[kudu-CR] WIP: Support non-voter in leader election

2017-09-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8142 ) Change subject: WIP: Support non-voter in leader election .. Patch Set 1: > Does this need to get merged into Alexey's patch? Yep.

[kudu-CR] WIP [consensus] introduce adding NON VOTER members

2017-09-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8138 ) Change subject: WIP [consensus] introduce adding NON_VOTER members .. Patch Set 2: > Curious how the client(s) will respond to seeing

[kudu-CR] WIP: Support non-voter in leader election

2017-09-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8142 ) Change subject: WIP: Support non-voter in leader election .. Patch Set 1: Does this need to get merged into Alexey's patch? -- To

[kudu-CR] WIP [consensus] introduce adding NON VOTER members

2017-09-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8138 ) Change subject: WIP [consensus] introduce adding NON_VOTER members .. Patch Set 2: Curious how the client(s) will respond to seeing a

[kudu-CR] [webui] Allow custom response codes and headers

2017-09-27 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8141 to look at the new patch set (#3). Change subject: [webui] Allow custom response codes and headers ..

[kudu-CR] python: pin to cython 0.26.1

2017-09-27 Thread Adar Dembo (Code Review)
Hello Jean-Daniel Cryans, Wes McKinney, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8155 to review the following change. Change subject: python: pin to cython 0.26.1 .. python: pin to

[kudu-CR] python: pin to cython 0.26.1

2017-09-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/8155 ) Change subject: python: pin to cython 0.26.1 .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] python: pin to cython 0.26.1

2017-09-27 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8155 ) Change subject: python: pin to cython 0.26.1 .. python: pin to cython 0.26.1 Some of our el6-based builds are running into an

[kudu-CR] [catalog manager] introduce replica selector

2017-09-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8161 Change subject: [catalog manager] introduce replica selector .. [catalog manager] introduce replica selector Introduced replica

[kudu-CR] [cluster itest util] fix typo in format string

2017-09-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8156 ) Change subject: [cluster_itest_util] fix typo in format string .. [cluster_itest_util] fix typo in format string Change-Id:

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-09-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: mvcc: allow tablet shutdown without completing txs .. Patch Set 15: IWYU failed but this is ready for review. -- To

[kudu-CR] master-test: fix another source of test flakiness

2017-09-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8160 ) Change subject: master-test: fix another source of test flakiness .. Patch Set 1: (1 comment)

[kudu-CR] master-test: fix another source of test flakiness

2017-09-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8160 ) Change subject: master-test: fix another source of test flakiness .. Patch Set 1: (1 comment)

[kudu-CR] [cluster itest util] fix typo in format string

2017-09-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8156 Change subject: [cluster_itest_util] fix typo in format string .. [cluster_itest_util] fix typo in format string Change-Id:

[kudu-CR] subprocess: Call should redirect stdout to stderr when stdout not requested

2017-09-27 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8157 to look at the new patch set (#2). Change subject: subprocess: Call should redirect stdout to stderr when stdout not requested

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-09-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: mvcc: allow tablet shutdown without completing txs .. Patch Set 15: This is one of the most tricky changes (if

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-09-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: mvcc: allow tablet shutdown without completing txs .. Patch Set 15: (3 comments)

[kudu-CR] master-test: deflake a test

2017-09-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8158 ) Change subject: master-test: deflake a test .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8158 To

[kudu-CR] [cluster itest util] fix typo in format string

2017-09-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8156 ) Change subject: [cluster_itest_util] fix typo in format string .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-09-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: mvcc: allow tablet shutdown without completing txs .. Patch Set 15: (6 comments)

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-09-27 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7439 to look at the new patch set (#15). Change subject: mvcc: allow tablet shutdown without completing txs

[kudu-CR] subprocess: Call should redirect stdout to stderr when stdout not requested

2017-09-27 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8157 to review the following change. Change subject: subprocess: Call should redirect stdout to stderr when stdout not requested

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-09-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: mvcc: allow tablet shutdown without completing txs .. Patch Set 15: (1 comment)

[kudu-CR] master-test: deflake a test

2017-09-27 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8158 to review the following change. Change subject: master-test: deflake a test .. master-test: deflake a test In this

[kudu-CR] master-test: fix another source of test flakiness

2017-09-27 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8160 to review the following change. Change subject: master-test: fix another source of test flakiness .. master-test:

[kudu-CR] subprocess: Call should redirect stdout to stderr when stdout not requested

2017-09-27 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8157 ) Change subject: subprocess: Call should redirect stdout to stderr when stdout not requested .. Removed reviewer Kudu Jenkins with

[kudu-CR] master-test: fix test-only TSAN data race

2017-09-27 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8159 to review the following change. Change subject: master-test: fix test-only TSAN data race .. master-test: fix

[kudu-CR] subprocess: Call should redirect stdout to stderr when stdout not requested

2017-09-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8157 ) Change subject: subprocess: Call should redirect stdout to stderr when stdout not requested .. Patch Set 2: Verified+1 Overriding

[kudu-CR] master-test: fix another source of test flakiness

2017-09-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8160 ) Change subject: master-test: fix another source of test flakiness .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-09-27 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7439 to look at the new patch set (#14). Change subject: mvcc: allow tablet shutdown without completing txs

[kudu-CR] [catalog manager] introduce replica selector

2017-09-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8161 ) Change subject: [catalog manager] introduce replica selector .. Removed reviewer Kudu Jenkins. -- To view, visit

[kudu-CR] master-test: fix test-only TSAN data race

2017-09-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8159 ) Change subject: master-test: fix test-only TSAN data race .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] master-test: fix test-only TSAN data race

2017-09-27 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8159 ) Change subject: master-test: fix test-only TSAN data race .. master-test: fix test-only TSAN data race

[kudu-CR] KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list

2017-09-27 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8041 ) Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list .. Patch Set 8: (6 comments)

[kudu-CR] KUDU-2055 [part 4]: Coalesce hole punch for LBM

2017-09-27 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8162 Change subject: KUDU-2055 [part 4]: Coalesce hole punch for LBM .. KUDU-2055 [part 4]: Coalesce hole punch for LBM This patch extends the

[kudu-CR] KUDU-2055 [part 2]: Add util to construct sorted disjoint interval list

2017-09-27 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, David Ribeiro Alves, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8041 to look at the new patch set (#8). Change subject: KUDU-2055 [part 2]: Add util to

[kudu-CR] master-test: deflake a test

2017-09-27 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8158 ) Change subject: master-test: deflake a test .. master-test: deflake a test In this test the master would periodically crash in

[kudu-CR] master-test: fix another source of test flakiness

2017-09-27 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8160 ) Change subject: master-test: fix another source of test flakiness .. master-test: fix another source of test flakiness This