[kudu-CR] KUDU-2262: allow Java client to retry if no master is a leader

Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9088 ) Change subject: KUDU-2262: allow Java client to retry if no master is a leader .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2270: Add a flag to control logging in RpczStore::LogTrace()

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9117 ) Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] Upgrade to tcmalloc 2.6.3 and enabled sized-deallocation

Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9108 ) Change subject: Upgrade to tcmalloc 2.6.3 and enabled sized-deallocation .. Upgrade to tcmalloc 2.6.3 and enabled

[kudu-CR] consensus: avoid extra thread wakeups for Peer::SignalRequest

Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9092 ) Change subject: consensus: avoid extra thread wakeups for Peer::SignalRequest .. consensus: avoid extra thread wakeups for

[kudu-CR] KUDU-2265 CA-signed server certs for non-leader masters

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9076 ) Change subject: KUDU-2265 CA-signed server certs for non-leader masters .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2262: allow Java client to retry if no master is a leader

Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9088 to look at the new patch set (#3). Change subject: KUDU-2262: allow Java client to retry if no master is a leader

[kudu-CR] KUDU-2270: Add a flag to control logging in RpczStore::LogTrace()

Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9117 to look at the new patch set (#2). Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace()

[kudu-CR] KUDU-2270: Add a flag to control logging in RpczStore::LogTrace()

Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9117 ) Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2191 (4/n): HMS Thrift client fault handling

Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8494 to look at the new patch set (#8). Change subject: KUDU-2191 (4/n): HMS Thrift client fault handling

[kudu-CR] KUDU-2191 (4/n): HMS Thrift client fault handling

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8494 ) Change subject: KUDU-2191 (4/n): HMS Thrift client fault handling .. Patch Set 8: (6 comments)

[kudu-CR] KUDU-2262: allow Java client to retry if no master is a leader

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9088 ) Change subject: KUDU-2262: allow Java client to retry if no master is a leader .. Patch Set 1: (8 comments) Just some nits on the

[kudu-CR] KUDU-2262: allow Java client to retry if no master is a leader

Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9088 ) Change subject: KUDU-2262: allow Java client to retry if no master is a leader .. Patch Set 4: (8 comments)

[kudu-CR] KUDU-2191 (4/n): HMS Thrift client fault handling

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8494 ) Change subject: KUDU-2191 (4/n): HMS Thrift client fault handling .. Patch Set 8: (4 comments)

[kudu-CR] consensus: avoid extra calls to protobuf SpaceUsed in the log cache

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9093 ) Change subject: consensus: avoid extra calls to protobuf SpaceUsed in the log cache .. Patch Set 2: (1 comment)

[kudu-CR] Bump Thrift to 0.11

Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9115 ) Change subject: Bump Thrift to 0.11 .. Bump Thrift to 0.11 Change-Id: I4e61c985a371524a5380613c4d03564de3caad50 Reviewed-on:

[kudu-CR] consensus: avoid extra thread wakeups for Peer::SignalRequest

David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9092 ) Change subject: consensus: avoid extra thread wakeups for Peer::SignalRequest .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] consensus: avoid extra calls to protobuf SpaceUsed in the log cache

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9093 ) Change subject: consensus: avoid extra calls to protobuf SpaceUsed in the log cache .. Patch Set 3: (1 comment)

[kudu-CR] consensus: avoid extra calls to protobuf SpaceUsed in the log cache

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9093 ) Change subject: consensus: avoid extra calls to protobuf SpaceUsed in the log cache .. Patch Set 4: Code-Review+1 -- To view, visit

[kudu-CR] [java] add test to reproduce KUDU-2267

Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9071 to look at the new patch set (#3). Change subject: [java] add test to reproduce KUDU-2267

[kudu-CR] KUDU-2262: allow Java client to retry if no master is a leader

Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9088 to look at the new patch set (#4). Change subject: KUDU-2262: allow Java client to retry if no master is a leader

[kudu-CR] KUDU-2262: allow Java client to retry if no master is a leader

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9088 ) Change subject: KUDU-2262: allow Java client to retry if no master is a leader .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8692 to look at the new patch set (#5). Change subject: KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

[kudu-CR] KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8692 ) Change subject: KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client .. Patch Set 4: (3 comments)

[kudu-CR] Upgrade to tcmalloc 2.6.3 and enabled sized-deallocation

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9108 ) Change subject: Upgrade to tcmalloc 2.6.3 and enabled sized-deallocation .. Patch Set 2: Code-Review+2 LGTM. Tests pass on macos 10.12.

[kudu-CR] KUDU-2265 CA-signed server certs for non-leader masters

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9076 ) Change subject: KUDU-2265 CA-signed server certs for non-leader masters .. KUDU-2265 CA-signed server certs for non-leader

[kudu-CR] consensus: avoid extra calls to protobuf SpaceUsed in the log cache

Hello Tidy Bot, Mike Percy, Dan Burkert, David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9093 to look at the new patch set (#4). Change subject: consensus: avoid extra calls to protobuf SpaceUsed in the log cache

[kudu-CR] fs: update default data dir group size

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8995 ) Change subject: fs: update default data dir group size .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] fs: update default data dir group size

Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8995 ) Change subject: fs: update default data dir group size .. fs: update default data dir group size This patch makes

[kudu-CR] KUDU-2270: Add a flag to control logging in RpczStore::LogTrace()

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9117 ) Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() .. Patch Set 1: (1 comment)

[kudu-CR] consensus: avoid extra calls to protobuf SpaceUsed in the log cache

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9093 ) Change subject: consensus: avoid extra calls to protobuf SpaceUsed in the log cache .. Patch Set 3: (1 comment)

[kudu-CR] consensus: avoid extra calls to protobuf SpaceUsed in the log cache

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9093 ) Change subject: consensus: avoid extra calls to protobuf SpaceUsed in the log cache .. Patch Set 3: Different perf timings on this

[kudu-CR] KUDU-2262: allow Java client to retry if no master is a leader

Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9088 ) Change subject: KUDU-2262: allow Java client to retry if no master is a leader .. KUDU-2262: allow Java client to retry if no master

[kudu-CR] KUDU-2262: allow Java client to retry if no master is a leader

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9088 ) Change subject: KUDU-2262: allow Java client to retry if no master is a leader .. Patch Set 4: Code-Review+1 -- To view, visit

[kudu-CR] env: properly use fdatasync on Linux

Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9128 to review the following change. Change subject: env: properly use fdatasync on Linux .. env: properly use fdatasync

[kudu-CR] design-docs: improve cfile.md

David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8860 ) Change subject: design-docs: improve cfile.md .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2262: allow Java client to retry if no master is a leader

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9088 ) Change subject: KUDU-2262: allow Java client to retry if no master is a leader .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [tests] de-flaking DontEvictIfRemainingConfigIsUnstable

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9126 Change subject: [tests] de-flaking DontEvictIfRemainingConfigIsUnstable .. [tests] de-flaking DontEvictIfRemainingConfigIsUnstable

[kudu-CR] env: properly use fdatasync on Linux

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9128 ) Change subject: env: properly use fdatasync on Linux .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1927: no half-baked responses on ConnectoToMaster

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9052 ) Change subject: KUDU-1927: no half-baked responses on ConnectoToMaster .. Patch Set 5: (2 comments)

[kudu-CR] [docs] Document how to recover from a majority failed tablet

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8402 ) Change subject: [docs] Document how to recover from a majority failed tablet .. Patch Set 6: (1 comment)

[kudu-CR] consensus: avoid extra calls to protobuf SpaceUsed in the log cache

Hello Tidy Bot, Mike Percy, Dan Burkert, David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9093 to look at the new patch set (#3). Change subject: consensus: avoid extra calls to protobuf SpaceUsed in the log cache

[kudu-CR] KUDU-2270: Add a flag to control logging in RpczStore::LogTrace()

Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9117 ) Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() .. KUDU-2270: Add a flag to control logging in

[kudu-CR] consensus: avoid extra calls to protobuf SpaceUsed in the log cache

Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9093 ) Change subject: consensus: avoid extra calls to protobuf SpaceUsed in the log cache .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-2270: Add a flag to control logging in RpczStore::LogTrace()

Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9117 ) Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8692 ) Change subject: KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client .. Patch Set 5: (12 comments)

[kudu-CR] env: properly use fdatasync on Linux

Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9128 ) Change subject: env: properly use fdatasync on Linux .. env: properly use fdatasync on Linux A previous commit attempted to make

[kudu-CR] consensus: avoid extra calls to protobuf SpaceUsed in the log cache

David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9093 ) Change subject: consensus: avoid extra calls to protobuf SpaceUsed in the log cache .. Patch Set 4: Code-Review+2 -- To view,

[kudu-CR] [java] add test to reproduce KUDU-2267

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9071 ) Change subject: [java] add test to reproduce KUDU-2267 .. Patch Set 3: (4 comments) lgtm, just a couple of nits

[kudu-CR] consensus: avoid extra calls to protobuf SpaceUsed in the log cache

Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9093 ) Change subject: consensus: avoid extra calls to protobuf SpaceUsed in the log cache .. consensus: avoid extra calls to protobuf

[kudu-CR] client: fix UBSAN error in failover calculation

Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9132 to review the following change. Change subject: client: fix UBSAN error in failover calculation .. client: fix UBSAN

[kudu-CR] KUDU-1865: Avoid some heap allocations in RPC paths

Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8895 ) Change subject: KUDU-1865: Avoid some heap allocations in RPC paths .. Patch Set 4: Thanks for the review. We need to re-evaluate the

[kudu-CR] KUDU-1927: no half-baked responses on ConnectToMaster

Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9052 to look at the new patch set (#6). Change subject: KUDU-1927: no half-baked responses on ConnectToMaster

[kudu-CR] KUDU-1927: no half-baked responses on ConnectToMaster

Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9052 to look at the new patch set (#7). Change subject: KUDU-1927: no half-baked responses on ConnectToMaster

[kudu-CR] KUDU-1927: no half-baked responses on ConnectToMaster

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9052 ) Change subject: KUDU-1927: no half-baked responses on ConnectToMaster .. Patch Set 7: (1 comment)

[kudu-CR] KUDU-1927: no half-baked responses on ConnectoToMaster

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9052 ) Change subject: KUDU-1927: no half-baked responses on ConnectoToMaster .. Patch Set 5: (2 comments)

[kudu-CR] KUDU-1927: no half-baked responses on ConnectoToMaster

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9052 ) Change subject: KUDU-1927: no half-baked responses on ConnectoToMaster .. Patch Set 5: (1 comment)

[kudu-CR] [java] add test to reproduce KUDU-2267

Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9071 ) Change subject: [java] add test to reproduce KUDU-2267 .. [java] add test to reproduce KUDU-2267 Currently, if a master has never

[kudu-CR] KUDU-1927: no half-baked responses on ConnectToMaster

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9052 ) Change subject: KUDU-1927: no half-baked responses on ConnectToMaster .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-1927: no half-baked responses on ConnectToMaster

Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9052 to look at the new patch set (#8). Change subject: KUDU-1927: no half-baked responses on ConnectToMaster

[kudu-CR] [java] add test to reproduce KUDU-2267

Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9071 ) Change subject: [java] add test to reproduce KUDU-2267 .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/9071/3//COMMIT_MSG

[kudu-CR] [java] add test to reproduce KUDU-2267

Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9071 to look at the new patch set (#4). Change subject: [java] add test to reproduce KUDU-2267

[kudu-CR] KUDU-1927: no half-baked responses on ConnectoToMaster

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9052 ) Change subject: KUDU-1927: no half-baked responses on ConnectoToMaster .. Patch Set 5: (1 comment)

[kudu-CR] [java] add test to reproduce KUDU-2267

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9071 ) Change subject: [java] add test to reproduce KUDU-2267 .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1927: no half-baked responses on ConnectoToMaster

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9052 ) Change subject: KUDU-1927: no half-baked responses on ConnectoToMaster .. Patch Set 5: (2 comments)

[kudu-CR] KUDU-1865: Avoid some heap allocations in RPC paths

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8895 ) Change subject: KUDU-1865: Avoid some heap allocations in RPC paths .. Patch Set 4: The code looks OK, but would be great to get some

[kudu-CR] KUDU-1927: no half-baked responses on ConnectoToMaster

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9052 ) Change subject: KUDU-1927: no half-baked responses on ConnectoToMaster .. Patch Set 5: (2 comments)

[kudu-CR] KUDU-1927: no half-baked responses on ConnectoToMaster

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9052 ) Change subject: KUDU-1927: no half-baked responses on ConnectoToMaster .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-1927: no half-baked responses on ConnectToMaster

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9052 ) Change subject: KUDU-1927: no half-baked responses on ConnectToMaster .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-1927: no half-baked responses on ConnectToMaster

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9052 ) Change subject: KUDU-1927: no half-baked responses on ConnectToMaster .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-1927: no half-baked responses on ConnectToMaster

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9052 ) Change subject: KUDU-1927: no half-baked responses on ConnectToMaster .. Patch Set 7: (1 comment)

[kudu-CR] KUDU-2265 CA-signed server certs for non-leader masters

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9076 ) Change subject: KUDU-2265 CA-signed server certs for non-leader masters .. Patch Set 7: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2270: Add a flag to control logging in RpczStore::LogTrace()

Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9117 Change subject: KUDU-2270: Add a flag to control logging in RpczStore::LogTrace() .. KUDU-2270: Add a flag to control logging in

[kudu-CR] rpc: micro-optimize delayed task handling

Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9048 ) Change subject: rpc: micro-optimize delayed task handling .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2265 CA-signed server certs for non-leader masters

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9076 ) Change subject: KUDU-2265 CA-signed server certs for non-leader masters .. Patch Set 6: (6 comments)

[kudu-CR] docs: fix number of number masters

Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9091 ) Change subject: docs: fix number of number masters .. Patch Set 3: (1 comment)

[kudu-CR] docs: fix number of number masters

Hello Alex Rodoni, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9091 to look at the new patch set (#4). Change subject: docs: fix number of number masters

[kudu-CR] docs: fix number of number masters

Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9091 ) Change subject: docs: fix number of number masters .. Patch Set 4: (7 comments)