[kudu-CR] KUDU-16: python client support for limits

2018-04-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9924 ) Change subject: KUDU-16: python client support for limits .. Patch Set 2: (1 comment)

[kudu-CR] WIP: use ExternalProject Add to define thirdparty deps

2018-04-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9931 ) Change subject: WIP: use ExternalProject_Add to define thirdparty deps .. Patch Set 1: (1 comment)

[kudu-CR] WIP: use ExternalProject Add to define thirdparty deps

2018-04-04 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9931 to review the following change. Change subject: WIP: use ExternalProject_Add to define thirdparty deps ..

[kudu-CR] KUDU-16: implement Java client limits

2018-04-04 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9926 to look at the new patch set (#2). Change subject: KUDU-16: implement Java client limits .. KUDU-16:

[kudu-CR] KUDU-16: implement Java client limits

2018-04-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9926 ) Change subject: KUDU-16: implement Java client limits .. Patch Set 2: (1 comment) Turns out extra bookkeeping was necessary.

[kudu-CR] KUDU-16: python client support for limits

2018-04-04 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9924 to look at the new patch set (#3). Change subject: KUDU-16: python client support for limits ..

[kudu-CR] KUDU-16: python client support for limits

2018-04-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9924 ) Change subject: KUDU-16: python client support for limits .. Patch Set 2: (1 comment)

[kudu-CR] WIP: support for running Java tests in dist-test

2018-04-04 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9932 Change subject: WIP: support for running Java tests in dist-test .. WIP: support for running Java tests in dist-test Probably not worth a

[kudu-CR] WIP: use ExternalProject Add to define thirdparty deps

2018-04-04 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9931 ) Change subject: WIP: use ExternalProject_Add to define thirdparty deps .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2135 (part 2): don't use previously failed disks

2018-04-04 Thread Andrew Wong (Code Review)
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/7270 ) Change subject: KUDU-2135 (part 2): don't use previously failed disks .. Abandoned no longer in scope for disk failure handling -- To view, visit

[kudu-CR] [spark]KUDU-2371: Add KuduWriteOptions class and ignoreNull option

2018-04-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9834 ) Change subject: [spark]KUDU-2371: Add KuduWriteOptions class and ignoreNull option .. Patch Set 4: (3 comments)

[kudu-CR] KUDU-2351 Add IP/port for Recv() failure

2018-04-04 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9818 ) Change subject: KUDU-2351 Add IP/port for Recv() failure .. Patch Set 10: (9 comments)

[kudu-CR] KUDU-2351 Add IP/port for Recv() failure

2018-04-04 Thread Attila Bukor (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9818 to look at the new patch set (#10). Change subject: KUDU-2351 Add IP/port for Recv() failure

[kudu-CR] KUDU-16: python client support for limits

2018-04-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9924 ) Change subject: KUDU-16: python client support for limits .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-16: python client support for limits

2018-04-04 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9924 to look at the new patch set (#4). Change subject: KUDU-16: python client support for limits ..

[kudu-CR] KUDU-2232. java: Remove deprecated call from KuduTable

2018-04-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8749 ) Change subject: KUDU-2232. java: Remove deprecated call from KuduTable .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-16: python client support for limits

2018-04-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9924 ) Change subject: KUDU-16: python client support for limits .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2135 (part 1): add persistent disk states

2018-04-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8048 ) Change subject: KUDU-2135 (part 1): add persistent disk states .. Patch Set 7: (2 comments) Should this be abandoned? I think it was

[kudu-CR] [docs] Add note for CM-based multi-master migration

2018-04-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9784 ) Change subject: [docs] Add note for CM-based multi-master migration .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2135 (part 2): don't use previously failed disks

2018-04-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/7270 ) Change subject: KUDU-2135 (part 2): don't use previously failed disks .. Patch Set 30: Should this also be abandoned? -- To view,

[kudu-CR] [docs] Add note for CM-based multi-master migration

2018-04-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9784 ) Change subject: [docs] Add note for CM-based multi-master migration .. [docs] Add note for CM-based multi-master migration The

[kudu-CR] striped64: reduce size from 192 to 16 bytes

2018-04-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9732 ) Change subject: striped64: reduce size from 192 to 16 bytes .. striped64: reduce size from 192 to 16 bytes Striped64 is the type backing

[kudu-CR] KUDU-16: python client support for limits

2018-04-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9924 ) Change subject: KUDU-16: python client support for limits .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.7.x) KUDU-2364 Add extra check in ksck for tserver ID

2018-04-04 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9855 to look at the new patch set (#2). Change subject: KUDU-2364 Add extra check in ksck for tserver ID

[kudu-CR] [docs] Add warning about unsafe-change-config

2018-04-04 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9906 ) Change subject: [docs] Add warning about unsafe-change-config .. Patch Set 2: (4 comments)

[kudu-CR] [docs] Add warning about unsafe-change-config

2018-04-04 Thread Attila Bukor (Code Review)
Hello Will Berkeley, Alex Rodoni, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9906 to look at the new patch set (#2). Change subject: [docs] Add warning about unsafe-change-config

[kudu-CR] WIP KUDU-16 pt 3: add per-scan-token limits

2018-04-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9923 ) Change subject: WIP KUDU-16 pt 3: add per-scan-token limits .. Patch Set 1: (1 comment)

[kudu-CR] WIP KUDU-16 pt 4: python client support for limits

2018-04-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9924 ) Change subject: WIP KUDU-16 pt 4: python client support for limits .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-2351 Add IP/port for Recv() failure

2018-04-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9818 ) Change subject: KUDU-2351 Add IP/port for Recv() failure .. Patch Set 10: (1 comment)

[kudu-CR] KUDU-16: remove Java warnings wrt scanner limits

2018-04-04 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9926 Change subject: KUDU-16: remove Java warnings wrt scanner limits .. KUDU-16: remove Java warnings wrt scanner limits With the

[kudu-CR] KUDU-16: remove Java warnings wrt scanner limits

2018-04-04 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9926 ) Change subject: KUDU-16: remove Java warnings wrt scanner limits .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-16: python client support for limits

2018-04-04 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9924 ) Change subject: KUDU-16: python client support for limits .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-16: python client support for limits

2018-04-04 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9924 to look at the new patch set (#2). Change subject: KUDU-16: python client support for limits ..

[kudu-CR] [docs] Add warning about unsafe-change-config

2018-04-04 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9906 ) Change subject: [docs] Add warning about unsafe-change-config .. Patch Set 2: (3 comments)

[kudu-CR] [spark]KUDU-2371: Add KuduWriteOptions class and ignoreNull option

2018-04-04 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9834 ) Change subject: [spark]KUDU-2371: Add KuduWriteOptions class and ignoreNull option .. Patch Set 4: (4 comments) Looking pretty good

[kudu-CR] WIP KUDU-16 pt 3: add per-scan-token limits

2018-04-04 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9923 Change subject: WIP KUDU-16 pt 3: add per-scan-token limits .. WIP KUDU-16 pt 3: add per-scan-token limits This patch implements

[kudu-CR] WIP KUDU-16 pt 4: python client support for limits

2018-04-04 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9924 Change subject: WIP KUDU-16 pt 4: python client support for limits .. WIP KUDU-16 pt 4: python client support for limits This patch