[kudu-CR] [util] Add ParseStringsWithScheme in net util

2018-11-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11843 ) Change subject: [util] Add ParseStringsWithScheme in net_util .. Patch Set 2: (3 comments)

[kudu-CR] [sentry] add AuthzProvider

2018-11-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 7: (7 comments) Mostly just a few nits at this point.

[kudu-CR] [compaction] Cleanup of compaction policy code

2018-11-01 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11827 to look at the new patch set (#4). Change subject: [compaction] Cleanup of compaction policy code

[kudu-CR] [util] Add ParseStringsWithScheme in net util

2018-11-01 Thread Hao Hao (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11843 to look at the new patch set (#3). Change subject: [util] Add ParseStringsWithScheme in net_util

[kudu-CR] [util] Add ParseStringsWithScheme in net util

2018-11-01 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11843 ) Change subject: [util] Add ParseStringsWithScheme in net_util .. Patch Set 3: (3 comments)

[kudu-CR] [util] Add ParseStringsWithScheme in net util

2018-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11843 ) Change subject: [util] Add ParseStringsWithScheme in net_util .. Patch Set 3: Code-Review+2 (1 comment)

[kudu-CR] [sentry] add AuthzProvider

2018-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/11659 To

[kudu-CR] [compaction] Cleanup of compaction policy code

2018-11-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11827 ) Change subject: [compaction] Cleanup of compaction policy code .. Patch Set 3: (10 comments)

[kudu-CR] revert change to exactly once writes-itest

2018-11-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11836 ) Change subject: revert change to exactly_once_writes-itest .. Patch Set 2: (1 comment)

[kudu-CR] [sentry] add AuthzProvider

2018-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 8: Code-Review+1 (3 comments)

[kudu-CR] KUDU-1918 Prevent hijacking of scanner IDs

2018-11-01 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#4) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/6348 ) Change subject: KUDU-1918 Prevent hijacking of scanner IDs .. KUDU-1918 Prevent hijacking

[kudu-CR] KUDU-1918 Prevent hijacking of scanner IDs

2018-11-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6348 ) Change subject: KUDU-1918 Prevent hijacking of scanner IDs .. Patch Set 4: (6 comments)

[kudu-CR] [sentry] add AuthzProvider

2018-11-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 10: Code-Review+1 (2 comments)

[kudu-CR] [examples] Add basic Spark example (scala)

2018-11-01 Thread Mitch Barnett (Code Review)
Mitch Barnett has posted comments on this change. ( http://gerrit.cloudera.org:8080/11788 ) Change subject: [examples] Add basic Spark example (scala) .. Patch Set 11: (13 comments)

[kudu-CR] [sentry] add AuthzProvider

2018-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 10: Code-Review+2 Looks good to me; maybe Andrew has some more feedback. --

[kudu-CR] [sentry] add AuthzProvider

2018-11-01 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 10: (3 comments)

[kudu-CR] [sentry] add AuthzProvider

2018-11-01 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11659 to look at the new patch set (#10). Change subject: [sentry] add AuthzProvider

[kudu-CR] [sentry] add AuthzProvider

2018-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 10: -Code-Review (2 comments)

[kudu-CR] [examples] Add basic Spark example (scala)

2018-11-01 Thread Mitch Barnett (Code Review)
Hello Will Berkeley, Attila Bukor, Kudu Jenkins, Adar Dembo, Grant Henke, Greg Solovyev, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11788 to look at the new patch set (#11). Change subject: [examples] Add basic Spark example (scala)

[kudu-CR] [sentry] add AuthzProvider

2018-11-01 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11659 to look at the new patch set (#9). Change subject: [sentry] add AuthzProvider

[kudu-CR] KUDU-1918 Prevent hijacking of scanner IDs

2018-11-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6348 ) Change subject: KUDU-1918 Prevent hijacking of scanner IDs .. Patch Set 4: (1 comment)

[kudu-CR] (03/05) delta store: support iteration with snap to exclude

2018-11-01 Thread Adar Dembo (Code Review)
Hello Mike Percy, David Ribeiro Alves, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11858 to look at the new patch set (#2). Change subject: (03/05) delta_store: support iteration with snap_to_exclude

[kudu-CR] WIP: DeltaApplier changes

2018-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has abandoned this change. ( http://gerrit.cloudera.org:8080/11139 ) Change subject: WIP: DeltaApplier changes .. Abandoned Revamped this in a new change. -- To view, visit http://gerrit.cloudera.org:8080/11139 To

[kudu-CR] deltamemstore: support iteration with snap to exclude

2018-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has abandoned this change. ( http://gerrit.cloudera.org:8080/11029 ) Change subject: deltamemstore: support iteration with snap_to_exclude .. Abandoned This ended up being more complicated and I wrote a new series

[kudu-CR] delta store: support iteration with snap to exclude

2018-11-01 Thread Adar Dembo (Code Review)
Hello Mike Percy, David Ribeiro Alves, Grant Henke, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11858 to review the following change. Change subject: delta_store: support iteration with snap_to_exclude

[kudu-CR] WIP: DeltaFileIterator snap to exclude

2018-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has abandoned this change. ( http://gerrit.cloudera.org:8080/11138 ) Change subject: WIP: DeltaFileIterator snap_to_exclude .. Abandoned Revamped this in a new change. -- To view, visit

[kudu-CR] [util] Add ParseStringsWithScheme in net util

2018-11-01 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11843 ) Change subject: [util] Add ParseStringsWithScheme in net_util .. [util] Add ParseStringsWithScheme in net_util This commit adds a

[kudu-CR] [sentry] add AuthzProvider

2018-11-01 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11659 to look at the new patch set (#8). Change subject: [sentry] add AuthzProvider

[kudu-CR] [sentry] add AuthzProvider

2018-11-01 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 8: (6 comments)

[kudu-CR] (02/05) delta store: convert DeltaIterator::PrepareBatch flags into bitfield

2018-11-01 Thread Adar Dembo (Code Review)
Hello Mike Percy, David Ribeiro Alves, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11857 to look at the new patch set (#2). Change subject: (02/05) delta_store: convert DeltaIterator::PrepareBatch flags into

[kudu-CR] (01/05) delta store: avoid copying deleted row data in ApplyUpdates

2018-11-01 Thread Adar Dembo (Code Review)
Hello Mike Percy, David Ribeiro Alves, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11856 to look at the new patch set (#2). Change subject: (01/05) delta_store: avoid copying deleted row data in ApplyUpdates

[kudu-CR] (05/05) delta applier: support for diff scan style iteration

2018-11-01 Thread Adar Dembo (Code Review)
Hello Mike Percy, David Ribeiro Alves, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11860 to look at the new patch set (#2). Change subject: (05/05) delta_applier: support for diff scan style iteration

[kudu-CR] (04/05) delta store: support iteration with is deleted virtual column

2018-11-01 Thread Adar Dembo (Code Review)
Hello Mike Percy, David Ribeiro Alves, Kudu Jenkins, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11859 to look at the new patch set (#2). Change subject: (04/05) delta_store: support iteration with is_deleted virtual column

[kudu-CR] [sentry] add AuthzProvider

2018-11-01 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 10: (2 comments)

[kudu-CR] [sentry] add AuthzProvider

2018-11-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 11: Code-Review+1 (2 comments) Sorry, a couple small nits and LGTM.

[kudu-CR] [sentry] add AuthzProvider

2018-11-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 11: (1 comment)

[kudu-CR] [sentry] add AuthzProvider

2018-11-01 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 11: (1 comment)

[kudu-CR] [sentry] add AuthzProvider

2018-11-01 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 11: (1 comment)

[kudu-CR] KUDU-1918 Prevent hijacking of scanner IDs

2018-11-01 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#6) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/6348 ) Change subject: KUDU-1918 Prevent hijacking of scanner IDs .. KUDU-1918 Prevent hijacking

[kudu-CR] KUDU-1918 Prevent hijacking of scanner IDs

2018-11-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6348 ) Change subject: KUDU-1918 Prevent hijacking of scanner IDs .. Patch Set 5: Fixed IWYU -- To view, visit

[kudu-CR] [sentry] add AuthzProvider

2018-11-01 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11659 to look at the new patch set (#11). Change subject: [sentry] add AuthzProvider

[kudu-CR] KUDU-1918 Prevent hijacking of scanner IDs

2018-11-01 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#5) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/6348 ) Change subject: KUDU-1918 Prevent hijacking of scanner IDs .. KUDU-1918 Prevent hijacking

[kudu-CR] KUDU-1918 Prevent hijacking of scanner IDs

2018-11-01 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/6348 ) Change subject: KUDU-1918 Prevent hijacking of scanner IDs .. Patch Set 5: (1 comment)

[kudu-CR] deltas: add SelectUpdates iterator method

2018-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has abandoned this change. ( http://gerrit.cloudera.org:8080/11137 ) Change subject: deltas: add SelectUpdates iterator method .. Abandoned Ended up merging this into another change, because it made more sense to do

[kudu-CR] delta store: avoid copying deleted row data in ApplyUpdates

2018-11-01 Thread Adar Dembo (Code Review)
Hello Mike Percy, David Ribeiro Alves, Grant Henke, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11856 to review the following change. Change subject: delta_store: avoid copying deleted row data in ApplyUpdates

[kudu-CR] delta store: support iteration with is deleted virtual column

2018-11-01 Thread Adar Dembo (Code Review)
Hello Mike Percy, David Ribeiro Alves, Grant Henke, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11859 to review the following change. Change subject: delta_store: support iteration with is_deleted virtual column

[kudu-CR] delta applier: support for diff scan style iteration

2018-11-01 Thread Adar Dembo (Code Review)
Hello Mike Percy, David Ribeiro Alves, Grant Henke, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11860 to review the following change. Change subject: delta_applier: support for diff scan style iteration

[kudu-CR] delta store: convert DeltaIterator::PrepareBatch flags into bitfield

2018-11-01 Thread Adar Dembo (Code Review)
Hello Mike Percy, David Ribeiro Alves, Grant Henke, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11857 to review the following change. Change subject: delta_store: convert DeltaIterator::PrepareBatch flags into bitfield

[kudu-CR] [sentry] add AuthzProvider

2018-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 7: (1 comment)

[kudu-CR] [util] Add ParseStringsWithScheme in net util

2018-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11843 ) Change subject: [util] Add ParseStringsWithScheme in net_util .. Patch Set 3: Code-Review+1 -- To view, visit

[kudu-CR] [sentry] add AuthzProvider

2018-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 7: (1 comment)

[kudu-CR] [compaction] Cleanup of compaction policy code

2018-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11827 ) Change subject: [compaction] Cleanup of compaction policy code .. Patch Set 5: Code-Review+1 (1 comment)

[kudu-CR](refs/meta/config) Change e-mail notification recipient to reviews@kudu.apache.org

2018-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11840 ) Change subject: Change e-mail notification recipient to reviews@kudu.apache.org .. Patch Set 3: Oops, I pushed to refs/meta/config

[kudu-CR](refs/meta/config) Change e-mail notification recipient to reviews@kudu.apache.org

2018-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11840 ) Change subject: Change e-mail notification recipient to reviews@kudu.apache.org .. Change e-mail notification recipient to

[kudu-CR](refs/meta/config) Change e-mail notification recipient to reviews@kudu.apache.org

2018-11-01 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11840 ) Change subject: Change e-mail notification recipient to reviews@kudu.apache.org .. Patch Set 3: Verified+1 Code-Review+2 Carrying

[kudu-CR] [examples] Add basic Spark example (scala)

2018-11-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11788 ) Change subject: [examples] Add basic Spark example (scala) .. Patch Set 10: (15 comments) I tested this locally with a multimaster

[kudu-CR] [sentry] add AuthzProvider

2018-11-01 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 7: (9 comments)

[kudu-CR] [compaction] Cleanup of compaction policy code

2018-11-01 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11827 to look at the new patch set (#5). Change subject: [compaction] Cleanup of compaction policy code

[kudu-CR] [sentry] add AuthzProvider

2018-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 7: (7 comments)

[kudu-CR](refs/meta/config) Change e-mail notification recipient to reviews@kudu.apache.org

2018-11-01 Thread Adar Dembo (Code Review)
Hello Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11840 to look at the new patch set (#3). Change subject: Change e-mail notification recipient to reviews@kudu.apache.org

[kudu-CR] [sentry] add AuthzProvider

2018-11-01 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11659 ) Change subject: [sentry] add AuthzProvider .. Patch Set 7: (2 comments)