[kudu-CR] KUDU-2612: propagate commit timestamp (C++ client)

2021-04-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17345 ) Change subject: KUDU-2612: propagate commit timestamp (C++ client) .. Patch Set 1: Verified+1 unrelated flakes in: *

[kudu-CR] KUDU-2612: propagate commit timestamp (C++ client)

2021-04-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-2612: propagate commit timestamp (C++ client) .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17345 To

[kudu-CR] KUDU-2612: propagate commit timestamp (C++ client)

2021-04-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17345 ) Change subject: KUDU-2612: propagate commit timestamp (C++ client) .. Patch Set 2: Verified+1 unrelated test failures: *

[kudu-CR] KUDU-2612: propagate commit timestamp (C++ client)

2021-04-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17345 ) Change subject: KUDU-2612: propagate commit timestamp (C++ client) .. KUDU-2612: propagate commit timestamp (C++ client) With

[kudu-CR] KUDU-2612: propagate commit timestamp (C++ client)

2021-04-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-2612: propagate commit timestamp (C++ client) .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17345 To

[kudu-CR] [client] retry master RPCs on network errors

2021-04-27 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17343 to look at the new patch set (#2). Change subject: [client] retry master RPCs on network errors

[kudu-CR] [client] retry master RPCs on network errors

2021-04-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17343 ) Change subject: [client] retry master RPCs on network errors .. Patch Set 2: (6 comments)

[kudu-CR] KUDU-2612: propagate commit timestamp (C++ client)

2021-04-27 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17345 to look at the new patch set (#2). Change subject: KUDU-2612: propagate commit timestamp (C++ client)

[kudu-CR] KUDU-2612: propagate commit timestamp (C++ client)

2021-04-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17345 ) Change subject: KUDU-2612: propagate commit timestamp (C++ client) .. Patch Set 1: (2 comments)

[kudu-CR] [hms] KUDU-1884 Add support for custom SASL protocol name

2021-04-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17350 ) Change subject: [hms] KUDU-1884 Add support for custom SASL protocol name .. Patch Set 1: (1 comment)

[kudu-CR] [client] retry master RPCs on network errors

2021-04-27 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17343 ) Change subject: [client] retry master RPCs on network errors .. Patch Set 1: (1 comment) The intent of the change makes sense.

[kudu-CR] KUDU-2612: propagate commit timestamp (C++ client)

2021-04-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17345 ) Change subject: KUDU-2612: propagate commit timestamp (C++ client) .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2612: propagate commit timestamp (C++ client)

2021-04-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17345 ) Change subject: KUDU-2612: propagate commit timestamp (C++ client) .. Patch Set 1: Code-Review+2 (2 comments) Thanks for making this

[kudu-CR] [security] set minimum TLS protocol version to TSLv1.2

2021-04-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17268 ) Change subject: [security] set minimum TLS protocol version to TSLv1.2 .. Patch Set 3: Code-Review-1 After some offline discussion,

[kudu-CR] [security] set minimum TLS protocol version to TSLv1.2

2021-04-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17268 ) Change subject: [security] set minimum TLS protocol version to TSLv1.2 .. Patch Set 3: Code-Review-2 -- To view, visit

[kudu-CR] [client] retry master RPCs on network errors

2021-04-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17343 ) Change subject: [client] retry master RPCs on network errors .. Patch Set 1: (5 comments)

[kudu-CR] [hms] KUDU-1884 Add support for custom SASL protocol name

2021-04-27 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17350 Change subject: [hms] KUDU-1884 Add support for custom SASL protocol name .. [hms] KUDU-1884 Add support for custom SASL protocol name

[kudu-CR] [hms] KUDU-1884 Add support for custom SASL protocol name

2021-04-27 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17350 ) Change subject: [hms] KUDU-1884 Add support for custom SASL protocol name .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [hms] KUDU-1884 Add support for custom SASL protocol name

2021-04-27 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17350 ) Change subject: [hms] KUDU-1884 Add support for custom SASL protocol name .. Patch Set 1: (1 comment)

[kudu-CR] [hms] KUDU-1884 Add support for custom SASL protocol name

2021-04-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17350 ) Change subject: [hms] KUDU-1884 Add support for custom SASL protocol name .. Patch Set 1: (1 comment)

[kudu-CR] [hms] KUDU-1884 Add support for custom SASL protocol name

2021-04-27 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17350 ) Change subject: [hms] KUDU-1884 Add support for custom SASL protocol name .. [hms] KUDU-1884 Add support for custom SASL

[kudu-CR] [hms] KUDU-1884 Add support for custom SASL protocol name

2021-04-27 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [hms] KUDU-1884 Add support for custom SASL protocol name .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17350 To

[kudu-CR] wip

2021-04-27 Thread Grant Henke (Code Review)
Grant Henke has abandoned this change. ( http://gerrit.cloudera.org:8080/17353 ) Change subject: wip .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/17353 To unsubscribe, visit

[kudu-CR] [thirdparty] Force Boost to use /dev/random for uuid

2021-04-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17354 ) Change subject: [thirdparty] Force Boost to use /dev/random for uuid .. Patch Set 2: (1 comment)

[kudu-CR] [client] retry master RPCs on network errors

2021-04-27 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: [client] retry master RPCs on network errors .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/17343 To unsubscribe,

[kudu-CR] [hms] KUDU-1884 Add support for custom SASL protocol name

2021-04-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17350 ) Change subject: [hms] KUDU-1884 Add support for custom SASL protocol name .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] [thirdparty] Force Boost to use /dev/random for uuid

2021-04-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17354 ) Change subject: [thirdparty] Force Boost to use /dev/random for uuid .. Patch Set 2: (5 comments)

[kudu-CR] [thirdparty] Force Boost to use /dev/random for uuid

2021-04-27 Thread Grant Henke (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17354 to look at the new patch set (#3). Change subject: [thirdparty] Force Boost to use /dev/random for uuid

[kudu-CR] [thirdparty] Force Boost to use /dev/random for uuid

2021-04-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17354 ) Change subject: [thirdparty] Force Boost to use /dev/random for uuid .. Patch Set 2: (5 comments)

[kudu-CR] [thirdparty] Force Boost to use /dev/random for uuid

2021-04-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17354 ) Change subject: [thirdparty] Force Boost to use /dev/random for uuid .. Patch Set 2: (1 comment)

[kudu-CR] [hms] KUDU-1884 Add support for custom SASL protocol name

2021-04-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17350 ) Change subject: [hms] KUDU-1884 Add support for custom SASL protocol name .. Patch Set 4: Verified+1 Code-Review+2 -- To view, visit

[kudu-CR] [client] retry master RPCs on network errors

2021-04-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17343 ) Change subject: [client] retry master RPCs on network errors .. Patch Set 5: Code-Review+2 (1 comment)

[kudu-CR] [client] retry master RPCs on network errors

2021-04-27 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17343 ) Change subject: [client] retry master RPCs on network errors .. [client] retry master RPCs on network errors

[kudu-CR] [client] retry master RPCs on network errors

2021-04-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17343 ) Change subject: [client] retry master RPCs on network errors .. Patch Set 6: (1 comment) Oops clicked submit instead of send.

[kudu-CR] [client] retry master RPCs on network errors

2021-04-27 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17343 to look at the new patch set (#3). Change subject: [client] retry master RPCs on network errors

[kudu-CR] [hms] KUDU-1884 Add support for custom SASL protocol name

2021-04-27 Thread Grant Henke (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17350 to look at the new patch set (#3). Change subject: [hms] KUDU-1884 Add support for custom SASL protocol name

[kudu-CR] [hms] KUDU-1884 Add support for custom SASL protocol name

2021-04-27 Thread Grant Henke (Code Review)
Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17350 to look at the new patch set (#4). Change subject: [hms] KUDU-1884 Add support for custom SASL protocol name

[kudu-CR] [client] retry master RPCs on network errors

2021-04-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17343 ) Change subject: [client] retry master RPCs on network errors .. Patch Set 5: Verified+1 Test failures were the known flake of

[kudu-CR] [hms] KUDU-1884 Add support for custom SASL protocol name

2021-04-27 Thread Grant Henke (Code Review)
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17350 to look at the new patch set (#2). Change subject: [hms] KUDU-1884 Add support for custom SASL protocol name

[kudu-CR] [doc] KUDU-2181 Update Migrating to Multiple Masters documentation

2021-04-27 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17352 to look at the new patch set (#2). Change subject: [doc] KUDU-2181 Update Migrating to Multiple Masters documentation

[kudu-CR] [doc] KUDU-2181 Update Migrating to Multiple Masters documentation

2021-04-27 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17352 to look at the new patch set (#3). Change subject: [doc] KUDU-2181 Update Migrating to Multiple Masters documentation

[kudu-CR] [client] retry master RPCs on network errors

2021-04-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17343 ) Change subject: [client] retry master RPCs on network errors .. Patch Set 3: Verified+1 (3 comments) Overall looks good, but there

[kudu-CR] [doc] KUDU-2181 Update Migrating to Multiple Masters documentation

2021-04-27 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17352 Change subject: [doc] KUDU-2181 Update Migrating to Multiple Masters documentation .. [doc] KUDU-2181 Update Migrating to Multiple

[kudu-CR] [client] retry master RPCs on network errors

2021-04-27 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17343 ) Change subject: [client] retry master RPCs on network errors .. Patch Set 5: > Patch Set 3: Verified+1 > > (3 comments) > > Overall

[kudu-CR] [client] retry master RPCs on network errors

2021-04-27 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17343 to look at the new patch set (#5). Change subject: [client] retry master RPCs on network errors

[kudu-CR] [client] retry master RPCs on network errors

2021-04-27 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17343 to look at the new patch set (#4). Change subject: [client] retry master RPCs on network errors

[kudu-CR] [hms] KUDU-1884 Add support for custom SASL protocol name

2021-04-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17350 ) Change subject: [hms] KUDU-1884 Add support for custom SASL protocol name .. Patch Set 1: (1 comment)

[kudu-CR] [hms] KUDU-1884 Add support for custom SASL protocol name

2021-04-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17350 ) Change subject: [hms] KUDU-1884 Add support for custom SASL protocol name .. Patch Set 3: Code-Review+2 (1 comment)

[kudu-CR] [thirdparty] Force Boost to use /dev/random for uuid

2021-04-27 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17354 to look at the new patch set (#2). Change subject: [thirdparty] Force Boost to use /dev/random for uuid ..

[kudu-CR] [thirdparty] Force Boost to use /dev/random for uuid

2021-04-27 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17354 Change subject: [thirdparty] Force Boost to use /dev/random for uuid .. [thirdparty] Force Boost to use /dev/random for uuid This patch

[kudu-CR] wip

2021-04-27 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17353 Change subject: wip .. wip Change-Id: I7e749b1133363c9f924b7c3493d3250db073c1f2 --- M thirdparty/build-definitions.sh 1 file changed, 7