[kudu-CR] KUDU-1586. consensus: always send at least one op

2016-08-29 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4168 to review the following change. Change subject: KUDU-1586. consensus: always send at least one op .. KUDU-1586.

[kudu-CR] KUDU-1586. consensus: always send at least one op

2016-08-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1586. consensus: always send at least one op .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3146/ -- To view, visit

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-29 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 15: (1 comment)

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-08-29 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4133 to look at the new patch set (#4). Change subject: Cleanup/refactor tracking of consensus watermarks ..

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-08-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/3145/ -- To view, visit

[kudu-CR] tool: port log-dump

2016-08-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: port log-dump .. Patch Set 1: Code lgtm. Can you add this to the release note with a pointer to 'kudu wal dump' and 'kudu tablet dump_wals'? -- To view,

[kudu-CR] KUDU-1231. Add "unlock" flag for experimental and unsafe flags

2016-08-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1231. Add "unlock" flag for experimental and unsafe flags .. KUDU-1231. Add "unlock" flag for experimental and unsafe flags This adds two new flags:

[kudu-CR] KUDU-1231. Add "unlock" flag for experimental and unsafe flags

2016-08-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1231. Add "unlock" flag for experimental and unsafe flags .. Patch Set 9: Verified+1 Hit a jenkins bug in the lint build (but previous lint builds passed)

[kudu-CR] Predicate evaluation pushdown

2016-08-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 7: (31 comments) http://gerrit.cloudera.org:8080/#/c/3990/7/src/kudu/cfile/binary_plain_block.cc File

[kudu-CR] tool: port log-dump

2016-08-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: port log-dump .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3144/ -- To view, visit http://gerrit.cloudera.org:8080/4167 To

[kudu-CR] KUDU-1231. Add "unlock" flag for experimental and unsafe flags

2016-08-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1231. Add "unlock" flag for experimental and unsafe flags .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4100 To

[kudu-CR] KUDU-1231. Add "unlock" flag for experimental and unsafe flags

2016-08-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1231. Add "unlock" flag for experimental and unsafe flags .. Patch Set 9: Build Started http://104.196.14.100/job/kudu-gerrit/3143/ -- To view, visit

[kudu-CR] KUDU-1231. Add "unlock" flag for experimental and unsafe flags

2016-08-29 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4100 to look at the new patch set (#9). Change subject: KUDU-1231. Add "unlock" flag for experimental and unsafe flags

[kudu-CR] Inlined dispatch for predicate evaluation

2016-08-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3142/ -- To view, visit

[kudu-CR] Inlined dispatch for predicate evaluation

2016-08-29 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4164 to look at the new patch set (#2). Change subject: Inlined dispatch for predicate evaluation .. Inlined dispatch

[kudu-CR] [docs] added Kudu version into the doxygen footer

2016-08-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [docs] added Kudu version into the doxygen footer .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/4165/1/CMakeLists.txt File CMakeLists.txt:

[kudu-CR] [docs] added Kudu version into the doxygen footer

2016-08-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [docs] added Kudu version into the doxygen footer .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3141/ -- To view, visit

[kudu-CR] [docs] added Kudu version into the doxygen footer

2016-08-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#2). Change subject: [docs] added Kudu version into the doxygen footer .. [docs] added Kudu version into the doxygen footer Added information on the Kudu source version into the HTML

[kudu-CR] [docs] added Kudu version into the doxygen footer

2016-08-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [docs] added Kudu version into the doxygen footer .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3140/ -- To view, visit

[kudu-CR] Inlined dispatch for predicate evaluation

2016-08-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3139/ -- To view, visit

[kudu-CR] Inlined dispatch for predicate evaluation

2016-08-29 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4164 Change subject: Inlined dispatch for predicate evaluation .. Inlined dispatch for predicate evaluation In order to evaluate a predicate,

[kudu-CR] compaction policy: fix bound calculation

2016-08-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: compaction_policy: fix bound calculation .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4152 To unsubscribe, visit

[kudu-CR] KUDU-1048 master should show versions of tservers, version summary

2016-08-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1048 master should show versions of tservers, version summary .. KUDU-1048 master should show versions of tservers, version summary This patch adds

[kudu-CR] KUDU-1048 master should show versions of tservers, version summary

2016-08-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1048 master should show versions of tservers, version summary .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4104 To

[kudu-CR] KUDU-1231. Add "unlock" flag for experimental and unsafe flags

2016-08-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1231. Add "unlock" flag for experimental and unsafe flags .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4100 To

[kudu-CR] tool: port cfile-dump to 'kudu fs dump cfile'

2016-08-29 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: tool: port cfile-dump to 'kudu fs dump_cfile' .. tool: port cfile-dump to 'kudu fs dump_cfile' Some non-cosmetic changes: - I changed the block_id

[kudu-CR] KUDU-1231. Add "unlock" flag for experimental and unsafe flags

2016-08-29 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4100 to look at the new patch set (#8). Change subject: KUDU-1231. Add "unlock" flag for experimental and unsafe flags

[kudu-CR] KUDU-1231. Add "unlock" flag for experimental and unsafe flags

2016-08-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1231. Add "unlock" flag for experimental and unsafe flags .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/3135/ -- To view, visit

[kudu-CR] KUDU-1231. Add "unlock" flag for experimental and unsafe flags

2016-08-29 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4100 to look at the new patch set (#7). Change subject: KUDU-1231. Add "unlock" flag for experimental and unsafe flags

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 23: Build Started http://104.196.14.100/job/kudu-gerrit/3136/ -- To view, visit

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-29 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#23). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode ..

[kudu-CR] tool: split up action descriptions

2016-08-29 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: tool: split up action descriptions .. tool: split up action descriptions With ksck we have a use case for "short" and "long" action descriptions: the

[kudu-CR] KUDU-1231. Add "unlock" flag for experimental and unsafe flags

2016-08-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1231. Add "unlock" flag for experimental and unsafe flags .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4100 To

[kudu-CR] KUDU-1231. Add "unlock" flag for experimental and unsafe flags

2016-08-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1231. Add "unlock" flag for experimental and unsafe flags .. Patch Set 6: (5 comments)

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 6: Code change looks good, but how about a test in kudu-ts-cli-test? -- To view, visit

[kudu-CR] tool: port cfile-dump to 'kudu fs dump cfile'

2016-08-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: port cfile-dump to 'kudu fs dump_cfile' .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4151 To unsubscribe, visit

[kudu-CR] cfile: replace DumpIteratorOptions with number of rows

2016-08-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: cfile: replace DumpIteratorOptions with number of rows .. cfile: replace DumpIteratorOptions with number of rows As of commit 9884fab, DumpIterator()

[kudu-CR] cfile: replace DumpIteratorOptions with number of rows

2016-08-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: cfile: replace DumpIteratorOptions with number of rows .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4150 To unsubscribe, visit

[kudu-CR] tool: split up action descriptions

2016-08-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: split up action descriptions .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4148 To unsubscribe, visit

[kudu-CR] KUDU-687: use client in ksck for master operations

2016-08-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-687: use client in ksck for master operations .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4147 To unsubscribe, visit

[kudu-CR] KUDU-687: use client in ksck for master operations

2016-08-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-687: use client in ksck for master operations .. KUDU-687: use client in ksck for master operations This patch modifies ksck to use the client for

[kudu-CR] transaction tracker: back-off when logging in-flight transactions

2016-08-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: transaction_tracker: back-off when logging in-flight transactions .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3133/ -- To view, visit

[kudu-CR] transaction tracker: back-off when logging in-flight transactions

2016-08-29 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4159 to review the following change. Change subject: transaction_tracker: back-off when logging in-flight transactions ..

[kudu-CR] KUDU-687: use client in ksck for master operations

2016-08-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-687: use client in ksck for master operations .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4147/1/src/kudu/tools/ksck_remote.cc File

[kudu-CR] KUDU-687: use client in ksck for master operations

2016-08-29 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4147 to look at the new patch set (#4). Change subject: KUDU-687: use client in ksck for master operations .. KUDU-687:

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/3131/ -- To view, visit

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-29 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4134 to look at the new patch set (#6). Change subject: Fix kudu-ts-cli crash when there is no data in tablet

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-29 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4134/2/src/kudu/tools/ts-cli.cc File

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-29 Thread Dinesh Bhat (Code Review)
Hello Dan Burkert, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4134 to look at the new patch set (#5). Change subject: Fix kudu-ts-cli crash when there is no data in tablet

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/3130/ -- To view, visit

[kudu-CR] tool: split up action descriptions

2016-08-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: split up action descriptions .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4148 To unsubscribe, visit

[kudu-CR] KUDU-687: expose additional tablet metadata in C++ client

2016-08-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-687: expose additional tablet metadata in C++ client .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4146 To unsubscribe,

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-29 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 16: (1 comment)

[kudu-CR] KUDU-1048 master should show versions of tservers, version summary

2016-08-29 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1048 master should show versions of tservers, version summary .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3129/ -- To view, visit

[kudu-CR] KUDU-1048 master should show versions of tservers, version summary

2016-08-29 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4104 to look at the new patch set (#3). Change subject: KUDU-1048 master should show versions of tservers, version summary

[kudu-CR] KUDU-1581 Fix DataFrame read failure when table has Binary Col

2016-08-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1581 Fix DataFrame read failure when table has Binary Col .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4145 To

[kudu-CR] KUDU-1581 Fix DataFrame read failure when table has Binary Col

2016-08-29 Thread Ram Mettu (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4145 to look at the new patch set (#3). Change subject: KUDU-1581 Fix DataFrame read failure when table has Binary Col

[kudu-CR] KUDU-1581 Fix DataFrame read failure when table has Binary Col For Binary Cols, kudu-spark is returning a ByteBuffer object when Spark expects to receive Array[Byte], so change is to return

2016-08-29 Thread Ram Mettu (Code Review)
Ram Mettu has posted comments on this change. Change subject: KUDU-1581 Fix DataFrame read failure when table has Binary Col For Binary Cols, kudu-spark is returning a ByteBuffer object when Spark expects to receive Array[Byte], so change is to return a copy of the byte array. Modified

[kudu-CR] KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata

2016-08-29 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1500: Data race in RaftConsensusITest.TestCorruptReplicaMetadata .. Patch Set 15: (1 comment)

[kudu-CR] Fix kudu-ts-cli crash when there is no data in tablet

2016-08-29 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: Fix kudu-ts-cli crash when there is no data in tablet .. Patch Set 4: (5 comments) TFTR Alexey/Todd, please see response inlined.