[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-03-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 7: (11 comments)

[kudu-CR] KUDU-2393. Fix flaky DebugUtilTest.TestSnapshot

2018-03-29 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9864 to look at the new patch set (#2). Change subject: KUDU-2393. Fix flaky DebugUtilTest.TestSnapshot .. KUDU-2393.

[kudu-CR] KUDU-2361. Fix flaky MasterTest.TestDumpStacksOnRpcQueueOverflow

2018-03-29 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9867 to review the following change. Change subject: KUDU-2361. Fix flaky MasterTest.TestDumpStacksOnRpcQueueOverflow ..

[kudu-CR] KUDU-2388. Fix TSAN race in MaintenanceManager::UnregisterOp

2018-03-29 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9866 to review the following change. Change subject: KUDU-2388. Fix TSAN race in MaintenanceManager::UnregisterOp

[kudu-CR] KUDU-2393. Fix flaky DebugUtilTest.TestSnapshot

2018-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9864 ) Change subject: KUDU-2393. Fix flaky DebugUtilTest.TestSnapshot .. Patch Set 1: I looped this 100 times prior to the fix, with

[kudu-CR] KUDU-2191 (8/n): Integrate HmsCatalog into CatalogManager

2018-03-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9863 ) Change subject: KUDU-2191 (8/n): Integrate HmsCatalog into CatalogManager .. Patch Set 2: This was split out from

[kudu-CR] KUDU-2191 (7/n): HmsCatalog

2018-03-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9862 ) Change subject: KUDU-2191 (7/n): HmsCatalog .. Patch Set 2: And a bunch of tests were added to hms_catalog-test -- To view, visit

[kudu-CR] KUDU-2191 (7/n): HmsCatalog

2018-03-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9862 ) Change subject: KUDU-2191 (7/n): HmsCatalog .. Patch Set 2: This was split out from https://gerrit.cloudera.org/c/8312/. It contains

[kudu-CR] WIP: flags: add API for thread-safe reading of string flags

2018-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9865 Change subject: WIP: flags: add API for thread-safe reading of string flags .. WIP: flags: add API for thread-safe reading of string flags

[kudu-CR] KUDU-2393. Fix flaky DebugUtilTest.TestSnapshot

2018-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9864 Change subject: KUDU-2393. Fix flaky DebugUtilTest.TestSnapshot .. KUDU-2393. Fix flaky DebugUtilTest.TestSnapshot This test was flaky

[kudu-CR] KUDU-2191 (6/n): Fixups to the C++ HMS client

2018-03-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9861 ) Change subject: KUDU-2191 (6/n): Fixups to the C++ HMS client .. Patch Set 1: This was split out from

[kudu-CR] KUDU-2191 (7/n): HmsCatalog

2018-03-29 Thread Dan Burkert (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Hao Hao, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9862 to look at the new patch set (#2). Change subject: KUDU-2191 (7/n): HmsCatalog

[kudu-CR] KUDU-2191 (8/n): Integrate HmsCatalog into CatalogManager

2018-03-29 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, Adar Dembo, Hao Hao, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9863 to look at the new patch set (#2). Change subject: KUDU-2191 (8/n): Integrate HmsCatalog into CatalogManager

[kudu-CR] KUDU-2384. Don't collect thread stacks when running under debugger

2018-03-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9835 ) Change subject: KUDU-2384. Don't collect thread stacks when running under debugger .. Patch Set 3: > This is an interesting case.

[kudu-CR] KUDU-16 pt 2: add client-side limits on scanners

2018-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9790 ) Change subject: KUDU-16 pt 2: add client-side limits on scanners .. Patch Set 4: (2 comments)

[kudu-CR] rowset metadata: cache min/max encoded keys

2018-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9372 ) Change subject: rowset_metadata: cache min/max encoded keys .. Patch Set 6: (1 comment)

[kudu-CR] rpc-test: fix multi-threaded test from running too long

2018-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9856 ) Change subject: rpc-test: fix multi-threaded test from running too long .. rpc-test: fix multi-threaded test from running too

[kudu-CR] rpc-test: fix multi-threaded test from running too long

2018-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9856 ) Change subject: rpc-test: fix multi-threaded test from running too long .. Patch Set 1: Verified+1 -- To view, visit

[kudu-CR] rpc-test: fix multi-threaded test from running too long

2018-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: rpc-test: fix multi-threaded test from running too long .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/9856 To

[kudu-CR] meta cache: improve multi-threaded scalability

2018-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9760 ) Change subject: meta_cache: improve multi-threaded scalability .. Patch Set 4: Verified+1 -- To view, visit

[kudu-CR] meta cache: improve multi-threaded scalability

2018-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: meta_cache: improve multi-threaded scalability .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/9760 To unsubscribe,

[kudu-CR] KUDU-16 pt 1: add server-side limits on scanners

2018-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9783 ) Change subject: KUDU-16 pt 1: add server-side limits on scanners .. Patch Set 9: (7 comments)

[kudu-CR] [examples] Update collectl example

2018-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9854 ) Change subject: [examples] Update collectl example .. Patch Set 1: (2 comments)

[kudu-CR] [examples] Improve the basic Java example

2018-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9852 ) Change subject: [examples] Improve the basic Java example .. Patch Set 1: (2 comments)

[kudu-CR] Improve the C++ client example

2018-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9838 ) Change subject: Improve the C++ client example .. Patch Set 1: (1 comment)

[kudu-CR] util: use uint64 t values for resource limits and adjust usages

2018-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9806 ) Change subject: util: use uint64_t values for resource limits and adjust usages .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] util: use uint64 t values for resource limits and adjust usages

2018-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9806 ) Change subject: util: use uint64_t values for resource limits and adjust usages .. util: use uint64_t values for resource limits

[kudu-CR] KUDU-2289: Tablet deletion should be throttled

2018-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9551 ) Change subject: KUDU-2289: Tablet deletion should be throttled .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-2191 (6/n): Hive Metastore catalog manager integration

2018-03-29 Thread Dan Burkert (Code Review)
Dan Burkert has abandoned this change. ( http://gerrit.cloudera.org:8080/8312 ) Change subject: KUDU-2191 (6/n): Hive Metastore catalog manager integration .. Abandoned split into smaller chunks -- To view, visit

[kudu-CR] KUDU-2191 (6/n): Hive Metastore catalog manager integration

2018-03-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8312 ) Change subject: KUDU-2191 (6/n): Hive Metastore catalog manager integration .. Patch Set 10: > Patch Set 10: > > (6 comments) This has

[kudu-CR] KUDU-2191 (7/n): HmsCatalog

2018-03-29 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9862 Change subject: KUDU-2191 (7/n): HmsCatalog .. KUDU-2191 (7/n): HmsCatalog This commit adds some important higher-level HMS machinery in

[kudu-CR] KUDU-2191 (6/n): Fixups to the C++ HMS client

2018-03-29 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9861 Change subject: KUDU-2191 (6/n): Fixups to the C++ HMS client .. KUDU-2191 (6/n): Fixups to the C++ HMS client These are changes

[kudu-CR] KUDU-2191 (8/n): Integrate HmsCatalog into CatalogManager

2018-03-29 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9863 Change subject: KUDU-2191 (8/n): Integrate HmsCatalog into CatalogManager .. KUDU-2191 (8/n): Integrate HmsCatalog into CatalogManager

[kudu-CR] [examples] Improve loadgen example

2018-03-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9853 ) Change subject: [examples] Improve loadgen example .. Patch Set 1: (2 comments)

[kudu-CR] [examples] Improve the basic Java example

2018-03-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9852 ) Change subject: [examples] Improve the basic Java example .. Patch Set 1: (1 comment)

[kudu-CR] [examples] Update collectl example

2018-03-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9854 ) Change subject: [examples] Update collectl example .. Patch Set 1: (1 comment)

[kudu-CR] [examples] Add licenses to Python examples

2018-03-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9858 ) Change subject: [examples] Add licenses to Python examples .. Patch Set 1: (2 comments)

[kudu-CR] [examples] Improve the basic Java example

2018-03-29 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9852 ) Change subject: [examples] Improve the basic Java example .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-16 pt 2: add client-side limits on scanners

2018-03-29 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9790 ) Change subject: KUDU-16 pt 2: add client-side limits on scanners .. Patch Set 4: > Patch Set 1: > > Haven't fully reviewed this patch,

[kudu-CR] KUDU-16 pt 1: add server-side limits on scanners

2018-03-29 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9783 ) Change subject: KUDU-16 pt 1: add server-side limits on scanners .. Patch Set 9: The pre-commit failures appear unrelated. -- To view,

[kudu-CR] KUDU-16 pt 2: add client-side limits on scanners

2018-03-29 Thread Andrew Wong (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9790 to look at the new patch set (#4). Change subject: KUDU-16 pt 2: add client-side limits on scanners

[kudu-CR] KUDU-16 pt 1: add server-side limits on scanners

2018-03-29 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Dan Burkert, David Ribeiro Alves, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9783 to look at the new patch set (#9). Change subject: KUDU-16 pt 1: add server-side limits on scanners

[kudu-CR] KUDU-16 pt 2: add client-side limits on scanners

2018-03-29 Thread Andrew Wong (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9790 to look at the new patch set (#3). Change subject: KUDU-16 pt 2: add client-side limits on scanners

[kudu-CR] KUDU-16 pt 1: add server-side limits on scanners

2018-03-29 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Dan Burkert, David Ribeiro Alves, Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9783 to look at the new patch set (#8). Change subject: KUDU-16 pt 1: add server-side limits on scanners

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-03-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 7: > Build Failed Unrelated, pre-existing race. See KUDU-2058.

[kudu-CR] [examples] Improve loadgen example

2018-03-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9853 ) Change subject: [examples] Improve loadgen example .. Patch Set 1: Verified+1 This code doesn't affect tests so overriding Jenkins.

[kudu-CR] [examples] Improve loadgen example

2018-03-29 Thread Will Berkeley (Code Review)
Will Berkeley has removed a vote on this change. Change subject: [examples] Improve loadgen example .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/9853 To unsubscribe, visit

[kudu-CR] [tools] Add a tool to recover master data from tablet servers

2018-03-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9490 ) Change subject: [tools] Add a tool to recover master data from tablet servers .. Patch Set 4: Quick update on this: I'm planning on

[kudu-CR] [examples] Add licenses to Python examples

2018-03-29 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9858 Change subject: [examples] Add licenses to Python examples .. [examples] Add licenses to Python examples This also adds a README to the

[kudu-CR] rpc-test: fix multi-threaded test from running too long

2018-03-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9856 ) Change subject: rpc-test: fix multi-threaded test from running too long .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2384. Don't collect thread stacks when running under debugger

2018-03-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9835 ) Change subject: KUDU-2384. Don't collect thread stacks when running under debugger .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] rpc-test: fix multi-threaded test from running too long

2018-03-29 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9856 ) Change subject: rpc-test: fix multi-threaded test from running too long .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] rpc-test: fix multi-threaded test from running too long

2018-03-29 Thread Todd Lipcon (Code Review)
Hello Sailesh Mukil, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9856 to review the following change. Change subject: rpc-test: fix multi-threaded test from running too long ..

[kudu-CR] KUDU-2384. Don't collect thread stacks when running under debugger

2018-03-29 Thread Todd Lipcon (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9835 to look at the new patch set (#3). Change subject: KUDU-2384. Don't collect thread stacks when running under debugger

[kudu-CR] meta cache: improve multi-threaded scalability

2018-03-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9760 ) Change subject: meta_cache: improve multi-threaded scalability .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.7.x) KUDU-2364 Add extra check in ksck for tserver ID

2018-03-29 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/9855 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. Patch Set 1: > Patch Set 1: Verified-1 > > Build Failed > >

[kudu-CR] make shared: fix build for newer libc++

2018-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9847 ) Change subject: make_shared: fix build for newer libc++ .. make_shared: fix build for newer libc++ Previously, we used

[kudu-CR] KUDU-2303: Add ignoreNull option to upsertRows

2018-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9834 ) Change subject: KUDU-2303: Add ignoreNull option to upsertRows .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2303: Add ignoreNull option to upsertRows

2018-03-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9834 ) Change subject: KUDU-2303: Add ignoreNull option to upsertRows .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1977. Avoid extra reference counting for fast-path MetaCache lookups

2018-03-29 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9753 to look at the new patch set (#4). Change subject: KUDU-1977. Avoid extra reference counting for fast-path MetaCache lookups

[kudu-CR] meta cache: improve multi-threaded scalability

2018-03-29 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9760 to look at the new patch set (#3). Change subject: meta_cache: improve multi-threaded scalability

[kudu-CR] meta cache: improve multi-threaded scalability

2018-03-29 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9760 ) Change subject: meta_cache: improve multi-threaded scalability .. Patch Set 1: (4 comments)

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-03-29 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9393 to look at the new patch set (#7). Change subject: KUDU-2290: Tool to re-create a tablet

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-03-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9393 ) Change subject: KUDU-2290: Tool to re-create a tablet .. Patch Set 6: (3 comments)

[kudu-CR] KUDU-2303: Add ignoreNull option to upsertRows

2018-03-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9834 ) Change subject: KUDU-2303: Add ignoreNull option to upsertRows .. Patch Set 2: (1 comment) > Patch Set 2: > > (5 comments)

[kudu-CR] KUDU-2290: Tool to re-create a tablet

2018-03-29 Thread Will Berkeley (Code Review)
Hello Tidy Bot, Dan Burkert, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9393 to look at the new patch set (#6). Change subject: KUDU-2290: Tool to re-create a tablet

[kudu-CR] KUDU-2364 Add extra check in ksck for tserver ID

2018-03-29 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9787 ) Change subject: KUDU-2364 Add extra check in ksck for tserver ID .. KUDU-2364 Add extra check in ksck for tserver ID ksck did

[kudu-CR] KUDU-2303: Add ignoreNull option to upsertRows

2018-03-29 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9834 ) Change subject: KUDU-2303: Add ignoreNull option to upsertRows .. Patch Set 2: (4 comments)