[kudu-CR] KUDU-2543 pt 1: basic checks for authz tokens

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11751 ) Change subject: KUDU-2543 pt 1: basic checks for authz tokens .. Patch Set 8: (2 comments)

[kudu-CR] java: KuduBinaryExtractor should use the thread context classloader

Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12147 ) Change subject: java: KuduBinaryExtractor should use the thread context classloader .. Patch Set 1: > We'll need to make sure the test

[kudu-CR] java: KuduBinaryExtractor should use the thread context classloader

Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12147 ) Change subject: java: KuduBinaryExtractor should use the thread context classloader .. Patch Set 1: Verified+1 Overriding unrelated c++

[kudu-CR] java: KuduBinaryExtractor should use the thread context classloader

Mike Percy has removed a vote on this change. Change subject: java: KuduBinaryExtractor should use the thread context classloader .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit

[kudu-CR] KUDU-2543 pt 1: basic checks for authz tokens

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11751 ) Change subject: KUDU-2543 pt 1: basic checks for authz tokens .. Patch Set 8: (2 comments)

[kudu-CR] Take absolute value of ntp maxerror to avoid undefined behavior from negative values

Patrick Freeman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12149 ) Change subject: Take absolute value of ntp maxerror to avoid undefined behavior from negative values .. Patch Set 1: > (1 comment)

[kudu-CR] java: KuduBinaryExtractor should use the thread context classloader

Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12147 ) Change subject: java: KuduBinaryExtractor should use the thread context classloader .. Patch Set 1: I think this will work nicely,

[kudu-CR] KUDU-2543 pt 1: basic checks for authz tokens

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11751 ) Change subject: KUDU-2543 pt 1: basic checks for authz tokens .. Patch Set 8: (4 comments)

[kudu-CR] Take absolute value of ntp maxerror to avoid undefined behavior from negative values

Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12149 ) Change subject: Take absolute value of ntp maxerror to avoid undefined behavior from negative values .. Patch Set 1: (1 comment)

[kudu-CR] Take absolute value of ntp maxerror to avoid undefined behavior from negative values

Patrick Freeman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12149 Change subject: Take absolute value of ntp maxerror to avoid undefined behavior from negative values .. Take absolute value of ntp

[kudu-CR] docs: update guidance for binding functions

Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12146 ) Change subject: docs: update guidance for binding functions .. docs: update guidance for binding functions Tweaked the docs to

[kudu-CR] KUDU-2543 pt 1: basic checks for authz tokens

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11751 ) Change subject: KUDU-2543 pt 1: basic checks for authz tokens .. Patch Set 8: (11 comments)

[kudu-CR] KUDU-2543 pt 1: basic checks for authz tokens

Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11751 to look at the new patch set (#8). Change subject: KUDU-2543 pt 1: basic checks for authz tokens

[kudu-CR] KUDU-683: unify C++ client-to-master retry logic

Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12002 ) Change subject: KUDU-683: unify C++ client-to-master retry logic .. KUDU-683: unify C++ client-to-master retry logic In

[kudu-CR] [util] use lighter locking scheme for ThreadMgr

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12112 ) Change subject: [util] use lighter locking scheme for ThreadMgr .. [util] use lighter locking scheme for ThreadMgr Use the

[kudu-CR] [gradle] Increase test JVMs heap size

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12134 ) Change subject: [gradle] Increase test JVMs heap size .. Patch Set 1: I am okay with this. Though, I would like to understand why the

[kudu-CR] python: fix tests run in Python 3.4 environments

Hello a...@phdata.io, Alexey Serbin, Andrew Wong, Jordan Birdsell, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/12148 to review the following change. Change subject: python: fix tests run in Python 3.4 environments

[kudu-CR] [util] use lighter locking scheme for ThreadMgr

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12112 ) Change subject: [util] use lighter locking scheme for ThreadMgr .. Patch Set 10: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 ) Change subject: KUDU-2411: Add OS/Arch detection to binary extract .. Patch Set 1: > I was thinking we could create new classloader for

[kudu-CR] java: KuduBinaryExtractor should use the thread context classloader

Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12147 Change subject: java: KuduBinaryExtractor should use the thread context classloader .. java: KuduBinaryExtractor should use the thread

[kudu-CR] [util] use lighter locking scheme for ThreadMgr

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12112 ) Change subject: [util] use lighter locking scheme for ThreadMgr .. Patch Set 9: (1 comment)

[kudu-CR] docs: update guidance for binding functions

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12146 ) Change subject: docs: update guidance for binding functions .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] docs: update guidance for binding functions

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12146 ) Change subject: docs: update guidance for binding functions .. Patch Set 2: (3 comments)

[kudu-CR] docs: update guidance for binding functions

Hello Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12146 to look at the new patch set (#2). Change subject: docs: update guidance for binding functions

[kudu-CR] KUDU-683: unify C++ client-to-master retry logic

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12002 ) Change subject: KUDU-683: unify C++ client-to-master retry logic .. Patch Set 13: Code-Review+2 (1 comment)

[kudu-CR] docs: update guidance for binding functions

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12146 ) Change subject: docs: update guidance for binding functions .. Patch Set 1: (1 comment)

[kudu-CR] docs: update guidance for binding functions

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12146 ) Change subject: docs: update guidance for binding functions .. Patch Set 1: (2 comments)

[kudu-CR] docs: update guidance for binding functions

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12146 ) Change subject: docs: update guidance for binding functions .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [util] use lighter locking scheme for ThreadMgr

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12112 ) Change subject: [util] use lighter locking scheme for ThreadMgr .. Patch Set 9: (1 comment)

[kudu-CR] [util] use lighter locking scheme for ThreadMgr

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12112 ) Change subject: [util] use lighter locking scheme for ThreadMgr .. Patch Set 8: (3 comments)

[kudu-CR] [util] use lighter locking scheme for ThreadMgr

Hello Will Berkeley, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12112 to look at the new patch set (#9). Change subject: [util] use lighter locking scheme for ThreadMgr

[kudu-CR] KUDU-2636: LBM supports deleting dead and full containers

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12075 ) Change subject: KUDU-2636: LBM supports deleting dead and full containers .. Patch Set 7: (1 comment)

[kudu-CR] [fs]: wrapping up containers in scoped refptr

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. Patch Set 3: (4 comments)

[kudu-CR] [fs]: wrapping up containers in scoped refptr

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 ) Change subject: [fs]: wrapping up containers in scoped_refptr .. Patch Set 3: > I compiled the kudu code on debian 8.9 locally, and the

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 ) Change subject: KUDU-2411: Add OS/Arch detection to binary extract .. Patch Set 1: It is not fully tested yet. We still need to add

[kudu-CR] KUDU-683: unify C++ client-to-master retry logic

Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12002 to look at the new patch set (#11). Change subject: KUDU-683: unify C++ client-to-master retry logic

[kudu-CR] KUDU-683: unify C++ client-to-master retry logic

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12002 ) Change subject: KUDU-683: unify C++ client-to-master retry logic .. Patch Set 13: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-683: unify C++ client-to-master retry logic

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12002 ) Change subject: KUDU-683: unify C++ client-to-master retry logic .. Patch Set 13: (7 comments)

[kudu-CR] KUDU-683: unify C++ client-to-master retry logic

Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12002 to look at the new patch set (#13). Change subject: KUDU-683: unify C++ client-to-master retry logic

[kudu-CR] KUDU-683: unify C++ client-to-master retry logic

Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12002 to look at the new patch set (#12). Change subject: KUDU-683: unify C++ client-to-master retry logic

[kudu-CR] KUDU-683: unify C++ client-to-master retry logic

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12002 ) Change subject: KUDU-683: unify C++ client-to-master retry logic .. Patch Set 10: (4 comments) Looks good to me, a few nit.

[kudu-CR] KUDU-2543 pt 2: pass around default authz tokens

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12122 ) Change subject: KUDU-2543 pt 2: pass around default authz tokens .. Patch Set 1: (28 comments)

[kudu-CR] KUDU-2543 pt 1: basic checks for authz tokens

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11751 ) Change subject: KUDU-2543 pt 1: basic checks for authz tokens .. Patch Set 7: (8 comments)

[kudu-CR] [python] handle DisableOpenSSLInitialization() result status

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12135 ) Change subject: [python] handle DisableOpenSSLInitialization() result status .. Patch Set 1: (1 comment)

[kudu-CR] [python] handle DisableOpenSSLInitialization() result status

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12135 ) Change subject: [python] handle DisableOpenSSLInitialization() result status .. [python] handle DisableOpenSSLInitialization()

[kudu-CR] KUDU-2640: Add Spark Structured Streaming Sink

Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12087 ) Change subject: KUDU-2640: Add Spark Structured Streaming Sink .. Patch Set 2: (3 comments)

[kudu-CR] [gradle] Increase test JVMs heap size

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12134 ) Change subject: [gradle] Increase test JVMs heap size .. Patch Set 1: Code-Review+2 Looks OK to me but would be nice if Grant took a

[kudu-CR] KUDU-2640: Add Spark Structured Streaming Sink

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12087 ) Change subject: KUDU-2640: Add Spark Structured Streaming Sink .. Patch Set 2: (2 comments)

[kudu-CR] Support location awareness in READ CLOSEST for the C++ client

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12138 ) Change subject: Support location awareness in READ_CLOSEST for the C++ client .. Patch Set 1: (4 comments)

[kudu-CR] [docs] add Hive Metastore integration

Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11798 ) Change subject: [docs] add Hive Metastore integration .. Patch Set 8: Code-Review+2 -- To view, visit

[kudu-CR] [c++] remove -Wno-deprecated compiler's flag

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12140 ) Change subject: [c++] remove -Wno-deprecated compiler's flag .. Patch Set 2: Code-Review+2 (2 comments)

[kudu-CR] [python] handle DisableOpenSSLInitialization() result status

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12135 ) Change subject: [python] handle DisableOpenSSLInitialization() result status .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] [util] use lighter locking scheme for ThreadMgr

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12112 ) Change subject: [util] use lighter locking scheme for ThreadMgr .. Patch Set 8: (3 comments)

[kudu-CR] KUDU-683: unify C++ client-to-master retry logic

Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12002 ) Change subject: KUDU-683: unify C++ client-to-master retry logic .. Patch Set 10: Code-Review+2 Check in with Alexey to see if he wants

[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract

Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 ) Change subject: KUDU-2411: Add OS/Arch detection to binary extract .. Patch Set 1: Code-Review+1 (1 comment) Looks good. Is it tested