[kudu-CR] Allow tablet shutdown without completing txs

2017-09-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 12: Thinking a bit more which constraint we actually want to enforce. I think we need to

[kudu-CR] Allow tablet shutdown without completing txs

2017-09-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 12: (4 comments) http://gerrit.cloudera.org:8080/#/c/7439/12/src/kudu/tablet/mvcc.cc File

[kudu-CR] Allow tablet shutdown without completing txs

2017-09-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Allow tablet shutdown without completing txs .. Patch Set 12: I like the changes in general (post specific comments in a few mins). One concern that I

[kudu-CR] consensus: KUDU-2147. Unknown leader should not be treated as valid UUID

2017-09-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: KUDU-2147. Unknown leader should not be treated as valid UUID .. Patch Set 1: (2 comments) are you planning on adding a regular unit test or

[kudu-CR] Fix tablet state metrics race

2017-09-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Fix tablet state metrics race .. Patch Set 4: Code-Review+2 sgtm then, thanks -- To view, visit http://gerrit.cloudera.org:8080/8082 To unsubscribe,

[kudu-CR] master: fix TSAN data race on ToString()

2017-09-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: master: fix TSAN data race on ToString() .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8092 To unsubscribe, visit

[kudu-CR] docs: add a blurb about faststring usage

2017-09-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: docs: add a blurb about faststring usage .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8106/1/docs/contributing.adoc File

[kudu-CR] Fix tablet state metrics race

2017-09-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Fix tablet state metrics race .. Patch Set 4: lgtm, but is there a test you can reuse/easily add to? -- To view, visit

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 23: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6968 To

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 22: (10 comments)

[kudu-CR] Link to troubleshooting docs for two common problems

2017-09-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Link to troubleshooting docs for two common problems .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8093 To unsubscribe,

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 19: (1 comment)

[kudu-CR] Link to troubleshooting docs for two common problems

2017-09-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Link to troubleshooting docs for two common problems .. Patch Set 3: Code-Review+1 lgtm adar's nits -- To view, visit

[kudu-CR] KUDU-1807 (part 3): remove GetTableSchema.create table done

2017-09-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1807 (part 3): remove GetTableSchema.create_table_done .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8045 To

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 19: (1 comment)

[kudu-CR] Link to troubleshooting docs for two common problems

2017-09-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Link to troubleshooting docs for two common problems .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8093/2/docs/troubleshooting.adoc

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-09-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Kudu Consistency Blog Post Pt1 .. Patch Set 14: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7019 To unsubscribe, visit

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-09-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Kudu Consistency Blog Post Pt1 .. Kudu Consistency Blog Post Pt1 This is the first part of multi-part blog post series about consistency in Kudu.

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-09-18 Thread David Ribeiro Alves (Code Review)
Hello Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7019 to look at the new patch set (#14). Change subject: Kudu Consistency Blog Post Pt1 .. Kudu Consistency Blog Post

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-09-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Kudu Consistency Blog Post Pt1 .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/7019/13/_posts/2017-09-18-kudu-consistency-pt1.md File

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-09-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Kudu Consistency Blog Post Pt1 .. Patch Set 11: (23 comments) http://gerrit.cloudera.org:8080/#/c/7019/12/_posts/2017-08-21-kudu-consistency-pt1.md File

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-09-18 Thread David Ribeiro Alves (Code Review)
Hello Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7019 to look at the new patch set (#13). Change subject: Kudu Consistency Blog Post Pt1 .. Kudu Consistency Blog Post

[kudu-CR] data dirs: fix a LOG statement

2017-09-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: data_dirs: fix a LOG statement .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8091 To unsubscribe, visit

[kudu-CR] KUDU-1807 (part 3): remove GetTableSchema.create table done

2017-09-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1807 (part 3): remove GetTableSchema.create_table_done .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8045 To

[kudu-CR] c++ client: try harder to pass table IDs into RPCs that can accept them

2017-09-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: c++ client: try harder to pass table IDs into RPCs that can accept them .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1807 (part 3): remove GetTableSchema.create table done

2017-09-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1807 (part 3): remove GetTableSchema.create_table_done .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8045 To

[kudu-CR] WIP [raft consensus-itest] fix flake in TestSlowLeader

2017-09-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP [raft_consensus-itest] fix flake in TestSlowLeader .. Patch Set 2: can you explain a little better the exact scenario that happens? could you cause

[kudu-CR] KUDU-1788. Increase Raft RPC timeout to 30sec to avoid fruitless retries.

2017-09-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1788. Increase Raft RPC timeout to 30sec to avoid fruitless retries. .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] c++ client: try harder to pass table IDs into RPCs that can accept them

2017-09-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: c++ client: try harder to pass table IDs into RPCs that can accept them .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-1807 (part 3): remove GetTableSchema.create table done

2017-09-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1807 (part 3): remove GetTableSchema.create_table_done .. Patch Set 3: are the build failures unrelated? (there are a few of them) -- To view,

[kudu-CR] KUDU-2055 [part 2]: Add util to construct sorted disjoint interval

2017-09-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-2055 [part 2]: Add util to construct sorted disjoint interval .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8041/1//COMMIT_MSG

[kudu-CR] KUDU-1807 (part 3): remove GetTableSchema.create table done

2017-09-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1807 (part 3): remove GetTableSchema.create_table_done .. Patch Set 2: actually nm. my concern was that we might use done() (which is false by

[kudu-CR] KUDU-1807 (part 3): remove GetTableSchema.create table done

2017-09-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1807 (part 3): remove GetTableSchema.create_table_done .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8045 To

[kudu-CR] KUDU-1807 (part 3): remove GetTableSchema.create table done

2017-09-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1807 (part 3): remove GetTableSchema.create_table_done .. Patch Set 2: lgtm, just want to make sure that previously the java client (and elsewhere)

[kudu-CR] KUDU-2144. Add metrics for Reactor load

2017-09-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-2144. Add metrics for Reactor load .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8064 To unsubscribe, visit

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 19: (3 comments) http://gerrit.cloudera.org:8080/#/c/6968/19/src/kudu/consensus/log.h

[kudu-CR] c++ client: try harder to pass table IDs into RPCs that can accept them

2017-09-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: c++ client: try harder to pass table IDs into RPCs that can accept them .. Patch Set 2: (5 comments)

[kudu-CR] KUDU-1788. Increase Raft RPC timeout to 30sec to avoid fruitless retries.

2017-09-12 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1788. Increase Raft RPC timeout to 30sec to avoid fruitless retries. .. Patch Set 1: does this have any nasty interaction with failure detection for

[kudu-CR] Add a simple benchmark to create 1M blocks and reopen LBM

2017-09-11 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a simple benchmark to create 1M blocks and reopen LBM .. Patch Set 1: it'd be awesome to have somethings like this for actual tablets. likely out of

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-09-11 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#12). Change subject: Kudu Consistency Blog Post Pt1 .. Kudu Consistency Blog Post Pt1 This is the first part of multi-part blog post series about consistency in Kudu. It's hard

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-09-11 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#11). Change subject: Kudu Consistency Blog Post Pt1 .. Kudu Consistency Blog Post Pt1 This is the first part of multi-part blog post series about consistency in Kudu. It's hard

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-09-11 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Kudu Consistency Blog Post Pt1 .. Patch Set 10: (37 comments) http://gerrit.cloudera.org:8080/#/c/7019/10/_posts/2017-08-21-kudu-consistency-pt1.md File

[kudu-CR] consensus: Save previous last-logged OpId across tablet copies

2017-08-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: Save previous last-logged OpId across tablet copies .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7888 To

[kudu-CR] consensus: Save previous last-logged OpId across tablet copies

2017-08-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: Save previous last-logged OpId across tablet copies .. Patch Set 4: (1 comment)

[kudu-CR] consensus: Save previous last-logged OpId across tablet copies

2017-08-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: consensus: Save previous last-logged OpId across tablet copies .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2083. Decrement running maintenance ops on failed prepare

2017-08-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: KUDU-2083. Decrement running maintenance ops on failed prepare .. KUDU-2083. Decrement running maintenance ops on failed prepare There is

[kudu-CR] KUDU-2083. Decrement running maintenance ops on failed prepare

2017-08-28 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7610 to look at the new patch set (#3). Change subject: KUDU-2083. Decrement running maintenance ops on failed prepare

[kudu-CR] open FS layout in presence of disk failure

2017-08-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7784 To unsubscribe, visit

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7784/4/src/kudu/fs/block_manager_util.h File

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7784/4/src/kudu/fs/block_manager_util.h File

[kudu-CR] open FS layout in presence of disk failure

2017-08-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: open FS layout in presence of disk failure .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/7784/4/src/kudu/fs/block_manager_util.cc File

[kudu-CR] disk failure: don't open tablets on failed disks

2017-08-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: disk failure: don't open tablets on failed disks .. Patch Set 4: (2 comments)

[kudu-CR] disk failure: don't open tablets on failed disks

2017-08-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: disk failure: don't open tablets on failed disks .. Patch Set 3: (9 comments)

[kudu-CR] KUDU-1407: reassign failed tablets

2017-08-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1407: reassign failed tablets .. Patch Set 17: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7440 To unsubscribe, visit

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-08-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#10). Change subject: Kudu Consistency Blog Post Pt1 .. Kudu Consistency Blog Post Pt1 This is the first part of multi-part blog post series about consistency in Kudu. It's hard

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-08-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#9). Change subject: Kudu Consistency Blog Post Pt1 .. Kudu Consistency Blog Post Pt1 This is the first part of multi-part blog post series about consistency in Kudu. It's hard

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-08-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#8). Change subject: Kudu Consistency Blog Post Pt1 .. Kudu Consistency Blog Post Pt1 This is the first part of multi-part blog post series about consistency in Kudu. It's hard

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-08-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#7). Change subject: Kudu Consistency Blog Post Pt1 .. Kudu Consistency Blog Post Pt1 This is the first part of multi-part blog post series about consistency in Kudu. It's hard

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-08-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#6). Change subject: Kudu Consistency Blog Post Pt1 .. Kudu Consistency Blog Post Pt1 This is the first part of multi-part blog post series about consistency in Kudu. It's hard

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-08-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#5). Change subject: Kudu Consistency Blog Post Pt1 .. Kudu Consistency Blog Post Pt1 This is the first part of multi-part blog post series about consistency in Kudu. It's hard

[kudu-CR](gh-pages) Kudu Consistency Blog Post Pt1

2017-08-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#4). Change subject: Kudu Consistency Blog Post Pt1 .. Kudu Consistency Blog Post Pt1 This is the first part of multi-part blog post series about consistency in Kudu. It's hard

[kudu-CR] KUDU-1407: reassign failed tablets

2017-08-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1407: reassign failed tablets .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7440 To unsubscribe, visit

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-1407: reassign failed tablets

2017-08-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1407: reassign failed tablets .. Patch Set 10: (6 comments) http://gerrit.cloudera.org:8080/#/c/7440/7/src/kudu/client/scanner-internal.cc File

[kudu-CR] gutil: remove use of deprecated headers

2017-08-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: gutil: remove use of deprecated headers .. Patch Set 1: looks good to me, but clang doens't seem to agree :) -- To view, visit

[kudu-CR] Give more context on errors reading cfiles

2017-08-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Give more context on errors reading cfiles .. Patch Set 1: Code-Review+2 sounds good -- To view, visit http://gerrit.cloudera.org:8080/7620 To

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/6960/6/src/kudu/tablet/tablet_replica.h File

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 6: (7 comments) leaving for luch, more comments forthcoming

[kudu-CR] Give more context on errors reading cfiles

2017-08-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Give more context on errors reading cfiles .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7620/1/src/kudu/cfile/cfile_reader.cc File

[kudu-CR] WIP: clock: add a built-in NTP client implementation

2017-08-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: clock: add a built-in NTP client implementation .. Patch Set 5: (1 comment) only browsed this briefly. The direction looks good, but would like to

[kudu-CR] transaction: remove unused StatusTransactionCompletionCallback

2017-08-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: transaction: remove unused StatusTransactionCompletionCallback .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7632 To

[kudu-CR] rpc: hook up a callback for libev fatal errors

2017-08-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: rpc: hook up a callback for libev fatal errors .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7633 To unsubscribe, visit

[kudu-CR](branch-1.2.x) KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

2017-08-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7613

[kudu-CR] WIP: KUDU-2083. Decrement running maintenance ops on failed prepare

2017-08-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: WIP: KUDU-2083. Decrement running maintenance ops on failed prepare .. WIP: KUDU-2083. Decrement running maintenance ops on failed prepare There is

[kudu-CR] WIP: KUDU-2083. Decrement running maitenance ops on failed prepare

2017-08-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/7610 Change subject: WIP: KUDU-2083. Decrement running maitenance ops on failed prepare .. WIP: KUDU-2083. Decrement running

[kudu-CR] KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

2017-08-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7545

[kudu-CR] [tests] fix compilation warning on OS X

2017-08-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [tests] fix compilation warning on OS X .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7594 To unsubscribe, visit

[kudu-CR] KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

2017-08-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks .. Patch Set 2: (1 comment)

[kudu-CR] disk failure: reassign failed tablets

2017-08-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: disk failure: reassign failed tablets .. Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/7440/7/src/kudu/client/scanner-internal.cc File

[kudu-CR] KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks

2017-08-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks .. Patch Set 2: (1 comment)

[kudu-CR] [build] Fix Python build failures on RHEL 6

2017-08-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [build] Fix Python build failures on RHEL 6 .. Patch Set 1: I'll keep looking for a "non-workaround" version. -- To view, visit

[kudu-CR] [build] Fix Python build failures on RHEL 6

2017-08-04 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [build] Fix Python build failures on RHEL 6 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7589 To unsubscribe, visit

[kudu-CR] java: prohibit use of a KuduTable from an unassociated KuduClient

2017-07-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: java: prohibit use of a KuduTable from an unassociated KuduClient .. Patch Set 2: (1 comment) this looks like a possible source of the problem. not

[kudu-CR](gh-pages) WIP: Kudu Consistency Blog Post Pt1

2017-07-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: Kudu Consistency Blog Post Pt1 .. Patch Set 3: What do you you guys think of me splitting the "Relevant architecture components" into another post,

[kudu-CR](gh-pages) WIP: Kudu Consistency Blog Post Pt1

2017-07-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: Kudu Consistency Blog Post Pt1 .. Patch Set 3: (35 comments) http://gerrit.cloudera.org:8080/#/c/7019/3/_posts/2017-05-30-kudu-consistency-pt1.md

[kudu-CR] Create ConsensusMetadataManager

2017-06-28 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Create ConsensusMetadataManager .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7191/7/src/kudu/consensus/consensus_meta_manager.cc File

[kudu-CR] Make ConsensusMetadata thread-safe

2017-06-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Make ConsensusMetadata thread-safe .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6958 To unsubscribe, visit

[kudu-CR] ConsensusMetadata::Create() should not overwrite an existing file

2017-06-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: ConsensusMetadata::Create() should not overwrite an existing file .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7190

[kudu-CR] Rename MiniCluster to InternalMiniCluster

2017-06-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Rename MiniCluster to InternalMiniCluster .. Patch Set 2: (1 comment)

[kudu-CR] Rename MiniClusterBase to MiniCluster

2017-06-26 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Rename MiniClusterBase to MiniCluster .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7273 To unsubscribe, visit

[kudu-CR] Make ConsensusMetadata thread-safe

2017-06-26 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Make ConsensusMetadata thread-safe .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6958 To unsubscribe, visit

[kudu-CR] ConsensusMetadata::Create() should not overwrite an existing file

2017-06-26 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: ConsensusMetadata::Create() should not overwrite an existing file .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7190

[kudu-CR] Simplify OpId/Timestamp assignment and make it atomic

2017-06-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Simplify OpId/Timestamp assignment and make it atomic .. Patch Set 8: Gonna pause this patch series until mike's consensus metadata changes land -- To

[kudu-CR] Fix SIGSEGV in ksck

2017-06-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Fix SIGSEGV in ksck .. Fix SIGSEGV in ksck ksck will segfault when some tablet servers that host tablet replicas are missing. This happens, for

[kudu-CR] Fix SIGSEGV in ksck

2017-06-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Fix SIGSEGV in ksck .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7261 To unsubscribe, visit

[kudu-CR] [consensus] 'runtime' tag for consensus log FI flags

2017-06-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [consensus] 'runtime' tag for consensus log FI flags .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7233 To unsubscribe,

[kudu-CR] Rename MiniClusterBase to MiniCluster

2017-06-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Rename MiniClusterBase to MiniCluster .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7273/1/src/kudu/integration-tests/mini_cluster.h

[kudu-CR] Rename MiniCluster to InternalMiniCluster

2017-06-23 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Rename MiniCluster to InternalMiniCluster .. Patch Set 1: (1 comment)

[kudu-CR] Simplify OpId/Timestamp assignment and make it atomic

2017-06-22 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7221 to look at the new patch set (#6). Change subject: Simplify OpId/Timestamp assignment and make it atomic ..

[kudu-CR] Simplify OpId/Timestamp assignment

2017-06-22 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7221 to look at the new patch set (#5). Change subject: Simplify OpId/Timestamp assignment .. Simplify OpId/Timestamp

<    1   2   3   4   5   6   7   8   9   10   >