[kudu-CR] [java client] Refactor all server info into a single class, add locality

2016-10-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Refactor all server info into a single class, add locality .. Patch Set 2: > Removed the following votes: > > * Verified-1 by Kudu Jenkins

[kudu-CR] KUDU-1715. Add a way to set ReplicaSelection to the java client

2016-10-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1715. Add a way to set ReplicaSelection to the java client .. Patch Set 2: > Removed the following votes: > > * Verified-1 by Kudu Jenkins (120) Al

[kudu-CR] WIP [java client] Implement RPC tracing

2016-10-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: WIP [java client] Implement RPC tracing .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4781/1/java/kudu-client/src/main/java/org/apache/k

[kudu-CR] [java client] Refactor all server info into a single class, add locality

2016-10-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Refactor all server info into a single class, add locality .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4836/2/java/kudu

[kudu-CR] KUDU-1715. Add a way to set ReplicaSelection to the java client

2016-10-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1715. Add a way to set ReplicaSelection to the java client .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/4837/2/java/kudu-client/sr

[kudu-CR] WIP [java client] Implement RPC tracing

2016-10-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new patch set (#2). Change subject: WIP [java client] Implement RPC tracing .. WIP [java client] Implement RPC tracing First stab at getting traces in the Java client. This patch is using a pret

[kudu-CR] [java client] Refactor all server info into a single class, add locality

2016-10-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new patch set (#3). Change subject: [java client] Refactor all server info into a single class, add locality .. [java client] Refactor all server info into a single class, add locality Having t

[kudu-CR] WIP [java client] Implement RPC tracing

2016-10-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: WIP [java client] Implement RPC tracing .. Patch Set 2: This is just a rebase on top of my other Java patches that I'm now depending on in this patch. --

[kudu-CR] KUDU-1715. Add a way to set ReplicaSelection to the java client

2016-10-25 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new patch set (#3). Change subject: KUDU-1715. Add a way to set ReplicaSelection to the java client .. KUDU-1715. Add a way to set ReplicaSelection to the java client This patch adds a ReplicaSe

[kudu-CR] WIP [java client] Implement RPC tracing

2016-10-26 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: WIP [java client] Implement RPC tracing .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4781/2/java/kudu-client/src/main/java/org/apache/k

[kudu-CR] Redirect krb5 stdout to SLF4j

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Redirect krb5 stdout to SLF4j .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4843 To unsubscribe, visit http://gerrit.clou

[kudu-CR] Redirect krb5 stdout to SLF4j

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Redirect krb5 stdout to SLF4j .. Redirect krb5 stdout to SLF4j Change-Id: Iaf49340cbe5f0630f2e0674274b94c853c4ccfc3 Reviewed-on: http://gerrit.clou

[kudu-CR] [java client] Refactor all server info into a single class, add locality

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4836 to look at the new patch set (#4). Change subject: [java client] Refactor all server info into a single class, add locality ...

[kudu-CR] [java client] Refactor all server info into a single class, add locality

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Refactor all server info into a single class, add locality .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/4836/3/java/kudu

[kudu-CR] [java client] Refactor all server info into a single class, add locality

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] Refactor all server info into a single class, add locality .. [java client] Refactor all server info into a single class, add localit

[kudu-CR] [java client] Refactor all server info into a single class, add locality

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Refactor all server info into a single class, add locality .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4836/4/java/kudu-

[kudu-CR] [java client] Refactor all server info into a single class, add locality

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Refactor all server info into a single class, add locality .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4836/4/java/kudu-

[kudu-CR] KUDU-1715. Add a way to set ReplicaSelection to the java client

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1715. Add a way to set ReplicaSelection to the java client .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4837 To uns

[kudu-CR] KUDU-1715. Add a way to set ReplicaSelection to the java client

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1715. Add a way to set ReplicaSelection to the java client .. Patch Set 4: > Patch Set 4: Code-Review+2 Carrying David's +2. -- To view, visit http:

[kudu-CR] KUDU-1715. Add a way to set ReplicaSelection to the java client

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1715. Add a way to set ReplicaSelection to the java client .. KUDU-1715. Add a way to set ReplicaSelection to the java client This patch adds

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4781 to look at the new patch set (#3). Change subject: [java client] Implement RPC tracing, part 1 ..

[kudu-CR] [java client] Remove timeouts when joining in the sync client

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4871 to review the following change. Change subject: [java client] Remove timeouts when joining in the sync client ...

[kudu-CR] [java client] KuduRpc.deserialize should throw KuduException

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4872 to review the following change. Change subject: [java client] KuduRpc.deserialize should throw KuduException

[kudu-CR] [java client] Remove timeouts when joining in the sync client

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Remove timeouts when joining in the sync client .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4871/1//COMMIT_MSG Commit Mes

[kudu-CR] [java client] KuduRpc.deserialize should throw KuduException

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] KuduRpc.deserialize should throw KuduException .. [java client] KuduRpc.deserialize should throw KuduException A vestige of our use o

[kudu-CR] [java client] Remove timeouts when joining in the sync client

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4871 to look at the new patch set (#2). Change subject: [java client] Remove timeouts when joining in the sync client ..

[kudu-CR] [java client] Remove timeouts when joining in the sync client

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Remove timeouts when joining in the sync client .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4871/2/java/kudu-client/src/m

[kudu-CR] [java client] Remove timeouts when joining in the sync client

2016-10-27 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4871 to look at the new patch set (#3). Change subject: [java client] Remove timeouts when joining in the sync client ..

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-10-28 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 .. Patch Set 3: (16 comments) > Would be nice to understand whether there's a perf impact to this, > to decide

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-10-28 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4781/3/java/kudu-client/src/test/java/org/apach

[kudu-CR] [java client] Remove timeouts when joining in the sync client

2016-10-28 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] Remove timeouts when joining in the sync client .. [java client] Remove timeouts when joining in the sync client Folks have often see

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-10-28 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4781 to look at the new patch set (#4). Change subject: [java client] Implement RPC tracing, part 1 .. [java client] Imp

[kudu-CR] [kudu-spark] Allow build against Spark 2.0 and Scala 2.11

2016-10-31 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [kudu-spark] Allow build against Spark 2.0 and Scala 2.11 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4886/1//COMMIT_MSG Commit Message

[kudu-CR] [kudu-spark] Allow build against Spark 2.0 and Scala 2.11

2016-10-31 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [kudu-spark] Allow build against Spark 2.0 and Scala 2.11 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4886/1/java/kudu-spark/pom.xml Fi

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-01 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/4781/3//COMMIT_MSG Commit Message: Line 30: R

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-01 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4781 to look at the new patch set (#5). Change subject: [java client] Implement RPC tracing, part 1 .. [java client] Imp

[kudu-CR](gh-pages) Add 11/1 weekly update

2016-11-01 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add 11/1 weekly update .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4912 To unsubscribe, visit http://gerrit.

[kudu-CR](gh-pages) Add 11/1 weekly update

2016-11-01 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Add 11/1 weekly update .. Add 11/1 weekly update Change-Id: I1e8f5ea5a4f6e591e7b349c9f336dbc68ae94b24 Reviewed-on: http://gerrit.cloudera.org:8080/

[kudu-CR] [kudu-spark] Allow build against Spark 2.0 with Scala 2.11

2016-11-02 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [kudu-spark] Allow build against Spark 2.0 with Scala 2.11 .. Patch Set 11: Code-Review+2 It looks like the Scala 2.11 build has new warnings that we should

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-02 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/4781/5//COMMIT_MSG Commit Message: PS5, Line

[kudu-CR] Avoid extra fsyncs of tombstoned tablets during startup

2016-11-02 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Avoid extra fsyncs of tombstoned tablets during startup .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4915/1/src/kudu/tablet/tablet_metad

[kudu-CR] [kudu-spark] Clean up some build warnings from Scala 2.11

2016-11-03 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [kudu-spark] Clean up some build warnings from Scala 2.11 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4924/1/java/kudu-spark/pom.xml Fi

[kudu-CR] [kudu-spark] Clean up some build warnings from Scala 2.11

2016-11-03 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [kudu-spark] Clean up some build warnings from Scala 2.11 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4924 To unsubscri

[kudu-CR] [kudu-spark] Clean up some build warnings from Scala 2.11

2016-11-03 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [kudu-spark] Clean up some build warnings from Scala 2.11 .. [kudu-spark] Clean up some build warnings from Scala 2.11 The new Spark 2.x with Scala

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-03 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4781/5/java/kudu-client/src/main/java/org/apach

[kudu-CR] Reject CREATE TABLE ops with even replication factor

2016-11-04 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Reject CREATE TABLE ops with even replication factor .. Patch Set 2: > Build Failed > > http://104.196.14.100/job/kudu-gerrit/4280/ : FAILURE Looks like

[kudu-CR] [java client] Cleanup "Connection reset" message in TabletClient

2016-11-04 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4947 to review the following change. Change subject: [java client] Cleanup "Connection reset" message in TabletClient

[kudu-CR] [java client] Small fix to logging in AsyncKuduClient.tooManyAttemptsOrTimeout

2016-11-04 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4948 to review the following change. Change subject: [java client] Small fix to logging in AsyncKuduClient.tooManyAttemptsOrTimeout .

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-04 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4781 to look at the new patch set (#6). Change subject: [java client] Implement RPC tracing, part 1 ..

[kudu-CR] [java client] Redirect KuduExceptions to RowError in KuduSession

2016-11-04 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4949 to review the following change. Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession

[kudu-CR] [java client] Implement RPC tracing, part 2

2016-11-04 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4950 to review the following change. Change subject: [java client] Implement RPC tracing, part 2 .. [java cli

[kudu-CR] block manager: better preallocation in log block manager

2016-11-04 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: block_manager: better preallocation in log block manager .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4848 To unsubscrib

[kudu-CR] block manager: better preallocation in log block manager

2016-11-04 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: block_manager: better preallocation in log block manager .. block_manager: better preallocation in log block manager As has been discussed to death

[kudu-CR] [java client] Redirect KuduExceptions to RowError in KuduSession

2016-11-04 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4949/1//COMMIT_MSG Commit

[kudu-CR] [java client] Redirect KuduExceptions to RowError in KuduSession

2016-11-04 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4949 to look at the new patch set (#2). Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession .

[kudu-CR] [java client] Implement RPC tracing, part 2

2016-11-04 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 2 .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4950/1//COMMIT_MSG Commit Message: PS1, Line

[kudu-CR] [java client] Implement RPC tracing, part 2

2016-11-04 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4950 to look at the new patch set (#2). Change subject: [java client] Implement RPC tracing, part 2 ..

[kudu-CR] Add KuduTable.getFormattedRangePartitions method

2016-11-04 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add KuduTable.getFormattedRangePartitions method .. Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/4934/2/java/kudu-client/src/main/java/org

[kudu-CR] [java client] Implement RPC tracing, part 2

2016-11-04 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4950 to look at the new patch set (#3). Change subject: [java client] Implement RPC tracing, part 2 ..

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-04 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4781 to look at the new patch set (#8). Change subject: [java client] Implement RPC tracing, part 1 ..

[kudu-CR] [java client] Redirect KuduExceptions to RowError in KuduSession

2016-11-04 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4949 to look at the new patch set (#3). Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession .

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-04 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4781 to look at the new patch set (#9). Change subject: [java client] Implement RPC tracing, part 1 ..

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-04 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] Implement RPC tracing, part 1 .. [java client] Implement RPC tracing, part 1 First part of this work is adding the tracing objects an

[kudu-CR] [java client] Redirect KuduExceptions to RowError in KuduSession

2016-11-04 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession .. Patch Set 3: > I'll defer the +2 to Alexey; he's most familiar with the equivalent > se

[kudu-CR] [java client] Implement RPC tracing, part 2

2016-11-04 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] Implement RPC tracing, part 2 .. [java client] Implement RPC tracing, part 2 This patch adds pretty printing for the traces, and make

[kudu-CR] [c++ client] implemented session operations stats

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [c++ client] implemented session operations stats .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4974/2//COMMIT_MSG Commit Message: PS2,

[kudu-CR] [c++ client] implemented session operations stats

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [c++ client] implemented session operations stats .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4974/2//COMMIT_MSG Commit Message: PS2,

[kudu-CR] [java client] Redirect KuduExceptions to RowError in KuduSession

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4949/3/java/kudu-client/sr

[kudu-CR] [java client] Redirect KuduExceptions to RowError in KuduSession

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4949 to look at the new patch set (#4). Change subject: [java client] Redirect KuduExceptions to RowError in KuduSession

[kudu-CR] [python] - Expand KuduError capabilities

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [python] - Expand KuduError capabilities .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4885/1/python/kudu/tests/test_client.py File pytho

[kudu-CR] [python] - Expose additional scanner methods

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [python] - Expose additional scanner methods .. [python] - Expose additional scanner methods This patch exposes a few remaining scanner methods fro

[kudu-CR] [python] - Expose additional scanner methods

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [python] - Expose additional scanner methods .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4888 To unsubscribe, visit htt

[kudu-CR] KUDU-1648 - [python] Expose Setting of Range Partitions

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1648 - [python] Expose Setting of Range Partitions .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4795 To unsubscribe

[kudu-CR] KUDU-1648 - [python] Expose Setting of Range Partitions

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1648 - [python] Expose Setting of Range Partitions .. KUDU-1648 - [python] Expose Setting of Range Partitions Currently, the Python client doe

[kudu-CR] KUDU-1690 - [python] Enable setting of default values

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1690 - [python] Enable setting of default values .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4818 To unsubscribe,

[kudu-CR] [python] - Expand KuduError capabilities

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [python] - Expand KuduError capabilities .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4885 To unsubscribe, visit http://

[kudu-CR] KUDU-1690 - [python] Enable setting of default values

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1690 - [python] Enable setting of default values .. KUDU-1690 - [python] Enable setting of default values This patch enables the python client

[kudu-CR] [python] - Expand KuduError capabilities

2016-11-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [python] - Expand KuduError capabilities .. [python] - Expand KuduError capabilities The Python client currently doesn't support the full error rep

[kudu-CR] Avoid extra fsyncs of tombstoned tablets during startup

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Avoid extra fsyncs of tombstoned tablets during startup .. Avoid extra fsyncs of tombstoned tablets during startup At startup, we roll-forward the

[kudu-CR] Avoid extra fsyncs of tombstoned tablets during startup

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Avoid extra fsyncs of tombstoned tablets during startup .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4915 To unsubscribe

[kudu-CR] [docs] - Update 1.1 release notes for Python.

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [docs] - Update 1.1 release notes for Python. .. Patch Set 1: Code-Review+1 Content looks good, I added John for reviews since he cares about docs a lot. -

[kudu-CR] [java client] Wrong javadoc in KuduClient

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, John Russell, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5001 to review the following change. Change subject: [java client] Wrong javadoc in KuduClient .. [java client

[kudu-CR] Release notes for the Java client in 1.1

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, John Russell, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5002 to review the following change. Change subject: Release notes for the Java client in 1.1 .. Release notes

[kudu-CR] Release notes for the Java client in 1.1

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Release notes for the Java client in 1.1 .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/5002/1/docs/release_notes.adoc File docs/release_

[kudu-CR] Release notes for the Java client in 1.1

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, John Russell, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5002 to look at the new patch set (#2). Change subject: Release notes for the Java client in 1.1 ..

[kudu-CR] [doc] 1.1.0 release notes for tools

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [doc] 1.1.0 release notes for tools .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5012/1/docs/release_notes.adoc File docs/release_notes

[kudu-CR] Add IN LIST release notes

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add IN LIST release notes .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5010/1/docs/release_notes.adoc File docs/release_notes.adoc: PS1

[kudu-CR] Enforce that REINSERTs are not supported in DeltaMemStores

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Enforce that REINSERTs are not supported in DeltaMemStores .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4991 To unsubscr

[kudu-CR] Account for REINSERTs in delta stats

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Account for REINSERTs in delta stats .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4932 To unsubscribe, visit http://gerr

[kudu-CR] Add IN LIST release notes

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add IN LIST release notes .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5010 To unsubscribe, visit http://gerrit.cloudera

[kudu-CR] Release notes for the Java client in 1.1

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Release notes for the Java client in 1.1 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5002/1/docs/release_notes.adoc File docs/release_n

[kudu-CR] Release notes for the Java client in 1.1

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, John Russell, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5002 to look at the new patch set (#3). Change subject: Release notes for the Java client in 1.1 ..

[kudu-CR] Don't do UNDO garbage collection until after the REDO->UNDO transformation

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Don't do UNDO garbage collection until after the REDO->UNDO transformation .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4993/2/src/kudu

[kudu-CR] Consolidate Row/CompactionInputRow printing on compaction

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Consolidate Row/CompactionInputRow printing on compaction .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4988/2/src/kudu/tablet/compaction

[kudu-CR] Improve debuggability of the delta/compaction path

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Improve debuggability of the delta/compaction path .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/4930/3//COMMIT_MSG Commit Message: PS3

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param .. Patch Set 5: (1 comment) http://gerrit.cloudera.

[kudu-CR] [doc] 1.1.0 release notes for tools

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [doc] 1.1.0 release notes for tools .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5012/2/docs/release_notes.adoc File docs/release_notes

[kudu-CR] Unbreak the build: Pull RowChangelistEncoder::get type()

2016-11-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Unbreak the build: Pull RowChangelistEncoder::get_type() .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5013 To unsubscrib

[kudu-CR] Release notes for the Java client in 1.1

2016-11-09 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5002 to look at the new patch set (#4). Change subject: Release notes for the Java client in 1.1 .. Release

[kudu-CR] Release notes for the Java client in 1.1

2016-11-09 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Release notes for the Java client in 1.1 .. Patch Set 4: Had to rebase and solve conflicts due to the other release notes that came in. David, you good wit

<    3   4   5   6   7   8   9   10   >