[kudu-CR] KUDU-1538: prevent block ID reuse to avoid potential data loss
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1538: prevent block ID reuse to avoid potential data loss .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2601/ -- To view, visit http://gerrit.cloudera.org:8080/3719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id45bf81bd6bccd51937c358716ace895ccee469c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] KUDU-1538: prevent block ID reuse to avoid potential data loss
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3719 to look at the new patch set (#2). Change subject: KUDU-1538: prevent block ID reuse to avoid potential data loss .. KUDU-1538: prevent block ID reuse to avoid potential data loss This changes the block managers to allocate block IDs sequentially rather than randomly. Given our 64-bit block IDs, this prevents ever reusing an ID (it would take thousands of years even at unrealistically high allocation rates). The trickiness of this patch is that, in many unit tests, the BlockCache singleton ends up persisting across multiple separate block managers. Even though the test has torn down and recreated a new block manager, the BlockCache continues to cache entries from the previous block manager. With the block IDs starting from '1', we would be sure to have a collision and many tests failed. The workaround is for the LBM to notice when it is running in a gtest (by way of some weak symbol magic) and start its allocation at a random point in block space, rather than starting at 1. For the FBM, I did a simpler workaround and just always started allocation at a random point, since the FBM doesn't scan its block list at startup and therefore would likely suffer collisions at startup even in the 'normal' (non-test) case. Unfortunately there's no real way to write a regression test for this: it would only produce itself after inserting tens of terabytes of data in the presence of lots of remote bootstraps, etc. Change-Id: Id45bf81bd6bccd51937c358716ace895ccee469c --- M src/kudu/fs/block_manager-test.cc M src/kudu/fs/file_block_manager.cc M src/kudu/fs/file_block_manager.h M src/kudu/fs/log_block_manager.cc M src/kudu/fs/log_block_manager.h M src/kudu/util/test_util.cc 6 files changed, 50 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/3719/2 -- To view, visit http://gerrit.cloudera.org:8080/3719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id45bf81bd6bccd51937c358716ace895ccee469c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1538 (WIP): prevent LBM block ID reuse to avoid potential data loss
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1538 (WIP): prevent LBM block ID reuse to avoid potential data loss .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2600/ -- To view, visit http://gerrit.cloudera.org:8080/3719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id45bf81bd6bccd51937c358716ace895ccee469c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] KUDU-1538 (WIP): prevent LBM block ID reuse to avoid potential data loss
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3719 to review the following change. Change subject: KUDU-1538 (WIP): prevent LBM block ID reuse to avoid potential data loss .. KUDU-1538 (WIP): prevent LBM block ID reuse to avoid potential data loss This changes the LogBlockManager to allocate block IDs sequentially rather than randomly. Given our 64-bit block IDs, this prevents ever reusing an ID (it would take thousands of years even at unrealistically high allocation rates). The trickiness of this patch is that, in many unit tests, the BlockCache singleton ends up persisting across multiple separate LogBlockManagers. Even though the test has torn down and recreated a new block manager, the BlockCache continues to cache entries from the previous block manager. With the block IDs starting from '1', we would be sure to have a collision and many tests failed. The workaround is for the LBM to notice when it is running in a gtest (by way of some weak symbol magic) and start its allocation at a random point in block space, rather than starting at 1. Unfortunately there's no real way to write a regression test for this: it would only produce itself after inserting tens of terabytes of data in the presence of lots of remote bootstraps, etc. WIP because we probably should do the same fix for FBM. Change-Id: Id45bf81bd6bccd51937c358716ace895ccee469c --- M src/kudu/fs/block_manager-test.cc M src/kudu/fs/log_block_manager.cc M src/kudu/fs/log_block_manager.h M src/kudu/util/test_util.cc 4 files changed, 38 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/3719/1 -- To view, visit http://gerrit.cloudera.org:8080/3719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id45bf81bd6bccd51937c358716ace895ccee469c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo
[kudu-CR] ksck: improve filtering capability
Jean-Daniel Cryans has posted comments on this change. Change subject: ksck: improve filtering capability .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6ef8ab20679a9967c321cd4f8412ea4ea5fd50d Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] ksck: improve output for long-running ksck checksums
Jean-Daniel Cryans has posted comments on this change. Change subject: ksck: improve output for long-running ksck checksums .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3715/1//COMMIT_MSG Commit Message: PS1, Line 11: nit -- To view, visit http://gerrit.cloudera.org:8080/3715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a9962329570e8383087747d36cee9ad4fa60825 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: Yes
[kudu-CR] master: do not delete unknown tablets
Kudu Jenkins has posted comments on this change. Change subject: master: do not delete unknown tablets .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/2599/ -- To view, visit http://gerrit.cloudera.org:8080/3645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I331f2d5bb06c38daa7b09854dbb24a7881723551 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] master: do not delete unknown tablets
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3645 to look at the new patch set (#8). Change subject: master: do not delete unknown tablets .. master: do not delete unknown tablets Quoting from docs/design-docs/multi-master-1.0.md: "The master and/or tserver must enforce that all actions take effect iff they were sent by the master that is currently the leader. After an exhaustive audit of all master state changes (see appendix A), it was determined that the current protection mechanisms built into each RPC are sufficient to provide fencing. The one exception is orphaned replica deletion done in response to a heartbeat. To protect against that, true orphans (i.e. tablets for which no persistent record exists) will not be deleted at all. As the master retains deleted table/tablet metadata in perpetuity, this should ensure that true orphans appear only under drastic circumstances, such as a tserver that heartbeats to the wrong cluster." The new test isn't ideal in that it must wait some time to allow the tserver to receive an RPC from the master, but on my laptop it does fail without the fix, and it should fail fairly often in other machines/environments too. Change-Id: I331f2d5bb06c38daa7b09854dbb24a7881723551 --- M src/kudu/integration-tests/create-table-itest.cc M src/kudu/integration-tests/delete_table-test.cc M src/kudu/master/catalog_manager.cc 3 files changed, 78 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/3645/8 -- To view, visit http://gerrit.cloudera.org:8080/3645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I331f2d5bb06c38daa7b09854dbb24a7881723551 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] ksck: fix a crash in checksum mode on tables with many tablets
Jean-Daniel Cryans has posted comments on this change. Change subject: ksck: fix a crash in checksum mode on tables with many tablets .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3714 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ca7ef75bd22ce27885e31ab20cf0e8e0ee2d355 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] ksck: also print info about the good replicas for a bad tablet
Jean-Daniel Cryans has posted comments on this change. Change subject: ksck: also print info about the good replicas for a bad tablet .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3706 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0dcefe5a7b00c77a116cc40601cce13cf8a0112 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] ksck: multi-thread the fetching of replica info from tablet servers
Jean-Daniel Cryans has posted comments on this change. Change subject: ksck: multi-thread the fetching of replica info from tablet servers .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7784697fb227743dccaa98922fb958cd6a3270e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] master: additional leader lock assertions in catalog manager
Kudu Jenkins has posted comments on this change. Change subject: master: additional leader lock assertions in catalog manager .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2597/ -- To view, visit http://gerrit.cloudera.org:8080/3684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bb2f5067cdbdd93900a80255def65a26216f6ea Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] c++ client: use operation timeout as deadline for finding new leader master
Kudu Jenkins has posted comments on this change. Change subject: c++ client: use operation timeout as deadline for finding new leader master .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2598/ -- To view, visit http://gerrit.cloudera.org:8080/3718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d770875bbf4703444abac11dbc232d7e382165e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1374: send full tablet report when new leader master is detected
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1374: send full tablet report when new leader master is detected .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2593/ -- To view, visit http://gerrit.cloudera.org:8080/3643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic16fc46736476dba39616e79ecfe79eee48b3d7f Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] master: do not delete unknown tablets
Hello Dan Burkert, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3645 to look at the new patch set (#7). Change subject: master: do not delete unknown tablets .. master: do not delete unknown tablets Quoting from docs/design-docs/multi-master-1.0.md: "The master and/or tserver must enforce that all actions take effect iff they were sent by the master that is currently the leader. After an exhaustive audit of all master state changes (see appendix A), it was determined that the current protection mechanisms built into each RPC are sufficient to provide fencing. The one exception is orphaned replica deletion done in response to a heartbeat. To protect against that, true orphans (i.e. tablets for which no persistent record exists) will not be deleted at all. As the master retains deleted table/tablet metadata in perpetuity, this should ensure that true orphans appear only under drastic circumstances, such as a tserver that heartbeats to the wrong cluster." The new test isn't ideal in that it must wait some time to allow the tserver to receive an RPC from the master, but on my laptop it does fail without the fix, and it should fail fairly often in other machines/environments too. Change-Id: I331f2d5bb06c38daa7b09854dbb24a7881723551 --- M src/kudu/integration-tests/create-table-itest.cc M src/kudu/integration-tests/delete_table-test.cc M src/kudu/master/catalog_manager.cc 3 files changed, 77 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/3645/7 -- To view, visit http://gerrit.cloudera.org:8080/3645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I331f2d5bb06c38daa7b09854dbb24a7881723551 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1358 (part 2): heartbeat to every master
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1358 (part 2): heartbeat to every master .. Patch Set 11: Build Started http://104.196.14.100/job/kudu-gerrit/2596/ -- To view, visit http://gerrit.cloudera.org:8080/3610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic85ac4193462d21c989dbd7874b451e8eaab8e3e Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] c++ client: use operation timeout as deadline for finding new leader master
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3718 to review the following change. Change subject: c++ client: use operation timeout as deadline for finding new leader master .. c++ client: use operation timeout as deadline for finding new leader master We had been using the default RPC timeout, which may be set to a very low value as in ClientStressTest_MultiMaster_TestLeaderResolutionTimeout. Now we'll use the operation timeout as the overall deadline while still preserving the semantics of using the default RPC timeout for the GetMasterRegistration() RPCs themselves. As my patch series removes the guarantee that a leader master is elected at the time that cluster tests run, it's important that the logic for finding the leader master provide ample time for an election to finish. Also, I think I've addressed the root cause behind KUDU-573 by fixing a race in GetLeaderMasterRpc's SendRpcCb() and GetMasterRegistrationRpcCbForNode() methods. The race manifests when the last two RPC responses are "I am the leader" and "I am not the leader" respectively. In one interleaving, both responses enter SendRpcCb(), and the second calls DelayedRetryCb(). If that were a call to DelayedRetry() instead, the GetLeaderMasterRpc would be destroyed by the time the reactor thread reran the RPC. Change-Id: I0d770875bbf4703444abac11dbc232d7e382165e --- M src/kudu/client/client-internal.cc M src/kudu/integration-tests/external_mini_cluster.cc M src/kudu/master/master_rpc.cc M src/kudu/master/master_rpc.h M src/kudu/tserver/heartbeater.cc 5 files changed, 52 insertions(+), 38 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/3718/1 -- To view, visit http://gerrit.cloudera.org:8080/3718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0d770875bbf4703444abac11dbc232d7e382165e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1358 (part 3): new multi-master stress test
Hello Dan Burkert, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3611 to look at the new patch set (#11). Change subject: KUDU-1358 (part 3): new multi-master stress test .. KUDU-1358 (part 3): new multi-master stress test This commit adds a stress test for multiple masters. The idea is simple: issue DDL operations at a high rate while periodically restarting a master. There's a balance to be struck both in the throughput of the operations and in the periodicity of the restarts; we need to ensure that the masters can make enough forward progress (in spite of the failures) to process all of the requests without timing out. To assist, the client uses abnormally long timeouts on all operations. Change-Id: I40b5b78c100a7b427b2f4aac3a54665e82a9618c --- M src/kudu/integration-tests/CMakeLists.txt A src/kudu/integration-tests/master-stress-test.cc 2 files changed, 421 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/3611/11 -- To view, visit http://gerrit.cloudera.org:8080/3611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I40b5b78c100a7b427b2f4aac3a54665e82a9618c Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] ksck: report hostnames instead of IP addresses for tablet servers
Jean-Daniel Cryans has posted comments on this change. Change subject: ksck: report hostnames instead of IP addresses for tablet servers .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8164dca050fd1adcc034a91cebc241e6fff8a117 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] KUDU-1374: send full tablet report when new leader master is detected
Hello Dan Burkert, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3643 to look at the new patch set (#7). Change subject: KUDU-1374: send full tablet report when new leader master is detected .. KUDU-1374: send full tablet report when new leader master is detected This should help prevent missed tablet reports in very specific edge cases, detailed in the bug report. The new integration test fails 100% of the time without the change, and passes 100% of the time with it. Change-Id: Ic16fc46736476dba39616e79ecfe79eee48b3d7f --- M src/kudu/integration-tests/master_failover-itest.cc M src/kudu/master/catalog_manager.cc M src/kudu/tserver/heartbeater.cc 3 files changed, 100 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/3643/7 -- To view, visit http://gerrit.cloudera.org:8080/3643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic16fc46736476dba39616e79ecfe79eee48b3d7f Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1358 (part 2): heartbeat to every master
Hello Dan Burkert, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3610 to look at the new patch set (#11). Change subject: KUDU-1358 (part 2): heartbeat to every master .. KUDU-1358 (part 2): heartbeat to every master Now that followers accept heartbeats, let's modify the tserver to send one to every master. Spawning a heartbeater thread for each master seemed like the natural way to do this; it should simplify dynamic master changes in the future (i.e. just add or remove threads as needed). The "dirty tablet" state is now encapsulated in the heartbeater threads themselves, and the heartbeater must "fan out" to manipulate all of it. It's a little noisy but I think it's reasonable. The alternative is for this state to remain in the TSTabletManager, for the heartbeater to continue tracking which master is the leader, and for it to only send tablet reports to that master. This can be done with a few changes (e.g. adding term numbers to the heartbeat response), but the only benefit is reduced network traffic when tablets are dirty, so that didn't seem worth the complexity. There's no new test here, but this code path is exercised in the test I reenabled, and in the new stress test (follow-on patch). Change-Id: Ic85ac4193462d21c989dbd7874b451e8eaab8e3e --- M src/kudu/integration-tests/master_failover-itest.cc M src/kudu/integration-tests/ts_tablet_manager-itest.cc M src/kudu/tserver/heartbeater.cc M src/kudu/tserver/heartbeater.h M src/kudu/tserver/ts_tablet_manager-test.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/ts_tablet_manager.h 7 files changed, 311 insertions(+), 264 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/3610/11 -- To view, visit http://gerrit.cloudera.org:8080/3610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic85ac4193462d21c989dbd7874b451e8eaab8e3e Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] master: do not delete unknown tablets
Kudu Jenkins has posted comments on this change. Change subject: master: do not delete unknown tablets .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2592/ -- To view, visit http://gerrit.cloudera.org:8080/3645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I331f2d5bb06c38daa7b09854dbb24a7881723551 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1358 (part 1): master should accept heartbeat even if follower
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1358 (part 1): master should accept heartbeat even if follower .. Patch Set 11: Build Started http://104.196.14.100/job/kudu-gerrit/2594/ -- To view, visit http://gerrit.cloudera.org:8080/3609 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I578674927b65b4171e8437de8515130e4a0ed139 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1358 (part 3): new multi-master stress test
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1358 (part 3): new multi-master stress test .. Patch Set 11: Build Started http://104.196.14.100/job/kudu-gerrit/2595/ -- To view, visit http://gerrit.cloudera.org:8080/3611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40b5b78c100a7b427b2f4aac3a54665e82a9618c Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1358 (part 1): master should accept heartbeat even if follower
Hello Dan Burkert, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3609 to look at the new patch set (#11). Change subject: KUDU-1358 (part 1): master should accept heartbeat even if follower .. KUDU-1358 (part 1): master should accept heartbeat even if follower This patch changes the master's heartbeat acceptance code so that heartbeats are not rejected outright if the master is a follower. To be specific, tablet reports are ignored, but heartbeats are processed just enough to warm the TSDescriptor cache. That way, if this master is elected leader, it can respond to a CreateTable() even before the first round of heartbeats. I reduced the complexity of the "should this tserver register or send a full tablet report?" dance by removing TSDescriptor.has_tablet_report_. It was used to guarantee a full tablet report in the event that 1) the tserver is sending incremental tablet reports, and 2) the master has already registered the tserver. I don't think this exact sequence of events is actually possible; the only way a master can "lose" a cached TSDescriptor is if the master is restarted, at which point it loses the tserver registration too. Plus, all the unit tests passed (in slow mode). I also snuck in a fix to TSManager::RegisterTS: it wasn't actually returning a TSDescriptor in its out parameter. Change-Id: I578674927b65b4171e8437de8515130e4a0ed139 --- M src/kudu/integration-tests/alter_table-test.cc M src/kudu/integration-tests/master_replication-itest.cc M src/kudu/integration-tests/mini_cluster.cc M src/kudu/integration-tests/mini_cluster.h M src/kudu/integration-tests/registration-test.cc M src/kudu/integration-tests/table_locations-itest.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/catalog_manager.h M src/kudu/master/master-test.cc M src/kudu/master/master_service.cc M src/kudu/master/ts_descriptor.cc M src/kudu/master/ts_descriptor.h M src/kudu/master/ts_manager.cc 13 files changed, 216 insertions(+), 124 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/3609/11 -- To view, visit http://gerrit.cloudera.org:8080/3609 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I578674927b65b4171e8437de8515130e4a0ed139 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1516 ksck should check for more raft-related status issues (partial)
Jean-Daniel Cryans has posted comments on this change.
Change subject: KUDU-1516 ksck should check for more raft-related status issues
(partial)
..
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3632/4/src/kudu/tools/ksck.cc
File src/kudu/tools/ksck.cc:
Line 484:
nit: extra empty line
Line 560: errors.push_back(Substitute("$0 does not have a majority of
replicas in RUNNING state",
Not sure about that one, I've seen clusters that had more tombstone'd tablets
than live ones but it's not really a problem.
http://gerrit.cloudera.org:8080/#/c/3632/4/src/kudu/tools/ksck.h
File src/kudu/tools/ksck.h:
Line 235:
nit: extra empty line?
--
To view, visit http://gerrit.cloudera.org:8080/3632
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec6590ba52548a9ee11d63269b134320b10809da
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy
Gerrit-Reviewer: Todd Lipcon
Gerrit-Reviewer: Will Berkeley
Gerrit-HasComments: Yes
[kudu-CR] WIP: KUDU-1536. ksck checksum scan crashes if a replica is on a server not known to master
Kudu Jenkins has posted comments on this change. Change subject: WIP: KUDU-1536. ksck checksum scan crashes if a replica is on a server not known to master .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2591/ -- To view, visit http://gerrit.cloudera.org:8080/3717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb2650d96674d816ceb671de8c74f317840ca842 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] WIP: KUDU-1536. ksck checksum scan crashes if a replica is on a server not known to master
Hello Jean-Daniel Cryans, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3717 to review the following change. Change subject: WIP: KUDU-1536. ksck checksum scan crashes if a replica is on a server not known to master .. WIP: KUDU-1536. ksck checksum scan crashes if a replica is on a server not known to master This fixes a crash if a tablet has a replica on a tablet server which has never heartbeated to the current master. WIP: need a test for this Change-Id: Idb2650d96674d816ceb671de8c74f317840ca842 --- M src/kudu/tools/ksck.cc 1 file changed, 9 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/3717/1 -- To view, visit http://gerrit.cloudera.org:8080/3717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idb2650d96674d816ceb671de8c74f317840ca842 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy
[kudu-CR] ksck: improve filtering capability
Hello Jean-Daniel Cryans, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3716 to review the following change. Change subject: ksck: improve filtering capability .. ksck: improve filtering capability - filters can now use glob-like pattern syntax - filters now apply for the metadata checks, not just the checksums Change-Id: Ic6ef8ab20679a9967c321cd4f8412ea4ea5fd50d --- M src/kudu/integration-tests/cluster_verifier.cc M src/kudu/tools/ksck-test.cc M src/kudu/tools/ksck.cc M src/kudu/tools/ksck.h M src/kudu/tools/ksck_remote-test.cc M src/kudu/tools/kudu-ksck.cc 6 files changed, 110 insertions(+), 60 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/3716/1 -- To view, visit http://gerrit.cloudera.org:8080/3716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic6ef8ab20679a9967c321cd4f8412ea4ea5fd50d Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy
[kudu-CR] ksck: improve filtering capability
Kudu Jenkins has posted comments on this change. Change subject: ksck: improve filtering capability .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2590/ -- To view, visit http://gerrit.cloudera.org:8080/3716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6ef8ab20679a9967c321cd4f8412ea4ea5fd50d Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] KUDU-1374: send full tablet report when new leader master is detected
Adar Dembo has posted comments on this change. Change subject: KUDU-1374: send full tablet report when new leader master is detected .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/3643/6/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 156: DEFINE_bool(catalog_manager_fail_async_rpcs, false, > what about swapping 'async' for 'ts'. When I read the previous test, my fi Done -- To view, visit http://gerrit.cloudera.org:8080/3643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic16fc46736476dba39616e79ecfe79eee48b3d7f Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] master: do not delete unknown tablets
Dan Burkert has posted comments on this change. Change subject: master: do not delete unknown tablets .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I331f2d5bb06c38daa7b09854dbb24a7881723551 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1358 (part 3): new multi-master stress test
Adar Dembo has posted comments on this change.
Change subject: KUDU-1358 (part 3): new multi-master stress test
..
Patch Set 10:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3611/10/src/kudu/integration-tests/master-stress-test.cc
File src/kudu/integration-tests/master-stress-test.cc:
Line 87: virtual void SetUp() OVERRIDE {
> void SetUp() override {
Done
Line 212: // The client retried after the RPC timed out, but the master
did in
> Seems to me this is unlikely to timeout, since it's not really doing much o
It's not possible for another thread to race in the rename/delete due to how
BlockingGetTableName()/PutTableName() work. So this really is all about the
timeouts.
Line 238: // TODO: Should be fixed with Exactly Once semantics, see
KUDU-1537.
> same here
See above.
--
To view, visit http://gerrit.cloudera.org:8080/3611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40b5b78c100a7b427b2f4aac3a54665e82a9618c
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: David Ribeiro Alves
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1374: send full tablet report when new leader master is detected
Dan Burkert has posted comments on this change. Change subject: KUDU-1374: send full tablet report when new leader master is detected .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/3643/6/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 156: DEFINE_bool(catalog_manager_fail_async_rpcs, false, what about swapping 'async' for 'ts'. When I read the previous test, my first question was "how is the alter table replicated to the other masters if all async RPCs are disabled?" -- To view, visit http://gerrit.cloudera.org:8080/3643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic16fc46736476dba39616e79ecfe79eee48b3d7f Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] KUDU-1358 (part 3): new multi-master stress test
Dan Burkert has posted comments on this change. Change subject: KUDU-1358 (part 3): new multi-master stress test .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/3611/10/src/kudu/integration-tests/master-stress-test.cc File src/kudu/integration-tests/master-stress-test.cc: Line 294: ExternalMaster* master = cluster_->master( > maybe a rolling restart would be more effective at shuffling around the mas Feel free to ignore this, I don't think it really matters, and may mask two-in-a-row type issues -- To view, visit http://gerrit.cloudera.org:8080/3611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40b5b78c100a7b427b2f4aac3a54665e82a9618c Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] KUDU-1358 (part 3): new multi-master stress test
Dan Burkert has posted comments on this change.
Change subject: KUDU-1358 (part 3): new multi-master stress test
..
Patch Set 10:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/3611/2/src/kudu/integration-tests/master-stress-test.cc
File src/kudu/integration-tests/master-stress-test.cc:
Line 87: virtual void SetUp() OVERRIDE {
signature should look like
void SetUp() override {
here and below
http://gerrit.cloudera.org:8080/#/c/3611/10/src/kudu/integration-tests/master-stress-test.cc
File src/kudu/integration-tests/master-stress-test.cc:
Line 87: virtual void SetUp() OVERRIDE {
void SetUp() override {
here and below
Line 174: if (s.IsServiceUnavailable()) {
This still seems really funky to me, but oh well.
Line 212: // The client retried after the RPC timed out, but the master
did in
Seems to me this is unlikely to timeout, since it's not really doing much on
the master side before returning. The NotFound returns are more likely due to
another thread renaming or deleting the table.
Line 238: // TODO: Should be fixed with Exactly Once semantics, see
KUDU-1537.
same here
Line 294: ExternalMaster* master = cluster_->master(
maybe a rolling restart would be more effective at shuffling around the master?
i.e. keep a counter and pick the master by (++counter % master_count)
--
To view, visit http://gerrit.cloudera.org:8080/3611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40b5b78c100a7b427b2f4aac3a54665e82a9618c
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: David Ribeiro Alves
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1358 (part 2): heartbeat to every master
Dan Burkert has posted comments on this change. Change subject: KUDU-1358 (part 2): heartbeat to every master .. Patch Set 10: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic85ac4193462d21c989dbd7874b451e8eaab8e3e Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1358 (part 1): master should accept heartbeat even if follower
Dan Burkert has posted comments on this change. Change subject: KUDU-1358 (part 1): master should accept heartbeat even if follower .. Patch Set 10: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3609 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I578674927b65b4171e8437de8515130e4a0ed139 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master
Mike Percy has posted comments on this change. Change subject: KUDU-1492: Show column encodings/compression on table page in master .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master
Mike Percy has submitted this change and it was merged. Change subject: KUDU-1492: Show column encodings/compression on table page in master .. KUDU-1492: Show column encodings/compression on table page in master This displays column attributes for the table schema in picture. If the table schema doesn't specify these attributes, AUTO_ENCODING or DEFAULT_COMPRESSION are displayed which means whatever is the current default value attributes in the given release. E.g., release 0.9.1 has values PLAIN_ENCODING for encoding and NO_COMPRESSION for compression. Sample results are posted in JIRA KUDU-1492. Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Reviewed-on: http://gerrit.cloudera.org:8080/3667 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy --- M src/kudu/server/webui_util.cc 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Mike Percy: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] Doxygen for C++ client API
Dan Burkert has posted comments on this change. Change subject: Doxygen for C++ client API .. Patch Set 12: OK that's all my feedback. Thanks again for taking this on! -- To view, visit http://gerrit.cloudera.org:8080/3619 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones Gerrit-HasComments: No
[kudu-CR] Doxygen for C++ client API
Dan Burkert has posted comments on this change. Change subject: Doxygen for C++ client API .. Patch Set 12: (19 comments) http://gerrit.cloudera.org:8080/#/c/3619/12/src/kudu/client/client.h File src/kudu/client/client.h: Line 469: /// For each set of hash partitions added to the table, the total number of s/table partitions/tablets Line 472: /// with 4 and 5 buckets respectively, the total number of table partitions s/table partitions/tablets Line 505: /// call this method with an empty vector and set no split rows an no hash s/an/and Line 517: /// If no range split rows are added, no range pre-splitting is performed. Remove this sentence; it's not true anymore since it can be done via range bounds. Line 559: /// Set the number of replicas for each tablet in the table. Referring to tablets in this is probably going to cause confusion. I think it would be better as: Set the table replication factor. Replicated tables can continue to read and write data while a majority of replicas are not failed. Line 567: /// Set the timeout for the operation. s/operation/table creation operation/ Line 622: /// This class is also a factory for write operation for on the table. s/for on/on Line 675: /// This method creates new instance of comparison predicate which s/of/of a Line 700: /// @return The KuduClient object associated with the table. add a note that the caller should not free the client. Line 725: /// Create a new instance of alterer using KuduClient::NewTableAlterer(). s/of alterer/of a table alterer Line 756: /// Alter an existing column. Add a note that the column may not be in the primary key. Line 764: /// Drops an existing column from the table. Add a note that they column may not be in the primary key. Line 771: /// Set timeout for the alteration operation. s/timeout/a timeout Line 814: /// @brief This class represents an error which occurred in a given operation. s/operation/write operation Line 1065: /// Apply the write operation in asynchronous mode. s/asynchronous mode/asynchronously Line 1089: /// @return Operation result status. Particularly, returns a bad status Returns a non-OK status if there... Line 1287: /// @copydoc KuduScanTokenBuilder::SetProjectedColumnIndexes() It's not an issue if the rendered docs come out the same, but this method should be considered the 'primary' use of this method, whereas the kudu scan token builder is really just copying this API. Line 1368: /// @return Operation result status. Particularly, this method returns s/Particularly/In particular Line 1493: /// @brief A partial scan limited to a single physical contiguous location. s/partital scan/scan descriptor -- To view, visit http://gerrit.cloudera.org:8080/3619 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones Gerrit-HasComments: Yes
[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions
Adar Dembo has posted comments on this change.
Change subject: KUDU-1311 [master] support adding and dropping range partitions
..
Patch Set 11:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3648/11/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
Line 1594: if (has_metadata_changes) {
What about this? Shouldn't it be the same condition as when setting
actions.table_to_update?
--
To view, visit http://gerrit.cloudera.org:8080/3648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be
Gerrit-PatchSet: 11
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] ksck: improve output for long-running ksck checksums
Kudu Jenkins has posted comments on this change. Change subject: ksck: improve output for long-running ksck checksums .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2589/ -- To view, visit http://gerrit.cloudera.org:8080/3715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a9962329570e8383087747d36cee9ad4fa60825 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] ksck: improve output for long-running ksck checksums
Hello Jean-Daniel Cryans, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3715 to review the following change. Change subject: ksck: improve output for long-running ksck checksums .. ksck: improve output for long-running ksck checksums Checksumming a large (multi-TB) table can take many minutes. Previously, the ksck output would be very quiet during that time, giving no indication as to whether it was making progress or how much work might be remaining. This addresses that by: - passing back how many bytes and number of rows have been summed so far on a regular basis - reporting progress every 5 seconds, including the above numbers Along the way, I decided that our default timeout of 5 minutes was way too low for typical table sizes, so bumped it to an hour. I also added more mock-based test coverage of the checksum-scan code path. Change-Id: I2a9962329570e8383087747d36cee9ad4fa60825 --- M src/kudu/tools/ksck-test.cc M src/kudu/tools/ksck.cc M src/kudu/tools/ksck.h M src/kudu/tools/ksck_remote-test.cc M src/kudu/tools/ksck_remote.cc M src/kudu/tools/ksck_remote.h M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tserver_service.proto 9 files changed, 179 insertions(+), 61 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/3715/1 -- To view, visit http://gerrit.cloudera.org:8080/3715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2a9962329570e8383087747d36cee9ad4fa60825 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy
[kudu-CR] ksck: fix a crash in checksum mode on tables with many tablets
Hello Jean-Daniel Cryans, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3714 to review the following change. Change subject: ksck: fix a crash in checksum mode on tables with many tablets .. ksck: fix a crash in checksum mode on tables with many tablets In the case that the list of tablets had to be fetched in multiple batches, we would improperly re-fetch the last tablet of the previous batch as the first tablet of the next batch. This would then cause a tablet to be inserted twice into the list, which would later cause a CHECK failure when we tried to InsertOrDie() this tablet ID into a map. This fixes the issue by making sure that we look for more tablets starting with the *successor* partition key compared to the previous tablet we fetched. I also updated the integration test to use a table with more tablets so that the batching code was exercised. Change-Id: I4ca7ef75bd22ce27885e31ab20cf0e8e0ee2d355 --- M src/kudu/tools/ksck_remote-test.cc M src/kudu/tools/ksck_remote.cc 2 files changed, 17 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/3714/1 -- To view, visit http://gerrit.cloudera.org:8080/3714 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4ca7ef75bd22ce27885e31ab20cf0e8e0ee2d355 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy
[kudu-CR] ksck: fix a crash in checksum mode on tables with many tablets
Kudu Jenkins has posted comments on this change. Change subject: ksck: fix a crash in checksum mode on tables with many tablets .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2588/ -- To view, visit http://gerrit.cloudera.org:8080/3714 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ca7ef75bd22ce27885e31ab20cf0e8e0ee2d355 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1492: Show column encodings/compression on table page in master .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3667/3/src/kudu/server/webui_util.cc File src/kudu/server/webui_util.cc: Line 53: const ColumnStorageAttributes& attrs = col.attributes(); > nit: it seems the indent for these new lines is off one shiftwidth. Consid Too many formatting errors for too little change :):), thanks Alexey. I am still in the process of figuring out a fancy GUI for this project, hence was relying on basic vim editor for this change. I corrected this one too. -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: Yes
[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1492: Show column encodings/compression on table page in master .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2587/ -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3667 to look at the new patch set (#4). Change subject: KUDU-1492: Show column encodings/compression on table page in master .. KUDU-1492: Show column encodings/compression on table page in master This displays column attributes for the table schema in picture. If the table schema doesn't specify these attributes, AUTO_ENCODING or DEFAULT_COMPRESSION are displayed which means whatever is the current default value attributes in the given release. E.g., release 0.9.1 has values PLAIN_ENCODING for encoding and NO_COMPRESSION for compression. Sample results are posted in JIRA KUDU-1492. Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 --- M src/kudu/server/webui_util.cc 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/3667/4 -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master
Alexey Serbin has posted comments on this change. Change subject: KUDU-1492: Show column encodings/compression on table page in master .. Patch Set 3: Code-Review+1 (1 comment) LGTM, just a small formatting nit. http://gerrit.cloudera.org:8080/#/c/3667/3/src/kudu/server/webui_util.cc File src/kudu/server/webui_util.cc: Line 53: const ColumnStorageAttributes& attrs = col.attributes(); nit: it seems the indent for these new lines is off one shiftwidth. Consider shifting them right to align with the rest of the code in the 'for' closure. -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: Yes
[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions
Dan Burkert has posted comments on this change.
Change subject: KUDU-1311 [master] support adding and dropping range partitions
..
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3648/9/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
Line 1522: if (has_metadata_changes) {
> But what if !tablets_to_add.empty() and !has_metadata_changes_for_existing_
Updated. I opted to keep the behavior as not incrementing the version on an
alter operation that only adds or removes tablets, since having the table be in
ALTER state multiple times for a given version does not seem to cause any
issues.
--
To view, visit http://gerrit.cloudera.org:8080/3648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1311 [master] support adding and dropping range partitions .. Patch Set 11: Build Started http://104.196.14.100/job/kudu-gerrit/2586/ -- To view, visit http://gerrit.cloudera.org:8080/3648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3648 to look at the new patch set (#11). Change subject: KUDU-1311 [master] support adding and dropping range partitions .. KUDU-1311 [master] support adding and dropping range partitions Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be --- M src/kudu/client/client-internal.cc M src/kudu/client/client-internal.h M src/kudu/client/client-test.cc M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/meta_cache.cc M src/kudu/client/meta_cache.h M src/kudu/client/table_alterer-internal.cc M src/kudu/client/table_alterer-internal.h M src/kudu/common/partition.cc M src/kudu/integration-tests/alter_table-randomized-test.cc M src/kudu/integration-tests/alter_table-test.cc M src/kudu/integration-tests/external_mini_cluster.cc M src/kudu/integration-tests/external_mini_cluster.h M src/kudu/master/catalog_manager.cc M src/kudu/master/catalog_manager.h M src/kudu/master/master.proto M src/kudu/master/master_service.cc M src/kudu/tools/ksck.cc 19 files changed, 1,180 insertions(+), 208 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/3648/11 -- To view, visit http://gerrit.cloudera.org:8080/3648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](gh-pages) www: Replace old Kudu logo with new responsive Apache Kudu logo
Mike Percy has posted comments on this change. Change subject: www: Replace old Kudu logo with new responsive Apache Kudu logo .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3178b8197e78ffd7f439fba0fcc35c702381fe57 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Mike Percy Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) www: Replace old Kudu logo with new responsive Apache Kudu logo
Mike Percy has submitted this change and it was merged. Change subject: www: Replace old Kudu logo with new responsive Apache Kudu logo .. www: Replace old Kudu logo with new responsive Apache Kudu logo Change-Id: I3178b8197e78ffd7f439fba0fcc35c702381fe57 Reviewed-on: http://gerrit.cloudera.org:8080/3708 Reviewed-by: Todd Lipcon Tested-by: Mike Percy --- M _includes/top_common.html M css/kudu.css M index.html 3 files changed, 23 insertions(+), 6 deletions(-) Approvals: Mike Percy: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/3708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3178b8197e78ffd7f439fba0fcc35c702381fe57 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Mike Percy Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR](gh-pages) www: Remove references to old Google Groups mailing list
Mike Percy has submitted this change and it was merged. Change subject: www: Remove references to old Google Groups mailing list .. www: Remove references to old Google Groups mailing list We missed some references when first entering incubation. Change-Id: Ic831f8cc4d4434bdde4415d86764e141f5dad3f7 Reviewed-on: http://gerrit.cloudera.org:8080/3710 Reviewed-by: Todd Lipcon Tested-by: Mike Percy --- M community.md M faq.md 2 files changed, 8 insertions(+), 6 deletions(-) Approvals: Mike Percy: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/3710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic831f8cc4d4434bdde4415d86764e141f5dad3f7 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Mike Percy Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR](gh-pages) www: Remove "incubating" from web site
Mike Percy has submitted this change and it was merged. Change subject: www: Remove "incubating" from web site .. www: Remove "incubating" from web site Also refer to the mailing lists as being at @kudu.apache.org TODO later after infrastructure-related changes: * Change our GitHub links to point to github.com/apache/kudu Change-Id: I5e246aa3b439d3ad1bb15c465ef0823f14fcc00b Reviewed-on: http://gerrit.cloudera.org:8080/3709 Reviewed-by: Todd Lipcon Tested-by: Mike Percy --- M _includes/bottom_common.html M _includes/top_common.html M _layouts/blog_layout.html M community.md M faq.md M index.html M overview.html M releases/index.md 8 files changed, 34 insertions(+), 46 deletions(-) Approvals: Mike Percy: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/3709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e246aa3b439d3ad1bb15c465ef0823f14fcc00b Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Mike Percy Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR](gh-pages) www: Remove "incubating" from web site
Mike Percy has posted comments on this change. Change subject: www: Remove "incubating" from web site .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e246aa3b439d3ad1bb15c465ef0823f14fcc00b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Mike Percy Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) www: Remove references to old Google Groups mailing list
Mike Percy has posted comments on this change. Change subject: www: Remove references to old Google Groups mailing list .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic831f8cc4d4434bdde4415d86764e141f5dad3f7 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Mike Percy Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] docs: Remove reference to old kudu-user mailing list
Mike Percy has submitted this change and it was merged. Change subject: docs: Remove reference to old kudu-user mailing list .. docs: Remove reference to old kudu-user mailing list Change-Id: I2752b7988d960a24be1597906226996e7a920d4c Reviewed-on: http://gerrit.cloudera.org:8080/3711 Reviewed-by: Todd Lipcon Tested-by: Kudu Jenkins --- M docs/installation.adoc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2752b7988d960a24be1597906226996e7a920d4c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1492: Show column encodings/compression on table page in master .. Patch Set 3: TFTR Alexey, good catches. Addressed all rev comments including massaging commit description. Please take a look at updated patch. -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1492: Show column encodings/compression on table page in master .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2585/ -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3667 to look at the new patch set (#3). Change subject: KUDU-1492: Show column encodings/compression on table page in master .. KUDU-1492: Show column encodings/compression on table page in master This displays column attributes for the table schema in picture. If the table schema doesn't specify these attributes, AUTO_ENCODING or DEFAULT_COMPRESSION are displayed which means whatever is the current default value attributes in the given release. E.g., release 0.9.1 has values PLAIN_ENCODING for encoding and NO_COMPRESSION for compression. Sample results are posted in JIRA KUDU-1492. Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 --- M src/kudu/server/webui_util.cc 1 file changed, 13 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/3667/3 -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR](gh-pages) www: Remove references to old Google Groups mailing list
Todd Lipcon has posted comments on this change. Change subject: www: Remove references to old Google Groups mailing list .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic831f8cc4d4434bdde4415d86764e141f5dad3f7 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) www: Remove "incubating" from web site
Todd Lipcon has posted comments on this change. Change subject: www: Remove "incubating" from web site .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e246aa3b439d3ad1bb15c465ef0823f14fcc00b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Mike Percy Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) www: Replace old Kudu logo with new responsive Apache Kudu logo
Todd Lipcon has posted comments on this change. Change subject: www: Replace old Kudu logo with new responsive Apache Kudu logo .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3178b8197e78ffd7f439fba0fcc35c702381fe57 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Mike Percy Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] docs: Remove reference to old kudu-user mailing list
Todd Lipcon has posted comments on this change. Change subject: docs: Remove reference to old kudu-user mailing list .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2752b7988d960a24be1597906226996e7a920d4c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Remove ASF incubation callouts
Mike Percy has posted comments on this change. Change subject: Remove ASF incubation callouts .. Patch Set 1: Code-Review+1 Other changes look good -- To view, visit http://gerrit.cloudera.org:8080/3699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic71f46177e20a7aa09deccb098841c70eaa5f289 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] Remove ASF incubation callouts
Mike Percy has posted comments on this change. Change subject: Remove ASF incubation callouts .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3699/1//COMMIT_MSG Commit Message: Line 13: - mailing list archive links Mailing list archive links apparently already work: http://mail-archives.apache.org/mod_mbox/kudu-user/ -- To view, visit http://gerrit.cloudera.org:8080/3699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic71f46177e20a7aa09deccb098841c70eaa5f289 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: Yes
[kudu-CR] docs: Remove reference to old kudu-user mailing list
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3711 to review the following change. Change subject: docs: Remove reference to old kudu-user mailing list .. docs: Remove reference to old kudu-user mailing list Change-Id: I2752b7988d960a24be1597906226996e7a920d4c --- M docs/installation.adoc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/3711/1 -- To view, visit http://gerrit.cloudera.org:8080/3711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2752b7988d960a24be1597906226996e7a920d4c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] docs: Remove reference to old kudu-user mailing list
Kudu Jenkins has posted comments on this change. Change subject: docs: Remove reference to old kudu-user mailing list .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2584/ -- To view, visit http://gerrit.cloudera.org:8080/3711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2752b7988d960a24be1597906226996e7a920d4c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) www: Remove references to old Google Groups mailing list
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3710 to review the following change. Change subject: www: Remove references to old Google Groups mailing list .. www: Remove references to old Google Groups mailing list We missed some references when first entering incubation. Change-Id: Ic831f8cc4d4434bdde4415d86764e141f5dad3f7 --- M community.md M faq.md 2 files changed, 8 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/3710/1 -- To view, visit http://gerrit.cloudera.org:8080/3710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic831f8cc4d4434bdde4415d86764e141f5dad3f7 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Doxygen for C++ client API
Dan Burkert has posted comments on this change. Change subject: Doxygen for C++ client API .. Patch Set 12: (23 comments) I'm still working on this so don't push quite yet. http://gerrit.cloudera.org:8080/#/c/3619/12/src/kudu/client/client.h File src/kudu/client/client.h: Line 92: /// Only the first invocation has effect; subsequent invocations are This needs to be 'any effect' or preferably 'an effect' Line 103: /// Only the first invocation has any effect; subsequent invocations are whatever you decide about 'an effect' above should probably be mirrored here. Line 145: /// @brief A "factory" for the KuduClient objects. s/for the/for Line 147: /// This class is used to create instances of KuduClient class s/of/of the Line 162: /// RPC addresses of masterts to add. s/masterts/masters Line 175: /// Set default timeout for administrative operations. s/default/the default Line 195: /// Create client object. s/client/a client Line 200: /// The newly created instance wrapped into a shared pointer. s/into/in Line 233: /// In order to actually access data on the cluster, callers must first s/actually access data on/write data to Line 239: /// @todo Cluster administration functions are likely to be in this class I'm not sure we actually want to change our TODO syntax; it's pretty consistent right now which allows for easy grepping. Perhaps this should remain, but not part of the formatted doxygen (is that possible by only using two slashes?). Line 247: /// @return Pointer to newly created instance; it's the caller's For consistency you should probably drop the contraction here and below. Line 251: /// Check whether CreateTable operation is in-progress. s/CreateTable/ a create table Line 269: /// Create a KuduTableAlterer object. It's probably best to be consistent about object vs. instance, for example NewTableCreator above uses instance. I don't have an opinion on what is more appropriate. Line 272: /// Name of the table to watch for. s/watch for/alter Line 280: /// Name of the table in question. remove 'in question' here and below, I don't think it adds any clarity. Line 310: /// Substring filter to use; empty sub-string filter matches any tables s/any tables/all tables. Line 326: /// If the table has not been opened before, then open the table I think this paragraph can be entirely removed, the first sentence is misleading, since we really don't do anything different in the case where you open an already 'opened' table. Line 359: /// @return @c true iff client was configured to talk to multiple s/was/is Line 373: /// Get highest HybridTime timestamp observed by the client. s/highest/the highest Line 388: /// To use this the user must obtain the HybridTime encoded timestamp from The HybridTime encoded timestamp should be obtained from another client's KuduClient::GetLatestObservedTimestamp() method. Line 442: /// Name of the target table -- it is copied. I would get rid of the note about the copy, it really shouldn't matter to callers. Line 443: /// @return Reference to the modified object. s/object/table creator Line 445: /// @remark Calling this method and setting name for the table-to-be s/name/the name -- To view, visit http://gerrit.cloudera.org:8080/3619 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Misty Stanley-Jones Gerrit-HasComments: Yes
[kudu-CR] [java client] Redo how we manage exceptions
Dan Burkert has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3055 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba6e8a022d7a5391c3657cbdc9d3f06f951be048 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) www: Remove "incubating" from web site
Mike Percy has posted comments on this change. Change subject: www: Remove "incubating" from web site .. Patch Set 1: Rendered at http://mpercy.github.io/kudu/ -- To view, visit http://gerrit.cloudera.org:8080/3709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e246aa3b439d3ad1bb15c465ef0823f14fcc00b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Mike Percy Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) www: Replace old Kudu logo with new responsive Apache Kudu logo
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3708 to review the following change. Change subject: www: Replace old Kudu logo with new responsive Apache Kudu logo .. www: Replace old Kudu logo with new responsive Apache Kudu logo Change-Id: I3178b8197e78ffd7f439fba0fcc35c702381fe57 --- M _includes/top_common.html M css/kudu.css M index.html 3 files changed, 23 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/3708/1 -- To view, visit http://gerrit.cloudera.org:8080/3708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3178b8197e78ffd7f439fba0fcc35c702381fe57 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR](gh-pages) www: Replace old Kudu logo with new responsive Apache Kudu logo
Mike Percy has posted comments on this change. Change subject: www: Replace old Kudu logo with new responsive Apache Kudu logo .. Patch Set 1: Rendered at http://mpercy.github.io/kudu/ -- To view, visit http://gerrit.cloudera.org:8080/3708 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3178b8197e78ffd7f439fba0fcc35c702381fe57 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Mike Percy Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](gh-pages) www: Remove "incubating" from web site
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3709 to review the following change. Change subject: www: Remove "incubating" from web site .. www: Remove "incubating" from web site Also refer to the mailing lists as being at @kudu.apache.org TODO later after infrastructure-related changes: * Change our GitHub links to point to github.com/apache/kudu Change-Id: I5e246aa3b439d3ad1bb15c465ef0823f14fcc00b --- M _includes/bottom_common.html M _includes/top_common.html M _layouts/blog_layout.html M community.md M faq.md M index.html M overview.html M releases/index.md 8 files changed, 34 insertions(+), 46 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/3709/1 -- To view, visit http://gerrit.cloudera.org:8080/3709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5e246aa3b439d3ad1bb15c465ef0823f14fcc00b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-Owner: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [java client] Redo how we manage exceptions
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3055 to look at the new patch set (#12). Change subject: [java client] Redo how we manage exceptions .. [java client] Redo how we manage exceptions Right now the exceptions are hard to handle in the Java client. They're all generic and you need to do a lot of introspection. For example, if you try to create a table that already exists, you need to start searching the exception's message to know if it's that or some other problem that gave you the error. With this patch we now only one main kind of public exception: KuduException. We still have Recoverable/NonRecoverableException but those are now package-private and only used internally. PleaseThrottleException is kept public for the async API. KuduException has a new field, `status`, which is your regular Kudu Status object. Wherever we can we try to recreate the Status objects that are sent to us from the servers, else we create our own. Now for the example above we can just query the exception's status with `isNotFound()`. The sync APIs is also modified to only throw KuduExceptions instead of plain Exceptions. Change-Id: Iba6e8a022d7a5391c3657cbdc9d3f06f951be048 --- M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java D java/kudu-client/src/main/java/org/kududb/client/ConnectionResetException.java M java/kudu-client/src/main/java/org/kududb/client/GetMasterRegistrationReceived.java D java/kudu-client/src/main/java/org/kududb/client/InvalidResponseException.java M java/kudu-client/src/main/java/org/kududb/client/KuduClient.java M java/kudu-client/src/main/java/org/kududb/client/KuduException.java M java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java M java/kudu-client/src/main/java/org/kududb/client/KuduScanner.java D java/kudu-client/src/main/java/org/kududb/client/KuduServerException.java M java/kudu-client/src/main/java/org/kududb/client/KuduSession.java D java/kudu-client/src/main/java/org/kududb/client/MasterErrorException.java M java/kudu-client/src/main/java/org/kududb/client/NoLeaderMasterFoundException.java M java/kudu-client/src/main/java/org/kududb/client/NonCoveredRangeException.java M java/kudu-client/src/main/java/org/kududb/client/NonRecoverableException.java M java/kudu-client/src/main/java/org/kududb/client/PleaseThrottleException.java M java/kudu-client/src/main/java/org/kududb/client/RecoverableException.java M java/kudu-client/src/main/java/org/kududb/client/RowResultIterator.java M java/kudu-client/src/main/java/org/kududb/client/Status.java M java/kudu-client/src/main/java/org/kududb/client/TabletClient.java D java/kudu-client/src/main/java/org/kududb/client/TabletServerErrorException.java M java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduSession.java M java/kudu-client/src/test/java/org/kududb/client/TestKuduSession.java M java/kudu-client/src/test/java/org/kududb/client/TestKuduTable.java M java/kudu-client/src/test/java/org/kududb/client/TestTimeouts.java 26 files changed, 406 insertions(+), 520 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/3055/12 -- To view, visit http://gerrit.cloudera.org:8080/3055 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iba6e8a022d7a5391c3657cbdc9d3f06f951be048 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [java client] Redo how we manage exceptions
Kudu Jenkins has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 12: Build Started http://104.196.14.100/job/kudu-gerrit/2583/ -- To view, visit http://gerrit.cloudera.org:8080/3055 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba6e8a022d7a5391c3657cbdc9d3f06f951be048 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] [java client] Redo how we manage exceptions
Jean-Daniel Cryans has posted comments on this change.
Change subject: [java client] Redo how we manage exceptions
..
Patch Set 11:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3055/11/java/kudu-client/src/main/java/org/kududb/client/KuduException.java
File java/kudu-client/src/main/java/org/kududb/client/KuduException.java:
Line 37: * sse if you're using the non-async API, such as {@link KuduSession}
instead of
> s/sse/see
Man I somehow reverted that change.
--
To view, visit http://gerrit.cloudera.org:8080/3055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba6e8a022d7a5391c3657cbdc9d3f06f951be048
Gerrit-PatchSet: 11
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon
Gerrit-HasComments: Yes
[kudu-CR] [java client] Redo how we manage exceptions
Dan Burkert has posted comments on this change.
Change subject: [java client] Redo how we manage exceptions
..
Patch Set 11:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3055/11/java/kudu-client/src/main/java/org/kududb/client/KuduException.java
File java/kudu-client/src/main/java/org/kududb/client/KuduException.java:
Line 37: * sse if you're using the non-async API, such as {@link KuduSession}
instead of
s/sse/see
--
To view, visit http://gerrit.cloudera.org:8080/3055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba6e8a022d7a5391c3657cbdc9d3f06f951be048
Gerrit-PatchSet: 11
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon
Gerrit-HasComments: Yes
[kudu-CR] [java client] Redo how we manage exceptions
Kudu Jenkins has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 11: Build Started http://104.196.14.100/job/kudu-gerrit/2582/ -- To view, visit http://gerrit.cloudera.org:8080/3055 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba6e8a022d7a5391c3657cbdc9d3f06f951be048 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] ksck: multi-thread the fetching of replica info from tablet servers
Kudu Jenkins has posted comments on this change. Change subject: ksck: multi-thread the fetching of replica info from tablet servers .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2579/ -- To view, visit http://gerrit.cloudera.org:8080/3705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7784697fb227743dccaa98922fb958cd6a3270e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] ksck: also print info about the good replicas for a bad tablet
Kudu Jenkins has posted comments on this change. Change subject: ksck: also print info about the good replicas for a bad tablet .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2581/ -- To view, visit http://gerrit.cloudera.org:8080/3706 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0dcefe5a7b00c77a116cc40601cce13cf8a0112 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] ksck: report hostnames instead of IP addresses for tablet servers
Kudu Jenkins has posted comments on this change. Change subject: ksck: report hostnames instead of IP addresses for tablet servers .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2580/ -- To view, visit http://gerrit.cloudera.org:8080/3704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8164dca050fd1adcc034a91cebc241e6fff8a117 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] ksck: also print info about the good replicas for a bad tablet
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3706 to review the following change. Change subject: ksck: also print info about the good replicas for a bad tablet .. ksck: also print info about the good replicas for a bad tablet In the case that one or more replicas is bad in a tablet, it can be useful to know where the _good_ replicas are in order to start debugging why they aren't doing their job of replacing or repairing the bad one. This patch prints out an INFO message for those good replicas. Example output: WARNING: Detected problems with Tablet 3bf432551c5d4c529616f8e7ce829424 of table 'usertable' WARNING: Bad state on TS c189483a372947f192fc338e612ef70f (e1516.halxg.cloudera.com:7050): NOT_STARTED Last status: RemoteBootstrap: Downloading block 369288934977914585 (450/31161) Data state: TABLET_DATA_COPYING INFO: OK state on TS dff78a5acdbb4a47ba2c7a62d1bcc5ee (e1407.halxg.cloudera.com:7050): RUNNING INFO: OK state on TS ea948da3787648c2b26049e953afb3ea (e1301.halxg.cloudera.com:7050): RUNNING Change-Id: Ic0dcefe5a7b00c77a116cc40601cce13cf8a0112 --- M src/kudu/tools/ksck-test.cc M src/kudu/tools/ksck.cc 2 files changed, 17 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/3706/1 -- To view, visit http://gerrit.cloudera.org:8080/3706 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic0dcefe5a7b00c77a116cc40601cce13cf8a0112 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans
[kudu-CR] ksck: report hostnames instead of IP addresses for tablet servers
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3704 to look at the new patch set (#2). Change subject: ksck: report hostnames instead of IP addresses for tablet servers .. ksck: report hostnames instead of IP addresses for tablet servers Typically admins know their hosts by hostname instead of by IP address. This rejiggers the code a bit to save the original host/port instead of the resolved address, so that the output contains a hostname instead of an IP. Tested manually against a cluster (hard to add an assertion since we don't have the ability to mock DNS). Change-Id: I8164dca050fd1adcc034a91cebc241e6fff8a117 --- M src/kudu/tools/ksck-test.cc M src/kudu/tools/ksck.h M src/kudu/tools/ksck_remote.cc M src/kudu/tools/ksck_remote.h 4 files changed, 30 insertions(+), 19 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/3704/2 -- To view, visit http://gerrit.cloudera.org:8080/3704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8164dca050fd1adcc034a91cebc241e6fff8a117 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] ksck: multi-thread the fetching of replica info from tablet servers
Hello Jean-Daniel Cryans, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3705 to review the following change. Change subject: ksck: multi-thread the fetching of replica info from tablet servers .. ksck: multi-thread the fetching of replica info from tablet servers In clusters with a lot of tablets, fetching the data from each tablet server can take a while (eg ~100ms per server from my laptop to a test cluster in our datacenter). For a large cluster (~70 nodes), this makes ksck rather slow. Multi-threading the fetching makes this much faster (5s vs original 31 seconds for the above test cluster). Change-Id: Ib7784697fb227743dccaa98922fb958cd6a3270e --- M src/kudu/tools/ksck.cc 1 file changed, 22 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/3705/1 -- To view, visit http://gerrit.cloudera.org:8080/3705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib7784697fb227743dccaa98922fb958cd6a3270e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy
[kudu-CR] ksck: multi-thread the fetching of replica info from tablet servers
Kudu Jenkins has posted comments on this change. Change subject: ksck: multi-thread the fetching of replica info from tablet servers .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2578/ -- To view, visit http://gerrit.cloudera.org:8080/3705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7784697fb227743dccaa98922fb958cd6a3270e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] ksck: report hostnames instead of IP addresses for tablet servers
Kudu Jenkins has posted comments on this change. Change subject: ksck: report hostnames instead of IP addresses for tablet servers .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2577/ -- To view, visit http://gerrit.cloudera.org:8080/3704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8164dca050fd1adcc034a91cebc241e6fff8a117 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] ksck: report hostnames instead of IP addresses for tablet servers
Hello Jean-Daniel Cryans, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3704 to review the following change. Change subject: ksck: report hostnames instead of IP addresses for tablet servers .. ksck: report hostnames instead of IP addresses for tablet servers Typically admins know their hosts by hostname instead of by IP address. This rejiggers the code a bit to save the original host/port instead of the resolved address, so that the output contains a hostname instead of an IP. Tested manually against a cluster (hard to add an assertion since we don't have the ability to mock DNS). Change-Id: I8164dca050fd1adcc034a91cebc241e6fff8a117 --- M src/kudu/tools/ksck.h M src/kudu/tools/ksck_remote.cc M src/kudu/tools/ksck_remote.h 3 files changed, 29 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/3704/1 -- To view, visit http://gerrit.cloudera.org:8080/3704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8164dca050fd1adcc034a91cebc241e6fff8a117 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy
[kudu-CR] [java client] Redo how we manage exceptions
Kudu Jenkins has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 10: Build Started http://104.196.14.100/job/kudu-gerrit/2576/ -- To view, visit http://gerrit.cloudera.org:8080/3055 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba6e8a022d7a5391c3657cbdc9d3f06f951be048 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] [java client] Redo how we manage exceptions
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3055 to look at the new patch set (#10). Change subject: [java client] Redo how we manage exceptions .. [java client] Redo how we manage exceptions Right now the exceptions are hard to handle in the Java client. They're all generic and you need to do a lot of introspection. For example, if you try to create a table that already exists, you need to start searching the exception's message to know if it's that or some other problem that gave you the error. With this patch we now only one main kind of public exception: KuduException. We still have Recoverable/NonRecoverableException but those are now package-private and only used internally. PleaseThrottleException is kept public for the async API. KuduException has a new field, `status`, which is your regular Kudu Status object. Wherever we can we try to recreate the Status objects that are sent to us from the servers, else we create our own. Now for the example above we can just query the exception's status with `isNotFound()`. The sync APIs is also modified to only throw KuduExceptions instead of plain Exceptions. Change-Id: Iba6e8a022d7a5391c3657cbdc9d3f06f951be048 --- M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java D java/kudu-client/src/main/java/org/kududb/client/ConnectionResetException.java M java/kudu-client/src/main/java/org/kududb/client/GetMasterRegistrationReceived.java D java/kudu-client/src/main/java/org/kududb/client/InvalidResponseException.java M java/kudu-client/src/main/java/org/kududb/client/KuduClient.java M java/kudu-client/src/main/java/org/kududb/client/KuduException.java M java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java M java/kudu-client/src/main/java/org/kududb/client/KuduScanner.java D java/kudu-client/src/main/java/org/kududb/client/KuduServerException.java M java/kudu-client/src/main/java/org/kududb/client/KuduSession.java D java/kudu-client/src/main/java/org/kududb/client/MasterErrorException.java M java/kudu-client/src/main/java/org/kududb/client/NoLeaderMasterFoundException.java M java/kudu-client/src/main/java/org/kududb/client/NonCoveredRangeException.java M java/kudu-client/src/main/java/org/kududb/client/NonRecoverableException.java M java/kudu-client/src/main/java/org/kududb/client/PleaseThrottleException.java M java/kudu-client/src/main/java/org/kududb/client/RecoverableException.java M java/kudu-client/src/main/java/org/kududb/client/RowResultIterator.java M java/kudu-client/src/main/java/org/kududb/client/Status.java M java/kudu-client/src/main/java/org/kududb/client/TabletClient.java D java/kudu-client/src/main/java/org/kududb/client/TabletServerErrorException.java M java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduSession.java M java/kudu-client/src/test/java/org/kududb/client/TestKuduSession.java M java/kudu-client/src/test/java/org/kududb/client/TestKuduTable.java M java/kudu-client/src/test/java/org/kududb/client/TestTimeouts.java 26 files changed, 393 insertions(+), 505 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/3055/10 -- To view, visit http://gerrit.cloudera.org:8080/3055 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iba6e8a022d7a5391c3657cbdc9d3f06f951be048 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master
Alexey Serbin has posted comments on this change. Change subject: KUDU-1492: Show column encodings/compression on table page in master .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/3667/2//COMMIT_MSG Commit Message: Line 9: This displays column atributes for the table schema in picture. typo: atributes --> attributes PS2, Line 9: nit: an extra space Line 13: release. For eg, current release has PLAIN_ENCODING for encoding nit: For eg --> E.g. ? http://gerrit.cloudera.org:8080/#/c/3667/2/src/kudu/server/webui_util.cc File src/kudu/server/webui_util.cc: PS2, Line 40: nit: Is this still a tab? If yes, consider expanding it with spaces to comply with code style. Line 54: string encoding = EncodingType_Name(attrs.encoding); nit: consider replacing with const reference: const string& encoding = ... Line 55: string compression = CompressionType_Name(attrs.compression); Ditto -- consider replacing with const reference. -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: Yes
[kudu-CR] [java client] Redo how we manage exceptions
Dan Burkert has posted comments on this change.
Change subject: [java client] Redo how we manage exceptions
..
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3055/8/java/kudu-client/src/main/java/org/kududb/client/KuduClient.java
File java/kudu-client/src/main/java/org/kududb/client/KuduClient.java:
Line 99: public boolean isAlterTableDone(String name) throws KuduException,
InterruptedException {
> Ugh yeah looks like in other places where we call Deferred.join we just pro
I think KuduException#transformException should specifically check for
InterruptedException, and if it finds it, set the threads interrupt flag.
--
To view, visit http://gerrit.cloudera.org:8080/3055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba6e8a022d7a5391c3657cbdc9d3f06f951be048
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon
Gerrit-HasComments: Yes
[kudu-CR] [java client] Integrate with the replay cache
Dan Burkert has posted comments on this change. Change subject: [java client] Integrate with the replay cache .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [java client] Integrate with the replay cache
Dan Burkert has posted comments on this change. Change subject: [java client] Integrate with the replay cache .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3631/5/java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java File java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java: Line 64: return incompleteRpcs.peek(); > Yeah it's just a question of timing, doing a peek then checking for null ha I meant the result of `incompleteRpcs.peek()` could be null, which would then throw a NPE during the cast. -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions
Adar Dembo has posted comments on this change.
Change subject: KUDU-1311 [master] support adding and dropping range partitions
..
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3648/9/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
Line 1522: if (has_metadata_changes) {
> Yes, that's basically what 'has_metadata_changes' is tracking.
But what if !tablets_to_add.empty() and
!has_metadata_changes_for_existing_tablets? Seems like that could happen if an
AlterTable() comes in that just adds a new partition. In that case, we will set
the table's state to ALTERING but not write it out, and revert the change
below. That doesn't seem correct.
--
To view, visit http://gerrit.cloudera.org:8080/3648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
