Re: Review Request 39645: Updates /site to reflect Niklas' 0.25.0 changes that weren't reflected in git.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39645/#review103988 --- Bad patch! Reviews applied: [39645] Failed command:

Review Request 39645: Updates /site to reflect Niklas' 0.25.0 changes that weren't reflected in git.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39645/ --- Review request for mesos, Adam B and Niklas Nielsen. Repository: mesos

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/#review103958 --- src/master/allocator/mesos/hierarchical.cpp (line 996)

Re: Review Request 39620: Windows: Included headers to make `stout/windows.hpp` standalone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39620/#review104077 --- Ship it! Ship It! - Joseph Wu On Oct. 24, 2015, 9:32 a.m.,

Re: Review Request 39533: SSLTest refactor: Change test #ifdefs so this class exists with or without --enable-ssl.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39533/ --- (Updated Oct. 26, 2015, 3:36 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 39628: Clear the suppressed flag when deactive a framework

> On Oct. 25, 2015, 2:51 p.m., Ben Mahler wrote: > > Can you please add a test that would have caught this issue? > > Guangya Liu wrote: > I think this is a bug, I tested without my code change, the test also > failed sometimes. Shall we file a bug for this? the failed test looks

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

> On Oct. 26, 2015, 6:55 p.m., Jie Yu wrote: > > src/slave/containerizer/linux_launcher.hpp, line 39 > > > > > > Cna you rename it to 'available'? We tend to omit 'is' or 'are' for > > those functions (e.g.,

Re: Review Request 39502: [DO NOT COMMIT] Sync v1/mesos.proto with docker, QoS, and AppC changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39502/ --- (Updated Oct. 26, 2015, 2:27 p.m.) Review request for mesos, Artem

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review104090 --- Note: considering the amount of changes since my last review, my

Re: Review Request 39534: SSLTest refactor: Change MesosTest to inherit from the SSL helper class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39534/#review104087 --- src/tests/mesos.hpp (line 100)

Re: Review Request 39498: SSLTest refactor: Change SSLTest to inherit from TemporaryDirectoryTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39498/#review104081 --- Ship it! 3rdparty/libprocess/include/process/ssl/gtest.hpp (line

Re: Review Request 39499: SSLTest refactor: Update docker registry tests to reflect changed cleanup logic of SSLTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39499/#review104084 --- Ship it! - Joris Van Remoortere On Oct. 22, 2015, 12:04 a.m.,

Re: Review Request 39501: SSLTest refactor: Split SSLTest into helpers which can be integrated into MesosTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39501/#review104091 --- Ship it! 3rdparty/libprocess/include/process/ssl/gtest.hpp

Re: Review Request 39533: SSLTest refactor: Change test #ifdefs so this class exists with or without --enable-ssl.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39533/#review104086 --- Ship it! 3rdparty/libprocess/include/process/ssl/gtest.hpp (line

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/#review104119 --- docs/configuration.md (lines 1545 - 1551)

Re: Review Request 38577: Added synchronous validation for Call in Agent

> On Oct. 27, 2015, 1:13 a.m., Vinod Kone wrote: > > src/slave/validation.hpp, line 31 > > > > > > why space here? Added it there after a review comment. > On Oct. 27, 2015, 1:13 a.m., Vinod Kone wrote: > >

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review104054 ---

Re: Review Request 39499: SSLTest refactor: Update docker registry tests to reflect changed cleanup logic of SSLTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39499/ --- (Updated Oct. 26, 2015, 3:34 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 39501: SSLTest refactor: Split SSLTest into helpers which can be integrated into MesosTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39501/ --- (Updated Oct. 26, 2015, 3:35 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 39498: SSLTest refactor: Change SSLTest to inherit from TemporaryDirectoryTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39498/ --- (Updated Oct. 26, 2015, 3:33 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 39534: SSLTest refactor: Change MesosTest to inherit from the SSL helper class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39534/ --- (Updated Oct. 26, 2015, 3:37 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review104105 --- Ship it! modulo joseph's comments. support/apply-reviews.py

Re: Review Request 38618: Changed executor HTTP API tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38618/ --- (Updated Oct. 27, 2015, 12:09 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 38577: Added synchronous validation for Call in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Oct. 27, 2015, 12:23 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 38844: Added unit tests for Call validation in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/ --- (Updated Oct. 27, 2015, 12:37 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 38577: Added synchronous validation for Call in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/ --- (Updated Oct. 27, 2015, 1:20 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 38844: Added unit tests for Call validation in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/#review104125 --- Ship it! src/tests/executor_http_api_tests.cpp (line 543)

Re: Review Request 39497: Fixed quotation of interpolated variables in log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39497/#review104101 --- Ship it! minus the removal of taskid quotations. - Joris Van

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review104098 --- support/apply-reviews.py (line 18)

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

> On Oct. 22, 2015, 9:20 p.m., Vinod Kone wrote: > > support/apply-reviews.py, line 25 > > > > > > s/extract_// > > Artem Harutyunyan wrote: > Marco commented earlier on this one `nit: you are 'masking' the

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review104106 --- support/apply-reviews.py (line 41)

Re: Review Request 39534: SSLTest refactor: Change MesosTest to inherit from the SSL helper class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39534/#review104110 --- Patch looks great! Reviews applied: [39495, 39498, 39499, 39501,

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39417/#review104120 --- Also, is there are way to test the different code paths? - Ian

Re: Review Request 38577: Added synchronous validation for Call in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review104123 --- Ship it! src/slave/validation.hpp (line 19)

Re: Review Request 38844: Added unit tests for Call validation in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/ --- (Updated Oct. 27, 2015, 1:30 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Oct. 27, 2015, 3:42 a.m.) Review request for mesos, Jie Yu, Timothy

Re: Review Request 38844: Added unit tests for Call validation in Agent

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/#review104132 --- Patch looks great! Reviews applied: [38618, 38577, 38844] All

Re: Review Request 38577: Added synchronous validation for Call in Agent

> On Oct. 27, 2015, 1:13 a.m., Vinod Kone wrote: > > src/slave/validation.cpp, line 75 > > > > > > also print status.source() > > Isabel Jimenez wrote: > We don't have a stringify for this. Why not implement

Re: Review Request 39400: Quota: Implemented quota API.

> On 十月 25, 2015, 9:06 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 903 > > > > > > I see that in the code, some are using > > > > '" << xxx << "'"; > > > > while

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39604/#review104064 --- Ship it! Thanks! src/slave/containerizer/linux_launcher.hpp

Re: Review Request 39645: Updates /site to reflect Niklas' 0.25.0 changes that weren't reflected in git.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39645/#review104016 --- Ship it! Thanks! Make ReviewBot happy, and then I'm happy with

Re: Review Request 39496: Clarified libevent config error messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39496/#review104015 --- Ship it! This file is also copied in 3rdparty/libprocess, so we

Re: Review Request 39590: Made license-headers doxygen-compatible.

> On Oct. 24, 2015, 7:23 p.m., Alexander Rukletsov wrote: > > What about `.proto` files? > > Benjamin Bannier wrote: > Good point, since they contain C++ embedded they should follow a similar > style. I pushed an updated RR. > > Most files follow that format; I cross-checked with

Re: Review Request 39400: Quota: Implemented quota API.

> On Oct. 25, 2015, 9:06 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 903 > > > > > > I see that in the code, some are using > > > > '" << xxx << "'"; > > > >

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/#review104013 --- src/master/allocator/mesos/hierarchical.cpp (line 1004)

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/#review104012 --- For this patch, it seems that we add the code related to quota

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/#review104006 --- src/master/allocator/mesos/hierarchical.cpp (line 1156)

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/#review103983 --- src/master/allocator/mesos/hierarchical.cpp (line 1018)

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/#review104010 --- src/master/allocator/mesos/hierarchical.cpp (line 998)

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 1:51 p.m., Artem Harutyunyan wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1044-1046 > > > > > > s/the/that/ > > > > Seems like a copy of the comment above, is this

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 8:27 a.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 996 > > > > > > These newly added code makes allocate() a huge method (more than 200 > > lines), maybe move

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 2 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1018 > > > > > > Can we move this out of the for loop? if the role is satisfied, > > framewor sort is not

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 1:13 p.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1156 > > > > > > I think we need to check if this is a quota'ed role first. Correct, thanks! - Alexander

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 1:49 p.m., Qian Zhang wrote: > > For this patch, it seems that we add the code related to quota support in > > the slave foreach loop in the HierarchicalAllocatorProcess::allocate(const > > hashset& slaveIds_) method, so that means for **each slave**, we > > handle quota

Re: Review Request 39494: Added libnl, libevent and ssl flags to config docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39494/#review104019 --- Ship it! Thanks for taking this on Greg! Greg will follow up with

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 25, 2015, 1:39 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 982 > > > > > > s/unsatisfiedRoleQuotas/unAllocatedRoleQuotas? Dynamic reservations may not be allocated, but

Re: Review Request 39360: Relocate MesosContainerizer specific files to the correct location

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39360/#review104061 --- Ship it! This looks good! You missed launcher and linux_launcher

Re: Review Request 39539: Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.

> On Oct. 23, 2015, 4:49 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, lines 270-274 > > > > > > Do you need this one? There are some uses of `os::mktemp` in the