Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46008/ --- (Updated April 14, 2016, 5:21 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

> On April 13, 2016, 4:24 a.m., Vinod Kone wrote: > > src/launcher/http_command_executor.cpp, lines 804-809 > > > > > > Lets fix this hack now that the executor receives acknowledgements for > > status updates. > >

Review Request 46187: Terminate when receiving the ACK of terminal status update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-3558

Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46008/ --- (Updated April 14, 2016, 5:05 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/ --- (Updated 四月 14, 2016, 5:01 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46134/ --- (Updated 四月 14, 2016, 5 a.m.) Review request for mesos, Kevin Klues and Vinod

Re: Review Request 45326: Added agent flag dvdcli_dir for specify dvdcli path.

> On 四月 13, 2016, 9:01 p.m., James DeFelice wrote: > > src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp, line 64 > > > > > > should we verify that the dvdcli binary actually exists here (and if > > not

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46134/#review128835 --- Ship it! It looks like the ReviewBot ran between the two most

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/#review128834 --- Ship it! Ship It! - Kevin Klues On April 14, 2016, 4:23

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

> On 四月 14, 2016, 4:04 a.m., Kevin Klues wrote: > > src/Makefile.am, lines 2137-2141 > > > > > > Assuming this is the right fix, you probably need DESTDIR here too Fixed in the latest patch, is there any way to

Re: Review Request 45360: Added volume client for mount and unmount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/ --- (Updated 四月 14, 2016, 4:45 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45500: Keep fs::mount information should be consolidated.

> On 四月 6, 2016, 9:04 p.m., Neil Conway wrote: > > src/tests/containerizer/fs_tests.cpp, line 35 > > > > > > Not yours, but we should sort these alphabetically. @Neil Conway how aobut your feedback. - Deshi

Re: Review Request 45270: Added spec protobut for external mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/ --- (Updated 四月 14, 2016, 4:41 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 45214: Updated protobuf to support external storage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45214/ --- (Updated 四月 14, 2016, 4:37 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46134/ --- (Updated 四月 14, 2016, 4:24 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/ --- (Updated 四月 14, 2016, 4:23 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/#review128829 --- src/Makefile.am (lines 2135 - 2139)

Re: Review Request 45214: Updated protobuf to support external storage.

> On 四月 13, 2016, 9:35 p.m., James DeFelice wrote: > > include/mesos/mesos.proto, line 1625 > > > > > > I definitely prefer this form, but there's also a Parameters message > > type. Which is more idiomatic in

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

> On 四月 13, 2016, 11:25 p.m., Vinod Kone wrote: > > Looks like ReviewBot failed. Can you make sure to fix that issue? Otherwise > > LGTM. > > Kevin Klues wrote: > It looks like it's failing on this step: > ``` > make[5]: Entering directory `/mesos/mesos-0.29.0/_build/src' > cp

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46134/ --- (Updated 四月 14, 2016, 3:24 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/ --- (Updated 四月 14, 2016, 3:23 a.m.) Review request for mesos, Kevin Klues and

Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46008/ --- (Updated April 14, 2016, 2:39 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46014: Stout:[1/2] Moved process tests to their own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46014/ --- (Updated April 14, 2016, 2:06 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.

> On April 12, 2016, 2:41 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp, line 179 > > > > > > Can you explain why this is not defined on windows? Well, I don't

Re: Review Request 46180: Implemented create() for docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46180/#review128819 --- Patch looks great! Reviews applied: [45214, 45217, 45270, 45360,

Re: Review Request 46160: Exposed zookeeper/authentication.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46160/#review128817 --- src/state/zookeeper.hpp (line 23)

Re: Review Request 46161: Exposed log/log.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46161/#review128816 --- Fix it, then Ship it! Please make sure the cmake works. Also,

Re: Review Request 46160: Exposed zookeeper/authentication.hpp.

> On April 13, 2016, 8:51 p.m., Jie Yu wrote: > > Do you need to update cmake? Ohh, yes. Will do that in a separate commit. - Kapil --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 46160: Exposed zookeeper/authentication.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46160/#review128814 --- Ship it! Do you need to update cmake? - Jie Yu On April 13,

Re: Review Request 45901: Removed unsed headers from master contender/detector files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45901/#review128813 --- Ship it! Ship It! - Jie Yu On April 13, 2016, 8:06 p.m.,

Re: Review Request 45900: Removed stale contender/detector files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45900/#review128812 --- Ship it! Ship It! - Jie Yu On April 13, 2016, 8:06 p.m.,

Re: Review Request 45983: Enabled the `network/cni` isolator in `MesosContainerizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45983/#review128811 --- src/slave/containerizer/mesos/containerizer.cpp (lines 165 -

Re: Review Request 45955: Added CNI helper subcommand to `mesos-containerizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45955/#review128810 --- This will break mac build. Please make sure to wrap code with

Re: Review Request 45956: Added the `_isolate` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45956/#review128809 --- Ship it! Ship It! - Jie Yu On April 14, 2016, midnight,

Re: Review Request 45217: Implemented docker volume driver isolator interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45217/ --- (Updated 四月 14, 2016, 12:32 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 46175: Added a test for slavePostFetchHook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46175/ --- (Updated April 14, 2016, 12:08 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 45956: Added the `_isolate` method.

> On April 13, 2016, 5:16 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 716-717 > > > > > > What if IP is not found? Should we use 127.0.0.1? > > Avinash sridharan

Re: Review Request 45956: Added the `_isolate` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45956/ --- (Updated April 14, 2016, midnight) Review request for mesos, Jie Yu and Qian

Re: Review Request 46175: Added a test for slavePostFetchHook.

> On April 13, 2016, 11 p.m., Ben Mahler wrote: > > src/examples/test_hook_module.cpp, line 197 > > > > > > Mind committing this as a separate patch? Done. > On April 13, 2016, 11 p.m., Ben Mahler wrote: > >

Re: Review Request 46168: Add subdirectory support to URI.filename field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46168/ --- (Updated April 13, 2016, 11:55 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

> On April 13, 2016, 11:22 p.m., Vinod Kone wrote: > > Ship It! Don't commit this yet, pert the comment at the botoom of: https://reviews.apache.org/r/46134/ - Kevin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 46168: Add subdirectory support to URI.filename field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46168/#review128800 --- Bad patch! Reviews applied: [46168] Failed command:

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

> On April 13, 2016, 11:25 p.m., Vinod Kone wrote: > > Looks like ReviewBot failed. Can you make sure to fix that issue? Otherwise > > LGTM. It looks like it's failing on this step: ``` make[5]: Entering directory `/mesos/mesos-0.29.0/_build/src' cp

Review Request 46180: Implemented create() for docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46180/ --- Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and

Re: Review Request 46134: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries(2).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46134/#review128798 --- Looks like ReviewBot failed. Can you make sure to fix that issue?

Re: Review Request 46164: Moved mesos::internal::state to mesos::state namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46164/#review128797 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 45806: Replace Master/Slave Terminology Phase I - Duplicate/Rename binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45806/#review128796 --- Ship it! Ship It! - Vinod Kone On April 13, 2016, 2:57

Re: Review Request 45360: Added volume client for mount and unmount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/ --- (Updated 四月 13, 2016, 11:12 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 46173: Added a slave post fetch hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46173/#review128777 --- Ship it! src/hook/manager.cpp (lines 243 - 244)

Re: Review Request 45956: Added the `_isolate` method.

> On April 13, 2016, 5:16 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 716-717 > > > > > > What if IP is not found? Should we use 127.0.0.1? > > Avinash sridharan

Re: Review Request 45360: Added volume client for mount and unmount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/ --- (Updated 四月 13, 2016, 11:01 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 46173: Added a slave post fetch hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46173/#review128789 --- src/hook/manager.hpp (lines 69 - 70)

Re: Review Request 46175: Added a test for slavePostFetchHook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46175/#review128783 --- src/examples/test_hook_module.cpp (line 197)

Re: Review Request 45670: Updated tests for HTTP command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45670/#review128787 --- Ship it! Ship It! - Vinod Kone On April 13, 2016, 9:15

Re: Review Request 45670: Updated tests for HTTP command executor.

> On April 12, 2016, 9:11 p.m., Vinod Kone wrote: > > Are you also planning to update slave recovery tests? Those are the most > > crucial. > > Qian Zhang wrote: > Sure, I will update slave recovery tests soon. Just want to double > confirm, in `slave_recovery_tests.cpp`, I see there are

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/#review128781 --- 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp

Re: Review Request 45270: Added spec protobut for external mount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45270/ --- (Updated 四月 13, 2016, 10:40 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 44427: Added --http_command_executor flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44427/#review128776 --- Ship it! Are you going to add the test to this review or the

Re: Review Request 44427: Added --http_command_executor flag.

> On April 12, 2016, 9:07 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, lines 5857-5870 > > > > > > I think this will break slave recovery when a slave is restarted with > > the flag set to true. This is

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

> On April 12, 2016, 8:24 p.m., Vinod Kone wrote: > > src/launcher/http_command_executor.cpp, lines 296-297 > > > > > > No need to capture taskId because you can get it from `task`? > > Qian Zhang wrote: > I

Re: Review Request 44424: Updated http_command_executor.cpp to use v1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44424/#review128773 --- Ship it! Ship It! - Vinod Kone On April 13, 2016, 9:13

Review Request 46175: Added a test for slavePostFetchHook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46175/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-5209

Review Request 46173: Added a slave post fetch hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46173/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-5209

Re: Review Request 45217: Implemented docker volume driver isolator interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45217/ --- (Updated 四月 13, 2016, 10:29 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 45217: Implemented docker volume driver isolator interface.

> On 四月 4, 2016, 11:01 p.m., Gilbert Song wrote: > > src/Makefile.am, line 860 > > > > > > Could you move it below runtime.cpp? > > Guangya Liu wrote: > There are some files such as spec.proto, dvd_client.cpp,

Re: Review Request 46118: Fixed tests impacted by enabling AuthN for HTTP frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46118/#review128769 --- Ship it! Ship It! - Vinod Kone On April 12, 2016, 10:26

Re: Review Request 46117: Added `None()` for credentials when creating scheduler lib.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46117/#review128768 --- Ship it! Ship It! - Vinod Kone On April 12, 2016, 10:25

Re: Review Request 46116: Added basic authentication scheme to the scheduler library.

> On April 13, 2016, 10:05 p.m., Vinod Kone wrote: > > Also, I'm wondering if it would be better for the library to take Authorization string as a parameter instead of Credential. That way it is more generic because the library can just set "Authorization: ". The idea is that scheduler will

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/ --- (Updated April 13, 2016, 10:06 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46116: Added basic authentication scheme to the scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46116/#review128764 --- Fix it, then Ship it! include/mesos/v1/scheduler.hpp (line

Re: Review Request 46009: Stout:[1/2] Added simple tests for `os::` functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46009/ --- (Updated April 13, 2016, 10:05 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46115: Added AuthN for HTTP based frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46115/#review128731 --- src/master/master.cpp (line 850)

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

> On April 12, 2016, 11:10 p.m., Alex Naparu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 383 > > > > > > Can you document this flag a bit please? GetProcessTimes requires > >

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

> On April 12, 2016, 11:10 p.m., Alex Naparu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 383 > > > > > > Can you document this flag a bit please? GetProcessTimes requires > >

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/ --- (Updated April 13, 2016, 9:49 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 45214: Updated protobuf to support external storage.

> On 四月 13, 2016, 9:35 p.m., James DeFelice wrote: > > include/mesos/mesos.proto, line 1625 > > > > > > I definitely prefer this form, but there's also a Parameters message > > type. Which is more idiomatic in

Re: Review Request 46027: Documented `libprocess` helper function.

> On April 13, 2016, 9:33 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/process.cpp, line 559 > > > > > > s/. A/. A/ > > > > Thanks for clarifying, sorry for the confusion! > > Ben Mahler wrote: >

Re: Review Request 46014: Stout:[1/2] Moved process tests to their own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46014/ --- (Updated April 13, 2016, 9:37 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46027: Documented `libprocess` helper function.

> On April 13, 2016, 9:33 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/process.cpp, line 559 > > > > > > s/. A/. A/ > > > > Thanks for clarifying, sorry for the confusion! Also, would you mind

Review Request 46168: Add subdirectory support to URI.filename field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46168/ --- Review request for mesos, Bernd Mathiske and Jiang Yan Xu. Bugs: MESOS-5119

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

> On April 12, 2016, 11:10 p.m., Alex Naparu wrote: > > Hey, sorry, you reviewed an old version of the code. I had a different branch checked out when I pushed this. The background is that this is an amalgamation of maybe 3 or 4 commits, and the code is not amazing. I went through and fixed

Re: Review Request 45214: Updated protobuf to support external storage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45214/#review128751 --- include/mesos/mesos.proto (line 1625)

Re: Review Request 46027: Documented `libprocess` helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46027/#review128749 --- Ship it! 3rdparty/libprocess/src/process.cpp (line 559)

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46013/ --- (Updated April 13, 2016, 9:33 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46029: Mark a few private functions `static` in libprocess tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46029/#review128748 --- Ship it! Ship It! - Ben Mahler On April 12, 2016, 12:13

Re: Review Request 45370: Implemented prepare() for dvd isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/#review128744 --- src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp (line

Re: Review Request 45326: Added agent flag dvdcli_dir for specify dvdcli path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45326/#review128743 --- src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp (line

Review Request 46165: Removed dependency on Boost.Foreach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46165/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-3214

Re: Review Request 45370: Implemented prepare() for dvd isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/#review128741 --- src/slave/containerizer/mesos/isolators/docker/dvd/dvd.cpp (line

Re: Review Request 45614: Windows: Implemented os::close for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45614/#review128742 --- Bad patch! Reviews applied: [45614] Failed command:

Re: Review Request 45360: Added dvd client for mount and unmount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45360/#review128740 ---

Review Request 46164: Moved mesos::internal::state to mesos::state namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46164/ --- Review request for mesos. Bugs: MESOS-5171

Review Request 46160: Exposed zookeeper/authentication.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46160/ --- Review request for mesos. Bugs: MESOS-5171

Re: Review Request 45900: Removed stale contender/detector files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45900/ --- (Updated April 13, 2016, 4:06 p.m.) Review request for mesos, Anurag Singh and

Review Request 46161: Exposed log/log.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46161/ --- Review request for mesos. Bugs: MESOS-5171

Review Request 46162: Moved mesos::internal::log::Log to mesos::log namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46162/ --- Review request for mesos. Bugs: MESOS-5171

Re: Review Request 45901: Removed unsed headers from master contender/detector files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45901/ --- (Updated April 13, 2016, 4:06 p.m.) Review request for mesos, Anurag Singh and

Review Request 46163: Exposed state/{state,storage}.hpp files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46163/ --- Review request for mesos. Bugs: MESOS-5171

Re: Review Request 46114: Fixed per framework principal metrics for HTTP frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46114/#review128730 --- src/master/master.cpp (lines 5939 - 5941)

Re: Review Request 45668: Enable CMake build for Linux as a CONFIGURATOR option.

> On Abr. 9, 2016, 1:34 a.m., Vinod Kone wrote: > > support/docker_build.sh, line 125 > > > > > > See the ASF CI build error on the attached ticket. > > > > I think specifying configuration options this way

  1   2   >