Re: Review Request 48048: Added documentation for access_sandboxes and access_mesos_logs acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48048/#review135770 --- Fix it, then Ship it! Looks good. I'll fix these nits and commi

Re: Review Request 48113: Replaced RUN_TASK_WITH_USER with RUN_TASK authorization action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48113/ --- (Updated May 31, 2016, 11:08 p.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 48113: Replaced RUN_TASK_WITH_USER with RUN_TASK authorization action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48113/#review135768 --- Ship it! Ship It! - Vinod Kone On June 1, 2016, 5:54 a.m., A

Review Request 48113: Replaced RUN_TASK_WITH_USER with RUN_TASK authorization action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48113/ --- Review request for mesos, Benjamin Bannier and Vinod Kone. Repository: mesos

Re: Review Request 47891: Added RUN_TASK authorization action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47891/#review135766 --- include/mesos/authorizer/authorizer.proto (line 71)

Re: Review Request 47891: Added RUN_TASK authorization action.

> On June 1, 2016, 4:53 a.m., Vinod Kone wrote: > > OK. I'll commit this now and add the deprecation. Can you please follow up > > with RUN_TASK_WITH_USER test if there isn't one? Thanks. aah. looks like you need to rebase :( - Vinod -

Re: Review Request 47891: Added RUN_TASK authorization action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47891/#review135762 --- Ship it! OK. I'll commit this now and add the deprecation. Can

Re: Review Request 47891: Added RUN_TASK authorization action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47891/#review135761 --- include/mesos/authorizer/authorizer.proto (line 69)

Re: Review Request 48084: Implemented v1::master::Call::GET_MAINTENANCE_STATUS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48084/#review135760 --- Patch looks great! Reviews applied: [48084] Passed command: expo

Re: Review Request 48084: Implemented v1::master::Call::GET_MAINTENANCE_STATUS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48084/#review135758 --- src/master/http.cpp (lines 3240 - 3244)

Re: Review Request 48092: Added authorizer interface changes and to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48092/#review135753 --- Bad patch! Reviews applied: [48092, 48054, 47736, 47704, 47559, 4

Re: Review Request 48101: Changed the ObjectApprover interface for optional subject and objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48101/ --- (Updated June 1, 2016, 2:23 a.m.) Review request for mesos, Adam B, Michael Par

Re: Review Request 48084: Implemented v1::master::Call::GET_MAINTENANCE_STATUS.

> On May 31, 2016, 7:24 p.m., Vinod Kone wrote: > > src/master/master.hpp, line 1236 > > > > > > put `_maintenanceStatus(` on the next line as well. Hi, @vinodkone, thanks a lot for your review. Just updated, may y

Re: Review Request 48084: Implemented v1::master::Call::GET_MAINTENANCE_STATUS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48084/ --- (Updated June 1, 2016, 2:13 a.m.) Review request for mesos and Vinod Kone. Bu

Re: Review Request 48084: Implemented v1::master::Call::GET_MAINTENANCE_STATUS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48084/ --- (Updated June 1, 2016, 2:13 a.m.) Review request for mesos and Vinod Kone. Ch

Re: Review Request 48101: Changed the ObjectApprover interface for optional subject and objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48101/#review135738 --- Bad patch! Reviews applied: [48101, 48092, 48054, 47736, 47704, 4

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review135736 --- Patch looks great! Reviews applied: [48094] Passed command: expo

Re: Review Request 48054: Added intergration tests for authorization based endpoint filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48054/#review135730 --- Ship it! Submitted with the following style changes. src/test

Re: Review Request 46758: V1 API: Split Accept/Decline for offers and Inverse Offers.

> On 五月 30, 2016, 10:08 a.m., Guangya Liu wrote: > > include/mesos/scheduler/scheduler.proto, line 270 > > > > > > Just a question here: Does it make sense to highlight that this is a > > `inverse offer fiter`? such

Re: Review Request 48101: Changed the ObjectApprover interface for optional subject and objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48101/ --- (Updated June 1, 2016, 12:26 a.m.) Review request for mesos, Adam B, Michael Pa

Re: Review Request 48101: Changed the ObjectApprover interface for optional subject and objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48101/ --- (Updated June 1, 2016, 12:20 a.m.) Review request for mesos, Adam B, Michael Pa

Re: Review Request 48101: Changed the ObjectApprover interface for optional subject and objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48101/#review135729 --- Ship it! Ship It! - Vinod Kone On May 31, 2016, 11:28 p.m.,

Re: Review Request 48092: Added authorizer interface changes and to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48092/#review135728 --- Ship it! Ship It! - Vinod Kone On May 31, 2016, 11:53 p.m.,

Re: Review Request 48103: Added change log for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48103/#review135727 --- Ship it! Ship It! - Jie Yu On June 1, 2016, 12:02 a.m., Avin

Re: Review Request 48103: Added change log for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48103/ --- (Updated June 1, 2016, 12:02 a.m.) Review request for mesos and Jie Yu. Chang

Review Request 48103: Added change log for `network/cni` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48103/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- A

Re: Review Request 48092: Added authorizer interface changes and to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48092/ --- (Updated May 31, 2016, 11:53 p.m.) Review request for mesos, Michael Park and V

Re: Review Request 48048: Added documentation for access_sandboxes and access_mesos_logs acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48048/#review135724 --- Patch looks great! Reviews applied: [48048] Passed command: expo

Re: Review Request 48092: Added `ObjectApprover` and endpoint filtering to the CHANGELOG.

> On May 31, 2016, 11:22 p.m., Vinod Kone wrote: > > CHANGELOG, line 49 > > > > > > Should we also specifically mention that this is a breaking change for > > modules and they need to be recompiled against the new in

Review Request 48101: Changed the ObjectApprover interface for optional subject and objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48101/ --- Review request for mesos, Adam B, Michael Park, Till Toenshoff, and Vinod Kone.

Re: Review Request 48058: Added authorization based endpoint filtering documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48058/#review135721 --- docs/authorization.md (line 655)

Re: Review Request 48092: Added `ObjectApprover` and endpoint filtering to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48092/#review135720 --- CHANGELOG (line 45)

Re: Review Request 48058: Added authorization based endpoint filtering documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48058/#review135719 --- Ship it! Ship It! - Vinod Kone On May 31, 2016, 7:03 a.m., J

Re: Review Request 48093: Updated comments in authorizer.proto.

> On May 31, 2016, 11:11 p.m., Vinod Kone wrote: > > i'll fix these while committing. thanks till. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48093/#review135713

Re: Review Request 48085: Added sanity checks to local authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48085/#review135716 --- Ship it! Ship It! - Vinod Kone On May 31, 2016, 10:22 p.m.,

Re: Review Request 48093: Updated comments in authorizer.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48093/#review135713 --- Fix it, then Ship it! include/mesos/authorizer/authorizer.prot

Re: Review Request 48093: Updated comments in authorizer.proto.

> On May 31, 2016, 10:39 p.m., Joerg Schad wrote: > > include/mesos/authorizer/authorizer.proto, line 58 > > > > > > only if they set an object (e.g., the teardown) How about this? ``` // Actions named *_WITH_foo may

Re: Review Request 48093: Updated comments in authorizer.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48093/#review135702 --- include/mesos/authorizer/authorizer.proto (line 58)

Re: Review Request 46757: V1 API: Split Rescind for offers and Inverse Offers.

> On May 30, 2016, 9:46 a.m., Guangya Liu wrote: > > src/messages/messages.proto, line 292 > > > > > > Why updating here, the Event here should still be `Rescind`? Thanks for catching this. We considered clarifying

Re: Review Request 46759: Updated Master to deal with Accept Offer vs InverseOffer correctly.

> On April 28, 2016, 7:24 p.m., Vinod Kone wrote: > > src/master/metrics.cpp, line 227 > > > > > > hmm...there is no "messages_accept_offers"? also, these are not really > > messages but calls. see discussion in htt

Re: Review Request 46756: V1 API: Split Resource offers and Inverse Offers.

> On May 30, 2016, 9:32 a.m., Guangya Liu wrote: > > src/examples/test_http_framework.cpp, lines 130-131 > > > > > > What about adding a `TODO` here to clarify that we need some logic here > > to handle inverse offe

Re: Review Request 48092: Added `ObjectApprover` and endpoint filtering to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48092/#review135695 --- Patch looks great! Reviews applied: [46093, 47558, 48052, 47559,

Re: Review Request 48085: Added sanity checks to local authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48085/ --- (Updated May 31, 2016, 10:22 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 48054: Added intergration tests for authorization based endpoint filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48054/ --- (Updated May 31, 2016, 10:18 p.m.) Review request for mesos and Michael Park.

Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-5494 h

Re: Review Request 48048: Added documentation for access_sandboxes and access_mesos_logs acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48048/ --- (Updated May 31, 2016, 11:32 p.m.) Review request for mesos, Adam B, Joerg Scha

Re: Review Request 48085: Added sanity checks to local authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48085/#review135686 --- Patch looks great! Reviews applied: [47505, 48085] Passed comman

Review Request 48093: Updated comments in authorizer.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48093/ --- Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, Joerg Sc

Re: Review Request 48054: Added intergration tests for authorization based endpoint filtering.

> On May 31, 2016, 8:20 p.m., Vinod Kone wrote: > > src/tests/master_authorization_tests.cpp, line 1273 > > > > > > instead of setting these "no principal can do foo" ACLs, you can just > > set permissive to `false

Review Request 48092: Added `ObjectApprover` and endpoint filtering to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48092/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 48054: Added intergration tests for authorization based endpoint filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48054/#review135679 --- Fix it, then Ship it! src/tests/master_authorization_tests.cpp

Re: Review Request 48084: Implemented v1::master::Call::GET_MAINTENANCE_STATUS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48084/#review135678 --- Patch looks great! Reviews applied: [48083, 48084] Passed comman

Review Request 48085: Added sanity checks to local authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48085/ --- Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, and Vino

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48049/#review135674 --- Ship it! Ship It! - Vinod Kone On May 31, 2016, 6:32 a.m., A

Re: Review Request 48084: Implemented v1::master::Call::GET_MAINTENANCE_STATUS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48084/#review135669 --- Fix it, then Ship it! src/master/master.hpp (line 1236)

Re: Review Request 48083: Fixed typo in `v1/master.proto`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48083/#review135668 --- Ship it! Thank you for catching these! - Vinod Kone On May 3

Re: Review Request 47505: Updated authorizer.proto Subject, Object and Request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47505/ --- (Updated May 31, 2016, 7:08 p.m.) Review request for mesos, Adam B, Alexander R

Re: Review Request 48084: Implemented v1::master::Call::GET_MAINTENANCE_STATUS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48084/ --- (Updated May 31, 2016, 7:06 p.m.) Review request for mesos and Vinod Kone. Ch

Review Request 48084: Implemented v1::master::Call::GET_MAINTENANCE_STATUS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48084/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5503 https://issues.ap

Re: Review Request 47505: Updated authorizer.proto Subject, Object and Request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47505/#review135667 --- Patch looks great! Reviews applied: [47505] Passed command: expo

Review Request 48083: Fixed typo in `v1/master.proto`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48083/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5503 https://issues.ap

Re: Review Request 46758: V1 API: Split Accept/Decline for offers and Inverse Offers.

> On May 30, 2016, 3:08 a.m., Guangya Liu wrote: > > include/mesos/scheduler/scheduler.proto, line 270 > > > > > > Just a question here: Does it make sense to highlight that this is a > > `inverse offer fiter`? such

Re: Review Request 47505: Updated authorizer.proto Subject, Object and Request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47505/#review135665 --- Fix it, then Ship it! Update your Request.subject/object commen

Re: Review Request 47505: Updated authorizer.proto Subject, Object and Request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47505/ --- (Updated May 31, 2016, 6:28 p.m.) Review request for mesos, Adam B, Alexander R

Re: Review Request 48000: Windows MVP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48000/ --- (Updated May 31, 2016, 6:25 p.m.) Review request for mesos. Repository: mesos

Re: Review Request 47505: Updated authorizer.proto Subject, Object and Request.

> On May 18, 2016, 8:30 a.m., Alexander Rukletsov wrote: > > Additionally, you should also update the local authorizer implementation, > > specifically > > ``` > > Future authorized( > > const authorization::Request& request, > > const vector& acls) > > ``` > > Currently, we do not

Re: Review Request 47505: Updated authorizer.proto Subject, Object and Request.

> On May 18, 2016, 8:30 a.m., Alexander Rukletsov wrote: > > include/mesos/authorizer/authorizer.proto, line 29 > > > > > > As per comment on MESOS-5405, I think it is fine that we have two ways > > of expressing {{A

Re: Review Request 47505: Updated authorizer.proto Subject, Object and Request.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47505/ --- (Updated May 31, 2016, 5:59 p.m.) Review request for mesos, Adam B, Alexander R

Re: Review Request 48048: Added documentation for access_sandboxes and access_mesos_logs acls.

> On May 31, 2016, 3:10 a.m., Adam B wrote: > > Can you please also update BROWSE_HELP, etc. with an `AUTHORIZATION(...)` > > string? This will also require you to run the script to update the > > endpoints help pages. > > - "Modifies the file `acls.proto`" seems wrong, since you're only modify

Re: Review Request 47991: Passed `Request` object by ptr instead of copying it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47991/#review135653 --- Fix it, then Ship it! 3rdparty/libprocess/src/process.cpp (lin

Re: Review Request 47990: Added move semantics to `Pipe::write()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47990/#review135654 --- Fix it, then Ship it! 3rdparty/libprocess/src/http.cpp (line 4

Re: Review Request 48048: Added documentation for access_sandboxes and access_mesos_logs acls.

> On May 31, 2016, 12:10 p.m., Adam B wrote: > > Can you please also update BROWSE_HELP, etc. with an `AUTHORIZATION(...)` > > string? This will also require you to run the script to update the > > endpoints help pages. > > - "Modifies the file `acls.proto`" seems wrong, since you're only modif

Re: Review Request 48054: Added intergration tests for authorization based endpoint filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48054/ --- (Updated May 31, 2016, 4:24 p.m.) Review request for mesos and Michael Park.

Re: Review Request 47891: Added RUN_TASK authorization action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47891/#review135633 --- Patch looks great! Reviews applied: [47891] Passed command: expo

Re: Review Request 47805: Add authorization to GET /weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47805/#review135615 --- Fix it, then Ship it! Thanks for the update. Just a handful mor

Re: Review Request 48051: Expose livereload port in site docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48051/#review135622 --- Patch looks great! Reviews applied: [48051] Passed command: expo

Re: Review Request 48048: Added documentation for access_sandboxes and access_mesos_logs acls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48048/#review135620 --- Can you please also update BROWSE_HELP, etc. with an `AUTHORIZATIO

Re: Review Request 47891: Added RUN_TASK authorization action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47891/ --- (Updated May 31, 2016, 11:22 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 48058: Added authorization based endpoint filtering documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48058/#review135619 --- Patch looks great! Reviews applied: [46093, 47558, 48052, 47559,

Re: Review Request 47891: Added RUN_TASK authorization action.

> On May 27, 2016, 11:43 p.m., Adam B wrote: > > src/master/master.cpp, line 3048 > > > > > > FrameworkInfo.user is the wrong user to pass in. It should be the user > > calculated by the code you removed above. >

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48049/#review135613 --- Patch looks great! Reviews applied: [48049] Passed command: expo

Re: Review Request 48051: Expose livereload port in site docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48051/#review135612 --- Ship it! Ship It! - haosdent huang On May 31, 2016, 7:23 a.m

Re: Review Request 47891: Added RUN_TASK authorization action.

> On May 28, 2016, 8:43 a.m., Adam B wrote: > > src/master/master.cpp, line 3048 > > > > > > FrameworkInfo.user is the wrong user to pass in. It should be the user > > calculated by the code you removed above. I a

Re: Review Request 47891: Added RUN_TASK authorization action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47891/#review135609 --- Nits & notes. I could fix these before committing, but you still n

Re: Review Request 48051: Expose livereload port in site docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48051/ --- (Updated May 31, 2016, 7:23 a.m.) Review request for mesos, haosdent huang, Kev

Re: Review Request 48051: Expose livereload port in site docker.

> On May 31, 2016, 1:50 a.m., haosdent huang wrote: > > site/README.md, line 61 > > > > > > @janisz I just test your patch. The livereload gem would bind to > > "0.0.0.0:35729" default. In Mac OSX, because docker lau

Re: Review Request 48051: Expose livereload port in site docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48051/ --- (Updated May 31, 2016, 7:22 a.m.) Review request for mesos, haosdent huang, Kev

Re: Review Request 48058: Added authorization based endpoint filtering documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48058/ --- (Updated May 31, 2016, 7:03 a.m.) Review request for mesos and Michael Park.