Re: Review Request 60562: Updated `accept` to perform operation adjustment in one place.

> On July 1, 2017, 2:13 a.m., Vinod Kone wrote: > > src/master/master.cpp > > Lines 3997 (patched) > > > > > > Can you log a warning here? I wouldn't log a warning here since it's the responsibility of the

Re: Review Request 60562: Updated `accept` to perform operation adjustment in one place.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60562/#review179454 --- Fix it, then Ship it! Made some suggestions for cleanups, feel

Re: Review Request 60564: Performed validation/upgrade of `Resource` objects before authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60564/#review179452 --- src/master/master.cpp Lines 3845-3856 (original), 3845-3856

Re: Review Request 60563: Updated `validateAndUpgradeResources` to operate on `Operation`s.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60563/#review179451 --- Ship it! src/common/resources_utils.cpp Line 199 (original),

Re: Review Request 60562: Updated `accept` to perform operation adjustment in one place.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60562/#review179450 --- Fix it, then Ship it! This is great. Thanks for the cleanup.

Re: Review Request 60563: Updated `validateAndUpgradeResources` to operate on `Operation`s.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60563/ --- (Updated June 30, 2017, 5:56 p.m.) Review request for mesos and Benjamin

Re: Review Request 60563: Updated `validateAndUpgradeResources` to operate on `Operation`s.

> On June 30, 2017, 12:44 p.m., Benjamin Bannier wrote: > > src/common/resources_utils.cpp > > Line 199 (original), 199 (patched) > > > > > > It seems by unconditionally calling `mutable_xyz` for `repeated` fields

Re: Review Request 60414: Update documentation for framework bounding capabilities.

> On July 1, 2017, 12:22 a.m., Jie Yu wrote: > > Can you update the CHANGELOG as well? And also upgrades.md. - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60414/#review179444

Re: Review Request 60414: Update documentation for framework bounding capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60414/#review179444 --- Can you update the CHANGELOG as well? - Jie Yu On June 24,

Re: Review Request 60411: Allow frameworks to specify the capabilities bounding set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60411/ --- (Updated July 1, 2017, 12:12 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 60497: Update mesos-execute capabilities options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60497/#review179442 --- Ship it! Ship It! - Jie Yu On June 28, 2017, 7:54 a.m.,

Re: Review Request 60414: Update documentation for framework bounding capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60414/#review179441 --- Ship it! Ship It! - Jie Yu On June 24, 2017, 6:11 a.m.,

Re: Review Request 60413: Rename and deprecate the LinuxInfo capability_info field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60413/#review179440 --- Ship it! Ship It! - Jie Yu On June 24, 2017, 6:11 a.m.,

Re: Review Request 60412: Add more linux/capabilities isolator test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60412/#review179438 --- Ship it! Ship It! - Jie Yu On June 24, 2017, 6:11 a.m.,

Re: Review Request 60411: Allow frameworks to specify the capabilities bounding set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60411/#review179437 --- Ship it! Ship It! - Jie Yu On June 24, 2017, 6:11 a.m.,

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/ --- (Updated June 30, 2017, 11:57 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 60410: Add bounding set support to linux/capabilities tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60410/#review179436 --- Ship it! Ship It! - Jie Yu On June 24, 2017, 6:11 a.m.,

Re: Review Request 60409: Add bounding_capabilities to LinuxInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60409/#review179435 --- Ship it! Ship It! - Jie Yu On June 24, 2017, 6:11 a.m.,

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/#review179433 --- src/slave/containerizer/mesos/launch.cpp Lines 799 (patched)

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/ --- (Updated June 30, 2017, 11:46 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179432 --- src/master/http.cpp Lines 3758 (patched)

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179431 --- src/master/http.cpp Lines 3758-3762 (original), 3758-3767

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179430 --- src/master/http.cpp Lines 3758-3762 (original), 3758-3767

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/ --- (Updated June 30, 2017, 11:37 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 60203: Introduce HTB class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60203/#review179425 --- Fix it, then Ship it! src/linux/routing/queueing/class.hpp

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179429 --- Also note: we need to follow up these patches with updates to the

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/ --- (Updated June 30, 2017, 11:26 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179428 --- src/tests/master_tests.cpp Lines 3510-3543 (patched)

Re: Review Request 60203: Introduce HTB class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60203/ --- (Updated June 30, 2017, 4:01 p.m.) Review request for mesos, Ilya Pronin, Jie

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59294/ --- (Updated June 30, 2017, 4 p.m.) Review request for mesos, Dmitry Zhuk, Ilya

Re: Review Request 60203: Introduce HTB class.

- Ian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60203/#review178789 --- On June 19, 2017, 12:36 p.m., Ian Downes wrote: > >

Re: Review Request 60203: Introduce HTB class.

> On June 23, 2017, 6:02 a.m., Ilya Pronin wrote: > > src/linux/routing/queueing/internal.hpp > > Lines 595-597 (patched) > > > > > > Why don't we handle this here to be consistent with other `*Class()` > >

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

> On June 26, 2017, 6:08 a.m., Ilya Pronin wrote: > > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > > Lines 2209-2210 (original), 2301-2302 (patched) > > > > > > Do we expect the helper to

Re: Review Request 60581: Added filtering to the '/slaves' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60581/ --- (Updated June 30, 2017, 10:44 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 60581: Added filtering to the '/slaves' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60581/ --- Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod

Re: Review Request 60520: Remove posix/subprocess.hpp dependencies.

> On June 30, 2017, 10:24 p.m., Gastón Kleiman wrote: > > docs/modules.md > > Line 91 (original), 91 (patched) > > > > > > Is the trailing comma here valid? Oops, looke like I picked up an unrelated change. I'll

Re: Review Request 60520: Remove posix/subprocess.hpp dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60520/#review179418 --- docs/modules.md Line 91 (original), 91 (patched)

Review Request 60580: Added filtering to the '/frameworks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60580/ --- Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod

Re: Review Request 60566: Validated and upgraded resources on the V1 operator API path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60566/#review179403 --- src/tests/master_tests.cpp Lines 7695 (patched)

Re: Review Request 60564: Performed validation/upgrade of `Resource` objects before authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60564/#review179399 --- Fix it, then Ship it! src/master/master.cpp Lines 3955-3978

Re: Review Request 60563: Updated `validateAndUpgradeResources` to operate on `Operation`s.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60563/#review179397 --- src/common/resources_utils.cpp Line 199 (original), 199

Re: Review Request 60562: Updated `accept` to perform operation adjustment in one place.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60562/#review179395 --- src/master/master.cpp Lines 3929 (patched)

Re: Review Request 60397: Check perf version compatibility in tests with disabled coredumps.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60397/ --- (Updated June 30, 2017, 5:41 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 59599: Added 'type' and 'name' fields to ResourceProviderInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59599/#review179385 --- Ship it! Ship It! - Benjamin Bannier On June 26, 2017, 6:30

Re: Review Request 56895: Added tests to ensure slave recovery post reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56895/ --- (Updated June 30, 2017, 3:18 p.m.) Review request for mesos, Neil Conway,

Re: Review Request 59936: Added streaming function for ResourceProviderInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59936/#review179364 --- Ship it! Ship It! - Benjamin Bannier On June 30, 2017, 6:02

Re: Review Request 59937: Added agent `--resource_provider_config_dir` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59937/#review179360 --- Ship it! Ship It! - Benjamin Bannier On June 30, 2017, 6:10

Re: Review Request 59937: Added agent `--resource_provider_config_dir` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59937/#review179351 --- Ship it! Ship It! - Jan Schlicht On June 30, 2017, 6:10

Review Request 60566: Validated and upgraded resources on the V1 operator API path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60566/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 59936: Added streaming function for ResourceProviderInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59936/#review179344 --- Ship it! Ship It! - Jan Schlicht On June 30, 2017, 6:02

Re: Review Request 59935: Introduced a streaming function for a vector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59935/#review179343 --- Ship it! Ship It! - Jan Schlicht On June 30, 2017, 5:54

Re: Review Request 60561: Replaced a few raw `for` loops with `foreach`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60561/#review179341 --- Ship it! Ship It! - Benjamin Mahler On June 30, 2017, 9

Review Request 60564: Performed validation/upgrade of `Resource` objects before authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60564/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7735

Review Request 60563: Updated `validateAndUpgradeResources` to operate on `Operation`s.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60563/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7735

Review Request 60562: Updated `accept` to perform operation adjustment in one place.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60562/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7735

Review Request 60561: Replaced a few raw `for` loops with `foreach`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60561/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 60558: Set container DNS with `--default_container_dns` in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60558/ --- (Updated June 30, 2017, 3:09 p.m.) Review request for mesos, Avinash sridharan

Review Request 60558: Set container DNS with `--default_container_dns` in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60558/ --- Review request for mesos, Avinash sridharan and Jie Yu. Bugs: MESOS-7709

Review Request 60557: Passed default container DNS info to Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60557/ --- Review request for mesos, Avinash sridharan and Jie Yu. Bugs: MESOS-7709