Re: Review Request 64226: Added a `ns::supported` convenience API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64226/#review198249 --- Patch looks great! Reviews applied: [64226] Passed command:

Re: Review Request 64226: Added a `ns::supported` convenience API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64226/#review198248 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 65775: Added a master API test for agent re-registration after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65775/#review198247 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 65774: Fixed a master API bug for agent re-registration after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65774/#review198246 --- Ship it! Ship It! - Greg Mann On Feb. 23, 2018, 8:08 p.m.,

Re: Review Request 65774: Fixed a master API bug for agent re-registration after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65774/#review198245 --- src/master/master.hpp Lines 2281-2285 (patched)

Re: Review Request 65785: Added a test for QuotaRequest validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65785/#review198244 --- Patch looks great! Reviews applied: [65334, 65514, 65515, 65780,

Re: Review Request 65775: Added a master API test for agent re-registration after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65775/#review198243 --- Ship it! Ship It! - Greg Mann On Feb. 24, 2018, 2:25 a.m.,

Re: Review Request 64226: Added a `ns::supported` convenience API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64226/#review198241 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 65775: Added a master API test for agent re-registration after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65775/ --- (Updated Feb. 24, 2018, 2:25 a.m.) Review request for mesos, Greg Mann, Jan

Re: Review Request 65683: Updated discard handling of the Docker 'inspect' call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/#review198240 --- src/docker/docker.cpp Lines 1287 (patched)

Re: Review Request 65775: Added a master API test for agent re-registration after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65775/#review198238 --- src/tests/api_tests.cpp Lines 2394 (patched)

Re: Review Request 65792: Fixed compilation error in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65792/#review198237 --- Ship it! Ship It! - Benjamin Mahler On Feb. 24, 2018, 1:21

Review Request 65792: Fixed compilation error in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65792/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review198236 --- Vinod and I went over this, a couple of issues: * The [endpoint

Re: Review Request 65775: Added a master API test for agent re-registration after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65775/ --- (Updated Feb. 24, 2018, 12:46 a.m.) Review request for mesos, Greg Mann, Jan

Re: Review Request 65791: Removed stale generated HTTP endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65791/#review198235 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 65791: Removed stale generated HTTP endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65791/#review198234 --- Ship it! Ship It! - Vinod Kone On Feb. 24, 2018, 12:29

Re: Review Request 65791: Removed stale generated HTTP endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65791/ --- (Updated Feb. 24, 2018, 12:29 a.m.) Review request for mesos, Benjamin Bannier

Review Request 65791: Removed stale generated HTTP endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65791/ --- Review request for mesos, Benjamin Bannier and Vinod Kone. Repository: mesos

Re: Review Request 65750: Added test for a hung 'docker inspect' during container pull.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65750/#review198233 --- Patch looks great! Reviews applied: [65786, 65787, 65751, 65750]

Re: Review Request 64226: Added a `ns::supported` convenience API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64226/#review198232 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 65594: Checkpointed profiles in storage local resource provider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65594/#review197572 --- src/resource_provider/storage/provider.cpp Line 1304 (original),

Re: Review Request 64226: Added a `ns::supported` convenience API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64226/#review198231 --- Fix it, then Ship it! LGTM src/linux/ns.cpp Lines 158

Re: Review Request 65785: Added a test for QuotaRequest validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65785/#review198229 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 65786: Prevented Docker library from terminating incorrect processes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65786/#review198228 --- Ship it! Ship It! - Michael Park On Feb. 23, 2018, 2:37

Re: Review Request 65750: Added test for a hung 'docker inspect' during container pull.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65750/ --- (Updated Feb. 23, 2018, 11:26 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65751/ --- (Updated Feb. 23, 2018, 11:24 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 65750: Added test for a hung 'docker inspect' during container pull.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65750/#review198226 --- Fix it, then Ship it!

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65751/#review198225 --- Ship it! Ship It! - Gilbert Song On Feb. 23, 2018, 2:39

Re: Review Request 65787: Updated discard handling for Docker 'stop' and 'pull' commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65787/#review198224 --- Ship it! Ship It! - Gilbert Song On Feb. 23, 2018, 2:38

Re: Review Request 65786: Prevented Docker library from terminating incorrect processes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65786/#review198223 --- Ship it! Ship It! - Gilbert Song On Feb. 23, 2018, 2:37

Re: Review Request 65683: Updated discard handling of the Docker 'inspect' call.

> On Feb. 23, 2018, 5:38 p.m., Gilbert Song wrote: > > src/docker/docker.cpp > > Lines 1199 (patched) > > > > > > Should we use a lambda instead of `lambda::bind`? (I know we want > > consistency in this file

Re: Review Request 65683: Updated discard handling of the Docker 'inspect' call.

> On Feb. 23, 2018, 5:38 p.m., Gilbert Song wrote: > > src/docker/docker.cpp > > Lines 151 (patched) > > > > > > Should we do `killtree()` even if the status is not pending (e.g., > > ready or failure)? > > >

Re: Review Request 65683: Updated discard handling of the Docker 'inspect' call.

> On Feb. 23, 2018, 9:14 a.m., Greg Mann wrote: > > src/docker/docker.cpp > > Lines 1287-1293 (patched) > > > > > > Whoops, this is not threadsafe :facepalm: > > > > For example, we could call

Re: Review Request 65683: Updated discard handling of the Docker 'inspect' call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/ --- (Updated Feb. 23, 2018, 11:07 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 65750: Added test for a hung 'docker inspect' during container pull.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65750/#review198218 --- FAIL: Failed to apply the dependent review: 65786. Failed

Re: Review Request 65514: Introduced a CHECK_NOTERROR macro.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65514/#review198217 --- Fix it, then Ship it! 3rdparty/stout/include/stout/check.hpp

Review Request 65785: Added a test for QuotaRequest validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65785/ --- Review request for mesos, Michael Park and Meng Zhu. Repository: mesos

Review Request 65783: Added a test for validation of UPDATE_QUOTA master::Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65783/ --- Review request for mesos, Michael Park and Meng Zhu. Repository: mesos

Review Request 65780: Removed an unnecessary argument from master::Call validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65780/ --- Review request for mesos, Michael Park and Meng Zhu. Repository: mesos

Review Request 65784: Added validation of QuotaRequest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65784/ --- Review request for mesos, Michael Park and Meng Zhu. Repository: mesos

Review Request 65782: Implemented master::Call validation for UPDATE_QUOTA.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65782/ --- Review request for mesos, Michael Park and Meng Zhu. Repository: mesos

Review Request 65781: Added a TODO to clean up master::Call validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65781/ --- Review request for mesos, Michael Park and Meng Zhu. Repository: mesos

Re: Review Request 65750: Added test for a hung 'docker inspect' during container pull.

> On Feb. 23, 2018, 6:12 p.m., Gilbert Song wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp > > Lines 5251-5258 (patched) > > > > > > Instead of following the style in this file, could we do

Re: Review Request 65750: Added test for a hung 'docker inspect' during container pull.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65750/ --- (Updated Feb. 23, 2018, 10:41 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65751/ --- (Updated Feb. 23, 2018, 10:39 p.m.) Review request for mesos, Andrei Budnik,

Review Request 65787: Updated discard handling for Docker 'stop' and 'pull' commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65787/ --- Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park. Bugs:

Review Request 65786: Prevented Docker library from terminating incorrect processes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65786/ --- Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park. Bugs:

Re: Review Request 65334: Added quota limit to the master API protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65334/ --- (Updated Feb. 23, 2018, 10:23 p.m.) Review request for mesos, Alexander

Re: Review Request 65515: Added rvalue reference Try::get overloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65515/#review198215 --- FAIL: Failed to apply the dependent review: 65334. Failed

Re: Review Request 65515: Added rvalue reference Try::get overloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65515/ --- (Updated Feb. 23, 2018, 10:16 p.m.) Review request for mesos and Michael Park.

Re: Review Request 65775: Added a master API test for agent re-registration after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65775/#review198212 --- Patch looks great! Reviews applied: [65774, 65775] Passed

Re: Review Request 65774: Fixed a master API bug for agent re-registration after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65774/#review198204 --- FAIL: Failed to apply the current review. Failed command:

Review Request 65775: Added a master API test for agent re-registration after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65775/ --- Review request for mesos, Greg Mann, Jan Schlicht, Vinod Kone, and Jiang Yan Xu.

Review Request 65774: Fixed a master API bug for agent re-registration after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65774/ --- Review request for mesos, Greg Mann, Jan Schlicht, Vinod Kone, and Jiang Yan Xu.

Re: Review Request 65674: Introduced helper for creating Mesos UUIDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65674/#review198202 --- Patch looks great! Reviews applied: [65587, 65588, 65589, 65590,

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

> On Feb. 23, 2018, 6:06 p.m., Gilbert Song wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp > > Lines 5148 (patched) > > > > > > Should we use `double`? The `sleep` command only accepts integer

Re: Review Request 65713: Handled hanging docker `stop`, `inspect` commands in docker executor.

> On Feb. 23, 2018, 6:24 p.m., Gilbert Song wrote: > > src/docker/executor.cpp > > Lines 319-321 (patched) > > > > > > Should we also call `.discard()` in this case? We need to discard `inspect` only in

Re: Review Request 65683: Updated discard handling in Docker library functions.

> On Feb. 23, 2018, 2:18 p.m., Andrei Budnik wrote: > > src/docker/docker.cpp > > Lines 1292 (patched) > > > > > > I think we don't need to discard the output, because the process will > > be killed, hence

Re: Review Request 65683: Updated discard handling in Docker library functions.

> On Feb. 23, 2018, 9:14 a.m., Greg Mann wrote: > > src/docker/docker.cpp > > Lines 1287-1293 (patched) > > > > > > Whoops, this is not threadsafe :facepalm: > > > > For example, we could call

Re: Review Request 65713: Handled hanging docker `stop`, `inspect` commands in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65713/#review198196 --- src/docker/executor.cpp Lines 319-321 (patched)

Re: Review Request 65750: Added test for a hung 'docker inspect' during container pull.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65750/#review198195 --- Fix it, then Ship it!

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

> On Feb. 23, 2018, 8:35 a.m., Andrei Budnik wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp > > Lines 5133 (patched) > > > > > > `os::write()` is not atomical, so we should write to a temporary

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65751/#review198194 --- Ship it! Ship It! - Gilbert Song On Feb. 22, 2018, 3:28

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65751/#review198192 --- src/tests/containerizer/docker_containerizer_tests.cpp Lines

Re: Review Request 65743: Ensured that Docker containerizer returns a failed Future in one case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65743/#review198191 --- Ship it! Ship It! - Gilbert Song On Feb. 21, 2018, 4:39

Re: Review Request 65683: Updated discard handling in Docker library functions.

> On Feb. 23, 2018, 1:14 a.m., Greg Mann wrote: > > src/docker/docker.cpp > > Lines 1287-1293 (patched) > > > > > > Whoops, this is not threadsafe :facepalm: > > > > For example, we could call

Re: Review Request 65683: Updated discard handling in Docker library functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/#review198188 --- src/docker/docker.cpp Lines 151 (patched)

Re: Review Request 65750: Added test for a hung 'docker inspect' during container pull.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65750/#review198186 --- src/tests/containerizer/docker_containerizer_tests.cpp Lines

Re: Review Request 65773: Introduced Docker image build and publish scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65773/#review198187 --- Patch looks great! Reviews applied: [65772, 65773] Passed

Re: Review Request 65751: Added test fixture for a hung Docker daemon.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65751/#review198184 --- src/tests/containerizer/docker_containerizer_tests.cpp Lines

Re: Review Request 65674: Introduced helper for creating Mesos UUIDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65674/#review198183 --- FAIL: Failed to apply the dependent review: 65587. Failed

Re: Review Request 65743: Ensured that Docker containerizer returns a failed Future in one case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65743/#review198182 --- Ship it! Ship It! - Andrei Budnik On Feb. 22, 2018, 12:39

Re: Review Request 65591: Explicitly tracked resource providers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/ --- (Updated Feb. 23, 2018, 4:22 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 65588: Used proto UUID instead stout UUID internally for operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65588/ --- (Updated Feb. 23, 2018, 4:22 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 65773: Introduced Docker image build and publish scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65773/#review198181 --- FAIL: Failed to apply the dependent review: 65772. Failed

Review Request 65772: Moved some docker image setups to dedicated directory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65772/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 65773: Introduced Docker image build and publish scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65773/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 65683: Updated discard handling in Docker library functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/#review198179 --- src/docker/docker.cpp Lines 1292 (patched)

Re: Review Request 65683: Updated discard handling in Docker library functions.

> On Feb. 23, 2018, 9:14 a.m., Greg Mann wrote: > > src/docker/docker.cpp > > Lines 1287-1293 (patched) > > > > > > Whoops, this is not threadsafe :facepalm: > > > > For example, we could call

Re: Review Request 65759: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65759/#review198176 --- Bad patch! Reviews applied: [65759, 65713, 65743, 65683] Failed

Re: Review Request 65759: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65759/#review198175 --- FAIL: Failed to apply the dependent review: 65683. Failed

Re: Review Request 65759: Added inspect retries to the Docker executor.

> On Feb. 23, 2018, 8:57 a.m., Greg Mann wrote: > > src/docker/executor.cpp > > Lines 25 (patched) > > > > > > Is this necessary? Without this header, I'm getting: ``` ../../src/docker/executor.cpp:230:32: error:

Re: Review Request 65713: Handled hanging docker `stop`, `inspect` commands in docker executor.

> On Feb. 23, 2018, 8:42 a.m., Greg Mann wrote: > > src/docker/executor.cpp > > Lines 535 (patched) > > > > > > We should probably move this inside the `if (killedByHealthCheck)` > > conditional, since the kill is

Re: Review Request 65674: Introduced helper for creating Mesos UUIDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65674/#review198172 --- src/common/protobuf_utils.hpp Lines 187 (patched)

Re: Review Request 64970: Replace ad hoc venv under support/ with tox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/#review198171 --- Patch looks great! Reviews applied: [64970] Passed command:

Re: Review Request 65683: Updated discard handling in Docker library functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/#review198170 --- src/docker/docker.cpp Lines 1287-1293 (patched)

Re: Review Request 65759: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65759/#review198168 --- src/docker/executor.cpp Lines 25 (patched)

Re: Review Request 64970: Replace ad hoc venv under support/ with tox.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64970/#review198169 --- PASS: Mesos patch 64970 was successfully built and tested.

Re: Review Request 65713: Handled hanging docker `stop`, `inspect` commands in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65713/#review198148 --- src/docker/executor.cpp Lines 535 (patched)