Re: Review Request 69158: Added an integration test for resource provider removal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69158/#review212001 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Jan. 14, 2019, 6:39 p.m., Gilbert Song wrote: > > include/mesos/mesos.proto > > Lines 3158-3159 (patched) > > > > > > Seems like this was added recently. > > > > Is this field only used when there is

Re: Review Request 69158: Added an integration test for resource provider removal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69158/#review211998 --- src/tests/slave_tests.cpp Lines 10609 (patched)

Re: Review Request 69158: Added an integration test for resource provider removal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69158/#review211996 --- src/tests/slave_tests.cpp Lines 10617 (patched)

Re: Review Request 68147: Added agent support to remove local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68147/#review211997 --- src/tests/api_tests.cpp Lines 7857 (patched)

Re: Review Request 68147: Added agent support to remove local resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68147/#review211993 --- src/master/master.cpp Lines 11248 (patched)

Re: Review Request 68147: Added agent support to remove local resource providers.

> On Aug. 17, 2018, 10:29 p.m., Chun-Hung Hsiao wrote: > > src/slave/slave.cpp > > Lines 8195 (patched) > > > > > > Let's validate that there is no task using the resources provided by > > this RP before doing the

Re: Review Request 68017: Added Seccomp-related protobuf messages.

> On Jan. 14, 2019, 6:39 p.m., Gilbert Song wrote: > > include/mesos/mesos.proto > > Lines 3158-3159 (patched) > > > > > > Seems like this was added recently. > > > > Is this field only used when there is

Re: Review Request 68022: Enabled Seccomp filter in the containerizer launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68022/#review211988 --- Ship it! Ship It! - Qian Zhang On Aug. 6, 2018, 9:39 p.m.,

Re: Review Request 68021: Added `linux/seccomp` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68021/#review211985 --- Fix it, then Ship it!

Re: Review Request 68018: Added `SeccompFilter` class.

> On Jan. 2, 2019, 5:58 p.m., Gilbert Song wrote: > > src/linux/seccomp/seccomp.cpp > > Lines 141-144 (patched) > > > > > > Instead of always set `SCMP_FLTATR_CTL_NNP`. Should we consider to > > check root

Re: Review Request 68017: Added Seccomp-related protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/#review211986 --- Fix it, then Ship it! include/mesos/mesos.proto Lines

Re: Review Request 68018: Added `SeccompFilter` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68018/#review211981 --- Fix it, then Ship it! src/linux/seccomp/seccomp.cpp Lines 173

Re: Review Request 68020: Added Seccomp-related flags to the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68020/#review211983 --- Fix it, then Ship it! src/slave/flags.cpp Lines 1399

Re: Review Request 68018: Added `SeccompFilter` class.

> On Jan. 14, 2019, 12:31 a.m., Qian Zhang wrote: > > src/linux/seccomp/seccomp.cpp > > Lines 137-139 (patched) > > > > > > Will this affect the task run by Mesos? E.g., a task may want to run a > > program which

Re: Review Request 68018: Added `SeccompFilter` class.

> On Jan. 14, 2019, 4:31 p.m., Qian Zhang wrote: > > src/linux/seccomp/seccomp.cpp > > Lines 137-139 (patched) > > > > > > Will this affect the task run by Mesos? E.g., a task may want to run a > > program which

Re: Review Request 69658: Avoided manual indexing during iteration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69658/#review211980 --- PASS: Mesos patch 69658 was successfully built and tested.

Re: Review Request 69669: Notified frameworks when operations are marked as unreachable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69669/#review211978 --- Ship it! Ship It! - Greg Mann On Jan. 11, 2019, 2:24 p.m.,

Re: Review Request 69687: Fixed flakiness of resource provider ContainerTerminationMetric test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69687/#review211975 --- Fix it, then Ship it!

Re: Review Request 69658: Avoided manual indexing during iteration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69658/#review211973 --- src/resource_provider/storage/provider.cpp Line 1211 (original),

Re: Review Request 69719: Exposed subscriptions and disconnections RP manager metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69719/#review211971 --- src/resource_provider/manager.cpp Lines 823-832 (original),

Re: Review Request 68017: Added Seccomp-related protobuf messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/#review211972 --- include/mesos/seccomp/seccomp.proto Lines 21-28 (patched)

Re: Review Request 69721: Broke up `SSLTest.ProtocolMismatch` into smaller tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69721/#review211969 --- PASS: Mesos patch 69721 was successfully built and tested.

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/#review211968 --- PASS: Mesos patch 69708 was successfully built and tested.

Re: Review Request 69606: Made starting and stopping on CSI plugin containers more verbose.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69606/#review211967 --- Fix it, then Ship it! Not sure how much we gain from this

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/ --- (Updated Jan. 14, 2019, 9:47 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69656: Fixed test `MesosContainerizerSlaveRecoveryTest.ResourceStatistics`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69656/#review211965 --- PASS: Mesos patch 69656 was successfully built and tested.

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/ --- (Updated Jan. 14, 2019, 8:21 p.m.) Review request for mesos, Benjamin Bannier,

[GitHub] kaysoky commented on a change in pull request #324: MESOS-9499 extended URI syntax to support any Zookeeper authentication schemes

kaysoky commented on a change in pull request #324: MESOS-9499 extended URI syntax to support any Zookeeper authentication schemes URL: https://github.com/apache/mesos/pull/324#discussion_r247638473 ## File path: include/mesos/zookeeper/url.hpp ## @@ -101,16 +102,35 @@

Re: Review Request 69729: Removed unused class fields in the allocator.

> On Jan. 11, 2019, 6:15 p.m., Benjamin Mahler wrote: > > Seems useful to add a bit of context to the description that these are now > > duplicated via the options struct and used through that? Did I understand > > right? That is correct. Updated the summary. - Meng

Re: Review Request 69720: Made `SSLTest` an unparameterized test suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69720/ --- (Updated Jan. 14, 2019, 8:54 p.m.) Review request for mesos and Till

Re: Review Request 69720: Made `SSLTest` an unparameterized test suite.

> On Jan. 14, 2019, 7:40 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/tests/ssl_tests.cpp > > Line 417 (original), 421 (patched) > > > > > > You can consider moving this test up to group with the other > >

Re: Review Request 69721: Broke up `SSLTest.ProtocolMismatch` into smaller tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69721/ --- (Updated Jan. 14, 2019, 8:54 p.m.) Review request for mesos and Till

Re: Review Request 69656: Fixed test `MesosContainerizerSlaveRecoveryTest.ResourceStatistics`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69656/#review211962 --- Fix it, then Ship it! src/tests/slave_recovery_tests.cpp

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/#review211960 --- 3rdparty/grpc-1.10.0.patch Lines 22-29 (patched)

Re: Review Request 69735: Fixed maintenance causes machines not in schedule rescinding offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69735/#review211959 --- Here's a test I wrote for this issue:

Re: Review Request 69721: Broke up `SSLTest.ProtocolMismatch` into smaller tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69721/#review211958 --- Ship it! Ship It! - Joseph Wu On Jan. 11, 2019, 3:22 a.m.,

Re: Review Request 69720: Made `SSLTest` an unparameterized test suite.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69720/#review211957 --- Fix it, then Ship it!

Re: Review Request 69726: Fixed flakiness in MasterAPITest.OperationUpdatesUponOfferGone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69726/#review211956 --- PASS: Mesos patch 69726 was successfully built and tested.

Re: Review Request 69726: Fixed flakiness in MasterAPITest.OperationUpdatesUponOfferGone.

> On Jan. 12, 2019, 8:50 p.m., Benjamin Bannier wrote: > > src/tests/api_tests.cpp > > Line 4830 (original), 4830 (patched) > > > > > > Could you explain what in particular is broken here (e.g., by linking a > >

Re: Review Request 69726: Fixed flakiness in MasterAPITest.OperationUpdatesUponOfferGone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69726/ --- (Updated Jan. 14, 2019, 4:35 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 68019: Added a parser for the Docker Seccomp config format.

> On Jan. 14, 2019, 1:24 p.m., Qian Zhang wrote: > > src/linux/seccomp/seccomp_parser.cpp > > Lines 363-365 (patched) > > > > > > So `includes` is a **required** field in a seccomp profile, at least we > > should

Re: Review Request 68019: Added a parser for the Docker Seccomp config format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68019/#review211947 --- Fix it, then Ship it! src/linux/seccomp/seccomp_parser.cpp

Re: Review Request 68018: Added `SeccompFilter` class.

> On Jan. 14, 2019, 8:31 a.m., Qian Zhang wrote: > > src/linux/seccomp/seccomp.cpp > > Lines 137-139 (patched) > > > > > > Will this affect the task run by Mesos? E.g., a task may want to run a > > program which

Re: Review Request 69735: Fixed maintenance causes machines not in schedule rescinding offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69735/#review211948 --- Is `MasterAPITest.OperationUpdatesUponAgentGone/1` failure

Re: Review Request 68018: Added `SeccompFilter` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68018/#review211946 --- src/linux/seccomp/seccomp.cpp Lines 137-139 (patched)