> On Dec. 12, 2018, 3:51 p.m., Gilbert Song wrote:
> > configure.ac
> > Lines 352 (patched)
> > <https://reviews.apache.org/r/68016/diff/9/?file=2110248#file2110248line352>
> >
> > Do we have a plan to deprecate this configuraton flag in the future?
&g
uld we move the seccomp proto to
include/mesos/seccomp and create a .hpp file there?
- Gilbert Song
On Nov. 8, 2018, 7:24 a.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
)
<https://reviews.apache.org/r/68017/#comment296232>
When parsing a profile, I can see unavoidably we have to do some
transforming in the parser helper, but probably we could do best effort to
leverage protobuf::parse<>().
- Gilbert Song
On Nov. 8, 2018, 7:24 a.m., Andrei
or add a TODO
include/mesos/slave/containerizer.proto
Lines 269 (patched)
<https://reviews.apache.org/r/68017/#comment296203>
How do we add repeated `subArchitectures` under the current `Architecture`
in the future?
- Gilbert Song
On Nov. 8, 2018,
g/r/68016/#comment296192>
Do we have a plan to deprecate this configuraton flag in the future? E.g.,
always only compile the seccomp library on linux.
- Gilbert Song
On Nov. 8, 2018, 7:23 a.m., Andrei Budnik wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69540/#review211175
---
Ship it!
Ship It!
- Gilbert Song
On Dec. 10, 2018, 8:41 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69545/#review211176
---
Ship it!
Ship It!
- Gilbert Song
On Dec. 10, 2018, 10:37
could apply and commit.
- Gilbert Song
On Aug. 6, 2018, 6:37 a.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69449/#review210892
---
Ship it!
Ship It!
- Gilbert Song
On Nov. 26, 2018, 12:38
Zhang.
Repository: mesos
Description
---
Fixed sandbox creation chmod error handling in the agent.
Diffs
-
src/slave/paths.cpp 9fd37f5456d45d520d6062577c1692a4be627c0e
Diff: https://reviews.apache.org/r/69441/diff/1/
Testing
---
N/A
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69389/#review210654
---
Ship it!
Ship It!
- Gilbert Song
On Nov. 18, 2018, 11:33
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69376/#review210637
---
Ship it!
Ship It!
- Gilbert Song
On Nov. 17, 2018, 6:08 a.m
apache.org/r/69286/#comment295051>
Remove these lines?
- Gilbert Song
On Nov. 7, 2018, 2:03 p.m., Jason Lai wrote:
>
> ---
> This is an automatically generated e-mail. To reply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69235/#review210404
---
Ship it!
Ship It!
- Gilbert Song
On Nov. 1, 2018, 2:28 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68642/#review210405
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 23, 2018, 7:30 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68645/#review210410
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 14, 2018, 7:10 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69016/#review210409
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 14, 2018, 7:11 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68995/#review210412
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 14, 2018, 7:14 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68991/#review210406
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 18, 2018, 11:58
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68644/#review210408
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 16, 2018, 11:43
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68646/#review210411
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 14, 2018, 7:12 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68643/#review210407
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 19, 2018, 8:37 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69234/#review210403
---
Ship it!
Ship It!
- Gilbert Song
On Nov. 5, 2018, 12:02 a.m
tps://reviews.apache.org/r/69234/#comment294951>
I would suggest to change the behavior for all nested container. If user is
not specified, always inherit from parent user.
- Gilbert Song
On Nov. 1, 2018, 2:25 p.m., Qian Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69236/#review210263
---
Ship it!
Ship It!
- Gilbert Song
On Nov. 1, 2018, 2:29 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69218/#review210201
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 30, 2018, 3:02 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69123/#review210194
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 25, 2018, 8:25 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69217/#review210193
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 30, 2018, 2:15 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69188/#review210180
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 28, 2018, 9:11 p.m
x/pipe.hpp
9838d7b3abac5d004839c78bd6f88c077cee5e3e
Diff: https://reviews.apache.org/r/69059/diff/1/
Testing
---
Thanks,
Gilbert Song
Testing
---
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63655/#review209600
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 1, 2018, 10:37 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63654/#review209599
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 1, 2018, 10:36 a.m
previous release. Could we
add a unit test to simulate the cgroup root being removed issue?
- Gilbert Song
On Oct. 10, 2018, 10:12 p.m., fei long wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68987/#review209435
---
Do we want a simple unit test?
- Gilbert Song
On Oct. 10, 2018
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68987/#review209434
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 10, 2018, 10:18
11dfbab182487c45fa494c41e31f777272b4b5d0
Diff: https://reviews.apache.org/r/68929/diff/3/
Changes: https://reviews.apache.org/r/68929/diff/2-3/
Testing
---
make check
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68941/
---
(Updated Oct. 8, 2018, 10:36 a.m.)
Review request for mesos, Greg Mann, Jie Yu,
nerated e-mail. To reply, visit:
https://reviews.apache.org/r/68941/#review209283
-------
On Oct. 5, 2018, 4:32 p.m., Gilbert Song wrote:
>
> ---
> This i
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68941/
---
(Updated Oct. 7, 2018, 11:56 p.m.)
Review request for mesos, Greg Mann, Jie Yu,
?
- Gilbert Song
On Oct. 4, 2018, 3:14 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68923/
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68941/
---
Review request for mesos, Greg Mann, Jie Yu, Meng Zhu, Qian Zhang, and Vinod
Kon
11dfbab182487c45fa494c41e31f777272b4b5d0
Diff: https://reviews.apache.org/r/68929/diff/2/
Changes: https://reviews.apache.org/r/68929/diff/1-2/
Testing
---
make check
Thanks,
Gilbert Song
11dfbab182487c45fa494c41e31f777272b4b5d0
Diff: https://reviews.apache.org/r/68929/diff/1/
Testing
---
make check
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68923/#review209246
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 4, 2018, 3:14 p.m
> On Oct. 3, 2018, 3:43 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
> > Lines 2268-2270 (patched)
> > <https://reviews.apache.org/r/68921/diff/1/?file=2094274#file2094274line2268>
> >
> > Do we still need t
Lines 2268-2270 (patched)
<https://reviews.apache.org/r/68921/#comment293525>
Do we still need this fallback if we are confident enough? or consider a
TODO to remove the fallback logic?
- Gilbert Song
On Oct. 3, 2018, 3:36 p.m., Sergey Urbanovich
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68921/#review209200
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 3, 2018, 3:36 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68912/#review209192
---
Ship it!
Ship It!
- Gilbert Song
On Oct. 3, 2018, 8:05 a.m
;
> (Updated Sept. 29, 2018, 7:06 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-9231
> https://issues.apache.org/jira/browse/MESOS-9231
>
>
> Repository: mesos
>
>
> Description
> ---
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68887/#review209122
---
Ship it!
Ship It!
- Gilbert Song
On Sept. 29, 2018, 7:06
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68872/#review209121
---
Ship it!
Ship It!
- Gilbert Song
On Sept. 28, 2018, 8:22
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68882/#review209120
---
Ship it!
Ship It!
- Gilbert Song
On Sept. 28, 2018, 8:21
?
- Gilbert Song
On Sept. 28, 2018, 12:04 a.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68880/#review209111
---
Ship it!
Ship It!
- Gilbert Song
On Sept. 28, 2018, 4:09
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68755/#review208747
---
Ship it!
Ship It!
- Gilbert Song
On Sept. 18, 2018, 9:47
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68555/#review208373
---
Ship it!
Ship It!
- Gilbert Song
On Aug. 29, 2018, 12:22
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68495/#review208372
---
Ship it!
Ship It!
- Gilbert Song
On Sept. 3, 2018, 6:53 p.m
Global test environment tear-down
[==] 3 tests from 1 test case ran. (29925 ms total)
[ PASSED ] 1 test.
[ FAILED ] 2 tests, listed below:
[ FAILED ]
BackendFlag/ProvisionerDockerBackendTest.ROOT_INTERNET_CURL_DTYPE_RootfsCleanup/1,
where GetParam() = "aufs"
[ FAILED ]
BackendFlag/ProvisionerDockerBackendTest.ROOT_INTERNET_CURL_DTYPE_RootfsCleanup/2,
where GetParam() = "overlay"
```
Thanks,
Gilbert Song
TYPE_RootfsCleanup/2,
where GetParam() = "overlay" (7324 ms)
[--] 3 tests from BackendFlag/ProvisionerDockerBackendTest (29894 ms
total)
[--] Global test environment tear-down
[==] 3 tests from 1 test case ran. (29925 ms total)
[ PASSED ] 1 test.
[ FAILED ] 2 tests, listed below:
[ FAILED ]
BackendFlag/ProvisionerDockerBackendTest.ROOT_INTERNET_CURL_DTYPE_RootfsCleanup/1,
where GetParam() = "aufs"
[ FAILED ]
BackendFlag/ProvisionerDockerBackendTest.ROOT_INTERNET_CURL_DTYPE_RootfsCleanup/2,
where GetParam() = "overlay"
```
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68598/#review208219
---
Ship it!
Ship It!
- Gilbert Song
On Aug. 31, 2018, 9:56 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68594/#review208215
---
Ship it!
Ship It!
- Gilbert Song
On Aug. 31, 2018, 9:50 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68596/#review208217
---
Ship it!
Ship It!
- Gilbert Song
On Aug. 31, 2018, 9:50 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68597/#review208218
---
Ship it!
Ship It!
- Gilbert Song
On Aug. 31, 2018, 9:50 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68595/#review208216
---
Ship it!
Ship It!
- Gilbert Song
On Aug. 31, 2018, 9:50 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68477/#review207779
---
Ship it!
Ship It!
- Gilbert Song
On Aug. 22, 2018, 4:19 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68479/#review207780
---
Ship it!
Ship It!
- Gilbert Song
On Aug. 22, 2018, 4:30 p.m
(original), 229 (patched)
<https://reviews.apache.org/r/68445/#comment291210>
s/point/points/g
- Gilbert Song
On Aug. 21, 2018, 3:01 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
/
Testing
---
make check
Thanks,
Gilbert Song
UNSET_CLOEXEC
via the ChildHook.
Diffs
-
src/slave/container_loggers/lib_logrotate.cpp
6a2839e07e0ea759ec16cb879ef0602341fd9f5c
Diff: https://reviews.apache.org/r/68458/diff/1/
Testing
---
make check
Thanks,
Gilbert Song
/container_loggers/lib_logrotate.cpp
fa71e07290413ae0670f9879cec60f59de005adb
Diff: https://reviews.apache.org/r/68397/diff/2/
Changes: https://reviews.apache.org/r/68397/diff/1-2/
Testing
---
Thanks,
Gilbert Song
01e3272fccda6ff66e1629fb10d22d8c4967b22a
Diff: https://reviews.apache.org/r/68396/diff/2/
Changes: https://reviews.apache.org/r/68396/diff/1-2/
Testing
---
make check
Thanks,
Gilbert Song
: https://reviews.apache.org/r/68396/diff/1/
Testing
---
make check
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63280/#review207546
---
Ship it!
Ship It!
- Gilbert Song
On Aug. 17, 2018, 11:14
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63682/#review207448
---
Could we rebase?
- Gilbert Song
On May 24, 2018, 2:17 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63280/#review207447
---
Could we rebase?
- Gilbert Song
On May 24, 2018, 2:16 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63270/#review207446
---
Ship it!
Ship It!
- Gilbert Song
On May 24, 2018, 2:16 p.m
fa71e07290413ae0670f9879cec60f59de005adb
Diff: https://reviews.apache.org/r/68397/diff/1/
Testing
---
Thanks,
Gilbert Song
01e3272fccda6ff66e1629fb10d22d8c4967b22a
Diff: https://reviews.apache.org/r/68396/diff/1/
Testing
---
make check
Thanks,
Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68222/#review207271
---
Ship it!
Ship It!
- Gilbert Song
On Aug. 13, 2018, 11:29
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68221/#review207270
---
Ship it!
Ship It!
- Gilbert Song
On Aug. 13, 2018, 11:29
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68216/#review207269
---
Ship it!
Ship It!
- Gilbert Song
On Aug. 13, 2018, 11:28
1175-1179 (patched)
<https://reviews.apache.org/r/68222/#comment290485>
why do we have 1 here?
src/tests/containerizer/docker_volume_isolator_tests.cpp
Lines 1307-1311 (patched)
<https://reviews.apache.org/r/68222/#comment290486>
ditto.
- Gilbert Song
On Aug. 7, 2018, 7:2
/isolator.cpp
Lines 343 (patched)
<https://reviews.apache.org/r/68221/#comment290482>
ditto
- Gilbert Song
On Aug. 7, 2018, 7:23 a.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68220/#review207188
---
Ship it!
Ship It!
- Gilbert Song
On Aug. 7, 2018, 7:23 a.m
/secret.cpp
Lines 287 (patched)
<https://reviews.apache.org/r/68219/#comment290479>
Why not the same order as previous patches? I guess it does not hurt
- Gilbert Song
On Aug. 7, 2018, 7:22 a.m., Qian Zhang wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68218/#review207183
---
Ship it!
Ship It!
- Gilbert Song
On Aug. 7, 2018, 7:22 a.m
117 (patched)
<https://reviews.apache.org/r/68216/#comment290478>
Given we already parse the volume once in prepare(), should we consider
avoid parse it again in _prepare() and pass a vector of bool along?
- Gilbert Song
On Aug. 7, 2018, 7:20 a.m., Qian Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68215/#review207136
---
Ship it!
Ship It!
- Gilbert Song
On Aug. 7, 2018, 7:19 a.m
/volume/sandbox_path.cpp
Line 373 (original), 373 (patched)
<https://reviews.apache.org/r/68214/#comment290359>
Not yours, but could we remove this?
- Gilbert Song
On Aug. 7, 2018, 7:18 a.m., Qian Zhang wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68299/#review207126
---
Ship it!
Ship It!
- Gilbert Song
On Aug. 10, 2018, 10:37
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68300/#review207083
---
Ship it!
Ship It!
- Gilbert Song
On Aug. 10, 2018, 11:11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68213/#review207058
---
Ship it!
Ship It!
- Gilbert Song
On Aug. 7, 2018, 7:11 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68212/#review207057
---
Ship it!
Ship It!
- Gilbert Song
On Aug. 7, 2018, 7:09 a.m
and set the default value as 60
seconds. You guys could configure the flag to be longer (I would suggest
forever).
- Gilbert Song
On July 30, 2018, 10:50 a.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68051/#review206489
---
Ship it!
Ship It!
- Gilbert Song
On July 25, 2018, 10:35
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67896/#review206298
---
Ship it!
Ship It!
- Gilbert Song
On July 19, 2018, 2:10 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67897/#review206221
---
Ship it!
Ship It!
- Gilbert Song
On July 12, 2018, 7:17 a.m
ent289110>
ditto.
- Gilbert Song
On July 12, 2018, 7:16 a.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
c/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45
Diff: https://reviews.apache.org/r/66820/diff/8/
Changes: https://reviews.apache.org/r/66820/diff/7-8/
Testing
---
Thanks,
Gilbert Song
301 - 400 of 2265 matches
Mail list logo
