Re: Review Request 46149: Speed up DynamicReservationFramework.

> On April 14, 2016, 7:56 p.m., Benjamin Bannier wrote: > > This is much better, but still long. I see that now most of the time is > > spent in `resourceOffers` -- can you think of a way to speed these up as > > well? > > Klaus Ma wrote: > @Bannier,

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/#review129476 --- Ship it! Ship It! - Klaus Ma On April 19, 2016, 11:28 a.m

Re: Review Request 44379: Use tokens size to parse perf stat format.

> On April 11, 2016, 10:09 p.m., Klaus Ma wrote: > > Ship It! > > Klaus Ma wrote: > LGTM. Just wonder how to handle the input that did not follow our > expectation: > > // value,event,cgroup > // value,unit,event,cgroup > /

Re: Review Request 46298: Rejected relative path agent work_dir.

isit: https://reviews.apache.org/r/46298/#review129313 ------- On April 16, 2016, 4:29 p.m., Klaus Ma wrote: > > --- > This is an automatically generate

Review Request 46298: Rejected relative path agent work_dir.

://reviews.apache.org/r/46298/diff/ Testing --- 1. make && make check 2. e2e test: ``` $ ./src/mesos-slave --work_dir=aa --master=aa The required option `--work_dir` must be absolute path. ``` Thanks, Klaus Ma

Re: Review Request 46149: Speed up DynamicReservationFramework.

> On April 14, 2016, 7:56 p.m., Benjamin Bannier wrote: > > This is much better, but still long. I see that now most of the time is > > spent in `resourceOffers` -- can you think of a way to speed these up as > > well? > > Klaus Ma wrote: > @Bannier,

Re: Review Request 46214: Valided role when framework subscribe.

src/tests/master_tests.cpp 1ae72600e26c5f31476f689cbb600d41d7cc9b74 src/tests/scheduler_http_api_tests.cpp d469adf7230ce5bb5e71a241a06e389295905e03 Diff: https://reviews.apache.org/r/46214/diff/ Testing --- make && make check Thanks, Klaus Ma

Review Request 46214: Valided role when framework subscribe.

/scheduler_http_api_tests.cpp d469adf7230ce5bb5e71a241a06e389295905e03 Diff: https://reviews.apache.org/r/46214/diff/ Testing --- make && make check Thanks, Klaus Ma

Re: Review Request 46149: Speed up DynamicReservationFramework.

rceOffers`? - Klaus --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46149/#review128877 --- On April 14, 2016, 8:59

Re: Review Request 46149: Speed up DynamicReservationFramework.

umeFramework (3379 ms) [ RUN ] ExamplesTest.DynamicReservationFramework [ OK ] ExamplesTest.DynamicReservationFramework (5127 ms) [--] 5 tests from ExamplesTest (20433 ms total) [--] Global test environment tear-down [==] 5 tests from 1 test case ran. (20443 ms total) [ PASSED ] 5 tests. Thanks, Klaus Ma

Review Request 46149: Speed up ExamplesTest.DynamicReservationFramework.

ExamplesTest (20433 ms total) [--] Global test environment tear-down [==] 5 tests from 1 test case ran. (20443 ms total) [ PASSED ] 5 tests. Thanks, Klaus Ma

Re: Review Request 46102: Fixed logic error in execute.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46102/#review128597 --- Ship it! Ship It! - Klaus Ma On April 13, 2016, 7:34 a.m

Re: Review Request 46023: Cleaned up dynamic reservation example framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46023/#review128120 --- Ship it! Ship It! - Klaus Ma On April 11, 2016, 10 p.m

Re: Review Request 44379: Use tokens size to parse perf stat format.

> On April 11, 2016, 10:09 p.m., Klaus Ma wrote: > > Ship It! LGTM. Just wonder how to handle the input that did not follow our expectation: // value,event,cgroup // value,unit,event,cgroup // value,unit,event,cgroup,running,ratio

Re: Review Request 44379: Use tokens size to parse perf stat format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44379/#review128117 --- Ship it! Ship It! - Klaus Ma On April 11, 2016, 3:01 p.m

Re: Review Request 37168: Add an example framework using dynamic reservation.

sting --- make make check Thanks, Klaus Ma

Re: Review Request 37168: Add an example framework using dynamic reservation.

make check Thanks, Klaus Ma

Re: Review Request 37168: Add an example framework using dynamic reservation.

eviews.apache.org/r/37168/#review127337 --- On April 6, 2016, 4:19 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 43561: Improve Ranges parsing to handle single values.

rn below. > > Joris Van Remoortere wrote: > There are a couple more of these that you missed. No need to update the > review again, i'll just re-open this and you can fix them after bmahler can > take a look. > > Klaus Ma wrote: > Updated patches for related c

Review Request 45813: Used object for return value.

Description --- Used object for return value. Diffs - src/common/values.cpp 9f3c0b9930bd3dd9d84d97119419825862f531c3 Diff: https://reviews.apache.org/r/45813/diff/ Testing --- make Thanks, Klaus Ma

Re: Review Request 37168: Add an example framework using dynamic reservation.

make check Thanks, Klaus Ma

Re: Review Request 37168: Add an example framework using dynamic reservation.

y generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review126769 ------- On April 5, 2016, 5:28 p.m., Klaus Ma wrote: > > --- > Th

Re: Review Request 37168: Add an example framework using dynamic reservation.

> On April 4, 2016, 9:40 a.m., Michael Park wrote: > > src/examples/dynamic_reservation_framework.cpp, line 308 > > <https://reviews.apache.org/r/37168/diff/15/?file=1309849#file1309849line308> > > > > `static const Resources TASK_RESOURCES;` > > Kla

Re: Review Request 37168: Add an example framework using dynamic reservation.

make check Thanks, Klaus Ma

Re: Review Request 37168: Add an example framework using dynamic reservation.

an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review126769 ------- On March 22, 2016, 11:44 a.m., Klaus Ma wrote: > > --- >

Re: Review Request 37168: Add an example framework using dynamic reservation.

27;s clear to me :). BTW, `rc` means `return code`. - Klaus --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review126769 --- On

Re: Review Request 37168: Add an example framework using dynamic reservation.

reply, visit: https://reviews.apache.org/r/37168/#review126769 ------- On March 22, 2016, 11:44 a.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 45707: Minor cleanups to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45707/#review127009 --- Ship it! Ship It! - Klaus Ma On April 5, 2016, 5:32 a.m

Re: Review Request 37168: Add an example framework using dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review125230 --- ping @mcypark, would you help to review it again? - Klaus Ma

Re: Review Request 45267: Fixed a memory leak in process::subprocess.

tps://reviews.apache.org/r/45267/#comment187990> Sugguest to add a NOTE that, the envp is environment->size() + 1, so the last NULL ptr is not handled (delete). - Klaus Ma On March 24, 2016, 11:41 a.m., Ben Mahler wrote: > > -

Re: Review Request 45267: Fixed a memory leak in process::subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45267/#review125200 --- Ship it! Ship It! - Klaus Ma On March 24, 2016, 11:41 a.m

Re: Review Request 43561: Improve Ranges parsing to handle single values.

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review124545 --- On March 22, 2016, 9:22 p.m., Klaus Ma wrote: > > -

Re: Review Request 43561: Improve Ranges parsing to handle single values.

---------- On March 22, 2016, 9:22 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43561/ >

Re: Review Request 43561: Improve Ranges parsing to handle single values.

GTEST_FILTER=~"*" ./src/mesos-test Thanks, Klaus Ma

Re: Review Request 43561: Improve Ranges parsing to handle single values.

ot; ./src/mesos-test Thanks, Klaus Ma

Re: Review Request 37168: Add an example framework using dynamic reservation.

make check Thanks, Klaus Ma

Re: Review Request 45081: Excluded reserved resources when got nonRevocable resources in stage 1.

ry to call `nonRevocable()` for reserved resources. Diffs - src/master/allocator/mesos/hierarchical.cpp 70291075c00a9a557529c2562dedcfc6c6c3ec32 Diff: https://reviews.apache.org/r/45081/diff/ Testing --- make make check Thanks, Klaus Ma

Review Request 45081: Excluded reserved resources when got nonRevocable resources in stage 1.

l.cpp 70291075c00a9a557529c2562dedcfc6c6c3ec32 Diff: https://reviews.apache.org/r/45081/diff/ Testing --- make make check Thanks, Klaus Ma

Re: Review Request 37168: Add an example framework using dynamic reservation.

VED state the > > first time? It seems to me we should have something here similar to what's > > in the switch for `State::UNRESERVING`, i.e., check the offer and see if > > the reserved resources are contained in it? The framework test passes for > > me thou

Re: Review Request 37168: Add an example framework using dynamic reservation.

-------- On March 16, 2016, 2:32 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37168/ > --

Re: Review Request 37168: Add an example framework using dynamic reservation.

/ Testing --- make make check Thanks, Klaus Ma

Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

tps://reviews.apache.org/r/44836/#comment186878> I think we need check `format()`'s result; if `tasksLaunched` is bigger than `99`, what's the behaviour? - Klaus Ma On March 16, 2016, 10:27 a.m., Jay Guo wrote: > > --

Re: Review Request 37168: Add an example framework using dynamic reservation.

make check Thanks, Klaus Ma

Re: Review Request 37168: Add an example framework using dynamic reservation.

Thanks, Klaus Ma

Re: Review Request 37168: Add an example framework using dynamic reservation.

----- On March 16, 2016, 2:27 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37168/ >

Re: Review Request 37168: Add an example framework using dynamic reservation.

make check Thanks, Klaus Ma

Re: Review Request 41334: Added helper functions to filter allocation slack resources.

tps://reviews.apache.org/r/41334/#comment186113> I think we should also update those helper fuction according to protobuf change, using `throttleable` instead of ALLOCATION_SLACK/USAGE_SLACK, e.g. `throttleable()`, `nonThrottleable()` and `revocable()`. - Klaus Ma On March 15, 2016, 10:33 p.m., Guang

Re: Review Request 41333: Added helper functions to filter usage slack resources.

tps://reviews.apache.org/r/41333/#comment186112> `isThrottleable`? - Klaus Ma On March 15, 2016, 10:33 p.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 42547: Added helper function to get non usage slack resources.

tps://reviews.apache.org/r/42547/#comment186110> should be `nonThrottleable`? - Klaus Ma On March 15, 2016, 10:32 p.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

/resources.cpp c6f125ec317e2da537a6456f5cff2da0a48701d8 Diff: https://reviews.apache.org/r/40375/diff/ Testing --- make && make check Thanks, Klaus Ma

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

6b004d64bb25112b19fc5d98b5bca874c5329e8c src/v1/resources.cpp c6f125ec317e2da537a6456f5cff2da0a48701d8 Diff: https://reviews.apache.org/r/40375/diff/ Testing --- make && make check Thanks, Klaus Ma

Re: Review Request 44360: Added a script to install the Nvidia GDK on a host.

> On March 6, 2016, 8:51 a.m., Klaus Ma wrote: > > support/install-nvidia-gdk.sh, lines 3-13 > > <https://reviews.apache.org/r/44360/diff/2/?file=1280297#file1280297line3> > > > > Are we going to provide documents about those vars? e.g. which version > &

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

src/tests/resources_tests.cpp 6b004d64bb25112b19fc5d98b5bca874c5329e8c src/v1/resources.cpp c6f125ec317e2da537a6456f5cff2da0a48701d8 Diff: https://reviews.apache.org/r/40375/diff/ Testing --- make && make check Thanks, Klaus Ma

Re: Review Request 42590: Renamed reserved() to reservations().

tps://reviews.apache.org/r/42590/#comment185472> I think we need to update document about the `Option role` - Klaus Ma On March 12, 2016, 10:47 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 42127: Did not rescind offer if only ALLOCATION_SLACK resources incuded.

) - src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc src/tests/oversubscription_tests.cpp e528476cd83b0e3f7ae8cea7d86dfabc1f66484e Diff: https://reviews.apache.org/r/42127/diff/ Testing --- make make check Thanks, Klaus Ma

Re: Review Request 41859: Launch tasks after evicting executors.

/ Testing --- Thanks, Klaus Ma

Re: Review Request 41858: Added helper functions to kill executor.

7520cc356e2b1b7f5fff15f33071a46a7b05e762 src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 Diff: https://reviews.apache.org/r/41858/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 41857: Got evictable executors.

7520cc356e2b1b7f5fff15f33071a46a7b05e762 src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 Diff: https://reviews.apache.org/r/41857/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 41856: Added helper functions to get allocation slack.

840534ff0687e82ed063c386e36bbabada230697 src/v1/resources.cpp 296c4c2392384a2fcc4f2c1843980ff97e71114d Diff: https://reviews.apache.org/r/41856/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 41855: Trace pending executors.

from pendingExecutor list. Diffs (updated) - src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762 src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 Diff: https://reviews.apache.org/r/41855/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 41850: Add map to trace evictable executors.

can be evicted. Diffs (updated) - src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762 src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 Diff: https://reviews.apache.org/r/41850/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 40379: MESOS-3930: Set resource type as USAGE_SLACK for Oversubscription.

840534ff0687e82ed063c386e36bbabada230697 Diff: https://reviews.apache.org/r/40379/diff/ Testing --- make (make check is on-going) Thanks, Klaus Ma

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

/resources.cpp 296c4c2392384a2fcc4f2c1843980ff97e71114d Diff: https://reviews.apache.org/r/40375/diff/ Testing --- make && make check Thanks, Klaus Ma

Re: Review Request 44570: Added an owner field to TaskInfo and ExecutorInfo.

org/r/44570/#comment185003> Also added in v1 APIs? src/master/validation.cpp (lines 381 - 382) <https://reviews.apache.org/r/44570/#comment185002> move `{` into one line. - Klaus Ma On March 9, 2016, 11:48 p.m., Jan Sc

Re: Review Request 37168: Add an example framework using dynamic reservation.

ws.apache.org/r/37168/#review120212 --- On March 7, 2016, 5:20 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews

Review Request 44433: Added empty line for list in maintenance doc.

--- Added empty line for list in maintenance doc. Diffs - docs/maintenance.md 365c920719dbd0c5e61efe1975547a2848647bce Diff: https://reviews.apache.org/r/44433/diff/ Testing --- Document update. Thanks, Klaus Ma

Re: Review Request 37168: Add an example framework using dynamic reservation.

s.cpp 6ddac17bb2ac0330bcc09eaab975ae70e84a7695 Diff: https://reviews.apache.org/r/37168/diff/ Testing --- make make check Thanks, Klaus Ma

Re: Review Request 43884: Added allocator metrics for used quotas.

tps://reviews.apache.org/r/43884/#comment184146> Add comments on keys, e.g. role : . - Klaus Ma On March 5, 2016, 12:01 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 44414: Added documentation about container image support.

md (lines 67 - 77) <https://reviews.apache.org/r/44414/#comment184131> +1 - Klaus Ma On March 5, 2016, 10:20 a.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/#review122218 --- Ship it! Ship It! - Klaus Ma On March 5, 2016, 12:17 p.m

Re: Review Request 44360: Added a script to install the Nvidia GDK on a host.

tps://reviews.apache.org/r/44360/#comment184127> Are we going to provide documents about those vars? e.g. which version are we going to support? - Klaus Ma On March 4, 2016, 9:21 a.m., Kevin Klues wrote: > > --- > This is an automati

Re: Review Request 44366: Added GPUs as an explicit resource.

> On March 4, 2016, 8:27 p.m., Klaus Ma wrote: > > src/slave/containerizer/containerizer.cpp, line 115 > > <https://reviews.apache.org/r/44366/diff/1/?file=1280284#file1280284line115> > > > > I'd like to say "`--navidia_gpus` must be set when s

Review Request 44396: Updated unavailable in batch to avoid several allocate(slaveId) call in "/maintenance/schedule".

://reviews.apache.org/r/44396/diff/ Testing --- make && make check at Mac OS Thanks, Klaus Ma

Re: Review Request 44366: Added GPUs as an explicit resource.

idia_gpus` must be set when specifying `gpu` resources." - Klaus Ma On March 4, 2016, 9:11 a.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 39939: Make docker_socket option support different protocols.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39939/#review122012 --- Ship it! Ship It! - Klaus Ma On March 4, 2016, 11:54 a.m

Re: Review Request 39939: Make docker_socket option support different protocols.

> On March 4, 2016, 11:02 a.m., Klaus Ma wrote: > > src/slave/containerizer/docker.cpp, lines 136-138 > > <https://reviews.apache.org/r/39939/diff/3/?file=1280373#file1280373line136> > > > > Two comments here: > > > > 1. Error messa

Re: Review Request 39939: Make docker_socket option support different protocols.

gt; Two comments here: 1. Error message; I'd like to say: "Failed to create docker container; only unix domain socket is supported for `docker_socket` when `docker_mesos_image` is enabled" 2. Can you also highlight this limitation/restriction to document/help - Kl

Re: Review Request 39939: Make docker_socket option support different protocols.

> On Feb. 22, 2016, 12:41 p.m., Klaus Ma wrote: > > src/slave/flags.cpp, line 437 > > <https://reviews.apache.org/r/39939/diff/1/?file=1115726#file1115726line437> > > > > I think we need to handle feature interaction with > > `docker_mesos_image

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

> On March 2, 2016, 10:43 p.m., Klaus Ma wrote: > > src/master/http.cpp, lines 1999-2000 > > <https://reviews.apache.org/r/44258/diff/1/?file=1276346#file1276346line1999> > > > > I think we can just remove `master->updateUnavailability(id, > > upda

Review Request 44313: Described "/maintanence/schedule" GET/POST in the two paragraph.

/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

nd remove the // unavailability. master->machines[id].info.set_mode(MachineInfo::UP); master->updateUnavailability(id, None()); } ``` - Klaus Ma On March 2, 2016, 3:45 p.m., Guangya Liu wrote: > > --

Re: Review Request 44254: Add curl_easy_cleanup when fopen is failed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44254/#review121595 --- Ship it! Ship It! - Klaus Ma On March 2, 2016, 2:21 p.m

Re: Review Request 44254: Add curl_easy_cleanup when fopen is failed.

159) <https://reviews.apache.org/r/44254/#comment183322> also close fd (`os::close(fd.get())`) - Klaus Ma On March 2, 2016, 11:45 a.m., Andy Pang wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 44236: Update slave's version after re-registering.

01:5051", "registered_time": 1456874482.32198, "reregistered_time": 1456874497.25686, "reserved_resources": {}, "reserved_resources_full": {}, "resources": { "cpus": 8.0, "disk": 470832.0, "mem": 15360.0, "ports": "[31000-32000]" }, "unreserved_resources": { "cpus": 8.0, "disk": 470832.0, "mem": 15360.0, "ports": "[31000-32000]" }, "used_resources": { "cpus": 0.0, "disk": 0.0, "mem": 0.0 }, "used_resources_full": [], "version": "0.27.0" } ] } ``` Thanks, Klaus Ma

Review Request 44236: Update slave's version after re-registering.

ces": {}, "reserved_resources_full": {}, "resources": { "cpus": 8.0, "disk": 470832.0, "mem": 15360.0, "ports": "[31000-32000]" }, "unreserved_resources": { "cpus": 8.0, "disk": 470832.0, "mem": 15360.0, "ports": "[31000-32000]" }, "used_resources": { "cpus": 0.0, "disk": 0.0, "mem": 0.0 }, "used_resources_full": [], "version": "0.27.0" } ] } ``` Thanks, Klaus Ma

Re: Review Request 43561: Improve Ranges parsing to handle single values.

/resources_tests.cpp a545100522bf4b1f03e50656d461b3cda6b41e11 src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 Diff: https://reviews.apache.org/r/43561/diff/ Testing --- make make check GTEST_FILTER=~"*" ./src/mesos-test Thanks, Klaus Ma

Re: Review Request 44110: Updated flag examples to refer to /role instead of stats.json.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44110/#review121151 --- Ship it! Ship It! - Klaus Ma On Feb. 27, 2016, 8:55 a.m

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On Feb. 26, 2016, 12:30 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 376 > > <https://reviews.apache.org/r/43881/diff/7/?file=1270846#file1270846line376> > > > > We also need to remove counter in `removeFramework`; or

Re: Review Request 43884: Added allocator metrics for used quotas.

tps://reviews.apache.org/r/43884/#comment182802> Remove it when removeQuota. src/master/allocator/mesos/hierarchical.cpp (line 1108) <https://reviews.apache.org/r/43884/#comment182803> This's not necessary; all resources in quotaSorter are `nonRevocable()`. - Klaus Ma On

Re: Review Request 43883: Added allocator metrics for number of offer filters per framework.

tps://reviews.apache.org/r/43883/#comment182801> Should we remove this `Gauge` when remove framework? - Klaus Ma On Feb. 27, 2016, 1:01 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

g/r/44047/#comment182798> s/slave/agent/ src/master/http.cpp (line 1047) <https://reviews.apache.org/r/44047/#comment182799> `` for /unreserve and /destroy-volumes. - Klaus Ma On Feb. 28, 2016, 8:17 a.m., Neil

Re: Review Request 44063: Waited for status update to happen before proceeding in test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44063/#review121143 --- Ship it! Ship It! - Klaus Ma On Feb. 28, 2016, 6:27 p.m

Re: Review Request 43718: Added fs::supported() function.

> On Feb. 28, 2016, 9:16 p.m., Guangya Liu wrote: > > src/linux/fs.cpp, line 60 > > > > > > I think that should `continue` here, if one line failed, other lines > > should still be tried to see if the fs is supportte

Re: Review Request 43718: Added fs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review121140 --- Ship it! Ship It! - Klaus Ma On Feb. 28, 2016, 9:08 p.m

Re: Review Request 43882: Added allocation metrics for allocation time.

tps://reviews.apache.org/r/43882/#comment182184> It seems a general functional class, can we move it into `process/metrics`? - Klaus Ma On Feb. 25, 2016, 7:37 p.m., Benjamin Bannier wrote: > > --- > This is an automatica

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

;https://reviews.apache.org/r/43881/#comment182182> ditto - Klaus Ma On Feb. 25, 2016, 7:37 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

eviews.apache.org/r/43880/#comment181980> Can we move the comments above the code and move `getMetric()` into one line? - Klaus Ma On Feb. 24, 2016, 6:58 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e

Re: Review Request 43879: Added allocator metrics for number of allocations made.

tps://reviews.apache.org/r/43879/#comment181976> Why a anonymous namespace? `static` should be fine. src/tests/hierarchical_allocator_tests.cpp (line 2395) <https://reviews.apache.org/r/43879/#comment181975> What are you going to do for this comments? or just a notes? - Klaus

Re: Review Request 43864: Fix typo of roles doc.

.org/r/43864/#review120347 --- On Feb. 24, 2016, 11:34 a.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: Review Request 43864: Fix typo of roles doc.

/http.cpp 939fab21a2240de7214ef809a194ffb3837a9f1b Diff: https://reviews.apache.org/r/43864/diff/ Testing --- Thanks, Klaus Ma

<    1   2   3   4   5   6   7   >