Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/ --- (Updated Nov. 22, 2015, 11:55 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/#review107525 --- Bad patch! Reviews applied: [39401] Failed command:

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 1:49 p.m., Qian Zhang wrote: > > For this patch, it seems that we add the code related to quota support in > > the slave foreach loop in the HierarchicalAllocatorProcess::allocate(const > > hashset& slaveIds_) method, so that means for **each slave**, we > > handle quota

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Nov. 1, 2015, 8:14 p.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1005 > > > > > > For this TODO, what do we plan to do in future? Include the dynamic > > reserved resources for

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/#review105865 --- src/master/allocator/mesos/hierarchical.cpp (line 984)

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 8:27 a.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1055-1057 > > > > > > Since we know the guarentee of each quota'ed role and the gap between > > it and role's

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 25, 2015, 1:39 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1035 > > > > > > I know that we have design to exclue the reserved resource from quota, > > but why not

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/ --- (Updated Nov. 9, 2015, 10:15 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 10:07 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1004 > > > > > > Just check the code, dynamically reserved resource are included in > > allocation. > > Qian

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Nov. 1, 2015, 8:14 p.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1005 > > > > > > For this TODO, what do we plan to do in future? Include the dynamic > > reserved resources for

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 25, 2015, 1:39 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1035 > > > > > > I know that we have design to exclue the reserved resource from quota, > > but why not

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Nov. 1, 2015, 12:14 p.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1005 > > > > > > For this TODO, what do we plan to do in future? Include the dynamic > > reserved resources

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 25, 2015, 1:39 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1035 > > > > > > I know that we have design to exclue the reserved resource from quota, > > but why not

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/#review104656 --- src/master/allocator/mesos/hierarchical.cpp (line 1005)

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On 十月 25, 2015, 1:39 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1035 > > > > > > I know that we have design to exclue the reserved resource from quota, > > but why not include

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 8:27 a.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1017-1020 > > > > > > Why do we put these code inside the framework sorters foreach loop? I > > do not see it

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/ --- (Updated Oct. 29, 2015, 7:29 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 1:49 p.m., Qian Zhang wrote: > > For this patch, it seems that we add the code related to quota support in > > the slave foreach loop in the HierarchicalAllocatorProcess::allocate(const > > hashset& slaveIds_) method, so that means for **each slave**, we > > handle quota

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 4:27 p.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1017-1020 > > > > > > Why do we put these code inside the framework sorters foreach loop? I > > do not see it

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 10:07 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1004 > > > > > > Just check the code, dynamically reserved resource are included in > > allocation. Really?:-)

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 9:49 p.m., Qian Zhang wrote: > > For this patch, it seems that we add the code related to quota support in > > the slave foreach loop in the HierarchicalAllocatorProcess::allocate(const > > hashset& slaveIds_) method, so that means for **each slave**, we > > handle quota

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/ --- (Updated Oct. 27, 2015, 7:27 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 1:49 p.m., Qian Zhang wrote: > > For this patch, it seems that we add the code related to quota support in > > the slave foreach loop in the HierarchicalAllocatorProcess::allocate(const > > hashset& slaveIds_) method, so that means for **each slave**, we > > handle quota

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 2:07 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1004 > > > > > > Just check the code, dynamically reserved resource are included in > > allocation. > > Qian

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/#review103958 --- src/master/allocator/mesos/hierarchical.cpp (line 996)

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/#review104013 --- src/master/allocator/mesos/hierarchical.cpp (line 1004)

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/#review104012 --- For this patch, it seems that we add the code related to quota

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/#review104006 --- src/master/allocator/mesos/hierarchical.cpp (line 1156)

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/#review103983 --- src/master/allocator/mesos/hierarchical.cpp (line 1018)

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/#review104010 --- src/master/allocator/mesos/hierarchical.cpp (line 998)

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 1:51 p.m., Artem Harutyunyan wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1044-1046 > > > > > > s/the/that/ > > > > Seems like a copy of the comment above, is this

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 8:27 a.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 996 > > > > > > These newly added code makes allocate() a huge method (more than 200 > > lines), maybe move

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 2 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1018 > > > > > > Can we move this out of the for loop? if the role is satisfied, > > framewor sort is not

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 1:13 p.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1156 > > > > > > I think we need to check if this is a quota'ed role first. Correct, thanks! - Alexander

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 26, 2015, 1:49 p.m., Qian Zhang wrote: > > For this patch, it seems that we add the code related to quota support in > > the slave foreach loop in the HierarchicalAllocatorProcess::allocate(const > > hashset& slaveIds_) method, so that means for **each slave**, we > > handle quota

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

> On Oct. 25, 2015, 1:39 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 982 > > > > > > s/unsatisfiedRoleQuotas/unAllocatedRoleQuotas? Dynamic reservations may not be allocated, but

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/#review103954 --- src/master/allocator/mesos/hierarchical.cpp (line 982)

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/ --- (Updated Oct. 23, 2015, 4:38 p.m.) Review request for mesos, Bernd Mathiske,