---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35863/#review89328
---
Ship it!
Ship It!
- Till Toenshoff
On June 25, 2015, 5:47 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35863/#review89326
---
Patch looks great!
Reviews applied: [35863]
All tests passed.
-
On June 25, 2015, 12:38 a.m., Vinod Kone wrote:
src/tests/master_contender_detector_tests.cpp, line 877
https://reviews.apache.org/r/35815/diff/3/?file=991386#file991386line877
s/EXPECT/ASSERT/
as this is the last expectation in the test.
LoL - I was doing some
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35841/#review89415
---
Ship it!
Ship It!
- Vinod Kone
On June 25, 2015, 5:27 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35841/#review89416
---
Ship it!
Thank you Paul, Mpark for cleaning this up. This
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/
---
(Updated June 26, 2015, 4:44 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/#review89471
---
Patch looks great!
Reviews applied: [35714, 35702]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34835/#review89338
---
Ship it!
Ship It!
- Bernd Mathiske
On June 24, 2015, 2:14 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35874/
---
Review request for mesos, Bernd Mathiske, Joerg Schad, Michael Park, and Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35714/#review89339
---
Ship it!
Ship It!
- Alexander Rojas
On June 22, 2015, 7:08
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34135/#review84775
---
I wish you could have split the patch. I think the Posix filesystem
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35861/#review89417
---
LGTM. Looks like you made the distinction between 3rd party headers
On June 20, 2015, 9:45 p.m., Mesos ReviewBot wrote:
Bad patch!
Reviews applied: [35285, 35286, 35287]
Failed command: ./support/apply-review.sh -n -r 35287
Error:
2015-06-20 21:41:02 URL:https://reviews.apache.org/r/35287/diff/raw/
[2559/2559] - 35287.patch [1]
error:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32750/#review89345
---
So I had a look into it. So the project built on an old Bootstrap
On June 25, 2015, 2:54 p.m., Benjamin Hindman wrote:
docs/mesos-doxygen-style-guide.md, line 20
https://reviews.apache.org/r/35843/diff/1/?file=991532#file991532line20
Seems like most of the examples in this file should still be ~~~{.cpp}?
I'll fix before commit.
Actually not.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35874/#review89349
---
Patch looks great!
Reviews applied: [35874]
All tests passed.
-
On June 25, 2015, 2:02 p.m., Michael Lunøe wrote:
So I had a look into it. So the project built on an old Bootstrap CSS file.
The solution to our problem will be solved by updating the Bootstrap CSS
file with a new build, as container-fluid was introduced later in
Bootstrap. I
On June 25, 2015, 2:54 p.m., Benjamin Hindman wrote:
docs/allocation-module.md, line 37
https://reviews.apache.org/r/35843/diff/1/?file=991528#file991528line37
These ones don't need to be indented, but I'll take care of this for
you when I commit.
oops, I missed this one.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35843/#review89311
---
Ship it!
docs/allocation-module.md (line 37)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35874/#review89381
---
s/reflex/reflects
- Joerg Schad
On June 25, 2015, 1:45 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35858/#review89384
---
src/scheduler/scheduler.cpp (line 306)
On June 25, 2015, 8:10 a.m., Marco Massenzio wrote:
Hey Paul, thanks for doing this!
In case you are interested, I have submitted a couple of Pull Requests to
the Google folks (without much success) but I've also
[forked](https://github.com/massenz/styleguide) `styleguide` and have
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35858/#review89369
---
Ship it!
I would like, if possible, to see some documentation
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35611/#review89362
---
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35858/#review89371
---
Ship it!
src/master/master.cpp (line 3139)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35836/#review89385
---
Ship it!
src/master/allocator/mesos/hierarchical.hpp (line 233)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35841/
---
(Updated June 25, 2015, 5:27 p.m.)
Review request for mesos, Benjamin Hindman,
On June 25, 2015, 5:20 p.m., Vinod Kone wrote:
src/master/allocator/mesos/hierarchical.hpp, line 233
https://reviews.apache.org/r/35836/diff/2/?file=991617#file991617line233
For posterity, can you add a comment here on why we store allocated
in the allocator despite having that
On June 25, 2015, 1:08 a.m., Ben Mahler wrote:
src/master/allocator/mesos/hierarchical.hpp, line 768
https://reviews.apache.org/r/35836/diff/2/?file=991617#file991617line768
Hm.. can you keep the available? I think we wanted this log line to
help us know what will be offered
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35861/#review89412
---
Patch looks great!
Reviews applied: [35861]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35857/#review89401
---
src/master/master.hpp (line 1036)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35861/
---
(Updated June 25, 2015, 6:32 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35841/#review89396
---
Patch looks great!
Reviews applied: [35841]
All tests passed.
-
On June 20, 2015, 9:45 p.m., Mesos ReviewBot wrote:
Bad patch!
Reviews applied: [35285, 35286, 35287]
Failed command: ./support/apply-review.sh -n -r 35287
Error:
2015-06-20 21:41:02 URL:https://reviews.apache.org/r/35287/diff/raw/
[2559/2559] - 35287.patch [1]
error:
On June 25, 2015, 8:10 a.m., Marco Massenzio wrote:
Hey Paul, thanks for doing this!
In case you are interested, I have submitted a couple of Pull Requests to
the Google folks (without much success) but I've also
[forked](https://github.com/massenz/styleguide) `styleguide` and have
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35861/
---
(Updated June 25, 2015, 9:58 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35856/#review89436
---
Ship it!
src/tests/scheduler_tests.cpp (line 736)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35861/#review89441
---
The ordering parts looks good. Should we also fix the
On June 25, 2015, 8:42 p.m., Vinod Kone wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp, line 20
https://reviews.apache.org/r/35861/diff/3/?file=992264#file992264line20
get rid of this?
Longer term, I'm looking at a program that uses clang to identify files that
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34136/#review89438
---
include/mesos/mesos.proto (line 1196)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35861/
---
(Updated June 25, 2015, 9:35 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35721/#review89430
---
src/messages/messages.proto (line 336)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35861/#review89440
---
Patch looks great!
Reviews applied: [35861]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35908/
---
Review request for mesos and Benjamin Hindman.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35853/
---
(Updated June 26, 2015, 3:55 a.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35908/#review89468
---
Ship it!
Ship It!
- Benjamin Hindman
On June 26, 2015, 3:55
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35852/
---
(Updated June 26, 2015, 3:55 a.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35854/
---
(Updated June 26, 2015, 3:55 a.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35854/#review89470
---
Ship it!
Ship It!
- Benjamin Hindman
On June 26, 2015, 3:55
On June 24, 2015, 3:24 a.m., Adam B wrote:
src/common/http.cpp, line 84
https://reviews.apache.org/r/35717/diff/4/?file=989671#file989671line84
I wonder if you could templatize this to work for modeling any
hashmapstring, T, where T is an already modeled type.
I'm not sure what
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35717/#review89456
---
Ship it!
Ship It!
- Adam B
On June 22, 2015, 4:37 a.m.,
On June 25, 2015, 12:38 a.m., Vinod Kone wrote:
src/tests/master_contender_detector_tests.cpp, line 877
https://reviews.apache.org/r/35815/diff/3/?file=991386#file991386line877
s/EXPECT/ASSERT/
as this is the last expectation in the test.
Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35861/#review89330
---
Hey Paul, thanks for doing this!
In case you are interested, I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35855/#review89331
---
Ship it!
src/master/master.cpp (line 2826)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35815/#review89332
---
Patch looks great!
Reviews applied: [35815]
All tests passed.
-
55 matches
Mail list logo
