Re: Review Request 38693: Added MESOS_SANDBOX environment variable in Mesos containerizer.

> On Sept. 23, 2015, 10:14 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 767 > > > > > > I think we should consolidate it, but we need to allow it to be passed > > in I think as

Re: Review Request 38575: Added masterSlaveLostHook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38575/ --- (Updated Sept. 23, 2015, 3:24 p.m.) Review request for mesos, Joris Van Remoort

Re: Review Request 38654: Added digest verifier for image blobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38654/ --- (Updated Sept. 23, 2015, 10:27 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 38575: Added masterSlaveLostHook

> On Sept. 21, 2015, 4:58 p.m., Guangya Liu wrote: > > include/mesos/hook.hpp, line 66 > > > > > > Do we need to update slave to agent in other comments introduced by > > this patch? All code references are now mark

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/#review100306 --- src/slave/containerizer/linux_launcher.cpp (line 133)

Re: Review Request 38575: Added masterSlaveLostHook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38575/#review100308 --- Ship it! Ship It! - Joris Van Remoortere On Sept. 23, 2015, 10:

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

> On Sept. 23, 2015, 8:46 a.m., Timothy Chen wrote: > > src/linux/systemd.cpp, line 54 > > > > > > Just tried to run this in CentOS 7 and I couldn't find /bin/systemd, > > but systemd is running. > > Niklas Nielsen

Re: Review Request 38137: Added Docker provisioner, store and local puller

> On Sept. 23, 2015, 7:45 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/provisioner/docker/metadata_manager.hpp, line 57 > > > > > > With the pullers refactored out of the store I don't see the need for a >

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38634/#review100310 --- Ship it! Ship It! src/linux/systemd.cpp (line 86)

Re: Review Request 38660: Restore Linux/Posix launcher creation logic for MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38660/ --- (Updated Sept. 23, 2015, 6:44 p.m.) Review request for mesos, haosdent huang an

Review Request 38697: Updated documentation strings for --launcher flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38697/ --- Review request for mesos and Jie Yu. Bugs: MESOS-3451 https://issues.apache

Re: Review Request 38660: Restore Linux/Posix launcher creation logic for MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38660/#review100311 --- Ship it! Ship It! - Timothy Chen On Sept. 23, 2015, 10:44 p.m.,

Re: Review Request 38660: Restore Linux/Posix launcher creation logic for MesosContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38660/#review100312 --- This can also fix Artem's failing CI with Docker too. - Timothy Ch

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38634/ --- (Updated Sept. 23, 2015, 10:59 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 38654: Added digest verifier for image blobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38654/#review100315 --- Patch looks great! Reviews applied: [38443, 38579, 38580, 38654]

Re: Review Request 38473: Add flag to disable hostname lookup.

> On Sept. 23, 2015, 10:01 p.m., Benjamin Hindman wrote: > > src/tests/master_tests.cpp, line 1127 > > > > > > I'm not sure what this tests for and if it doesn't actually introduce a > > potential source of flakine

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

> On Sept. 23, 2015, 10:31 p.m., Kapil Arya wrote: > > src/slave/containerizer/linux_launcher.cpp, line 133 > > > > > > Do we want to ABORT, or return an Error here (and below)? Not sure, if > > we have a policy tha

Re: Review Request 38473: Add flag to disable hostname lookup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38473/ --- (Updated Sept. 23, 2015, 11:10 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 38693: Added MESOS_SANDBOX environment variable in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38693/#review100319 --- Ship it! src/tests/containerizer/filesystem_isolator_tests.cpp (l

Re: Review Request 38693: Added MESOS_SANDBOX environment variable in Mesos containerizer.

> On Sept. 23, 2015, 3:14 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 767 > > > > > > I think we should consolidate it, but we need to allow it to be passed > > in I think as

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/#review100317 --- src/linux/systemd.hpp (line 34)

Re: Review Request 38637: Added recovery warnings for LinuxLauncher on Systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38637/#review100321 --- src/slave/containerizer/linux_launcher.cpp (lines 187 - 188)

Re: Review Request 38137: Added Docker provisioner, store and local puller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review100285 --- src/slave/containerizer/provisioner/docker/store.cpp (lines 210 -

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

> On Sept. 23, 2015, 10:31 p.m., Kapil Arya wrote: > > src/slave/containerizer/linux_launcher.cpp, line 133 > > > > > > Do we want to ABORT, or return an Error here (and below)? Not sure, if > > we have a policy tha

Re: Review Request 38693: Added MESOS_SANDBOX environment variable in Mesos containerizer.

> On Sept. 23, 2015, 10:14 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 767 > > > > > > I think we should consolidate it, but we need to allow it to be passed > > in I think as

Re: Review Request 38693: Added MESOS_SANDBOX environment variable in Mesos containerizer.

> On Sept. 23, 2015, 11:50 p.m., Jiang Yan Xu wrote: > > src/tests/containerizer/filesystem_isolator_tests.cpp, lines 872-873 > > > > > > I think this works too: > > > > ``` > > if [[ \"$MESOS_DIRECTORY\

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/ --- (Updated Sept. 24, 2015, 12:12 a.m.) Review request for mesos, Benjamin Hindman

Review Request 38699: stout: use os::close everywhere.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38699/ --- Review request for mesos and Vinod Kone. Bugs: mesos-2768 https://issues.ap

Review Request 38700: libprocess: use os::close everywhere.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38700/ --- Review request for mesos and Vinod Kone. Bugs: mesos-2768 https://issues.ap

Re: Review Request 38693: Added MESOS_SANDBOX environment variable in Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38693/#review100328 --- Patch looks great! Reviews applied: [38693] All tests passed. -

Review Request 38701: Use os::close everywhere.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38701/ --- Review request for mesos and Vinod Kone. Bugs: mesos-2768 https://issues.ap

Re: Review Request 38699: stout: use os::close everywhere.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38699/#review100329 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp

Re: Review Request 38697: Updated documentation strings for --launcher flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38697/#review100331 --- Bad patch! Reviews applied: [38660] Failed command: ./support/app

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38634/#review100330 --- Ship it! src/linux/systemd.cpp (line 59)

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/#review100332 --- Ship it! src/linux/systemd.hpp (lines 32 - 33)

Re: Review Request 38636: Assign executors to `mesos_executor.slice` in LinuxLauncher on Systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38636/#review100334 --- Ship it! src/slave/containerizer/linux_launcher.cpp (line 349)

Re: Review Request 38637: Added recovery warnings for LinuxLauncher on Systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38637/#review100335 --- Ship it! Agree with Jie on returning 'Failure' instead of 'EXIT'.

Re: Review Request 38137: Added Docker provisioner, store and local puller

> On Sept. 23, 2015, 7:45 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/provisioner/docker/store.cpp, line 191 > > > > > > How large could this folder potentially be? To remove large directories > > I think

Re: Review Request 38137: Added Docker provisioner, store and local puller

> On Sept. 23, 2015, 7:50 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/provisioner/docker/puller.hpp, line 60 > > > > > > If we use LinkedHashMap we don't need to create another struct right? True, but I ac

Re: Review Request 38137: Added Docker provisioner, store and local puller

> On Sept. 23, 2015, 5:34 p.m., Jojy Varghese wrote: > > src/slave/containerizer/provisioner/docker/puller.hpp, line 40 > > > > > > Shouldnt this be LayerInfo? I don't think we need to call it Info as it only holds

Re: Review Request 38473: Add flag to disable hostname lookup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38473/#review100340 --- Patch looks great! Reviews applied: [38473] All tests passed. -

Re: Review Request 38697: Updated documentation strings for --launcher flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38697/ --- (Updated Sept. 23, 2015, 9:50 p.m.) Review request for mesos, Jie Yu and Niklas

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/ --- (Updated Sept. 24, 2015, 1:52 a.m.) Review request for mesos, haosdent huang, M

Re: Review Request 38660: Restore Linux/Posix launcher creation logic for MesosContainerizer.

> On Sept. 23, 2015, 6:15 p.m., Cong Wang wrote: > > src/slave/flags.cpp, line 62 > > > > > > Document it in docs/configuration.md too? Created a new RR: https://reviews.apache.org/r/38697/ - Kapil --

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/ --- (Updated Sept. 24, 2015, 1:55 a.m.) Review request for mesos, haosdent huang, M

Re: Review Request 38697: Updated documentation strings for --launcher flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38697/#review100343 --- Ship it! Ship It! - Cong Wang On Sept. 24, 2015, 1:50 a.m., Kap

Re: Review Request 38699: stout: use os::close everywhere.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38699/#review100344 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp

Re: Review Request 38452: Updated C++ style guide for namespace usage

> On 九月 23, 2015, 5:47 p.m., Ben Mahler wrote: > > It seems good to qualify how we're different from the google style guide > > here. It seems the main difference is that we avoid the using statements > > inside functions / classes for the most part. > > > > Also not your fault but we're talki

Re: Review Request 38452: Updated C++ style guide for namespace usage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38452/ --- (Updated 九月 24, 2015, 2:20 a.m.) Review request for mesos and Ben Mahler. Bug

Re: Review Request 38697: Updated documentation strings for --launcher flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38697/#review100350 --- Ship it! Ship It! - Guangya Liu On 九月 24, 2015, 1:50 a.m., Kapi

Re: Review Request 38603: Refactored http::internal::Request to take a Request object.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38603/#review100351 --- Ship it! Ship It! - Vinod Kone On Sept. 22, 2015, 6:18 a.m., Be

Re: Review Request 38604: Re-enabled decoder test for case insensitive headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38604/#review100352 --- Ship it! Ship It! - Vinod Kone On Sept. 22, 2015, 6:18 a.m., Be

Re: Review Request 38605: Improved streaming decoder tests by checking the failed state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38605/#review100353 --- Ship it! Ship It! - Vinod Kone On Sept. 22, 2015, 6:18 a.m., Be

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38454/#review100354 --- Patch looks great! Reviews applied: [38454] All tests passed. -

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38287/ --- (Updated Sept. 24, 2015, 3:15 a.m.) Review request for mesos, Ian Downes, Jie Y

Re: Review Request 38634: Added Systemd environment check to LinuxLauncher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38634/ --- (Updated Sept. 24, 2015, 3:39 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/ --- (Updated Sept. 24, 2015, 3:41 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38635: Create and Start `mesos_executor.slice` in LinuxLauncher on Systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/ --- (Updated Sept. 24, 2015, 3:52 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38636: Assign executors to `mesos_executor.slice` in LinuxLauncher on Systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38636/ --- (Updated Sept. 24, 2015, 3:53 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38637: Added recovery warnings for LinuxLauncher on Systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38637/ --- (Updated Sept. 24, 2015, 3:53 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38637: Added recovery warnings for LinuxLauncher on Systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38637/ --- (Updated Sept. 24, 2015, 4 a.m.) Review request for mesos, Benjamin Hindman, Ar

Review Request 38705: Added support for applying a review chain (apply-reviews.py).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/ --- Review request for mesos, Joris Van Remoortere, Joseph Wu, and Vinod Kone. Bugs

Re: Review Request 38697: Updated documentation strings for --launcher flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38697/#review100359 --- Bad patch! Reviews applied: [38660] Failed command: ./support/app

Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38287/#review100364 --- Patch looks great! Reviews applied: [38287] All tests passed. -

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review100375 --- Patch looks great! Reviews applied: [38705] All tests passed. -

Re: Review Request 38637: Added recovery warnings for LinuxLauncher on Systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38637/#review100376 --- src/slave/containerizer/linux_launcher.cpp (line 246)

Re: Review Request 38697: Updated documentation strings for --launcher flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38697/ --- (Updated Sept. 24, 2015, 2:44 a.m.) Review request for mesos, Jie Yu and Niklas

Re: Review Request 38697: Updated documentation strings for --launcher flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38697/ --- (Updated Sept. 24, 2015, 2:44 a.m.) Review request for mesos, Jie Yu and Niklas

Re: Review Request 38137: Added Docker provisioner, store and local puller

> On Sept. 23, 2015, 5:34 p.m., Jojy Varghese wrote: > > src/slave/containerizer/provisioner/docker/puller.hpp, line 60 > > > > > > I think timeout should be part of the interface. remote puller > > especially shoul

<    1   2