Re: Review Request 39088: Made shell test locale-independent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39088/#review102220 --- Ship it! Ship It! - Alexander Rojas On Oct. 8, 2015, 3:27

Review Request 39219: Windows: Added support for `slave/state.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39219/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 39217: Windows: Added `stout/os/chsize.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39217/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 39220: CMake: Added `slave/state.cpp` to Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39220/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 39213: Windows: Moved `bootId` to is own file, `stout/os/windows/bootid.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39213/ --- (Updated Oct. 12, 2015, 6:16 a.m.) Review request for mesos, Artem

Re: Review Request 39008: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39008/ --- (Updated Oct. 12, 2015, 7:09 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 38977: Add reason for declineOffer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38977/ --- (Updated 十月 12, 2015, 7:46 a.m.) Review request for mesos, BenjaminVW

Review Request 39218: Windows: Added support for `process/address.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39218/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 39220: CMake: Added `slave/state.cpp` to Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39220/#review102219 --- Patch looks great! Reviews applied: [39019, 39076, 39091, 39092,

Re: Review Request 39216: Rename http_api_tests.cpp to scheduler_http_api_tests.cpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39216/#review102211 --- Patch looks great! Reviews applied: [39216] All tests passed. -

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review102203 --- include/mesos/resources.hpp (line 312)

Re: Review Request 37996: Added InheritanceTree a tree based container where children nodes inherit the values associated with their parent.

> On Oct. 6, 2015, 2:39 p.m., Bernd Mathiske wrote: > > Ship It! > > Ben Mahler wrote: > I don't think we should introduce this into stout in its current form. I > realize you're planning to use this for authentication stuff, but looking at > this on its own, it seems like a confusing

Re: Review Request 39088: Made shell test locale-independent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39088/#review102231 --- Ship it! Ship It! - haosdent huang On Oct. 8, 2015, 1:27 p.m.,

Re: Review Request 39135: Fixed teardown test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39135/#review102229 --- Ship it! Ship It! - Guangya Liu On 十月 8, 2015, 6:25 p.m.,

Re: Review Request 38977: Add reason for declineOffer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38977/#review102234 --- Patch looks great! Reviews applied: [38977] All tests passed. -

Re: Review Request 39205: Deprecate resource_monitoring_interval flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39205/#review102230 --- Ship it! Ship It! - haosdent huang On Oct. 12, 2015, 3:32

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

> On Oct. 10, 2015, 12:10 p.m., Alex Clemmer wrote: > > src/Makefile.am, line 463 > > > > > > (I hesistate to comment this time, but...) could we add this to the > > `CMakeLists.txt` file in `src/`? (It looks to be

Re: Review Request 39099: Changed secret field in Credential from 'bytes' to 'string' for V1

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39099/#review102225 --- This one need a rebase - Guangya Liu On 十月 7, 2015, 7:10 p.m.,

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/ --- (Updated Oct. 12, 2015, 11:30 a.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/#review102237 --- Ship it! Ship It! - Guangya Liu On 十月 2, 2015, 8:11 p.m.,

Re: Review Request 39008: Used thread-safe replacement for strerror.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39008/#review102224 --- Patch looks great! Reviews applied: [39005, 39008] All tests

Re: Review Request 39100: Changed Credential validation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39100/#review102226 --- Ship it! Ship It! - Guangya Liu On 十月 8, 2015, 6:26 p.m.,

Re: Review Request 37813: Added additional diagnostic output when a fetcher cache test fails.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37813/ --- (Updated Oct. 12, 2015, 9:25 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

> On Sept. 29, 2015, 10:43 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, lines 773-774 > > > > > > Could you please help me understand why this check is

Re: Review Request 37336: Simplified the caller interface to process::Subprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/#review102243 --- 3rdparty/libprocess/include/process/subprocess.hpp (line 68)

Re: Review Request 39135: Fixed teardown test

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39135/#review102267 --- Ship it! Ship It! - Michael Park On Oct. 8, 2015, 6:25 p.m.,

Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/#review102238 --- include/mesos/authentication/http/basic_authenticator_factory.hpp

Review Request 39230: Added check for SASL deprecation into configuration phase.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39230/ --- Review request for mesos and switched to 'mcypark'. Bugs: MESOS-3030

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38627/#review102245 --- Would it be possible to add a few unit tests, also to show usage

Re: Review Request 39230: Added check for SASL deprecation into configuration phase.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39230/#review102251 --- Patch looks great! Reviews applied: [39230] All tests passed. -

Re: Review Request 39223: WIP Added Quota related Tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Oct. 12, 2015, 4:57 p.m.) Review request for mesos, Alexander

Re: Review Request 37813: Added additional diagnostic output when a fetcher cache test fails.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37813/#review102278 --- Patch looks great! Reviews applied: [37813] All tests passed. -

Re: Review Request 39019: [WORK IN PROGRESS, NOT IMMEDIATELY NECESSARY] Windows: Added dirent compat code for non-Unix systems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/ --- (Updated Oct. 12, 2015, 5:44 p.m.) Review request for mesos, Artem

Re: Review Request 39211: Check for trailing characters in JSON::parse().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39211/#review102283 --- Ship it!

Re: Review Request 39076: CMake: Added ability of Windows builds to include protobuf headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39076/ --- (Updated Oct. 12, 2015, 5:51 p.m.) Review request for mesos, Artem

Re: Review Request 37993: Add explanatory comments for Allocator interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review102266 --- Ship it! I've shipped this patch with the minor typos and style

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/ --- (Updated Oct. 12, 2015, 6:24 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 39211: Check for trailing characters in JSON::parse().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39211/ --- (Updated Oct. 12, 2015, 6:29 p.m.) Review request for mesos, Adam B and Joseph

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

> On Oct. 9, 2015, 4:52 a.m., Timothy Chen wrote: > > include/mesos/mesos.proto, line 1121 > > > > > > What's the reasoning behind this order? Reordered according to alphabet. - Jie

Re: Review Request 39093: CMake:[3/3] Add `make check` target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39093/#review102295 --- CMakeLists.txt (lines 96 - 99)

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review102294 --- Patch looks great! Reviews applied: [39211, 39018] All tests

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review101451 --- Incomplete review on v13. Continuing on the latest version.

Re: Review Request 39018: Added JSON parsing for Resources.

> On Oct. 12, 2015, 7:48 a.m., Guangya Liu wrote: > > include/mesos/resources.hpp, line 312 > > > > > > Can you please make those comments using > >

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

> On Oct. 9, 2015, 10:54 p.m., Ben Mahler wrote: > > include/mesos/containerizer/containerizer.proto, lines 95-99 > > > > > > Why do you say "executor" here but termination is about "container" > > above? > > >

Re: Review Request 37024: Exposes mesos version information in components.

Apologies, I've committed the fix for cmake. Looking forward to getting it set up in jenkins to catch these! On Sun, Oct 11, 2015 at 9:53 AM, haosdent huang wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37024/ > > On

Re: Review Request 38747: Adding digest utilities

> On Oct. 1, 2015, 11:23 a.m., Jiang Yan Xu wrote: > > Sorry I haven't chimed in earlier. I made one comment earlier with a > > reference to a pending review but > > didn't look at the review closely. I also have a ticket > >

Re: Review Request 39201: Included `stout/check.hpp` in `future.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39201/#review102297 --- Ship it! Ship It! - Joseph Wu On Oct. 9, 2015, 9:31 p.m., Alex

Re: Review Request 37024: Exposes mesos version information in components.

Oh man, me too. :) On Mon, Oct 12, 2015 at 11:50 AM, Benjamin Mahler wrote: > Apologies, I've committed the fix for cmake. Looking forward to getting it > set up in jenkins to catch these! > > On Sun, Oct 11, 2015 at 9:53 AM, haosdent huang >

Re: Review Request 39097: CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39097/#review102296 --- Ship it! Ship It! - Joseph Wu On Oct. 9, 2015, 9:28 p.m., Alex

Re: Review Request 38747: Adding digest utilities

> On Oct. 1, 2015, 6:23 p.m., Jiang Yan Xu wrote: > > Sorry I haven't chimed in earlier. I made one comment earlier with a > > reference to a pending review but > > didn't look at the review closely. I also have a ticket > >

Re: Review Request 39202: CMake: Moved libevent, gmock, http-parser to CMake on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39202/#review102300 --- 3rdparty/libprocess/3rdparty/CMakeLists.txt (line 124)

Re: Review Request 39203: CMake: fixed typo in agent include directory configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39203/#review102303 --- Ship it! Ship It! - Joseph Wu On Oct. 10, 2015, 2:58 a.m.,

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/ --- (Updated Oct. 12, 2015, 7:33 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 39093: CMake:[3/3] Add `make check` target.

> On Oct. 12, 2015, 7:06 p.m., Joseph Wu wrote: > > CMakeLists.txt, lines 96-99 > > > > > > Still only runs the libprocess tests. > > > > This runs both tests: > > ``` > > add_custom_target( > >

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/#review102312 --- Patch looks great! Reviews applied: [38746] All tests passed. -

Re: Review Request 39193: Fixed leakage of fts_open.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39193/ --- (Updated Oct. 12, 2015, 8:19 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39192: Fixed leakage of fts_open.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39192/ --- (Updated Oct. 12, 2015, 8:18 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 39192: Fixed leakage of fts_open.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39192/#review102314 --- Ship it! Ship It! - Ben Mahler On Oct. 12, 2015, 8:18 p.m.,

Re: Review Request 39193: Fixed leakage of fts_open.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39193/#review102315 --- Ship it! src/linux/cgroups.cpp (lines 925 - 926)

Re: Review Request 39230: Added check for SASL deprecation into configuration phase.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39230/#review102306 --- Ship it! It's marginal, but I think ```AC_LANG_PROGRAM``` is a

Re: Review Request 39093: CMake:[3/3] Add `make check` target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39093/ --- (Updated Oct. 12, 2015, 7:41 p.m.) Review request for mesos, Artem

Re: Review Request 39202: CMake: Moved libevent, gmock, http-parser to CMake on Windows.

> On Oct. 12, 2015, 7:26 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, lines 241-246 > > > > > > Where are you moving this to? > > (Or why do we *not* need to build Gmock now?) Sorry,

Re: Review Request 39093: CMake:[3/3] Add `make check` target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39093/#review102309 --- Ship it! Ship It! - Joseph Wu On Oct. 12, 2015, 12:41 p.m.,

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/ --- (Updated Oct. 12, 2015, 6:34 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/ --- (Updated Oct. 12, 2015, 6:38 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 37336: Simplified the caller interface to process::Subprocess

> On Oct. 12, 2015, 4:08 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 281 > > > > > > Is this API something you agreed on with your shepherd? I'm curious why > > we

Re: Review Request 39037: Allow description empty in help information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39037/#review102290 --- 3rdparty/libprocess/src/help.cpp (lines 41 - 75)

Re: Review Request 39204: Windows: Added support for `stout/os/read.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39204/#review102319 --- Ship it! Looks good. (Checked that logical content of `read.hpp`

Re: Review Request 38919: Validation of Docker Image Manifests

> On Oct. 9, 2015, 3:22 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/provisioner/docker/spec.hpp, line 38 > > > > > > Nit: s/validateManifest/validate > > > > We tend to use non-redundant names.

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/#review102317 --- Ship it! Really nice to see this stuff get fixed, thanks Jie!

Re: Review Request 39207: Windows: Move `write` to its own file, `stout/os/write.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39207/#review102323 --- Ship it! LGTM. Verified that none of the `write` logic changed

Re: Review Request 39208: Windows: Add windows support to `stout/protobuf.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39208/#review102325 --- Ship it!

Re: Review Request 38747: Adding digest utilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/ --- (Updated Oct. 12, 2015, 9:14 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38747: Adding digest utilities

> On Oct. 12, 2015, 7:18 p.m., Jiang Yan Xu wrote: > > 3rdparty/libprocess/include/process/digest.hpp, line 61 > > > > > > Consider using `boost::shared_array data` (see io.cpp). Since c++11 standard way is to use

Re: Review Request 38570: Change documentation image links to absolute paths.

> On Oct. 6, 2015, 2:29 p.m., Ben Mahler wrote: > > docs/external-containerizer.md, line 92 > > > > > > How will this work when we add multiple versions of documents to the > > website? Now this hardcodes "latest"

Re: Review Request 38901: Serialize Docker Image Spec as Protobuf

> On Oct. 9, 2015, 1:12 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/provisioner/docker/spec.hpp, line 18 > > > > > > We generally prefer header files that are `complete` i.e. they compile > > on their

Re: Review Request 38578: Update upgrade.md for SUPPRESS related upgrade

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38578/ --- (Updated Oct. 13, 2015, 1:08 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 39184: RegistryClient refactor: reordered ctor parameters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39184/#review102374 --- Ship it! Ship It! - Timothy Chen On Oct. 9, 2015, 11:51 p.m.,

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38416/#review102346 --- Ship it! Thanks for your patience Tim! Looks good, just some

Re: Review Request 38570: Change documentation image links to absolute paths.

> On Oct. 6, 2015, 2:29 p.m., Ben Mahler wrote: > > docs/external-containerizer.md, line 92 > > > > > > How will this work when we add multiple versions of documents to the > > website? Now this hardcodes "latest"

Re: Review Request 39249: Updated upgrades.md about TaskStatus::Reason naming changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39249/#review102371 --- Patch looks great! Reviews applied: [38746, 39249] All tests

Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message.

> On Oct. 12, 2015, 9:03 p.m., Ben Mahler wrote: > > include/mesos/mesos.proto, lines 1100-1101 > > > > > > Shall we say why it's "bad"? i.e. the default value when a caller > > doesn't check for presence is 0 and

Re: Review Request 38747: Adding digest utilities

> On Oct. 1, 2015, 11:23 a.m., Jiang Yan Xu wrote: > > Sorry I haven't chimed in earlier. I made one comment earlier with a > > reference to a pending review but > > didn't look at the review closely. I also have a ticket > >

Re: Review Request 39250: Puller refactor: moved untar to a common place

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39250/#review102373 --- Bad patch! Reviews applied: [39013, 38443, 39184, 39155, 39156,

Re: Review Request 38580: Added docker registry RemotePuller

> On Oct. 1, 2015, 6:53 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioner/docker/remote_puller.cpp, line 227 > > > > > > I thought you wanted to move this to somewhere shared? We can create a > >

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38342/#review102344 --- Ship it!

Re: Review Request 37993: Add explanatory comments for Allocator interface

> On 十月 12, 2015, 6:15 p.m., Michael Park wrote: > > I've shipped this patch with the minor typos and style fixes outlined below. Thanks Michael Park for the update ;-) - Guangya --- This is an automatically generated e-mail. To reply,

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/#review102362 --- Ship it! Mind rebasing this, Felix? :) We can land this after

Re: Review Request 39250: Puller refactor: moved untar to a common place

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39250/ --- (Updated Oct. 13, 2015, 12:37 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 39211: Check for trailing characters in JSON::parse().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39211/#review102372 --- Looks great! Just a couple of suggestions to expand unit testing &

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Oct. 12, 2015, 9:35 p.m.) Review request for mesos, Jie Yu, Timothy

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

> On Sept. 29, 2015, 12:14 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, lines 762-763 > > > > > > I've seen your discussion with @Jan above, here is what I

Review Request 39250: Puller refactor: moved untar to a common place

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39250/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38564/ --- (Updated Oct. 13, 2015, 1:39 a.m.) Review request for mesos, Connor Doyle and

Re: Review Request 38570: Change documentation image links to absolute paths.

> On Oct. 6, 2015, 9:29 p.m., Ben Mahler wrote: > > docs/external-containerizer.md, line 92 > > > > > > How will this work when we add multiple versions of documents to the > > website? Now this hardcodes "latest"

Re: Review Request 39213: Windows: Moved `bootId` to is own file, `stout/os/windows/bootid.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39213/#review102337 --- Ship it!

Re: Review Request 37996: Added InheritanceTree a tree based container where children nodes inherit the values associated with their parent.

> On Oct. 6, 2015, 12:39 p.m., Bernd Mathiske wrote: > > Ship It! > > Ben Mahler wrote: > I don't think we should introduce this into stout in its current form. I > realize you're planning to use this for authentication stuff, but looking at > this on its own, it seems like a confusing

Re: Review Request 39205: Deprecate resource_monitoring_interval flag

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39205/#review102361 --- Ship it! Ship It! - Niklas Nielsen On Oct. 11, 2015, 8:32

Re: Review Request 39210: Windows: Moved `realpath` to its own file, `stout/os/realpath.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39210/#review102331 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/realpath.hpp

Re: Review Request 38443: Added layerid information to ManifestResponse

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38443/#review102363 --- Ship it! Ship It! - Timothy Chen On Oct. 9, 2015, 6:34 p.m.,

  1   2   >