Re: Review Request 40978: Modify the Http test process in FetcherTests to be symmetric in spawn/terminate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40978/#review109485 --- Ship it! Ship It! - Michael Park On Dec. 4, 2015, 6:49 p.m.,

Re: Review Request 40978: Modify the Http test process in FetcherTests to be symmetric in spawn/terminate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40978/#review109483 --- Ship it! This looks a lot like other HTTP tests now. Good job

Re: Review Request 41050: Added a paragraph to the release guide that handles API updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41050/#review109484 --- Ship it! Ship It! - Michael Park On Dec. 7, 2015, 9:06 p.m.,

Re: Review Request 40292: Added style guideline for writing numbers to markdown styleguide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40292/#review109488 --- -1 to this review. We are getting so many rules which regulate

Re: Review Request 40224: Fix wrong flags infos in /state and /flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40224/#review109479 --- Patch looks great! Reviews applied: [40224] Passed command:

Re: Review Request 40978: Modify the Http test process in FetcherTests to be symmetric in spawn/terminate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40978/#review109486 --- Ship it! src/tests/fetcher_tests.cpp (line 278)

Re: Review Request 41119: Cleaned up DRF allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41119/#review109487 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 40632: WIP: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 十二月 9, 2015, 12:38 p.m.) Review request for mesos and Klaus Ma.

Re: Review Request 40632: WIP: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/#review109503 --- Bad patch! Reviews applied: [40375, 40339] Failed command:

Re: Review Request 40339: Added a flag to master to enable oversubscription for reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40339/ --- (Updated 十二月 9, 2015, 1:05 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40978: Modify the Http test process in FetcherTests to be symmetric in spawn/terminate.

> On Dec. 9, 2015, 2:31 a.m., Benjamin Bannier wrote: > > src/tests/fetcher_tests.cpp, line 278 > > > > > > Unneeded dead code which should be removed (otherwise should be `= > > default`). You are right, but all

Re: Review Request 40978: Modify the Http test process in FetcherTests to be symmetric in spawn/terminate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40978/#review109492 --- src/tests/fetcher_tests.cpp (line 278)

Re: Review Request 40849: Fix flaky MemoryPressureMesosTests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40849/#review109494 --- Ship it! Ship It! - Benjamin Bannier On Dec. 3, 2015, 7:01

Re: Review Request 40903: Ported approximated Option CPU resource number comparison to v1 and improved the check expression for this.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40903/#review109537 --- Ship it! Ship It! - Avinash sridharan On Dec. 3, 2015, 11:09

Re: Review Request 41076: Added tests for implicit roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41076/#review109529 --- It would be great to have a test for "/roles" endpoint when: -

Re: Review Request 41075: Added support for implicit roles.

> On Dec. 8, 2015, 4:45 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, lines 1543-1545 > > > > > > Why don't we consider roles without frameworks but with a non-default > > weight active? Or roles with

Re: Review Request 40292: Added style guideline for writing numbers to markdown styleguide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40292/#review109545 --- -1 Personally, I have not yet encountered in a review the

Re: Review Request 41092: Added CMake file for agent executable build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41092/#review109544 --- src/slave/CMakeLists.txt (lines 17 - 19)

Re: Review Request 41090: Second iteration of changes for cmake build on linux.

> On Dec. 8, 2015, 6:18 p.m., Joseph Wu wrote: > > src/slave/cmake/FindCurl.cmake, line 28 > > > > > > (I'm a bit of a CMake noob.) Where is this defined? `find_package` is a built-in, and when you define a macro

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/#review109559 --- src/CMakeLists.txt (lines 223 - 226)

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/#review109562 --- src/CMakeLists.txt (lines 267 - 286)

Re: Review Request 41104: Addes some additional missing source files and put the source files in proper order

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41104/#review109564 --- src/CMakeLists.txt (line 248)

Re: Review Request 41108: Add curl, sasl and dl link flags and add protobuf library directory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41108/#review109566 --- src/slave/cmake/SlaveConfigure.cmake (line 39)

Re: Review Request 41096: Added LFLAGs need for linux cmake build

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41096/#review109569 --- 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake (line

Re: Review Request 40056: Make hook execution order deterministic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40056/ --- (Updated Dec. 9, 2015, 5:25 p.m.) Review request for mesos, Ben Mahler, Kapil

Re: Review Request 40056: Make hook execution order deterministic.

> On Dec. 4, 2015, 9:15 p.m., Niklas Nielsen wrote: > > Hi Haosdent! > > > > I apologize the tardy reply. The patch looks good but needs rebasing. > > Also, have you thought of a way to test this? > > > > With a test (maybe by just ensuring the existing ordering of the test > > modules are

Re: Review Request 41092: Added CMake file for agent executable build.

> On Dec. 9, 2015, 3:30 a.m., Joseph Wu wrote: > > src/slave/CMakeLists.txt, line 42 > > > > > > The pre-commit hooks will complain about this line. Ah, I didn't know this was true. I thought `mesos-style` only ran

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/#review109548 --- This is looking great, Bartek! One more round and I think we are

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40944/ --- (Updated Dec. 9, 2015, 10:36 a.m.) Review request for mesos, Artem

Re: Review Request 40838: Environment variable: Implemented `Env` specified in docker image returned from docker pull.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40838/ --- (Updated Dec. 9, 2015, 10:41 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 40884: Environment variable: Implemented passing user taskinfo and docker image env var for docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40884/ --- (Updated Dec. 9, 2015, 10:43 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/ --- (Updated Dec. 9, 2015, 9:15 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40944/#review109614 --- Patch looks great! Reviews applied: [40944] Passed command:

Re: Review Request 37703: Add docker exec command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37703/#review109600 --- Patch looks great! Reviews applied: [37703] Passed command:

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/ --- (Updated Dec. 9, 2015, 10:48 p.m.) Review request for mesos, Artem

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/#review109620 --- Ship it! Ship It! - Alex Clemmer On Dec. 9, 2015, 10:48 p.m.,

Re: Review Request 41156: Employed a better macro in tests, cleaned up formatting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41156/ --- (Updated Dec. 9, 2015, 11:36 p.m.) Review request for mesos, Michael Park,

Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40382/ --- (Updated Dec. 10, 2015, 12:08 a.m.) Review request for mesos, Artem

Re: Review Request 41001: Improved 'ReservationTest.ACLMultipleOperations'.

> On Dec. 9, 2015, 5:56 a.m., Michael Park wrote: > > src/tests/reservation_tests.cpp, line 1660 > > > > > > This one gets dropped because it's an invalid unreserve request, right? > > This is still what's

Re: Review Request 41001: Improved 'ReservationTest.ACLMultipleOperations'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41001/ --- (Updated Dec. 10, 2015, 2:02 a.m.) Review request for mesos, Jie Yu and

Re: Review Request 41178: Fixed a message dropping bug in the health checker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41178/#review109664 --- src/tests/health_check_tests.cpp (line 633)

Re: Review Request 40617: Added Load QoS Controller for simple eviction when system load is above configured threshold.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40617/#review109597 --- Are you also planning to update

Re: Review Request 41158: Turn off rx checksum offloading for veth in container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41158/ --- (Updated Dec. 9, 2015, 3:15 p.m.) Review request for mesos, Ian Downes and Jie

Re: Review Request 40951: CMake: Added missing source files to src/CMakeLists.txt.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/#review109632 --- Ship it! src/CMakeLists.txt (line 319)

Re: Review Request 41158: Turn off rx checksum offloading for veth in container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41158/#review109644 --- This is more like a question: do we need to turn off tx side as

Re: Review Request 39219: Windows: Added support for `slave/state.cpp`.

> On Dec. 10, 2015, 1:37 a.m., Joris Van Remoortere wrote: > > src/slave/state.cpp, lines 39-43 > > > > > > what about ``? > > Alex Clemmer wrote: > You committed it already, so, uh, well, I guess we'll get it

Re: Review Request 39219: Windows: Added support for `slave/state.cpp`.

> On Dec. 10, 2015, 1:37 a.m., Joris Van Remoortere wrote: > > src/slave/state.cpp, lines 39-43 > > > > > > what about ``? You committed it already, so, uh, well, I guess we'll get it next time.

Re: Review Request 39560: CMake: Add state.cpp, flags.cpp to Windows agent build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39560/#review109662 --- Ship it! Ship It! - Joris Van Remoortere On Nov. 16, 2015,

Review Request 41158: Turn off rx checksum offloading for veth in container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41158/ --- Review request for mesos, Ian Downes and Jie Yu. Repository: mesos

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39583/ --- (Updated Dec. 10, 2015, 2:14 a.m.) Review request for mesos, Artem

Review Request 41156: Cleaned up formatting and employed a better macro in authz tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41156/ --- Review request for mesos, Neil Conway and Till Toenshoff. Repository: mesos

Re: Review Request 40195: Changed commit hook linting to ignore empty diffs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40195/ --- (Updated Dec. 9, 2015, 11:09 p.m.) Review request for mesos, Artem

Re: Review Request 41159: Corrected a comment in reservation endpoint tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41159/#review109630 --- Ship it! Good catch, thanks!! - Greg Mann On Dec. 9, 2015,

Re: Review Request 41001: Improved 'ReservationTest.ACLMultipleOperations'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41001/ --- (Updated Dec. 10, 2015, 1:18 a.m.) Review request for mesos, Jie Yu and

Re: Review Request 39219: Windows: Added support for `slave/state.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39219/ --- (Updated Dec. 10, 2015, 1:27 a.m.) Review request for mesos, Artem

Re: Review Request 39219: Windows: Added support for `slave/state.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39219/#review109654 --- Ship it! src/slave/state.cpp (lines 36 - 40)

Review Request 41178: Fixed a message dropping bug in the health checker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41178/ --- Review request for mesos, Artem Harutyunyan and Timothy Chen. Bugs: MESOS-1613

Re: Review Request 40195: Changed commit hook linting to ignore empty diffs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40195/ --- (Updated Dec. 9, 2015, 11:01 p.m.) Review request for mesos, Artem

Re: Review Request 40195: Changed commit hook linting to ignore empty diffs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40195/#review109624 --- Ship it! After updating the description to match the code. -

Re: Review Request 40951: CMake: Added missing source files to src/CMakeLists.txt.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/ --- (Updated Dec. 9, 2015, 11:35 p.m.) Review request for mesos, Artem

Re: Review Request 40056: Make hook execution order deterministic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40056/#review109651 --- Ship it! Ship It! - Guangya Liu On 十二月 9, 2015, 5:25 p.m.,

Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40382/#review109652 --- Ship it! Ship It! - Joris Van Remoortere On Dec. 10, 2015,

Re: Review Request 40382: Windows: Added threadsafe `strerror_r` implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40382/ --- (Updated Dec. 10, 2015, 1:06 a.m.) Review request for mesos, Artem

Re: Review Request 41156: Employed a better macro in tests, cleaned up formatting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41156/#review109661 --- Bad patch! Reviews applied: [41156] Failed command:

Re: Review Request 40995: Added test cases for role behavior.

> On Dec. 8, 2015, 2:55 p.m., Alexander Rukletsov wrote: > > src/tests/role_tests.cpp, lines 83-84 > > > > > > `MesosTest` exposes the `defaultAgentResourcesString` constant. I think > > you can get rid of these

Review Request 41113: Added `IsolatorRecoveryInfo` message as the sole parameter to `Isolator::recover()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41113/ --- Review request for mesos, Adam B, Ben Mahler, Jie Yu, and Neil Conway. Bugs:

Re: Review Request 40905: [libprocess]: Made `MethodNotAllowed` response compliant to RFC 2616.

> On Dec. 3, 2015, 5:10 p.m., Anand Mazumdar wrote: > > 3rdparty/libprocess/include/process/http.hpp, line 582 > > > > > > hmmm , why do we need another constructor with no response body ? > > > > We have

Review Request 41159: Corrected a comment in reservation endpoint tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41159/ --- Review request for mesos, Greg Mann and Michael Park. Repository: mesos

Re: Review Request 40632: WIP: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/ --- (Updated 十二月 9, 2015, 11:33 p.m.) Review request for mesos and Klaus Ma.

Re: Review Request 41158: Turn off rx checksum offloading for veth in container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41158/#review109641 --- Ship it! Ship It! - Jie Yu On Dec. 9, 2015, 11:15 p.m., Cong

Re: Review Request 40632: WIP: Enabled oversubscribed resources for reservations in allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/#review109643 --- Bad patch! Reviews applied: [40375, 40339, 40529, 40532, 40632]

Re: Review Request 41090: CMake: Added FindCurl.cmake script to locate curl library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41090/ --- (Updated Dec. 10, 2015, 1:10 a.m.) Review request for mesos, Artem

Re: Review Request 41090: CMake: Added FindCurl.cmake script to locate curl library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41090/#review109657 --- Ship it! Ship It! - Alex Clemmer On Dec. 10, 2015, 1:10 a.m.,

Re: Review Request 41158: Turn off rx checksum offloading for veth in container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41158/#review109627 --- Ship it!

Re: Review Request 41156: Cleaned up formatting and employed a better macro in authz tests.

> On Dec. 9, 2015, 10:58 p.m., Neil Conway wrote: > > There are a few more instances of the `AWAIT_EXPECT_EQ(true, ...)` pattern > > in group_tests.cpp -- want to fix those as well? I was looking at "authorization_tests.cpp", but... why not? Will do! - Alexander

Re: Review Request 41159: Corrected a comment in reservation endpoint tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41159/#review109636 --- Ship it! Ship It! - Neil Conway On Dec. 9, 2015, 11:22 p.m.,

Re: Review Request 40906: Replaced `BadRequest` with `MethodNotAllowed` for all HTTP requests with unsupported methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40906/ --- (Updated Dec. 10, 2015, 12:13 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 40913: Made `MethodNotAllowed` response compliant to RFC 2616.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40913/ --- (Updated Dec. 10, 2015, 12:12 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39559/ --- (Updated Dec. 10, 2015, 1:14 a.m.) Review request for mesos, Artem

Re: Review Request 41178: Fixed a message dropping bug in the health checker.

> On Dec. 10, 2015, 2:10 a.m., Neil Conway wrote: > > src/tests/health_check_tests.cpp, line 633 > > > > > > Comment needs updating. Thanks for catching this! - Ben

Re: Review Request 41096: CMake: Added LFLAGs need for linux cmake build

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41096/ --- (Updated Dec. 10, 2015, 3:16 a.m.) Review request for mesos, Artem

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/ --- (Updated Dec. 10, 2015, 3:36 a.m.) Review request for mesos and Adam B.

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/ --- (Updated Dec. 10, 2015, 3:36 a.m.) Review request for mesos and Adam B.

Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/#review109684 --- 1. We badly need a unit test for this. :-) 2. If I understand

Re: Review Request 41159: Corrected a comment in reservation endpoint tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41159/#review109686 --- Patch looks great! Reviews applied: [41159] Passed command:

Re: Review Request 40903: Ported approximated Option CPU resource number comparison to v1 and improved the check expression for this.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40903/#review109672 --- Ship it! Ship It! - Klaus Ma On Dec. 3, 2015, 7:09 p.m., Bernd

Re: Review Request 41182: Exposed task health flag through the state endpoint on master and slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41182/#review109671 --- Ship it! I shortened some of the comments, but looks great,

Re: Review Request 41092: Added CMake file for agent executable build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41092/#review109679 --- Bad patch! Reviews applied: [40951, 41090, 41092] Failed

Re: Review Request 40906: Replaced `BadRequest` with `MethodNotAllowed` for all HTTP requests with unsupported methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40906/#review109693 --- Ship it! Ship It! - Anand Mazumdar On Dec. 10, 2015, 12:13

Re: Review Request 41178: Fixed a message dropping bug in the health checker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41178/#review109668 --- Ship it! Ship It! - Artem Harutyunyan On Dec. 9, 2015, 6:01

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39583/#review109665 --- Ship it!

Re: Review Request 41178: Fixed a message dropping bug in the health checker.

> On Dec. 10, 2015, 2:35 a.m., Artem Harutyunyan wrote: > > src/health-check/main.cpp, line 120 > > > > > > Do we need to create a JIRA for eventually get rid of the hack? Good idea, I filed MESOS-4111 and will

Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41187/ --- Review request for mesos and Adam B. Bugs: MESOS-3962

Review Request 41182: Exposed task health flag through the state endpoint on master and slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41182/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4015

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review109681 ---

Re: Review Request 40905: [libprocess]: Made `MethodNotAllowed` response compliant to RFC 2616.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40905/#review109691 --- Ship it! LGTM - Anand Mazumdar On Dec. 10, 2015, 12:12 a.m.,

Review Request 41185: CMake: Updated LFLAG for dl library to defined label

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41185/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van

Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/ --- Review request for mesos and Adam B. Bugs: MESOS-3962

Re: Review Request 41187: Adding labels field to Port information, for service discovery to associate arbitrary tags by applications to ports for a given task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41187/#review109683 --- Can we also update the V1 protobufs since this would be external

Re: Review Request 40429: Report executor exit to framework schedulers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40429/#review109593 --- Few things you need to do before this can get committed 1) Send

  1   2   >