Re: Review Request 42689: Clarified a comment that occurs in several test cases.

2016-02-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42689/#review118432 --- Patch looks great! Reviews applied: [42689] Passed command:

Re: Review Request 43198: Added common appc spec utilities.

2016-02-09 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43198/ --- (Updated Feb. 9, 2016, 7:40 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

2016-02-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review118439 --- Bad patch! Reviews applied: [42696] Failed command:

Re: Review Request 42516: Add support for user-defined networks.

2016-02-09 Thread Ezra Silvera
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/ --- (Updated Feb. 9, 2016, 7:25 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 43309: Added systemd life-extension option to posix launcher.

2016-02-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43309/#review118459 --- Patch looks great! Reviews applied: [43302, 43303, 43304, 43305,

Re: Review Request 43302: Libprocess: Introduced Hooks for Subprocess.

2016-02-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43302/ --- (Updated Feb. 9, 2016, 7:12 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 43201: Updated reservation documentation.

2016-02-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43201/ --- (Updated Feb. 9, 2016, 7:32 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

2016-02-09 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43093/#review118436 --- Thanks for taking this on! Some small remarks below. Overall

Re: Review Request 43303: Libprocess: Added 'parent_hooks' as an argument to 'subprocess'.

2016-02-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43303/ --- (Updated Feb. 9, 2016, 7:13 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 43258: Modified agent to get container status from containerizer.

2016-02-09 Thread Avinash sridharan
> On Feb. 9, 2016, 1:33 a.m., Jie Yu wrote: > > src/slave/slave.cpp, lines 3080-3091 > > > > > > This looks problematic to me now as we introduce 'status()' interface > > for isolators. What if there's a network

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

2016-02-09 Thread Joerg Schad
On Feb. 9, 2016, 7:13 p.m., Travis Hegner wrote: > > hanks Oh btw regarding the commit message: We usually have commit messages stating what changed, so in your case it could be something along the lines of 'Added support for new docker network setting.' - Joerg

Re: Review Request 43308: Added systemd life-extension option to container logrotate module.

2016-02-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43308/ --- (Updated Feb. 9, 2016, 7:14 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 43304: Mesos: Disambiguated call to 'subprocess' in linux launcher.

2016-02-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43304/ --- (Updated Feb. 9, 2016, 7:13 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 43307: Added systemd life-extension option to docker process containerizer.

2016-02-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43307/ --- (Updated Feb. 9, 2016, 7:14 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 43306: Migrated linux launcher systemd executor logic into subprocess hook.

2016-02-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43306/ --- (Updated Feb. 9, 2016, 7:14 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 43309: Added systemd life-extension option to posix launcher.

2016-02-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43309/ --- (Updated Feb. 9, 2016, 7:14 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 43305: Moved systemd executor slice initialization logic.

2016-02-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43305/ --- (Updated Feb. 9, 2016, 7:13 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 43199: Updated authorization documentation.

2016-02-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43199/ --- (Updated Feb. 9, 2016, 7:35 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/#review118430 --- This is a partial review. I scanned the entire patch and realized

Re: Review Request 43127: Introduced Appc image cache.

2016-02-09 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43127/ --- (Updated Feb. 9, 2016, 8:25 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 43258: Modified agent to get container status from containerizer.

2016-02-09 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43258/ --- (Updated Feb. 9, 2016, 8:32 p.m.) Review request for mesos, Jie Yu and Kapil

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-02-09 Thread haosdent huang
> On Feb. 8, 2016, 10:52 p.m., Ian Downes wrote: > > src/linux/perf.cpp, lines 423-426 > > > > > > Hmmm, I'm not satisfied with this. I thought the new output format was > > introduced at a specific kernel version

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-02-09 Thread haosdent huang
> On Feb. 8, 2016, 10:52 p.m., Ian Downes wrote: > > src/linux/perf.cpp, lines 423-426 > > > > > > Hmmm, I'm not satisfied with this. I thought the new output format was > > introduced at a specific kernel version

Re: Review Request 41760: Add initialization method to Anonymous module

2016-02-09 Thread Marco Massenzio
> On Feb. 8, 2016, 4:53 p.m., Kapil Arya wrote: > > I am little concerned about `Flags` being passed to the module. Since there > > is no visibility about the allowed master/agent flags from the module's > > perspective, how does it cope with the changes to master/slave flags? Would > > we

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-02-09 Thread haosdent huang
> On Feb. 8, 2016, 10:52 p.m., Ian Downes wrote: > > src/linux/perf.cpp, lines 423-426 > > > > > > Hmmm, I'm not satisfied with this. I thought the new output format was > > introduced at a specific kernel version

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-02-09 Thread Artem Harutyunyan
> On Feb. 6, 2016, 7:39 p.m., Guangya Liu wrote: > > @Maged, I think that you can now find a shephard for this. You can post an > > email to d...@mesos.apache.org to ask for a shephard for MESOS-4353 Folks, generally the expectation is that the shepherd is found *before* the code gets written

Re: Review Request 42589: Added test case for allocator recover with Quota.

2016-02-09 Thread Klaus Ma
> On Feb. 1, 2016, 7:57 p.m., Alexander Rukletsov wrote: > > What is the use case you want to test here? Specifically, why do you test > > *both* resume paths simulataneously? Will the outcome of the test change if > > you remove one of those? This is the test case for

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

2016-02-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43358/#review118389 --- Patch looks great! Reviews applied: [43358] Passed command:

Re: Review Request 43312: Updated docs/presentations.md.

2016-02-09 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43312/#review118390 --- Ship it! I think that you need to update

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-09 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43321/#review118391 --- src/tests/scheduler_tests.cpp (line 839)

Re: Review Request 42982: Defined a virtual `status` method for Containerizer.

2016-02-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42982/#review118392 --- Ship it! Ship It! - Jie Yu On Feb. 8, 2016, 7:19 p.m.,

Review Request 43359: Fixed the build with gcc 5.2.

2016-02-09 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43359/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

2016-02-09 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43358/ --- (Updated Feb. 9, 2016, 12:54 p.m.) Review request for mesos, Ben Mahler, Chi

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

2016-02-09 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43358/ --- (Updated Feb. 9, 2016, 12:47 p.m.) Review request for mesos, Ben Mahler, Chi

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

2016-02-09 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43358/ --- (Updated Feb. 9, 2016, 12:47 p.m.) Review request for mesos, Ben Mahler, Chi

Re: Review Request 43359: Fixed the build with gcc 5.2.

2016-02-09 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43359/#review118388 --- Ship it! Ship It! - Till Toenshoff On Feb. 9, 2016, 1:36

Re: Review Request 43359: Fixed the build with gcc 5.2.

2016-02-09 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43359/ --- (Updated Feb. 9, 2016, 5:45 a.m.) Review request for mesos and Till Toenshoff.

Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

2016-02-09 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43358/ --- Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, Niklas Nielsen,

Re: Review Request 43384: Improved error handling in generate-endpoint-help script.

2016-02-09 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43384/#review118489 --- I don't mind these changes. I had catches similar to these in

Re: Review Request 43122: Updated doxygen target for site/Rakefile.

2016-02-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43122/ --- (Updated Feb. 9, 2016, 3:54 p.m.) Review request for mesos, Joseph Wu and Neil

Re: Review Request 43198: Added common appc spec utilities.

2016-02-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43198/#review118463 --- include/mesos/appc/spec.hpp (line 27)

Re: Review Request 42516: Add support for user-defined networks.

2016-02-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42516/#review118476 --- Patch looks great! Reviews applied: [42516] Passed command:

Re: Review Request 43258: Modified agent to get container status from containerizer.

2016-02-09 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43258/ --- (Updated Feb. 9, 2016, 10:08 p.m.) Review request for mesos, Jie Yu and Kapil

Review Request 43384: Improved error handling in generate-endpoint-help script.

2016-02-09 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43384/ --- Review request for mesos, Ben Mahler and Kevin Klues. Repository: mesos

Re: Review Request 43306: Migrated linux launcher systemd executor logic into subprocess hook.

2016-02-09 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43306/#review118487 --- src/linux/systemd.cpp (line 76)

Re: Review Request 43118: Corrected mistakes in docs for volume/reservation HTTP endpoints.

2016-02-09 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43118/ --- (Updated Feb. 9, 2016, 10:53 p.m.) Review request for mesos, Greg Mann and Jie

Re: Review Request 43122: Updated doxygen target for site/Rakefile.

2016-02-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43122/ --- (Updated Feb. 9, 2016, 3:55 p.m.) Review request for mesos, Joseph Wu and Neil

Re: Review Request 43258: Modified agent to get container status from containerizer.

2016-02-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43258/#review118478 --- Fix it, then Ship it! src/slave/slave.cpp (line 3098)

Re: Review Request 43306: Migrated linux launcher systemd executor logic into subprocess hook.

2016-02-09 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43306/#review118469 --- Fix it, then Ship it! src/linux/systemd.cpp (line 66)

Re: Review Request 43319: Remove markdown files from doxygen.

2016-02-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43319/ --- (Updated Feb. 9, 2016, 3:55 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 43200: Updated role documentation.

2016-02-09 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43200/#review118449 --- docs/roles.md (line 130)

Re: Review Request 43199: Updated authorization documentation.

2016-02-09 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43199/#review118446 --- Fix it, then Ship it! docs/authorization.md (line 76)

Re: Review Request 43138: Updated a comment for oversubscribed resources for clarity.

2016-02-09 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43138/#review118431 --- src/master/allocator/mesos/hierarchical.cpp (lines 524 - 531)

Re: Review Request 43316: Decrease countCacheEntries in FetcherCacheTest.SimpleEviction .

2016-02-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43316/ --- (Updated Feb. 9, 2016, 6:18 p.m.) Review request for mesos and Bernd Mathiske.

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/ --- (Updated Feb. 9, 2016, 6:17 p.m.) Review request for mesos and Bernd Mathiske.

Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

2016-02-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- Review request for mesos and Bernd Mathiske. Bugs: MESOS-4156

Re: Review Request 43353: Fixed SlaveRecoveryTest.RecoverStatusUpdateManager.

2016-02-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43353/#review118427 --- Ship it! Ship It! - Vinod Kone On Feb. 9, 2016, 2:41 a.m.,

Re: Review Request 43384: Improved error handling in generate-endpoint-help script.

2016-02-09 Thread Neil Conway
> On Feb. 9, 2016, 10:51 p.m., Kevin Klues wrote: > > I don't mind these changes. I had catches similar to these in eralier > > versions of this script (https://reviews.apache.org/r/43220/diff/2/), but > > reviews pointed to removing them in favor of printing the "ugly" stack > > traces.

Review Request 43381: Updated Doxyfile to use relative path.

2016-02-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43381/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Review Request 43382: Updated Doxyfile to use relative path.

2016-02-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43382/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 43199: Updated authorization documentation.

2016-02-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43199/ --- (Updated Feb. 9, 2016, 11:19 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 43199: Updated authorization documentation.

2016-02-09 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43199/#review118499 --- docs/authorization.md (line 78)

Re: Review Request 43200: Updated role documentation.

2016-02-09 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43200/#review118465 --- Fix it, then Ship it! docs/roles.md (line 129)

Re: Review Request 43328: Title for documentation webpages.

2016-02-09 Thread haosdent huang
> On Feb. 10, 2016, 1:12 a.m., Neil Conway wrote: > > We should make sure we're consistent with capitalization of titles. Also we > > should make the title match the Markdown title (the "#" phrase at the top > > of the page), not the file name. > > > > Lastly, I think we should probably have

Re: Review Request 43319: Remove markdown files from doxygen.

2016-02-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43319/ --- (Updated Feb. 9, 2016, 6:13 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 43122: Updated doxygen target for site/Rakefile.

2016-02-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43122/ --- (Updated Feb. 9, 2016, 6:13 p.m.) Review request for mesos, Joseph Wu and Neil

Re: Review Request 43258: Modified agent to get container status from containerizer.

2016-02-09 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43258/ --- (Updated Feb. 9, 2016, 11:47 p.m.) Review request for mesos, Jie Yu and Kapil

Re: Review Request 43388: Revised authentication documentation.

2016-02-09 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43388/ --- (Updated Feb. 10, 2016, 12:10 a.m.) Review request for mesos, Adam B, Greg

Re: Review Request 42754: Added support for labels to resource reservations.

2016-02-09 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42754/#review118506 --- Fix it, then Ship it! include/mesos/type_utils.hpp (line 71)

Re: Review Request 43258: Modified agent to get container status from containerizer.

2016-02-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43258/#review118520 --- Ship it! Ship It! - Jie Yu On Feb. 9, 2016, 11:47 p.m.,

Re: Review Request 43118: Corrected mistakes in docs for volume/reservation HTTP endpoints.

2016-02-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43118/#review118521 --- Patch looks great! Reviews applied: [43118] Passed command:

Re: Review Request 43322: Exposed `ContainerStatus` in `state.json`.

2016-02-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43322/#review118523 --- Ship it! Ship It! - Jie Yu On Feb. 8, 2016, 8:33 p.m.,

Re: Review Request 43388: Revised authentication documentation.

2016-02-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43388/#review118519 --- It's unfortunate that the docs don't currently maintain a single

Re: Review Request 43319: Remove markdown files from doxygen.

2016-02-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43319/ --- (Updated Feb. 9, 2016, 6:22 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 43382: Updated Doxyfile to use relative path.

2016-02-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43382/ --- (Updated Feb. 9, 2016, 6:22 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 43258: Modified agent to get container status from containerizer.

2016-02-09 Thread Avinash sridharan
> On Feb. 9, 2016, 10:23 p.m., Jie Yu wrote: > > src/slave/slave.cpp, lines 3186-3199 > > > > > > I think we should only do this if 'future' is Ready. Otherwise, we > > cannot tell if we should fill IP or not

Re: Review Request 43199: Updated authorization documentation.

2016-02-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43199/ --- (Updated Feb. 10, 2016, 12:32 a.m.) Review request for mesos, Neil Conway and

Re: Review Request 43199: Updated authorization documentation.

2016-02-09 Thread Greg Mann
> On Feb. 9, 2016, 11:27 p.m., Neil Conway wrote: > > docs/authorization.md, line 78 > > > > > > I don't think a "framework is used to represent various individuals or > > groups". A framework is just a piece of

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/ --- (Updated Feb. 10, 2016, 12:48 a.m.) Review request for mesos and Bernd

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

2016-02-09 Thread haosdent huang
> On Feb. 9, 2016, 7:13 p.m., Joerg Schad wrote: > > src/docker/docker.cpp, line 307 > > > > > > Are these additional checks which should apply in both cases (i.e. > > deprecated and new `addressLocation`? I.e.

Re: Review Request 43318: Updated release guide to include doxygen site generation.

2016-02-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43318/ --- (Updated Feb. 9, 2016, 6:14 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 43201: Updated reservation documentation.

2016-02-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43201/#review118497 --- Patch looks great! Reviews applied: [43199, 43200, 43201]

Review Request 43388: Revised authentication documentation.

2016-02-09 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43388/ --- Review request for mesos, Adam B, Greg Mann, and Vinod Kone. Repository: mesos

Re: Review Request 43328: Title for documentation webpages.

2016-02-09 Thread Neil Conway
> On Feb. 8, 2016, 4:47 p.m., Kevin Klues wrote: > > We recently added a script to generate markdown files for all http > > endpoints in the master and agent. We then commit these back to the repo. > > We probably need to modify this script to insert this header as well as > > update the

Re: Review Request 43200: Updated role documentation.

2016-02-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43200/ --- (Updated Feb. 10, 2016, 12:41 a.m.) Review request for mesos, Neil Conway and

Review Request 43398: CMake: Added AppC spec protocol buffer to build.

2016-02-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43398/ --- Review request for mesos, Jie Yu, Joris Van Remoortere, and switched to

Re: Review Request 43328: Title for documentation webpages.

2016-02-09 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43328/#review118513 --- We should make sure we're consistent with capitalization of

Re: Review Request 43388: Revised authentication documentation.

2016-02-09 Thread Adam B
> On Feb. 9, 2016, 5:28 p.m., Adam B wrote: > > Looks good, but I'd include a mention of FrameworkInfo.principal for use > > with authorization. Probably worth linking to http://mesos.apache.org/documentation/latest/authorization/ there too - Adam

Re: Review Request 43156: Added test: dynamic reservations with same role, different principals.

2016-02-09 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43156/#review118535 --- Ship it! Ship It! - Michael Park On Feb. 5, 2016, 5:47

Re: Review Request 43388: Revised authentication documentation.

2016-02-09 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43388/#review118531 --- Fix it, then Ship it! Looks good, but I'd include a mention of

Re: Review Request 43200: Updated role documentation.

2016-02-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43200/ --- (Updated Feb. 9, 2016, 11:18 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 43122: Updated doxygen target for site/Rakefile.

2016-02-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43122/ --- (Updated Feb. 9, 2016, 6:22 p.m.) Review request for mesos, Joseph Wu and Neil

Re: Review Request 43318: Updated release guide to include doxygen site generation.

2016-02-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43318/ --- (Updated Feb. 9, 2016, 6:22 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 43382: Updated Doxyfile to use relative path.

2016-02-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43382/ --- (Updated Feb. 9, 2016, 7:16 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 43388: Revised authentication documentation.

2016-02-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43388/#review118504 --- Fix it, then Ship it! docs/authentication.md (line 11)

Re: Review Request 43398: CMake: Added AppC spec protocol buffer to build.

2016-02-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43398/#review118528 --- Ship it! Ship It! - Jie Yu On Feb. 10, 2016, 1:12 a.m.,

Review Request 43399: Windows: Added `stout/os/read.hpp` include to `windows/os.hpp`.

2016-02-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43399/ --- Review request for mesos, Jie Yu, Joris Van Remoortere, and switched to

Re: Review Request 42689: Clarified a comment that occurs in several test cases.

2016-02-09 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42689/#review118540 --- Ship it! Ship It! - Adam B On Feb. 9, 2016, 9:13 a.m., Neil

Re: Review Request 43321: Speeded up SchedulerTest.Decline by advancing the clock.

2016-02-09 Thread haosdent huang
> On Feb. 9, 2016, 2:29 p.m., Guangya Liu wrote: > > src/tests/scheduler_tests.cpp, line 839 > > > > > > Do we need Clock::settle() here to make sure the `recoverResources` > > messages to be dispatched and

Re: Review Request 43388: Revised authentication documentation.

2016-02-09 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43388/ --- (Updated Feb. 10, 2016, 2:06 a.m.) Review request for mesos, Adam B, Greg

  1   2   >