Re: Review Request 51509: Fixed potential FD double close in the libevent socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51509/#review148467 --- Fix it, then Ship it!

Re: Review Request 51374: Change registry update order on removal, mark-unreachable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51374/ --- (Updated Sept. 12, 2016, 10:05 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50845: Added `unreachable_time` to TaskStatus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50845/ --- (Updated Sept. 12, 2016, 10:05 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50705: Changed master to allow partitioned slaves to reregister.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50705/ --- (Updated Sept. 12, 2016, 10:05 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51635: Added a test case `HealthCheckTest.HealthCheckProtobufCompatible`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51635/ --- (Updated Sept. 12, 2016, 10:21 a.m.) Review request for mesos, Alexander

Re: Review Request 51560: Updated HealthCheck protobuf message for backwards compatibility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/ --- (Updated Sept. 12, 2016, 10:28 a.m.) Review request for mesos, Alexander

Re: Review Request 51511: Added check in FileEncoder's destructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51511/#review148472 --- 3rdparty/libprocess/src/encoder.hpp (line 259)

Re: Review Request 51561: Fixed the overview table style in upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51561/ --- (Updated Sept. 12, 2016, 10:21 a.m.) Review request for mesos, Alexander

Re: Review Request 51560: Updated HealthCheck protobuf message for backwards compatibility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/ --- (Updated Sept. 12, 2016, 10:20 a.m.) Review request for mesos, Alexander

Re: Review Request 51561: Fixed the overview table style in upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51561/ --- (Updated Sept. 12, 2016, 10:29 a.m.) Review request for mesos, Alexander

Re: Review Request 51791: Renamed `CGROUPS_ROOT_PERF_RollForward` to keep consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51791/ --- (Updated Sept. 12, 2016, 7:29 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51631/#review148462 --- Patch looks great! Reviews applied: [49855, 50733, 50749, 50748,

Re: Review Request 51783: Refactored `UserCgroupsIsolatorTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51783/ --- (Updated Sept. 12, 2016, 8:19 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.

> On Sept. 12, 2016, 3:09 a.m., Qian Zhang wrote: > > I think this patch is mainly for handling the case that agent is restarted > > with more cgroups subsystems enabled, but what if the agent is restarted > > with less cgroups subsystems enabled? In this case, it seems we may miss to > >

Re: Review Request 51783: Refactored `UserCgroupsIsolatorTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51783/#review148463 --- Fix it, then Ship it!

Re: Review Request 51561: Fixed the overview table style in upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51561/#review148477 --- Patch looks great! Reviews applied: [51560, 51561] Passed

Re: Review Request 51784: Supported merging the launch command from isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51784/#review148482 --- I am not really sure it is a good idea to follow this approach.

Re: Review Request 51561: Fixed the overview table style in upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51561/#review148483 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 12, 2016,

Re: Review Request 51021: Added GC of unreachable agent metadata from the registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51021/ --- (Updated Sept. 12, 2016, 1:48 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/#review148484 --- include/mesos/mesos.proto (lines 358 - 359)

Re: Review Request 51560: Deprecated using health checks without setting the type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/ --- (Updated Sept. 12, 2016, 12:56 p.m.) Review request for mesos, Alexander

Re: Review Request 51561: Fixed the overview table style in upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51561/ --- (Updated Sept. 12, 2016, 12:56 p.m.) Review request for mesos, Alexander

Re: Review Request 45492: Used ChildHooks in Mesos [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45492/ --- (Updated Sept. 12, 2016, 1:05 p.m.) Review request for mesos, Alexander

Re: Review Request 51561: Fixed the overview table style in upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51561/ --- (Updated Sept. 12, 2016, 1:17 p.m.) Review request for mesos, Alexander

Re: Review Request 51560: Deprecated using health checks without setting the type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/ --- (Updated Sept. 12, 2016, 1:18 p.m.) Review request for mesos, Alexander

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/ --- (Updated Sept. 12, 2016, 1:17 p.m.) Review request for mesos, Alexander

Review Request 51805: Updated master to send TASK_UNREACHABLE task state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51805/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4049

Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/ --- Review request for mesos, Alexander Rukletsov, Joseph Wu, Silas Snider, and

Review Request 51804: Fixed typos in subprocess_base.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51804/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/ --- (Updated Sept. 12, 2016, 2 p.m.) Review request for mesos, Alexander

Re: Review Request 51805: Updated master to send TASK_UNREACHABLE task state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51805/#review148500 --- Bad patch! Reviews applied: [51805, 51707, 51653, 51706, 51021,

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

> On Sept. 12, 2016, 5:23 p.m., Silas Snider wrote: > > include/mesos/mesos.proto, line 374 > > > > > > Why is this being deprecated when the comment above mentions needing to > > support it? @swsnider, we may not

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

> On Sept. 12, 2016, 5:23 p.m., Silas Snider wrote: > > include/mesos/mesos.proto, line 374 > > > > > > Why is this being deprecated when the comment above mentions needing to > > support it? > > haosdent huang

Re: Review Request 51779: Introduced a new protobuf message 'ContainerRecoverInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51779/ --- (Updated Sept. 12, 2016, 11:41 a.m.) Review request for mesos, Benjamin

Review Request 51816: Updated the upgrades.md and CHANGELOG for MESOS-6150.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51816/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph

Re: Review Request 51511: Added check in FileEncoder's destructor.

> On Sept. 12, 2016, 2:11 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/encoder.hpp, line 259 > > > > > > Do we want to fast fail on all errors returned by `close` or just > > `EBADFD`? > > This

Re: Review Request 51740: Added the 'name' and 'args' field to the 'delegate' plugin's CNI config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51740/ --- (Updated Sept. 12, 2016, 7:28 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 51737: Added `PluginError` to simplify error reporting for CNI plugins.

> On Sept. 10, 2016, 1:15 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/spec.hpp, lines 63-66 > > > > > > Why we need this? If I don't have an `ostream` operator for `PluginError` the

Re: Review Request 51737: Added `PluginError` to simplify error reporting for CNI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51737/ --- (Updated Sept. 12, 2016, 7:27 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/#review148521 --- include/mesos/mesos.proto (line 374)

Re: Review Request 51780: Changed isolator recover interface using 'ContainerRecoverInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51780/ --- (Updated Sept. 12, 2016, 11:41 a.m.) Review request for mesos, Benjamin

Re: Review Request 51816: Updated the upgrades.md and CHANGELOG for MESOS-6150.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51816/ --- (Updated Sept. 12, 2016, 11:45 a.m.) Review request for mesos, Benjamin

Re: Review Request 51668: Changed the nested ContainerID from hashmap to list in memory.

> On Sept. 6, 2016, 4:16 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.hpp, line 333 > > > > > > Any reason not use a 'vector'? > > Jie Yu wrote: > IN fact, why not use hashset here?

Re: Review Request 51769: Implemented `delegate` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51769/ --- (Updated Sept. 12, 2016, 7:31 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 51486: Added `execute` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51486/ --- (Updated Sept. 12, 2016, 7:32 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 51784: Supported merging the launch command from isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51784/#review148571 --- Fix it, then Ship it!

Re: Review Request 51509: Fixed potential FD double close in the libevent socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51509/ --- (Updated Sept. 12, 2016, 1:01 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 51624: Implemented 'GetAgent' call in v1 agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51624/ --- (Updated Sept. 12, 2016, 4:50 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 51626: Showed the containers information in the v1 `GET_STATE` API of Agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51626/ --- (Updated Sept. 12, 2016, 4:51 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 42860: Added paths::overlapping to check whether paths are overlapping.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42860/ --- (Updated Sept. 12, 2016, 5:29 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 42861: Ensured two Mount Disk resources do not have the same root path.

> On Sept. 6, 2016, 10:38 p.m., Greg Mann wrote: > > Thanks Haosdent! Looks good. Could you also add a test for this? Hi, @greggomann Thanks a lot for your reviews and helps! For test cases, I think we have covered it in https://reviews.apache.org/r/42860/. So I think not need to add it here.

Re: Review Request 51805: Updated master to send TASK_UNREACHABLE task state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51805/ --- (Updated Sept. 12, 2016, 4:02 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 42861: Ensured two Mount Disk resources do not have the same root path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/ --- (Updated Sept. 12, 2016, 5:29 p.m.) Review request for mesos, Benjamin

Re: Review Request 42861: Ensured two Mount Disk resources do not have the same root path.

> On Sept. 7, 2016, 7:21 p.m., Joris Van Remoortere wrote: > > src/slave/slave.cpp, lines 559-561 > > > > > > We should improve the error information here. Why can't we identify > > which original paths that were

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/ --- (Updated Sept. 12, 2016, 6:30 p.m.) Review request for mesos, Alexander

Re: Review Request 51625: Refactored `GET_CONTAINERS` Call in v1 Agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51625/ --- (Updated Sept. 12, 2016, 4:50 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 51626: Showed the containers information in the v1 `GET_STATE` API of Agent.

> On Sept. 5, 2016, 1:51 p.m., Vinod Kone wrote: > > src/slave/http.cpp, line 1454 > > > > > > it's a bit weird that `getState` filters frameworks, executors but not > > containers. > > > > can you filter

Review Request 51825: Updated the streaming function for ContainerID to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51825/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph

Re: Review Request 51625: Refactored `GET_CONTAINERS` Call in v1 Agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51625/#review148573 --- Can you separate out filtering of containers and the refactor

Re: Review Request 51475: Added an equality operator for `TaskGroupInfo`/`TaskInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51475/ --- (Updated Sept. 12, 2016, 8:21 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51475: Added an equality operator for `TaskGroupInfo`.

> On Sept. 8, 2016, 8:46 a.m., Vinod Kone wrote: > > No unit tests for this? hmm, I had punted on this due to not able to find the corresponding test file for type utils. I added a new file for type utils tests explicitly now. > On Sept. 8, 2016, 8:46 a.m., Vinod Kone wrote: > >

Re: Review Request 51477: Implemented `RunTaskGroupMessage` handler on the agent.

> On Sept. 8, 2016, 9:14 a.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 2112 > > > > > > #2085 explicitly calls stringify(). lets be consistent. > > > > also this could've been better written as >

Re: Review Request 51477: Implemented `RunTaskGroupMessage` handler on the agent.

> On Sept. 8, 2016, 2:28 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 2277 > > > > > > just realized that you need to set proper command info for `DEFAULT` > > executor here? master is not going to fill

Re: Review Request 51805: Updated master to send TASK_UNREACHABLE task state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51805/#review148581 --- Patch looks great! Reviews applied: [50235, 50416, 50417, 50418,

Re: Review Request 50706: Added test cases for PARTITION_AWARE behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50706/#review148589 --- Ship it! Ship It! - Vinod Kone On Sept. 6, 2016, 3:24 p.m.,

Re: Review Request 50705: Changed master to allow partitioned slaves to reregister.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50705/#review148588 --- Ship it! Ship It! - Vinod Kone On Sept. 12, 2016, 10:05

Re: Review Request 51371: Fixed flakiness in MasterAuthorizationTest.SlaveDisconnected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51371/#review148596 --- Ship it! Ship It! - Vinod Kone On Aug. 29, 2016, 9:51 a.m.,

Re: Review Request 51375: Introduced MockRegistrar.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51375/#review148610 --- Ship it! Ship It! - Vinod Kone On Sept. 12, 2016, 2:49

Re: Review Request 51771: Updated master validation for DOCKER ContainerInfo in TaskGroup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51771/#review148575 --- Fix it, then Ship it! LGTM modulo comments from me and

Re: Review Request 51475: Added an equality operator for `TaskGroupInfo`/`TaskInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51475/#review148578 --- Fix it, then Ship it! src/common/type_utils.cpp (line 417)

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review148579 --- src/master/allocator/mesos/hierarchical.hpp (lines 227 - 228)

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

> On Sept. 12, 2016, 10:57 a.m., Jiang Yan Xu wrote: > > include/mesos/mesos.proto, line 372 > > > > > > In genenal I think we should state "Feature X will be deprecated in > > version Y in favor of feature Z" to

Re: Review Request 51374: Change registry update order on removal, mark-unreachable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51374/#review148606 --- Fix it, then Ship it! src/master/master.cpp (line 5753)

Re: Review Request 50707: Added test for race between health checks and agent disconnect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50707/#review148592 --- Fix it, then Ship it! src/tests/slave_tests.cpp (line 2810)

Re: Review Request 51771: Updated master validation for DOCKER ContainerInfo in TaskGroup.

> On Sept. 10, 2016, 4 a.m., Guangya Liu wrote: > > src/tests/master_validation_tests.cpp, line 1722 > > > > > > s/ContainerInfo Type/`ContainerInfo` > > s/DOCKER/`DOCKER` don't think we use backticks for enum

Re: Review Request 51771: Updated master validation for DOCKER ContainerInfo in TaskGroup.

> On 九月 10, 2016, 4 a.m., Guangya Liu wrote: > > src/tests/master_validation_tests.cpp, line 1722 > > > > > > s/ContainerInfo Type/`ContainerInfo` > > s/DOCKER/`DOCKER` > > Vinod Kone wrote: > don't think

Re: Review Request 51794: Updated `ROOT_CGROUPS_CFS_Big_Quota` to test a CFS quota with decimal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51794/ --- (Updated Sept. 13, 2016, 3:17 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 51783: Refactored `UserCgroupsIsolatorTest`.

> On Sept. 13, 2016, 4:18 a.m., Jie Yu wrote: > > src/tests/containerizer/cgroups_isolator_tests.cpp, line 112 > > > > > > 'nobody' does not work on my box because it cannot access my home dir, > > and

Re: Review Request 51784: Supported merging the launch command from isolators.

> On Sept. 12, 2016, 1:46 p.m., Benjamin Bannier wrote: > > I am not really sure it is a good idea to follow this approach. It might > > make things simpler for anybody working on the Mesos containerizer, but I > > fear it might make the interfaces we expose hard to use for everybody else > >

Re: Review Request 51625: Refactored `GET_CONTAINERS` Call in v1 Agent API.

> On Sept. 5, 2016, 1:51 p.m., Vinod Kone wrote: > > src/slave/http.cpp, line 1863 > > > > > > It is unfortunate that you re-implemented `__containers()` here. Is it > > possible to factor out the implementation

Re: Review Request 51560: Deprecated using health checks without setting the type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51560/#review148522 --- Patch looks great! Reviews applied: [51561, 51803, 51560]

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

> On Sept. 12, 2016, 5:23 p.m., Silas Snider wrote: > > include/mesos/mesos.proto, line 374 > > > > > > Why is this being deprecated when the comment above mentions needing to > > support it? > > haosdent huang

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/#review148536 --- include/mesos/mesos.proto (line 372)

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

> On Sept. 12, 2016, 5:57 p.m., Jiang Yan Xu wrote: > > include/mesos/mesos.proto, line 372 > > > > > > In genenal I think we should state "Feature X will be deprecated in > > version Y in favor of feature Z" to

Re: Review Request 51794: Updated `ROOT_CGROUPS_CFS_Big_Quota` to test a CFS quota with decimal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51794/#review148641 --- src/tests/containerizer/cgroups_tests.cpp (line 512)

Re: Review Request 51782: Entered working directory before switch user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51782/#review148645 --- Why this change? Any particular reason? - Jie Yu On Sept. 11,

Re: Review Request 51783: Refactored `UserCgroupsIsolatorTest`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51783/#review148646 --- src/tests/containerizer/cgroups_isolator_tests.cpp (line 111)

Re: Review Request 51782: Entered working directory before switch user.

> On Sept. 13, 2016, 4:12 a.m., Jie Yu wrote: > > Why this change? Any particular reason? Suppose working directory is `/tmp/mesos/sandbox`, if a normal user what to `chdir` into this folder, that requires that user has `-x` permissions on * /tmp/ * /tmp/mesos/ * /tmp/mesos/sandox But if we

Re: Review Request 51783: Refactored `UserCgroupsIsolatorTest`.

> On Sept. 13, 2016, 4:18 a.m., Jie Yu wrote: > > src/tests/containerizer/cgroups_isolator_tests.cpp, line 112 > > > > > > 'nobody' does not work on my box because it cannot access my home dir, > > and

Re: Review Request 51825: Updated the streaming function for ContainerID to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51825/#review148637 --- Bad patch! Reviews applied: [51825, 51816, 51780, 51779, 51778,

Re: Review Request 51668: Changed the nested ContainerID from hashmap to list in memory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51668/ --- (Updated Sept. 12, 2016, 11:42 a.m.) Review request for mesos, Benjamin

Re: Review Request 51736: Added fields `chain` and `excludeDevices` to `PortMapper`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51736/ --- (Updated Sept. 12, 2016, 7:04 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 51152: Moved MockDocker and related declarations to separate files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51152/#review148560 --- Patch looks great! Reviews applied: [51148, 51149, 51150, 51151,

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/ --- (Updated Sept. 13, 2016, 1:47 a.m.) Review request for mesos, Alexander

Re: Review Request 51486: Added `execute` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51486/#review148632 --- Patch looks great! Reviews applied: [51736, 51737, 51740, 51767,

Re: Review Request 51376: Adjusted existing tests to use MockRegistrar.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51376/#review148611 --- Ship it! Ship It! - Vinod Kone On Aug. 24, 2016, 3:50 p.m.,

Re: Review Request 51021: Added GC of unreachable agent metadata from the registry.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51021/#review148615 --- Fix it, then Ship it! Nice tests! src/master/flags.cpp (line

Re: Review Request 42861: Ensured two Mount Disk resources do not have the same root path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/#review148620 --- Patch looks great! Reviews applied: [42860, 42861] Passed

Re: Review Request 51653: Handled agents failing health checks multiple times.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51653/#review148619 --- Fix it, then Ship it! src/master/master.cpp (line 5835)

Re: Review Request 51805: Updated master to send TASK_UNREACHABLE task state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51805/#review148623 --- Ship it! Ship It! - Vinod Kone On Sept. 12, 2016, 4:02

  1   2   >