Re: Review Request 29406: Introduce libevent ssl socket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated May 30, 2015, 5:29 a.m.) Review request for Michael Park. Changes --

Re: Review Request 34837: Added help for state.json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34837/#review85851 --- Patch looks great! Reviews applied: [34837] All tests passed. - M

Re: Review Request 34837: Added help for state.json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34837/ --- (Updated May 30, 2015, 1:17 a.m.) Review request for mesos, Niklas Nielsen and

Review Request 34837: Added help for state.json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34837/ --- Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: mesos-2277 h

Re: Review Request 34835: Add constexpr to C++ whitelist

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/#review85850 --- Patch looks great! Reviews applied: [34835] All tests passed. - M

Re: Review Request 34193: Refactored common functionality into FlagsBase

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34193/#review85843 --- 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp

Re: Review Request 33159: Pump updateFramework through Allocator from Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33159/#review85844 --- Patch looks great! Reviews applied: [32961, 33159] All tests passe

Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33271/ --- (Updated May 29, 2015, 11:50 p.m.) Review request for mesos, Bernd Mathiske, Co

Re: Review Request 34835: Add constexpr to C++ whitelist

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/#review85840 --- Ship it! Ship It! - Vinod Kone On May 29, 2015, 11:23 p.m., Paul

Review Request 34835: Add constexpr to C++ whitelist

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/ --- Review request for mesos, Benjamin Hindman, Dave Lester, Ian Downes, and Vinod K

Re: Review Request 34832: Add new qdisc tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34832/#review85838 --- Patch looks great! Reviews applied: [34830, 34832] All tests passe

Re: Review Request 34816: Changed TestResourceEstimator to be mocked.

> On May 29, 2015, 1:28 p.m., Niklas Nielsen wrote: > > src/tests/mesos.hpp, line 704 > > > > > > Why are we specializing it for the NoopResourceEstimator here? > > Bartek Plotka wrote: > To have default value for

Re: Review Request 33159: Pump updateFramework through Allocator from Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33159/ --- (Updated May 29, 2015, 10:41 p.m.) Review request for mesos and Benjamin Hindma

Review Request 34832: Add new qdisc tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34832/ --- Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: M

Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34830/ --- Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: M

Re: Review Request 34816: Changed TestResourceEstimator to be mocked.

> On May 29, 2015, 8:28 p.m., Niklas Nielsen wrote: > > src/tests/mesos.hpp, line 710 > > > > > > Couldn't we drop 'Option()' or replace with None()? ResourceEstimator was defined to have create(Option parameter. It's

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34687/ --- (Updated May 29, 2015, 9:36 p.m.) Review request for mesos, haosdent huang and

Re: Review Request 34816: Changed TestResourceEstimator to be mocked.

> On May 29, 2015, 8:28 p.m., Niklas Nielsen wrote: > > src/tests/mesos.hpp, line 704 > > > > > > Why are we specializing it for the NoopResourceEstimator here? To have default value for that typename (: It has no us

Re: Review Request 34816: Changed TestResourceEstimator to be mocked.

> On May 29, 2015, 8:50 p.m., Vinod Kone wrote: > > src/tests/mesos.hpp, line 716 > > > > > > s/Mock/Test/ since this wraps a real estimator. If i'll do that, we will have a conflict with enum ModuleID.TestResourceEs

Re: Review Request 34310: Use IDLE scheduling for revocable CPU in cgroups isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34310/#review85810 --- Patch looks great! Reviews applied: [34308, 34309, 34310] All test

Re: Review Request 34816: Changed TestResourceEstimator to be mocked.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34816/#review85806 --- you need to rebase this on the latest master src/tests/mesos.hpp <

Re: Review Request 34816: Changed TestResourceEstimator to be mocked.

> On May 29, 2015, 8:28 p.m., Niklas Nielsen wrote: > > src/tests/mesos.hpp, lines 732-735 > > > > > > Do you still need this, if we can mock the oversubscribable call? +1. lets kill this. > On May 29, 2015, 8:28 p.

Re: Review Request 34310: Use IDLE scheduling for revocable CPU in cgroups isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34310/#review85799 --- Ship it! - Vinod Kone On May 29, 2015, 7:57 p.m., Ian Downes wrot

Re: Review Request 34782: Convert Non-POD static variables in fq_codel and ingress to constexpr

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34782/ --- (Updated May 29, 2015, 8:36 p.m.) Review request for mesos, Ben Mahler, Chi Zha

Re: Review Request 34782: Convert Non-POD static variables in fq_codel and ingress to constexpr

> On May 29, 2015, 6:04 p.m., Chi Zhang wrote: > > LGTM! I think this is what constexpr is introducd for, if it is cleared in > > the codebase. Got ok on constexpr from mesosphere in email. - Paul --- This is an automatically generated

Re: Review Request 34816: Changed TestResourceEstimator to be mocked.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34816/#review85795 --- src/tests/mesos.hpp

Re: Review Request 34529: Add non-const reference version of Option::get.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34529/#review85792 --- Ship it! Hey Mark, Thanks for your work! I left some comments, but

Re: Review Request 34310: Use IDLE scheduling for revocable CPU in cgroups isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34310/ --- (Updated May 29, 2015, 12:57 p.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 34309: Support manipulating scheduler policy on Linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34309/ --- (Updated May 29, 2015, 12:56 p.m.) Review request for mesos, Joris Van Remoorte

Re: Review Request 34782: Convert Non-POD static variables in fq_codel and ingress to constexpr

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34782/#review85777 --- Ship it! src/linux/routing/queueing/fq_codel.cpp

Re: Review Request 34632: Added QoS Controller in slave

> On May 29, 2015, 7:17 p.m., Vinod Kone wrote: > > src/tests/mesos.hpp, lines 731-743 > > > > > > Should this be changed similar to how TestResourceEstimator is being > > changed? +1 - Bartek ---

Re: Review Request 34633: Added QoS Controller test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34633/#review85775 --- src/tests/oversubscription_tests.cpp

Re: Review Request 33793: HTTP headers should be considered case-insensitive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33793/#review85769 --- 3rdparty/libprocess/include/process/http.hpp

Re: Review Request 34632: Added QoS Controller in slave

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34632/#review85758 --- src/slave/slave.cpp

Re: Review Request 34662: Modularized ResourceEstimator and added test for RE module

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34662/ --- (Updated May 29, 2015, 7:10 p.m.) Review request for mesos, Jie Yu, Niklas Niel

Re: Review Request 33823: Protocol file with the HTTP API messages between executor and slave

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33823/#review85759 --- include/mesos/executor/executor.proto

Re: Review Request 34816: Changed TestResourceEstimator to be mocked.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34816/ --- (Updated May 29, 2015, 6:18 p.m.) Review request for mesos, Jie Yu, Niklas Niel

Re: Review Request 34782: Convert Non-POD static variables in fq_codel and ingress to constexpr

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34782/#review85761 --- Ship it! LGTM! I think this is what constexpr is introducd for, if

Review Request 34816: Changed TestResourceEstimator to be mocked.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34816/ --- Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod Kone

Re: Review Request 34655: Use relative url in /help generated links point

On Fri, May 29, 2015 at 1:40 AM, Adam B wrote: > > > > On May 28, 2015, 10:40 a.m., Adam B wrote: > > > Do you clearly understand why this change is needed? I didn't > understand after just reading the JIRA, and had to ask the reporter(s). > Mesosphere is hosting the Mesos UI(s) underneath the DC

Re: Review Request 34631: Added QoS Controller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631/#review85757 --- include/mesos/slave/qos_controller.hpp

Re: Review Request 33823: Protocol file with the HTTP API messages between executor and slave

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33823/#review85754 --- Ship it! include/mesos/executor/executor.hpp

Re: Review Request 34782: Convert Non-POD static variables in fq_codel and ingress to constexpr

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34782/ --- (Updated May 29, 2015, 4:37 p.m.) Review request for mesos, Ben Mahler, Chi Zha

Re: Review Request 34545: Updated the allocator related docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34545/ --- (Updated May 29, 2015, 3:39 p.m.) Review request for mesos, Adam B, Bernd Mathi

Re: Review Request 34545: Updated the allocator related docs.

> On May 29, 2015, 3:01 p.m., Niklas Nielsen wrote: > > docs/allocation-module.md, line 101 > > > > > > s/several/two/? several is less error-prone: one we get more steps, this sentence should not be updated. - Ale

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review85734 --- Patch looks great! Reviews applied: [32198, 32163, 30612] All test

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

> On May 21, 2015, 10:37 a.m., Niklas Nielsen wrote: > > src/tests/master_tests.cpp, lines 1829-1836 > > > > > > I don't think we should not have tests and asserts in SetUp(). Are all > > theses tasks and setup used

Re: Review Request 34644: Update existing lambdas to meet style guide

> On May 25, 2015, 10:51 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp, line 1411 > > > > > > I don't think this will compile. > > This forces a copy of `receiver`, which th

Re: Review Request 34645: Update existing lambdas to meet style guide

> On May 25, 2015, 11:05 p.m., Joris Van Remoortere wrote: > > This is an interesting case. We have a proxy to another function, rather > > than the implementation of that function as a lambda. > > I'm curious what the community's view is on using the proxy lambda approach > > as per your patch

Re: Review Request 34545: Updated the allocator related docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34545/#review85723 --- Ship it! docs/allocation-module.md

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

> On May 21, 2015, 7:37 p.m., Niklas Nielsen wrote: > > src/tests/master_tests.cpp, lines 1829-1836 > > > > > > I don't think we should not have tests and asserts in SetUp(). Are all > > theses tasks and setup used

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

> On May 13, 2015, 11:19 a.m., Adam B wrote: > > src/master/http.cpp, lines 279-288 > > > > > > One thing I'm not 100% clear about from this description: Are each of > > these levels strict subsets of the json hierar

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/ --- (Updated May 29, 2015, 4:47 p.m.) Review request for mesos, Adam B, Joerg Schad

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

> On May 13, 2015, 9:19 a.m., Adam B wrote: > > src/master/http.cpp, line 322 > > > > > > What about completed frameworks? Should they use this endpoint too, or > > would they get their own? Right now we would like

Re: Review Request 34545: Updated the allocator related docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34545/#review85716 --- Patch looks great! Reviews applied: [34545] All tests passed. - M

Re: Review Request 34703: Added stream manipulators for the Time object.

> On May 28, 2015, 5:49 a.m., Nikita Vetoshkin wrote: > > 3rdparty/libprocess/include/process/time.hpp, line 109 > > > > > > Can I add one more nitpick? If we make `WEEK_DAYS` and `MONTHS` > > `static` then will put o

Re: Review Request 34703: Added stream manipulators for the Time object.

> On May 28, 2015, 7:49 a.m., Nikita Vetoshkin wrote: > > 3rdparty/libprocess/include/process/time.hpp, line 109 > > > > > > Can I add one more nitpick? If we make `WEEK_DAYS` and `MONTHS` > > `static` then will put o

Re: Review Request 34703: Added stream manipulators for the Time object.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34703/ --- (Updated May 29, 2015, 2:59 p.m.) Review request for mesos, Bernd Mathiske, Mic

Re: Review Request 34545: Updated the allocator related docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34545/ --- (Updated May 29, 2015, 12:48 p.m.) Review request for mesos, Adam B, Bernd Math

Re: Review Request 34545: Updated the allocator related docs.

> On May 29, 2015, 9:01 a.m., Adam B wrote: > > docs/allocation-module.md, line 7 > > > > > > technically, the "default" is "hierarchical DRF" (role, then framework). Indeed, good point! > On May 29, 2015, 9:01 a.m.,

Re: Review Request 34545: Updated the allocator related docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34545/#review85704 --- Patch looks great! Reviews applied: [34545] All tests passed. - M

Re: Review Request 34545: Updated the allocator related docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34545/#review85693 --- Looks good. Just some wording suggestions. docs/allocation-module.

Re: Review Request 34655: Use relative url in /help generated links point

> On May 28, 2015, 10:40 a.m., Adam B wrote: > > Do you clearly understand why this change is needed? I didn't understand > > after just reading the JIRA, and had to ask the reporter(s). Mesosphere is > > hosting the Mesos UI(s) underneath the DCOS UI behind a reverse proxy, so > > that `http: