Re: Review Request 50123: Added GPU scheduler for docker containerizer.

> On 七月 27, 2016, 2:15 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 1333 > > > > > > 1) s/allocator.get().allocate(requested)/allocator->allocate(requested) > > > > 2) I think it

Re: Review Request 50482: Fixed the CORS error when redirect in WEB UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50482/ --- (Updated July 29, 2016, 4:35 a.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 50482: Fixed the CORS error when redirect in WEB UI.

> On July 27, 2016, 11:32 p.m., Vinod Kone wrote: > > src/webui/master/static/js/controllers.js, line 60 > > > > > > why is this scope.state instead of scope.data? In the previous code, we didn't use JSONP, so the

Re: Review Request 50482: Fixed the CORS error when redirect in WEB UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50482/ --- (Updated July 29, 2016, 4:24 a.m.) Review request for mesos, Adam B, Jie Yu,

Review Request 50593: Added `URL::isRelative` to check if the URL is relative.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50593/ --- Review request for mesos, Adam B, Benjamin Mahler, Jie Yu, Michael Lunøe, Vinod

Re: Review Request 50488: Fixed the incomplete redirect url in `Master::Http::redirect`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50488/ --- (Updated July 29, 2016, 4:07 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/#review144048 --- I would suggest you take a look at

Review Request 50592: Updated NvidiaVolume to mount as 'tmpfs' if parent fs is 'noexec'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50592/ --- Review request for mesos, Benjamin Mahler and Jie Yu. Bugs: MESOS-5923

Re: Review Request 50205: Enhanced benchmark test for resources to include shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50205/#review144047 --- src/tests/resources_tests.cpp (lines 2480 - 2487)

Re: Review Request 50568: Updated -=/+= to subtract/add for resource object.

> On 七月 28, 2016, 11:13 p.m., Benjamin Mahler wrote: > > src/common/resources.cpp, line 458 > > > > > > Hm.. why isn't this just: > > > > ``` > > result.add(resource); > > ``` Sorry, I missed this

Re: Review Request 50568: Updated -=/+= to subtract/add for resource object.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50568/ --- (Updated 七月 29, 2016, 1:34 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45959/#review143997 --- This is done before the you rebased but it should be

Re: Review Request 50324: Added script to build mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50324/#review144030 --- Ship it! src/cli/CMakeLists.txt (line 22)

Re: Review Request 50323: Added build script for mesos-local executable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50323/#review144016 --- Ship it! LGTM! src/local/CMakeLists.txt (lines 20 - 22)

Re: Review Request 50477: Fixed use-after-close bug when using libevent and SSL.

> On July 27, 2016, 1:31 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/libevent_ssl_socket.cpp, lines 106-110 > > > > > > This comment still seems relevant. > > Benjamin Mahler wrote: > Yeah, it's still

Re: Review Request 50477: Fixed use-after-close bug when using libevent and SSL.

> On July 27, 2016, 8:31 p.m., Joseph Wu wrote: > > LGTM + some comment tweaks. > > > > This review is almost a revert of this patch: > > https://github.com/apache/mesos/commit/ca3667f4e97e11ad30811753fdb52bc02854113f > > You may want to reference that commit and/or the reasoning behind it.

Re: Review Request 50477: Fixed use-after-close bug when using libevent and SSL.

> On July 27, 2016, 8:33 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/libevent_ssl_socket.cpp, line 508 > > > > > > why `s` vs `get()`? I didn't think of using get() at the time. Looking at it now,

Re: Review Request 49616: Add suppression benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/#review144029 --- src/tests/hierarchical_allocator_tests.cpp (line 3878)

Re: Review Request 50568: Updated -=/+= to subtract/add for resource object.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50568/#review144028 --- Fix it, then Ship it! src/common/resources.cpp (line 458)

Re: Review Request 50179: Added mesos-logrotate-logger utility executable.

> On July 28, 2016, 3:12 p.m., Joseph Wu wrote: > > A few minor nits. I can fix before committing. Oh, and I will disable this target on Windows for now. The implementation currently includes some non-Windows headers. - Joseph ---

Re: Review Request 50382: Added number of filtered offers to allocator benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50382/#review144024 --- Ship it! src/tests/hierarchical_allocator_tests.cpp (line

Re: Review Request 50374: Used `size_t` as the type of "size", "count" and "index".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50374/#review144023 --- Ship it! Ship It! - Benjamin Mahler On July 23, 2016, 9:54

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/#review143893 --- src/master/master.cpp (line 3936)

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated July 28, 2016, 10:46 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated July 28, 2016, 10:44 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

> On July 26, 2016, 4:06 p.m., Jiang Yan Xu wrote: > > src/master/master.hpp, lines 817-822 > > > > > > As commented below, I realized that we may not need this. We shouldn't > > calculate total task resources as

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/ --- (Updated July 28, 2016, 10:43 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45959/ --- (Updated July 28, 2016, 10:42 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 48616: Add v1 changes for shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48616/ --- (Updated July 28, 2016, 10:42 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 50064: Added setns and active user test binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50064/#review144011 --- Ship it! LGTM! src/tests/CMakeLists.txt (line 26)

Re: Review Request 40512: Libprocess Reinit: Add a test-only method to reinitialize libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40512/#review143993 --- 3rdparty/libprocess/src/process.cpp (line 871)

Re: Review Request 49616: Add suppression benchmark.

> On July 28, 2016, 4:02 p.m., Jiang Yan Xu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3813 > > > > > > The asymmetry between the string typed `agentTotal` and the `Resources` > > typed

Re: Review Request 49616: Add suppression benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/ --- (Updated July 28, 2016, 8:42 p.m.) Review request for mesos, James Peach,

Re: Review Request 40268: Libprocess Reinit: Change Socket::DEFAULT_KIND to a non-static value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40268/#review143989 --- 3rdparty/libprocess/src/socket.cpp (line 108)

Re: Review Request 50205: Enhanced benchmark test for resources to include shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50205/#review143974 --- Ship it! BTW the method `static vector parameters()` should

Re: Review Request 40413: Libprocess Reinit: Move ReaperProcess instantiation into process.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40413/#review143875 --- 3rdparty/libprocess/include/process/reap.hpp (line 22)

Review Request 50582: Fixed OsTest.User failure due to unsorted gids returned by getgrouplist.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50582/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Kapil Arya, and Timothy

Review Request 50580: Removed unused user variable in filesystem linux isolator prepare.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50580/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Timothy Chen, and Jiang

Review Request 50581: Added logs for pre-exec commands to sandbox in MesosContainerizerLaunch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50581/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.

Re: Review Request 50216: Updated filesystem linux isolator pre exec commands to be non-shell.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50216/ --- (Updated July 28, 2016, 12:39 p.m.) Review request for mesos, Artem

Re: Review Request 50570: Mesos-slave --help should not return as failed.

> On juil. 28, 2016, 5:09 après-midi, Greg Mann wrote: > > src/slave/main.cpp, lines 192-195 > > > > > > Perhaps we could move this block above the `load.isError()` check, > > rather than adding the additional

Re: Review Request 50570: Mesos-slave --help should not return as failed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50570/ --- (Updated juil. 28, 2016, 5:24 après-midi) Review request for mesos and Greg

Re: Review Request 50570: Mesos-slave --help should not return as failed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50570/#review143949 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 49852: Implemented `NetClsSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49852/#review143943 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp

Re: Review Request 50552: Fixed a typo in cgroups.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50552/#review143945 --- Ship it! Ship It! - Gilbert Song On July 27, 2016, 11:58

Review Request 50570: Mesos-slave --help should not return as failed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50570/ --- Review request for mesos. Repository: mesos Description --- Doing a

Re: Review Request 50568: Updated -=/+= to subtract/add for resource object.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50568/#review143942 --- Patch looks great! Reviews applied: [50380, 50551, 50553, 50556,

Re: Review Request 49852: Implemented `NetClsSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49852/#review143933 --- Fix it, then Ship it!

Review Request 50568: Updated -=/+= to subtract/add for resource object.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50568/ --- Review request for mesos, Benjamin Mahler, Joris Van Remoortere, and Klaus Ma.

Re: Review Request 50422: Future-proofed some slave removal tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50422/#review143929 --- Patch looks great! Reviews applied: [50235, 50416, 50417, 50418,

Re: Review Request 50557: Used `add` instead of `+=` for `Resources::filter`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50557/#review143918 --- Patch looks great! Reviews applied: [50380, 50551, 50553, 50556,

Re: Review Request 50235: Added more expectations to TASK_LOST test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50235/ --- (Updated July 28, 2016, 11:04 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50422: Future-proofed some slave removal tests.

> On July 27, 2016, 11:54 p.m., Vinod Kone wrote: > > src/tests/slave_tests.cpp, line 2428 > > > > > > Are you sure pausing the clock at the beginning is safe? IIRC, the > > scheduler driver does reliable

Re: Review Request 50422: Future-proofed some slave removal tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50422/#review143910 --- src/tests/slave_tests.cpp (line 2564)

Re: Review Request 50422: Future-proofed some slave removal tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50422/ --- (Updated July 28, 2016, 10:14 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50417: Improved consistency of test code for partitioning an agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50417/ --- (Updated July 28, 2016, 9:42 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 50417: Improved consistency of test code for partitioning an agent.

> On July 27, 2016, 11:44 p.m., Vinod Kone wrote: > > I'm assuming the `Clock::settle()` is no longer necessary because `AWAIT_*` > > does Clock::settle() implicitly? Can you add the reason in the description > > for posterity? > > > > Also, I'm guessing you ran these tests in a loop to check

Re: Review Request 50553: Used `subtract` instead of `-=` for `Resources::contains`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50553/ --- (Updated 七月 28, 2016, 9:30 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50557: Used `add` instead of `+=` for `Resources::filter`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50557/ --- (Updated 七月 28, 2016, 9:29 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50552: Fixed a typo in cgroups.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50552/#review143911 --- Patch looks great! Reviews applied: [50552] Passed command:

Re: Review Request 50235: Added more expectations to TASK_LOST test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50235/ --- (Updated July 28, 2016, 9:06 a.m.) Review request for mesos and Vinod Kone.

Review Request 50557: Used `add` instead of `+=` for `Resources::filter`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50557/ --- Review request for mesos, Benjamin Mahler, Joris Van Remoortere, and Klaus Ma.

Re: Review Request 50553: Used `subtract` instead of `-=` for `Resources::contains`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50553/ --- (Updated 七月 28, 2016, 8:51 a.m.) Review request for mesos, Benjamin Mahler,

Review Request 50556: Added benchmark test for `Resources::nonRevocable`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50556/ --- Review request for mesos, Benjamin Mahler, Joris Van Remoortere, and Klaus Ma.

Re: Review Request 49851: Implemented `MemorySubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/#review143903 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp

Re: Review Request 50398: Added libz to Ubuntu build dependencies.

> On July 28, 2016, 12:01 a.m., Vinod Kone wrote: > > docs/getting-started.md, line 50 > > > > > > what's libz needed for? we don't seem to install it in our docker > > builds?

Review Request 50553: Used `subtract` instead of `-=` for `Resources::contains`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50553/ --- Review request for mesos, Benjamin Mahler, Joris Van Remoortere, and Klaus Ma.

Re: Review Request 50552: Fixed a typo in cgroups.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50552/#review143894 --- Ship it! Ship It! - haosdent huang On July 28, 2016, 6:58

Re: Review Request 50499: Added logic in master/main.cpp to use log network module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50499/#review143899 --- Patch looks great! Reviews applied: [50490, 50491, 50492, 50493,

Re: Review Request 50552: Fixed a typo in cgroups.hpp.

> On July 28, 2016, 7 a.m., haosdent huang wrote: > > Ship It! Thank you for correting the typo! - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50552/#review143894

Re: Review Request 49814: Implemented `CgroupsIsolatorProcess::create`.

> On July 24, 2016, 5:50 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 78-84 > > > > > > I just realize that the old `cgroups/cpu` isolator actually handles two > >

Re: Review Request 49814: Implemented `CgroupsIsolatorProcess::create`.

> On July 25, 2016, 1:50 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 78-84 > > > > > > I just realize that the old `cgroups/cpu` isolator actually handles two > >

Review Request 50552: Fixed a typo in cgroups.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50552/ --- Review request for mesos, haosdent huang and Jie Yu. Repository: mesos

Review Request 50551: Added benchmark test for `Resources::contains`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50551/ --- Review request for mesos, Benjamin Mahler and Klaus Ma. Bugs: MESOS-5700

Re: Review Request 49849: Implemented `CpuSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49849/#review143892 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp