Review Request 52623: Replaced POSIX `int` with `FileDesc` abstraction in `src` folder. On POSIX this should have no effect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52623/ --- Review request for mesos, Joseph Wu and Michael Park. Repository: mesos

Re: Review Request 52545: Replaced POSIX `int` with `FileDesc` abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52545/ --- (Updated Oct. 7, 2016, 5:45 a.m.) Review request for mesos, Joseph Wu and

Review Request 52624: Replaced POSIX `int` with `FileDesc` abstraction in `src` folder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52624/ --- Review request for mesos, Joseph Wu and Michael Park. Repository: mesos

Re: Review Request 52347: Send last `TaskStatus` in `TaskUpdated`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52347/ --- (Updated Oct. 7, 2016, 5:19 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 51774: Added `AGENT_ADDED` and `AGENT_REMOVED` master events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51774/#review151726 --- Fix it, then Ship it! I would fix these while committing.

Re: Review Request 52615: Store terminated containers in the test containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52615/#review151749 --- Ship it! LGTM - Anand Mazumdar On Oct. 6, 2016, 7:38 p.m.,

Re: Review Request 52574: Parameterized the image volume tests for nested containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52574/#review151734 --- Ship it! Smart changes, but just a little harder for people

Re: Review Request 52563: Minor clean ups in `health_check_tests.cpp` for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52563/#review151732 --- Patch looks great! Reviews applied: [52250, 52251, 52560, 52561,

Review Request 52620: Updated InverseOffers* maintenance tests to use the new scheduler mock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52620/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-4948

Re: Review Request 52539: Refactored and simplified LinuxFilesystemIsolatorTests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52539/#review151727 --- Ship it! Ship It! - Gilbert Song On Oct. 4, 2016, 6:15

Re: Review Request 52347: Send last `TaskStatus` in `TaskUpdated`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52347/ --- (Updated Oct. 6, 2016, 9:52 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 52617: Improved symmetry of code in related utility functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52617/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Review Request 52618: Added comment describing a common gotcha.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52618/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-6231

Review Request 52616: Fixed whitespace infelicities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52616/ --- Review request for mesos and Joseph Wu. Repository: mesos Description

Re: Review Request 52608: Reordered the list of executor env variables in code and documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52608/#review151723 --- Patch looks great! Reviews applied: [52556, 52608] Passed

Re: Review Request 52539: Refactored and simplified LinuxFilesystemIsolatorTests.

> On Oct. 6, 2016, 7:45 p.m., Gilbert Song wrote: > > src/tests/containerizer/filesystem_isolator_tests.cpp, line 230 > > > > > > Use `const` if sounds good to you. I just make things consistent. If we want to use

Re: Review Request 52539: Refactored and simplified LinuxFilesystemIsolatorTests.

> On Oct. 6, 2016, 7:45 p.m., Gilbert Song wrote: > > src/tests/containerizer/filesystem_isolator_tests.cpp, line 115 > > > > > > This is my main concern on this patch. We bundle the `filesystem/linux` > > isolator

Re: Review Request 52573: Removed some redundant cleanup code in linux filesystem isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52573/#review151718 --- Ship it! Ship It! - Gilbert Song On Oct. 5, 2016, 2:15

Re: Review Request 52572: Used unmountAll to replace the original shell script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52572/#review151717 --- Ship it! Ship It! - Gilbert Song On Oct. 5, 2016, 2:15

Re: Review Request 52546: Moved a few test helpers to the common header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52546/#review151716 --- Ship it! Ship It! - Gilbert Song On Oct. 4, 2016, 11:07

Re: Review Request 51774: Added `AGENT_ADDED` and `AGENT_REMOVED` master events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51774/ --- (Updated Oct. 6, 2016, 8:17 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52587: Allow CREATE of shared volumes based on capability of framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52587/ --- (Updated Oct. 6, 2016, 8:16 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52516: Added test for `AGENT_ADDED` and `AGENT_REMOVED` events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52516/ --- (Updated Oct. 6, 2016, 8:11 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52515: Implemented `AGENT_ADDED` and `AGENT_REMOVED` events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52515/ --- (Updated Oct. 6, 2016, 8:11 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52584: Created helper function `createAgentResponse`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52584/ --- (Updated Oct. 6, 2016, 8:10 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 52539: Refactored and simplified LinuxFilesystemIsolatorTests.

> On Oct. 6, 2016, 12:45 p.m., Gilbert Song wrote: > > src/tests/containerizer/filesystem_isolator_tests.cpp, lines 199-219 > > > > > > Consider a followup patch to move this to tests/mesos.hpp? Just see it in your

Re: Review Request 52539: Refactored and simplified LinuxFilesystemIsolatorTests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52539/#review151706 --- src/tests/containerizer/filesystem_isolator_tests.cpp

Review Request 52615: Store terminated containers in the test containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52615/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-6319

Re: Review Request 52347: Send last `TaskStatus` in `TaskUpdated`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52347/#review151696 --- include/mesos/master/master.proto (line 465)

Re: Review Request 52538: Reordered filesystem isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52538/#review151703 --- Ship it! Ship It! - Gilbert Song On Oct. 4, 2016, 6:15

Re: Review Request 51774: Add `AGENT_ADDED` and `AGENT_REMOVED` master events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51774/#review151691 --- include/mesos/master/master.proto (line 482)

Review Request 52612: Added nested container tests for docker runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52612/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, and

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- (Updated Oct. 6, 2016, 6:28 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52288: Recover resources when offer is rescinded on DESTROY of shared volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52288/#review151635 --- src/tests/persistent_volume_tests.cpp (line 1005)

Re: Review Request 52584: Create helper function `createAgentResponse`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52584/#review151690 --- Ship it! Ship It! - Anand Mazumdar On Oct. 5, 2016, 11:46

Re: Review Request 52515: Implement `AGENT_ADDED` and `AGENT_REMOVED` events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52515/#review151681 --- Fix it, then Ship it! src/master/http.cpp (line 2303)

Re: Review Request 52563: Minor clean ups in `health_check_tests.cpp` for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52563/ --- (Updated Oct. 6, 2016, 5:26 p.m.) Review request for mesos, Alexander

Re: Review Request 52516: Add test for `AGENT_ADDED` and `AGENT_REMOVED` events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52516/#review151679 --- Fix it, then Ship it! src/tests/api_tests.cpp (lines 1416 -

Review Request 52608: Reordered the list of executor env variables in code and documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52608/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, and Jiang Yan Xu.

Re: Review Request 52556: Added the MESOS_RUNTIME_DIRECTORY executor env variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52556/ --- (Updated Oct. 6, 2016, 4:28 p.m.) Review request for mesos, Alexander

Re: Review Request 51700: Add `FrameworkAdded` event to master event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51700/#review151666 --- src/master/http.cpp (line 1401)

Re: Review Request 52560: Avoided temporary `MockDocker` pointers in health check test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52560/#review151664 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 5, 2016,

Re: Review Request 52604: Removed flags::Flags helper template.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52604/#review151661 --- Ship it! Ship It! - Michael Park On Oct. 6, 2016, 2:58

Re: Review Request 52390: Fully qualified addresses of Flag members in add calls in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52390/ --- (Updated Oct. 6, 2016, 5:06 p.m.) Review request for mesos. Changes ---

Re: Review Request 52516: Add test for `AGENT_ADDED` and `AGENT_REMOVED` events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52516/#review151653 --- src/tests/api_tests.cpp (line 1486)

Re: Review Request 46825: Fully-typed all FlagsBase::add overloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46825/ --- (Updated Oct. 6, 2016, 4:59 p.m.) Review request for mesos, Alexander

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46824/ --- (Updated Oct. 6, 2016, 4:59 p.m.) Review request for mesos, Alexander

Re: Review Request 46823: Fully qualified addresses of Flag members in add calls in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46823/ --- (Updated Oct. 6, 2016, 4:59 p.m.) Review request for mesos, Alexander

Re: Review Request 49829: Consistently used virtual inheritance for Flags classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49829/ --- (Updated Oct. 6, 2016, 4:58 p.m.) Review request for mesos and Michael Park.

Re: Review Request 52387: Consistently used virtual inheritance for Flags classes in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52387/ --- (Updated Oct. 6, 2016, 4:58 p.m.) Review request for mesos and Michael Park.

Re: Review Request 49833: Consistently used virtual inheritance for Flags classes in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49833/ --- (Updated Oct. 6, 2016, 4:58 p.m.) Review request for mesos and Michael Park.

Re: Review Request 52515: Implement `AGENT_ADDED` and `AGENT_REMOVED` events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52515/#review151652 --- Ship it! Ship It! - haosdent huang On Oct. 5, 2016, 11:47

Re: Review Request 50380: Added new benchmark test for port resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50380/ --- (Updated 十月 6, 2016, 2:56 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52081: Reorganized includes in containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52081/ --- (Updated Oct. 6, 2016, 4:28 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Oct. 6, 2016, 4:28 p.m.) Review request for mesos, Jay Guo and Jie

Re: Review Request 52561: Renamed `flags` to `agentFlags` in health check test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52561/#review151646 --- Ship it! Ship It! - Gastón Kleiman On Oct. 5, 2016, 6:11

Re: Review Request 52560: Avoided temporary `MockDocker` pointers in health check test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52560/#review151645 --- Ship it! Ship It! - Gastón Kleiman On Oct. 5, 2016, 6:11

Re: Review Request 52563: Minor clean ups in `health_check_tests.cpp` for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52563/#review151644 --- Fix it, then Ship it! Thanks for the cleanup! I suggested an

Review Request 52599: Fixed a typo for resources benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52599/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 50551: Added benchmark test for `Resources::contains`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50551/ --- (Updated 十月 6, 2016, 9:30 a.m.) Review request for mesos, Benjamin Mahler,

Review Request 52596: Added special case when sorting hierarchically in MountInfoTable::read.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52596/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6118