Re: Review Request 52787: Set `runtime_dir` to a temporary folder in `mesos-local`.

> On Oct. 13, 2016, 5:48 a.m., Kevin Klues wrote: > > I should have looked at this more carefully before giving it a Ship it. It > > seemed reasonable at first glance though. > > > > Did you attempt to compile it before posting the patch? Looks like there > > were errors with the flags definit

Re: Review Request 52787: Set `runtime_dir` to a temporary folder in `mesos-local`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52787/ --- (Updated Oct. 13, 2016, 6:44 a.m.) Review request for mesos, Jie Yu and Kevin K

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52471/ --- (Updated Oct. 13, 2016, 6:37 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 52664: Moved the `decimalFloat` filter to app.js for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52664/ --- (Updated Oct. 13, 2016, 6:37 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 52520: Exposed the executor's type in the endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52520/ --- (Updated Oct. 13, 2016, 6:36 a.m.) Review request for mesos, Anand Mazumdar and

Review Request 52817: Added utils method to check if `ExecutorInfo` different.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52817/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-6283 h

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/ --- (Updated Oct. 13, 2016, 6:36 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 52803: Changed agent to send TASK_GONE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52803/#review152458 --- Patch looks great! Reviews applied: [50235, 50416, 50417, 50418,

Re: Review Request 51009: Collect throttle related cpu.stat for Docker Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51009/#review152456 --- Ship it! Ship It! - Jie Yu On Oct. 12, 2016, 5 p.m., Zhitao

Re: Review Request 52787: Set `runtime_dir` to a temporary folder in `mesos-local`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52787/#review152455 --- I should have looked at this more carefully before giving it a Shi

Re: Review Request 52811: Updated 'MountInfoTableReadSorted' test to use a hashset.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52811/#review152454 --- Ship it! Ship It! - Jie Yu On Oct. 12, 2016, 11:12 p.m., Kev

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

> On Oct. 7, 2016, 5:49 p.m., Greg Mann wrote: > > src/slave/containerizer/mesos/isolators/filesystem/posix.hpp, line 55 > > > > > > If you end up removing the check for persistent volumes in this > > function per Y

Re: Review Request 45967: Added documentation for shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/ --- (Updated Oct. 13, 2016, 5:25 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated Oct. 13, 2016, 5:24 a.m.) Review request for mesos, Greg Mann and Jian

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

> On Oct. 7, 2016, 4:49 p.m., Jiang Yan Xu wrote: > > src/master/validation.hpp, lines 72-74 > > > > > > Not quite sure what `isTaskContext` is? We want to make sure persistent volumes when CREATEd have a mode as `R

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated Oct. 13, 2016, 5:24 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52810: Added tests to test usernamespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52810/#review152449 --- Bad patch! Reviews applied: [52810, 52809] Failed command: ./sup

Review Request 52814: Added notes to the getting started and upgrade docs about --runtime_dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52814/ --- Review request for mesos, Alexander Rukletsov, Jie Yu, Till Toenshoff, and Vinod

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/#review152438 --- src/slave/slave.cpp (line 4219)

Re: Review Request 51617: Added the `remove` and `insert` methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51617/#review152435 --- Patch looks great! Reviews applied: [51736, 51737, 51740, 51767,

Re: Review Request 52755: Made default executor handle shutdown events while disconnected.

> On Oct. 12, 2016, 10:52 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp, line 700 > > > > > > can you add a comment on how this can happen when we are in `CONNECTED` > > state? it's not obvious to me

Re: Review Request 52756: Invoke the shutdown executor callback for checkpointed frameworks.

> On Oct. 12, 2016, 10:56 p.m., Vinod Kone wrote: > > src/executor/executor.cpp, line 734 > > > > > > I think this should call `_shutdown()` to ensure ShutdownProcess is > > spawned whenever we want to shutdown. >

Re: Review Request 52755: Made default executor handle shutdown events while disconnected.

> On Oct. 12, 2016, 10:52 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp, line 700 > > > > > > can you add a comment on how this can happen when we are in `CONNECTED` > > state? it's not obvious to me

Re: Review Request 52756: Invoke the shutdown executor callback for checkpointed frameworks.

> On Oct. 12, 2016, 10:56 p.m., Vinod Kone wrote: > > src/executor/executor.cpp, line 734 > > > > > > I think this should call `_shutdown()` to ensure ShutdownProcess is > > spawned whenever we want to shutdown. T

Re: Review Request 52569: Updated the nested container launch to correctly determine the user.

> On Oct. 12, 2016, 6:46 p.m., Gilbert Song wrote: > > src/slave/http.cpp, lines 1964-1965 > > > > > > Would you mind removing this `TODO`? They are no longer valid. > > Gilbert Song wrote: > I will follow up w

Re: Review Request 51620: Removed two std::move in MountInfoTable::read.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51620/#review152427 --- src/linux/fs.cpp (line 145)

Re: Review Request 52706: Updated mesos containerizer to use new 'stout/wait.hpp' header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52706/ --- (Updated Oct. 13, 2016, 12:08 a.m.) Review request for mesos and Jie Yu. Chan

Re: Review Request 52705: Added 'stout/wait.hpp' header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52705/ --- (Updated Oct. 13, 2016, 12:08 a.m.) Review request for mesos and Jie Yu. Chan

Re: Review Request 52705: Added 'stout/wait.hpp' header.

> On Oct. 11, 2016, 8:48 p.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/wait.hpp, line 17 > > > > > > How much work is it to do this now? If we're going to have a dedicated > > header, I would greatly pre

Re: Review Request 52705: Added 'stout/wait.hpp' header.

> On Oct. 11, 2016, 8:48 p.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/wait.hpp, line 28 > > > > > > I've been out of the game awhile-- are we wrapping comments at 70 > > characters these days? I typica

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

> On Oct. 7, 2016, 5:20 p.m., Greg Mann wrote: > > Given how similar the code in the new example framework is to the existing > > persistent volumes framework, I think it could make sense to add shared > > volume features to the existing framework, which could be enabled/disabled > > via comma

Re: Review Request 45967: Added documentation for shareable resources.

> On Oct. 12, 2016, 4:13 p.m., Jiang Yan Xu wrote: > > docs/shared-resources.md, line 175 > > > > > > We can add a section for things that aren't in the doc for regular > > persistent volumes. i.e., > > > >

Re: Review Request 45967: Added documentation for shareable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/#review152236 --- High-level comments: 1. We should tailor this towards the users/o

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/#review152415 --- Patch looks great! Reviews applied: [51052] Passed command: expo

Review Request 52811: Updated 'MountInfoTableReadSorted' test to use a hashset.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52811/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6118 https://issues.apache

Re: Review Request 52703: Added test to test corner cases with sorted 'MountInfoTable::read()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52703/ --- (Updated Oct. 12, 2016, 11:11 p.m.) Review request for mesos and Jie Yu. Chan

Re: Review Request 52704: Refactored 'MountInfoTable::read()' into two separate functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52704/ --- (Updated Oct. 12, 2016, 11:10 p.m.) Review request for mesos and Jie Yu. Chan

Re: Review Request 52596: Added special case when sorting hierarchically in MountInfoTable::read.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52596/ --- (Updated Oct. 12, 2016, 11:09 p.m.) Review request for mesos and Jie Yu. Chan

Re: Review Request 52597: Added more detailed error message when failing in MountInfoTable::read.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52597/ --- (Updated Oct. 12, 2016, 11:05 p.m.) Review request for mesos and Jie Yu. Chan

Review Request 52810: Added tests to test usernamespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52810/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos Descript

Review Request 52809: User Namespace implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52809/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos Descript

Re: Review Request 52809: User Namespace implementation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52809/ --- (Updated Oct. 12, 2016, 11:01 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 52755: Made default executor handle shutdown events while disconnected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52755/#review152413 --- Fix it, then Ship it! src/launcher/default_executor.cpp (line

Re: Review Request 52756: Invoke the shutdown executor callback for checkpointed frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52756/#review152414 --- src/executor/executor.cpp (line 731)

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/#review152410 --- include/mesos/mesos.proto

Re: Review Request 52787: Set `runtime_dir` to a temporary folder in `mesos-local`.

> On Oct. 12, 2016, 10:10 p.m., Kevin Klues wrote: > > Ship It! Can you link this to the proper JIRA? - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52787/#review152408 -

Re: Review Request 52787: Set `runtime_dir` to a temporary folder in `mesos-local`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52787/#review152408 --- Ship it! Ship It! - Kevin Klues On Oct. 12, 2016, 4:13 p.m.,

Re: Review Request 52412: Supported logger with nested containers in Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52412/#review152406 --- Ship it! Ship It! - Joseph Wu On Oct. 12, 2016, 2:06 p.m., G

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- (Updated Oct. 12, 2016, 9:38 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/#review152404 --- src/master/validation.cpp (line 1115)

Re: Review Request 40512: Libprocess Reinit: Add a test-only method to reinitialize libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40512/ --- (Updated Oct. 12, 2016, 2:25 p.m.) Review request for mesos, Greg Mann, Artem H

Re: Review Request 40411: Libprocess Reinit: Modify test to use PID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40411/ --- (Updated Oct. 12, 2016, 2:25 p.m.) Review request for mesos, Greg Mann, Artem H

Re: Review Request 51049: Libprocess Reinit: Removed authorizer callback leaks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51049/ --- (Updated Oct. 12, 2016, 2:25 p.m.) Review request for mesos, Greg Mann, Artem H

Re: Review Request 50621: Libprocess reinit: Moved HttpProxy finalization and destruction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50621/ --- (Updated Oct. 12, 2016, 2:25 p.m.) Review request for mesos, Greg Mann, Artem H

Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40410/ --- (Updated Oct. 12, 2016, 2:25 p.m.) Review request for mesos, Greg Mann, Artem H

Re: Review Request 40413: Libprocess Reinit: Move ReaperProcess instantiation into process.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40413/ --- (Updated Oct. 12, 2016, 2:25 p.m.) Review request for mesos, Greg Mann, Artem H

Re: Review Request 52412: Supported logger with nested containers in Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52412/ --- (Updated Oct. 12, 2016, 2:06 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 51617: Added the `remove` and `insert` methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51617/ --- (Updated Oct. 12, 2016, 8:55 p.m.) Review request for mesos, Jie Yu and Qian Zh

Re: Review Request 51486: Added `execute` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51486/ --- (Updated Oct. 12, 2016, 8:55 p.m.) Review request for mesos, Jie Yu and Qian Zh

Re: Review Request 51769: Implemented `delegate` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51769/ --- (Updated Oct. 12, 2016, 8:54 p.m.) Review request for mesos, Jie Yu and Qian Zh

Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40266/ --- (Updated Oct. 12, 2016, 1:48 p.m.) Review request for mesos, Greg Mann, Artem H

Re: Review Request 52746: Changed agent to send TASK_DROPPED for task launch failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52746/ --- (Updated Oct. 12, 2016, 7:35 p.m.) Review request for mesos and Vinod Kone. C

Review Request 52803: Changed agent to send TASK_GONE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52803/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6332 https://issues.ap

Review Request 52802: Added a new slave metric, "tasks_gone".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52802/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6332 https://issues.ap

Review Request 52801: Changed description of TASK_GONE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52801/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6332 https://issues.ap

Re: Review Request 52740: Refactored some code into a separate function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52740/ --- (Updated Oct. 12, 2016, 7:34 p.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 52798: Windows: Implemented os::execvpe with _spawnvpe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52798/#review152382 --- Ship it! Ship It! - Jie Yu On Oct. 12, 2016, 7:20 p.m., Jose

Review Request 52798: Windows: Implemented os::execvpe with _spawnvpe.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52798/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Jie Yu

Re: Review Request 52645: Harden Mesos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/#review152381 --- src/Makefile.am (line 112)

Re: Review Request 52569: Updated the nested container launch to correctly determine the user.

> On Oct. 12, 2016, 11:46 a.m., Gilbert Song wrote: > > src/slave/http.cpp, lines 1964-1965 > > > > > > Would you mind removing this `TODO`? They are no longer valid. I will follow up with a patch. Sorry not review

Re: Review Request 52569: Updated the nested container launch to correctly determine the user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52569/#review151564 --- src/slave/http.cpp (lines 1964 - 1965)

Re: Review Request 52647: Fix new sign comparison errors produced by hardened flags

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/#review152378 --- As mentioned elsewhere, can you split stout and libprocess changes

Re: Review Request 52412: Supported logger with nested containers in Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52412/ --- (Updated Oct. 12, 2016, 11:39 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 52563: Minor clean ups in `health_check_tests.cpp` for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52563/#review152376 --- Patch looks great! Reviews applied: [52786, 52250, 52251, 52560,

Re: Review Request 52774: Added a test for verifying nested container environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52774/#review152358 --- Ship it! Ship It! - Gilbert Song On Oct. 11, 2016, 10:35 p.m

Re: Review Request 52288: Recover resources when offer is rescinded on DESTROY of shared volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52288/#review152329 --- src/tests/persistent_volume_tests.cpp (lines 1031 - 1033)

Re: Review Request 51769: Implemented `delegate` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51769/#review152348 --- src/slave/containerizer/mesos/isolators/network/cni/plugins/port_

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/ --- (Updated Oct. 12, 2016, 5:18 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52471/ --- (Updated Oct. 12, 2016, 5:18 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 52520: Exposed the executor's type in the endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52520/ --- (Updated Oct. 12, 2016, 5:18 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 52664: Moved the `decimalFloat` filter to app.js for consistency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52664/ --- (Updated Oct. 12, 2016, 5:18 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/ --- (Updated Oct. 12, 2016, 5:17 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 51768: Updated signature of `delegate` and `execute` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51768/#review152347 --- Ship it! Ship It! - Jie Yu On Sept. 28, 2016, 7:30 p.m., Avi

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/ --- (Updated Oct. 12, 2016, 5:02 p.m.) Review request for mesos, Gilbert Song, haos

Re: Review Request 51009: Collect throttle related cpu.stat for Docker Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51009/ --- (Updated Oct. 12, 2016, 5 p.m.) Review request for mesos, Xiaojian Huang, Gilbe

Re: Review Request 51740: Added the 'name' and 'args' field to the 'delegate' plugin's CNI config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51740/#review152343 --- Ship it! Ship It! - Jie Yu On Sept. 28, 2016, 7:29 p.m., Avi

Re: Review Request 51767: Added constants for CNI commands.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51767/#review152344 --- Ship it! Ship It! - Jie Yu On Sept. 28, 2016, 7:29 p.m., Avi

Re: Review Request 51737: Added `PluginError` to simplify error reporting for CNI plugins.

> On Oct. 12, 2016, 4:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/spec.hpp, line 61 > > > > > > 2 lines apart I'll fix for you - Jie

Re: Review Request 51737: Added `PluginError` to simplify error reporting for CNI plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51737/#review152336 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/

Re: Review Request 52638: Populated `recovered_agents` field in `GetAgents` response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52638/ --- (Updated Oct. 12, 2016, 4:46 p.m.) Review request for mesos, Anand Mazumdar, Xi

Re: Review Request 52638: Populated `recovered_agents` field in `GetAgents` response.

> On Oct. 10, 2016, 6:53 p.m., Anand Mazumdar wrote: > > Would you be following up with the change to `/state` in a separate review? Done. r/52765 - Zhitao --- This is an automatically generated e-mail. To reply, visit: https://reviews.

Review Request 52787: Set `runtime_dir` to a temporary folder in `mesos-local`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52787/ --- Review request for mesos, Jie Yu and Kevin Klues. Repository: mesos Descripti

Re: Review Request 52288: Recover resources when offer is rescinded on DESTROY of shared volume.

> On Oct. 12, 2016, 8:20 a.m., Jiang Yan Xu wrote: > > src/tests/persistent_volume_tests.cpp, lines 1125-1128 > > > > > > We have reduced the number of places that advance time to one, we can > > just pull the Cloc

Re: Review Request 52288: Recover resources when offer is rescinded on DESTROY of shared volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52288/#review152323 --- src/tests/persistent_volume_tests.cpp (lines 1079 - 1086)

Re: Review Request 52707: Updated CLI bootstrap to search for local virtualenv installations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52707/#review152321 --- Ship it! Ship It! - Kevin Klues On Oct. 10, 2016, 9:42 p.m.,

Re: Review Request 51715: Added a parallel gtest runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/ --- (Updated Oct. 12, 2016, 5:28 p.m.) Review request for mesos, Kevin Klues and Ti

Re: Review Request 52288: Recover resources when offer is rescinded on DESTROY of shared volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52288/#review152282 --- Ship it! Committing with these cleanups. src/tests/persistent

Re: Review Request 51715: Added a parallel gtest runner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/#review152322 --- Ship it! Ship It! - Kevin Klues On Oct. 11, 2016, 8:18 a.m.,

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/#review152315 --- 3rdparty/libprocess/Makefile.am (line 29)

Re: Review Request 52696: Harden stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/#review152316 --- 3rdparty/stout/Makefile.am (line 26)

  1   2   >