this pipe to send the request via the socket.
Diffs (updated)
-
3rdparty/libprocess/src/http.cpp b5ddac9f1970358f8232a481431507242052d294
Diff: https://reviews.apache.org/r/53489/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
--------
On Nov. 4, 2016, 5:55 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53490/
> -
533104c93dd1eaf67bf3752163d2e0cad090078d
Diff: https://reviews.apache.org/r/53490/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
/http_tests.cpp
533104c93dd1eaf67bf3752163d2e0cad090078d
Diff: https://reviews.apache.org/r/53490/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
-
On Nov. 10, 2016, 10:07 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53511/
> ---
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53365/#review155662
---
Ship it!
Ship It!
- Anand Mazumdar
On Nov. 8, 2016, 4:22
g semantically?
- Anand Mazumdar
On Nov. 8, 2016, 4:22 a.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://
533104c93dd1eaf67bf3752163d2e0cad090078d
Diff: https://reviews.apache.org/r/53490/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
(line 22)
<https://reviews.apache.org/r/53366/#comment225738>
Kill this since it's not needed anymore.
- Anand Mazumdar
On Nov. 11, 2016, 12:36 a.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically genera
mentation difference?
> > Have you explored merging them? E.g.
> >
> > ```
> > namespace internal {
> > template // We can later restrict which T's are allowed.
> > class Decoder
> > {
> > ...
> > };
> > }
> >
> > // Users only use these non-t
)
-
3rdparty/libprocess/src/decoder.hpp 76dca0b272af8591880ef220ec2dc006906fbc36
Diff: https://reviews.apache.org/r/53486/diff/
Testing
---
make check (tests are added in https://reviews.apache.org/r/53511/)
Thanks,
Anand Mazumdar
sage) {
> > if (!message.isReady()) {
> > // Handle error.
> > }
> >
> > // No longer need to care about nullptr case.
> > CHECK_NOTNULL(message.get());
> >
> > // Han
/
Testing
---
make check (Tests are added in https://reviews.apache.org/r/53490 i.e., after
we add support to the `Connection` abstraction for request streaming)
Thanks,
Anand Mazumdar
: https://reviews.apache.org/r/53490/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53680/#review155746
---
Ship it!
- Anand Mazumdar
On Nov. 11, 2016, 9 p.m., Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53654/#review156422
---
Ship it!
LGTM, thanks for the cleanup.
- Anand Mazumdar
On
(lines 1630 - 1634)
<https://reviews.apache.org/r/53825/#comment226629>
Nit: Sort them alphabetically.
- Anand Mazumdar
On Nov. 18, 2016, 8:04 a.m., Vijay Srinivasaraghavan wrote:
>
> ---
> This is an automatically genera
before committing.
- Anand Mazumdar
On Nov. 2, 2016, 5:35 a.m., Manuwela Kanade wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
ab2b5a9d38a3001d6a5daa1807fecb630c4b154d
Diff: https://reviews.apache.org/r/53487/diff/
Testing
---
make check (Tests are added in https://reviews.apache.org/r/53490 i.e., after
we add support to the `Connection` abstraction for request streaming)
Thanks,
Anand Mazumdar
://reviews.apache.org/r/53486/
Diffs (updated)
-
3rdparty/libprocess/src/decoder.hpp 76dca0b272af8591880ef220ec2dc006906fbc36
Diff: https://reviews.apache.org/r/53486/diff/
Testing
---
make check (tests are added in https://reviews.apache.org/r/53511/)
Thanks,
Anand Mazumdar
Thanks,
Anand Mazumdar
et in C++11), whereas you couldn't with the first option.
Used `Owned &&` instead.
- Anand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53487/#review156500
s.cpp 99c27399297e3b04af167029d200d8ac418af2a6
Diff: https://reviews.apache.org/r/53491/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
Diff: https://reviews.apache.org/r/53487/diff/
Testing
---
make check (Tests are added in https://reviews.apache.org/r/53490 i.e., after
we add support to the `Connection` abstraction for request streaming)
Thanks,
Anand Mazumdar
914767915d68d747a3c0e873047e527e6aedea0e
Diff: https://reviews.apache.org/r/53485/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
/53491/#review156625
---
On Nov. 22, 2016, 12:27 a.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53491/
> --
> On Nov. 20, 2016, 9:04 p.m., Anand Mazumdar wrote:
> > Nice first patch and welcome to the community!
> >
> > - Can you update the Testing Done section with details on testing?
> > - We also support Python bindings. Do you mind adding these protos to our
> >
g/r/54039/#comment227057>
Unrelated to this review, can you also make a similar change to the
scheduler/executor library for consistency.
- Anand Mazumdar
On Nov. 23, 2016, 7:20 p.m., Vinod Kone wrote:
>
> ---
> This is a
the other
decoders to correctly initialize the `settings` variable too?
- Anand Mazumdar
On Nov. 25, 2016, 11:41 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54048/#review156972
---
Ship it!
Ship It!
- Anand Mazumdar
On Nov. 26, 2016, 5:40
tps://reviews.apache.org/r/54093/#comment227350>
You might want to commit naming the `ReaderProcess` as a separate commit
since it's unrelated to this patch.
- Anand Mazumdar
On Nov. 26, 2016, 5:40 p.m., Vinod Kone wrote:
>
> ---
onnection between agent and switchboard breaks
- Anand Mazumdar
On Nov. 26, 2016, 5:41 p.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
53994/#comment227358>
This can be moved to the `api()` handler itself.
- Anand Mazumdar
On Nov. 26, 2016, 5:42 p.m., Vinod Kone wrote:
>
> ---
> This is an automatically gen
.
```
Aliased `process::http` namespace to `http` in `tests/api_tests.cpp`.
```
- Anand Mazumdar
On Nov. 26, 2016, 5:42 p.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
g/r/54039/#comment227365>
hmm, this doesn't need to be an `Owned` here. Can we just use `Reader&&
reader` instead?
We needed it to be an `Owned` in the scheduler library as we wanted to save
it as a member variable across invocations.
- Anand Mazumdar
On Nov.
> On Nov. 20, 2016, 9:04 p.m., Anand Mazumdar wrote:
> > Nice first patch and welcome to the community!
> >
> > - Can you update the Testing Done section with details on testing?
> > - We also support Python bindings. Do you mind adding these protos to our
> >
390)
<https://reviews.apache.org/r/53994/#comment227566>
Do you need to implicitly capture everything or can we be explicit here?
- Anand Mazumdar
On Nov. 28, 2016, 8:56 p.m., Vinod Kone wrote:
>
> ---
> This is an automatically genera
nerizer/mock_containerizer.hpp (lines 71 - 73)
<https://reviews.apache.org/r/53995/#comment227610>
hmm, not sure why did you need the change in this review? You don't seem to
be using the `MockContainerizer` in your test?
- Anand Mazumdar
On Nov. 28, 2016, 10:50 p.m., Vinod Ko
(line 165)
<https://reviews.apache.org/r/54039/#comment227613>
s/the future/, the future
- Anand Mazumdar
On Nov. 28, 2016, 6:48 a.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
tps://reviews.apache.org/r/53995/#comment227661>
argument by reference: `Future&`
src/tests/api_tests.cpp (line 31)
<https://reviews.apache.org/r/53995/#comment227660>
Remove this include?
- Anand Mazumdar
On Nov. 29, 2016, 5:38 a.m.,
f.
Diffs
-
src/common/http.hpp 378208be58d0cd141ff60a6d25a173f2793870dc
src/common/http.cpp 42af33094150001fa6741effb6b0aee1cde3c109
Diff: https://reviews.apache.org/r/54218/diff/
Testing
---
make check (these would be tested later in the chain)
Thanks,
Anand Mazumdar
://reviews.apache.org/r/54217/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
check (tests would be added later in the chain)
Thanks,
Anand Mazumdar
/slave/http.cpp 87189dd6e2e099cb74faabd3ad26aaca11e5cef2
src/slave/slave.hpp 05865a09724f7a46e9c06b02e59779513fc532aa
Diff: https://reviews.apache.org/r/54220/diff/
Testing
---
make check (tests would be added later in the chain)
Thanks,
Anand Mazumdar
Diff: https://reviews.apache.org/r/54221/diff/
Testing
---
make check (tests would be added soon and can't be committed without them)
Thanks,
Anand Mazumdar
make check (these would be tested later in the chain)
Thanks,
Anand Mazumdar
s (updated)
-
src/slave/http.cpp 87189dd6e2e099cb74faabd3ad26aaca11e5cef2
src/slave/slave.hpp 05865a09724f7a46e9c06b02e59779513fc532aa
Diff: https://reviews.apache.org/r/54221/diff/
Testing
---
make check (tests would be added soon and can't be committed without them)
Thanks,
Anand Mazumdar
ambdas any more since it's no longer doing "Record-IO"
as was the case previously. :-)
- Anand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54218/#review157508
--
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54193/#review157513
---
Ship it!
Ship It!
- Anand Mazumdar
On Nov. 30, 2016, 3:53
added later in the chain)
Thanks,
Anand Mazumdar
make check (these would be tested later in the chain)
Thanks,
Anand Mazumdar
87189dd6e2e099cb74faabd3ad26aaca11e5cef2
src/slave/slave.hpp 05865a09724f7a46e9c06b02e59779513fc532aa
Diff: https://reviews.apache.org/r/54221/diff/
Testing
---
make check (tests would be added soon and can't be committed without them)
Thanks,
Anand Mazumdar
nput` in
> > this patch?
+1 to the proposal except don't pass `principal` when its not needed. Some
calls might not be interested in AuthZ at all.
I did not pass `principal` since we did not have AuthZ handling for this
handler. Would add it since we know that it's alread
---
Otherwise, the test would fail when we add support to the
containerizer to support `attach()`.
Diffs
-
src/tests/api_tests.cpp b2a70f3174824d3cb241a098d96e4d63a390f8bc
Diff: https://reviews.apache.org/r/54243/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
check
Thanks,
Anand Mazumdar
ttachContainerOutput`. can we make them consistent?
>
> Anand Mazumdar wrote:
> hmm, the scenarios looked pretty different and hence I did not make them
> consistent. In the previous scenario, we had already received the `response`
> from the `Connection` object and were streamin
hanks,
Anand Mazumdar
87189dd6e2e099cb74faabd3ad26aaca11e5cef2
src/slave/slave.hpp 05865a09724f7a46e9c06b02e59779513fc532aa
Diff: https://reviews.apache.org/r/54221/diff/
Testing
---
make check (tests would be added soon and can't be committed without them)
Thanks,
Anand Mazumdar
make check (these would be tested later in the chain)
Thanks,
Anand Mazumdar
the containerizer for launching debug containers?
src/tests/api_tests.cpp (line 3679)
<https://reviews.apache.org/r/54196/#comment228243>
Use this directly in L3685. You don't need the accept header here due to
the response being `InternalServerError`.
- Anand Mazumdar
On Dec. 1, 2016,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54194/#review157632
---
Ship it!
Ship It!
- Anand Mazumdar
On Nov. 30, 2016, 3:55
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54245/#review157633
---
Ship it!
Nice cleanup!
- Anand Mazumdar
On Dec. 1, 2016, 6
5203fb308e4ba2cd7d00b1c5a96d783c966ef47b
3rdparty/libprocess/src/tests/http_tests.cpp
4a0d852e304ff50afca090571f82d0848adf1d25
Diff: https://reviews.apache.org/r/54274/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
src/tests/api_tests.cpp (line 3683)
<https://reviews.apache.org/r/54196/#comment228323>
s/callbacks/pending callbacks
- Anand Mazumdar
On Dec. 2, 2016, 4:42 a.m., Vinod Kone wrote:
>
> ---
> This is an autom
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54274/#review157704
---
On Dec. 2, 2016, 12:11 a.m., Anand Mazumdar wrote:
>
> --
bda::bind(
deserialize, contentType, lambda::_1)),
request.reader.get()));
```
- Anand Mazumdar
On Dec. 2, 2016, 6:48 a.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To rep
streaming decoder
first and then keep reviewing this. (We can't commit this anyways without tests)
- Anand Mazumdar
On Dec. 2, 2016, 6:54 a.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
che.org/r/54337/diff/
Testing
---
make check + added test
Thanks,
Anand Mazumdar
---
Fixed an attach container input test impacted by stricter validation.
Diffs
-
src/tests/api_tests.cpp afae6a7e0809174f48f280f170fad9315e80a906
Diff: https://reviews.apache.org/r/54340/diff/
Testing
---
Thanks,
Anand Mazumdar
a60d2315ae511
src/tests/api_tests.cpp afae6a7e0809174f48f280f170fad9315e80a906
Diff: https://reviews.apache.org/r/54337/diff/
Testing
---
make check + added test
Thanks,
Anand Mazumdar
8b104ce9ca6e72a1e76943f0d68a0541a45e39f6
Diff: https://reviews.apache.org/r/54342/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
eply, visit:
https://reviews.apache.org/r/54337/#review157897
---
On Dec. 3, 2016, 7:19 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically g
/slave/http.cpp 8b104ce9ca6e72a1e76943f0d68a0541a45e39f6
Diff: https://reviews.apache.org/r/54342/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
---
make check
Thanks,
Anand Mazumdar
le to combine these:
```cpp
failure = Failure("Failed writing to stdin:"
" " + (future.isFailed() ? future.failure() :
"discarded");
```
src/slave/containerizer/mesos/io/switchboard.cpp (line 1021)
<https://reviews.apache.org/r/5
/reviews.apache.org/r/54297/#comment228562>
Nice Test!
src/tests/containerizer/io_switchboard_tests.cpp (line 303)
<https://reviews.apache.org/r/54297/#comment228556>
s/only//
- Anand Mazumdar
On Dec. 4, 2016, 12:54 a.m., Kevin Klues wrote:
>
> ---
> On Dec. 3, 2016, 8:36 p.m., Anand Mazumdar wrote:
> > src/slave/containerizer/mesos/io/switchboard.cpp, line 916
> > <https://reviews.apache.org/r/54297/diff/2/?file=1575106#file1575106line916>
> >
> > hmm, this message is a bit mis-leading given that y
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54013/#review157927
---
Gilbert, can you add [~neilc] as a reviewer too?
- Anand
witchboard.cpp (lines 1044 - 1046)
<https://reviews.apache.org/r/54297/#comment228580>
Kill this and just have a `UNREACHABLE()`.
- Anand Mazumdar
On Dec. 4, 2016, 6:55 a.m., Kevin Klues wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53825/#review158010
---
Ship it!
Ship It!
- Anand Mazumdar
On Nov. 23, 2016, 5:46
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54014/#review158009
---
Ship it!
Ship It!
- Anand Mazumdar
On Nov. 23, 2016, 5:46
ily after an
upgrade.
- Anand Mazumdar
On Dec. 5, 2016, 7:09 a.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
` for other task group
related tests that have a similar wrong assumption?
I would go ahead and commit this for now.
- Anand Mazumdar
On Nov. 28, 2016, 6:32 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54133/#review158025
---
Ship it!
Ship It!
- Anand Mazumdar
On Nov. 28, 2016, 6:32
am (line 460)
<https://reviews.apache.org/r/54015/#comment228704>
Alignment of the trailing character (``) needs to be fixed.
src/Makefile.am (line 490)
<https://reviews.apache.org/r/54015/#comment228668>
Alignment of the trailing character (``) needs to be fixed.
- Anand Maz
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54077/#review158068
---
Ship it!
Ship It!
- Anand Mazumdar
On Nov. 25, 2016, 4:07
/
Testing
---
make check (A test is added later in the chain that won't pass otherwise)
Thanks,
Anand Mazumdar
---
Added a test for the 'ATTACH_CONTAINER_INPUT' call.
Diffs
-
src/tests/api_tests.cpp 6cd1f83a47731ee8c4fb1f022bf585b271b3b966
Diff: https://reviews.apache.org/r/54497/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
--------
On Dec. 7, 2016, 8:15 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54496/
> -
che.org/r/54497/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
_tests.cpp 6cd1f83a47731ee8c4fb1f022bf585b271b3b966
Diff: https://reviews.apache.org/r/54502/diff/
Testing
---
make check
Thanks,
Anand Mazumdar
Thanks,
Anand Mazumdar
his is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54497/#review158388
---
On Dec. 8, 2016, 12:39 a.m., Anand Mazumdar wrote:
>
> ---
>
ttps://reviews.apache.org/r/54281/#comment229337>
Might want to make the string themselves be "stdout"/"stderr"?
- Anand Mazumdar
On Dec. 8, 2016, 1:23 a.m., Vinod Kone wrote:
>
> ---
> Th
)
<https://reviews.apache.org/r/54508/#comment229363>
Nit: Quotes before `TTYInfo`
src/tests/api_tests.cpp (line 3862)
<https://reviews.apache.org/r/54508/#comment229364>
s/stederr/stderr
- Anand Mazumdar
On Dec. 8, 2016, 9:51 p.m., Vino
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54516/#review158765
---
Ship it!
Ship It!
- Anand Mazumdar
On Dec. 8, 2016, 9:52
this future itself fails for some
reason, the next line won't future would never be ready.
- Anand Mazumdar
On Dec. 8, 2016, 9:53 p.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54545/#review158767
---
Ship it!
Thanks for the cleanup!
- Anand Mazumdar
On Dec. 8
e.org/r/52765/#comment229722>
Let's keep the same comment here as you have on L2688 later
- Anand Mazumdar
On Nov. 2, 2016, 4:42 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
/cni_isolator_tests.cpp (lines 578 - 581)
<https://reviews.apache.org/r/54676/#comment229736>
How about just:
```cpp
TaskInfo task = createTask(offer, command);
```
- Anand Mazumdar
On Dec. 12, 2016, 9:53 p.m., Jie Yu wrote:
>
> -
801 - 900 of 1643 matches
Mail list logo
