---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47209/#review133025
---
Ship it!
Ship It!
- Ben Mahler
On May 13, 2016, 3:37 a.m
e following?
```
// Ensure there is a link to the master before we start communicating with
it.
```
- Ben Mahler
On May 12, 2016, 6:18 p.m., David Robinson wrote:
>
> ---
> This is an automatically generated e-mail. To r
)
<https://reviews.apache.org/r/46670/#comment197314>
Mind committing this bit separately? You also need duration.hpp, error.hpp,
none.hpp, stringify.hpp.
- Ben Mahler
On May 12, 2016, 10:38 p.m., Vinod Kone wrote:
>
> ---
tps://reviews.apache.org/r/46815/#comment197313>
`->` here and everywhere else
- Ben Mahler
On May 12, 2016, 10:43 p.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
(line 613)
<https://reviews.apache.org/r/46818/#comment197312>
Can you add an expectation that there are no warnings?
- Ben Mahler
On May 12, 2016, 10:42 p.m., Vinod Kone wrote:
>
> ---
> This is an automatically gener
gs/flags.hpp (lines 883 - 884)
<https://reviews.apache.org/r/46863/#comment197311>
Shouldn't this print the `name` being looped over here so that we can see
the two clashing names?
- Ben Mahler
On May 12, 2016, 10:42 p.m., Vinod Kone wrote:
>
> ---
te all of these existing tests to expect no warnings?
3rdparty/stout/tests/flags_tests.cpp (line 502)
<https://reviews.apache.org/r/46669/#comment197298>
Can you use the `->` operator here?
EXPECT?
Also can you add an expectation on the message?
- Ben Mahler
On May
--
>
> (Updated May 11, 2016, 12:58 a.m.)
>
>
> Review request for mesos, Ben Mahler, Ian Downes, and Cong Wang.
>
>
> Bugs: MESOS-5330
> https://issues.apache.org/jira/browse/MESOS-5330
>
>
> Repository: mesos
>
>
> Descrip
1488)
<https://reviews.apache.org/r/47028/#comment197044>
How about "No allocations performed"? It is a bit odd to refer to offers
here since we don't know about offers in the allocator currently.
- Ben Mahler
On May 11, 2016, 5:58 p.m
...
Connected to localhost.
Escape character is '^]'.
```
Hit the endpoints:
```
$ curl --insecure https://localhost:5050/health
```
These curl requests hangs without this fix.
Thanks,
Ben Mahler
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46325/#review132324
---
Ship it!
Modulo comments.
- Ben Mahler
On May 7, 2016, 1:03
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46491/#review132323
---
Ship it!
Modulo comments.
- Ben Mahler
On May 7, 2016, 1:02
-
3rdparty/libprocess/src/http.cpp 48f91d01555e760b1c4fd2cde684168d65f75e57
Diff: https://reviews.apache.org/r/47091/diff/
Testing
---
Removed the hack put in place within the http::get path to validate the fix.
Thanks,
Ben Mahler
context.
Diffs (updated)
-
3rdparty/libprocess/src/http.cpp 48f91d01555e760b1c4fd2cde684168d65f75e57
Diff: https://reviews.apache.org/r/47091/diff/
Testing
---
Removed the hack put in place within the http::get path to validate the fix.
Thanks,
Ben Mahler
-
3rdparty/libprocess/src/http.cpp 48f91d01555e760b1c4fd2cde684168d65f75e57
Diff: https://reviews.apache.org/r/47091/diff/
Testing
---
Removed the hack put in place within the http::get path to validate the fix.
Thanks,
Ben Mahler
9cc4acd11dba561f40c33bc9dabb35a452a80e62
3rdparty/libprocess/src/poll_socket.cpp
e68c7836b6a79253fa646c1919d0f331f21ec131
3rdparty/libprocess/src/socket.cpp ec0e913aca30f92d4a0543ad1e685b897617bca3
Diff: https://reviews.apache.org/r/47092/diff/
Testing
---
make check
Thanks,
Ben Mahler
: https://reviews.apache.org/r/47091/diff/
Testing
---
Removed the hack put in place within the http::get path to validate the fix.
Thanks,
Ben Mahler
1cda7b4ec31fcd06161925ce5788741f299217c7
Diff: https://reviews.apache.org/r/47090/diff/
Testing
---
Ran in repetition.
Thanks,
Ben Mahler
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46730/#review132098
---
Ship it!
Ship It!
- Ben Mahler
On April 29, 2016, 1:03 p.m
rs[frameworkId].keys()) {
```
- Ben Mahler
On May 4, 2016, 5:14 a.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
wondering why there are
two variables for these (that has a lot of context of the road you went down
trying to consolidate them into just the timer variable). Likely they're more
interested in what these represent.
If we cha
om above.
src/launcher/http_command_executor.cpp (lines 712 - 717)
<https://reviews.apache.org/r/46491/#comment195926>
Ditto from above.
- Ben Mahler
On May 5, 2016, 3:37 p.m., Alexander Rukletsov wrote:
>
> -
uot;terminated" to the patch that reads the
value? It's only written to in this patch AFAICT.
- Ben Mahler
On May 5, 2016, 3:37 p.m., Alexander Rukletsov wrote:
>
> ---
&g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46165/#review131593
---
Ship it!
Ship It!
- Ben Mahler
On May 3, 2016, 8:53 p.m
/include/stout/json.hpp (lines 749 - 751)
<https://reviews.apache.org/r/46945/#comment195596>
Could we avoid the 'elem' name in favor of 'element' or 'v' (full word or
single letter)?
Per our conversation, do we want to adjust the foreachpair above?
gging_unittest-logging_unittest.o] Error 1
```
Thanks,
Ben Mahler
---
This reflects the backport of MESOS-5018 to the 0.27.x branch.
Diffs
-
CHANGELOG 0c5987779e5f0e2cb416dfe885f7ba836e3958eb
Diff: https://reviews.apache.org/r/46805/diff/
Testing
---
N/A
Thanks,
Ben Mahler
ST(UserDefinedClass, logging) {
^
make[7]: *** [logging_unittest-logging_unittest.o] Error 1
```
Thanks,
Ben Mahler
---
This reflects the backport of MESOS-5021 to the 0.27.x branch.
Diffs
-
CHANGELOG 937716068c126fd76b70e08f7654a659ba1029d8
Diff: https://reviews.apache.org/r/46753/diff/
Testing
---
N/A
Thanks,
Ben Mahler
master/scheduler_calls/type/kill: 512
...
```
Also, this lets us distinguish between schedulers making calls and operators
hitting the endpoints (the current patch treats these the same). We should get
some feedback from Vinod Kone and Anand Mazumdar since they've been working on
the HTTP API.
background information
in the review description?
- Ben Mahler
On April 27, 2016, 11:44 a.m., Tomasz Janiszewski wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
PowerPC) I've gone ahead and
committed it.
The cleanup mentioned by haosdent sounds great if it removes unnecessary #ifdef
logic. Let me know when the cleanup is available!
- Ben Mahler
On April 24, 2016, 11:36 a.m., Tomasz Janiszewski
---
This reflects the backport of MESOS-4705 to the 0.28.x branch.
Diffs
-
CHANGELOG 57f5457640c9b7ca2cb7707f2962dd0421f090f7
Diff: https://reviews.apache.org/r/46663/diff/
Testing
---
N/A
Thanks,
Ben Mahler
---
This reflects the backport of MESOS-4705 to the 0.27.x branch.
Diffs
-
CHANGELOG 57f5457640c9b7ca2cb7707f2962dd0421f090f7
Diff: https://reviews.apache.org/r/46664/diff/
Testing
---
N/A
Thanks,
Ben Mahler
---
This reflects the backport of MESOS-4705 to the 0.26.x branch.
Diffs
-
CHANGELOG 57f5457640c9b7ca2cb7707f2962dd0421f090f7
Diff: https://reviews.apache.org/r/46665/diff/
Testing
---
N/A
Thanks,
Ben Mahler
nternal::normalize(tokens[2]), tokens[3]});
}
+// Bail out if the format is not recognized.
return Error("Unexpected number of fields");
}
};
```
- Ben Mahler
On April 18, 2016, 5:41 a.m., fan du wrote:
>
> ---
>
looks like a bug fix? Any reason it
is being bundled with this patch?
- Ben Mahler
On April 21, 2016, 2:28 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automa
)
<https://reviews.apache.org/r/46323/#comment193488>
const & for both of these since the rhs is not a temporary
- Ben Mahler
On April 21, 2016, 2:28 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatical
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46324/#review129463
---
Ship it!
Ship It!
- Ben Mahler
On April 18, 2016, 12:44 p.m
in the handler to check the optionality.
- Ben Mahler
On April 18, 2016, 12:44 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
overrides task_info.kill_policy.
Perhaps for now, we just explicitly state that the grace period may be
"overridden" (or "adjusted"?) in order to give more or less time to a graceful
kill that is in progress.
- Ben Mahler
On April 18, 2016, 12:43 p.m., Alexander
new enum value.
Ditto below.
- Ben Mahler
On March 25, 2016, 9:25 p.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vis
tps://reviews.apache.org/r/45317/#comment192865>
Yikes, this case isn't actually unreachable!
Per MESOS-2664 and MESOS-3754, please avoid 'default' in favor of an
explicit 'case UNKNOWN' so that the compiler helps us catch all switches when
we introduce a new enum value.
-
code from compiling when a new enum value is introduced but
not handled.
Make sense?
Ditto for the recent executor.proto and scheduler.proto changes.
- Ben Mahler
On March 29, 2016, 2:04 a.m., Yong Tang wrote:
>
> --
/master_slave_reconciliation_tests.cpp
71fb78afe6ddca061dd05cfda7bbf17d4b3ea834
Diff: https://reviews.apache.org/r/46339/diff/
Testing
---
Ran in repetition.
Thanks,
Ben Mahler
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46175/#review128790
---
Ship it!
Modulo comments from before.
- Ben Mahler
On April
tps://reviews.apache.org/r/46173/#comment192234>
Would you mind getting the quotes on the same line?
```
LOG(WARNING) << "Failed to execute slave post fetch hook for module"
<< " '" << name << "': " &l
43>
Why `docker.get()->ps` instead of `docker->ps`?
src/tests/hook_tests.cpp (line 843)
<https://reviews.apache.org/r/46175/#comment192242>
Why `docker.get()->rm` instead of `docker->rm`?
- Ben Mahler
On April 13, 2016, 10:33 p.m., Jie Yu wrote:
>
> ---
> On April 13, 2016, 9:33 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/src/process.cpp, line 559
> > <https://reviews.apache.org/r/46027/diff/2/?file=1340142#file1340142line559>
> >
> > s/. A/. A/
> >
> > Thanks for clarifying, s
)
<https://reviews.apache.org/r/46027/#comment192211>
s/. A/. A/
Thanks for clarifying, sorry for the confusion!
- Ben Mahler
On April 12, 2016, 12:23 a.m., Neil Conway wrote:
>
> ---
> This is an automatically gener
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46029/#review128748
---
Ship it!
Ship It!
- Ben Mahler
On April 12, 2016, 12:13 a.m
indeed using a temporary directory.
- Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46121/#review128578
-------
On
ated e-mail. To reply, visit:
https://reviews.apache.org/r/46121/#review128580
---
On April 12, 2016, 11:15 p.m., Ben Mahler wrote:
>
> ---
> This is an automatically generated
due to /tmp/stdout being owned by root)
Thanks,
Ben Mahler
.org/r/45932/#comment192010>
How about key1,value1 and key2,value2? I'm not sure if there's any value in
having task / executor within the names.
- Ben Mahler
On April 12, 2016, 5:03 a.m., Zhitao Li wrote:
>
> -
otobuf(createLabel("key1", "value1"))),
labels_->values[0]);
```
src/tests/oversubscription_tests.cpp (lines 230 - 231)
<https://reviews.apache.org/r/45572/#comment191949>
My suggestion for earlier was just to avoid using words like "foo" and
"bar
.
src/slave/slave.cpp (line 4972)
<https://reviews.apache.org/r/45941/#comment191911>
newline here
missing an 'i' in 'Oversubscrbable'
src/slave/slave.cpp (line 4976)
<https://reviews.apache.org/r/45941/#comment191912>
s/.get()./->/
- Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46024/#review128319
---
Ship it!
Ship It!
- Ben Mahler
On April 11, 2016, 2:36 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46053/#review128310
---
Ship it!
Ship It!
- Ben Mahler
On April 11, 2016, 10:11 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45969/#review128309
---
Ship it!
Ship It!
- Ben Mahler
On April 11, 2016, 10:19 p.m
/nvidia_gpu_isolator_tests.cpp (lines 217 - 223)
<https://reviews.apache.org/r/45970/#comment191734>
How about no newlines between these since they are related?
- Ben Mahler
On April 11, 2016, 10:18 p.m., Kevin Klues wrote:
>
> ---
> This is a
/process_tests.cpp
<https://reviews.apache.org/r/46029/#comment191701>
Is this a complete header audit? Why only this file? I'd suggest we remove
this part of the diff.
- Ben Mahler
On April 11, 2016, 9:01 p.m., Neil C
less of your changes) seems to be
that the socket is an outbound socket? Is that true?
- Ben Mahler
On April 11, 2016, 2:35 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
eview but since they
wrote the code I'd like them to be aware of this change.
- Ben Mahler
On April 11, 2016, 2:36 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
it is sent by a libprocess instance.
- Ben Mahler
On April 11, 2016, 2:35 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
was made implicit
and no control was given to the caller.
- Ben Mahler
On April 11, 2016, 2:35 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
/reviews.apache.org/r/46025/#comment191679>
Why didn't you update this comment? Is the set of values within `temps`
equivalent to `dispose`? Would be great to explain the distinction here.
- Ben Mahler
On April 11,
to an initializer list.
- Ben Mahler
On April 11, 2016, 9:01 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45489/#review127941
---
Ship it!
Ship It!
- Ben Mahler
On March 30, 2016, 4:16 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45590/#review127940
---
Ship it!
Ship It!
- Ben Mahler
On April 1, 2016, 4:22 p.m
iews.apache.org/r/45932/#comment191318>
How about s/task_label/key/ s/task_label_value/value/ ? Will it fit on one
line then?
We generally avoid "foo" and "bar" in favor of things like "key&q
include/mesos/mesos.proto (lines 496 - 498)
<https://reviews.apache.org/r/45572/#comment191311>
Any reason not to re-use the more descriptive comment on TaskInfo.labels?
Specifically it would be nice to include the warning about the master keeping
this data in memory.
- Ben Mahl
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45488/#review127911
---
Ship it!
Ship It!
- Ben Mahler
On March 30, 2016, 2:49 p.m
cator since that just happens to be where the failure manifests.
Perhaps something like:
```
// Oversubscrbable resources must be considered revocable.
//
// TODO(bmahler): Consider tagging input as revocable
// rather than rejecting and crashing here.
```
-
gt;
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45572/
> -----------
>
> (Updated April 1, 2016, 1:42 a.m.)
>
>
> Rev
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45942/#review127891
---
Ship it!
Ship It!
- Ben Mahler
On April 8, 2016, 8:36 p.m
:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45855/
> ---
>
> (Updated April 7, 2016, 1:54 a.m.)
>
>
>
he.org/r/45855/
> -------
>
> (Updated April 7, 2016, 1:54 a.m.)
>
>
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
>
>
> Bugs: MESOS-5135
> https://issues.apache.org/jira/browse/MESOS-5135
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45855/#review127889
---
Ship it!
Ship It!
- Ben Mahler
On April 7, 2016, 1:54 a.m
)
<https://reviews.apache.org/r/45854/#comment191248>
I'm a little hesitant about using revocable gpus here given that it's not
clear how it would work, but I suppose there is no harm in it for this test.
- Ben Mahler
On April 8, 2016, 5:54 a.m., K
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45852/#review127886
---
Ship it!
Ship It!
- Ben Mahler
On April 8, 2016, 8:34 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45856/#review127885
---
Ship it!
Ship It!
- Ben Mahler
On April 7, 2016, 1:54 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45853/#review127860
---
Ship it!
Ship It!
- Ben Mahler
On April 7, 2016, 1:54 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44832/#review127727
---
Ship it!
Ship It!
- Ben Mahler
On April 2, 2016, 8:07 a.m
djacent with the expectation on the metrics?
It's also how we did it in the metrics test above:
```
expected.values = {
{"allocator/mesos/dominant_share/roles/roleA", 0.5},
};
metrics = Metrics();
EXPECT_T
watch.stop();
```
src/tests/hierarchical_allocator_tests.cpp (lines 3029 - 3031)
<https://reviews.apache.org/r/44853/#comment191091>
How about:
```
cout << "/metrics/snapshot took " << watch.elapsed()
<< " for " <
/hierarchical.hpp (line 479)
<https://reviews.apache.org/r/45533/#comment191095>
whoops?
- Ben Mahler
On April 1, 2016, 8:07 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
> On April 5, 2016, 11:53 p.m., Ben Mahler wrote:
> >
Do we also need the uvm device?
- Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45715/#rev
/cgroups/devices/gpus/nvidia.cpp (lines
65 - 78)
<https://reviews.apache.org/r/45715/#comment190468>
Could we avoid the static non-POD?
- Ben Mahler
On April 4, 2016, 11:41 p.m., Kevin Klues wrote:
>
> ---
> This is a
reviews.apache.org/r/44364/#comment190433>
It's unfortunate that the curl filter used "error" to express existence,
could we do a s/error/exists/ here? I'd also be ok shipping a patch for the
curl filter if you want to take that on.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45622/#review127231
---
Ship it!
Ship It!
- Ben Mahler
On April 2, 2016, 9:35 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45773/#review127202
---
Ship it!
Ship It!
- Ben Mahler
On April 5, 2016, 8:13 p.m
op of the class and the commit message to
mention the current caveats.
- Ben Mahler
On March 31, 2016, 4:48 p.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
nes 117 - 119)
<https://reviews.apache.org/r/44366/#comment188913>
We would probably need this TODO in all of our nvidia gpu blocks :)
- Ben Mahler
On March 14, 2016, 7:39 a.m., Kevin Klues wrote:
>
> ---
> This is an auto
- 1309)
<https://reviews.apache.org/r/44365/#comment188908>
Could we add something to clarify that this is relevant when "gpus" are
specified within --resources?
- Ben Mahler
On March 14, 2016, 7:38 a.m., Kevin Klues wrote:
>
>
y when the path is absolute?
- Ben Mahler
On March 14, 2016, 7:37 a.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
minor typos.
- Ben Mahler
On March 14, 2016, 7:35 a.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
:
> https://reviews.apache.org/r/44777/
> -----------
>
> (Updated March 18, 2016, 12:14 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-4926
> https://issues.apache.org/jira/b
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44776/#review125930
---
Ship it!
Ship It!
- Ben Mahler
On March 14, 2016, 7:36 a.m
/#comment188662>
I'm not sure if we need some of these comments, for example I can tell
pretty easily from 'Access' that it represents the access permissions and it is
part of a whitelist entry because it is contained within the ListEntry class.
Ditto for selector.
- Be
1 - 100 of 964 matches
Mail list logo
