Re: Review Request 39285: Added Quota Request Validation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Nov. 10, 2015, 9:07 a.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere. Bugs: MESOS-3199 https://issues.apache.org/jira/browse/MESOS-3199 Repository: mesos Description --- Added Quota Request Validation. Diffs (updated) - src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 src/master/quota.hpp PRE-CREATION src/master/quota.cpp PRE-CREATION src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39285/diff/ Testing --- make test Thanks, Joerg Schad
Re: Review Request 39400: Quota: Implemented quota API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/#review105817 --- src/master/allocator/mesos/hierarchical.hpp (line 358) <https://reviews.apache.org/r/39400/#comment164474> s/the/this src/master/allocator/mesos/hierarchical.hpp (line 359) <https://reviews.apache.org/r/39400/#comment164476> Quota is satisfied before fair share, ... src/master/allocator/mesos/hierarchical.cpp (line 137) <https://reviews.apache.org/r/39400/#comment164477> `Resources` src/master/allocator/mesos/hierarchical.cpp (line 416) <https://reviews.apache.org/r/39400/#comment164479> `resources` src/master/allocator/mesos/hierarchical.cpp (line 581) <https://reviews.apache.org/r/39400/#comment164480> `resources` src/master/allocator/mesos/hierarchical.cpp (line 893) <https://reviews.apache.org/r/39400/#comment164481> s/numbers/numbers. src/master/allocator/mesos/hierarchical.cpp (line 924) <https://reviews.apache.org/r/39400/#comment164482> Do you want to -symetrically to your todu when setting quota- print the actual quota removed? - Joerg Schad On Nov. 5, 2015, 6:25 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39400/ > --- > > (Updated Nov. 5, 2015, 6:25 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > and Joseph Wu. > > > Bugs: MESOS-3718 > https://issues.apache.org/jira/browse/MESOS-3718 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/master/allocator/mesos/hierarchical.hpp > cfd937ba306273c24fb5337dfeb1a15e1545169b > src/master/allocator/mesos/hierarchical.cpp > f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 > > Diff: https://reviews.apache.org/r/39400/diff/ > > > Testing > --- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 39285: Added Quota Request Validation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Nov. 10, 2015, 10 a.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere. Bugs: MESOS-3199 https://issues.apache.org/jira/browse/MESOS-3199 Repository: mesos Description --- Added Quota Request Validation. Diffs (updated) - src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 src/master/quota.hpp PRE-CREATION src/master/quota.cpp PRE-CREATION src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39285/diff/ Testing --- make test Thanks, Joerg Schad
Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/#review105865 --- src/master/allocator/mesos/hierarchical.cpp (line 984) <https://reviews.apache.org/r/39401/#comment164547> laidAside are rejected resources? In that case I would prefer rejectedResources. src/master/allocator/mesos/hierarchical.cpp (line 997) <https://reviews.apache.org/r/39401/#comment164548> s/comes first/is satisfied first src/master/allocator/mesos/hierarchical.cpp (line 1003) <https://reviews.apache.org/r/39401/#comment164552> We can sum up resources as quota is only applicable to scalar resources. src/master/allocator/mesos/hierarchical.cpp (line 1006) <https://reviews.apache.org/r/39401/#comment164554> Wouldn't it make sense to have a flag indicating when quota ia satisfied for the first time in this loop (i.e. foreach slave)? Otherwise we have to recheck this for every agent in the cluster - Joerg Schad On Nov. 9, 2015, 10:01 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39401/ > --- > > (Updated Nov. 9, 2015, 10:01 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > and Joseph Wu. > > > Bugs: MESOS-3718 > https://issues.apache.org/jira/browse/MESOS-3718 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/master/allocator/mesos/hierarchical.cpp > 14fef63714721fcda7cea3c28704766efda6d007 > > Diff: https://reviews.apache.org/r/39401/diff/ > > > Testing > --- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 39285: Added Quota Request Validation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Nov. 10, 2015, 2:03 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere. Bugs: MESOS-3199 https://issues.apache.org/jira/browse/MESOS-3199 Repository: mesos Description --- Added Quota Request Validation. Diffs (updated) - src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 src/master/quota.hpp PRE-CREATION src/master/quota.cpp PRE-CREATION src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39285/diff/ Testing --- make test Thanks, Joerg Schad
Re: Review Request 39223: Added Quota Request Validation Tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 10, 2015, 2:05 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere. Bugs: MESOS-3199 https://issues.apache.org/jira/browse/MESOS-3199 Repository: mesos Description --- see Summary. Diffs (updated) - src/tests/master_quota_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39223/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 39285: Added Quota Request Validation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Nov. 9, 2015, 12:51 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere. Bugs: MESOS-3199 https://issues.apache.org/jira/browse/MESOS-3199 Repository: mesos Description --- Added Quota Request Validation. Diffs - src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39285/diff/ Testing (updated) --- make test Thanks, Joerg Schad
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Nov. 9, 2015, 4:06 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, and Joris Van Remoortere. Bugs: MESOS-3073 https://issues.apache.org/jira/browse/MESOS-3073 Repository: mesos Description --- Added /quota HTTP Endpoint for Quota handling. Diffs (updated) - src/CMakeLists.txt cbc25e3ea33c47a787d34a7fa8499af3eb0b2c10 src/Makefile.am 938b8d403024e7b705b6088384292ad80452d9c6 src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 39285: Added Quota Request Validation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Nov. 9, 2015, 7:31 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere. Bugs: MESOS-3199 https://issues.apache.org/jira/browse/MESOS-3199 Repository: mesos Description --- Added Quota Request Validation. Diffs (updated) - src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39285/diff/ Testing --- make test Thanks, Joerg Schad
Re: Review Request 39285: Added Quota Request Validation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Nov. 9, 2015, 8:25 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere. Bugs: MESOS-3199 https://issues.apache.org/jira/browse/MESOS-3199 Repository: mesos Description --- Added Quota Request Validation. Diffs (updated) - src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39285/diff/ Testing --- make test Thanks, Joerg Schad
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Nov. 9, 2015, 11:10 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, and Joris Van Remoortere. Bugs: MESOS-3073 https://issues.apache.org/jira/browse/MESOS-3073 Repository: mesos Description --- Added /quota HTTP Endpoint for Quota handling. Diffs (updated) - src/CMakeLists.txt cbc25e3ea33c47a787d34a7fa8499af3eb0b2c10 src/Makefile.am 938b8d403024e7b705b6088384292ad80452d9c6 src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 39285: Added Quota Request Validation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Nov. 9, 2015, 11:30 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere. Bugs: MESOS-3199 https://issues.apache.org/jira/browse/MESOS-3199 Repository: mesos Description --- Added Quota Request Validation. Diffs (updated) - src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39285/diff/ Testing --- make test Thanks, Joerg Schad
Re: Review Request 39223: Added Quota Request Validation Tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 9, 2015, 10:45 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere. Bugs: MESOS-3199 https://issues.apache.org/jira/browse/MESOS-3199 Repository: mesos Description --- see Summary. Diffs (updated) - src/tests/master_quota_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39223/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.
> On Nov. 6, 2015, 2:58 p.m., Klaus Ma wrote: > > src/master/quota_handler.cpp, line 1 > > <https://reviews.apache.org/r/36913/diff/21/?file=1114591#file1114591line1> > > > > It seems other feature named file without "_handler"; any consideration > > for it? In this case the file acutally only includes the handler part (basically in order not to overload the http code) and hence the name seems to be precise. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review105425 ------- On Nov. 3, 2015, 1:55 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36913/ > --- > > (Updated Nov. 3, 2015, 1:55 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, > and Joris Van Remoortere. > > > Bugs: MESOS-3073 > https://issues.apache.org/jira/browse/MESOS-3073 > > > Repository: mesos > > > Description > --- > > Added /quota HTTP Endpoint for Quota handling. > > > Diffs > - > > src/CMakeLists.txt d107e329cc6887cd9d4ce3706dfc6ce6080d0289 > src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db > src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 > src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac > src/master/master.cpp 2bc5a97a5b50c8a8a9902c47b2e9e3b5216d97ea > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/36913/diff/ > > > Testing > --- > > make check > > > Thanks, > > Joerg Schad > >
Re: Review Request 39285: Added Quota Request Validation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Nov. 9, 2015, 8:16 a.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere. Changes --- Adressed comments. Bugs: MESOS-3199 https://issues.apache.org/jira/browse/MESOS-3199 Repository: mesos Description --- Added Quota Request Validation. Diffs (updated) - src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39285/diff/ Testing --- Thanks, Joerg Schad
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Nov. 9, 2015, 8:15 a.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, and Joris Van Remoortere. Changes --- Fixed Typo Bugs: MESOS-3073 https://issues.apache.org/jira/browse/MESOS-3073 Repository: mesos Description --- Added /quota HTTP Endpoint for Quota handling. Diffs (updated) - src/CMakeLists.txt d107e329cc6887cd9d4ce3706dfc6ce6080d0289 src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac src/master/master.cpp 2bc5a97a5b50c8a8a9902c47b2e9e3b5216d97ea src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 39223: Added Quota Request Validation Tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 9, 2015, 7:29 a.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere. Bugs: MESOS-3199 https://issues.apache.org/jira/browse/MESOS-3199 Repository: mesos Description --- see Summary. Diffs (updated) - src/tests/master_quota_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39223/diff/ Testing (updated) --- make check Thanks, Joerg Schad
Re: Review Request 39285: Added Quota Request Validation.
> On Nov. 6, 2015, 4:19 p.m., Klaus Ma wrote: > > src/master/quota_handler.cpp, line 180 > > <https://reviews.apache.org/r/39285/diff/7/?file=1118136#file1118136line180> > > > > Should we move it into `validateQuotaRequest`? If any role is exist in > > master, we did not need to continue to check others. And in QuotaHandler, > > we had the pointer to master `Master* master`. > > Alexander Rukletsov wrote: > I'd keep it here, because it's related to how we currently process the > request, rather than whether the request is valid. There was an earlier comment from Joris mentioning that this isn't really part of validatating the request (as it also involves state of the master). > On Nov. 6, 2015, 4:19 p.m., Klaus Ma wrote: > > src/master/quota_handler.cpp, line 140 > > <https://reviews.apache.org/r/39285/diff/7/?file=1118136#file1118136line140> > > > > Suggest to move it into the loop; if any role is not known by master, > > we did not need to continue to check others. > > Alexander Rukletsov wrote: > I think the flow is more readable how it's now: in the loop we > reconstruct the "reference" role, afterwards we check whether it is known to > the master. Also, my gut feeling is that typos in roles will not be that > frequent, so checking it once instead of per resource makes sense to me. There should just be a single role per request, why should I check that in the loop? - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review105440 --- On Nov. 6, 2015, 3:23 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39285/ > --- > > (Updated Nov. 6, 2015, 3:23 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van > Remoortere. > > > Bugs: MESOS-3199 > https://issues.apache.org/jira/browse/MESOS-3199 > > > Repository: mesos > > > Description > --- > > Added Quota Request Validation. > > > Diffs > - > > src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39285/diff/ > > > Testing > --- > > > Thanks, > > Joerg Schad > >
Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/#review105422 --- include/mesos/master/allocator.hpp (line 357) <https://reviews.apache.org/r/38218/#comment164014> s/given role not set/nonexisting role? - Joerg Schad On Nov. 5, 2015, 7:29 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38218/ > --- > > (Updated Nov. 5, 2015, 7:29 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > and Joseph Wu. > > > Bugs: MESOS-3716 > https://issues.apache.org/jira/browse/MESOS-3716 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 > src/master/allocator/mesos/allocator.hpp > c5375aa89b210e46c41ac7d68d119749de15d2f5 > src/master/allocator/mesos/hierarchical.hpp > cfd937ba306273c24fb5337dfeb1a15e1545169b > src/master/allocator/mesos/hierarchical.cpp > f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 > src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a > > Diff: https://reviews.apache.org/r/38218/diff/ > > > Testing > --- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 39285: Added Quota Request Validation.
> On Nov. 5, 2015, 9:59 p.m., Joseph Wu wrote: > > src/master/quota_handler.cpp, lines 102-110 > > <https://reviews.apache.org/r/39285/diff/6/?file=1105159#file1105159line102> > > > > What do you think about using helpers from > > `include/mesos/resources.hpp`? A bunch of these checks could be done on a > > `Resources` (plural) object. I considered them but decided against them for the following reasons - I really jsut want to check whether such additional field has been specified, consider for example 'isPersistentVolume' which also checks for persistence. Hence I would need to chech .has_disk() anyhow. - Others seem like very trivial wrappers (e.g. isRevocable -> return resource.has_revocable()) in which case I would like to have one consistent way across all checks (which due the above point is checking the protobug fields without the helpers). - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review105313 ------- On Oct. 24, 2015, 7:42 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39285/ > --- > > (Updated Oct. 24, 2015, 7:42 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van > Remoortere. > > > Bugs: MESOS-3199 > https://issues.apache.org/jira/browse/MESOS-3199 > > > Repository: mesos > > > Description > --- > > Added Quota Request Validation. > > > Diffs > - > > src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39285/diff/ > > > Testing > --- > > > Thanks, > > Joerg Schad > >
Re: Review Request 39285: Added Quota Request Validation.
> On Nov. 3, 2015, 1:37 p.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 123 > > <https://reviews.apache.org/r/39285/diff/6/?file=1105159#file1105159line123> > > > > Suggest to change ```if``` to ```else if```, in this way, for the first > > resource, we do not need to compare it with itself. I personally find the non else version easier to read as it is just a sequence of conditions being checked, but changed it anyhow. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review104906 --- On Oct. 24, 2015, 7:42 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39285/ > --- > > (Updated Oct. 24, 2015, 7:42 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van > Remoortere. > > > Bugs: MESOS-3199 > https://issues.apache.org/jira/browse/MESOS-3199 > > > Repository: mesos > > > Description > --- > > Added Quota Request Validation. > > > Diffs > - > > src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39285/diff/ > > > Testing > --- > > > Thanks, > > Joerg Schad > >
Re: Review Request 39285: Added Quota Request Validation.
> On Oct. 25, 2015, 2:45 a.m., Klaus Ma wrote:
> > src/master/quota_handler.cpp, line 115
> > <https://reviews.apache.org/r/39285/diff/6/?file=1105159#file1105159line115>
> >
> > It said the role maybe not set in allocator interface's comments
> > (`setQuota`); so any case that the role passed validation in master but
> > it's still empty to allocator?
If I picked the correct comment ("n allocator implementation may assume quota
for the given role is not set prior to the call and react accordingly if this
assumption is violated (i.e. fail)").
This comment refers to whether a role must be exixting prior to the call, this
check is concerned whether the request has a role set which currently is
required.
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review103918
---
On Oct. 24, 2015, 7:42 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39285/
> ---
>
> (Updated Oct. 24, 2015, 7:42 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van
> Remoortere.
>
>
> Bugs: MESOS-3199
> https://issues.apache.org/jira/browse/MESOS-3199
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Added Quota Request Validation.
>
>
> Diffs
> -
>
> src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598
> src/master/quota_handler.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39285/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 39285: Added Quota Request Validation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Nov. 6, 2015, 3:23 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere. Bugs: MESOS-3199 https://issues.apache.org/jira/browse/MESOS-3199 Repository: mesos Description --- Added Quota Request Validation. Diffs (updated) - src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39285/diff/ Testing --- Thanks, Joerg Schad
Re: Review Request 38956: Quota: Added allocator-agnostic tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38956/#review105438 --- src/tests/master_quota_tests.cpp (line 170) <https://reviews.apache.org/r/38956/#comment164039> Also we usually use 3rd person in test comments. (see your comment on 39223) // This test ensures... or // This tests that... or simply // Tests whether... - Joerg Schad On Nov. 5, 2015, 7:27 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38956/ > --- > > (Updated Nov. 5, 2015, 7:27 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > Joseph Wu, and Michael Park. > > > Bugs: MESOS-3720 > https://issues.apache.org/jira/browse/MESOS-3720 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 > src/master/quota_handler.cpp PRE-CREATION > src/tests/master_quota_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38956/diff/ > > > Testing > --- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 39223: Added Quota Request Validation Tests.
> On Nov. 3, 2015, 12:35 p.m., Alexander Rukletsov wrote: > > src/tests/master_quota_tests.cpp, line 431 > > <https://reviews.apache.org/r/39223/diff/6/?file=1105362#file1105362line431> > > > > It looks like this comment is a victim of partial refactoring : ). > > Could you please udpate it? > > > > Also we usually use 3rd person in test comments. > > > > ``` > > // This test ensures... > > ``` > > or > > ``` > > // This tests that... > > ``` > > or simply > > ``` > > // Tests whether... > > ``` Just following your lead on your previous comment ;-): "Verifies that a request for a non-existent role is rejected." - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/#review104894 --- On Oct. 23, 2015, 9:10 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39223/ > --- > > (Updated Oct. 23, 2015, 9:10 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van > Remoortere. > > > Bugs: MESOS-3199 > https://issues.apache.org/jira/browse/MESOS-3199 > > > Repository: mesos > > > Description > --- > > see Summary. > > > Diffs > - > > src/tests/master_quota_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39223/diff/ > > > Testing > --- > > > Thanks, > > Joerg Schad > >
Re: Review Request 38956: Quota: Added allocator-agnostic tests.
> On Nov. 6, 2015, 4:06 p.m., Joerg Schad wrote: > > src/tests/master_quota_tests.cpp, line 170 > > <https://reviews.apache.org/r/38956/diff/8/?file=1114104#file1114104line170> > > > > Also we usually use 3rd person in test comments. > > (see your comment on 39223) > > > > > > // This test ensures... > > > > or > > > > // This tests that... > > > > or simply > > > > // Tests whether... What I was trying to ask was whether we should use Tests instead of Verfies - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38956/#review105438 --- On Nov. 5, 2015, 7:27 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38956/ > ------- > > (Updated Nov. 5, 2015, 7:27 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > Joseph Wu, and Michael Park. > > > Bugs: MESOS-3720 > https://issues.apache.org/jira/browse/MESOS-3720 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 > src/master/quota_handler.cpp PRE-CREATION > src/tests/master_quota_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38956/diff/ > > > Testing > --- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 39285: Added Quota Request Validation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review105450 --- src/master/quota_handler.cpp (line 118) <https://reviews.apache.org/r/39285/#comment164058> } else if - Joerg Schad On Nov. 6, 2015, 3:23 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39285/ > --- > > (Updated Nov. 6, 2015, 3:23 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van > Remoortere. > > > Bugs: MESOS-3199 > https://issues.apache.org/jira/browse/MESOS-3199 > > > Repository: mesos > > > Description > --- > > Added Quota Request Validation. > > > Diffs > - > > src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39285/diff/ > > > Testing > --- > > > Thanks, > > Joerg Schad > >
Re: Review Request 38956: Quota: Added allocator-agnostic tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38956/#review105454 --- src/tests/master_quota_tests.cpp (line 341) <https://reviews.apache.org/r/38956/#comment164063> Please move up below AWAIT_READY(agentTotalResources); - Joerg Schad On Nov. 5, 2015, 7:27 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38956/ > --- > > (Updated Nov. 5, 2015, 7:27 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > Joseph Wu, and Michael Park. > > > Bugs: MESOS-3720 > https://issues.apache.org/jira/browse/MESOS-3720 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 > src/master/quota_handler.cpp PRE-CREATION > src/tests/master_quota_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38956/diff/ > > > Testing > --- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 39223: Added Quota Request Validation Tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Nov. 6, 2015, 5:02 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere. Bugs: MESOS-3199 https://issues.apache.org/jira/browse/MESOS-3199 Repository: mesos Description --- see Summary. Diffs (updated) - src/tests/master_quota_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39223/diff/ Testing --- Thanks, Joerg Schad
Re: Review Request 39223: Added Quota Request Validation Tests.
> On Nov. 3, 2015, 12:35 p.m., Alexander Rukletsov wrote: > > src/tests/master_quota_tests.cpp, line 463 > > <https://reviews.apache.org/r/39223/diff/6/?file=1105362#file1105362line463> > > > > We try to keep tests atomic: testing one thing at a time. However, I > > think it does make sense to merge `Set_InvalidJson`, `Set_InvalidJson2`, > > and `Set_InvalidResources` into one tests for brevity and speed. These 3 > > tests address the same issue: malformed JSON, similar to what you have done > > with `Set_InvalidResourceInfos`. I feel that these are actually testing slightly different stuff (different from the invalidResource Info) - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/#review104894 ------- On Oct. 23, 2015, 9:10 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39223/ > --- > > (Updated Oct. 23, 2015, 9:10 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van > Remoortere. > > > Bugs: MESOS-3199 > https://issues.apache.org/jira/browse/MESOS-3199 > > > Repository: mesos > > > Description > --- > > see Summary. > > > Diffs > - > > src/tests/master_quota_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39223/diff/ > > > Testing > --- > > > Thanks, > > Joerg Schad > >
Review Request 40017: Add Docker Image type to Container Image for v1 API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40017/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-2851 https://issues.apache.org/jira/browse/MESOS-2851 Repository: mesos Description --- Review 37196 added the Docker image type to the old API, this review does the same for the v1 API. Diffs - include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a Diff: https://reviews.apache.org/r/40017/diff/ Testing --- make distcheck Thanks, Joerg Schad
Re: Review Request 37196: Add Docker Image type to Container Image protobuf.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37196/#review105414 --- Should this be added as well to the v1 Api? - Joerg Schad On Aug. 10, 2015, 10:30 p.m., Lily Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37196/ > --- > > (Updated Aug. 10, 2015, 10:30 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, and Timothy Chen. > > > Bugs: MESOS-2851 > https://issues.apache.org/jira/browse/MESOS-2851 > > > Repository: mesos > > > Description > --- > > Add Docker Image type to Container Image protobuf. > > > Diffs > - > > include/mesos/mesos.proto 80f56ac2178b24ff19f57c1ace13f567843c7807 > > Diff: https://reviews.apache.org/r/37196/diff/ > > > Testing > --- > > make check > > > Thanks, > > Lily Chen > >
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Nov. 3, 2015, 1:31 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, and Joris Van Remoortere. Bugs: MESOS-3073 https://issues.apache.org/jira/browse/MESOS-3073 Repository: mesos Description --- Added /quota HTTP Endpoint for Quota handling. Diffs (updated) - src/CMakeLists.txt d107e329cc6887cd9d4ce3706dfc6ce6080d0289 src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac src/master/master.cpp 2bc5a97a5b50c8a8a9902c47b2e9e3b5216d97ea Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 39449: Documented order of includes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39449/#review104986 --- docs/c++-style-guide.md (line 262) <https://reviews.apache.org/r/39449/#comment163349> This should be the first include (see my other comments and the Google Styleguide ( https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes) :-)). - Joerg Schad On Oct. 19, 2015, 9:29 p.m., Jan Schlicht wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39449/ > --- > > (Updated Oct. 19, 2015, 9:29 p.m.) > > > Review request for mesos, Marco Massenzio and Michael Park. > > > Bugs: MESOS-2275 > https://issues.apache.org/jira/browse/MESOS-2275 > > > Repository: mesos > > > Description > --- > > Documented order of includes. > > > Diffs > - > > docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad > > Diff: https://reviews.apache.org/r/39449/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jan Schlicht > >
Re: Review Request 39449: Documented order of includes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39449/#review104983 --- Ship it! docs/c++-style-guide.md (line 235) <https://reviews.apache.org/r/39449/#comment163346> Could we add that for cpp files the repective .h file should be included first (which is specified in the Google Styleguide but many files ignore this) docs/c++-style-guide.md (lines 240 - 241) <https://reviews.apache.org/r/39449/#comment163348> Add foo.hpp as first include. docs/c++-style-guide.md (line 251) <https://reviews.apache.org/r/39449/#comment163344> Could we add a short comment above every new section describing the representative meaning of each? (e.g. here nested subfolder) - Joerg Schad On Oct. 19, 2015, 9:29 p.m., Jan Schlicht wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39449/ > --- > > (Updated Oct. 19, 2015, 9:29 p.m.) > > > Review request for mesos, Marco Massenzio and Michael Park. > > > Bugs: MESOS-2275 > https://issues.apache.org/jira/browse/MESOS-2275 > > > Repository: mesos > > > Description > --- > > Documented order of includes. > > > Diffs > - > > docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad > > Diff: https://reviews.apache.org/r/39449/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jan Schlicht > >
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Nov. 3, 2015, 1:55 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, and Joris Van Remoortere. Bugs: MESOS-3073 https://issues.apache.org/jira/browse/MESOS-3073 Repository: mesos Description --- Added /quota HTTP Endpoint for Quota handling. Diffs (updated) - src/CMakeLists.txt d107e329cc6887cd9d4ce3706dfc6ce6080d0289 src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 src/master/master.hpp b76d30197b3decda0a742e03ce01a17a64b633ac src/master/master.cpp 2bc5a97a5b50c8a8a9902c47b2e9e3b5216d97ea src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/#review104710 --- Ship it! src/master/allocator/mesos/allocator.hpp (line 268) <https://reviews.apache.org/r/38218/#comment162961> Could we add a todo for updateQuota()? In my opinion this would make it easier to understand both the MVP semantic as well as the post mvp plans. Same below. src/tests/mesos.hpp (line 1652) <https://reviews.apache.org/r/38218/#comment162962> Why not single line? - Joerg Schad On Oct. 23, 2015, 4:38 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38218/ > --- > > (Updated Oct. 23, 2015, 4:38 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van > Remoortere. > > > Bugs: MESOS-3716 > https://issues.apache.org/jira/browse/MESOS-3716 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 > src/master/allocator/mesos/allocator.hpp > c5375aa89b210e46c41ac7d68d119749de15d2f5 > src/master/allocator/mesos/hierarchical.hpp > cfd937ba306273c24fb5337dfeb1a15e1545169b > src/master/allocator/mesos/hierarchical.cpp > f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 > src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a > > Diff: https://reviews.apache.org/r/38218/diff/ > > > Testing > --- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 39285: Added Quota Request Validation.
> On Oct. 25, 2015, 2:45 a.m., Klaus Ma wrote: > > src/master/master.hpp, line 864 > > <https://reviews.apache.org/r/39285/diff/6/?file=1105158#file1105158line864> > > > > Should we return Bad Request (404) for now, because we did not > > implement it yet. As it is implemented in the following patches it does not matter too much in my opinion... > On Oct. 25, 2015, 2:45 a.m., Klaus Ma wrote: > > src/master/master.hpp, line 875 > > <https://reviews.apache.org/r/39285/diff/6/?file=1105158#file1105158line875> > > > > Same as above. see above... - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review103918 ------- On Oct. 24, 2015, 7:42 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39285/ > --- > > (Updated Oct. 24, 2015, 7:42 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van > Remoortere. > > > Bugs: MESOS-3199 > https://issues.apache.org/jira/browse/MESOS-3199 > > > Repository: mesos > > > Description > --- > > Added Quota Request Validation. > > > Diffs > - > > src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39285/diff/ > > > Testing > --- > > > Thanks, > > Joerg Schad > >
Re: Review Request 39285: Added Quota Request Validation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Oct. 24, 2015, 7:42 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere. Bugs: MESOS-3199 https://issues.apache.org/jira/browse/MESOS-3199 Repository: mesos Description --- Added Quota Request Validation. Diffs - src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39285/diff/ Testing --- Thanks, Joerg Schad
Re: Review Request 39614: Quota: Added Status Validation Tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/ --- (Updated Oct. 24, 2015, 7:40 p.m.) Review request for mesos, Alexander Rukletsov and Bernd Mathiske. Bugs: MESOS-3073 https://issues.apache.org/jira/browse/MESOS-3073 Repository: mesos Description --- Quota: Added Status Validation Tests. Diffs (updated) - src/tests/master_quota_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39614/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38218/#review103905 --- include/mesos/master/allocator.hpp (line 360) <https://reviews.apache.org/r/38218/#comment162020> Agree would be helpful. include/mesos/master/allocator.hpp (line 377) <https://reviews.apache.org/r/38218/#comment162019> Agree, this would be helpful. - Joerg Schad On Oct. 23, 2015, 4:38 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38218/ > --- > > (Updated Oct. 23, 2015, 4:38 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van > Remoortere. > > > Bugs: MESOS-3716 > https://issues.apache.org/jira/browse/MESOS-3716 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 > src/master/allocator/mesos/allocator.hpp > c5375aa89b210e46c41ac7d68d119749de15d2f5 > src/master/allocator/mesos/hierarchical.hpp > cfd937ba306273c24fb5337dfeb1a15e1545169b > src/master/allocator/mesos/hierarchical.cpp > f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 > src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a > > Diff: https://reviews.apache.org/r/38218/diff/ > > > Testing > --- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 39492: Added status endpoint for quota master endpoint.
> On Oct. 25, 2015, 3:28 a.m., Guangya Liu wrote:
> > src/master/quota_handler.cpp, line 237
> > <https://reviews.apache.org/r/39492/diff/2/?file=1105415#file1105415line237>
> >
> > Can you please add a new test case for this? You can refer to
> > https://github.com/apache/mesos/blob/master/src/tests/master_tests.cpp#L1623-L1699
> > as a reference
Check the next patch in the chain (i.e. https://reviews.apache.org/r/39614/)
:-).
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review103928
-------
On Oct. 23, 2015, 10:34 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> ---
>
> (Updated Oct. 23, 2015, 10:34 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van
> Remoortere.
>
>
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Added status handling for quota master endpoint.
> Tests are in next Review.
>
>
> Diffs
> -
>
> src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598
> src/master/quota_handler.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/39492/diff/
>
>
> Testing
> ---
>
> Test output:
> {"quota":[{"guarantee":{"cpus":4.0,"disk":0,"mem":5.0},"role":"test"}]}
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 39285: Added Quota Request Validation.
> On Oct. 22, 2015, 10:25 a.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, lines 71-72 > > <https://reviews.apache.org/r/39285/diff/4/?file=1103067#file1103067line71> > > > > How about initializing `role` with QuotaInfo.role? Or we agreed not to > > send role as part of the JSON request? According to the current design doc no. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review103539 --- On Oct. 22, 2015, 4:38 a.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39285/ > --- > > (Updated Oct. 22, 2015, 4:38 a.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van > Remoortere. > > > Bugs: MESOS-3199 > https://issues.apache.org/jira/browse/MESOS-3199 > > > Repository: mesos > > > Description > --- > > Added Quota Request Validation. > > > Diffs > - > > src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39285/diff/ > > > Testing > --- > > > Thanks, > > Joerg Schad > >
Re: Review Request 39285: Added Quota Request Validation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Oct. 23, 2015, 4:52 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere. Bugs: MESOS-3199 https://issues.apache.org/jira/browse/MESOS-3199 Repository: mesos Description --- Added Quota Request Validation. Diffs (updated) - src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39285/diff/ Testing --- Thanks, Joerg Schad
Review Request 39614: Quota: Added Status Validation Tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39614/ --- Review request for mesos, Alexander Rukletsov and Bernd Mathiske. Bugs: MESOS-3073 https://issues.apache.org/jira/browse/MESOS-3073 Repository: mesos Description --- Quota: Added Status Validation Tests. Diffs - src/tests/master_quota_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39614/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 39492: Added status endpoint for quota master endpoint.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/
---
(Updated Oct. 23, 2015, 10:34 p.m.)
Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van
Remoortere.
Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073
Repository: mesos
Description (updated)
---
Added status handling for quota master endpoint.
Tests are in next Review.
Diffs
-
src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598
src/master/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/39492/diff/
Testing
---
Test output:
{"quota":[{"guarantee":{"cpus":4.0,"disk":0,"mem":5.0},"role":"test"}]}
Thanks,
Joerg Schad
Re: Review Request 39223: WIP Added Quota Request Validation Tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Oct. 23, 2015, 9:10 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere. Bugs: MESOS-3199 https://issues.apache.org/jira/browse/MESOS-3199 Repository: mesos Description --- Right now intented for TDD. Diffs (updated) - src/tests/master_quota_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39223/diff/ Testing --- Thanks, Joerg Schad
Re: Review Request 39223: Added Quota Request Validation Tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Oct. 23, 2015, 9:10 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere. Summary (updated) - Added Quota Request Validation Tests. Bugs: MESOS-3199 https://issues.apache.org/jira/browse/MESOS-3199 Repository: mesos Description (updated) --- see Summary. Diffs - src/tests/master_quota_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39223/diff/ Testing --- Thanks, Joerg Schad
Re: Review Request 39492: Added status endpoint for quota master endpoint.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/
---
(Updated Oct. 23, 2015, 9:32 p.m.)
Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van
Remoortere.
Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073
Repository: mesos
Description
---
Added status handling for quota master endpoint.
Diffs (updated)
-
src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598
src/master/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/39492/diff/
Testing
---
Test output:
{"quota":[{"guarantee":{"cpus":4.0,"disk":0,"mem":5.0},"role":"test"}]}
Thanks,
Joerg Schad
Re: Review Request 39285: Added Quota Request Validation.
> On Oct. 22, 2015, 10:57 a.m., Alexander Rukletsov wrote: > > src/master/quota_handler.cpp, lines 64-66 > > <https://reviews.apache.org/r/39285/diff/4/?file=1103067#file1103067line64> > > > > This is an API change which contradicts the API described in the design > > doc and differs from, for example, dynamic reservations. Mind elaborating > > why you have opted for this change? No strong preference, will switch back. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review103555 ------- On Oct. 22, 2015, 4:38 a.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39285/ > --- > > (Updated Oct. 22, 2015, 4:38 a.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van > Remoortere. > > > Bugs: MESOS-3199 > https://issues.apache.org/jira/browse/MESOS-3199 > > > Repository: mesos > > > Description > --- > > Added Quota Request Validation. > > > Diffs > - > > src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39285/diff/ > > > Testing > --- > > > Thanks, > > Joerg Schad > >
Re: Review Request 39285: Added Quota Request Validation.
> On Oct. 22, 2015, 10:25 a.m., Alexander Rukletsov wrote: > > src/master/master.hpp, line 878 > > <https://reviews.apache.org/r/39285/diff/4/?file=1103066#file1103066line878> > > > > s/Check/Checks > > s/Request/request > > > > Do we capitalize "quota"? I did, will adjust to you style - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/#review103539 ------- On Oct. 22, 2015, 4:38 a.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39285/ > --- > > (Updated Oct. 22, 2015, 4:38 a.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van > Remoortere. > > > Bugs: MESOS-3199 > https://issues.apache.org/jira/browse/MESOS-3199 > > > Repository: mesos > > > Description > --- > > Added Quota Request Validation. > > > Diffs > - > > src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39285/diff/ > > > Testing > --- > > > Thanks, > > Joerg Schad > >
Re: Review Request 39285: Added Quota Request Validation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Oct. 22, 2015, 4:38 a.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere. Bugs: MESOS-3199 https://issues.apache.org/jira/browse/MESOS-3199 Repository: mesos Description --- Added Quota Request Validation. Diffs (updated) - src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39285/diff/ Testing --- Thanks, Joerg Schad
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.
> On Oct. 22, 2015, 3:08 a.m., Guangya Liu wrote: > > src/master/http.cpp, line 843 > > <https://reviews.apache.org/r/36913/diff/19/?file=1102864#file1102864line843> > > > > What about return quotaHandler.delete(request); > > > > It is better that the operation API can map to CRUD We wanted to make the name consistent across all calls. @alex: Any preference? > On Oct. 22, 2015, 3:08 a.m., Guangya Liu wrote: > > src/master/http.cpp, line 839 > > <https://reviews.apache.org/r/36913/diff/19/?file=1102864#file1102864line839> > > > > what about "return quotaHandler.create(request)" Wanted to make names consistent. @alex: any preference? - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review103518 ------- On Oct. 22, 2015, 1:03 a.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36913/ > --- > > (Updated Oct. 22, 2015, 1:03 a.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, > and Joris Van Remoortere. > > > Bugs: MESOS-3073 > https://issues.apache.org/jira/browse/MESOS-3073 > > > Repository: mesos > > > Description > --- > > Added /quota HTTP Endpoint for Quota handling. > > > Diffs > - > > src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd > src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 > src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 > src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 > src/master/master.cpp 0981428f5a93242d6fb3f68fb93d5f8ee6178ace > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/36913/diff/ > > > Testing > --- > > make check > > > Thanks, > > Joerg Schad > >
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Oct. 21, 2015, 10:41 p.m.) Review request for Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, and Joris Van Remoortere. Bugs: MESOS-3073 https://issues.apache.org/jira/browse/MESOS-3073 Repository: mesos Description --- Added /quota HTTP Endpoint for Quota handling. Diffs (updated) - src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 src/master/http.cpp 093f79384916dc08b32b70d3614e0ff314825c42 src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 src/master/master.cpp 0981428f5a93242d6fb3f68fb93d5f8ee6178ace src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 39285: Added Quota Request Validation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Oct. 19, 2015, 8:11 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere. Changes --- Adressed comments Bugs: MESOS-3199 https://issues.apache.org/jira/browse/MESOS-3199 Repository: mesos Description --- Added Quota Request Validation. Diffs (updated) - src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39285/diff/ Testing --- Thanks, Joerg Schad
Re: Review Request 39452: MESOS-3566 Description of RecordIO format
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review103152 --- Ship it! docs/scheduler-http-api.md (line 59) <https://reviews.apache.org/r/39452/#comment161115> independent - Joerg Schad On Oct. 19, 2015, 7:59 p.m., Marco Massenzio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39452/ > --- > > (Updated Oct. 19, 2015, 7:59 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-3566 > https://issues.apache.org/jira/browse/MESOS-3566 > > > Repository: mesos > > > Description > --- > > Added the description of the RecordIO format to the HTTP API > document with example code (Python) to decode. > > > Diffs > - > > docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 > > Diff: https://reviews.apache.org/r/39452/diff/ > > > Testing > --- > > > Thanks, > > Marco Massenzio > >
Re: Review Request 39223: WIP Added Quota Request Validation Tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Oct. 20, 2015, 2:15 a.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere. Changes --- Adressed reviews. Bugs: MESOS-3199 https://issues.apache.org/jira/browse/MESOS-3199 Repository: mesos Description --- Right now intented for TDD. Diffs (updated) - src/tests/master_quota_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39223/diff/ Testing --- Thanks, Joerg Schad
Re: Review Request 39285: Added Quota Request Validation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39285/ --- (Updated Oct. 15, 2015, 6:50 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere. Changes --- Rebased Bugs: MESOS-3199 https://issues.apache.org/jira/browse/MESOS-3199 Repository: mesos Description --- Added Quota Request Validation. Diffs (updated) - src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/39285/diff/ Testing --- Thanks, Joerg Schad
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Oct. 14, 2015, 1:28 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, and Joris Van Remoortere. Changes --- Adressed comments. Bugs: MESOS-3073 https://issues.apache.org/jira/browse/MESOS-3073 Repository: mesos Description --- Added /quota HTTP Endpoint for Quota handling. Diffs (updated) - src/CMakeLists.txt 98e76cee81ab206f3ffe7989711abc38f49c4352 src/Makefile.am 4a0eeb89eb2f3fa5e9fff46e4316e39209884343 src/master/http.cpp 3ca3725302cc831b067a2f69edbda95cd30c2520 src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 src/master/master.cpp ba12a83b64e9fd02dd4ee7de27c44e0c8d4f03a9 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Oct. 14, 2015, 1:07 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, and Joris Van Remoortere. Changes --- Rebased. Bugs: MESOS-3073 https://issues.apache.org/jira/browse/MESOS-3073 Repository: mesos Description --- Added /quota HTTP Endpoint for Quota handling. Diffs (updated) - src/CMakeLists.txt 98e76cee81ab206f3ffe7989711abc38f49c4352 src/Makefile.am 4a0eeb89eb2f3fa5e9fff46e4316e39209884343 src/master/http.cpp 3ca3725302cc831b067a2f69edbda95cd30c2520 src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 src/master/master.cpp ba12a83b64e9fd02dd4ee7de27c44e0c8d4f03a9 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Oct. 14, 2015, 2:07 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, and Joris Van Remoortere. Bugs: MESOS-3073 https://issues.apache.org/jira/browse/MESOS-3073 Repository: mesos Description --- Added /quota HTTP Endpoint for Quota handling. Diffs - src/CMakeLists.txt 98e76cee81ab206f3ffe7989711abc38f49c4352 src/Makefile.am 4a0eeb89eb2f3fa5e9fff46e4316e39209884343 src/master/http.cpp 3ca3725302cc831b067a2f69edbda95cd30c2520 src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 src/master/master.cpp ba12a83b64e9fd02dd4ee7de27c44e0c8d4f03a9 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Oct. 14, 2015, 2:16 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, and Joris Van Remoortere. Changes --- Rebased on top of 38218. Bugs: MESOS-3073 https://issues.apache.org/jira/browse/MESOS-3073 Repository: mesos Description --- Added /quota HTTP Endpoint for Quota handling. Diffs (updated) - src/CMakeLists.txt 98e76cee81ab206f3ffe7989711abc38f49c4352 src/Makefile.am 2bf40f27733b4362d64679bf594e15e82f47155d src/master/http.cpp 3ca3725302cc831b067a2f69edbda95cd30c2520 src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 src/master/master.cpp ba12a83b64e9fd02dd4ee7de27c44e0c8d4f03a9 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.
> On Oct. 13, 2015, 11:54 a.m., Joris Van Remoortere wrote: > > src/master/http.cpp, line 787 > > <https://reviews.apache.org/r/36913/diff/14/?file=1094793#file1094793line787> > > > > Let's add the corresponding HELP function for this. See Alex's earlier comment about providing the Help function once the semantics are finalized. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review102433 --- On Oct. 13, 2015, 8:55 a.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36913/ > --- > > (Updated Oct. 13, 2015, 8:55 a.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Alex Clemmer, > and Joris Van Remoortere. > > > Bugs: MESOS-3073 > https://issues.apache.org/jira/browse/MESOS-3073 > > > Repository: mesos > > > Description > --- > > Added /quota HTTP Endpoint for Quota handling. > > > Diffs > - > > src/CMakeLists.txt 828dbb690841c561816811dfbb044aa3afead89d > src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e > src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660 > src/master/master.hpp 9d957519bb0f717526af9b2717dc870fae93c20f > src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/36913/diff/ > > > Testing > --- > > make check > > > Thanks, > > Joerg Schad > >
Re: Review Request 39223: WIP Added Quota related Tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/ --- (Updated Oct. 12, 2015, 4:57 p.m.) Review request for mesos, Alexander Rukletsov and Bernd Mathiske. Changes --- Added Test for Non-Scalar resources. Repository: mesos Description --- Right now intented for TDD. Diffs (updated) - src/tests/master_tests.cpp ee2473997ccbd1c50d0cbf65d1259ea2dfe82971 Diff: https://reviews.apache.org/r/39223/diff/ Testing --- Thanks, Joerg Schad
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.
> On Oct. 10, 2015, 10:08 a.m., Alex Clemmer wrote: > > src/Makefile.am, line 492 > > <https://reviews.apache.org/r/36913/diff/13/?file=1091694#file1091694line492> > > > > Hey, could we please also add this to the `CMakeLists.txt` file in the > > `src/` directory? Thanks! Done, please double-check and reopen if I have to do more :-). Thanks for pointing this out! - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review102159 --- On Oct. 11, 2015, 4:12 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36913/ > --- > > (Updated Oct. 11, 2015, 4:12 p.m.) > > > Review request for mesos, Alexander Rukletsov and Bernd Mathiske. > > > Bugs: MESOS-3073 > https://issues.apache.org/jira/browse/MESOS-3073 > > > Repository: mesos > > > Description > --- > > Added /quota HTTP Endpoint for Quota handling. > > > Diffs > - > > src/CMakeLists.txt 828dbb690841c561816811dfbb044aa3afead89d > src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e > src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660 > src/master/master.hpp 9d957519bb0f717526af9b2717dc870fae93c20f > src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/36913/diff/ > > > Testing > --- > > make check > > > Thanks, > > Joerg Schad > >
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Oct. 11, 2015, 4:12 p.m.) Review request for mesos, Alexander Rukletsov and Bernd Mathiske. Changes --- Added to CMakeList.txt Bugs: MESOS-3073 https://issues.apache.org/jira/browse/MESOS-3073 Repository: mesos Description --- Added /quota HTTP Endpoint for Quota handling. Diffs (updated) - src/CMakeLists.txt 828dbb690841c561816811dfbb044aa3afead89d src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660 src/master/master.hpp 9d957519bb0f717526af9b2717dc870fae93c20f src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 39042: Updated comment referencing deprecated and removed /master/shutdown endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39042/ --- (Updated Oct. 6, 2015, 8:18 a.m.) Review request for mesos and Bernd Mathiske. Bugs: MESOS-2697 https://issues.apache.org/jira/browse/MESOS-2697 Repository: mesos Description (updated) --- /master/shutdown endpoint has been fully removed with 36732. Diffs - src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c Diff: https://reviews.apache.org/r/39042/diff/ Testing --- Thanks, Joerg Schad
Review Request 39042: Updated comment referencing deprecated and removed /master/shutdown endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39042/ --- Review request for mesos and Bernd Mathiske. Bugs: MESOS-2697 https://issues.apache.org/jira/browse/MESOS-2697 Repository: mesos Description --- Updated comment referencing deprecated and removed /master/shutdown endpoint. Diffs - src/master/master.hpp 4bb65f0b6b77ea7324b0dee943602cfdb0f6a11c Diff: https://reviews.apache.org/r/39042/diff/ Testing --- Thanks, Joerg Schad
Re: Review Request 37967: Added Non-Freezeer Task Killer. 36620
> On Sept. 22, 2015, 10:37 p.m., Jie Yu wrote: > > src/linux/cgroups.hpp, line 666 > > <https://reviews.apache.org/r/37967/diff/2/?file=1081507#file1081507line666> > > > > Any reason you want to expose these two classes in the header? If no > > one is using them right now, please move them to the cpp file (close to > > their impl.) I would like to leave them here as my second patch with tests can access the classes in this way. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37967/#review100082 ------- On Sept. 22, 2015, 7:43 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37967/ > --- > > (Updated Sept. 22, 2015, 7:43 p.m.) > > > Review request for mesos and Till Toenshoff. > > > Repository: mesos > > > Description > --- > > Added Non-Freezeer Task Killer. 36620 > > > Diffs > - > > src/linux/cgroups.hpp 204c53038a1ccfa693f4f2293488cff8cdd60835 > src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f > > Diff: https://reviews.apache.org/r/37967/diff/ > > > Testing > --- > > > Thanks, > > Joerg Schad > >
Re: Review Request 38158: Refactored Value::Ranges coalesce().
> On Sept. 23, 2015, 12:58 a.m., Michael Park wrote:
> > src/common/values.cpp, line 301
> > <https://reviews.apache.org/r/38158/diff/13/?file=1081516#file1081516line301>
> >
> > Can we just take a `Value::Ranges` here rather than
> > `initializer_list`?
> >
> > It looks like the only place we actually use this is in `operator+`,
> > for which we can just follow the pattern for `operator-`.
> >
> > ```cpp
> > coalesce(, left);
> > return result += result;
> > ```
> >
> > I think it would also clean up this code significantly, as we wouldn't
> > need the `rangesSum` loop, The `fill` function wouldn't have to be factored
> > out, wouldn't need the `offset` math, etc.
>
> Joerg Schad wrote:
> Would like to avoid coalescing twice, but couldnt we do something along
> the lines
> ```c++
> void coalesce(Value::Ranges* result, Value::Ranges ranges) {
> size_t rangesSum = result->range_size() + ranges->ranges_size();
> ```
>
> In that case I would probably leave fill factored out, but the rest
> (rangesSum, offset) would be simplified.
>
> Joerg Schad wrote:
> Na doesn't really help, will add a more detailed discussion of tradeoffs.
As discussed.
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38158/#review100091
---
On Sept. 22, 2015, 8:55 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38158/
> ---
>
> (Updated Sept. 22, 2015, 8:55 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joris Van Remoortere, and Till
> Toenshoff.
>
>
> Bugs: MESOS-3051
> https://issues.apache.org/jira/browse/MESOS-3051
>
>
> Repository: mesos
>
>
> Description
> ---
>
> The goal of this refactoring was to reuse the Ranges objects as much as
> possible, as prior there was substantial time spend in allocation/destruction
> (MESOS-3051).
>
>
> Diffs
> -
>
> src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f
> src/tests/resources_tests.cpp 0318885336409f7cc9dbd4a3daa9b52db197bbd1
> src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5
>
> Diff: https://reviews.apache.org/r/38158/diff/
>
>
> Testing
> ---
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 37967: Added Non-Freezeer Task Killer. 36620
> On Sept. 22, 2015, 10:37 p.m., Jie Yu wrote: > > Tests? Also, link the JIRA ticket in the review board. Updated Review 36620, this was only my internal stash, sorry for adding mesos as Group. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37967/#review100082 --- On Sept. 22, 2015, 7:43 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37967/ > --- > > (Updated Sept. 22, 2015, 7:43 p.m.) > > > Review request for mesos and Till Toenshoff. > > > Repository: mesos > > > Description > --- > > Added Non-Freezeer Task Killer. 36620 > > > Diffs > - > > src/linux/cgroups.hpp 204c53038a1ccfa693f4f2293488cff8cdd60835 > src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f > > Diff: https://reviews.apache.org/r/37967/diff/ > > > Testing > --- > > > Thanks, > > Joerg Schad > >
Re: Review Request 38158: Refactored Value::Ranges coalesce().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/ --- (Updated Sept. 23, 2015, 12:37 p.m.) Review request for mesos, Bernd Mathiske, Joris Van Remoortere, and Till Toenshoff. Bugs: MESOS-3051 https://issues.apache.org/jira/browse/MESOS-3051 Repository: mesos Description --- The goal of this refactoring was to reuse the Ranges objects as much as possible, as prior there was substantial time spend in allocation/destruction (MESOS-3051). Diffs (updated) - src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f src/tests/resources_tests.cpp 0318885336409f7cc9dbd4a3daa9b52db197bbd1 src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 38158: Refactored Value::Ranges coalesce().
> On Sept. 9, 2015, 3:46 p.m., Alexander Rukletsov wrote:
> > src/common/values.cpp, lines 250-271
> > <https://reviews.apache.org/r/38158/diff/5/?file=1065425#file1065425line250>
> >
> > I think we can conflate this two cases, how about this:
> > ```
> > if (range->end() + 1 >= current.begin()) {
> > range->set_end(std::max(range.end(), current.end()));
> > deleteSet.insert(y);
> > ++i;
> > } else {
> > break;
> > }
> > ```
>
> Joerg Schad wrote:
> Yes we could do this. I personally find the 2 distinct cases (especially
> with the range comments) more readable.
>
> Alexander Rukletsov wrote:
> I think we can also add range comments here to make it more readable : ).
> Usually less branches and less code means faster execution. However, you (and
> your shepherd) decide, means you can drop the issue.
refactored
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38158/#review98200
---
On Sept. 23, 2015, 12:37 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38158/
> ---
>
> (Updated Sept. 23, 2015, 12:37 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joris Van Remoortere, and Till
> Toenshoff.
>
>
> Bugs: MESOS-3051
> https://issues.apache.org/jira/browse/MESOS-3051
>
>
> Repository: mesos
>
>
> Description
> ---
>
> The goal of this refactoring was to reuse the Ranges objects as much as
> possible, as prior there was substantial time spend in allocation/destruction
> (MESOS-3051).
>
>
> Diffs
> -
>
> src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f
> src/tests/resources_tests.cpp 0318885336409f7cc9dbd4a3daa9b52db197bbd1
> src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5
>
> Diff: https://reviews.apache.org/r/38158/diff/
>
>
> Testing
> ---
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 38158: Refactored Value::Ranges coalesce().
> On Sept. 23, 2015, 6:29 p.m., Ben Mahler wrote: > > Where is the benchmark for this change? :( We benchmarked the code with a proprietary benchmark. I added https://issues.apache.org/jira/browse/MESOS-3502 aiming at adding an open-source benchmark for this. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/#review100261 --- On Sept. 23, 2015, 12:37 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38158/ > --- > > (Updated Sept. 23, 2015, 12:37 p.m.) > > > Review request for mesos, Bernd Mathiske, Joris Van Remoortere, and Till > Toenshoff. > > > Bugs: MESOS-3051 > https://issues.apache.org/jira/browse/MESOS-3051 > > > Repository: mesos > > > Description > --- > > The goal of this refactoring was to reuse the Ranges objects as much as > possible, as prior there was substantial time spend in allocation/destruction > (MESOS-3051). > > > Diffs > - > > src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f > src/tests/resources_tests.cpp 0318885336409f7cc9dbd4a3daa9b52db197bbd1 > src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 > > Diff: https://reviews.apache.org/r/38158/diff/ > > > Testing > --- > > make check > > > Thanks, > > Joerg Schad > >
Re: Review Request 38158: Refactored Value::Ranges coalesce().
> On Sept. 23, 2015, 12:58 a.m., Michael Park wrote:
> > src/common/values.cpp, line 204
> > <https://reviews.apache.org/r/38158/diff/13/?file=1081516#file1081516line204>
> >
> > Why not pass by value?
Not sure why you would want to pass either by value. Result we want to use for
the output and the ranges vector I also wouldn't copy.
> On Sept. 23, 2015, 12:58 a.m., Michael Park wrote:
> > src/common/values.cpp, lines 264-289
> > <https://reviews.apache.org/r/38158/diff/13/?file=1081516#file1081516line264>
> >
> > Could we simply `Resize` and not worry about `DeleteSubrange`,
> > `Reserve`, and `add_range`?
> >
> > ```cpp
> > result->mutable_range()->Resize(count, {});
> > ```
afaik Resize is only available for RepeatedFields
https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.repeated_field#RepeatedField.Resize.details
.
Ranges is a RepeatedPtrField which doesn't offer resize.
Please correct me if I am wrong.
> On Sept. 23, 2015, 12:58 a.m., Michael Park wrote:
> > src/common/values.cpp, line 301
> > <https://reviews.apache.org/r/38158/diff/13/?file=1081516#file1081516line301>
> >
> > Can we just take a `Value::Ranges` here rather than
> > `initializer_list`?
> >
> > It looks like the only place we actually use this is in `operator+`,
> > for which we can just follow the pattern for `operator-`.
> >
> > ```cpp
> > coalesce(, left);
> > return result += result;
> > ```
> >
> > I think it would also clean up this code significantly, as we wouldn't
> > need the `rangesSum` loop, The `fill` function wouldn't have to be factored
> > out, wouldn't need the `offset` math, etc.
Would like to avoid coalescing twice, but couldnt we do something along the
lines
```c++
void coalesce(Value::Ranges* result, Value::Ranges ranges) {
size_t rangesSum = result->range_size() + ranges->ranges_size();
```
In that case I would probably leave fill factored out, but the rest (rangesSum,
offset) would be simplified.
- Joerg
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38158/#review100091
---
On Sept. 22, 2015, 8:55 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38158/
> ---
>
> (Updated Sept. 22, 2015, 8:55 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joris Van Remoortere, and Till
> Toenshoff.
>
>
> Bugs: MESOS-3051
> https://issues.apache.org/jira/browse/MESOS-3051
>
>
> Repository: mesos
>
>
> Description
> ---
>
> The goal of this refactoring was to reuse the Ranges objects as much as
> possible, as prior there was substantial time spend in allocation/destruction
> (MESOS-3051).
>
>
> Diffs
> -
>
> src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f
> src/tests/resources_tests.cpp 0318885336409f7cc9dbd4a3daa9b52db197bbd1
> src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5
>
> Diff: https://reviews.apache.org/r/38158/diff/
>
>
> Testing
> ---
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 38158: Refactored Value::Ranges coalesce().
> On Sept. 23, 2015, 12:58 a.m., Michael Park wrote:
> > src/common/values.cpp, line 301
> > <https://reviews.apache.org/r/38158/diff/13/?file=1081516#file1081516line301>
> >
> > Can we just take a `Value::Ranges` here rather than
> > `initializer_list`?
> >
> > It looks like the only place we actually use this is in `operator+`,
> > for which we can just follow the pattern for `operator-`.
> >
> > ```cpp
> > coalesce(, left);
> > return result += result;
> > ```
> >
> > I think it would also clean up this code significantly, as we wouldn't
> > need the `rangesSum` loop, The `fill` function wouldn't have to be factored
> > out, wouldn't need the `offset` math, etc.
>
> Joerg Schad wrote:
> Would like to avoid coalescing twice, but couldnt we do something along
> the lines
> ```c++
> void coalesce(Value::Ranges* result, Value::Ranges ranges) {
> size_t rangesSum = result->range_size() + ranges->ranges_size();
> ```
>
> In that case I would probably leave fill factored out, but the rest
> (rangesSum, offset) would be simplified.
Na doesn't really help, will add a more detailed discussion of tradeoffs.
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38158/#review100091
---
On Sept. 22, 2015, 8:55 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38158/
> ---
>
> (Updated Sept. 22, 2015, 8:55 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joris Van Remoortere, and Till
> Toenshoff.
>
>
> Bugs: MESOS-3051
> https://issues.apache.org/jira/browse/MESOS-3051
>
>
> Repository: mesos
>
>
> Description
> ---
>
> The goal of this refactoring was to reuse the Ranges objects as much as
> possible, as prior there was substantial time spend in allocation/destruction
> (MESOS-3051).
>
>
> Diffs
> -
>
> src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f
> src/tests/resources_tests.cpp 0318885336409f7cc9dbd4a3daa9b52db197bbd1
> src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5
>
> Diff: https://reviews.apache.org/r/38158/diff/
>
>
> Testing
> ---
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 38158: Refactored Value::Ranges coalesce().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/ --- (Updated Sept. 22, 2015, 8:55 p.m.) Review request for mesos, Bernd Mathiske, Joris Van Remoortere, and Till Toenshoff. Bugs: MESOS-3051 https://issues.apache.org/jira/browse/MESOS-3051 Repository: mesos Description --- The goal of this refactoring was to reuse the Ranges objects as much as possible, as prior there was substantial time spend in allocation/destruction (MESOS-3051). Diffs (updated) - src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f src/tests/resources_tests.cpp 0318885336409f7cc9dbd4a3daa9b52db197bbd1 src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 38158: Refactored Value::Ranges coalesce().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/ --- (Updated Sept. 18, 2015, 6:39 a.m.) Review request for mesos, Bernd Mathiske, Joris Van Remoortere, and Till Toenshoff. Bugs: MESOS-3051 https://issues.apache.org/jira/browse/MESOS-3051 Repository: mesos Description --- The goal of this refactoring was to reuse the Ranges objects as much as possible, as prior there was substantial time spend in allocation/destruction (MESOS-3051). Diffs (updated) - include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 38158: Refactored Value::Ranges coalesce().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/ --- (Updated Sept. 17, 2015, 11:34 p.m.) Review request for mesos, Bernd Mathiske and Till Toenshoff. Bugs: MESOS-3051 https://issues.apache.org/jira/browse/MESOS-3051 Repository: mesos Description --- The goal of this refactoring was to reuse the Ranges objects as much as possible, as prior there was substantial time spend in allocation/destruction (MESOS-3051). Diffs (updated) - include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 38158: Refactored Value::Ranges coalesce().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/ --- (Updated Sept. 18, 2015, 5:17 a.m.) Review request for mesos, Bernd Mathiske and Till Toenshoff. Changes --- removed duplicated line... Bugs: MESOS-3051 https://issues.apache.org/jira/browse/MESOS-3051 Repository: mesos Description --- The goal of this refactoring was to reuse the Ranges objects as much as possible, as prior there was substantial time spend in allocation/destruction (MESOS-3051). Diffs (updated) - include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 38158: Refactored Value::Ranges coalesce().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/ --- (Updated Sept. 15, 2015, 8:46 p.m.) Review request for mesos, Bernd Mathiske and Till Toenshoff. Bugs: MESOS-3051 https://issues.apache.org/jira/browse/MESOS-3051 Repository: mesos Description --- The goal of this refactoring was to reuse the Ranges objects as much as possible, as prior there was substantial time spend in allocation/destruction (MESOS-3051). Diffs (updated) - include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 38158: Refactored Value::Ranges coalesce().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/ --- (Updated Sept. 10, 2015, 6:15 p.m.) Review request for mesos, Bernd Mathiske and Till Toenshoff. Bugs: MESOS-3051 https://issues.apache.org/jira/browse/MESOS-3051 Repository: mesos Description --- The goal of this refactoring was to reuse the Ranges objects as much as possible, as prior there was substantial time spend in allocation/destruction (MESOS-3051). Diffs (updated) - include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 38158: Refactored Value::Ranges coalesce().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/ --- (Updated Sept. 9, 2015, 8:48 p.m.) Review request for mesos, Bernd Mathiske and Till Toenshoff. Bugs: MESOS-3051 https://issues.apache.org/jira/browse/MESOS-3051 Repository: mesos Description --- The goal of this refactoring was to reuse the Ranges objects as much as possible, as prior there was substantial time spend in allocation/destruction (MESOS-3051). Diffs (updated) - include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 38158: Refactored Value::Ranges coalesce().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/ --- (Updated Sept. 8, 2015, 7:25 p.m.) Review request for mesos, Bernd Mathiske and Till Toenshoff. Changes --- Added missing dot at end of comment. Bugs: MESOS-3051 https://issues.apache.org/jira/browse/MESOS-3051 Repository: mesos Description --- The goal of this refactoring was to reuse the Ranges objects as much as possible, as prior there was substantial time spend in allocation/destruction (MESOS-3051). Diffs (updated) - include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 38158: Refactored Value::Ranges coalesce().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/ --- (Updated Sept. 8, 2015, 7:22 p.m.) Review request for mesos, Bernd Mathiske and Till Toenshoff. Changes --- Improved the deleting of ranges in coalesce(ranges). Bugs: MESOS-3051 https://issues.apache.org/jira/browse/MESOS-3051 Repository: mesos Description --- The goal of this refactoring was to reuse the Ranges objects as much as possible, as prior there was substantial time spend in allocation/destruction (MESOS-3051). Diffs (updated) - include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 38158: Refactored Value::Ranges coalesce().
> On Sept. 7, 2015, 9:24 p.m., Alexander Rukletsov wrote: > > src/common/values.cpp, line 231 > > <https://reviews.apache.org/r/38158/diff/2/?file=1064869#file1064869line231> > > > > An idea to re-use code here. This function boils down to inserting an > > element into a sorted range and then performing one step of coalescing from > > this element till the end of the sequence. We can keep the insetion > > "virual" and move the elements once during the second coalescing pass (see > > my comment above). New code does only insert a new range if not overlapping/neighboring with existing ranges, otherwise existing ranges are updated. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/#review97937 --- On Sept. 8, 2015, 7:25 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38158/ > --- > > (Updated Sept. 8, 2015, 7:25 p.m.) > > > Review request for mesos, Bernd Mathiske and Till Toenshoff. > > > Bugs: MESOS-3051 > https://issues.apache.org/jira/browse/MESOS-3051 > > > Repository: mesos > > > Description > --- > > The goal of this refactoring was to reuse the Ranges objects as much as > possible, as prior there was substantial time spend in allocation/destruction > (MESOS-3051). > > > Diffs > - > > include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 > src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f > src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 > src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 > > Diff: https://reviews.apache.org/r/38158/diff/ > > > Testing > --- > > make check > > > Thanks, > > Joerg Schad > >
Re: Review Request 38158: Refactored Value::Ranges coalesce().
> On Sept. 7, 2015, 9:24 p.m., Alexander Rukletsov wrote: > > src/common/values.cpp, lines 277-278 > > <https://reviews.apache.org/r/38158/diff/2/?file=1064869#file1064869line277> > > > > Since you're editing here, mind explaining what an "urange" is? As the comment above states it is an Un-coalesced range, will try to highlight that more. > On Sept. 7, 2015, 9:24 p.m., Alexander Rukletsov wrote: > > src/common/values.cpp, line 665 > > <https://reviews.apache.org/r/38158/diff/2/?file=1064869#file1064869line665> > > > > Just to make sure, you have added just `2` lines to this function (not > > easy on RB): > > ``` > > sort(ranges); > > coalesce(ranges); > > ``` > > Correct? And removed one temporary Ranges object (see line 72 in previous version). > On Sept. 7, 2015, 9:24 p.m., Alexander Rukletsov wrote: > > src/common/values.cpp, lines 442-444 > > <https://reviews.apache.org/r/38158/diff/2/?file=1064869#file1064869line442> > > > > Let's let compiler do it's job: how about passing `left` by value and > > not creating a copy manually? Wanted to keep the (internal) interface consistent with the other operators. Do you have a strong preference here? > On Sept. 7, 2015, 9:24 p.m., Alexander Rukletsov wrote: > > src/common/values.cpp, lines 185-186 > > <https://reviews.apache.org/r/38158/diff/2/?file=1064869#file1064869line185> > > > > s/is/are > > > > I would suggest we write high level comments. How about this: "We > > assume ranges are sorted in ascending order of the lower endpoint." ranges is the Ranges object i.e. is, and otherwise I personally find range.begin() a more precise description - Joerg ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/#review97937 --- On Sept. 7, 2015, 6:04 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38158/ > --- > > (Updated Sept. 7, 2015, 6:04 p.m.) > > > Review request for mesos, Bernd Mathiske and Till Toenshoff. > > > Bugs: MESOS-3051 > https://issues.apache.org/jira/browse/MESOS-3051 > > > Repository: mesos > > > Description > --- > > The goal of this refactoring was to reuse the Ranges objects as much as > possible, as prior there was substantial time spend in allocation/destruction > (MESOS-3051). > > > Diffs > - > > include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 > src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f > src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 > src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 > > Diff: https://reviews.apache.org/r/38158/diff/ > > > Testing > --- > > make check > > > Thanks, > > Joerg Schad > >
Re: Review Request 38158: Refactored Value::Ranges coalesce().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/ --- (Updated Sept. 8, 2015, 2:33 p.m.) Review request for mesos, Bernd Mathiske and Till Toenshoff. Bugs: MESOS-3051 https://issues.apache.org/jira/browse/MESOS-3051 Repository: mesos Description --- The goal of this refactoring was to reuse the Ranges objects as much as possible, as prior there was substantial time spend in allocation/destruction (MESOS-3051). Diffs (updated) - include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 38158: Refactored Value::Ranges coalesce().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/ --- (Updated Sept. 7, 2015, 4:57 p.m.) Review request for mesos, Bernd Mathiske and Till Toenshoff. Bugs: MESOS-3051 https://issues.apache.org/jira/browse/MESOS-3051 Repository: mesos Description (updated) --- The goal of this refactoring was to reuse the Ranges objects as much as possible, as prior there was substantial time spend in allocation/destruction (MESOS-3051). Diffs - include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 38158: Refactored Value::Ranges coalesce().
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/ --- (Updated Sept. 7, 2015, 6:04 p.m.) Review request for mesos, Bernd Mathiske and Till Toenshoff. Bugs: MESOS-3051 https://issues.apache.org/jira/browse/MESOS-3051 Repository: mesos Description --- The goal of this refactoring was to reuse the Ranges objects as much as possible, as prior there was substantial time spend in allocation/destruction (MESOS-3051). Diffs (updated) - include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 src/common/values.cpp 750264e603b4cde2011f07f4434a4b34fe3e512f src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56 src/tests/values_tests.cpp fc35d97894a2de6207b9337180e2160e6f2cb1f5 Diff: https://reviews.apache.org/r/38158/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review97885 --- src/Makefile.am (line 1463) <https://reviews.apache.org/r/37168/#comment153951> Any reason for this blank line here? src/examples/dynamic_reservation_framework.cpp (line 281) <https://reviews.apache.org/r/37168/#comment153953> s/get/receives src/examples/dynamic_reservation_framework.cpp (line 283) <https://reviews.apache.org/r/37168/#comment153954> s/TASK_DONE/TASKS_DONE Please correct me if I am wrong: TASK_DONE is a global state across all slaves, while the other states can differ per state, or? Maybe just extend the comment a bit explaining this. src/tests/dynamic_reservation_framework_test.sh (line 30) <https://reviews.apache.org/r/37168/#comment153952> Do we need this here and below in script.cpp? - Joerg Schad On Sept. 6, 2015, 4:11 a.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37168/ > --- > > (Updated Sept. 6, 2015, 4:11 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-3063 > https://issues.apache.org/jira/browse/MESOS-3063 > > > Repository: mesos > > > Description > --- > > Provide example for dynamic reservation features. > > > Diffs > - > > src/Makefile.am 5fdca0f > src/examples/dynamic_reservation_framework.cpp PRE-CREATION > src/tests/dynamic_reservation_framework_test.sh PRE-CREATION > src/tests/examples_tests.cpp 3f56b30 > src/tests/flags.hpp 06da36d > src/tests/script.cpp bcc1fab > > Diff: https://reviews.apache.org/r/37168/diff/ > > > Testing > --- > > make > make check > > > Thanks, > > Klaus Ma > >
Re: Review Request 37168: MESOS-3063
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review97423 --- As this is an example framework (which will be used by people to start their own framework), would it make sense to add some more comments explaining especially the relevant bits here? - Joerg Schad On Aug. 28, 2015, 3:31 a.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37168/ > --- > > (Updated Aug. 28, 2015, 3:31 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-3063 > https://issues.apache.org/jira/browse/MESOS-3063 > > > Repository: mesos > > > Description > --- > > MESOS-3063 (Add an example framework using dynamic reservation) > > > Diffs > - > > src/Makefile.am 7b620ff > src/examples/dynamic_reservation_executor.cpp PRE-CREATION > src/examples/dynamic_reservation_framework.cpp PRE-CREATION > src/tests/dynamic_reservation_framework_test.sh PRE-CREATION > src/tests/examples_tests.cpp 3f56b30 > src/tests/flags.hpp 3644956 > src/tests/script.cpp bcc1fab > > Diff: https://reviews.apache.org/r/37168/diff/ > > > Testing > --- > > make > make check > > > Thanks, > > Klaus Ma > >
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Sept. 2, 2015, 4:16 p.m.) Review request for mesos, Alexander Rukletsov and Bernd Mathiske. Bugs: MESOS-3073 https://issues.apache.org/jira/browse/MESOS-3073 Repository: mesos Description --- Added /quota HTTP Endpoint for Quota handling. Diffs (updated) - src/Makefile.am 7b4d9f65506e7fa8425966009401aae73cdb79a5 src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 36908: Added QuotaInfo Protobuf.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/ --- (Updated Sept. 2, 2015, 1:38 p.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till Toenshoff. Changes --- Rebased and minor rename. Bugs: MESOS-3164 https://issues.apache.org/jira/browse/MESOS-3164 Repository: mesos Description --- Added QuotaInfo Protobuf. Diffs (updated) - include/mesos/master/quota.hpp PRE-CREATION include/mesos/master/quota.proto PRE-CREATION src/Makefile.am 7b4d9f65506e7fa8425966009401aae73cdb79a5 Diff: https://reviews.apache.org/r/36908/diff/ Testing --- make distcheck Thanks, Joerg Schad
Re: Review Request 36908: Added QuotaInfo Protobuf.
> On Aug. 24, 2015, 9:12 p.m., Alexander Rukletsov wrote: > > include/mesos/master/quota.proto, line 19 > > <https://reviews.apache.org/r/36908/diff/4/?file=1032679#file1032679line19> > > > > I think we should version this protobuf. As so far only mesos and scheduler are versioned, we don't do this right now (as discussed). - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review96213 --- On Aug. 5, 2015, 2:03 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36908/ > --- > > (Updated Aug. 5, 2015, 2:03 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till > Toenshoff. > > > Bugs: MESOS-3164 > https://issues.apache.org/jira/browse/MESOS-3164 > > > Repository: mesos > > > Description > --- > > Added QuotaInfo Protobuf. > > > Diffs > - > > include/mesos/master/quota.hpp PRE-CREATION > include/mesos/master/quota.proto PRE-CREATION > src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec > > Diff: https://reviews.apache.org/r/36908/diff/ > > > Testing > --- > > make distcheck > > > Thanks, > > Joerg Schad > >
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Sept. 2, 2015, 1:46 p.m.) Review request for mesos, Alexander Rukletsov and Bernd Mathiske. Changes --- Rebased Bugs: MESOS-3073 https://issues.apache.org/jira/browse/MESOS-3073 Repository: mesos Description --- Added /quota HTTP Endpoint for Quota handling. Diffs (updated) - src/Makefile.am 7b4d9f65506e7fa8425966009401aae73cdb79a5 src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 src/master/quota_handler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36913/diff/ Testing --- make check Thanks, Joerg Schad
Review Request 37892: Renamed cgroups::kill to cgroups::signal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37892/ --- Review request for mesos. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- As this function is actually just sending the signal we renamed it. Additionally we want to introduce an actual cgroups::kill() with MESOS-3086. Diffs - src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f src/tests/containerizer/cgroups_tests.cpp 0b171eeb53037f26b7e952830e88e59f1278e7c6 Diff: https://reviews.apache.org/r/37892/diff/ Testing --- Thanks, Joerg Schad
Re: Review Request 37892: Renamed cgroups::kill to cgroups::signal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37892/ --- (Updated Aug. 28, 2015, 4:12 p.m.) Review request for mesos. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- As this function is actually just sending the signal we renamed it. Additionally we want to introduce an actual cgroups::kill() with MESOS-3086. Diffs (updated) - src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f src/tests/containerizer/cgroups_tests.cpp 0b171eeb53037f26b7e952830e88e59f1278e7c6 Diff: https://reviews.apache.org/r/37892/diff/ Testing --- Thanks, Joerg Schad
Review Request 37894: Renamed cgroups::kill to cgroups::signal.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37894/ --- Review request for mesos, Jie Yu, Till Toenshoff, and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- As this function is actually just sending the signal we renamed it. Additionally we want to introduce an actual cgroups::kill() with MESOS-3086. Diffs - src/linux/cgroups.hpp 204c53038a1ccfa693f4f2293488cff8cdd60835 src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f src/tests/containerizer/cgroups_tests.cpp 0b171eeb53037f26b7e952830e88e59f1278e7c6 Diff: https://reviews.apache.org/r/37894/diff/ Testing --- Thanks, Joerg Schad
Re: Review Request 37894: Renamed cgroups::kill to cgroups::signal.
On Aug. 28, 2015, 4:45 p.m., Cong Wang wrote: Why? Everyone knows kill(2) sends a signal while signal(2) installs a signal handler... Jie Yu wrote: IMO, that naming is confusing, and should be 'signal' and 'install'. This is actually answering a discussion here https://reviews.apache.org/r/36620/#comment152376. And I agree that the original names are weird, but you are right in that we should have an open discussion about this. I will send a mail to dev later on... - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37894/#review96883 --- On Aug. 28, 2015, 4:39 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37894/ --- (Updated Aug. 28, 2015, 4:39 p.m.) Review request for mesos, Jie Yu, Till Toenshoff, and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- As this function is actually just sending the signal we renamed it. Additionally we want to introduce an actual cgroups::kill() with MESOS-3086. Diffs - src/linux/cgroups.hpp 204c53038a1ccfa693f4f2293488cff8cdd60835 src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f src/tests/containerizer/cgroups_tests.cpp 0b171eeb53037f26b7e952830e88e59f1278e7c6 Diff: https://reviews.apache.org/r/37894/diff/ Testing --- Thanks, Joerg Schad
