ther randomly chosen one.
- Till Toenshoff
On May 13, 2016, 2:24 p.m., Abhishek Dasgupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://r
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47061/#review133120
---
Ship it!
Ship It!
- Till Toenshoff
On May 13, 2016, 9:50
> On May 13, 2016, 2:59 p.m., Till Toenshoff wrote:
> > Ship It!
Minus the "debugging artefact?" Alex noted.
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46888/#review132923
---
Ship it!
Ship It!
- Till Toenshoff
On May 12, 2016, 1:36
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47115/#review132914
---
Ship it!
Ship It!
- Till Toenshoff
On May 9, 2016, 9:56 a.m
described in the attached
JIRA was succesful, the idle connection does not prevent new connection
processing anymore.
Thanks,
Till Toenshoff
g/r/46203/#comment195908>
Two blanks please.
- Till Toenshoff
On April 27, 2016, 2:32 p.m., Jan Schlicht wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45438/#review125950
---
Ship it!
Ship It!
- Till Toenshoff
On March 29, 2016, 6:45
https://reviews.apache.org/r/45419/diff/
Testing
---
make check
Thanks,
Till Toenshoff
---
make check
Thanks,
Till Toenshoff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45098/#review124533
---
Ship it!
Ship It!
- Till Toenshoff
On March 21, 2016, 11:19
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45088/#review124530
---
Ship it!
Ship It!
- Till Toenshoff
On March 20, 2016, 7:01
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44227/#review122081
---
Ship it!
Ship It!
- Till Toenshoff
On March 4, 2016, 3:07
> On March 3, 2016, 8:12 p.m., Till Toenshoff wrote:
> > support/mesos-style.py, line 90
> > <https://reviews.apache.org/r/44343/diff/1/?file=1279526#file1279526line90>
> >
> > Are the two leading spaces intentional?
>
> Benjamin Bannier wrot
'tills_awesome_auth_module' not found. Check the spelling
(compare to 'basic'') or verify that the authenticator was loaded successfully
(see --modules)
```
After applying this patch, resulting in:
```
I0304 00:49:45.259122 1064960 master.cpp:555] Using 'tills_awesome_auth_module'
HTTP authenticator
```
Thanks,
Till Toenshoff
---
see summary.
Diffs
-
src/master/master.cpp 2be954d04ab9ba329bac95d815637caf557339cc
Diff: https://reviews.apache.org/r/44370/diff/
Testing
---
make check
Thanks,
Till Toenshoff
g/r/44343/#comment183781>
Are the two leading spaces intentional?
- Till Toenshoff
On March 3, 2016, 5:06 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
parallel tests in action.
src/tests/state_tests.cpp (line 406)
<https://reviews.apache.org/r/44163/#comment183417>
We need to assert here again as the baseclass Setup implementation may have
returned with an empty sandbox container.
- Till Toenshoff
On Feb. 29, 2016, 11:37 a.m., Be
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44096/#review121216
---
Ship it!
Ship It!
- Till Toenshoff
On Feb. 26, 2016, 6:49
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43859/#review120316
---
Ship it!
Ship It!
- Till Toenshoff
On Feb. 23, 2016, 10:58
190)
<https://reviews.apache.org/r/43367/#comment181551>
s/serializes/serialize/
s/will/would/
s/this/task execution/
- Till Toenshoff
On Feb. 18, 2016, 2:54 p.m., haosdent huang wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43359/#review118388
---
Ship it!
Ship It!
- Till Toenshoff
On Feb. 9, 2016, 1:36
g/r/40553/#comment179475>
Whoops, this one was not supposed to get removed.
- Till Toenshoff
On Feb. 4, 2016, 6:14 p.m., James Peach wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
emain.
src/tests/utils.hpp (line 65)
<https://reviews.apache.org/r/40553/#comment179452>
For consistency, let's add a short comment here as well.
- Till Toenshoff
On Feb. 4, 2016, 6:14 p.m., James Peach wrote:
>
> ---
&
> On Feb. 5, 2016, 3:38 a.m., Till Toenshoff wrote:
> > src/slave/containerizer/fetcher.cpp, lines 754-757
> > <https://reviews.apache.org/r/43177/diff/5/?file=1235917#file1235917line754>
> >
> > Will add a blank line inbetween while committing to give this
tps://reviews.apache.org/r/43177/#comment179255>
Will add a blank line inbetween while committing to give this code some air
:).
- Till Toenshoff
On Feb. 5, 2016, 3:36 a.m., Shuai Lin wrote:
>
> ---
> This is an automatica
> On Feb. 5, 2016, 3:20 a.m., Till Toenshoff wrote:
> > We need a centralized solution here. Same as MESOS-4598 however, this is
> > fine for a fix, I believe.
ow. please fix this - I totally missed the fact that you are removing the IP
and not the
-4598 however, this is fine
for a fix, I believe.
- Till Toenshoff
On Feb. 5, 2016, 3:09 a.m., Shuai Lin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
tps://reviews.apache.org/r/42908/#comment179247>
I feel this comment as-is does not add much.
Either removing it or supplying a reasoning in that comment would be more
helpful, no?
- Till Toenshoff
On Jan. 29, 2016, 10:34 a.m., Alexander Rukletsov
centralized fix as proposed
in the comments of the attached JIRA issue.
- Till Toenshoff
On Feb. 4, 2016, 11:17 p.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
we prefer to wrap at assignments if possible. Then given that this
is not an argument wrapping, we now indent by 2 spaces.
- Till Toenshoff
On Jan. 27, 2016, 6:44 p.m., James Peach wrote:
>
> ---
> This is an automatically gen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39780/#review117783
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 27, 2016, 6:47
ply, visit:
> https://reviews.apache.org/r/41871/
> ---
>
> (Updated Jan. 11, 2016, 5:22 p.m.)
>
>
> Review request for mesos, Joerg Schad, Michael Park, and Till Toenshoff.
>
>
> Bugs: MESOS-4271
> https://issues.apache.org/jira/browse/MESOS-427
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42247/#review117165
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 25, 2016, 2:35
,
Till Toenshoff
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42255/#review115494
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 18, 2016, 11:46 a.m
> On Jan. 20, 2016, 7:37 p.m., Till Toenshoff wrote:
> > src/master/http.cpp, lines 549-553
> > <https://reviews.apache.org/r/42027/diff/5/?file=1200104#file1200104line549>
> >
> > To prosterity; this means that we currently do not support mixed usage
tps://reviews.apache.org/r/42027/#comment176419>
To prosterity; this means that we currently do not support mixed usage of
old API and HTTP API for frameworks as soon as the master has enabled mandatory
framework authentication.
- Till Toenshoff
On Jan. 20, 2016, 2:03 p.m., Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42140/#review115432
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 18, 2016, 10:53 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42144/#review115431
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 11, 2016, 3:07 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42143/#review115428
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 13, 2016, 6:13 p.m
)
<https://reviews.apache.org/r/42458/#comment175993>
I would like to make it a bit more deterministic...
How about something like:
```
We use the following format for links pointing to pages within the
documentation folder:
```
- Till Toenshoff
On Jan. 19, 2
of us -- certainly not
me -- NO! -- NOT ME! -- ok, also me :)
- Till Toenshoff
On Jan. 18, 2016, 1:20 p.m., Joerg Schad wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
> On Jan. 18, 2016, 4:26 p.m., Till Toenshoff wrote:
> > src/tests/fetcher_cache_tests.cpp, line 837
> > <https://reviews.apache.org/r/42149/diff/4/?file=1200150#file1200150line837>
> >
> > Lets either remove the brackets, making this an equally important
;
Given that pause() and resume() will always be used on the same thread, we
dont have a race here accross an already used latch just after this case, right?
- Till Toenshoff
On Jan. 18, 2016, 11:28 a.m., Bernd Mathiske wrote:
>
> --
eviews.apache.org/r/42197/#comment175835>
s/cycles/cpu-cycles/
src/tests/environment.cpp (line 347)
<https://reviews.apache.org/r/42197/#comment175836>
s/cycles/cpu-cycles/
- Till Toenshoff
On Jan. 15, 2016, 2:38 p.m., Jan Schlicht wrote:
>
>
cycles [Hardware event]
```
More on that on
https://issues.apache.org/jira/browse/MESOS-3082?focusedCommentId=15101208&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15101208
- Till Toenshoff
On Jan. 14, 2016, 3:28 p.m., Jan Schl
!
support/post-reviews.py (line 111)
<https://reviews.apache.org/r/42309/#comment175484>
Minor nit, missing '.' - fixing this while committing.
- Till Toenshoff
On Jan. 15, 2016, 1:04 a.m., Kevin Klues wrote:
>
> --
- thanks Kevin!
- Till Toenshoff
On Jan. 14, 2016, 1:29 a.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
,
Till Toenshoff
ation, at line 36).
- Till Toenshoff
On Jan. 13, 2016, 6:41 p.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42262/#review114321
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 13, 2016, 11:10 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42263/#review114320
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 13, 2016, 8:38 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42253/#review114239
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 13, 2016, 3:26 p.m
es sense to show this for all platforms
that dont run the tests, just like we do e.g. for the below netcat stuff. Or am
I missing something?
- Till Toenshoff
On Jan. 13, 2016, 3:23 p.m., Jan Schlicht wrote:
>
> ---
> This is an
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42196/#review114236
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 13, 2016, 3:18 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39782/#review114193
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 12, 2016, 10:14 p.m
.
- Till Toenshoff
On Jan. 13, 2016, 10:34 a.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/flags.hpp (lines 242 -
257)
<https://reviews.apache.org/r/41882/#comment175010>
Much slicker now, thanks for the suggestion Alexander!
The comment helps understanding the ghist, gj!
- Till Toenshoff
On Jan. 13, 2016, 10:43 a.m., Benjamin Bannier
> On Jan. 13, 2016, 10:04 a.m., Till Toenshoff wrote:
> > bootstrap, line 15
> > <https://reviews.apache.org/r/41243/diff/4/?file=1192325#file1192325line15>
> >
> > This would introduce Python as a hard dependency of the Mesos build
> > environment
243/#comment175001>
This would introduce Python as a hard dependency of the Mesos build
environment.
We should avoid this.
- Till Toenshoff
On Jan. 11, 2016, 8:12 p.m., Kevin Klues wrote:
>
> ---
> This is an automatica
s.apache.org/r/41429/#comment174185>
Include "stout/none.hpp" please.
src/tests/environment.cpp (line 166)
<https://reviews.apache.org/r/41429/#comment174182>
Include "stout/option.hpp" please.
- Till Toenshoff
On Jan. 7, 2016, 8 p.m., Greg Mann wrote:
>
&
> On Dec. 17, 2015, 3:42 a.m., Till Toenshoff wrote:
> > Ship It!
Sorry for the delay -- this patch now needs a rebase.
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.or
tps://reviews.apache.org/r/41649/#comment174179>
Intentional blank?
src/slave/containerizer/containerizer.hpp (line 138)
<https://reviews.apache.org/r/41649/#comment174181>
So this was an error as the checkpoint flag is passed on from the
frameworkInfo as discussed.
- Till Toensh
r/master.cpp (line 528)
<https://reviews.apache.org/r/39043/#comment173987>
s/.//
src/tests/mesos.cpp (line 436)
<https://reviews.apache.org/r/39043/#comment173989>
As discussed and commented by Alex, that addition about the risks in
multi-master configurations are a good
n. 7, 2016, 4:41 p.m., Alexander Rojas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39043/
> ---
>
> (Updated Jan. 7, 2016, 4:41 p.m.)
>
>
> Review request fo
tps://reviews.apache.org/r/40975/#comment173993>
`EPIPE` in backticks makes sense, I think
- Till Toenshoff
On Jan. 7, 2016, 5:30 p.m., James Peach wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
mp --credentials=file://some_valid_file
./src/test-framework --master=127.0.0.1:5050
curl --data "frameworkId=valid_framework_id" 127.0.0.1:5050/teardown -v
-> succeeds with "HTTP/1.1 200 OK"
curl --user some:credentials --data "frameworkId=valid_framework_id"
127.0.0.1:5050/teardown -v
-> succeeds with "HTTP/1.1 200 OK"
Thanks,
Till Toenshoff
nd of log/exit lines.
Dang, thanks!
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42025/#review113336
---
On Jan. 7, 2016, 8:
credentials=file://some_valid_file
./src/test-framework --master=127.0.0.1:5050
curl --data "frameworkId=valid_framework_id" 127.0.0.1:5050/teardown -v
-> succeeds with "HTTP/1.1 200 OK"
curl --user some:credentials --data "frameworkId=valid_framework_id"
127.0.0.1:5050/teardown -v
-> succeeds with "HTTP/1.1 200 OK"
Thanks,
Till Toenshoff
endpoint
> > requiring authentification are allowed.
> >
> > 'If false also unauthenticated requests for HTTP endpoint
> > requiring authentification are also allowed.'
>
> Till Toenshoff wrote:
> aye!
>
> Till
an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42025/#review113301
-------
On Jan. 7, 2016, 7:12 p.m., Till Toenshoff wrote:
>
> ---
> This is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42025/#review113293
-------
On Jan. 7, 2016, 7:12 p.m., Till Toenshoff wrote:
>
> -
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42025/#review113255
---
On Jan. 7, 2016, 2:38 p.m., Till Toenshoff wrote:
>
> -
-
https://reviews.apache.org/r/41927/ fixed the problem in a preferred way.
Thanks for your submission, Ian!
- Till Toenshoff
On Jan. 4, 2016, 3:43 a.m., Ian Babrou wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41548/#review113075
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 6, 2016, 2:37 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41550/#review113067
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 6, 2016, 1:15 p.m
/#comment173572>
s/http/HTTP/
s/teshttpauthenticator/testhttpauthenticator/
- Till Toenshoff
On Jan. 5, 2016, 4:17 p.m., Alexander Rojas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
> On Jan. 5, 2016, 7:49 p.m., Till Toenshoff wrote:
> > src/tests/registrar_tests.cpp, line 909
> > <https://reviews.apache.org/r/41622/diff/2/?file=1182172#file1182172line909>
> >
> > Seems `std::set` also can lose that namespace.
>
> Greg Mann wr
> On Jan. 5, 2016, 7:49 p.m., Till Toenshoff wrote:
> > src/tests/registrar_tests.cpp, line 909
> > <https://reviews.apache.org/r/41622/diff/2/?file=1182172#file1182172line909>
> >
> > Seems `std::set` also can lose that namespace.
>
> Greg Mann wr
sed?!
src/tests/registrar_tests.cpp (line 909)
<https://reviews.apache.org/r/41622/#comment173388>
Seems `std::set` also can lose that namespace.
- Till Toenshoff
On Jan. 5, 2016, 7:12 p.m., Greg Mann wrote:
>
> ---
> This is
> On Dec. 7, 2015, 9:42 p.m., Neil Conway wrote:
> > What is the status of this patch -- can someone (Till) commit it?
>
> Greg Mann wrote:
> Looks like this is in need of a rebase, I'll update it.
Sry, did not have it on my radar -- it's always a good idea to add me as a
reviewer for prev
Updated Jan. 5, 2016, 3:13 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
>
>
> Bugs: MESOS-4083
> https://issues.apache.org/jira/browse/MESOS-4083
>
>
> Repository: mesos
>
>
> Description
> ---
>
&g
src/tests/master_quota_tests.cpp (line 1119)
<https://reviews.apache.org/r/41550/#comment173373>
Blank line?
src/tests/master_quota_tests.cpp (line 1122)
<https://reviews.apache.org/r/41550/#comment173374>
Blank line?
- Till Toenshoff
On Jan. 5, 2016, 3:13
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41550/
> ---
>
> (Updated Jan. 5, 2016, 3:13 p.m.)
>
>
> Review req
tps://reviews.apache.org/r/41549/#comment173366>
s/Principal/Principals/ ?
- Till Toenshoff
On Jan. 5, 2016, 11:17 a.m., Jan Schlicht wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
utating that `create.get()` result directly.
How about making `quotaInfo` above a copy (instead of a reference) and then
modifying that one here, if needed?
src/master/quota_handler.cpp (lines 524 - 525)
<https://reviews.apache.org/r/41548/#comment173361>
No snake case here please!
r principal".
- Till Toenshoff
On Jan. 5, 2016, 11:16 a.m., Jan Schlicht wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41879/#review112852
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 5, 2016, 8:27 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41878/#review112851
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 5, 2016, 8:23 a.m
> On Jan. 5, 2016, 1:41 p.m., Till Toenshoff wrote:
> > Ship It!
Thanks for describing your testing that well!
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41927/#rev
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41927/#review112846
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 5, 2016, 1:14 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40966/#review112836
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 5, 2016, 12:34 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41546/#review112834
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 5, 2016, 11:15 a.m
sos.hpp:1046:3: note: candidate constructor not viable:
requires 4 arguments, but 3 were provided
MockDockerContainerizer(
```
src/tests/health_check_tests.cpp (line 265)
<https://reviews.apache.org/r/40966/#comment173304>
Insert a blank line, please.
- Till Toenshoff
On Jan. 5, 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41872/#review112564
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 4, 2016, 9:23 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41871/#review112549
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 4, 2016, 9:12 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41882/#review112546
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 4, 2016, 11:06 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41875/#review112545
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 4, 2016, 9:41 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41876/#review112544
---
Ship it!
Ship It!
- Till Toenshoff
On Jan. 4, 2016, 9:41 a.m
801 - 900 of 1274 matches
Mail list logo
