tps://reviews.apache.org/r/36036/#comment142912>
s/5051/5050/
src/master/master.cpp (line 369)
<https://reviews.apache.org/r/36036/#comment142914>
s/Release/Version/
- Vinod Kone
On June 30, 2015, 11:23 p.m., Marco Mas
st.sh
7984559e8ad7e0c1b0dda2355f06b4fc9da5103e
src/tests/low_level_scheduler_pthread_test.sh
c6e7115f2db635e352fb2122e0cb9f6af2613760
Diff: https://reviews.apache.org/r/36077/diff/
Testing
---
make check
Thanks,
Vinod Kone
ed9e7d6
src/tests/scheduler_tests.cpp cbe6c91a1b4f864ceb11cf062da0ada6c9666f9f
Diff: https://reviews.apache.org/r/36078/diff/
Testing
---
make check
Thanks,
Vinod Kone
https://reviews.apache.org/r/35855/diff/
Testing
---
make check
Thanks,
Vinod Kone
/
Testing
---
make check
Thanks,
Vinod Kone
https://reviews.apache.org/r/35858/diff/
Testing
---
make check
Thanks,
Vinod Kone
r.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064
src/master/master.cpp 34ce744f84465ecc9aeecd5fdc3d06047a4b7d92
src/scheduler/scheduler.cpp f360e4d062488986b14e3d48d140996e8ed9e7d6
Diff: https://reviews.apache.org/r/36079/diff/
Testing
---
make check
Thanks,
Vinod Kone
add a new test because an existing test
(SchedulerTest.TaskRunning) already exercises this code path.
Thanks,
Vinod Kone
I've been changing protobufs formats/tags without compatibility concerns.
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36078/#review90009
-----
work_info" as optional and keep setting it for older Masters?
see my comment above about compatibility.
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36078/#review90011
----
make check
Thanks,
Vinod Kone
7;s worded now, it seems a bit hard to get the higher level
> > picture, maybe rephrase given my other suggestion below?
> >
> > ```
> > // New schedulers will be assigned an identifier by the master during
> > // the initial Subscribe call, by leavi
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35855/#review89331
---
On July 1, 2015, 5:24 a.m., Vinod Kone wrote:
>
> --
--------
On July 1, 2015, 5:24 a.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35855/
> -
34ce744f84465ecc9aeecd5fdc3d06047a4b7d92
src/scheduler/scheduler.cpp f360e4d062488986b14e3d48d140996e8ed9e7d6
src/tests/scheduler_tests.cpp cbe6c91a1b4f864ceb11cf062da0ada6c9666f9f
Diff: https://reviews.apache.org/r/35855/diff/
Testing
---
make check
Thanks,
Vinod Kone
n automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35856/#review89436
-------
On July 1, 2015, 5:25 a.m., Vinod Kone wrote:
>
> ---
> This is an automatically
,
Vinod Kone
------
On July 1, 2015, 5:26 a.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35857/
> ---
nning) already exercises this code path.
Thanks,
Vinod Kone
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35858/#review89369
---
On July 1, 2015, 5:26 a.m., Vinod Kone wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35858/#review89384
-------
On July 1, 2015, 5:26 a.m., Vinod Kone wrote:
>
> --
,
Vinod Kone
36079/diff/
Testing
---
make check
Thanks,
Vinod Kone
666f9f
Diff: https://reviews.apache.org/r/36078/diff/
Testing
---
make check
Thanks,
Vinod Kone
hange!!
I would recommend adding new endpoints with the same name but without .json
extension in one release, send a deprecation notice to the dev list and remove
the .json endpoints in the next release.
- Vinod Kone
On July 2, 2015, 7:42 a.m., Isabel Jimenez
-
>
> (Updated July 2, 2015, 7:50 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and
> Vinod Kone.
>
>
> Bugs: MESOS-2983
> https://issues.apache.org/jira/browse/MESOS-2983
>
>
> Repository: mesos-incubating
>
(lines 41 - 42)
<https://reviews.apache.org/r/36152/#comment143404>
I don't think we need these either because you are already calling out
MESOS-2955
CHANGELOG (line 44)
<https://reviews.apache.org/r/36152/#comment143403>
ditto.
- Vinod Kone
O
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36200/#review90506
---
Ship it!
Thank you!
- Vinod Kone
On July 6, 2015, 1:38 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36189/#review90512
---
Ship it!
Ship It!
- Vinod Kone
On July 6, 2015, 3:29 p.m
removed?
- Vinod Kone
On June 29, 2015, 7:20 p.m., Jiang Yan Xu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
269/#comment143884>
I would just put this under deprecations section.
Also, mind updating MESOS-2058 in deprecation section to do
s/deprecate/remove/ because its been removed.
- Vinod Kone
On July 7, 2015, 5:59 p.m., Jiang Yan Xu
> On July 7, 2015, 6:40 p.m., Vinod Kone wrote:
> > CHANGELOG, line 337
> > <https://reviews.apache.org/r/36269/diff/1/?file=1001355#file1001355line337>
> >
> > I would just put this under deprecations section.
> >
> > Also, mind upd
upport/post-reviews.py (line 173)
<https://reviews.apache.org/r/35777/#comment143908>
Why 'format' instead of directly printing the message with a %s? Just
curious.
- Vinod Kone
On July 7, 2015, 3:19 p.m., Michael Park wrote:
>
> -
tps://reviews.apache.org/r/36299/#comment144092>
kill ws
- Vinod Kone
On July 8, 2015, 8:48 a.m., Adam B wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
-mail. To reply, visit:
> https://reviews.apache.org/r/34136/
> ---
>
> (Updated June 22, 2015, 4:42 p.m.)
>
>
> Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
>
>
> Repository: mesos
>
>
>
tps://reviews.apache.org/r/34136/#comment144200>
Add a comment that only one of these should be set.
- Vinod Kone
On June 22, 2015, 4:42 p.m., Ian Downes wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34136/
> ---
>
> (Updated June 22, 2015, 4:42 p.m.)
>
>
> Revie
why include the container id?
src/slave/containerizer/provisioner.hpp (lines 59 - 60)
<https://reviews.apache.org/r/34137/#comment144228>
What does this return?
src/slave/containerizer/provisioner.cpp (line 37)
<https://reviews.apache.org/r/34137/#comment144229>
if (flags.
7:42 p.m.)
>
>
> Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> The MesosContainerizer can optionally provision a root filesystem for the
> containers.
>
>
havent
encountered an issue so far?
- Vinod Kone
On July 8, 2015, 10:50 p.m., Paul Brett wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
pull this below #2998 so that webui_url testing is all in one block.
also, you captured 'Capability' into an JSON::array but doing nothing with
it? did you forget to add an EXPECT_EQ to make sure this value is the same as
the one you added in #2958?
- Vinod Kone
On
che.org/r/34138/#comment144423>
This should take a 'Path' type instead of 'string'.
src/slave/containerizer/provisioners/appc/hash.hpp (line 69)
<https://reviews.apache.org/r/34138/#comment144425>
looks like 'command()' is only used once here. why spli
> On July 9, 2015, 6:47 p.m., Vinod Kone wrote:
> >
Also, we need tests!?
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34138/#re
on stuff in the current
review and its dependent reviews. it's hard to review o.w.
- Vinod Kone
On July 7, 2015, 7:42 p.m., Ian Downes wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
.x master for
completeness?
- Vinod Kone
On July 9, 2015, 6:55 p.m., Ben Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36450/#review91506
---
LGTM. Will wait for the test before giving shipit.
- Vinod Kone
is for you.
- Vinod Kone
On July 12, 2015, 6:25 p.m., Aditi Dixit wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
the revive workflow, but it
didn't need any update)
Thanks,
Vinod Kone
---
make check
Thanks,
Vinod Kone
57721b788d0c70f4c6f5cc44d87465f52a70b6c2
Diff: https://reviews.apache.org/r/36463/diff/
Testing
---
make check
Thanks,
Vinod Kone
440b07475e28dc491ab640acaca8ee20db8411f8
Diff: https://reviews.apache.org/r/36467/diff/
Testing
---
make check
Thanks,
Vinod Kone
/
Testing
---
make check
Thanks,
Vinod Kone
/
Testing
---
make check
Thanks,
Vinod Kone
/
Testing
---
make check
Thanks,
Vinod Kone
/
Testing
---
Tested in subsequent reviews.
Thanks,
Vinod Kone
://reviews.apache.org/r/36461/diff/
Testing
---
Tested in subsequent reviews.
Thanks,
Vinod Kone
> On July 8, 2015, 11:34 p.m., Vinod Kone wrote:
> > can you please set the dependency for this review correctly? it's hard to
> > understand which reviews introduced the code that this review depends on.
none of the dropped issues have comments. did you forget to hit publi
tainerizer/provisioner.cpp (lines 41 - 44)
<https://reviews.apache.org/r/34137/#comment145206>
Why do you need foreach loop here if you were going to return error anyway?
- Vinod Kone
On July 12, 2015, 4:47 a.m., Ian Downes wrote:
>
> ---
directory?
- Vinod Kone
On July 15, 2015, 4:11 p.m., James Peach wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
aster/master.cpp b877676afa6f3833eb7d2fb06beeaa288bd8bd5d
src/tests/scheduler_tests.cpp 946fa8245d8ab35e04bad642d69114caf0ccf6a9
Diff: https://reviews.apache.org/r/36518/diff/
Testing
---
make check
Thanks,
Vinod Kone
hanks.
src/master/http.cpp (line 125)
<https://reviews.apache.org/r/35687/#comment145437>
'framework' should be aligned with 'const'.
src/tests/master_tests.cpp (line 2957)
<https://reviews.apache.org/r/35687/#comment145439>
s/capabilityName/capabilityTy
tps://reviews.apache.org/r/36493/#comment145444>
Do you know why it doesn't resolve? Does stringify() help?
- Vinod Kone
On July 15, 2015, 1:47 a.m., Ben Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To r
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35752/#review91798
---
Ship it!
Ship It!
- Vinod Kone
On July 15, 2015, 1:47 a.m., Ben
g/r/36450/#comment145445>
s/ip/IP/
src/common/type_utils.cpp (line 131)
<https://reviews.apache.org/r/36450/#comment145447>
Is the order of query parameters important? Aren't these URLs equivalent?
http://a.b.c/?k1=a&k2=b
http://a.b.c/?k2=b&k1=a
org/r/36494/#comment145458>
instead of calling into frameworkMessage() here can you have
frameworkMessage() call into a new message(const Event& event) method?
this is how we did it in the master and i think it will make deprecating
old message handlers easy.
- Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36410/#review91822
---
Ship it!
Ship It!
- Vinod Kone
On July 11, 2015, 12:09 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36412/#review91911
---
Ship it!
Ship It!
- Vinod Kone
On July 11, 2015, 12:09 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36411/#review91912
---
Ship it!
Ship It!
- Vinod Kone
On July 11, 2015, 12:09 a.m
tps://reviews.apache.org/r/36412/#comment145630>
I would recommend to keep the IDLE check because that code still exists.
- Vinod Kone
On July 11, 2015, 12:09 a.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
<https://reviews.apache.org/r/36413/#comment145632>
I see. So you removed it here. Can you remove it from the test in this
review instead of the previous one?
- Vinod Kone
On July 11, 2015, 12:09 a.m., Jie Yu wrote:
>
> -
)
<https://reviews.apache.org/r/36494/#comment145658>
Can you add a comment here saying that you are simulating master sending
the event?
- Vinod Kone
On July 15, 2015, 1:47 a.m., Ben Mahler wrote:
>
> ---
> This is a
tps://reviews.apache.org/r/36495/#comment145661>
Add a TODO here to refactor.
src/tests/scheduler_event_call_tests.cpp (line 85)
<https://reviews.apache.org/r/36495/#comment145659>
ditto. comment.
- Vinod Kone
On July 15, 2015, 1:47 a.m., Ben
> On July 15, 2015, 8:46 p.m., Vinod Kone wrote:
> > src/sched/sched.cpp, lines 490-493
> > <https://reviews.apache.org/r/36494/diff/1/?file=1011986#file1011986line490>
> >
> > instead of calling into frameworkMessage() here can you have
> > framework
496/#comment145663>
TODO for refactor.
src/tests/scheduler_event_call_tests.cpp (line 170)
<https://reviews.apache.org/r/36496/#comment145664>
comment.
- Vinod Kone
On July 15, 2015, 1:47 a.m., Ben Mahler wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36496/#review91933
---
Ship it!
Ship It!
- Vinod Kone
On July 15, 2015, 1:47 a.m., Ben
plit this into its own test.
src/tests/scheduler_event_call_tests.cpp (line 158)
<https://reviews.apache.org/r/36497/#comment145680>
comment.
- Vinod Kone
On July 15, 2015, 1:47 a.m., Ben Mahler wrote:
>
>
use createTask()?
src/tests/scheduler_event_call_tests.cpp (line 237)
<https://reviews.apache.org/r/36498/#comment145695>
Why capture the executor driver when it's not used?
- Vinod Kone
On July 15, 2015, 1:47 a.m., Ben Mahler wrote:
>
> --
145705>
No need for driver.stop() and driver.join()? Shutdown()?
- Vinod Kone
On July 15, 2015, 1:47 a.m., Ben Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
> On July 16, 2015, 6:20 p.m., Vinod Kone wrote:
> > src/tests/scheduler_event_call_tests.cpp, line 91
> > <https://reviews.apache.org/r/36494/diff/1/?file=1011987#file1011987line91>
> >
> > Can you add a comment here saying that you are simulating master
SERT.
s/masterStateObject_/state/
src/tests/fault_tolerance_tests.cpp (line 1812)
<https://reviews.apache.org/r/35797/#comment145736>
s/famework_/framework/
new line after this.
src/tests/fault_tolerance_tests.cpp (line 1831)
<https://reviews.apache.org/r/35797
l_framework.cpp
17fdcac44c0a51293a318ef5184f4d48a461abd9
src/tests/scheduler_tests.cpp 946fa8245d8ab35e04bad642d69114caf0ccf6a9
Diff: https://reviews.apache.org/r/36560/diff/
Testing
---
make check
Thanks,
Vinod Kone
p the condition consistent across all of
> > these checks (i.e. has_id && id != ""), up to you.
> >
> > At least, would be nice to add an != operator for FrameworkID vs string.
updated the condition. i'll add a TODO to add != operator and do a sweep.
- Vinod
--
k
Thanks,
Vinod Kone
?
s/n/message/
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36461/#review91757
---
On July 13, 2015, 11:55 p.m., Vinod Kone wrote:
>
clude/process/gmock.hpp
e8781610f636954b39611fcb1de310a78ceea7cb
Diff: https://reviews.apache.org/r/36461/diff/
Testing
---
Tested in subsequent reviews.
Thanks,
Vinod Kone
s.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3
Diff: https://reviews.apache.org/r/36462/diff/
Testing
---
Tested in subsequent reviews.
Thanks,
Vinod Kone
y.
>
>
> Diffs
> -
>
> src/sched/sched.cpp a748686dfc6bff39d81fd7adbd5cce88ddaaa73d
> src/tests/master_tests.cpp 57721b788d0c70f4c6f5cc44d87465f52a70b6c2
>
> Diff: https://reviews.apache.org/r/36464/diff/
>
>
> Testing
> ---
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
fter setting type. i'll make sure it's consistent.
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36465/#review91765
------
s.cpp 1070ccf17f98f6b3800684a5edd6517d90631c3e
src/tests/master_tests.cpp 767c86cbde31eeb49d110d04bfb5a3eb5d469afc
Diff: https://reviews.apache.org/r/36463/diff/
Testing
---
make check
Thanks,
Vinod Kone
eviews.apache.org/r/36463/#review91762
---
On July 13, 2015, 11:58 p.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To rep
s.cpp 767c86cbde31eeb49d110d04bfb5a3eb5d469afc
Diff: https://reviews.apache.org/r/36464/diff/
Testing
---
make check
Thanks,
Vinod Kone
s.cpp 89cc7f68b33b037626ca6056647c360b5a6d5901
src/tests/status_update_manager_tests.cpp
440b07475e28dc491ab640acaca8ee20db8411f8
Diff: https://reviews.apache.org/r/36467/diff/
Testing
---
make check
Thanks,
Vinod Kone
generated e-mail. To reply, visit:
https://reviews.apache.org/r/36469/#review91770
---
On July 14, 2015, 12:30 a.m., Vinod Kone wrote:
>
> ---
> This
s.cpp 1070ccf17f98f6b3800684a5edd6517d90631c3e
src/tests/slave_recovery_tests.cpp 2f882cf7b4235583b0ec8397cfcbbc02930fbc88
Diff: https://reviews.apache.org/r/36469/diff/
Testing
---
make check
Thanks,
Vinod Kone
s.cpp 49d907b0be45ccfed8af5c8fda89ad560e012c1e
src/tests/slave_recovery_tests.cpp 2f882cf7b4235583b0ec8397cfcbbc02930fbc88
Diff: https://reviews.apache.org/r/36470/diff/
Testing
---
make check
Thanks,
Vinod Kone
49d907b0be45ccfed8af5c8fda89ad560e012c1e
src/tests/slave_recovery_tests.cpp 2f882cf7b4235583b0ec8397cfcbbc02930fbc88
Diff: https://reviews.apache.org/r/36470/diff/
Testing
---
make check
Thanks,
Vinod Kone
/
Testing
---
make check
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36562/#review92115
---
Ship it!
Ship It!
- Vinod Kone
On July 17, 2015, 1:36 a.m., Ben
tps://reviews.apache.org/r/36497/#comment146054>
there is no master UPID anymore. update the comment?
src/sched/sched.cpp (line 465)
<https://reviews.apache.org/r/36497/#comment146055>
s/required/relied/ ?
- Vinod Kone
On July 17, 2015, 1:36 a.m., Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36450/#review92118
---
Ship it!
Ship It!
- Vinod Kone
On July 17, 2015, 1:36 a.m., Ben
501 - 600 of 3244 matches
Mail list logo
