Re: Review Request 43608: Speed up FetcherCache test cases by disable framework checkpoint.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43608/
---

(Updated Feb. 17, 2016, 2:10 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
Mathiske.


Changes
---

Rebase


Bugs: MESOS-4685
https://issues.apache.org/jira/browse/MESOS-4685


Repository: mesos


Description
---

Speed up FetcherCache test cases by disable framework checkpoint.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp fc89be46bc4cca81f6f3f5072539d3dae26f7c8f 

Diff: https://reviews.apache.org/r/43608/diff/


Testing
---

When we enable checkpoint for frameworks, StatusUpdateManager would waiting for 
write StatusUpdateRecord to file and then boardcast it. This cause uncessary 
disk operations and bring unstable delay if our test cases don't depends on 
recovery.  

Before
```
[   OK ] FetcherCacheTest.LocalUncached (2645 ms)
[   OK ] FetcherCacheTest.LocalCached (2653 ms)
[   OK ] FetcherCacheTest.CachedFallback (1110 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (2620 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (2758 ms)
[   OK ] FetcherCacheTest.SimpleEviction (5059 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2648 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3661 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2600 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (2013 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1746 ms)
```

After
```
[   OK ] FetcherCacheTest.LocalUncached (2580 ms)
[   OK ] FetcherCacheTest.LocalCached (2516 ms)
[   OK ] FetcherCacheTest.CachedFallback (957 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (2519 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (2594 ms)
[   OK ] FetcherCacheTest.SimpleEviction (4532 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2579 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3528 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2520 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1534 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1345 ms)
```

And test the recovery test manually:
```
./bin/mesos-tests.sh 
--gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
```


Thanks,

haosdent huang

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
---

(Updated Feb. 17, 2016, 2:11 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
Mathiske.


Changes
---

Rebase.


Bugs: MESOS-4628
https://issues.apache.org/jira/browse/MESOS-4628


Repository: mesos


Description
---

Speed up FetcherCache test cases by reduce allocation_interval.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp fc89be46bc4cca81f6f3f5072539d3dae26f7c8f 

Diff: https://reviews.apache.org/r/43367/diff/


Testing
---

In this patch, we use 500ms instead of the default allocation_interval 1s. If 
the test cases depends on getting offers from master multiple times, this patch 
could reduce the offer waiting time and speed up them. 

Before
```
[   OK ] FetcherCacheTest.LocalUncached (943 ms)
[   OK ] FetcherCacheTest.LocalCached (1612 ms)
[   OK ] FetcherCacheTest.CachedFallback (906 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
[   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)

```

After
```
[   OK ] FetcherCacheTest.LocalUncached (979 ms)
[   OK ] FetcherCacheTest.LocalCached (1510 ms)
[   OK ] FetcherCacheTest.CachedFallback (853 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[   OK ] FetcherCacheTest.SimpleEviction (2720 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
```


Thanks,

haosdent huang

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test by reduce loop.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/
---

(Updated Feb. 17, 2016, 2:10 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
Mathiske.


Changes
---

Rebase


Bugs: MESOS-4486
https://issues.apache.org/jira/browse/MESOS-4486


Repository: mesos


Description
---

Speed up FetcherCacheTest.Local* test by reduce loop.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp fc89be46bc4cca81f6f3f5072539d3dae26f7c8f 

Diff: https://reviews.apache.org/r/42696/diff/


Testing
---

Before
```
[   OK ] FetcherCacheTest.LocalUncached (2580 ms)
[   OK ] FetcherCacheTest.LocalCached (2516 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (2519 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (2594 ms)
```

After
```
[   OK ] FetcherCacheTest.LocalUncached (977 ms)
[   OK ] FetcherCacheTest.LocalCached (1731 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (975 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1713 ms)
```


Thanks,

haosdent huang

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
---

(Updated Feb. 17, 2016, 9:54 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
Mathiske.


Changes
---

Address @guangya's comment.


Bugs: MESOS-4628
https://issues.apache.org/jira/browse/MESOS-4628


Repository: mesos


Description
---

Speed up FetcherCache test cases by reduce allocation_interval.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp fc89be46bc4cca81f6f3f5072539d3dae26f7c8f 

Diff: https://reviews.apache.org/r/43367/diff/


Testing
---

In this patch, we use 500ms instead of the default allocation_interval 1s. If 
the test cases depends on getting offers from master multiple times, this patch 
could reduce the offer waiting time and speed up them. 

Before
```
[   OK ] FetcherCacheTest.LocalUncached (943 ms)
[   OK ] FetcherCacheTest.LocalCached (1612 ms)
[   OK ] FetcherCacheTest.CachedFallback (906 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
[   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)

```

After
```
[   OK ] FetcherCacheTest.LocalUncached (979 ms)
[   OK ] FetcherCacheTest.LocalCached (1510 ms)
[   OK ] FetcherCacheTest.CachedFallback (853 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[   OK ] FetcherCacheTest.SimpleEviction (2720 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
```


Thanks,

haosdent huang

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[haosdent huang]

> On Feb. 17, 2016, 5:10 a.m., Guangya Liu wrote:
> > src/tests/fetcher_cache_tests.cpp, line 194
> > <https://reviews.apache.org/r/43367/diff/8/?file=1252269#file1252269line194>
> >
> > Can you please summary the discussion of you and  bernd-mesos for why 
> > not using `Clock::settle()` so as to let everyone know the detail?

Thank you very much for your help! Could you help review it again?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review119413
---


On Feb. 17, 2016, 9:54 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> ---
> 
> (Updated Feb. 17, 2016, 9:54 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
> Mathiske.
> 
> 
> Bugs: MESOS-4628
> https://issues.apache.org/jira/browse/MESOS-4628
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCache test cases by reduce allocation_interval.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp fc89be46bc4cca81f6f3f5072539d3dae26f7c8f 
> 
> Diff: https://reviews.apache.org/r/43367/diff/
> 
> 
> Testing
> ---
> 
> In this patch, we use 500ms instead of the default allocation_interval 1s. If 
> the test cases depends on getting offers from master multiple times, this 
> patch could reduce the offer waiting time and speed up them. 
> 
> Before
> ```
> [   OK ] FetcherCacheTest.LocalUncached (943 ms)
> [   OK ] FetcherCacheTest.LocalCached (1612 ms)
> [   OK ] FetcherCacheTest.CachedFallback (906 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)
> 
> ```
> 
> After
> ```
> [   OK ] FetcherCacheTest.LocalUncached (979 ms)
> [   OK ] FetcherCacheTest.LocalCached (1510 ms)
> [   OK ] FetcherCacheTest.CachedFallback (853 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (2720 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[haosdent huang]

> On Feb. 17, 2016, 10:09 a.m., Bernd Mathiske wrote:
> > src/tests/fetcher_cache_tests.cpp, line 197
> > <https://reviews.apache.org/r/43367/diff/9/?file=1252393#file1252393line197>
> >
> > Having run multiple test suite runs, I am not convinced this has much 
> > of an effect. I got results between 20 and 28 seconds for all FetcherCache 
> > tests combined no matter what allocation interval I used: default, 500, 
> > 100. If there is an effect, it is less than the variance.

Looks weird, let me double check this.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review119434
---


On Feb. 17, 2016, 9:54 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> ---
> 
> (Updated Feb. 17, 2016, 9:54 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
> Mathiske.
> 
> 
> Bugs: MESOS-4628
> https://issues.apache.org/jira/browse/MESOS-4628
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCache test cases by reduce allocation_interval.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp fc89be46bc4cca81f6f3f5072539d3dae26f7c8f 
> 
> Diff: https://reviews.apache.org/r/43367/diff/
> 
> 
> Testing
> ---
> 
> In this patch, we use 500ms instead of the default allocation_interval 1s. If 
> the test cases depends on getting offers from master multiple times, this 
> patch could reduce the offer waiting time and speed up them. 
> 
> Before
> ```
> [   OK ] FetcherCacheTest.LocalUncached (943 ms)
> [   OK ] FetcherCacheTest.LocalCached (1612 ms)
> [   OK ] FetcherCacheTest.CachedFallback (906 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)
> 
> ```
> 
> After
> ```
> [   OK ] FetcherCacheTest.LocalUncached (979 ms)
> [   OK ] FetcherCacheTest.LocalCached (1510 ms)
> [   OK ] FetcherCacheTest.CachedFallback (853 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (2720 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[haosdent huang]

> On Feb. 17, 2016, 10:09 a.m., Bernd Mathiske wrote:
> > src/tests/fetcher_cache_tests.cpp, line 197
> > <https://reviews.apache.org/r/43367/diff/9/?file=1252393#file1252393line197>
> >
> > Having run multiple test suite runs, I am not convinced this has much 
> > of an effect. I got results between 20 and 28 seconds for all FetcherCache 
> > tests combined no matter what allocation interval I used: default, 500, 
> > 100. If there is an effect, it is less than the variance.
> 
> haosdent huang wrote:
> Looks weird, let me double check this.

I use `./bin/mesos-tests.sh --gtest_filter="FetcherCache*" --gtest_repeat=10 
2>&1 |grep total` to test. Could find use allocation_interval from 1s to 200ms 
bring effect as the allocation_interval decrease.

Use 1 s
```
[==] 11 tests from 2 test cases ran. (21652 ms total)
[==] 11 tests from 2 test cases ran. (21278 ms total)
[==] 11 tests from 2 test cases ran. (21077 ms total)
[==] 11 tests from 2 test cases ran. (21447 ms total)
[==] 11 tests from 2 test cases ran. (21594 ms total)
[==] 11 tests from 2 test cases ran. (21364 ms total)
[==] 11 tests from 2 test cases ran. (21085 ms total)
[==] 11 tests from 2 test cases ran. (21773 ms total)
[==] 11 tests from 2 test cases ran. (21737 ms total)
[==] 11 tests from 2 test cases ran. (21075 ms total)
```

Use 500 ms
```
[==] 11 tests from 2 test cases ran. (18028 ms total)
[==] 11 tests from 2 test cases ran. (18438 ms total)
[==] 11 tests from 2 test cases ran. (18636 ms total)
[==] 11 tests from 2 test cases ran. (18470 ms total)
[==] 11 tests from 2 test cases ran. (17913 ms total)
[==] 11 tests from 2 test cases ran. (18842 ms total)
[==] 11 tests from 2 test cases ran. (18785 ms total)
[==] 11 tests from 2 test cases ran. (18312 ms total)
[==] 11 tests from 2 test cases ran. (18216 ms total)
[==] 11 tests from 2 test cases ran. (18827 ms total)
```

Use 200 ms
```
[==] 11 tests from 2 test cases ran. (16630 ms total)
[==] 11 tests from 2 test cases ran. (17993 ms total)
[==] 11 tests from 2 test cases ran. (17282 ms total)
[==] 11 tests from 2 test cases ran. (17588 ms total)
[==] 11 tests from 2 test cases ran. (16502 ms total)
[==] 11 tests from 2 test cases ran. (17218 ms total)
[==] 11 tests from 2 test cases ran. (17744 ms total)
[==] 11 tests from 2 test cases ran. (17136 ms total)
[==] 11 tests from 2 test cases ran. (17178 ms total)
[==] 11 tests from 2 test cases ran. (17613 ms total)
```

Use 100 ms
```
[==] 11 tests from 2 test cases ran. (16305 ms total)
[==] 11 tests from 2 test cases ran. (16093 ms total)
[==] 11 tests from 2 test cases ran. (16345 ms total)
[==] 11 tests from 2 test cases ran. (16898 ms total)
[==] 11 tests from 2 test cases ran. (16517 ms total)
[==] 11 tests from 2 test cases ran. (16005 ms total)
[==] 11 tests from 2 test cases ran. (21150 ms total)
[==] 11 tests from 2 test cases ran. (16650 ms total)
[==] 11 tests from 2 test cases ran. (16287 ms total)
[==] 11 tests from 2 test cases ran. (16617 ms total)
```


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review119434
-------


On Feb. 17, 2016, 9:54 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> ---
> 
> (Updated Feb. 17, 2016, 9:54 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
> Mathiske.
> 
> 
> Bugs: MESOS-4628
> https://issues.apache.org/jira/browse/MESOS-4628
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCache test cases by reduce allocation_interval.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp fc89be46bc4cca81f6f3f5072539d3dae26f7c8f 
> 
> Diff: https://reviews.apache.org/r/43367/diff/
> 
> 
> Testing
> ---
> 
> In this patch, we use 500ms instead of the default allocation_interval 1s. If 
> the test cases depends on getting offers from master multiple times, this 
> patch could reduce the offer waiting time and speed up them. 
> 
> Before
> ```
> [   OK ] FetcherCacheTest.LocalUncached (943 ms)
> [   OK ] FetcherCacheTest.LocalCached (1612 ms)
> [   OK ] FetcherCacheTest.C

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[haosdent huang]

> On Feb. 17, 2016, 10:09 a.m., Bernd Mathiske wrote:
> > src/tests/fetcher_cache_tests.cpp, line 197
> > <https://reviews.apache.org/r/43367/diff/9/?file=1252393#file1252393line197>
> >
> > Having run multiple test suite runs, I am not convinced this has much 
> > of an effect. I got results between 20 and 28 seconds for all FetcherCache 
> > tests combined no matter what allocation interval I used: default, 500, 
> > 100. If there is an effect, it is less than the variance.
> 
> haosdent huang wrote:
>     Looks weird, let me double check this.
> 
> haosdent huang wrote:
> I use `./bin/mesos-tests.sh --gtest_filter="FetcherCache*" 
> --gtest_repeat=10 2>&1 |grep total` to test. Could find use 
> allocation_interval from 1s to 200ms bring effect as the allocation_interval 
> decrease.
> 
> Use 1 s
> ```
> [==] 11 tests from 2 test cases ran. (21652 ms total)
> [==] 11 tests from 2 test cases ran. (21278 ms total)
> [==] 11 tests from 2 test cases ran. (21077 ms total)
> [==] 11 tests from 2 test cases ran. (21447 ms total)
> [==] 11 tests from 2 test cases ran. (21594 ms total)
> [==] 11 tests from 2 test cases ran. (21364 ms total)
> [==] 11 tests from 2 test cases ran. (21085 ms total)
> [==] 11 tests from 2 test cases ran. (21773 ms total)
> [==] 11 tests from 2 test cases ran. (21737 ms total)
> [==] 11 tests from 2 test cases ran. (21075 ms total)
> ```
> 
> Use 500 ms
> ```
> [==] 11 tests from 2 test cases ran. (18028 ms total)
> [==] 11 tests from 2 test cases ran. (18438 ms total)
> [==] 11 tests from 2 test cases ran. (18636 ms total)
> [==] 11 tests from 2 test cases ran. (18470 ms total)
> [==] 11 tests from 2 test cases ran. (17913 ms total)
> [==] 11 tests from 2 test cases ran. (18842 ms total)
> [==] 11 tests from 2 test cases ran. (18785 ms total)
> [==] 11 tests from 2 test cases ran. (18312 ms total)
> [==] 11 tests from 2 test cases ran. (18216 ms total)
> [==] 11 tests from 2 test cases ran. (18827 ms total)
> ```
> 
> Use 200 ms
> ```
> [==] 11 tests from 2 test cases ran. (16630 ms total)
> [==] 11 tests from 2 test cases ran. (17993 ms total)
> [==] 11 tests from 2 test cases ran. (17282 ms total)
> [==] 11 tests from 2 test cases ran. (17588 ms total)
> [==] 11 tests from 2 test cases ran. (16502 ms total)
> [==] 11 tests from 2 test cases ran. (17218 ms total)
> [==] 11 tests from 2 test cases ran. (17744 ms total)
> [==] 11 tests from 2 test cases ran. (17136 ms total)
> [==] 11 tests from 2 test cases ran. (17178 ms total)
> [==] 11 tests from 2 test cases ran. (17613 ms total)
> ```
> 
> Use 100 ms
> ```
> [==] 11 tests from 2 test cases ran. (16305 ms total)
> [==] 11 tests from 2 test cases ran. (16093 ms total)
> [==] 11 tests from 2 test cases ran. (16345 ms total)
> [==] 11 tests from 2 test cases ran. (16898 ms total)
> [==] 11 tests from 2 test cases ran. (16517 ms total)
> [==] 11 tests from 2 test cases ran. (16005 ms total)
> [==] 11 tests from 2 test cases ran. (21150 ms total)
> [==] 11 tests from 2 test cases ran. (16650 ms total)
> [==] 11 tests from 2 test cases ran. (16287 ms total)
> [==] 11 tests from 2 test cases ran. (16617 ms total)
> ```

400 ms
```
[==] 11 tests from 2 test cases ran. (17678 ms total)
[==] 11 tests from 2 test cases ran. (17093 ms total)
[==] 11 tests from 2 test cases ran. (17174 ms total)
[==] 11 tests from 2 test cases ran. (17396 ms total)
[==] 11 tests from 2 test cases ran. (18095 ms total)
[==] 11 tests from 2 test cases ran. (17404 ms total)
[==] 11 tests from 2 test cases ran. (17480 ms total)
[==] 11 tests from 2 test cases ran. (17110 ms total)
[==] 11 tests from 2 test cases ran. (17352 ms total)
[==] 11 tests from 2 test cases ran. (17219 ms total)
```

300 ms
```
[==] 11 tests from 2 test cases ran. (17165 ms total)
[==] 11 tests from 2 test cases ran. (18067 ms total)
[==] 11 tests from 2 test cases ran. (17951 ms total)
[==] 11 tests from 2 test cases ran. (17602 ms total)
[==] 11 tests from 2 test cases ran. (16994 ms total)
[==] 11 tests from 2 test cases ran. (18004 ms total)
[==]

Re: Review Request 43608: Speed up FetcherCache test cases by disable framework checkpoint.

[haosdent huang]

> On Feb. 17, 2016, 3:21 p.m., Bernd Mathiske wrote:
> > Are a couple of seconds wirth the extra code complexity? Opinions, please!

Yes, @bernd, as you see here, this patch don't bring too much effects. How 
about let's discard it and reopen it if really necessary?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43608/#review119462
---


On Feb. 17, 2016, 2:10 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43608/
> ---
> 
> (Updated Feb. 17, 2016, 2:10 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
> Mathiske.
> 
> 
> Bugs: MESOS-4685
> https://issues.apache.org/jira/browse/MESOS-4685
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCache test cases by disable framework checkpoint.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp fc89be46bc4cca81f6f3f5072539d3dae26f7c8f 
> 
> Diff: https://reviews.apache.org/r/43608/diff/
> 
> 
> Testing
> ---
> 
> When we enable checkpoint for frameworks, StatusUpdateManager would waiting 
> for write StatusUpdateRecord to file and then boardcast it. This cause 
> uncessary disk operations and bring unstable delay if our test cases don't 
> depends on recovery.  
> 
> Before
> ```
> [   OK ] FetcherCacheTest.LocalUncached (2645 ms)
> [   OK ] FetcherCacheTest.LocalCached (2653 ms)
> [   OK ] FetcherCacheTest.CachedFallback (1110 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2620 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2758 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (5059 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2648 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3661 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2600 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (2013 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1746 ms)
> ```
> 
> After
> ```
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2516 ms)
> [   OK ] FetcherCacheTest.CachedFallback (957 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2519 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2594 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (4532 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2579 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3528 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2520 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1534 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1345 ms)
> ```
> 
> And test the recovery test manually:
> ```
> ./bin/mesos-tests.sh 
> --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[haosdent huang]

> On Feb. 17, 2016, 10:09 a.m., Bernd Mathiske wrote:
> > src/tests/fetcher_cache_tests.cpp, line 197
> > <https://reviews.apache.org/r/43367/diff/9/?file=1252393#file1252393line197>
> >
> > Having run multiple test suite runs, I am not convinced this has much 
> > of an effect. I got results between 20 and 28 seconds for all FetcherCache 
> > tests combined no matter what allocation interval I used: default, 500, 
> > 100. If there is an effect, it is less than the variance.
> 
> haosdent huang wrote:
>     Looks weird, let me double check this.
> 
> haosdent huang wrote:
> I use `./bin/mesos-tests.sh --gtest_filter="FetcherCache*" 
> --gtest_repeat=10 2>&1 |grep total` to test. Could find use 
> allocation_interval from 1s to 200ms bring effect as the allocation_interval 
> decrease.
> 
> Use 1 s
> ```
> [==] 11 tests from 2 test cases ran. (21652 ms total)
> [==] 11 tests from 2 test cases ran. (21278 ms total)
> [==] 11 tests from 2 test cases ran. (21077 ms total)
> [==] 11 tests from 2 test cases ran. (21447 ms total)
> [==] 11 tests from 2 test cases ran. (21594 ms total)
> [==] 11 tests from 2 test cases ran. (21364 ms total)
> [==] 11 tests from 2 test cases ran. (21085 ms total)
> [==] 11 tests from 2 test cases ran. (21773 ms total)
> [==] 11 tests from 2 test cases ran. (21737 ms total)
> [==] 11 tests from 2 test cases ran. (21075 ms total)
> ```
> 
> Use 500 ms
> ```
> [==] 11 tests from 2 test cases ran. (18028 ms total)
> [==] 11 tests from 2 test cases ran. (18438 ms total)
> [==] 11 tests from 2 test cases ran. (18636 ms total)
> [==] 11 tests from 2 test cases ran. (18470 ms total)
> [==] 11 tests from 2 test cases ran. (17913 ms total)
> [==] 11 tests from 2 test cases ran. (18842 ms total)
> [==] 11 tests from 2 test cases ran. (18785 ms total)
> [==] 11 tests from 2 test cases ran. (18312 ms total)
> [==] 11 tests from 2 test cases ran. (18216 ms total)
> [==] 11 tests from 2 test cases ran. (18827 ms total)
> ```
> 
> Use 200 ms
> ```
> [==] 11 tests from 2 test cases ran. (16630 ms total)
> [==] 11 tests from 2 test cases ran. (17993 ms total)
> [==] 11 tests from 2 test cases ran. (17282 ms total)
> [==] 11 tests from 2 test cases ran. (17588 ms total)
> [==] 11 tests from 2 test cases ran. (16502 ms total)
> [==] 11 tests from 2 test cases ran. (17218 ms total)
> [==] 11 tests from 2 test cases ran. (17744 ms total)
> [==] 11 tests from 2 test cases ran. (17136 ms total)
> [==] 11 tests from 2 test cases ran. (17178 ms total)
> [==] 11 tests from 2 test cases ran. (17613 ms total)
> ```
> 
> Use 100 ms
> ```
> [==] 11 tests from 2 test cases ran. (16305 ms total)
> [==] 11 tests from 2 test cases ran. (16093 ms total)
> [==] 11 tests from 2 test cases ran. (16345 ms total)
> [==] 11 tests from 2 test cases ran. (16898 ms total)
> [==] 11 tests from 2 test cases ran. (16517 ms total)
> [==] 11 tests from 2 test cases ran. (16005 ms total)
> [==] 11 tests from 2 test cases ran. (21150 ms total)
> [==] 11 tests from 2 test cases ran. (16650 ms total)
> [==] 11 tests from 2 test cases ran. (16287 ms total)
> [==] 11 tests from 2 test cases ran. (16617 ms total)
> ```
> 
> haosdent huang wrote:
> 400 ms
> ```
> [==] 11 tests from 2 test cases ran. (17678 ms total)
> [==] 11 tests from 2 test cases ran. (17093 ms total)
> [==] 11 tests from 2 test cases ran. (17174 ms total)
> [==] 11 tests from 2 test cases ran. (17396 ms total)
> [==] 11 tests from 2 test cases ran. (18095 ms total)
> [==] 11 tests from 2 test cases ran. (17404 ms total)
> [==] 11 tests from 2 test cases ran. (17480 ms total)
> [==] 11 tests from 2 test cases ran. (17110 ms total)
> [==] 11 tests from 2 test cases ran. (17352 ms total)
> [==] 11 tests from 2 test cases ran. (17219 ms total)
> ```
> 
> 300 ms
> ```
> [==] 11 tests from 2 test cases ran. (17165 ms total)
> [==] 11 tests from 2 test cases ran. (18067 ms total)
> [==] 11 tests from 2 test cases ran. (17951 ms to

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
---

(Updated Feb. 17, 2016, 4:55 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
Mathiske.


Changes
---

Address @guangya @bernd's comments.


Bugs: MESOS-4628
https://issues.apache.org/jira/browse/MESOS-4628


Repository: mesos


Description
---

Speed up FetcherCache test cases by reduce allocation_interval.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp f9c48f5d938c2601cb8f826029d6969d676ab98e 

Diff: https://reviews.apache.org/r/43367/diff/


Testing
---

In this patch, we use 500ms instead of the default allocation_interval 1s. If 
the test cases depends on getting offers from master multiple times, this patch 
could reduce the offer waiting time and speed up them. 

Before
```
[   OK ] FetcherCacheTest.LocalUncached (943 ms)
[   OK ] FetcherCacheTest.LocalCached (1612 ms)
[   OK ] FetcherCacheTest.CachedFallback (906 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
[   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)

```

After
```
[   OK ] FetcherCacheTest.LocalUncached (979 ms)
[   OK ] FetcherCacheTest.LocalCached (1510 ms)
[   OK ] FetcherCacheTest.CachedFallback (853 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[   OK ] FetcherCacheTest.SimpleEviction (2720 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
```


Thanks,

haosdent huang

Re: Review Request 43676: Fixed variable shadowing in HookManager::slavePreLaunchDockerHook.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43676/#review119564
---


Ship it!




[~kdevroede] Your patch looks nice. Could you ask [~tnachen] or other 
committers whether he have cycles to shepherd you in this ticket? Then he could 
help you review and commit this.

- haosdent huang


On Feb. 17, 2016, 10:03 p.m., Kevin Devroede wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43676/
> ---
> 
> (Updated Feb. 17, 2016, 10:03 p.m.)
> 
> 
> Review request for mesos and haosdent huang.
> 
> 
> Bugs: MESOS-4693
> https://issues.apache.org/jira/browse/MESOS-4693
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed variable shadowing in HookManager::slavePreLaunchDockerHook.
> 
> 
> Diffs
> -
> 
>   src/hook/manager.hpp 8ab331ae28d29a006a7c9878ffb619f2cdd03a42 
>   src/hook/manager.cpp 704b166725c0b356f2acb9bb1539a72cefd9b7ae 
> 
> Diff: https://reviews.apache.org/r/43676/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Devroede
> 
>

Re: Review Request 41865: Use full width for mesos div.container

[haosdent huang]

> On 二月 18, 2016, 1:32 p.m., Bernd Mathiske wrote:
> > @mlunoe Is this change still needed, since the ticket has been closed given 
> > your patch?

don't need any more. Let me discard


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41865/#review119612
---


On 一月 3, 2016, 3:08 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41865/
> ---
> 
> (Updated 一月 3, 2016, 3:08 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Michael Lunøe.
> 
> 
> Bugs: MESOS-2585
> https://issues.apache.org/jira/browse/MESOS-2585
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use full width for mesos div.container
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/css/mesos.css 
> 5b1227e9d64757f9fc106e497f7fa3ed72112c10 
> 
> Diff: https://reviews.apache.org/r/41865/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
---

(Updated Feb. 18, 2016, 2:52 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
Mathiske.


Changes
---

Address @tnachen's review.


Bugs: MESOS-4628
https://issues.apache.org/jira/browse/MESOS-4628


Repository: mesos


Description
---

Speed up FetcherCache test cases by reduce allocation_interval.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp f9c48f5d938c2601cb8f826029d6969d676ab98e 

Diff: https://reviews.apache.org/r/43367/diff/


Testing
---

In this patch, we use 500ms instead of the default allocation_interval 1s. If 
the test cases depends on getting offers from master multiple times, this patch 
could reduce the offer waiting time and speed up them. 

Before
```
[   OK ] FetcherCacheTest.LocalUncached (943 ms)
[   OK ] FetcherCacheTest.LocalCached (1612 ms)
[   OK ] FetcherCacheTest.CachedFallback (906 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
[   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)

```

After
```
[   OK ] FetcherCacheTest.LocalUncached (979 ms)
[   OK ] FetcherCacheTest.LocalCached (1510 ms)
[   OK ] FetcherCacheTest.CachedFallback (853 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[   OK ] FetcherCacheTest.SimpleEviction (2720 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
```


Thanks,

haosdent huang

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
---

(Updated Feb. 18, 2016, 2:54 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
Mathiske.


Changes
---

Address @bernd's comment.


Bugs: MESOS-4628
https://issues.apache.org/jira/browse/MESOS-4628


Repository: mesos


Description
---

Speed up FetcherCache test cases by reduce allocation_interval.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp f9c48f5d938c2601cb8f826029d6969d676ab98e 

Diff: https://reviews.apache.org/r/43367/diff/


Testing
---

In this patch, we use 500ms instead of the default allocation_interval 1s. If 
the test cases depends on getting offers from master multiple times, this patch 
could reduce the offer waiting time and speed up them. 

Before
```
[   OK ] FetcherCacheTest.LocalUncached (943 ms)
[   OK ] FetcherCacheTest.LocalCached (1612 ms)
[   OK ] FetcherCacheTest.CachedFallback (906 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
[   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)

```

After
```
[   OK ] FetcherCacheTest.LocalUncached (979 ms)
[   OK ] FetcherCacheTest.LocalCached (1510 ms)
[   OK ] FetcherCacheTest.CachedFallback (853 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[   OK ] FetcherCacheTest.SimpleEviction (2720 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
```


Thanks,

haosdent huang

Re: Review Request 43519: Speed up MasterMaintenanceTest.InverseOffers.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43519/
---

(Updated Feb. 19, 2016, 1:45 a.m.)


Review request for mesos, Ben Mahler and Joseph Wu.


Changes
---

Address @kaysoky's comments.


Bugs: MESOS-4169
https://issues.apache.org/jira/browse/MESOS-4169


Repository: mesos


Description
---

Speed up MasterMaintenanceTest.InverseOffers.


Diffs (updated)
-

  src/tests/master_maintenance_tests.cpp 
b98eedec388813ee795dd83ccc5ff27338209475 

Diff: https://reviews.apache.org/r/43519/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 43518: Speed up MasterMaintenanceTest.EnterMaintenanceMode.

[haosdent huang]

ioner/docker/metadata_manager.hpp 
137af502a66e6a65773c00eaacbe392576376284 
  src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 
f391a943551792c8edf5759d9491fda33116f2b4 
  src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
5b2d72c22fcbcc379b4901607cf3eb682de66206 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
377da0c647db198a023c1631930637ed3df2188d 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
2ba6b10a269705ecd1d085ceec07d8d8c1bf2560 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp 
bccbac3357cf942446604e6cf5d16c3d594b 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
3fcf1471a035e35a2cac22442655ad65a84a9793 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
12a39060a0aaf8f7afda77cbffd783e134994d51 
  src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61 
  src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a 
  src/slave/http.cpp a18085ea020d0d6c39f23213e11af75a02eedb7e 
  src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb 
  src/tests/common/command_utils_tests.cpp 
c91a7f38263e4c8352ec56f79070baec2b1cb06f 
  src/tests/container_logger_tests.cpp 6e2b8c1b80d4b49a1042c53945c223785d0d4a3f 
  src/tests/containerizer/docker_containerizer_tests.cpp 
8541a9a3d2f40cd6e78ff8fba474da214017937a 
  src/tests/containerizer/port_mapping_tests.cpp 
983a6be160aefe5a32acb6111bb3c85230ec 
  src/tests/containerizer/provisioner_docker_tests.cpp 
4db6793a21abbb7ea4de0d0fca0431237d38d013 
  src/tests/fetcher_cache_tests.cpp f9c48f5d938c2601cb8f826029d6969d676ab98e 
  src/tests/group_tests.cpp af530f32fac47801a2cd0d941f3aa9196d448bd2 
  src/tests/master_contender_detector_tests.cpp 
255ab8119a04b55bb4f1b61dee19c4be64499376 
  src/tests/master_maintenance_tests.cpp 
b98eedec388813ee795dd83ccc5ff27338209475 
  src/tests/resources_tests.cpp 96864c3945729fe33be8b243b9c826fb12e90eff 
  src/tests/zookeeper_tests.cpp 6bde10b9ae9a644d3506abb285786200dc2fbe94 
  src/v1/values.cpp 58ea9875804bf0287855a1e9855855e5e54de4c4 
  src/zookeeper/group.hpp 2003b60574e471c0dc08b8abf5f170df02f91f5b 
  src/zookeeper/group.cpp 7aa95a7b7eafe0a2c49dc077b3a4abd688e5d8e8 
  src/zookeeper/zookeeper.hpp 9191df50dd5b601491a86584f7184a31a6151ca5 

Diff: https://reviews.apache.org/r/43518/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 43519: Speed up MasterMaintenanceTest.InverseOffers.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43519/
---

(Updated Feb. 19, 2016, 1:46 a.m.)


Review request for mesos, Ben Mahler and Joseph Wu.


Changes
---

Rebase


Bugs: MESOS-4169
https://issues.apache.org/jira/browse/MESOS-4169


Repository: mesos


Description
---

Speed up MasterMaintenanceTest.InverseOffers.


Diffs (updated)
-

  src/tests/master_maintenance_tests.cpp 
b98eedec388813ee795dd83ccc5ff27338209475 

Diff: https://reviews.apache.org/r/43519/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 43518: Speed up MasterMaintenanceTest.EnterMaintenanceMode.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43518/
---

(Updated Feb. 19, 2016, 1:46 a.m.)


Review request for mesos, Ben Mahler and Joseph Wu.


Changes
---

Rebase


Bugs: MESOS-4168
https://issues.apache.org/jira/browse/MESOS-4168


Repository: mesos


Description
---

Speed up MasterMaintenanceTest.EnterMaintenanceMode.


Diffs (updated)
-

  src/tests/master_maintenance_tests.cpp 
b98eedec388813ee795dd83ccc5ff27338209475 

Diff: https://reviews.apache.org/r/43518/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 43518: Speed up MasterMaintenanceTest.EnterMaintenanceMode.

[haosdent huang]

> On Feb. 18, 2016, 7:34 p.m., Joseph Wu wrote:
> > Confirmed speedup (on OSX) and doesn't appear to be flaky (1500 iterations).

Thank you very much for you review, could you help check it again?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43518/#review119698
---


On Feb. 19, 2016, 1:46 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43518/
> ---
> 
> (Updated Feb. 19, 2016, 1:46 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-4168
> https://issues.apache.org/jira/browse/MESOS-4168
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up MasterMaintenanceTest.EnterMaintenanceMode.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> b98eedec388813ee795dd83ccc5ff27338209475 
> 
> Diff: https://reviews.apache.org/r/43518/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[haosdent huang]

> On Feb. 19, 2016, 9:02 a.m., Alexander Rukletsov wrote:
> > src/tests/fetcher_cache_tests.cpp, lines 189-191
> > <https://reviews.apache.org/r/43367/diff/12/?file=1254386#file1254386line189>
> >
> > Will it be more clear to explicitly advance clock in those tests? I 
> > think keeping changes local, i.e. making them only there where they are 
> > necessary, serves educational purposes. People often read tests to 
> > understand how things work, hence it's valuable not to distract them with 
> > irrelevant actions, nor to hide meaningful steps.

Do you mean move

```
  Future> offers;
  EXPECT_CALL(scheduler, resourceOffers(driver, _))
.WillOnce(FutureArg<1>(&offers))
.WillRepeatedly(DeclineOffers());

  // The default timeout in AWAIT_READY is 15 seconds,
  // so we use that amount here.
  // TODO(bernd-mesos): Make this a symbolic constant in "gtest.hpp"
  // that we can reference here.
  offers.await(Seconds(15));
  if (!offers.isReady()) {
return Error("Failed to wait for resource offers: " +
   (offers.isFailed() ? offers.failure() : "discarded"));
  }

  CHECK_NE(0u, offers.get().size());
  const Offer offer = offers.get()[0];
```

out and use advance clock according to different test cases?

Or pass a new param
```
Try FetcherCacheTest::launchTask(
const CommandInfo& commandInfo,
const size_t taskIndex,
const bool& advanceAllocation)
```


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/#review119838
---


On Feb. 18, 2016, 2:54 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43367/
> ---
> 
> (Updated Feb. 18, 2016, 2:54 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
> Mathiske.
> 
> 
> Bugs: MESOS-4628
> https://issues.apache.org/jira/browse/MESOS-4628
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCache test cases by reduce allocation_interval.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp f9c48f5d938c2601cb8f826029d6969d676ab98e 
> 
> Diff: https://reviews.apache.org/r/43367/diff/
> 
> 
> Testing
> ---
> 
> In this patch, we use 500ms instead of the default allocation_interval 1s. If 
> the test cases depends on getting offers from master multiple times, this 
> patch could reduce the offer waiting time and speed up them. 
> 
> Before
> ```
> [   OK ] FetcherCacheTest.LocalUncached (943 ms)
> [   OK ] FetcherCacheTest.LocalCached (1612 ms)
> [   OK ] FetcherCacheTest.CachedFallback (906 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)
> 
> ```
> 
> After
> ```
> [   OK ] FetcherCacheTest.LocalUncached (979 ms)
> [   OK ] FetcherCacheTest.LocalCached (1510 ms)
> [   OK ] FetcherCacheTest.CachedFallback (853 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
> [   OK ] FetcherCacheTest.SimpleEviction (2720 ms)
> [   OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
> [   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
> [   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
> [   OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43718: Added fs::supported() function.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review119845
---




src/tests/containerizer/fs_tests.cpp (line 49)
<https://reviews.apache.org/r/43718/#comment181228>

I use CentOS 6. But seems don't have `ext2` and `ext3` in 
`/proc/filesystems`

```
at /proc/filesystems
nodev   sysfs
nodev   rootfs
nodev   bdev
nodev   proc
nodev   cgroup
nodev   cpuset
nodev   tmpfs
nodev   devtmpfs
nodev   binfmt_misc
nodev   debugfs
nodev   securityfs
nodev   sockfs
nodev   usbfs
nodev   pipefs
nodev   anon_inodefs
nodev   inotifyfs
nodev   devpts
nodev   ramfs
nodev   hugetlbfs
iso9660
nodev   pstore
nodev   mqueue
ext4
vfat
    ```


- haosdent huang


On Feb. 19, 2016, 2:02 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> ---
> 
> (Updated Feb. 19, 2016, 2:02 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
> https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
>   src/tests/containerizer/fs_tests.cpp 
> 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43718: Added fs::supported() function.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review119847
---




src/linux/fs.cpp (line 59)
<https://reviews.apache.org/r/43718/#comment181233>

`tokens.back()` instead of `tokens[tokens.size() - 1]`?


- haosdent huang


On Feb. 19, 2016, 2:02 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> ---
> 
> (Updated Feb. 19, 2016, 2:02 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
> https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
>   src/tests/containerizer/fs_tests.cpp 
> 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43718: Added fs::supported() function.

[haosdent huang]

> On Feb. 19, 2016, 9:28 a.m., haosdent huang wrote:
> > src/tests/containerizer/fs_tests.cpp, line 49
> > <https://reviews.apache.org/r/43718/diff/3/?file=1258902#file1258902line49>
> >
> > I use CentOS 6. But seems don't have `ext2` and `ext3` in 
> > `/proc/filesystems`
> > 
> > ```
> > at /proc/filesystems
> > nodev   sysfs
> > nodev   rootfs
> > nodev   bdev
> > nodev   proc
> > nodev   cgroup
> > nodev   cpuset
> > nodev   tmpfs
> > nodev   devtmpfs
> > nodev   binfmt_misc
> > nodev   debugfs
> > nodev   securityfs
> > nodev   sockfs
> > nodev   usbfs
> > nodev   pipefs
> > nodev   anon_inodefs
> > nodev   inotifyfs
> > nodev   devpts
> > nodev   ramfs
> > nodev   hugetlbfs
> > iso9660
> > nodev   pstore
> > nodev   mqueue
> > ext4
> > vfat
> > ```
> 
> Guangya Liu wrote:
> I think that's why using EXPECT_SOME_TRUE here. The ubuntu does have this.

Yes, but this test case would fail in CentOS 6?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review119845
---


On Feb. 19, 2016, 2:02 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> ---
> 
> (Updated Feb. 19, 2016, 2:02 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
> https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
>   src/tests/containerizer/fs_tests.cpp 
> 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43718: Added fs::supported() function.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43718/#review120075
---


Ship it!




Ship It!

- haosdent huang


On Feb. 21, 2016, 12:24 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43718/
> ---
> 
> (Updated Feb. 21, 2016, 12:24 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4707
> https://issues.apache.org/jira/browse/MESOS-4707
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added fs::supported() function.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp fddee2441e008dc70d9cff5e63536ef21c865595 
>   src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e 
>   src/tests/containerizer/fs_tests.cpp 
> 29e43877612fa151e6f6d79268a7411272a7bfeb 
> 
> Diff: https://reviews.apache.org/r/43718/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04 64bit vm
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 43814: Enabled volume propagation for docker volume.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43814/#review120098
---


Ship it!




Ship It!


include/mesos/mesos.proto (line 1498)
<https://reviews.apache.org/r/43814/#comment181476>

I think we could not mix `rw` and propagation modes when mount, right?


- haosdent huang


On Feb. 22, 2016, 1:54 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43814/
> ---
> 
> (Updated Feb. 22, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4717
> https://issues.apache.org/jira/browse/MESOS-4717
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled volume propagation for docker volume.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 11a71cbe25acbc232cea6b5d72484e2e9eef6167 
>   include/mesos/v1/mesos.proto 84e933e0bc30aa8f9b6d6047402f449666a80a23 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
> 
> Diff: https://reviews.apache.org/r/43814/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> Will rebase after https://reviews.apache.org/r/42516 , as 
> https://reviews.apache.org/r/42516 is going to add a docker version in Docker 
> class.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 43807: Replaced with `~` in authentication.md.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43807/#review120099
---




docs/authentication.md (line 97)
<https://reviews.apache.org/r/43807/#comment181477>

I try `echo ~/a` in both bash and zsh. Seems it works for me. And do we 
have a jira ticket related to this?


- haosdent huang


On Feb. 21, 2016, 6:42 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43807/
> ---
> 
> (Updated Feb. 21, 2016, 6:42 a.m.)
> 
> 
> Review request for mesos, Adam B and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaced  with `~` in authentication.md.
> 
> 
> Diffs
> -
> 
>   docs/authentication.md c7649bb279312e3183d8c977811d12121208f9f8 
> 
> Diff: https://reviews.apache.org/r/43807/diff/
> 
> 
> Testing
> ---
> 
> Can not parss `~` to $HOME in Mac OS; update document to use $HOME. Test 
> passed in Mac OS.
> 
> Failed when using `~`:
> I0221 13:08:41.717308 4284416 credentials.hpp:35] Loading credentials for 
> authentication from '~/credentials'
> Failed to read credentials file '~/credentials': Failed to open file 
> '~/credentials': No such file or directory (see --credentials flag)
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 43802: Wrapped TASK_LOST with `` in authorization.md.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43802/#review120100
---


Ship it!




Ship It!

- haosdent huang


On Feb. 21, 2016, 1:05 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43802/
> ---
> 
> (Updated Feb. 21, 2016, 1:05 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Wrapped TASK_LOST with `` in authorization.md
> 
> 
> Diffs
> -
> 
>   docs/authorization.md bbb4f2a 
> 
> Diff: https://reviews.apache.org/r/43802/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 43580: Add indent to comments in protobuf_tests.cpp.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43580/#review120102
---


Ship it!




Ship It!

- haosdent huang


On Feb. 15, 2016, 4:16 p.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43580/
> ---
> 
> (Updated Feb. 15, 2016, 4:16 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add indent to comments in protobuf_tests.cpp.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 
> 8dd9cfd3e7d1e3ab4ace87066a43a3094b776d82 
> 
> Diff: https://reviews.apache.org/r/43580/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43367/
---

(Updated Feb. 22, 2016, 3:48 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
Mathiske.


Changes
---

address @tillt's comment


Bugs: MESOS-4628
https://issues.apache.org/jira/browse/MESOS-4628


Repository: mesos


Description
---

Speed up FetcherCache test cases by reduce allocation_interval.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp f9c48f5d938c2601cb8f826029d6969d676ab98e 

Diff: https://reviews.apache.org/r/43367/diff/


Testing
---

In this patch, we use 500ms instead of the default allocation_interval 1s. If 
the test cases depends on getting offers from master multiple times, this patch 
could reduce the offer waiting time and speed up them. 

Before
```
[   OK ] FetcherCacheTest.LocalUncached (943 ms)
[   OK ] FetcherCacheTest.LocalCached (1612 ms)
[   OK ] FetcherCacheTest.CachedFallback (906 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (940 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1719 ms)
[   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2518 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (3653 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2632 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1227 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1129 ms)

```

After
```
[   OK ] FetcherCacheTest.LocalUncached (979 ms)
[   OK ] FetcherCacheTest.LocalCached (1510 ms)
[   OK ] FetcherCacheTest.CachedFallback (853 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (816 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1715 ms)
[   OK ] FetcherCacheTest.SimpleEviction (2720 ms)
[   OK ] FetcherCacheTest.FallbackFromEviction (2119 ms)
[   OK ] FetcherCacheTest.RemoveLRUCacheEntries (2847 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedSerialized (2233 ms)
[   OK ] FetcherCacheHttpTest.HttpCachedConcurrent (1211 ms)
[   OK ] FetcherCacheHttpTest.HttpMixed (1106 ms)
```


Thanks,

haosdent huang

Re: Review Request 43888: Updated webui to reflect the new TASK_KILLING state.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43888/#review120348
---


Ship it!




Ship It!

- haosdent huang


On Feb. 23, 2016, 6:04 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43888/
> ---
> 
> (Updated Feb. 23, 2016, 6:04 p.m.)
> 
> 
> Review request for mesos and Abhishek Dasgupta.
> 
> 
> Bugs: MESOS-4547
> https://issues.apache.org/jira/browse/MESOS-4547
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated webui to reflect the new TASK_KILLING state.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/home.html ad3f092a8c7ae2965f2718078c8407e19ae70f10 
>   src/webui/master/static/js/controllers.js 
> ff73a46c598ebb9b32566cef3d9151ddf81891c8 
>   src/webui/master/static/slave.html 4735d66c03418ed964a4b720632614e9f9668df7 
> 
> Diff: https://reviews.apache.org/r/43888/diff/
> 
> 
> Testing
> ---
> 
> Manually ran the webui and looked for the new fields and looked for console 
> errors.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review120349
---



Hi, I think the bug field for this review should be `MESOS-4746`?

- haosdent huang


On Feb. 23, 2016, 6:13 p.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43889/
> ---
> 
> (Updated Feb. 23, 2016, 6:13 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-4647
> https://issues.apache.org/jira/browse/MESOS-4647
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMAKE: Add leveldb library to 3rdparty external builds
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> 0c80fb8d799ea1252492cd98ac0780f1228aadcd 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
> 3a2e0999722007475c023ade75719093e35cfc80 
>   3rdparty/libprocess/cmake/macros/External.cmake 
> e3901b67048f1c028216ae8323ee1c318a46f3cc 
> 
> Diff: https://reviews.apache.org/r/43889/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review120353
---




3rdparty/cmake/Mesos3rdpartyConfigure.cmake (line 34)
<https://reviews.apache.org/r/43889/#comment181786>

I suggest order items according to their dictionary orders.



3rdparty/libprocess/cmake/macros/External.cmake (line 34)
<https://reviews.apache.org/r/43889/#comment181785>

And why we need change `EXTERNAL` macro here? I prososal add a version to 
our leveldb.tar.gz


- haosdent huang


On Feb. 23, 2016, 6:13 p.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43889/
> ---
> 
> (Updated Feb. 23, 2016, 6:13 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-4647
> https://issues.apache.org/jira/browse/MESOS-4647
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMAKE: Add leveldb library to 3rdparty external builds
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> 0c80fb8d799ea1252492cd98ac0780f1228aadcd 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
> 3a2e0999722007475c023ade75719093e35cfc80 
>   3rdparty/libprocess/cmake/macros/External.cmake 
> e3901b67048f1c028216ae8323ee1c318a46f3cc 
> 
> Diff: https://reviews.apache.org/r/43889/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds

[haosdent huang]

> On Feb. 23, 2016, 6:22 p.m., haosdent huang wrote:
> > 3rdparty/libprocess/cmake/macros/External.cmake, line 38
> > <https://reviews.apache.org/r/43889/diff/1/?file=1265841#file1265841line38>
> >
> > And why we need change `EXTERNAL` macro here? I prososal add a version 
> > to our leveldb.tar.gz
> 
> Diana Arroyo wrote:
> I expect we will need to get an agreement with the folks who maintain the 
> make build.  Who is the person that need to be pulled into this discussion?

I think maybe @tillt


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review120353
---


On Feb. 24, 2016, 2:05 p.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43889/
> ---
> 
> (Updated Feb. 24, 2016, 2:05 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-4746
> https://issues.apache.org/jira/browse/MESOS-4746
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMAKE: Add leveldb library to 3rdparty external builds
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> 0c80fb8d799ea1252492cd98ac0780f1228aadcd 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
> 3a2e0999722007475c023ade75719093e35cfc80 
>   3rdparty/libprocess/cmake/macros/External.cmake 
> e3901b67048f1c028216ae8323ee1c318a46f3cc 
> 
> Diff: https://reviews.apache.org/r/43889/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 43519: Speed up MasterMaintenanceTest.InverseOffers.

[haosdent huang]

> On Feb. 24, 2016, 11 p.m., Joseph Wu wrote:
> > src/tests/master_maintenance_tests.cpp, lines 1213-1218
> > <https://reviews.apache.org/r/43519/diff/3/?file=1258885#file1258885line1213>
> >
> > Sorry!  I didn't catch this during the first review :(
> > 
> > We need to wait until we've processed the ACCEPT/DECLINE event before 
> > advancing the clock.  See:
> > 
> > https://github.com/apache/mesos/blob/master/src/tests/master_maintenance_tests.cpp#L1564-L1568

Thank you very much, let me submit a hotfix!


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43519/#review120598
-------


On Feb. 19, 2016, 1:46 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43519/
> ---
> 
> (Updated Feb. 19, 2016, 1:46 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-4169
> https://issues.apache.org/jira/browse/MESOS-4169
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up MasterMaintenanceTest.InverseOffers.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> b98eedec388813ee795dd83ccc5ff27338209475 
> 
> Diff: https://reviews.apache.org/r/43519/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43961: Added some additional synchronization in ROOT_CGROUPS_Pids_and_Tids.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43961/#review120640
---


Ship it!




Ship It!

- haosdent huang


On Feb. 24, 2016, 9:11 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43961/
> ---
> 
> (Updated Feb. 24, 2016, 9:11 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Chi Zhang, Artem Harutyunyan, and 
> Jian Qiu.
> 
> 
> Bugs: MESOS-4677
> https://issues.apache.org/jira/browse/MESOS-4677
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds a set of pipes to mitigate a race between `exec`ing + updating cgroup 
> tasks and the test reading said cgroup tasks.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> 653b037c489072f43e53dec01a811a9249dcd660 
> 
> Diff: https://reviews.apache.org/r/43961/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Centos7: sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_Pids_and_Tids" 
> --gtest_repeat=5000 --gtest_break_on_failure
> 
> ---
> 
> CI results:
> 
> sudo make check
> 
>  | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | 
> Ubuntu 12 |
>  Non-SSL |  :) |@_@   | *|X_X   |   :) |:) |  
>:)|
> With-SSL |  :) |@_@   | *| &|   :) |:) |  
>:)|
> 
>  :) = Passed.
> X_X = Configuration error with docker.
> @_@ = Ran out of disk space in some tests: 
> LinuxFilesystemIsolatorTest.ROOT_SandboxEnvironmentVariable, 
> LinuxFilesystemIsolatorTest.ROOT_MultipleContainers, 
> MesosContainerizerLaunchTest.ROOT_ChangeRootfs, 
> LinuxFilesystemIsolatorTest.ROOT_ImageInVolumeWithRootFilesystem
> 
>   * = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes (Known 
> issue)
>   % = DockerContainerizerTest.ROOT_DOCKER_Logs
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Review Request 43978: Wait until processed offer before advance clock.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43978/
---

Review request for mesos, Joris Van Remoortere and Joseph Wu.


Bugs: MESOS-4169
https://issues.apache.org/jira/browse/MESOS-4169


Repository: mesos


Description
---

Wait until processed offer before advance clock.


Diffs
-

  src/tests/master_maintenance_tests.cpp 
c9e3828933d16ec65298e4ad4b1a3e0ddf99032d 

Diff: https://reviews.apache.org/r/43978/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 43519: Speed up MasterMaintenanceTest.InverseOffers.

[haosdent huang]

> On Feb. 24, 2016, 11 p.m., Joseph Wu wrote:
> > src/tests/master_maintenance_tests.cpp, lines 1213-1218
> > <https://reviews.apache.org/r/43519/diff/3/?file=1258885#file1258885line1213>
> >
> > Sorry!  I didn't catch this during the first review :(
> > 
> > We need to wait until we've processed the ACCEPT/DECLINE event before 
> > advancing the clock.  See:
> > 
> > https://github.com/apache/mesos/blob/master/src/tests/master_maintenance_tests.cpp#L1564-L1568
> 
> haosdent huang wrote:
> Thank you very much, let me submit a hotfix!

Hotfix: https://reviews.apache.org/r/43978/


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43519/#review120598
---


On Feb. 19, 2016, 1:46 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43519/
> ---
> 
> (Updated Feb. 19, 2016, 1:46 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-4169
> https://issues.apache.org/jira/browse/MESOS-4169
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up MasterMaintenanceTest.InverseOffers.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> b98eedec388813ee795dd83ccc5ff27338209475 
> 
> Diff: https://reviews.apache.org/r/43519/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43963: Fixed flakiness in DockerContainerizerTest.ROOT_DOCKER_Logs.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43963/#review120650
---


Ship it!




Verify that add unbuffer works!

- haosdent huang


On Feb. 25, 2016, 2 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43963/
> ---
> 
> (Updated Feb. 25, 2016, 2 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Timothy Chen.
> 
> 
> Bugs: MESOS-4676
> https://issues.apache.org/jira/browse/MESOS-4676
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Adds the `unbuffer` utility in front of each `echo` in the test.  Since 
> Docker appears to handle simultaneous stdout/stderr in a non-robust fashion, 
> this mitigates the amount of overlap the two streams will have in the test.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> a299c9e0744b5657984e5bb0afbe4874a266ddb6 
> 
> Diff: https://reviews.apache.org/r/43963/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> On Centos7: sudo bin/mesos-tests.sh --gtest_filter="\*ROOT_DOCKER_Logs" 
> --gtest_repeat=1200 --gtest_break_on_failure
> 
> ---
> 
> CI results: 
> sudo make check
> 
>  | OSX | CentOS 7 | CentOS 6 | Debian 8 | Ubuntu 15.10 | Ubuntu 14 | 
> Ubuntu 12 |
>  Non-SSL |  :) |:)| *|:)|   :) |:) |  
>:)|
> With-SSL |  :) |:)|&*| &|^ |:) |  
>:)|
> 
>  :) = Passed.
> 
> Known flaky tests:
>   * = DockerContainerizerTest.ROOT_DOCKER_LaunchWithPersistentVolumes
>   & = MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery
>   ^ = LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 43978: Wait until processed offer before advance clock.

[haosdent huang]

> On Feb. 25, 2016, 1:58 a.m., Joseph Wu wrote:
> > I should have noted this: https://reviews.apache.org/r/43971/

Got it, let me discard.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43978/#review120642
---


On Feb. 25, 2016, 1:56 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43978/
> ---
> 
> (Updated Feb. 25, 2016, 1:56 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Bugs: MESOS-4169
> https://issues.apache.org/jira/browse/MESOS-4169
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Wait until processed offer before advance clock.
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> c9e3828933d16ec65298e4ad4b1a3e0ddf99032d 
> 
> Diff: https://reviews.apache.org/r/43978/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43971: Fixed flakiness in MasterMaintenanceTest.InverseOffers.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43971/#review120652
---


Ship it!




Ship It!

- haosdent huang


On Feb. 25, 2016, 1:01 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43971/
> ---
> 
> (Updated Feb. 25, 2016, 1:01 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-4768
> https://issues.apache.org/jira/browse/MESOS-4768
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The accept/decline of the inverse offers in the test could arrive after the 
> clock is paused and advanced in the test.  This meant that the test would 
> trigger an allocation and then idle (because the clock is paused).  This is 
> the same problem we fixed in https://issues.apache.org/jira/browse/MESOS-4059 
> .
> 
> 
> Diffs
> -
> 
>   src/tests/master_maintenance_tests.cpp 
> c9e3828933d16ec65298e4ad4b1a3e0ddf99032d 
> 
> Diff: https://reviews.apache.org/r/43971/diff/
> 
> 
> Testing
> ---
> 
> make check (OSX)
> 
> bin/mesos-tests.sh --gtest_filter="MasterMaintenanceTest.InverseOffers" 
> --gtest_repeat=5000 --gtest_break_on_failure
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 44058: Add metrics for {RESERVE, UNRESERVE} and {CREATE, DESTROY} offer operation

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44058/#review120860
---


Ship it!




Ship It!

- haosdent huang


On Feb. 26, 2016, 7:19 a.m., fan du wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44058/
> ---
> 
> (Updated Feb. 26, 2016, 7:19 a.m.)
> 
> 
> Review request for mesos, Greg Mann, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-4492
> https://issues.apache.org/jira/browse/MESOS-4492
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add metrics for {RESERVE, UNRESERVE} and {CREATE, DESTROY} offer operation
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 8d6d3c6468c6b85fe09c33cf9747cc3d1f515ab9 
>   src/master/metrics.hpp 9d201fcce1c46a890c86a889ab31029f9a061561 
>   src/master/metrics.cpp 30c091198a8fdd6d6a957a351dc37d3dae7788e4 
> 
> Diff: https://reviews.apache.org/r/44058/diff/
> 
> 
> Testing
> ---
> 
> 1. make check on Centos-7 (3.10.0-123.el7.x86_640
> 2. Verify its functionality with 'reserve' http endpoint as an test case
> 
> # curl http://ipdc02-kvm-guest2:5050/metrics/snapshot | python -mjson.tool | 
> grep reserve
> "master/messages_reserve_resource": 0.0,
> "master/messages_unreserve_resource": 0.0,
> 
> 
> # curl -i -d slaveId=6250553a-2f39-4a92-9073-4618d130f433-S1  -d resources='[ 
> { "name": "cpus", "type": "SCALAR","scalar": { "value": 1 
> },"reservation":{"principal": "XiaoHaHa"}}  ]' -X POST  
> ipdc02-kvm-guest2:5050/master/reserve
> HTTP/1.1 200 OK
> Date: Fri, 26 Feb 2016 19:59:01 GMT
> Content-Length: 0
> 
> # curl http://ipdc02-kvm-guest2:5050/metrics/snapshot  | python -mjson.tool | 
> grep reserve
> "master/messages_reserve_resource": 1.0,
> "master/messages_unreserve_resource": 0.0,
> 
> 
> Thanks,
> 
> fan du
> 
>

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

[haosdent huang]

> On Feb. 8, 2016, 10:52 p.m., Ian Downes wrote:
> > src/linux/perf.cpp, lines 423-426
> > <https://reviews.apache.org/r/43283/diff/1/?file=1237011#file1237011line423>
> >
> > Hmmm, I'm not satisfied with this. I thought the new output format was 
> > introduced at a specific kernel version (3.13.0 might not be correct). 
> > Could you please confirm that the 3.10 on CentOS7.1 has the new unit field 
> > but other 3.10 kernels don't.
> 
> haosdent huang wrote:
> The interesting thing here is I saw `unit` appear since 3.14 
> http://lxr.free-electrons.com/source/tools/perf/util/evsel.h?v=3.14#L72 I 
> think I missing something, let me find out more details about this.
> 
> haosdent huang wrote:
> According 
> https://github.com/torvalds/linux/blob/v3.13/tools/perf/builtin-stat.c#L1190-L1206
>  , I think the `perf stat` format for 3.13.0 also is `value,event,cgroup`.
> The `unit` added in this commit which contains since 3.14. 
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=410136f5dd96b6013fe6d1011b523b1c247e1ccb
> Let me try create a virtual machine to verify this.
> 
> haosdent huang wrote:
> I try this in 
> 
> ```
> # cat /etc/issue
> Ubuntu 14.04.3 LTS \n \l
> ```
> 
> Kernel is 
> 
> ```
> uname -a
> Linux haosdent 3.13.0-32-generic #57-Ubuntu SMP Tue Jul 15 03:51:08 UTC 
> 2014 x86_64 x86_64 x86_64 GNU/Linux
> 
> 
> The `perf stat` output don't contains unit:
> 
> ```
> perf stat --all-cpus --field-separator , --log-fd 1 --event cycles 
> --cgroup mesos --event task-clock --cgroup mesos -- sleep 0.25
> ,cycles,mesos
> ,task-clock,mesos
> ```
> 
> Ian Downes wrote:
> Okay, if I'm understanding you correctly the value,unit,event,cgroup 
> format came in 3.14.0, not 3.13.0 as the current code states. Can we not 
> adjust the cases to correctly match the precise kernel versions?

Sorry, I could not get your idea here. Do you mean we need add a check >= 3.0.0 
?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/#review118314
---


On Feb. 14, 2016, 7:59 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43283/
> ---
> 
> (Updated Feb. 14, 2016, 7:59 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.
> 
> 
> Bugs: MESOS-4655
> https://issues.apache.org/jira/browse/MESOS-4655
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128 
> 
> Diff: https://reviews.apache.org/r/43283/diff/
> 
> 
> Testing
> ---
> 
> This also fix similar error in 
> `CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 44254: Add curl_easy_cleanup when fopen is failed.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44254/#review121582
---


Ship it!




Could you create a jira ticket for this?

- haosdent huang


On March 2, 2016, 3:45 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44254/
> ---
> 
> (Updated March 2, 2016, 3:45 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When fopen is failed,we should curl_easy_cleanup curl_handle.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3c80910 
> 
> Diff: https://reviews.apache.org/r/44254/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

> On Feb. 22, 2016, 4:41 a.m., Klaus Ma wrote:
> > src/slave/flags.cpp, line 437
> > <https://reviews.apache.org/r/39939/diff/1/?file=1115726#file1115726line437>
> >
> > I think we need to handle feature interaction with 
> > `docker_mesos_image`. Currently, we mount unix socket into container; but 
> > it'll failed when using TCP socket.

Hi, @klaus1982 Sorry to forgot update this. Do you mean we need add a check 
here?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review120096
---


On Feb. 22, 2016, 3:35 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated Feb. 22, 2016, 3:35 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
>   src/docker/docker.hpp 527b3e48edf7e84095a8d9ff4fd1a848c2d529f0 
>   src/docker/docker.cpp 4ebca660834492f99815a17e04cef6116654dedb 
>   src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

> On Feb. 22, 2016, 4:41 a.m., Klaus Ma wrote:
> > src/slave/flags.cpp, line 437
> > <https://reviews.apache.org/r/39939/diff/1/?file=1115726#file1115726line437>
> >
> > I think we need to handle feature interaction with 
> > `docker_mesos_image`. Currently, we mount unix socket into container; but 
> > it'll failed when using TCP socket.
> 
> haosdent huang wrote:
> Hi, @klaus1982 Sorry to forgot update this. Do you mean we need add a 
> check here?

My concern here is if we use host network when we launch slave in docker, use 
tcp protocol should still works.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review120096
---


On March 3, 2016, 4:40 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated March 3, 2016, 4:40 p.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/
---

(Updated March 3, 2016, 4:40 p.m.)


Review request for mesos, Klaus Ma and Timothy Chen.


Changes
---

Rebase and address @guangya's comment.


Bugs: MESOS-3821
https://issues.apache.org/jira/browse/MESOS-3821


Repository: mesos


Description
---

Make docker_socket option support different protocols.


Diffs (updated)
-

  docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
  src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
  src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
  src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 

Diff: https://reviews.apache.org/r/39939/diff/


Testing
---

make check


Thanks,

haosdent huang

Re: Review Request 44342: XFS disk resource isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44342/#review121888
---




src/Makefile.am (line 869)
<https://reviews.apache.org/r/44342/#comment183733>

Do you forgot to update CMake?


- haosdent huang


On March 3, 2016, 5 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44342/
> ---
> 
> (Updated March 3, 2016, 5 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4828
> https://issues.apache.org/jira/browse/MESOS-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Track sandbox directory usage by dynamically assigning XFS project
> quotas. We track a range of XFS project IDs, assigning a project ID
> and a project quota to each sandbox as it is created. When the task
> reaches the quota, writes will fail with EDQUOT, and the task will have
> an opportunity to handle that.
> 
> Quotas are not applied to volume resources since the isolator interface
> has no insight into the volume lifecycle. Thus it is not currently
> possible to accurately assign and reclaim project IDs.
> 
> If LOW is the lower bound of the project ID range and HIGH is the upper
> bound, you can show the currently allocated project quotas using the
> xfs_quota command:
> 
>   $ xfs_quota -x -c "report -a -n -L LOW -U HIGH"
> 
> To show the project ID assigned to the file PATH, use the xfs_io command:
> 
>   $ xfs_io -r -c stat PATH
> 
> 
> Diffs
> -
> 
>   configure.ac b045d3c68a2d440bed4d1b3e6ab21a1bbe063517 
>   src/Makefile.am b30cc25f61856d6417437547baaa0bb338a30d63 
>   src/slave/containerizer/mesos/containerizer.cpp 
> af3ff5750649497d8852b4761c78d4cae5455a02 
>   src/slave/containerizer/mesos/isolators/disk/xfs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/disk/xfs.cpp PRE-CREATION 
>   src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/44342/diff/
> 
> 
> Testing
> ---
> 
> Manual testing on Fedora 23 w/ XFS. Make check on Fedora and OS X.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 44342: XFS disk resource isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44342/#review121889
---




src/slave/containerizer/mesos/containerizer.cpp (line 216)
<https://reviews.apache.org/r/44342/#comment183734>

Does your isolator only work in linux?



src/slave/containerizer/mesos/isolators/disk/xfs.hpp (line 35)
<https://reviews.apache.org/r/44342/#comment183735>

Style should be

```
namespace mesos {
namespace internal {
namespace slave {
```

here.



src/slave/containerizer/mesos/isolators/disk/xfs.cpp (line 23)
<https://reviews.apache.org/r/44342/#comment183736>

headers should order by dictionary order as well?



src/slave/containerizer/mesos/isolators/disk/xfs.cpp (line 208)
<https://reviews.apache.org/r/44342/#comment183737>

Seems we capital first later in both log and error message.


- haosdent huang


On March 3, 2016, 5 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44342/
> ---
> 
> (Updated March 3, 2016, 5 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4828
> https://issues.apache.org/jira/browse/MESOS-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Track sandbox directory usage by dynamically assigning XFS project
> quotas. We track a range of XFS project IDs, assigning a project ID
> and a project quota to each sandbox as it is created. When the task
> reaches the quota, writes will fail with EDQUOT, and the task will have
> an opportunity to handle that.
> 
> Quotas are not applied to volume resources since the isolator interface
> has no insight into the volume lifecycle. Thus it is not currently
> possible to accurately assign and reclaim project IDs.
> 
> If LOW is the lower bound of the project ID range and HIGH is the upper
> bound, you can show the currently allocated project quotas using the
> xfs_quota command:
> 
>   $ xfs_quota -x -c "report -a -n -L LOW -U HIGH"
> 
> To show the project ID assigned to the file PATH, use the xfs_io command:
> 
>   $ xfs_io -r -c stat PATH
> 
> 
> Diffs
> -
> 
>   configure.ac b045d3c68a2d440bed4d1b3e6ab21a1bbe063517 
>   src/Makefile.am b30cc25f61856d6417437547baaa0bb338a30d63 
>   src/slave/containerizer/mesos/containerizer.cpp 
> af3ff5750649497d8852b4761c78d4cae5455a02 
>   src/slave/containerizer/mesos/isolators/disk/xfs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/disk/xfs.cpp PRE-CREATION 
>   src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/44342/diff/
> 
> 
> Testing
> ---
> 
> Manual testing on Fedora 23 w/ XFS. Make check on Fedora and OS X.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 44342: XFS disk resource isolator.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44342/#review121890
---



Hi, @jamespeach Your patch looks great. I have a question, `ENOSPC` only happen 
when call `write` and we could not register any singal handler in this isolator 
to receive a exceed quote singal, right?


src/slave/containerizer/mesos/isolators/disk/xfs.cpp (line 364)
<https://reviews.apache.org/r/44342/#comment183738>

Need two space line between methods.



src/slave/containerizer/mesos/isolators/disk/xfs.cpp (line 597)
<https://reviews.apache.org/r/44342/#comment183739>

Why we don't move assign logic to `isolate()`?


- haosdent huang


On March 3, 2016, 5 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44342/
> ---
> 
> (Updated March 3, 2016, 5 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4828
> https://issues.apache.org/jira/browse/MESOS-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Track sandbox directory usage by dynamically assigning XFS project
> quotas. We track a range of XFS project IDs, assigning a project ID
> and a project quota to each sandbox as it is created. When the task
> reaches the quota, writes will fail with EDQUOT, and the task will have
> an opportunity to handle that.
> 
> Quotas are not applied to volume resources since the isolator interface
> has no insight into the volume lifecycle. Thus it is not currently
> possible to accurately assign and reclaim project IDs.
> 
> If LOW is the lower bound of the project ID range and HIGH is the upper
> bound, you can show the currently allocated project quotas using the
> xfs_quota command:
> 
>   $ xfs_quota -x -c "report -a -n -L LOW -U HIGH"
> 
> To show the project ID assigned to the file PATH, use the xfs_io command:
> 
>   $ xfs_io -r -c stat PATH
> 
> 
> Diffs
> -
> 
>   configure.ac b045d3c68a2d440bed4d1b3e6ab21a1bbe063517 
>   src/Makefile.am b30cc25f61856d6417437547baaa0bb338a30d63 
>   src/slave/containerizer/mesos/containerizer.cpp 
> af3ff5750649497d8852b4761c78d4cae5455a02 
>   src/slave/containerizer/mesos/isolators/disk/xfs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/disk/xfs.cpp PRE-CREATION 
>   src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/44342/diff/
> 
> 
> Testing
> ---
> 
> Manual testing on Fedora 23 w/ XFS. Make check on Fedora and OS X.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 44342: XFS disk resource isolator.

[haosdent huang]

> On March 3, 2016, 5:30 p.m., haosdent huang wrote:
> > src/Makefile.am, line 869
> > <https://reviews.apache.org/r/44342/diff/2/?file=1279519#file1279519line869>
> >
> > Do you forgot to update CMake?
> 
> James Peach wrote:
> Nope, I just didn't want to block on learning how to do this in Cmake. 
> Can we split that out into a separate Jira?

can.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44342/#review121888
---


On March 3, 2016, 5 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44342/
> ---
> 
> (Updated March 3, 2016, 5 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4828
> https://issues.apache.org/jira/browse/MESOS-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Track sandbox directory usage by dynamically assigning XFS project
> quotas. We track a range of XFS project IDs, assigning a project ID
> and a project quota to each sandbox as it is created. When the task
> reaches the quota, writes will fail with EDQUOT, and the task will have
> an opportunity to handle that.
> 
> Quotas are not applied to volume resources since the isolator interface
> has no insight into the volume lifecycle. Thus it is not currently
> possible to accurately assign and reclaim project IDs.
> 
> If LOW is the lower bound of the project ID range and HIGH is the upper
> bound, you can show the currently allocated project quotas using the
> xfs_quota command:
> 
>   $ xfs_quota -x -c "report -a -n -L LOW -U HIGH"
> 
> To show the project ID assigned to the file PATH, use the xfs_io command:
> 
>   $ xfs_io -r -c stat PATH
> 
> 
> Diffs
> -
> 
>   configure.ac b045d3c68a2d440bed4d1b3e6ab21a1bbe063517 
>   src/Makefile.am b30cc25f61856d6417437547baaa0bb338a30d63 
>   src/slave/containerizer/mesos/containerizer.cpp 
> af3ff5750649497d8852b4761c78d4cae5455a02 
>   src/slave/containerizer/mesos/isolators/disk/xfs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/disk/xfs.cpp PRE-CREATION 
>   src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/44342/diff/
> 
> 
> Testing
> ---
> 
> Manual testing on Fedora 23 w/ XFS. Make check on Fedora and OS X.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 44342: XFS disk resource isolator.

[haosdent huang]

> On March 3, 2016, 5:51 p.m., haosdent huang wrote:
> > Hi, @jamespeach Your patch looks great. I have a question, `ENOSPC` only 
> > happen when call `write` and we could not register any singal handler in 
> > this isolator to receive a exceed quote singal, right?
> 
> James Peach wrote:
> The write fails with ``EDQUOT``. I'm not aware of any signals getting 
> delivered in response to disk quota?

Thx, got it.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44342/#review121890
---


On March 3, 2016, 6:06 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44342/
> ---
> 
> (Updated March 3, 2016, 6:06 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4828
> https://issues.apache.org/jira/browse/MESOS-4828
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Track sandbox directory usage by dynamically assigning XFS project
> quotas. We track a range of XFS project IDs, assigning a project ID
> and a project quota to each sandbox as it is created. When the task
> reaches the quota, writes will fail with EDQUOT, and the task will have
> an opportunity to handle that.
> 
> Quotas are not applied to volume resources since the isolator interface
> has no insight into the volume lifecycle. Thus it is not currently
> possible to accurately assign and reclaim project IDs.
> 
> If LOW is the lower bound of the project ID range and HIGH is the upper
> bound, you can show the currently allocated project quotas using the
> xfs_quota command:
> 
>   $ xfs_quota -x -c "report -a -n -L LOW -U HIGH"
> 
> To show the project ID assigned to the file PATH, use the xfs_io command:
> 
>   $ xfs_io -r -c stat PATH
> 
> 
> Diffs
> -
> 
>   configure.ac b045d3c68a2d440bed4d1b3e6ab21a1bbe063517 
>   src/Makefile.am b30cc25f61856d6417437547baaa0bb338a30d63 
>   src/slave/containerizer/mesos/containerizer.cpp 
> af3ff5750649497d8852b4761c78d4cae5455a02 
>   src/slave/containerizer/mesos/isolators/disk/xfs.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/disk/xfs.cpp PRE-CREATION 
>   src/slave/flags.hpp feb095da4521f678c96f4cc53bdfda262d350388 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/44342/diff/
> 
> 
> Testing
> ---
> 
> Manual testing on Fedora 23 w/ XFS. Make check on Fedora and OS X.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44257/#review121985
---


Ship it!




Ship It!

- haosdent huang


On March 4, 2016, 1:38 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44257/
> ---
> 
> (Updated March 4, 2016, 1:38 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-4678
> https://issues.apache.org/jira/browse/MESOS-4678
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade protobuf to 2.6.1 to support PowerPC LE platform.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
>   3rdparty/libprocess/3rdparty/protobuf-2.5.0.tar.gz 
> e600ac57be4c88efb5f146e4b3ec226d8f685033 
>   3rdparty/libprocess/3rdparty/protobuf-2.6.1.tar.gz PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/README.md 
> c534835db7baca1138791f2c700e95ff73052d85 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 
> 3d1f13082a65f9b1694ee7c65ba0cec131c18c5a 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 
> fb11b1147b3a1872f60e90d0691723f9b2985427 
>   3rdparty/libprocess/3rdparty/versions.am 
> 98195b8eb60b2673d610d8ab7ea31103f137debf 
>   LICENSE c3aaa437af10533132698df3348114195d338965 
>   configure.ac b045d3c68a2d440bed4d1b3e6ab21a1bbe063517 
>   src/java/mesos.pom.in 7615d61eb6fedfa0ead785cd360946c56ccf80af 
>   src/python/interface/setup.py.in d73996734c3a3c70c3a6c0c697bb6733c241c091 
>   src/python/native/ext_modules.py.in 
> 4682e5eed0f7be23fb48ef628e1bebc7741431d7 
>   src/python/protocol/setup.py.in 4c50fbbf1ce11c4c42c848364523225ee7ea5a3b 
> 
> Diff: https://reviews.apache.org/r/44257/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/
---

(Updated March 4, 2016, 2:23 a.m.)


Review request for mesos, Klaus Ma and Timothy Chen.


Changes
---

Address @klaus1982's comment.


Bugs: MESOS-3821
https://issues.apache.org/jira/browse/MESOS-3821


Repository: mesos


Description
---

Make docker_socket option support different protocols.


Diffs (updated)
-

  docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
  src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
  src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
  src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
  src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 

Diff: https://reviews.apache.org/r/39939/diff/


Testing
---

make check


Thanks,

haosdent huang

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

> On Feb. 22, 2016, 4:41 a.m., Klaus Ma wrote:
> > src/slave/flags.cpp, line 437
> > <https://reviews.apache.org/r/39939/diff/1/?file=1115726#file1115726line437>
> >
> > I think we need to handle feature interaction with 
> > `docker_mesos_image`. Currently, we mount unix socket into container; but 
> > it'll failed when using TCP socket.
> 
> haosdent huang wrote:
> Hi, @klaus1982 Sorry to forgot update this. Do you mean we need add a 
> check here?
> 
> haosdent huang wrote:
> My concern here is if we use host network when we launch slave in docker, 
> use tcp protocol should still works.
> 
> Klaus Ma wrote:
> When `docker_mesos_image` is enabled, `docker_socket` are mounted into 
> docker by volume which is not worked for TCP ( 
> https://github.com/apache/mesos/blob/master/src/slave/containerizer/docker.cpp#L293
>  ).
> 
> IMO, two options:
> 
> 1. Highlight in document that TCP docker_socket can not work with 
> `docker_mesos_image`
> 2. Add logic for `docker_mesos_image`, just pass docker_socket into slave 
> in docker instead of mounting it; we also need to update document that it's 
> user's responsibility to make sure network is accessable.

Thank you very much. I add a check here.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review120096
---


On March 4, 2016, 2:23 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated March 4, 2016, 2:23 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 44376: Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44376/#review121999
---


Ship it!




Ship It!

- haosdent huang


On March 4, 2016, 2:33 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44376/
> ---
> 
> (Updated March 4, 2016, 2:33 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-4612
> https://issues.apache.org/jira/browse/MESOS-4612
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am 3782583b7683d9d3bb61e7e8a1953bc3f61055f0 
>   3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
>   3rdparty/versions.am 3f4513d960901bc0c014cc7ca148bf5bd43f5995 
>   3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da 
>   3rdparty/zookeeper-3.4.5.tar.gz 1a547fe17a6fad86012f855d3c4cc38fed4899fc 
>   3rdparty/zookeeper-3.4.8.patch PRE-CREATION 
>   src/examples/java/test-log.in 4c8547aaa115779ae7cec58edde01ab85feeb1b1 
>   src/python/native/ext_modules.py.in 
> 4682e5eed0f7be23fb48ef628e1bebc7741431d7 
>   src/tests/zookeeper_test_server.cpp 
> 0dc041fef8973d35114b9f76a6a4002853884670 
> 
> Diff: https://reviews.apache.org/r/44376/diff/
> 
> 
> Testing
> ---
> 
> Added a new patch that solved 
> [ZOOKEEPER-1643](https://issues.apache.org/jira/browse/ZOOKEEPER-1643)
> 
> The original patch: 
> <https://github.com/apache/zookeeper/commit/46b565e6abd8423c43f1bb8da782d76bac7c392c>
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

> On March 4, 2016, 3:03 a.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, line 134
> > <https://reviews.apache.org/r/39939/diff/3/?file=1280373#file1280373line134>
> >
> > Does the `docker_socket` support starting wit `unix:`? I think not, 
> > because the `Docker::create` will add `unix:` automatically.

As I check, it should support if you run `docker -H unix://`.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review122003
---


On March 4, 2016, 2:23 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated March 4, 2016, 2:23 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

> On March 4, 2016, 3:02 a.m., Klaus Ma wrote:
> > src/slave/containerizer/docker.cpp, lines 136-138
> > <https://reviews.apache.org/r/39939/diff/3/?file=1280373#file1280373line136>
> >
> > Two comments here:
> > 
> > 1. Error message; I'd like to say: "Failed to create docker container; 
> > only unix domain socket is supported for `docker_socket` when 
> > `docker_mesos_image` is enabled"
> > 2. Can you also highlight this limitation/restriction to document/help

Because outside exists

```
  Try containerizer =
DockerContainerizer::create(flags, fetcher);
  if (containerizer.isError()) {
return Error("Could not create DockerContainerizer: " +
 containerizer.error());
```

I change to `only unix domain socket is supported for docker_socket when 
docker_mesos_image is enabled`.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review122000
-------


On March 4, 2016, 2:23 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated March 4, 2016, 2:23 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/
---

(Updated March 4, 2016, 3:13 a.m.)


Review request for mesos, Klaus Ma and Timothy Chen.


Changes
---

Address @guangya and @klaus1982's comments.


Bugs: MESOS-3821
https://issues.apache.org/jira/browse/MESOS-3821


Repository: mesos


Description
---

Make docker_socket option support different protocols.


Diffs (updated)
-

  docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
  docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 
  src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
  src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
  src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
  src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 

Diff: https://reviews.apache.org/r/39939/diff/


Testing
---

make check


Thanks,

haosdent huang

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

> On March 4, 2016, 3:03 a.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, line 134
> > <https://reviews.apache.org/r/39939/diff/3/?file=1280373#file1280373line134>
> >
> > Does the `docker_socket` support starting wit `unix:`? I think not, 
> > because the `Docker::create` will add `unix:` automatically.
> 
> haosdent huang wrote:
> As I check, it should support if you run `docker -H unix://`.
> 
> Guangya Liu wrote:
> Yes, but the `docker_socket` flag cannot include `unix:` as prefix as the 
> `Docker::create` already added `unix:` prefix, the format of `docker_socket` 
> should be `tcp://0.0.0.0:2375, /var/run/docker.sock`

I think still could, when we pass unix:///var/run/docker.sock as docker_socket. 
It would go into this, right?

```
  if (strings::startsWith(socket, "/")) {
docker_ = new Docker(path, "unix://" + socket);
  } else {
docker_ = new Docker(path, socket); <--- If we use unix:///
  }
```


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review122003
---


On March 4, 2016, 3:13 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated March 4, 2016, 3:13 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

> On March 4, 2016, 3:03 a.m., Guangya Liu wrote:
> > src/slave/containerizer/docker.cpp, line 134
> > <https://reviews.apache.org/r/39939/diff/3/?file=1280373#file1280373line134>
> >
> > Does the `docker_socket` support starting wit `unix:`? I think not, 
> > because the `Docker::create` will add `unix:` automatically.
> 
> haosdent huang wrote:
> As I check, it should support if you run `docker -H unix://`.
> 
> Guangya Liu wrote:
> Yes, but the `docker_socket` flag cannot include `unix:` as prefix as the 
> `Docker::create` already added `unix:` prefix, the format of `docker_socket` 
> should be `tcp://0.0.0.0:2375, /var/run/docker.sock`
> 
> haosdent huang wrote:
> I think still could, when we pass unix:///var/run/docker.sock as 
> docker_socket. It would go into this, right?
> 
> ```
>   if (strings::startsWith(socket, "/")) {
> docker_ = new Docker(path, "unix://" + socket);
>   } else {
> docker_ = new Docker(path, socket); <--- If we use unix:///
>   }
> ```
> 
> Guangya Liu wrote:
> Yes, then what about update the configuration.md, flags.cpp etc by adding 
> unix:///var/run/docker.sock as a valid option?

Got it, let me update.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/#review122003
---


On March 4, 2016, 3:13 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39939/
> ---
> 
> (Updated March 4, 2016, 3:13 a.m.)
> 
> 
> Review request for mesos, Klaus Ma and Timothy Chen.
> 
> 
> Bugs: MESOS-3821
> https://issues.apache.org/jira/browse/MESOS-3821
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make docker_socket option support different protocols.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
>   docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 
>   src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
>   src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
>   src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
>   src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 
> 
> Diff: https://reviews.apache.org/r/39939/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/
---

(Updated March 4, 2016, 3:41 a.m.)


Review request for mesos, Klaus Ma and Timothy Chen.


Changes
---

Address @guangya's comment.


Bugs: MESOS-3821
https://issues.apache.org/jira/browse/MESOS-3821


Repository: mesos


Description
---

Make docker_socket option support different protocols.


Diffs (updated)
-

  docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
  docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 
  src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
  src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
  src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
  src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 

Diff: https://reviews.apache.org/r/39939/diff/


Testing
---

make check


Thanks,

haosdent huang

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/
---

(Updated March 4, 2016, 3:54 a.m.)


Review request for mesos, Klaus Ma and Timothy Chen.


Changes
---

Address @guangya's comments.


Bugs: MESOS-3821
https://issues.apache.org/jira/browse/MESOS-3821


Repository: mesos


Description
---

Make docker_socket option support different protocols.


Diffs (updated)
-

  docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
  docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 
  src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
  src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
  src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
  src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 

Diff: https://reviews.apache.org/r/39939/diff/


Testing
---

make check


Thanks,

haosdent huang

Re: Review Request 39939: Make docker_socket option support different protocols.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39939/
---

(Updated March 4, 2016, 6:10 a.m.)


Review request for mesos, Klaus Ma and Timothy Chen.


Changes
---

Address @guangya's comment.


Bugs: MESOS-3821
https://issues.apache.org/jira/browse/MESOS-3821


Repository: mesos


Description
---

Make docker_socket option support different protocols.


Diffs (updated)
-

  docs/configuration.md 305ba2c801c2060db6dcb4ef83c1043aaa7d520c 
  docs/docker-containerizer.md 865b2cf0e158b1aab6c384d26ab7a3d9800610ac 
  src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972 
  src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373 
  src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
  src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 

Diff: https://reviews.apache.org/r/39939/diff/


Testing
---

make check


Thanks,

haosdent huang

Re: Review Request 44380: Change IOTest.BufferedRead to write to the temporary directory.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44380/#review122027
---


Ship it!




Ship It!

- haosdent huang


On March 4, 2016, 7:27 a.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44380/
> ---
> 
> (Updated March 4, 2016, 7:27 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-4807
> https://issues.apache.org/jira/browse/MESOS-4807
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit changes IOTest.BufferedRead so that tests could be
> executed from temporary directories via TemporaryDirectoryTest
> fixture (MESOS-4807).
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/io_tests.cpp 
> 2bffc7cd9c3aa204a1d1b8eb45f0bff12f49ca62 
> 
> Diff: https://reviews.apache.org/r/44380/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44372/#review122029
---




3rdparty/libprocess/3rdparty/Makefile.am (line 44)
<https://reviews.apache.org/r/44372/#comment183876>

How about align the `` here.



3rdparty/libprocess/3rdparty/Makefile.am (line 68)
<https://reviews.apache.org/r/44372/#comment183877>

    ditto.


- haosdent huang


On March 4, 2016, 7:24 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44372/
> ---
> 
> (Updated March 4, 2016, 7:24 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-4805
> https://issues.apache.org/jira/browse/MESOS-4805
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade http-parser to 2.6.1 to support Power LE platform.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 6eac4dc0f7189e209e7d7232419e4de4bc0875c0 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> b8351ad0181d885a984580ae8de208ea0524b0e7 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> ddf7e3d9bf76d4a03c33f02d52ec29812aef8509 
>   3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz PRE-CREATION 
>   3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.patch 
> f9fac12437a6bedc66353fda1ce9c0d7a383225a 
>   3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.tar.gz 
> b811b63ce0ad6d71d9d296fed76656c023c76fc5 
>   3rdparty/libprocess/3rdparty/versions.am 
> 98195b8eb60b2673d610d8ab7ea31103f137debf 
>   3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d 
>   3rdparty/libprocess/src/decoder.hpp 
> a20b5ba8fc50d834573d253948645cc863f030dd 
>   LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 
> 
> Diff: https://reviews.apache.org/r/44372/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 44337: Updated utils for URI constructor streaming.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44337/#review122031
---




src/uri/utils.cpp (line 58)
<https://reviews.apache.org/r/44337/#comment183878>

How about `uri.path().empty()`?


- haosdent huang


On March 4, 2016, 3 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44337/
> ---
> 
> (Updated March 4, 2016, 3 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4851
> https://issues.apache.org/jira/browse/MESOS-4851
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated utils for URI constructor streaming.
> 
> 
> Diffs
> -
> 
>   src/tests/uri_tests.cpp 1d33ab110bed7c0b7ecfa5d608965da5a1729562 
>   src/uri/utils.cpp 3940dc041c1783eec9e7c950402fd7c42e620d8e 
> 
> Diff: https://reviews.apache.org/r/44337/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> ./bin/mesos-tests.sh --gtest_filter="UriTest.*"
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.

[haosdent huang]

> On March 4, 2016, 7:37 a.m., haosdent huang wrote:
> > 3rdparty/libprocess/3rdparty/Makefile.am, line 44
> > <https://reviews.apache.org/r/44372/diff/2/?file=1280491#file1280491line44>
> >
> > How about align the `` here.
> 
> Zhiwei Chen wrote:
> There are too many backslashes that did not column aligned, how about 
> create another patch to fix this?
> 
> I don't want to do things that not related to this patch.
> 
> Thanks.

Seems only few `` not align. 
https://github.com/apache/mesos/blob/master/3rdparty/libprocess/3rdparty/Makefile.am


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44372/#review122029
---


On March 4, 2016, 7:24 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44372/
> ---
> 
> (Updated March 4, 2016, 7:24 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-4805
> https://issues.apache.org/jira/browse/MESOS-4805
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade http-parser to 2.6.1 to support Power LE platform.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 6eac4dc0f7189e209e7d7232419e4de4bc0875c0 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> b8351ad0181d885a984580ae8de208ea0524b0e7 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> ddf7e3d9bf76d4a03c33f02d52ec29812aef8509 
>   3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz PRE-CREATION 
>   3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.patch 
> f9fac12437a6bedc66353fda1ce9c0d7a383225a 
>   3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.tar.gz 
> b811b63ce0ad6d71d9d296fed76656c023c76fc5 
>   3rdparty/libprocess/3rdparty/versions.am 
> 98195b8eb60b2673d610d8ab7ea31103f137debf 
>   3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d 
>   3rdparty/libprocess/src/decoder.hpp 
> a20b5ba8fc50d834573d253948645cc863f030dd 
>   LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 
> 
> Diff: https://reviews.apache.org/r/44372/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 44421: Added support for "overlay" keyword.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44421/#review122195
---



I agree this could works completely. But I not sure whether we have a better 
way to add something like `overlayfs::supported()`? Because some guys may 
forgor this and continue us `fs::supported("overlayfs")` in the future.

Another question is changing the `fs::supported` interface also bring confusing 
thing. For example, `fs::support("ext3,overlay")` means we check our filesystem 
support both `ext3` and `overlay`, or check support any one of the list `ext3, 
overlayfs`?

- haosdent huang


On March 5, 2016, 8:04 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44421/
> ---
> 
> (Updated March 5, 2016, 8:04 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Jie Yu, and Shuai Lin.
> 
> 
> Bugs: MESOS-4874
> https://issues.apache.org/jira/browse/MESOS-4874
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The "overlayfs" was renamed to "overlay" in kernel 4.2, for overlay
> support check function, it should check both "overlay" and "overlayfs"
> in "/proc/filesystems".
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
>   src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> 55652540e35f9c451ad85cfead575a788aa3eba1 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
> 5cc0f8b5a8cd4c945023f874056a8184113186c5 
>   src/tests/environment.cpp ee1bbe6b4e3dda1e27b63d71a08ef0d1d254741a 
> 
> Diff: https://reviews.apache.org/r/44421/diff/
> 
> 
> Testing
> ---
> 
> root@mesos002:~/src/mesos/m1/mesos/build# uname -r
> 4.2.3-040203-generic
> root@mesos002:~/src/mesos/m1/mesos/build# lsmod  | grep over
> overlay45056  1 
> root@mesos002:~/src/mesos/m1/mesos/build# cat /proc/filesystems | grep over
> nodev overlay
> root@mesos002:~/src/
> 
> make
> make check
> ./bin/mesos-tests.sh 
> --gtest_filter="OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackend" --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44376: Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.

[haosdent huang]

> On March 4, 2016, 2:55 a.m., haosdent huang wrote:
> > Ship It!

Sorry, I found you binary file in this patch is incomplete when you submit it. 
Could you apply this https://reviews.reviewboard.org/r/7571/diff/1#index_header 
to you rbtools and upload the patch again?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44376/#review121999
---


On March 4, 2016, 9:22 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44376/
> ---
> 
> (Updated March 4, 2016, 9:22 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-4612
> https://issues.apache.org/jira/browse/MESOS-4612
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am 49aa55741d76aa88c8fbb526f18908312bb0c717 
>   3rdparty/cmake/Versions.cmake 6eac4dc0f7189e209e7d7232419e4de4bc0875c0 
>   3rdparty/versions.am c2dae2fb521b12344b93bf771dd5497ba8d446c3 
>   3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da 
>   3rdparty/zookeeper-3.4.5.tar.gz 1a547fe17a6fad86012f855d3c4cc38fed4899fc 
>   3rdparty/zookeeper-3.4.8.patch PRE-CREATION 
>   src/examples/java/test-log.in 4c8547aaa115779ae7cec58edde01ab85feeb1b1 
>   src/python/native/ext_modules.py.in 
> eb93864733713dddad66141c6b8b6cd895f41484 
>   src/tests/zookeeper_test_server.cpp 
> 0dc041fef8973d35114b9f76a6a4002853884670 
> 
> Diff: https://reviews.apache.org/r/44376/diff/
> 
> 
> Testing
> ---
> 
> Added a new patch that solved 
> [ZOOKEEPER-1643](https://issues.apache.org/jira/browse/ZOOKEEPER-1643)
> 
> The original patch: 
> <https://github.com/apache/zookeeper/commit/46b565e6abd8423c43f1bb8da782d76bac7c392c>
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform.

[haosdent huang]

> On March 4, 2016, 1:45 a.m., haosdent huang wrote:
> > Ship It!

Sorry, I found you binary file in this patch is incomplete when you submit it. 
Could you apply this https://reviews.reviewboard.org/r/7571/diff/1#index_header 
to you rbtools and upload the patch again? Same as your patch for MESOS-4612


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44257/#review121985
---


On March 4, 2016, 1:38 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44257/
> ---
> 
> (Updated March 4, 2016, 1:38 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-4678
> https://issues.apache.org/jira/browse/MESOS-4678
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade protobuf to 2.6.1 to support PowerPC LE platform.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
>   3rdparty/libprocess/3rdparty/protobuf-2.5.0.tar.gz 
> e600ac57be4c88efb5f146e4b3ec226d8f685033 
>   3rdparty/libprocess/3rdparty/protobuf-2.6.1.tar.gz PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/README.md 
> c534835db7baca1138791f2c700e95ff73052d85 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 
> 3d1f13082a65f9b1694ee7c65ba0cec131c18c5a 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc 
> fb11b1147b3a1872f60e90d0691723f9b2985427 
>   3rdparty/libprocess/3rdparty/versions.am 
> 98195b8eb60b2673d610d8ab7ea31103f137debf 
>   LICENSE c3aaa437af10533132698df3348114195d338965 
>   configure.ac b045d3c68a2d440bed4d1b3e6ab21a1bbe063517 
>   src/java/mesos.pom.in 7615d61eb6fedfa0ead785cd360946c56ccf80af 
>   src/python/interface/setup.py.in d73996734c3a3c70c3a6c0c697bb6733c241c091 
>   src/python/native/ext_modules.py.in 
> 4682e5eed0f7be23fb48ef628e1bebc7741431d7 
>   src/python/protocol/setup.py.in 4c50fbbf1ce11c4c42c848364523225ee7ea5a3b 
> 
> Diff: https://reviews.apache.org/r/44257/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 44379: Correctly parse perf stat format for 3.10 kernel.

[haosdent huang]

> On March 8, 2016, 1:35 a.m., Ben Mahler wrote:
> > src/linux/perf.cpp, lines 430-431
> > 
> >
> > Couple of thoughts here:
> > 
> > (1) This comment is no longer accurate since there is a special case 
> > for 3.10. Would be better to re-structure the last block of this else flow 
> > to better reflect the new logic.
> > 
> > (2) What about 3.11? Is it the same as 3.10? It would be surprising if 
> > 3.11 and < 3.10 are the same, but 3.10 is different.

There is a exist patch may related to this. https://reviews.apache.org/r/43283/


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44379/#review122455
---


On March 4, 2016, 6:28 a.m., fan du wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44379/
> ---
> 
> (Updated March 4, 2016, 6:28 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-4705
> https://issues.apache.org/jira/browse/MESOS-4705
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Correctly parse perf stat format for 3.10 kernel.
> 
> 
> Diffs
> -
> 
>   src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128 
> 
> Diff: https://reviews.apache.org/r/44379/diff/
> 
> 
> Testing
> ---
> 
> {Found and Test} with Serenity, ema filter could get perf event statistics 
> correctly as expected.
> 
> 
> Thanks,
> 
> fan du
> 
>

Re: Review Request 44421: Added support for "overlay" keyword.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44421/#review123133
---


Ship it!




Ship It!

- haosdent huang


On March 11, 2016, 11:58 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44421/
> ---
> 
> (Updated March 11, 2016, 11:58 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Jie Yu, and Shuai Lin.
> 
> 
> Bugs: MESOS-4874
> https://issues.apache.org/jira/browse/MESOS-4874
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The "overlayfs" was renamed to "overlay" in kernel 4.2, for overlay
> support check function, it should check both "overlay" and "overlayfs"
> in "/proc/filesystems".
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp 4525a5d5566e2bc913894e993ac7350f1bbd9cc0 
>   src/linux/fs.cpp dbf94759b6382bfafd3f3b8b4c2047af36a53ad5 
>   src/slave/containerizer/mesos/provisioner/backend.cpp 
> 55652540e35f9c451ad85cfead575a788aa3eba1 
>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp 
> 5cc0f8b5a8cd4c945023f874056a8184113186c5 
>   src/tests/environment.cpp ee1bbe6b4e3dda1e27b63d71a08ef0d1d254741a 
> 
> Diff: https://reviews.apache.org/r/44421/diff/
> 
> 
> Testing
> ---
> 
> root@mesos002:~/src/mesos/m1/mesos/build# uname -r
> 4.2.3-040203-generic
> root@mesos002:~/src/mesos/m1/mesos/build# lsmod  | grep over
> overlay45056  1 
> root@mesos002:~/src/mesos/m1/mesos/build# cat /proc/filesystems | grep over
> nodev overlay
> root@mesos002:~/src/
> 
> make
> make check
> ./bin/mesos-tests.sh 
> --gtest_filter="OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackend" --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 43956: Created base docker image for test suite.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43956/#review123173
---




src/tests/containerizer/docker_archive.hpp (line 169)
<https://reviews.apache.org/r/43956/#comment185347>

We don't need clear anyfiles we created before once failed, right?



src/tests/containerizer/docker_archive.hpp (line 212)
<https://reviews.apache.org/r/43956/#comment185346>

Do we need pass a value to avoid it await forever? Above code also have 
another tarRootfs.await()


- haosdent huang


On March 10, 2016, 11:37 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43956/
> ---
> 
> (Updated March 10, 2016, 11:37 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4684
> https://issues.apache.org/jira/browse/MESOS-4684
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Created base docker image for test suite.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
>   src/tests/containerizer/docker_archive.hpp PRE-CREATION 
>   src/tests/containerizer/runtime_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43956/diff/
> 
> 
> Testing
> ---
> 
> (Ubuntu14.04 + clang-3.6)
> 
> make -j24 check GTEST_FILTER="*ROOT_RUNTIME_CreateDockerLocalTar*" 
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="*ROOT_RUNTIME_CreateDockerLocalTar*"
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 44672: Added normalize method to registry puller.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44672/#review123295
---


Ship it!




Ship It!

- haosdent huang


On March 10, 2016, 11:49 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44672/
> ---
> 
> (Updated March 10, 2016, 11:49 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added normalize method to registry puller.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6d637ed14f35feb554c8fcc63a7a7e046aaca574 
> 
> Diff: https://reviews.apache.org/r/44672/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> sudo ./bin/mesos-test.sh 
> --gtest_filter="*ProvisionerDockerRegistryPullerTest*"
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 44761: [WIP][PROPOSAL_2]Add CgroupsIsolator. This is only used for discussion.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44761/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-4697
https://issues.apache.org/jira/browse/MESOS-4697


Repository: mesos


Description
---

Add CgroupsIsolator. This is only used for discussion.


Diffs
-

  src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 
  src/Makefile.am f2a592dba3e963c99c48c4b9045b4a04d173cb22 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44761/diff/


Testing
---


Thanks,

haosdent huang

Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44762/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-4697
https://issues.apache.org/jira/browse/MESOS-4697


Repository: mesos


Description
---

Add CgroupsIsolator. This is only used for discussion.


Diffs
-

  src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 
  src/Makefile.am f2a592dba3e963c99c48c4b9045b4a04d173cb22 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/info.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/info.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44762/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44762/
---

(Updated March 13, 2016, 5:50 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4697
https://issues.apache.org/jira/browse/MESOS-4697


Repository: mesos


Description
---

Add CgroupsIsolator. This is only used for discussion.


Diffs
-

  src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 
  src/Makefile.am f2a592dba3e963c99c48c4b9045b4a04d173cb22 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/info.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/info.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44762/diff/


Testing (updated)
---

The relations between classes in this proposal is:

```
++
||
| CgroupsIsolatorProcess <-+
|| |
+^---+ +
 |   Belongs to
 + +
Belongs to |
 + |
 | |
   +-+-+   +---+-+
   |   |   | |
   | Subsystem <---+Used by+---+ CgroupsIsolatorInfo |
   |   |   | |
   +---+   +-+
```


Thanks,

haosdent huang

Re: Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44762/#review123319
---




src/slave/containerizer/mesos/isolators/cgroups/info.hpp (line 55)
<https://reviews.apache.org/r/44762/#comment185536>

Because both CgroupsIsolatorProcess and Subsystem need access 
CgroupsIsolatorInfo, I use struct here.



src/slave/containerizer/mesos/isolators/cgroups/info.hpp (line 75)
<https://reviews.apache.org/r/44762/#comment185537>

Could not use something like 
```
vector
```

here.



src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (line 63)
<https://reviews.apache.org/r/44762/#comment185535>

Because we set ContainerLimiation when oom or in some scenarios, I use 
WatchCallback here.



src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp (line 93)
<https://reviews.apache.org/r/44762/#comment185538>

Because besides `assign`, sometimes we would like to register oom listener 
in mem subsytem, I move it from `CgroupsIsolatorProcess` to `Subsystem` as a 
default implementation. But it would assign to same hierarchy multiple times, 
should I move it back to `CgroupsIsolatorProcess`?


- haosdent huang


On March 13, 2016, 5:50 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44762/
> ---
> 
> (Updated March 13, 2016, 5:50 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4697
> https://issues.apache.org/jira/browse/MESOS-4697
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add CgroupsIsolator. This is only used for discussion.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 
>   src/Makefile.am f2a592dba3e963c99c48c4b9045b4a04d173cb22 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/info.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/info.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44762/diff/
> 
> 
> Testing
> ---
> 
> The relations between classes in this proposal is:
> 
> ```
> ++
> ||
> | CgroupsIsolatorProcess <-+
> || |
> +^---+ +
>  |   Belongs to
>  + +
> Belongs to |
>  + |
>  | |
>+-+-+   +---+-+
>|   |   | |
>    | Subsystem <---+Used by+---+ CgroupsIsolatorInfo |
>|   |   | |
>+---+   +-+
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 44761: [WIP][PROPOSAL_2]Add CgroupsIsolator. This is only used for discussion.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44761/
---

(Updated March 13, 2016, 6:09 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4697
https://issues.apache.org/jira/browse/MESOS-4697


Repository: mesos


Description
---

Add CgroupsIsolator. This is only used for discussion.


Diffs
-

  src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 
  src/Makefile.am f2a592dba3e963c99c48c4b9045b4a04d173cb22 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44761/diff/


Testing (updated)
---

The relations between classes in this proposal is:
```
   ++
   ||
   | CgroupsIsolatorProcess |
   ||
   +---^+
   |
   |
 Belongs to
   |
+--+---+
|  |
| CgroupsIsolatorProcess::Info |
|  |
+--^---+
   |
 Belongs to
   |
 +-+-+
 |   |
 | Subsystem |
 |   |
 +---+
```


Thanks,

haosdent huang

Re: Review Request 44762: [WIP][PROPOSAL_1]Add CgroupsIsolator. This is only used for discussion.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44762/#review123321
---




src/slave/containerizer/mesos/isolators/cgroups/info.hpp (line 55)
<https://reviews.apache.org/r/44762/#comment185539>

Another problem here is could not avoid different threads to modify a same 
`CgroupsIsolatorInfo` object in a easy way.


- haosdent huang


On March 13, 2016, 5:50 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44762/
> ---
> 
> (Updated March 13, 2016, 5:50 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4697
> https://issues.apache.org/jira/browse/MESOS-4697
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add CgroupsIsolator. This is only used for discussion.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 0517dd1ae7125ac1ae85cc83b6daaca66a10b8b4 
>   src/Makefile.am f2a592dba3e963c99c48c4b9045b4a04d173cb22 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/info.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/info.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44762/diff/
> 
> 
> Testing
> ---
> 
> The relations between classes in this proposal is:
> 
> ```
> ++
> ||
> | CgroupsIsolatorProcess <-+
> || |
> +^---+ +
>  |   Belongs to
>  + +
> Belongs to |
>  + |
>  | |
>+-+-+   +---+-+
>|   |   | |
>| Subsystem <---+Used by+---+ CgroupsIsolatorInfo |
>|   |   | |
>+---+   +-+
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 44798: [WIP]Remove SlaveState in containerizer interface.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44798/
---

Review request for mesos and Till Toenshoff.


Bugs: MESOS-3709
https://issues.apache.org/jira/browse/MESOS-3709


Repository: mesos


Description
---

Remove SlaveState in containerizer interface.


Diffs
-

  src/slave/containerizer/composing.hpp 
f3eebd19bc9e6b3b8a969a2ad967b3e2909e0ee4 
  src/slave/containerizer/composing.cpp 
15d059f0bbda4e8cb93c65c09327dde1e34d3e7b 
  src/slave/containerizer/containerizer.hpp 
ff78b4d0fd4a3b862f6019fc757c16b7367cd3cf 
  src/slave/containerizer/docker.hpp 79cd955e9c241becff52cc4bbef81dcc16802ee7 
  src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
  src/slave/containerizer/external_containerizer.hpp 
feeb0278a3d8fec8c7177a9a3dc443ee0c198c5c 
  src/slave/containerizer/external_containerizer.cpp 
fe368dd52644b89e47ffd4d947de290b3998fb1a 
  src/slave/containerizer/mesos/containerizer.hpp 
3ef6a6752a6656e97be9f48bd4d2d060d1f9cb46 
  src/slave/containerizer/mesos/containerizer.cpp 
af3ff5750649497d8852b4761c78d4cae5455a02 
  src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 
  src/tests/container_logger_tests.cpp 00f4129e46aa9268fbb66da25b34e61004fa87b2 
  src/tests/containerizer.hpp 67fbe7fedbe170c3f22a2dcbb5aebf4195a5aabc 
  src/tests/containerizer.cpp c6772ce5908edaab6c3189a65e8446217d1c7c27 
  src/tests/containerizer/composing_containerizer_tests.cpp 
e7e3b622b6606a812aef046c761bf92368d34af2 
  src/tests/containerizer/docker_containerizer_tests.cpp 
8afaa4dab3984e9866b7b223e8e2e70ef83a39dc 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
15f0f93d2e5c19a22f6cc4a71a7d94be4aaec2c1 

Diff: https://reviews.apache.org/r/44798/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44798/
---

(Updated March 15, 2016, 2:02 a.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Rebase


Summary (updated)
-

Update `Slave::_recoverContainerizer` to use `ContainerState`.


Bugs: MESOS-3709
https://issues.apache.org/jira/browse/MESOS-3709


Repository: mesos


Description (updated)
---

Update `Slave::_recoverContainerizer` to use `ContainerState`.


Diffs (updated)
-

  src/slave/containerizer/containerizer.hpp 
ff78b4d0fd4a3b862f6019fc757c16b7367cd3cf 
  src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 

Diff: https://reviews.apache.org/r/44798/diff/


Testing
---


Thanks,

haosdent huang

Review Request 44822: Remove `SlaveState` in `MesosContainerizer` during recover.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44822/
---

Review request for mesos.


Repository: mesos


Description
---

Remove `SlaveState` in `MesosContainerizer` during recover.


Diffs
-

  src/slave/containerizer/mesos/containerizer.hpp 
3ef6a6752a6656e97be9f48bd4d2d060d1f9cb46 
  src/slave/containerizer/mesos/containerizer.cpp 
4638d08328127a8c4ae37555f2be74fe9695da31 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
15f0f93d2e5c19a22f6cc4a71a7d94be4aaec2c1 

Diff: https://reviews.apache.org/r/44822/diff/


Testing
---


Thanks,

haosdent huang

Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44823/
---

Review request for mesos and Till Toenshoff.


Repository: mesos


Description
---

Remove `SlaveState` in `DockerContainerizer` during recover.


Diffs
-

  src/slave/containerizer/docker.hpp 79cd955e9c241becff52cc4bbef81dcc16802ee7 
  src/slave/containerizer/docker.cpp fb9188a19a5cd8211d4f36f9647ebb70de560109 
  src/tests/containerizer/docker_containerizer_tests.cpp 
8afaa4dab3984e9866b7b223e8e2e70ef83a39dc 

Diff: https://reviews.apache.org/r/44823/diff/


Testing
---


Thanks,

haosdent huang

Review Request 44824: Remove `SlaveState` in `ComposingContainerizer` during recover.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44824/
---

Review request for mesos and Till Toenshoff.


Repository: mesos


Description
---

Remove `SlaveState` in `ComposingContainerizer` during recover.


Diffs
-

  src/slave/containerizer/composing.hpp 
f3eebd19bc9e6b3b8a969a2ad967b3e2909e0ee4 
  src/slave/containerizer/composing.cpp 
15d059f0bbda4e8cb93c65c09327dde1e34d3e7b 
  src/tests/containerizer/composing_containerizer_tests.cpp 
e7e3b622b6606a812aef046c761bf92368d34af2 

Diff: https://reviews.apache.org/r/44824/diff/


Testing
---


Thanks,

haosdent huang

Review Request 44826: Remove `SlaveState` in `TestContainerizer` during recover.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44826/
---

Review request for mesos and Till Toenshoff.


Repository: mesos


Description
---

Remove `SlaveState` in `TestContainerizer` during recover.


Diffs
-

  src/tests/containerizer.hpp 67fbe7fedbe170c3f22a2dcbb5aebf4195a5aabc 
  src/tests/containerizer.cpp c6772ce5908edaab6c3189a65e8446217d1c7c27 

Diff: https://reviews.apache.org/r/44826/diff/


Testing
---


Thanks,

haosdent huang

Review Request 44825: Remove `SlaveState` in `ExternalContainerizer` during recover.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44825/
---

Review request for mesos and Till Toenshoff.


Repository: mesos


Description
---

Remove `SlaveState` in `ExternalContainerizer` during recover.


Diffs
-

  src/slave/containerizer/external_containerizer.hpp 
feeb0278a3d8fec8c7177a9a3dc443ee0c198c5c 
  src/slave/containerizer/external_containerizer.cpp 
fe368dd52644b89e47ffd4d947de290b3998fb1a 

Diff: https://reviews.apache.org/r/44825/diff/


Testing
---


Thanks,

haosdent huang

Review Request 44828: Remove `SlaveState` in ContainerLoggerTest related test cases.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44828/
---

Review request for mesos and Till Toenshoff.


Repository: mesos


Description
---

Remove `SlaveState` in ContainerLoggerTest related test cases.


Diffs
-

  src/tests/container_logger_tests.cpp 00f4129e46aa9268fbb66da25b34e61004fa87b2 

Diff: https://reviews.apache.org/r/44828/diff/


Testing
---


Thanks,

haosdent huang

Review Request 44832: Validate string when convert `Flags` to `hashmap`.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44832/
---

Review request for mesos, Adam B, Ben Mahler, and Kevin Klues.


Bugs: MESOS-2023
https://issues.apache.org/jira/browse/MESOS-2023


Repository: mesos


Description
---

Validate string when convert `Flags` to `hashmap`.


Diffs
-

  src/common/parse.hpp 9535fad0d50b469fbb4dc6ac5cf5c89b40d29b47 

Diff: https://reviews.apache.org/r/44832/diff/


Testing
---

1. Without pass `--env=`.
```
$ ./src/mesos-execute  --master=127.0.0.1:5050 --name=test --command='echo $a'
```

Output:
```
Starting task test
Forked command at 4542
sh -c 'echo $a'
I0315 11:45:39.153188  4402 slave.cpp:3002] Handling status update TASK_RUNNING 
(UUID: 06b8f974-b6ec-4d10-b1d8-f84b5d4f728d) for task test of framework 
cf1af3e0-dd66-41e8-8c56-7ad80d7dce98-0001 from execu
tor(1)@127.0.0.1:54698
I0315 11:45:39.153964  4401 status_update_manager.cpp:320] Received status 
update TASK_RUNNING (UUID: 06b8f974-b6ec-4d10-b1d8-f84b5d4f728d) for task test 
of framework cf1af3e0-dd66-41e8-8c56-7ad80d7dce98-
0001
```

2. Pass `--env=`.
```
$ ./src/mesos-execute  --master=127.0.0.1:5050 --name=test --command='echo $a' 
--env="{\"a\": \"stdin\"}"
```

Output:
```
Registered executor on localhost
Starting task test
Forked command at 4675
sh -c 'echo $a'
stdin
I0315 11:46:34.797502  4408 slave.cpp:3002] Handling status update TASK_RUNNING 
(UUID: 16040c40-f5e4-4bf0-8690-447f2901310b) for task test of framework 
cf1af3e0-dd66-41e8-8c56-7ad80d7dce98-0003 from execu
tor(1)@127.0.0.1:57831
```

3. Pass incorrect json format in `--env=`.
```
./src/mesos-execute  --master=127.0.0.1:5050 --name=test --command='echo $a' 
--env="{\"a\": {}}"
Failed to load flag 'env': Failed to load value '{"a": {}}': The value of key 
'a' in '{"a":{}}' is not a valid string.
```


Thanks,

haosdent huang

Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44836/#review123607
---



Thank you for your patch. Could you update the `Bugs` field to `MESOS-4930`? By 
the way, I think you need find a shepherd for this ticket. Could you follow 
this guide 
https://github.com/apache/mesos/blob/master/docs/submitting-a-patch.md to find 
the committer which could help you review this more detail and help you submit?


src/examples/long_lived_framework.cpp (line 92)
<https://reviews.apache.org/r/44836/#comment185843>

We have a function in ``. I think you could use it like 
this directly.

```
strings::format("%06d", xxx)
```


- haosdent huang


On March 15, 2016, 6:54 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44836/
> ---
> 
> (Updated March 15, 2016, 6:54 a.m.)
> 
> 
> Review request for mesos and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Current WebUI sorts taskId lexically, which results in non-intuitive ordering.
> This patch updates long_lived_framework to use `01`, `02` instead.
> 
> Signed-off-by: Zhou Xing 
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> 289a0b9dd3d1ce30f20dd9bb381126bff30c 
> 
> Diff: https://reviews.apache.org/r/44836/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> In addition, `long_lived_framework` is ran and we confirm correct sorting of 
> `TaskID` in WebUI
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44836/#review123608
---




src/examples/long_lived_framework.cpp (line 98)
<https://reviews.apache.org/r/44836/#comment185844>

Need remove cast if we change taskId to string.



src/examples/long_lived_framework.cpp (line 99)
<https://reviews.apache.org/r/44836/#comment185846>

Ditto



src/examples/long_lived_framework.cpp (line 130)
<https://reviews.apache.org/r/44836/#comment185845>

Also need update here if the type of taskId is string.


- haosdent huang


On March 15, 2016, 6:54 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44836/
> ---
> 
> (Updated March 15, 2016, 6:54 a.m.)
> 
> 
> Review request for mesos and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Current WebUI sorts taskId lexically, which results in non-intuitive ordering.
> This patch updates long_lived_framework to use `01`, `02` instead.
> 
> Signed-off-by: Zhou Xing 
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> 289a0b9dd3d1ce30f20dd9bb381126bff30c 
> 
> Diff: https://reviews.apache.org/r/44836/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> In addition, `long_lived_framework` is ran and we confirm correct sorting of 
> `TaskID` in WebUI
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

[haosdent huang]

> On March 15, 2016, 7:04 a.m., haosdent huang wrote:
> >

I also notice the submitter `guojian...@cn.ibm.com` is different with signer 
`Zhou Xing `. I suggest don't do it like this.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44836/#review123608
---


On March 15, 2016, 6:54 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44836/
> ---
> 
> (Updated March 15, 2016, 6:54 a.m.)
> 
> 
> Review request for mesos and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Current WebUI sorts taskId lexically, which results in non-intuitive ordering.
> This patch updates long_lived_framework to use `01`, `02` instead.
> 
> Signed-off-by: Zhou Xing 
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> 289a0b9dd3d1ce30f20dd9bb381126bff30c 
> 
> Diff: https://reviews.apache.org/r/44836/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> In addition, `long_lived_framework` is ran and we confirm correct sorting of 
> `TaskID` in WebUI
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 44837: Added force_pull_image to Image protobuf.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44837/#review123611
---




include/mesos/v1/mesos.proto (line 1494)
<https://reviews.apache.org/r/44837/#comment185847>

Should be `on the agent`?


- haosdent huang


On March 15, 2016, 7:18 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44837/
> ---
> 
> (Updated March 15, 2016, 7:18 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added force_pull_image to Image protobuf.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto deb9c0910a27afd67276f54b3f666a878212727b 
>   include/mesos/v1/mesos.proto a981e750c24cfc48177bbc9ca56f0c3ecfae1a1b 
> 
> Diff: https://reviews.apache.org/r/44837/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44838/#review123612
---




src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp (line 93)
<https://reviews.apache.org/r/44838/#comment185848>

Should we have default value for `forcePullImage`, for example: 
`forcePullImage=false`.



src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp (line 167)
<https://reviews.apache.org/r/44838/#comment185850>

Maybe we need log `forcePullImage` option in this log item.



src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp (line 169)
<https://reviews.apache.org/r/44838/#comment185849>

I suggest change
```
!storedImages.contains(imageReference) || forcePullImage
```
to 
```
forcePullImage || !storedImages.contains(imageReference)
```
So that we don't need search `storedImages` if `forcePullImage` is true.


- haosdent huang


On March 15, 2016, 7:18 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44838/
> ---
> 
> (Updated March 15, 2016, 7:18 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4886
> https://issues.apache.org/jira/browse/MESOS-4886
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled mesos containerizer force_pull_image for docker.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 
> 137af502a66e6a65773c00eaacbe392576376284 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 
> cf630cc0b67a325529fa04ad2b1708e013b9596a 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> eeec94326a4fd67675df10e0b6a32267e555fa96 
> 
> Diff: https://reviews.apache.org/r/44838/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> It is difficult to test this with unit test, but just test with mesos execute 
> by setting `force_pull_image` as true and found that the iamge was always 
> pulled when `force_pull_image` is true.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44838/#review123614
---



And seems don't contains `appc` part in this patch?


src/slave/containerizer/mesos/provisioner/docker/store.cpp (line 188)
<https://reviews.apache.org/r/44838/#comment185852>

Because we don't set default value of `force_pull_image` in protobuf file. 
Seems here would be `false`. It is a excepted behaviour, right?


- haosdent huang


On March 15, 2016, 7:18 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44838/
> ---
> 
> (Updated March 15, 2016, 7:18 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4886
> https://issues.apache.org/jira/browse/MESOS-4886
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled mesos containerizer force_pull_image for docker.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 
> 137af502a66e6a65773c00eaacbe392576376284 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 
> cf630cc0b67a325529fa04ad2b1708e013b9596a 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> eeec94326a4fd67675df10e0b6a32267e555fa96 
> 
> Diff: https://reviews.apache.org/r/44838/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> It is difficult to test this with unit test, but just test with mesos execute 
> by setting `force_pull_image` as true and found that the iamge was always 
> pulled when `force_pull_image` is true.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

[haosdent huang]

> On March 15, 2016, 7:04 a.m., haosdent huang wrote:
> >
> 
> haosdent huang wrote:
> I also notice the submitter `guojian...@cn.ibm.com` is different with 
> signer `Zhou Xing `. I suggest don't do it like this.
> 
> Jay Guo wrote:
> We are following pair programming pattern and use git-duet. Will do clean 
> commit in the future. Also, IMHO, sorting task ID in WebUI by detecting 
> string type would be a more appropriate solution, instead of forcing 
> framework to use string IDs. Maybe we could bring this up at a later point.

Agree with you.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44836/#review123608
---


On March 15, 2016, 7:49 a.m., Jay Guo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44836/
> ---
> 
> (Updated March 15, 2016, 7:49 a.m.)
> 
> 
> Review request for mesos and haosdent huang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Current WebUI sorts taskId lexically, which results in non-intuitive ordering.
> This patch updates long_lived_framework to use `01`, `02` instead.
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> 289a0b9dd3d1ce30f20dd9bb381126bff30c 
> 
> Diff: https://reviews.apache.org/r/44836/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> In addition, `long_lived_framework` is ran and we confirm correct sorting of 
> `TaskID` in WebUI
> 
> 
> Thanks,
> 
> Jay Guo
> 
>

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

[haosdent huang]

> On March 15, 2016, 7:42 a.m., haosdent huang wrote:
> > src/slave/containerizer/mesos/provisioner/docker/store.cpp, line 188
> > <https://reviews.apache.org/r/44838/diff/1/?file=1299389#file1299389line188>
> >
> > Because we don't set default value of `force_pull_image` in protobuf 
> > file. Seems here would be `false`. It is a excepted behaviour, right?
> 
> Guangya Liu wrote:
> Yes, there is already a similar parameter here 
> https://reviews.apache.org/r/28190 for docker containerizer, I was using 
> similar logic to handle it in mesos containerizer.

Got it. Thank you for explanation.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44838/#review123614
---


On March 15, 2016, 7:55 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44838/
> ---
> 
> (Updated March 15, 2016, 7:55 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Jie Yu.
> 
> 
> Bugs: MESOS-4886
> https://issues.apache.org/jira/browse/MESOS-4886
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled mesos containerizer force_pull_image for docker.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 
> 137af502a66e6a65773c00eaacbe392576376284 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 
> cf630cc0b67a325529fa04ad2b1708e013b9596a 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> eeec94326a4fd67675df10e0b6a32267e555fa96 
> 
> Diff: https://reviews.apache.org/r/44838/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> It is difficult to test this with unit test, but just test with mesos execute 
> by setting `force_pull_image` as true and found that the iamge was always 
> pulled when `force_pull_image` is true.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44838/#review123622
---


Ship it!




Ship It!

- haosdent huang


On March 15, 2016, 7:55 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44838/
> ---
> 
> (Updated March 15, 2016, 7:55 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Jie Yu.
> 
> 
> Bugs: MESOS-4886
> https://issues.apache.org/jira/browse/MESOS-4886
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled mesos containerizer force_pull_image for docker.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 
> 137af502a66e6a65773c00eaacbe392576376284 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 
> cf630cc0b67a325529fa04ad2b1708e013b9596a 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> eeec94326a4fd67675df10e0b6a32267e555fa96 
> 
> Diff: https://reviews.apache.org/r/44838/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> It is difficult to test this with unit test, but just test with mesos execute 
> by setting `force_pull_image` as true and found that the iamge was always 
> pulled when `force_pull_image` is true.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44837: Added force_pull_image to Image protobuf.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44837/#review123623
---


Ship it!




Ship It!

- haosdent huang


On March 15, 2016, 7:31 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44837/
> ---
> 
> (Updated March 15, 2016, 7:31 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Jie Yu.
> 
> 
> Bugs: MESOS-4886
> https://issues.apache.org/jira/browse/MESOS-4886
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added force_pull_image to Image protobuf.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto deb9c0910a27afd67276f54b3f666a878212727b 
>   include/mesos/v1/mesos.proto a981e750c24cfc48177bbc9ca56f0c3ecfae1a1b 
> 
> Diff: https://reviews.apache.org/r/44837/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>