[GitHub] spark pull request: [SPARK-6911] [SQL] improve accessor for nested...

2015-04-14 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/5513#discussion_r28392046 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala --- @@ -515,14 +515,15 @@ class Column(protected[sql] val expr: Expression) extends Logg

[GitHub] spark pull request: [SPARK-3454] [WIP] separate json endpoints for...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4435#issuecomment-93180574 [Test build #30301 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30301/consoleFull) for PR 4435 at commit [`c22b11f`](https://githu

[GitHub] spark pull request: [SPARK-6692][YARN] Add an option for client to...

2015-04-14 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/5343#issuecomment-93180360 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-6692][YARN] Add an option for client to...

2015-04-14 Thread piaozhexiu
Github user piaozhexiu commented on the pull request: https://github.com/apache/spark/pull/5343#issuecomment-93179692 Can someone please trigger the jenkins build for this PR? It failed for a flaky test before and didn't rerun after that. Thanks! --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-3454] [WIP] separate json endpoints for...

2015-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4435#issuecomment-93179548 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-3454] [WIP] separate json endpoints for...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4435#issuecomment-93179544 [Test build #30294 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30294/consoleFull) for PR 4435 at commit [`9ea682c`](https://gith

[GitHub] spark pull request: Expose regionName setting in Kinesis receiver ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5375#discussion_r28391705 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -39,6 +39,7 @@ object KinesisUtils { * @para

[GitHub] spark pull request: [SQL] SPARK-6489: Optimize lateral view with e...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5358#issuecomment-93177971 [Test build #30300 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30300/consoleFull) for PR 5358 at commit [`9e7aaec`](https://githu

[GitHub] spark pull request: Expose regionName setting in Kinesis receiver ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5375#discussion_r28391631 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -70,6 +72,7 @@ object KinesisUtils { * @para

[GitHub] spark pull request: Expose regionName setting in Kinesis receiver ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5375#discussion_r28391619 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -39,6 +39,7 @@ object KinesisUtils { * @para

[GitHub] spark pull request: [Core][minor] remove unnecessary `parents` in ...

2015-04-14 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/5416#issuecomment-93177863 Yes, the parent of the second shuffle map stage will be the first shuffle map stage. Logically every `Stage` except the first one have parents, but the problem is we al

[GitHub] spark pull request: Expose regionName setting in Kinesis receiver ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5375#discussion_r28391597 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala --- @@ -36,18 +36,19 @@ import com.amazonaws.services.k

[GitHub] spark pull request: [SPARK-6638] [SQL] Improve performance of Stri...

2015-04-14 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/5350#discussion_r28391601 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala --- @@ -284,9 +321,9 @@ object CatalystTypeConverters {

[GitHub] spark pull request: [SPARK-4194] [core] Make SparkContext initiali...

2015-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5335#issuecomment-93177486 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-4194] [core] Make SparkContext initiali...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5335#issuecomment-93177469 [Test build #30293 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30293/consoleFull) for PR 5335 at commit [`746b661`](https://gith

[GitHub] spark pull request: [SPARK-6844][SQL] Clean up accumulators used i...

2015-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5475#issuecomment-93176378 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-6844][SQL] Clean up accumulators used i...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5475#issuecomment-93176357 [Test build #30291 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30291/consoleFull) for PR 5475 at commit [`0b41235`](https://gith

[GitHub] spark pull request: [SPARK-4897] [PySpark] Python 3 support

2015-04-14 Thread shaananc
Github user shaananc commented on the pull request: https://github.com/apache/spark/pull/5173#issuecomment-93175644 I'm getting the error: `File "/spark/python/pyspark/serializers.py", line 419, in loads return pickle.loads(obj) TypeError: ('code() takes at most 14

[GitHub] spark pull request: [SPARK-6638] [SQL] Improve performance of Stri...

2015-04-14 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/5350#discussion_r28391203 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala --- @@ -284,9 +321,9 @@ object CatalystTypeConverters {

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28391083 --- Diff: extras/kinesis-asl/src/main/java/org/apache/spark/examples/streaming/JavaKinesisWordCountASL.java --- @@ -131,7 +131,7 @@ public static void main(S

[GitHub] spark pull request: [SPARK-2213] [SQL] sort merge join for spark s...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5208#issuecomment-93173575 [Test build #30299 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30299/consoleFull) for PR 5208 at commit [`413fd24`](https://githu

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28391006 --- Diff: extras/kinesis-asl/src/main/java/org/apache/spark/examples/streaming/JavaKinesisWordCountASL.java --- @@ -131,7 +131,7 @@ public static void main(S

[GitHub] spark pull request: [SPARK-6638] [SQL] Improve performance of Stri...

2015-04-14 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/5350#discussion_r28391007 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala --- @@ -284,9 +321,9 @@ object CatalystTypeConverters {

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28390980 --- Diff: docs/streaming-kinesis-integration.md --- @@ -67,6 +67,8 @@ A Kinesis stream can be set up at one of the valid Kinesis endpoints with 1 or m

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28390951 --- Diff: docs/streaming-kinesis-integration.md --- @@ -44,7 +44,7 @@ A Kinesis stream can be set up at one of the valid Kinesis endpoints with 1 or m

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28390948 --- Diff: docs/streaming-kinesis-integration.md --- @@ -32,7 +32,7 @@ A Kinesis stream can be set up at one of the valid Kinesis endpoints with 1 or m

[GitHub] spark pull request: [SPARK-6898][SQL] completely support special c...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5511#issuecomment-93172292 [Test build #30298 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30298/consoleFull) for PR 5511 at commit [`d81ad43`](https://githu

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28390832 --- Diff: extras/kinesis-asl/src/test/java/org/apache/spark/streaming/kinesis/JavaKinesisStreamSuite.java --- @@ -34,7 +34,7 @@ public void testKinesisStream

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28390845 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCountASL.scala --- @@ -113,7 +113,7 @@ private object KinesisWordC

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28390844 --- Diff: extras/kinesis-asl/src/main/java/org/apache/spark/examples/streaming/JavaKinesisWordCountASL.java --- @@ -131,7 +131,7 @@ public static void main(S

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28390830 --- Diff: extras/kinesis-asl/src/test/scala/org/apache/spark/streaming/kinesis/KinesisReceiverSuite.scala --- @@ -86,7 +86,7 @@ class KinesisReceiverSuite ex

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28390749 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -59,9 +61,10 @@ object KinesisUtils { end

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28390679 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisUtils.scala --- @@ -16,6 +16,7 @@ */ package org.apache.spar

[GitHub] spark pull request: [SPARK-6638] [SQL] Improve performance of Stri...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5350#issuecomment-93170251 [Test build #30297 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30297/consoleFull) for PR 5350 at commit [`2772f0d`](https://githu

[GitHub] spark pull request: [SPARK-6807] [SparkR] Merge recent SparkR-pkg ...

2015-04-14 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/5436#issuecomment-93169393 @shivaram this PR is ready to review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28390431 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala --- @@ -82,15 +82,19 @@ private[kinesis] class KinesisRe

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28390315 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala --- @@ -82,15 +82,19 @@ private[kinesis] class KinesisRe

[GitHub] spark pull request: [SPARK-2213] [SQL] sort merge join for spark s...

2015-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5208#issuecomment-93164496 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-2213] [SQL] sort merge join for spark s...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5208#issuecomment-93164474 [Test build #30289 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30289/consoleFull) for PR 5208 at commit [`b198278`](https://gith

[GitHub] spark pull request: SPARK-5960 allow aws credentials to be passed ...

2015-04-14 Thread cfregly
Github user cfregly commented on a diff in the pull request: https://github.com/apache/spark/pull/5439#discussion_r28390150 --- Diff: extras/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala --- @@ -24,8 +24,7 @@ import org.apache.spark.storage.St

[GitHub] spark pull request: [SPARK-6800][SQL] Update doc for JDBCRelation'...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5488#issuecomment-93164229 [Test build #30296 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30296/consoleFull) for PR 5488 at commit [`3eb74d6`](https://githu

[GitHub] spark pull request: [SPARK-6368][SQL] Build a specialized serializ...

2015-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5497#issuecomment-93163340 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-6368][SQL] Build a specialized serializ...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5497#issuecomment-93163336 [Test build #30288 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30288/consoleFull) for PR 5497 at commit [`3e09655`](https://gith

[GitHub] spark pull request: [SPARK-6871][SQL] WITH clause in CTE can not f...

2015-04-14 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/5480#issuecomment-93158092 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] spark pull request: [SPARK-6046] [core] Reorganize deprecated conf...

2015-04-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/5514#discussion_r28389478 --- Diff: docs/monitoring.md --- @@ -86,11 +86,12 @@ follows: -spark.history.fs.update.interval.seconds -10 +s

[GitHub] spark pull request: [SPARK-6871][SQL] WITH clause in CTE can not f...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5480#issuecomment-93157382 [Test build #30295 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30295/consoleFull) for PR 5480 at commit [`4da3712`](https://githu

[GitHub] spark pull request: [SPARK-2213] [SQL] sort merge join for spark s...

2015-04-14 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/5208#issuecomment-93157431 https://github.com/adrian-wang/spark/pull/3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] spark pull request: [SPARK-6800][SQL] Fix wrong logic to generate ...

2015-04-14 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/5488#issuecomment-93157103 That is correct. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] spark pull request: [SPARK-6046] [core] Reorganize deprecated conf...

2015-04-14 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/5514#discussion_r28389311 --- Diff: docs/monitoring.md --- @@ -86,11 +86,12 @@ follows: -spark.history.fs.update.interval.seconds -10 +

[GitHub] spark pull request: [SPARK-3454] [WIP] separate json endpoints for...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4435#issuecomment-93156365 [Test build #30294 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30294/consoleFull) for PR 4435 at commit [`9ea682c`](https://githu

[GitHub] spark pull request: [SPARK-4897] [PySpark] Python 3 support

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5173#issuecomment-93156062 [Test build #676 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/676/consoleFull) for PR 5173 at commit [`4006829`](https://githu

[GitHub] spark pull request: [SPARK-6800][SQL] Fix wrong logic to generate ...

2015-04-14 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/5488#issuecomment-93156010 ok. If I understand it correctly, `lowerBound` and `upperBound` are just used to decide partition stride, not for filtering. So all table rows are partitioned. --- If yo

[GitHub] spark pull request: [YARN] SPARK-6470. Add support for YARN node l...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5242#issuecomment-93155567 [Test build #30284 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30284/consoleFull) for PR 5242 at commit [`4a1b837`](https://gith

[GitHub] spark pull request: [YARN] SPARK-6470. Add support for YARN node l...

2015-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5242#issuecomment-93155588 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-5337][Mesos][Standalone] respect spark....

2015-04-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/4129#issuecomment-93155407 @CodingCat good to see this being fixed. However, as it stands the existing solution does not seem to be sufficient. I pointed out a scenario where we will fall into a

[GitHub] spark pull request: [SPARK-5337][Mesos][Standalone] respect spark....

2015-04-14 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4129#discussion_r28389067 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -556,17 +556,18 @@ private[spark] class Master( // in the queue,

[GitHub] spark pull request: [SPARK-4194] [core] Make SparkContext initiali...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5335#issuecomment-93155011 [Test build #30293 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30293/consoleFull) for PR 5335 at commit [`746b661`](https://githu

[GitHub] spark pull request: SPARK-6919 Add asDict method to StatCounter

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5516#issuecomment-93154680 [Test build #30292 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30292/consoleFull) for PR 5516 at commit [`c933af7`](https://githu

[GitHub] spark pull request: [SPARK-5337][Mesos][Standalone] respect spark....

2015-04-14 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4129#discussion_r28388979 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -556,17 +556,18 @@ private[spark] class Master( // in the queue,

[GitHub] spark pull request: [SPARK-6905] Upgrade to snappy-java 1.1.1.7

2015-04-14 Thread ash211
Github user ash211 commented on the pull request: https://github.com/apache/spark/pull/5512#issuecomment-93154197 Really appreciate this work @JoshRosen ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] spark pull request: [SPARK-5337][Mesos][Standalone] respect spark....

2015-04-14 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4129#discussion_r28388951 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -556,17 +556,18 @@ private[spark] class Master( // in the queue,

[GitHub] spark pull request: [SPARK-5337][Mesos][Standalone] respect spark....

2015-04-14 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4129#discussion_r28388840 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala --- @@ -213,13 +225,13 @@ private[spark] class Co

[GitHub] spark pull request: SPARK-6919 Add asDict method to StatCounter

2015-04-14 Thread ash211
Github user ash211 commented on the pull request: https://github.com/apache/spark/pull/5516#issuecomment-93152146 Jenkins this is ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-6844][SQL] Clean up accumulators used i...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5475#issuecomment-93150230 [Test build #30291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30291/consoleFull) for PR 5475 at commit [`0b41235`](https://githu

[GitHub] spark pull request: [SPARK-6638] [SQL] Improve performance of Stri...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5350#issuecomment-93148720 [Test build #30286 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30286/consoleFull) for PR 5350 at commit [`59025c8`](https://gith

[GitHub] spark pull request: [SPARK-6638] [SQL] Improve performance of Stri...

2015-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5350#issuecomment-93148745 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-6844][SQL] Clean up accumulators used i...

2015-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5475#issuecomment-93147915 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-6844][SQL] Clean up accumulators used i...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5475#issuecomment-93147903 [Test build #30290 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30290/consoleFull) for PR 5475 at commit [`dc1d5d5`](https://gith

[GitHub] spark pull request: [SPARK-4897] [PySpark] Python 3 support

2015-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5173#issuecomment-93147750 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-4897] [PySpark] Python 3 support

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5173#issuecomment-93147729 [Test build #30287 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30287/consoleFull) for PR 5173 at commit [`4006829`](https://gith

[GitHub] spark pull request: [SPARK-6844][SQL] Clean up accumulators used i...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5475#issuecomment-93147563 [Test build #30290 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30290/consoleFull) for PR 5475 at commit [`dc1d5d5`](https://githu

[GitHub] spark pull request: [SPARK-5337][Mesos][Standalone] respect spark....

2015-04-14 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4129#discussion_r28388533 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -533,7 +533,7 @@ private[spark] class Master( val shuffledAliveWo

[GitHub] spark pull request: [SPARK-5337][Mesos][Standalone] respect spark....

2015-04-14 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4129#discussion_r28388523 --- Diff: core/src/main/scala/org/apache/spark/deploy/ApplicationDescription.scala --- @@ -30,6 +30,8 @@ private[spark] class ApplicationDescription(

[GitHub] spark pull request: [SPARK-5337][Mesos][Standalone] respect spark....

2015-04-14 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4129#discussion_r28388461 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/SparkDeploySchedulerBackend.scala --- @@ -41,8 +41,20 @@ private[spark] class SparkDeploy

[GitHub] spark pull request: [SPARK-6752][Streaming] Allow StreamingContext...

2015-04-14 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/5428#discussion_r28388452 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/Checkpoint.scala --- @@ -77,7 +77,8 @@ object Checkpoint extends Logging { } /*

[GitHub] spark pull request: [SPARK-5337][Mesos][Standalone] respect spark....

2015-04-14 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/4129#discussion_r28388427 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/SparkDeploySchedulerBackend.scala --- @@ -41,8 +41,20 @@ private[spark] class SparkDeploy

[GitHub] spark pull request: [SPARK-6844][SQL] Clean up accumulators used i...

2015-04-14 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/5475#issuecomment-93146300 ok. updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] spark pull request: [SPARK-5634] [core] Show correct message in HS...

2015-04-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5515 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-5634] [core] Show correct message in HS...

2015-04-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/5515#issuecomment-93144575 LGTM merging into master thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark pull request: [SPARK-6890] [core] Fix launcher lib work with...

2015-04-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5504 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-6890] [core] Fix launcher lib work with...

2015-04-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/5504#issuecomment-93144025 Alright, I tested the latest changes locally again and can verify that this patch does fix the problem. Now that it's also passing tests I will merge this into master.

[GitHub] spark pull request: [SPARK-2213] [SQL] sort merge join for spark s...

2015-04-14 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/5208#issuecomment-93136064 Thanks! just in case your PR will conflict, please note that I just update my PR. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] spark pull request: [SPARK-2213] [SQL] sort merge join for spark s...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5208#issuecomment-93134866 [Test build #30289 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30289/consoleFull) for PR 5208 at commit [`b198278`](https://githu

[GitHub] spark pull request: [SPARK-6350][Mesos] Make mesosExecutorCores co...

2015-04-14 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/5063#issuecomment-93132743 I talked to @sryza and @tnachen offline about the potential sources of confusion here. It seems that this code used to mistakenly use `spark.task.cpus` as the number o

[GitHub] spark pull request: [SPARK-6350][Mesos] Make mesosExecutorCores co...

2015-04-14 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/5063#discussion_r28386662 --- Diff: docs/running-on-mesos.md --- @@ -211,6 +211,16 @@ See the [configuration page](configuration.html) for information on Spark config

[GitHub] spark pull request: [SPARK-4897] [PySpark] Python 3 support

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5173#issuecomment-93131436 [Test build #675 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/675/consoleFull) for PR 5173 at commit [`2fc0066`](https://githu

[GitHub] spark pull request: [SPARK-5634] [core] Show correct message in HS...

2015-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5515#issuecomment-93131090 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-2213] [SQL] sort merge join for spark s...

2015-04-14 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/5208#issuecomment-93130870 BTW, as I discussed with @chenghao-intel today, I think this is very close to merging. There are a few things I'd like to clean up, but I propose I just make a PR again

[GitHub] spark pull request: [SPARK-5634] [core] Show correct message in HS...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5515#issuecomment-93131060 [Test build #30283 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30283/consoleFull) for PR 5515 at commit [`f74ecf1`](https://gith

[GitHub] spark pull request: [SPARK-2213] [SQL] sort merge join for spark s...

2015-04-14 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/5208#discussion_r28386536 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala --- @@ -41,6 +41,15 @@ case class Project(projectList: Seq[NamedExpr

[GitHub] spark pull request: SPARK-6919 Add asDict method to StatCounter

2015-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5516#issuecomment-93128523 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: SPARK-6919 Add asDict method to StatCounter

2015-04-14 Thread eshilts
GitHub user eshilts opened a pull request: https://github.com/apache/spark/pull/5516 SPARK-6919 Add asDict method to StatCounter Add method to easily convert a StatCounter instance into a Python dict https://issues.apache.org/jira/browse/SPARK-6919 Note: This is my

[GitHub] spark pull request: [SPARK-6196][build]Add MAPR 4.0.2 support to t...

2015-04-14 Thread trystanleftwich
Github user trystanleftwich closed the pull request at: https://github.com/apache/spark/pull/4928 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] spark pull request: [SPARK-6350][Mesos] Make mesosExecutorCores co...

2015-04-14 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/5063#discussion_r28386441 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackend.scala --- @@ -233,9 +234,7 @@ private[spark] class MesosSched

[GitHub] spark pull request: [SPARK-6350][Mesos] Make mesosExecutorCores co...

2015-04-14 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/5063#discussion_r28386348 --- Diff: docs/running-on-mesos.md --- @@ -211,6 +211,16 @@ See the [configuration page](configuration.html) for information on Spark config

[GitHub] spark pull request: [SPARK-6368][SQL] Build a specialized serializ...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5497#issuecomment-93127680 [Test build #30288 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30288/consoleFull) for PR 5497 at commit [`3e09655`](https://githu

[GitHub] spark pull request: [SPARK-6350][Mesos] Make mesosExecutorCores co...

2015-04-14 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/5063#discussion_r28385856 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackend.scala --- @@ -67,6 +67,8 @@ private[spark] class MesosSchedul

[GitHub] spark pull request: [SPARK-6046] [core] Reorganize deprecated conf...

2015-04-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5514#issuecomment-93125698 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30

[GitHub] spark pull request: [SPARK-6046] [core] Reorganize deprecated conf...

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5514#issuecomment-93125691 [Test build #30282 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30282/consoleFull) for PR 5514 at commit [`ab20351`](https://gith

[GitHub] spark pull request: [SPARK-4897] [PySpark] Python 3 support

2015-04-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5173#issuecomment-93125649 [Test build #676 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/676/consoleFull) for PR 5173 at commit [`4006829`](https://github

<    1   2   3   4   5   6   7   >