[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-08-18 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r472587295 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -454,6 +490,40 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-08-18 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r472587295 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -454,6 +490,40 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-08-18 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r472585859 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -903,15 +910,61 @@ private[joins] object

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-29 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r461220193 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -903,15 +910,55 @@ private[joins] object

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460805760 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1147,4 +1147,40 @@ class JoinSuite extends QueryTest with

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460795351 ## File path: sql/core/src/test/scala/org/apache/spark/sql/NullAwareAntiJoinSQLQueryTestSuite.scala ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r46016 ## File path: sql/core/src/test/scala/org/apache/spark/sql/NullAwareAntiJoinSQLQueryTestSuite.scala ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460776654 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/debug/DebuggingSuite.scala ## @@ -70,15 +70,15 @@ class DebuggingSuite extends

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460776317 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/debug/DebuggingSuite.scala ## @@ -70,15 +70,15 @@ class DebuggingSuite extends

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460774691 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1147,4 +1147,40 @@ class JoinSuite extends QueryTest with

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460774691 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1147,4 +1147,40 @@ class JoinSuite extends QueryTest with

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460773428 ## File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala ## @@ -1147,4 +1147,40 @@ class JoinSuite extends QueryTest with

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460772792 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -903,15 +926,65 @@ private[joins] object

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460772228 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -311,6 +314,15 @@ private[joins] object

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460762568 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -896,22 +967,29 @@ private[joins] object

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-27 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460676977 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -896,22 +967,29 @@ private[joins] object

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-24 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460275829 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -81,6 +81,34 @@ private[execution] sealed trait

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-24 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460276191 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -896,22 +969,32 @@ private[joins] object

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-24 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460276050 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -323,11 +374,20 @@ private[joins] object

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-24 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460275713 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -133,10 +142,38 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-24 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460273465 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -896,22 +969,32 @@ private[joins] object

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-24 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460273465 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -896,22 +969,32 @@ private[joins] object

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-24 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460272135 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -896,22 +969,32 @@ private[joins] object

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-24 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460272135 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -896,22 +969,32 @@ private[joins] object

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-24 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460269289 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -923,9 +1006,9 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-24 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460267914 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -323,11 +374,20 @@ private[joins] object

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-24 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r460149058 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -454,6 +491,48 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459822735 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -454,6 +491,48 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459822735 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -454,6 +491,48 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459820829 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -454,6 +491,48 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459820163 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -454,6 +491,48 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459819627 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -454,6 +491,48 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459817412 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -454,6 +491,48 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459816849 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -323,11 +374,18 @@ private[joins] object

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459815333 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -454,6 +491,48 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459815126 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -454,6 +491,48 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459813412 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -323,11 +374,18 @@ private[joins] object

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459813091 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -323,11 +374,18 @@ private[joins] object

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459812742 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -454,6 +491,48 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459796329 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -133,10 +145,39 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459796241 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java ## @@ -591,6 +591,15 @@ public boolean anyNull() {

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459796290 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -133,10 +145,39 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459796065 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala ## @@ -186,6 +186,13 @@ trait HashJoin extends BaseJoinExec {

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459795913 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -453,6 +494,47 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459795966 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -453,6 +494,47 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459796125 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -81,6 +81,32 @@ private[execution] sealed trait

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459795867 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -453,6 +494,47 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459795806 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -81,6 +81,32 @@ private[execution] sealed trait

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459789858 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -453,6 +494,47 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459789169 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -453,6 +494,47 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459788703 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -453,6 +494,47 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459778507 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java ## @@ -591,6 +591,15 @@ public boolean anyNull() {

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459778507 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java ## @@ -591,6 +591,15 @@ public boolean anyNull() {

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459349052 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -454,6 +478,28 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-23 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459348848 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -133,10 +135,32 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-22 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459050176 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -454,6 +478,28 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-22 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459038966 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -454,6 +478,28 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-22 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459026478 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -454,6 +478,28 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-22 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459015968 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -454,6 +478,28 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-22 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459012565 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -133,10 +135,32 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-22 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459010866 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -454,6 +478,28 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-22 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459008565 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -454,6 +478,28 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-22 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r459008874 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -454,6 +478,28 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-22 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r458583091 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNullAwareHashJoinExec.scala ## @@ -0,0 +1,205 @@ +/* + * Licensed to

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-22 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r458582831 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -171,6 +171,23 @@ private volatile MapIterator

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-21 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r458489513 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNullAwareHashJoinExec.scala ## @@ -0,0 +1,205 @@ +/* + * Licensed to

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-21 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r458489403 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -300,8 +318,12 @@ private[joins] class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-21 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r458489011 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -71,6 +71,18 @@ private[execution] sealed trait

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-21 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r458491095 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNullAwareHashJoinExec.scala ## @@ -0,0 +1,205 @@ +/* + * Licensed to

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-21 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r458490245 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNullAwareHashJoinExec.scala ## @@ -0,0 +1,205 @@ +/* + * Licensed to

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-21 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r458485921 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala ## @@ -388,3 +390,35 @@ object PhysicalWindow {

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-21 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r458154628 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala ## @@ -388,3 +390,36 @@ object PhysicalWindow {

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-21 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r458154338 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala ## @@ -388,3 +390,36 @@ object PhysicalWindow {

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-21 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r458152176 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala ## @@ -388,3 +390,36 @@ object PhysicalWindow {

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-21 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r458150987 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -471,6 +518,8 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-21 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457907864 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -71,6 +71,16 @@ private[execution] sealed trait

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-21 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457908392 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -498,6 +547,8 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-21 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457870914 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -171,6 +171,23 @@ private volatile MapIterator

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-21 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457873194 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -171,6 +171,23 @@ private volatile MapIterator

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-21 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457870914 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -171,6 +171,23 @@ private volatile MapIterator

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-21 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457871466 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala ## @@ -71,6 +71,16 @@ private[execution] sealed trait

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-21 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457870914 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -171,6 +171,23 @@ private volatile MapIterator

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-21 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457870914 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -171,6 +171,23 @@ private volatile MapIterator

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-21 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457869773 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala ## @@ -388,3 +390,36 @@ object PhysicalWindow {

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457813266 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -64,10 +65,32 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457791849 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -385,55 +408,101 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457786737 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2671,6 +2671,25 @@ object SQLConf { .checkValue(_ >

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457786215 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -44,7 +45,7 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457784068 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2671,6 +2671,25 @@ object SQLConf { .checkValue(_ >

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457473120 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -64,10 +65,32 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457464340 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -64,10 +65,32 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457455756 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -64,10 +65,32 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457450423 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -385,55 +408,101 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457448051 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -64,10 +65,32 @@ case class

[GitHub] [spark] leanken commented on a change in pull request #29104: [SPARK-32290][SQL] SingleColumn Null Aware Anti Join Optimize

2020-07-20 Thread GitBox
leanken commented on a change in pull request #29104: URL: https://github.com/apache/spark/pull/29104#discussion_r457445110 ## File path: core/src/main/java/org/apache/spark/unsafe/map/BytesToBytesMap.java ## @@ -171,6 +171,29 @@ private volatile MapIterator