Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22146
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r229367166
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Constants.scala
---
@@ -74,8 +74,16 @@ private[spark] object
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r229367415
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala
---
@@ -16,11 +16,17 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r229024855
--- Diff: docs/running-on-kubernetes.md ---
@@ -799,4 +815,168 @@ specific to Spark on Kubernetes.
This sets the major Python version of the docker
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r229013867
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Constants.scala
---
@@ -74,8 +74,16 @@ private[spark] object
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r229013753
--- Diff: docs/running-on-kubernetes.md ---
@@ -185,6 +185,22 @@ To use a secret through an environment variable use
the following options to the
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r229013267
--- Diff: docs/running-on-kubernetes.md ---
@@ -799,4 +815,168 @@ specific to Spark on Kubernetes.
This sets the major Python version of the docker
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r226643416
--- Diff: docs/running-on-kubernetes.md ---
@@ -799,4 +815,168 @@ specific to Spark on Kubernetes.
This sets the major Python version of the docker
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r226642833
--- Diff: docs/running-on-kubernetes.md ---
@@ -799,4 +815,168 @@ specific to Spark on Kubernetes.
This sets the major Python version of the docker
Github user aditanase commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r223673773
--- Diff: docs/running-on-kubernetes.md ---
@@ -799,4 +815,168 @@ specific to Spark on Kubernetes.
This sets the major Python version of the
Github user rvesse commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r223620758
--- Diff: docs/running-on-kubernetes.md ---
@@ -799,4 +815,168 @@ specific to Spark on Kubernetes.
This sets the major Python version of the docker
Github user aditanase commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r223596796
--- Diff: docs/running-on-kubernetes.md ---
@@ -799,4 +815,168 @@ specific to Spark on Kubernetes.
This sets the major Python version of the
Github user aditanase commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r223493848
--- Diff: docs/running-on-kubernetes.md ---
@@ -185,6 +185,22 @@ To use a secret through an environment variable use
the following options to the
Github user aditanase commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r223491915
--- Diff: docs/running-on-kubernetes.md ---
@@ -799,4 +815,168 @@ specific to Spark on Kubernetes.
This sets the major Python version of the
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r215452489
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala
---
@@ -81,9 +95,12 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r215451113
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
---
@@ -59,5 +66,28 @@ private[spark] object
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r215450800
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Constants.scala
---
@@ -74,8 +74,16 @@ private[spark] object
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r215450600
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
---
@@ -59,5 +66,28 @@ private[spark] object
Github user onursatici commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r214339066
--- Diff: docs/running-on-kubernetes.md ---
@@ -185,6 +185,21 @@ To use a secret through an environment variable use
the following options to the
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r214205873
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
---
@@ -59,5 +66,28 @@ private[spark] object
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r214177723
--- Diff: docs/running-on-kubernetes.md ---
@@ -185,6 +185,21 @@ To use a secret through an environment variable use
the following options to the
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r214118624
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/PodTemplateConfigMapStepSuite.scala
---
@@ -0,0 +1,96 @@
Github user onursatici commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r213846434
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/PodTemplateConfigMapStepSuite.scala
---
@@ -0,0 +1,96
Github user onursatici commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r213817812
--- Diff: docs/running-on-kubernetes.md ---
@@ -185,6 +185,21 @@ To use a secret through an environment variable use
the following options to the
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r213612518
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/PodTemplateConfigMapStepSuite.scala
---
@@ -0,0 +1,96 @@
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r213612172
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PodTemplateSuite.scala
---
@@ -0,0
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r213604900
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Constants.scala
---
@@ -74,8 +74,16 @@ private[spark] object
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r213602355
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Constants.scala
---
@@ -74,8 +74,16 @@ private[spark] object
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r213600630
--- Diff: docs/running-on-kubernetes.md ---
@@ -775,4 +787,183 @@ specific to Spark on Kubernetes.
This sets the major Python version of the docker
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r213064784
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala
---
@@ -81,9 +95,12 @@
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r213064103
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesDriverSpec.scala
---
@@ -24,8 +24,9 @@ private[spark]
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r213061625
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PodTemplateSuite.scala
---
@@ -0,0
Github user ifilonenko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r213060443
--- Diff:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PodTemplateSuite.scala
---
@@ -0,0
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r213047538
--- Diff: docs/running-on-kubernetes.md ---
@@ -185,6 +185,21 @@ To use a secret through an environment variable use
the following options to the
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212761597
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -225,6 +225,18 @@ private[spark] object
Github user yifeih commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212760156
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -225,6 +225,18 @@ private[spark] object Config
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212724020
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -225,6 +225,18 @@ private[spark] object
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212722242
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -225,6 +225,18 @@ private[spark] object Config
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212721068
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -225,6 +225,18 @@ private[spark] object
Github user erikerlandson commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212668742
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -225,6 +225,18 @@ private[spark] object
Github user yifeih commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212631214
--- Diff: docs/running-on-kubernetes.md ---
@@ -775,4 +787,183 @@ specific to Spark on Kubernetes.
This sets the major Python version of the docker
Github user yifeih commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212631423
--- Diff: docs/running-on-kubernetes.md ---
@@ -775,4 +787,183 @@ specific to Spark on Kubernetes.
This sets the major Python version of the docker
Github user yifeih commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212636275
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -225,6 +225,18 @@ private[spark] object Config
Github user yifeih commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212633621
--- Diff: docs/running-on-kubernetes.md ---
@@ -775,4 +787,183 @@ specific to Spark on Kubernetes.
This sets the major Python version of the docker
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212470424
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -225,6 +225,18 @@ private[spark] object
Github user erikerlandson commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212469389
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -225,6 +225,18 @@ private[spark] object
Github user erikerlandson commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212460665
--- Diff: docs/running-on-kubernetes.md ---
@@ -775,4 +787,183 @@ specific to Spark on Kubernetes.
This sets the major Python version of the
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212448189
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -225,6 +225,18 @@ private[spark] object Config
Github user erikerlandson commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212438850
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -225,6 +225,18 @@ private[spark] object
Github user erikerlandson commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212423082
--- Diff: docs/running-on-kubernetes.md ---
@@ -775,4 +787,183 @@ specific to Spark on Kubernetes.
This sets the major Python version of the
Github user erikerlandson commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212424515
--- Diff: docs/running-on-kubernetes.md ---
@@ -775,4 +787,183 @@ specific to Spark on Kubernetes.
This sets the major Python version of the
Github user erikerlandson commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212423941
--- Diff: docs/running-on-kubernetes.md ---
@@ -775,4 +787,183 @@ specific to Spark on Kubernetes.
This sets the major Python version of the
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212396608
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/PodTemplateConfigMapStep.scala
---
@@ -0,0 +1,71 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212396719
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/PodTemplateConfigMapStep.scala
---
@@ -0,0 +1,71 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212400281
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -81,13 +88,17 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212396387
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
---
@@ -59,5 +65,21 @@ private[spark] object
Github user erikerlandson commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212399808
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -225,6 +225,18 @@ private[spark] object
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212395959
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -225,6 +225,18 @@ private[spark] object Config
Github user erikerlandson commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212364915
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -225,6 +225,18 @@ private[spark] object
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212126595
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala
---
@@ -51,7 +57,13 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212072262
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala
---
@@ -81,9 +97,9 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212070807
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala
---
@@ -81,9 +97,9 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212069991
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala
---
@@ -96,3 +112,25 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212068833
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Constants.scala
---
@@ -74,8 +74,15 @@ private[spark] object
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212069720
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala
---
@@ -16,11 +16,17 @@
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212068140
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/TemplateVolumeStep.scala
---
@@ -0,0 +1,51 @@
+/*
Github user yifeih commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212017571
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala
---
@@ -51,7 +57,13 @@
Github user yifeih commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r211999160
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala
---
@@ -51,7 +57,13 @@
Github user yifeih commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r211998423
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala
---
@@ -96,3 +112,25 @@
69 matches
Mail list logo
