Re: Review Request 44933: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-18 Thread Juanjo Marron
ou > > can create a json file at HDP/2.0.6/properties/stack_features.json and > > reference it in the config property xml file. I will be committing those > > changes soon. I saw the example of stack_tools.json in https://reviews.apache.org/r/44835/. It would work even if the sta

Re: Review Request 44933: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-18 Thread Juanjo Marron
it: https://reviews.apache.org/r/44933/#review124298 --- On March 16, 2016, 9:24 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, vis

Review Request 44933: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-19 Thread Juanjo Marron
rg/r/44933/diff/ Testing --- Zookeeper fresh installation has been tested using HDP stack 2.3 and AMBARI-13364 branch code. Thanks, Juanjo Marron

Re: Review Request 44933: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-21 Thread Juanjo Marron
e Attachments (updated) AMBARI-14435.patch https://reviews.apache.org/media/uploaded/files/2016/03/22/ca5af0ea-dcdc-4ded-9e36-eda14e7b6ecf__AMBARI-14435.patch Thanks, Juanjo Marron

Re: Review Request 44933: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-21 Thread Juanjo Marron
EATION Diff: https://reviews.apache.org/r/44933/diff/ Testing --- Zookeeper fresh installation has been tested using HDP stack 2.3 and AMBARI-13364 branch code. Thanks, Juanjo Marron

Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-21 Thread Juanjo Marron
ver/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 5f77f48 ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json PRE-CREATION Diff: https://reviews.apache.org/r/45141/diff/ Testing --- Zookeeper fresh installation on top of latest trunk Thanks, Juanjo Marron

Re: Review Request 44933: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-21 Thread Juanjo Marron
e, express_upgrade and config_versioning - Juanjo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44933/#review124634 -------

Re: Review Request 44933: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-21 Thread Juanjo Marron
01834line25> > > > > FYI, in https://reviews.apache.org/r/44835/ I added a feature to > > support external properties file for complete structures like these. So you > > can create a json file at HDP/2.0.6/properties/stack_features.json and > > reference

Re: Review Request 44933: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-21 Thread Juanjo Marron
e-mail. To reply, visit: https://reviews.apache.org/r/44933/#review124636 ----------- On March 22, 2016, 1:03 a.m., Juanjo Marron wrote: > > --- > This is an aut

Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-21 Thread Juanjo Marron
eper_service.py 6fe0772 ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 5f77f48 ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json PRE-CREATION Diff: https://reviews.apache.org/r/45141/diff/ Testing --- Zookeeper fresh installation on top of latest trunk Thanks, Juanjo Marron

Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-21 Thread Juanjo Marron
es - Juanjo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45141/#review124702 --- On March 22, 2016, 1:50 a.m., Juanjo Marron wrote: > > -

Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-22 Thread Juanjo Marron
: https://reviews.apache.org/r/45141/diff/ Testing --- Zookeeper fresh installation on top of latest trunk Thanks, Juanjo Marron

Re: Review Request 45141: Apply the stack featurization prototype detailed on AMBARI-13364 to ZOOKEEPER service.

2016-03-22 Thread Juanjo Marron
ssue > > during zookeeper_server::security_status checks as only status_params is > > imported in security_status() > > > > def security_status(self, env): > > import status_params > > env.set_params(status_params) > > if s

Review Request 45254: Apply the stack featurization prototype detailed on AMBARI-13364 to TEZ service

2016-03-23 Thread Juanjo Marron
/scripts/tez_client.py e770d9b Diff: https://reviews.apache.org/r/45254/diff/ Testing --- TEZ fresh installation Thanks, Juanjo Marron

Re: Review Request 45254: Apply the stack featurization prototype detailed on AMBARI-13364 to TEZ service

2016-03-24 Thread Juanjo Marron
/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/service_check.py c0c66af ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py e770d9b Diff: https://reviews.apache.org/r/45254/diff/ Testing --- TEZ fresh installation Thanks, Juanjo

Re: Review Request 45254: Apply the stack featurization prototype detailed on AMBARI-13364 to TEZ service

2016-03-24 Thread Juanjo Marron
l. To reply, visit: https://reviews.apache.org/r/45254/#review125316 --- On March 24, 2016, 6:22 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mai

Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-24 Thread Juanjo Marron
1 argument (0 given) -- Total run:928 Total errors:1 Total failures:0 Thanks, Juanjo Marron

Review Request 45338: AMBARI-15053: Stack Featurize YARN & MR services

2016-03-25 Thread Juanjo Marron
INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 6:20.634s [INFO] Finished at: Thu Mar 25 11:22:15 PDT 2016 [INFO] Final Memory: 112M/531M Thanks, Juanjo Marron

Re: Review Request 45338: AMBARI-15053: Stack Featurize YARN and MR services

2016-03-28 Thread Juanjo Marron
] Finished at: Thu Mar 25 11:22:15 PDT 2016 [INFO] Final Memory: 112M/531M Thanks, Juanjo Marron

Re: Review Request 45338: AMBARI-15053: Stack Featurize YARN and MR services

2016-03-28 Thread Juanjo Marron
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45338/#review125695 --- On March 28, 2016, 4:09 p.m., Juanjo Marron wrote: > > --

Review Request 45407: AMBARI-15114: Stack Featurize HBASE Service

2016-03-28 Thread Juanjo Marron
] [INFO] Total time: 4:57.086s [INFO] Finished at: Mon Mar 28 16:29:18 PDT 2016 [INFO] Final Memory: 111M/759M [INFO] -- Thanks, Juanjo Marron

Re: Review Request 45338: AMBARI-15053: Stack Featurize YARN and MR services

2016-03-29 Thread Juanjo Marron
; > > > > Can we remove the import *? > > Juanjo Marron wrote: > Most of the service scripts still include the from resource_management > import * line. > I found 123 matches searching in common-services. > It would be great to clean up the extra/non

Re: Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-29 Thread Juanjo Marron
on() takes exactly 1 argument (0 given) -- Total run:928 Total errors:1 Total failures:0 Thanks, Juanjo Marron

Re: Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-29 Thread Juanjo Marron
ated e-mail. To reply, visit: https://reviews.apache.org/r/45328/#review125898 ----------- On March 29, 2016, 8:06 p.m., Juanjo Marron wrote: > > --- > This is a

Re: Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-29 Thread Juanjo Marron
last trunk version - Juanjo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45328/#review125895 --- On March 29, 2016, 8:

Re: Review Request 45338: AMBARI-15053: Stack Featurize YARN and MR services

2016-03-29 Thread Juanjo Marron
] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 6:20.634s [INFO] Finished at: Thu Mar 25 11:22:15 PDT 2016 [INFO] Final Memory: 112M/531M Thanks, Juanjo Marron

Review Request 45460: AMBARI-15582: Stack Featurize Sqoop Service

2016-03-29 Thread Juanjo Marron
] [INFO] Total time: 7:18.415s [INFO] Finished at: Tue Mar 29 16:21:24 PDT 2016 [INFO] Final Memory: 111M/707M [INFO] Thanks, Juanjo Marron

Re: Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-30 Thread Juanjo Marron
MBARI-14451: Stack Featurize HDFS service (Juanjo Marron via jluniya) Thanks Jayush! - Juanjo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45328/#review126003 ---

Re: Review Request 45338: AMBARI-15053: Stack Featurize YARN and MR services

2016-03-30 Thread Juanjo Marron
gt; > The point of this function was to have a dictionary with the key being > > each possible stack name. If we always return "hadoop-client", might as > > well just return it as a string no matter what. > > Juanjo Marron wrote: > The didct value is

Re: Review Request 45470: AMBARI-15578: Stack Featurize Atlas Service

2016-03-30 Thread Juanjo Marron
pport", "min_version": "2.3.0.0" } I think rolling upgrade and config versioning could be added as features later on when supported - Juanjo Marron On March 30, 2016, 5:15 a.m., Jayush Luniya wrote: > > ---

Re: Review Request 45470: AMBARI-15578: Stack Featurize Atlas Service

2016-03-30 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45470/#review126192 --- Ship it! Ship It! - Juanjo Marron On March 30, 2016, 5:15

Review Request 45522: AMBARI-14472: Stack Featurize OozieService

2016-03-30 Thread Juanjo Marron
[INFO] [root@localhost ambari]# Thanks, Juanjo Marron

Re: Review Request 45522: AMBARI-14472: Stack Featurize OozieService

2016-04-01 Thread Juanjo Marron
eviews.apache.org/r/45522/#review126277 --- On March 31, 2016, 2:50 a.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 45522: AMBARI-14472: Stack Featurize Oozie Service

2016-04-01 Thread Juanjo Marron
] [root@localhost ambari]# Thanks, Juanjo Marron

Re: Review Request 45522: AMBARI-14472: Stack Featurize OozieService

2016-04-01 Thread Juanjo Marron
45522/#review126274 ------- On March 31, 2016, 2:50 a.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.o

Re: Review Request 45522: AMBARI-14472: Stack Featurize Oozie Service

2016-04-04 Thread Juanjo Marron
> > > Let me check if this restriction for 2.2.1.0 is Oozie specific. > > Juanjo Marron wrote: > Maintained for now in the new patch. Please, let me know if it needs to > be edited > > Jayush Luniya wrote: > @Juanjo. I didnt get a chance to look into this.

Re: Review Request 45522: AMBARI-14472: Stack Featurize Oozie Service

2016-04-04 Thread Juanjo Marron
> > > Let me check if this restriction for 2.2.1.0 is Oozie specific. > > Juanjo Marron wrote: > Maintained for now in the new patch. Please, let me know if it needs to > be edited > > Jayush Luniya wrote: > @Juanjo. I didnt get a chance to look into this.

Review Request 45778: AMBARI-15577: Stack Featurize HIVE service

2016-04-05 Thread Juanjo Marron
r 1.2.1.2.3.0.0-2434' != 'hive --config /etc/hive/conf.server --service hiveserver2 --deregister 1.2.1.2.3.0.0-2434' -- Total run:933 Total errors:0 Total failures:1 Thanks, Juanjo Marron

Re: Review Request 45778: AMBARI-15577: Stack Featurize HIVE service

2016-04-06 Thread Juanjo Marron
ly, visit: https://reviews.apache.org/r/45778/#review127295 ------- On April 5, 2016, 9:46 p.m., Juanjo Marron wrote: > > --- > This is an automatically gen

Re: Review Request 45778: AMBARI-15577: Stack Featurize HIVE service

2016-04-06 Thread Juanjo Marron
] Finished at: Wed Apr 06 01:38:42 PDT 2016 [INFO] Final Memory: 112M/721M Thanks, Juanjo Marron

Re: Review Request 45778: AMBARI-15577: Stack Featurize HIVE service

2016-04-07 Thread Juanjo Marron
] [INFO] Total time: 5:29.110s [INFO] Finished at: Thu Apr 07 10:42:41 PDT 2016 [INFO] Final Memory: 114M/778M Thanks, Juanjo Marron

Review Request 46445: Refactor get_stack_to_component() method

2016-04-20 Thread Juanjo Marron
[INFO] Final Memory: 124M/560M Additionally Build #6552 was successful: https://builds.apache.org/job/Ambari-trunk-test-patch/6552/ Thanks, Juanjo Marron

Re: Review Request 46445: Refactor get_stack_to_component() method

2016-04-22 Thread Juanjo Marron
MBARI-16014 which has been committed yesterday - Juanjo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46445/#review130152 ----------

Re: Review Request 46445: Refactor get_stack_to_component() method

2016-04-22 Thread Juanjo Marron
time: 6:03.806s [INFO] Finished at: Fri Apr 22 15:48:12 PDT 2016 [INFO] Final Memory: 124M/686M Additionally Build #6552 was successful: https://builds.apache.org/job/Ambari-trunk-test-patch/6552/ Thanks, Juanjo Marron

Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-04-29 Thread Juanjo Marron
/common-services/GANGLIA/3.5.0/package/scripts/params.py 30f8ee4 ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/status_params.py 0c69ca9 Diff: https://reviews.apache.org/r/46853/diff/ Testing --- Sucessfull tests by Hadoop QA Thanks, Juanjo Marron

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-04-29 Thread Juanjo Marron
--- Sucessfull tests by Hadoop QA Thanks, Juanjo Marron

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-04-29 Thread Juanjo Marron
versions - Juanjo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46853/#review131209 --- On April 30, 2016, 12:51 a.m.,

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-05-02 Thread Juanjo Marron
> On April 29, 2016, 10:34 p.m., Jayush Luniya wrote: > > I think we need more testing on this apart from unit tests to ensure all > > imports are there. > > Juanjo Marron wrote: > Hi Jayush, > > Thanks for the review. > I'll add this

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-05-03 Thread Juanjo Marron
his is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46853/#review131430 --- On April 30, 2016, 12:51 a.m., Juanjo Marron wrote: > > --- > This i

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-05-03 Thread Juanjo Marron
tests by Hadoop QA Thanks, Juanjo Marron

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-05-03 Thread Juanjo Marron
) --- Sucessfull tests by Hadoop QA Manual fresh installation and service checks Thanks, Juanjo Marron

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-05-09 Thread Juanjo Marron
> On April 29, 2016, 10:34 p.m., Jayush Luniya wrote: > > I think we need more testing on this apart from unit tests to ensure all > > imports are there. > > Juanjo Marron wrote: > Hi Jayush, > > Thanks for the review. > I'll add this

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-05-11 Thread Juanjo Marron
> On April 29, 2016, 10:34 p.m., Jayush Luniya wrote: > > I think we need more testing on this apart from unit tests to ensure all > > imports are there. > > Juanjo Marron wrote: > Hi Jayush, > > Thanks for the review. > I'll add this

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-05-16 Thread Juanjo Marron
e.org/r/46853/#review133259 --- On May 3, 2016, 6:12 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Review Request 47541: clean up import * for HBase service scripts in common-services

2016-05-18 Thread Juanjo Marron
https://builds.apache.org/job/Ambari-trunk-test-patch/6878//console Thanks, Juanjo Marron

Re: Review Request 47475: clean up import * for Hive service scripts in common-services

2016-05-18 Thread Juanjo Marron
assed unit tests in ambari-server. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/6869//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/6869//console This message is automatically generated. Thanks, Juanjo Marron

Re: Review Request 47477: clean up import * for HDFS service scripts in common-services

2016-05-18 Thread Juanjo Marron
trunk-test-patch/6870//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/6870//console This message is automatically generated. Thanks, Juanjo Marron

Review Request 47560: clean up import * for Kerberos service scripts in common-services

2016-05-18 Thread Juanjo Marron
ge is automatically generated. Thanks, Juanjo Marron

Re: Review Request 47475: clean up import * for Hive service scripts in common-services

2016-05-18 Thread Juanjo Marron
eviews.apache.org/r/47475/#review133768 ------- On May 18, 2016, 4:48 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 47541: clean up import * for HBase service scripts in common-services

2016-05-18 Thread Juanjo Marron
che.org/r/47541/#review133825 --- On May 18, 2016, 4:41 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 47475: clean up import * for Hive service scripts in common-services

2016-05-18 Thread Juanjo Marron
che.org/r/47475/#review133824 --- On May 18, 2016, 4:48 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 47477: clean up import * for HDFS service scripts in common-services

2016-05-18 Thread Juanjo Marron
it: https://reviews.apache.org/r/47477/#review133767 --- On May 18, 2016, 4:49 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 47560: clean up import * for Kerberos service scripts in common-services

2016-05-18 Thread Juanjo Marron
it: https://reviews.apache.org/r/47560/#review133823 --- On May 18, 2016, 10:14 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To rep

Review Request 47619: clean up import * for MAHOUT service scripts in common-services

2016-05-19 Thread Juanjo Marron
sults: https://builds.apache.org/job/Ambari-trunk-test-patch/6906//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/6906//console Thanks, Juanjo Marron

Re: Review Request 47560: clean up import * for Kerberos service scripts in common-services

2016-05-19 Thread Juanjo Marron
ated e-mail. To reply, visit: https://reviews.apache.org/r/47560/#review134050 --- On May 18, 2016, 10:14 p.m., Juanjo Marron wrote: > > --- > This is an automatically gen

Review Request 47653: clean up import * for OOZIE service scripts in common-services

2016-05-20 Thread Juanjo Marron
Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/6920//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/6920//console This message is automatically generated. Thanks, Juanjo Marron

Review Request 47669: import missing check_process_status

2016-05-20 Thread Juanjo Marron
in snamenode check_process_status(status_params.snamenode_pid_file) NameError: global name 'check_process_status' is not defined It was not captured on the UTs, fresh installation and service_check tests Thanks, Juanjo Marron

Review Request 47781: clean up import * for PIG service scripts in common-services

2016-05-24 Thread Juanjo Marron
https://builds.apache.org/job/Ambari-trunk-test-patch/6946//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/6946//console This message is automatically generated. Thanks, Juanjo Marron

Review Request 47922: clean up import * for KNOX service scripts in common-services

2016-05-26 Thread Juanjo Marron
mbari-server. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/6985//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/6985//console This message is automatically generated. Thanks, Juanjo Marron

Review Request 47923: clean up import * for SPARK service scripts in common-services

2016-05-26 Thread Juanjo Marron
ge is automatically generated. Thanks, Juanjo Marron

Review Request 47934: clean up import * for SLIDER service scripts in common-services

2016-05-26 Thread Juanjo Marron
ssage is automatically generated. Reply Thanks, Juanjo Marron

Review Request 47962: clean up import * for STORM, TEZ and ZEPPELIN services

2016-05-27 Thread Juanjo Marron
g/job/Ambari-trunk-test-patch/7000//console This message is automatically generated. Thanks, Juanjo Marron

Review Request 47963: clean up import * for YARN service

2016-05-27 Thread Juanjo Marron
cally generated. Reply Thanks, Juanjo Marron

Review Request 47964: clean up import * for ZOOKEEPER service

2016-05-27 Thread Juanjo Marron
patch/7006//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7006//console This message is automatically generated. Thanks, Juanjo Marron

Review Request 47965: clean up import * for RANGER service

2016-05-27 Thread Juanjo Marron
cally generated. Thanks, Juanjo Marron

Re: Review Request 47964: clean up import * for ZOOKEEPER service

2016-06-01 Thread Juanjo Marron
iew135757 --- On May 27, 2016, 4:36 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 47963: clean up import * for YARN service

2016-06-01 Thread Juanjo Marron
it this issue for verification, please? - Juanjo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47963/#review135820 ----------- On May 27, 2016, 4:33 p.m., Juanjo Marron wrote: > > -

Review Request 48143: Missing import check_process_status for HDFS nodemanager service

2016-06-01 Thread Juanjo Marron
://reviews.apache.org/r/48143/diff/ Testing --- Added after Jayush Luniya comment on https://reviews.apache.org/r/47963 Thanks, Juanjo Marron

Re: Review Request 48143: Missing import check_process_status for YARN nodemanager service

2016-06-01 Thread Juanjo Marron
Diffs - ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py 038ccb9 Diff: https://reviews.apache.org/r/48143/diff/ Testing --- Added after Jayush Luniya comment on https://reviews.apache.org/r/47963 Thanks, Juanjo Marron

Re: Review Request 47963: clean up import * for YARN service

2016-06-01 Thread Juanjo Marron
t; > > @Juanjo, it looks like check_process_status is not imported for YARN > > nodemanager and will cause problems. Can you submit an addendum patch with > > this change? > > Juanjo Marron wrote: > Hi Jayush, > Yes, ill work on fixing it. Can you tell me when you hit th

Re: Review Request 47653: clean up import * for OOZIE service scripts in common-services

2016-06-01 Thread Juanjo Marron
- Juanjo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47653/#review135750 --- On May 20, 2016, 6:14 p.m., Juanjo Mar

Re: Review Request 47923: clean up import * for SPARK service scripts in common-services

2016-06-01 Thread Juanjo Marron
his is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47923/#review135754 --- On May 26, 2016, 11:04 p.m., Juanjo Marron wrote: > > --- > This i

Re: Review Request 47923: clean up import * for SPARK service scripts in common-services

2016-06-01 Thread Juanjo Marron
> On June 1, 2016, 2:53 a.m., Jayush Luniya wrote: > > Patch doesnt apply cleanly. Can you rebase the patch? > > Juanjo Marron wrote: > Patch submitted to https://issues.apache.org/jira/browse/AMBARI-16797. > Waiting for Hadoop QA review Patch applied cleanly by

Re: Review Request 47653: clean up import * for OOZIE service scripts in common-services

2016-06-02 Thread Juanjo Marron
> On June 1, 2016, 2:33 a.m., Jayush Luniya wrote: > > Patch doesnt apply cleanly. Can you rebase the patch and resolve conflicts? > > Juanjo Marron wrote: > New patch submitted to https://issues.apache.org/jira/browse/AMBARI-16672. > Waiting for HAdoop QA review

Review Request 48184: clean up import * for SPARK2 service scripts in common-services

2016-06-02 Thread Juanjo Marron
/7156//console This message is automatically generated. Thanks, Juanjo Marron

Re: Review Request 48184: clean up import * for SPARK2 service scripts in common-services

2016-06-08 Thread Juanjo Marron
- Juanjo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48184/#review136516 --- On June 7, 2016, 4:09 p.m., Juanjo Mar

Re: Review Request 48184: clean up import * for SPARK2 service scripts in common-services

2016-06-09 Thread Juanjo Marron
> On June 7, 2016, 6:45 p.m., Alejandro Fernandez wrote: > > Ship It! > > Juanjo Marron wrote: > I dont have privileges to commit. Could someone deliver it to trunk so I > can mark the JIRA https://issues.apache.org/jira/browse/AMBARI-16101 as > complete, please?

Review Request 48766: MySQL service status needs to be more robust

2016-06-15 Thread Juanjo Marron
f release audit warnings. +1 core tests. The patch passed unit tests in ambari-server. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7367//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7367//console This message is automatically generated. Thanks, Juanjo Marron

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-15 Thread Juanjo Marron
nerated e-mail. To reply, visit: https://reviews.apache.org/r/48766/#review137885 ------- On June 15, 2016, 10:39 p.m., Juanjo Marron wrote: > > --- > This is an automatic

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-15 Thread Juanjo Marron
; > > We should probably do a checked_call here to give an exception with a > > good information in case we cannot do this. > > > > Also why to we need timeout here? > > Juanjo Marron wrote: > Hi Andrew! > Thanks for the quick review > >

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-16 Thread Juanjo Marron
javac. The applied patch does not increase the total number of javac compiler warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in ambari-server. Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7367//testReport/ Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7367//console This message is automatically generated. Thanks, Juanjo Marron

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-16 Thread Juanjo Marron
; > > We should probably do a checked_call here to give an exception with a > > good information in case we cannot do this. > > > > Also why to we need timeout here? > > Juanjo Marron wrote: > Hi Andrew! > Thanks for the quick review > >

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-16 Thread Juanjo Marron
ql_pid_file is None: raise Fail("Output of '{0}' didn't contain pid_file. Output: '{1}'").format(cmd, output) return mysql_pid_file I tested start, stop, and restart and seems to be working fine. Please, let me know what do you think and I

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-17 Thread Juanjo Marron
rn mysql_pid_file > > Andrew Onischuk wrote: > Juanjo sorry for bothering you so much with this issues. I just feel like > this is something which we should fix to be able debug problems in this place > more simply in future. > > Juanjo Marron wrote: > No problem

Re: Review Request 49735: AMBARI-17570 Lack of importing ClientComponentHasNoStatus

2016-07-06 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49735/#review141106 --- Ship it! Ship It! - Juanjo Marron On July 6, 2016, 11:45

Re: Review Request 49930: AMBARI-17614 Clean up import * for AMBARI_METRICS services

2016-07-11 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49930/#review141805 --- Ship it! Ship It! - Juanjo Marron On July 11, 2016, 10:59

Re: Review Request 49895: AMBARI-17631: preinstall-check script should use AMBARI-AGENT REST API for the list of agents

2016-07-12 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49895/#review141961 --- Ship it! Ship It! - Juanjo Marron On July 12, 2016, 4:48

Re: Review Request 48766: MySQL service status needs to be more robust

2016-08-02 Thread Juanjo Marron
rn mysql_pid_file > > Andrew Onischuk wrote: > Juanjo sorry for bothering you so much with this issues. I just feel like > this is something which we should fix to be able debug problems in this place > more simply in future. > > Juanjo Marron wrote: > No problem

Re: Review Request 48766: MySQL service status needs to be more robust

2016-08-03 Thread Juanjo Marron
rn mysql_pid_file > > Andrew Onischuk wrote: > Juanjo sorry for bothering you so much with this issues. I just feel like > this is something which we should fix to be able debug problems in this place > more simply in future. > > Juanjo Marron wrote: > No problem

Re: Review Request 48766: MySQL service status needs to be more robust

2016-08-05 Thread Juanjo Marron
: https://builds.apache.org/job/Ambari-trunk-test-patch/7367//console This message is automatically generated. Thanks, Juanjo Marron

  1   2   >