Review Request 48178: AMBARI-17017. Fixing open issues for 'Hive Server Interactive' in Kerberized environment. / AMBARI-17020. Use 'llapstatus' comand after starting llap to check its status before s

2016-06-02 Thread Swapan Shridhar
eviews.apache.org/r/48178/diff/ Testing --- - Python UT passes. Thanks, Swapan Shridhar

Review Request 48590: AMBARI-17179. Allow 'LLAP related calculations' to be done for any selected queue instead of existing for only 'llap' named queue.

2016-06-12 Thread Swapan Shridhar
Attachments Screen Shot 2016-06-12 at 3.46.48 PM.png https://reviews.apache.org/media/uploaded/files/2016/06/12/9e2997f5-2d81-410a-b84a-1e313800e4c2__Screen_Shot_2016-06-12_at_3.46.48_PM.png Thanks, Swapan Shridhar

Re: Review Request 48590: AMBARI-17179. Allow 'LLAP related calculations' to be done for any selected queue instead of existing for only 'llap' named queue.

2016-06-12 Thread Swapan Shridhar
and modifed. - Python UT passes. File Attachments Screen Shot 2016-06-12 at 3.46.48 PM.png https://reviews.apache.org/media/uploaded/files/2016/06/12/9e2997f5-2d81-410a-b84a-1e313800e4c2__Screen_Shot_2016-06-12_at_3.46.48_PM.png Thanks, Swapan Shridhar

Review Request 48506: AMBARI-17103. Incorporating the inheritance logic for "tez_hive2/tez-site.xml" using tez/tez-site.xml. Also, removing 'hive.tez.java.opts' config from hive2/hive-site.xml as it w

2016-06-09 Thread Swapan Shridhar
c52 Diff: https://reviews.apache.org/r/48506/diff/ Testing --- Python UTs modified : Passes. Thanks, Swapan Shridhar

Review Request 47815: Handle the scenario when 'capacity-scheduler' configs is passed in as dictionary to Stack Advisor (generally on 1st invocation) in order to create 'llap' queue for Hive Server In

2016-05-25 Thread Swapan Shridhar
tionary. Diffs - ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py af812fe ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 51c0d0c Diff: https://reviews.apache.org/r/47815/diff/ Testing --- - Tested Blueprint deploy with strategy "ALWAYS_APPLY_DONT_OVERRIDE_CUSTOM_VALUES " : Works. - Tested UI deploy : Works. - - Added Python UT's to test the behavior when 'capacity-scheduler' is passed in as a dictionary. - Python UT passes. Thanks, Swapan Shridhar

Review Request 48301: AMBARI-17075. Set 'hive.server2.tez.default.queues' config value to be the one used by config hive.llap.daemon.queue.name for 'llap' app.

2016-06-06 Thread Swapan Shridhar
/ Testing --- - Added new UT's and updated the relevant existing one. Relevant Python UT passes. - Errors seen in other UTs (87 total). Thanks, Swapan Shridhar

Review Request 48454: AMBARI-17103. Incorporating the inheritance logic for "tez_hive2/tez-site.xml" using tez/tez-site.xml. Also, removing 'hive.tez.java.opts' config from hive2/hive-site.xml as it w

2016-06-08 Thread Swapan Shridhar
ck_secured (test_yarn_service_check.TestServiceCheck) ERROR: test_service_check_default (test_yarn_service_check.TestServiceCheck) Thanks, Swapan Shridhar

Review Request 48454: AMBARI-17103. Incorporating the inheritance logic for "tez_hive2/tez-site.xml" using tez/tez-site.xml. Also, removing 'hive.tez.java.opts' config from hive2/hive-site.xml as it w

2016-06-08 Thread Swapan Shridhar
ck_secured (test_yarn_service_check.TestServiceCheck) ERROR: test_service_check_default (test_yarn_service_check.TestServiceCheck) Thanks, Swapan Shridhar

Re: Review Request 47996: AMBARI-16942. Take into account reading 'hive.tez.container.size', 'yarn.scheduler.minimum-allocation-mb', 'yarn.nodemanager.resource.memory-mb' & 'tez.am.resource.memory.mb'

2016-05-27 Thread Swapan Shridhar
main/resources/stacks/HDP/2.5/services/stack_advisor.py 837a446 ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 3f5da61 Diff: https://reviews.apache.org/r/47996/diff/ Testing --- - Fixed Python UT. - - Python UT passes. Thanks, Swapan Shridhar

Re: Review Request 48042: Allow setting log level, and java opts for hive interactive/llap

2016-05-31 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48042/#review135655 --- Ship it! Ship It! - Swapan Shridhar On May 30, 2016, 1:33

Review Request 47949: AMBARI-16923. Fix for getting the 'hive.llap.daemon.queue.name' config Property Attributes updated if there is a change in 'capacity-scheduler'.

2016-05-27 Thread Swapan Shridhar
- - Python UT added. - - Python UT passes. Thanks, Swapan Shridhar

Re: Review Request 47946: Yarn minimum container size calculation problem in stack advisor

2016-05-27 Thread Swapan Shridhar
terms of timeline compared to services. Your inputs please? - Swapan Shridhar On May 27, 2016, 10:14 a.m., Daniel Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 47949: AMBARI-16923. Fix for getting the 'hive.llap.daemon.queue.name' config Property Attributes updated if there is a change in 'capacity-scheduler'.

2016-05-27 Thread Swapan Shridhar
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47949/#review135224 ------- On May 27, 2016, 10:48 a.m., Swapan Shridhar wrote: > > --

Re: Review Request 47946: Yarn minimum container size calculation problem in stack advisor

2016-05-27 Thread Swapan Shridhar
> On May 27, 2016, 11:05 a.m., Swapan Shridhar wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py, > > line 643 > > <https://reviews.apache.org/r/47946/diff/1/?file=1396190#file1396190line643> > > > > Should we d

Re: Review Request 47949: AMBARI-16923. Fix for getting the 'hive.llap.daemon.queue.name' config Property Attributes updated if there is a change in 'capacity-scheduler'.

2016-05-27 Thread Swapan Shridhar
on/stacks/2.5/common/test_stack_advisor.py 0066e1d Diff: https://reviews.apache.org/r/47949/diff/ Testing --- - Python UT added. - - Python UT passes. Thanks, Swapan Shridhar

Review Request 47996: AMBARI-16921. Take into account reading 'hive.tez.container.size', 'yarn.scheduler.minimum-allocation-mb', 'yarn.nodemanager.resource.memory-mb' & 'tez.am.resource.memory.mb' con

2016-05-27 Thread Swapan Shridhar
837a446 ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 3f5da61 Diff: https://reviews.apache.org/r/47996/diff/ Testing --- - Fixed Python UT. - - Python UT passes. Thanks, Swapan Shridhar

Re: Review Request 47914: AMBARI-16910. Hive Server Interactive. Change the timeout to 120 secs for LLAP alert command.

2016-05-26 Thread Swapan Shridhar
-1c9d10d79a23__Screen_Shot_2016-05-26_at_5.34.45_PM.png RUNNING state https://reviews.apache.org/media/uploaded/files/2016/05/27/b9c22854-8c5f-463c-bc3d-e1b38ea7c351__Screen_Shot_2016-05-26_at_5.32.15_PM.png Thanks, Swapan Shridhar

Review Request 47914: AMBARI-16910. Hive Server Interactive. Change the timeout to 120 secs for LLAP alert command.

2016-05-26 Thread Swapan Shridhar
-e1b38ea7c351__Screen_Shot_2016-05-26_at_5.32.15_PM.png Thanks, Swapan Shridhar

Review Request 49014: AMBARI-17331. Determine Tez for Hive2 config 'tez.am.resource.memory.mb' based on cluster capacity.

2016-06-21 Thread Swapan Shridhar
bc53ea Diff: https://reviews.apache.org/r/49014/diff/ Testing --- Python UT added. - Python UT passes. Thanks, Swapan Shridhar

Review Request 48712: AMBARI-17263. Fix for following for Hive Server Interactive : (1). Updates to 'llapstatus' command while querying LLAP app status. (2). Adding validation check for config 'hive.s

2016-06-15 Thread Swapan Shridhar
/test_stack_advisor.py 4085ad6 Diff: https://reviews.apache.org/r/48712/diff/ Testing --- Added Validation UT. - Python UT passes. Thanks, Swapan Shridhar

Review Request 48697: AMBARI-17229. Add config 'tez.lib.uris' in tez_hive2/tez-site's pointing to tez_hive2 path jar.

2016-06-14 Thread Swapan Shridhar
ks/HDP/2.5/services/HIVE/configuration/tez-interactive-site.xml 93a2073 Diff: https://reviews.apache.org/r/48697/diff/ Testing --- Python UT passes. Thanks, Swapan Shridhar

Re: Review Request 48697: AMBARI-17229. Add config 'tez.lib.uris' in tez_hive2/tez-site's pointing to tez_hive2 path jar.

2016-06-14 Thread Swapan Shridhar
l eb4aa61 ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/tez-interactive-site.xml 93a2073 Diff: https://reviews.apache.org/r/48697/diff/ Testing --- Python UT passes. Thanks, Swapan Shridhar

Re: Review Request 48814: AMBARI-17283. Display LLAP calculated configs as 'Labels' (non-editable) on 'Hive Server Interactive' Panel and Textboxes (editable) in HIVE Advanced section.

2016-06-16 Thread Swapan Shridhar
-16_at_1.55.20_PM.png Thanks, Swapan Shridhar

Re: Review Request 49014: AMBARI-17331. Determine Tez for Hive2 config 'tez.am.resource.memory.mb' based on cluster capacity.

2016-06-21 Thread Swapan Shridhar
cks/HDP/2.5/services/stack_advisor.py 76654c3 ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 1bc53ea Diff: https://reviews.apache.org/r/49014/diff/ Testing --- Python UT added. - Python UT passes. Thanks, Swapan Shridhar

Re: Review Request 49014: AMBARI-17331. Determine Tez for Hive2 config 'tez.am.resource.memory.mb' based on cluster capacity.

2016-06-21 Thread Swapan Shridhar
added. - Python UT passes. Thanks, Swapan Shridhar

Review Request 48894: AMBARI-17306. Filter out Message Of The Day (MOTD) logging from 'llapstatus' command in order to get the output which is JSON parsable.

2016-06-17 Thread Swapan Shridhar
ppComplete_withMOTDmsg.txt PRE-CREATION ambari-server/src/test/python/stacks/2.5/HIVE/invalidApp_withMOTDmsg.txt PRE-CREATION ambari-server/src/test/python/stacks/2.5/HIVE/oneContainerDown_withMOTDmsg.txt PRE-CREATION ambari-server/src/test/python/stacks/2.5/HIVE/running_withMOTDmsg.txt PRE-CREATION ambari-server/src/test/python/stacks/2.5/HIVE/starting_withMOTDmsg.txt PRE-CREATION ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 348a17d Diff: https://reviews.apache.org/r/48894/diff/ Testing --- Python UT added. - Python UT passes. Thanks, Swapan Shridhar

Review Request 49114: AMBARI-17384. Remove '/usr/hdp' hardcoding from HIVE's alert_llap_app_status.py and KNOX's upgrade.py

2016-06-22 Thread Swapan Shridhar
401 ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py 8c71260 Diff: https://reviews.apache.org/r/49114/diff/ Testing --- Python UT passes. Thanks, Swapan Shridhar

Review Request 49128: AMBARI-17389. Read 'yarn.nodemanager.resource.memory-mb' and 'yarn.scheduler.minimum-allocation-mb' from 'configurations' if 'changed-configurations' is empty and config is there

2016-06-22 Thread Swapan Shridhar
e. Diffs - ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 8aa2f5f ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py fce1c1c Diff: https://reviews.apache.org/r/49128/diff/ Testing --- Updated Python UTs. Thanks, Swapan Shridhar

Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in Ambari

2016-06-16 Thread Swapan Shridhar
ot_2016-04-28_at_2.27.03_AM.png Thanks, Swapan Shridhar

Review Request 49163: AMBARI-17408. Use the correct config for slider AM size 'slider_am_container_mb' to set its value during LLAP config calculations.

2016-06-23 Thread Swapan Shridhar
/stack_advisor.py 4c2f889 ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 0218b30 Diff: https://reviews.apache.org/r/49163/diff/ Testing --- - Updated Python UT - Python UT passes. Thanks, Swapan Shridhar

Review Request 49179: AMBARI-17418. Fix for LLAP calculation to happen on invocation by Blueprints and HIVE SERVER INTERACTIVE is ON (1st invocation to Stack Advisor). Also, reverts AMBARI-17283.

2016-06-23 Thread Swapan Shridhar
/2.5/common/test_stack_advisor.py e4fad77 Diff: https://reviews.apache.org/r/49179/diff/ Testing --- - Fixed Python UT's - Added Python Ut for checking when services['changed-configurations'] is passed-in as empty. - Pyython UT passes. Thanks, Swapan Shridhar

Re: Review Request 49179: AMBARI-17418. Fix for LLAP calculation to happen on invocation by Blueprints and HIVE SERVER INTERACTIVE is ON (1st invocation to Stack Advisor). Also, reverts AMBARI-17283.

2016-06-23 Thread Swapan Shridhar
ecking when services['changed-configurations'] is passed-in as empty. - Pyython UT passes. Thanks, Swapan Shridhar

Re: Review Request 49179: AMBARI-17418. Fix for LLAP calculation to happen on invocation by Blueprints and HIVE SERVER INTERACTIVE is ON (1st invocation to Stack Advisor). Also, reverts AMBARI-17283.

2016-06-24 Thread Swapan Shridhar
st/python/stacks/2.5/common/test_stack_advisor.py e4fad77 Diff: https://reviews.apache.org/r/49179/diff/ Testing --- - Fixed Python UT's - Added Python Ut for checking when services['changed-configurations'] is passed-in as empty. - Pyython UT passes. Thanks, Swapan Shridhar

Review Request 49298: AMBARI-17461. Assign Hive Server Interactive config 'hive.llap.daemon.yarn.container.mb' value of 'yarn.scheduler.minimum-allocation-mb' only if call is made via Blueprint.

2016-06-28 Thread Swapan Shridhar
5/services/stack_advisor.py af2d2c1 Diff: https://reviews.apache.org/r/49298/diff/ Testing --- Python UT passes. Thanks, Swapan Shridhar

Re: Review Request 49221: [PREVIEW] Smart configs for Atlas to setup authentication as either LDAP or AD

2016-06-27 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49221/#review139636 --- Ship it! Ship It! - Swapan Shridhar On June 25, 2016, 12:08

Review Request 44556: HiveInteractive. (1). Code for 'Hive Server Interactive' and related 'Tez' binaries installation. (2). Parameter declaration in 'params_linux' and 'status_params' related to 'Hiv

2016-03-11 Thread Swapan Shridhar
-upgrade.json 9122a69 Diff: https://reviews.apache.org/r/44556/diff/ Testing --- - Yes. Installation of hive-server2-hive2 and tez_hive2 goes fine with HDp 2.6.0.0-110 build. - Python UT passes. - "mvn clean test" -> In progress, will update the results. Thanks, Swapan Shridhar

Re: Review Request 44556: HiveInteractive. (1). Code for 'Hive Server Interactive' and related 'Tez' binaries installation. (2). Parameter declaration in 'params_linux' and 'status_params' related to

2016-03-15 Thread Swapan Shridhar
passes. Thanks, Swapan Shridhar

Review Request 44746: HiveInteractiveServer. Add 'tez-interactive-site.xml' for custom Tez used by Hive2.

2016-03-14 Thread Swapan Shridhar
provided by Sid Seth in https://hortonworks.jira.com/browse/BUG-50819 Diffs - ambari-server/src/main/resources/stacks/HDP/2.6/services/HIVE/configuration/tez-interactive-site.xml PRE-CREATION Diff: https://reviews.apache.org/r/44746/diff/ Testing --- Not done. Thanks, Swapan Shridhar

Re: Review Request 46105: capacity-scheduler config blob is not a part of recommendation API when Hive Interactive query is turned ON

2016-04-12 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46105/#review128500 --- Ship it! Ship It! - Swapan Shridhar On April 12, 2016, 6:03

Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-09 Thread Swapan Shridhar
/services/stack_advisor.py 9050092 Diff: https://reviews.apache.org/r/45972/diff/ Testing --- - Partially done. - Currently blocked by : https://hortonworks.jira.com/browse/BUG-55791 - - Python UT : PASSES. Thanks, Swapan Shridhar

Re: Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-10 Thread Swapan Shridhar
-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py a3009ee Diff: https://reviews.apache.org/r/45972/diff/ Testing --- - Partially done. - Python UT : PASSES. Thanks, Swapan

Re: Review Request 45786: Lifecycle for restarting LLAP on HiveServer Interactive via Custom Command

2016-04-05 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45786/#review127263 --- Ship it! Ship It! - Swapan Shridhar On April 6, 2016, 12:14

Re: Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-11 Thread Swapan Shridhar
/YARN/kerberos.json PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py a3009ee Diff: https://reviews.apache.org/r/45972/diff/ Testing --- - Partially done. - Python UT : PASSES. Thanks, Swapan Shridhar

Re: Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-11 Thread Swapan Shridhar
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 1812d05 Diff: https://reviews.apache.org/r/45972/diff/ Testing --- - Partially done. - Python UT : PASSES. Thanks, Swapan Shridhar

Re: Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-10 Thread Swapan Shridhar
> Remove the variable llap_local_dir Removed. Not required till we decide on creating LLAP related work dirs. - Swapan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4597

Review Request 45175: Fix the 'tez-interactive-site.xml'. Added new properties, fixed values of existing props.

2016-03-22 Thread Swapan Shridhar
/configuration/tez-interactive-site.xml c4dee3e Diff: https://reviews.apache.org/r/45175/diff/ Testing --- Yes. Said props value enable LLAP and Hive Interactive to come up properly. Thanks, Swapan Shridhar

Re: Review Request 45175: Fix the 'tez-interactive-site.xml'. Added new properties, fixed values of existing props.

2016-03-22 Thread Swapan Shridhar
eviews.apache.org/r/45175/#review124878 --- On March 22, 2016, 7:29 p.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 45175: Fix the 'tez-interactive-site.xml'. Added new properties, fixed values of existing props.

2016-03-22 Thread Swapan Shridhar
line390> > > > > Why is this not a multiple of 8 or even 64? > > Swapan Shridhar wrote: > This value is in MB. So will still stay aligned on 8 byte boundary. > > Swapan Shridhar wrote: > 682 is generally taken default. But our YARN setting Scheduler -> > yarn

Re: Review Request 45175: Fix the 'tez-interactive-site.xml'. Added new properties, fixed values of existing props.

2016-03-22 Thread Swapan Shridhar
line390> > > > > Why is this not a multiple of 8 or even 64? > > Swapan Shridhar wrote: > This value is in MB. So will still stay aligned on 8 byte boundary. 682 is generally taken default. But our YARN setting Scheduler -> yarn.scheduler.capacity.root.default.maximum-capacity

Re: Review Request 45289: RBAC based user access to view instances are not honoured

2016-03-24 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45289/#review125296 --- Ship it! Ship It! - Swapan Shridhar On March 24, 2016, 2:59

Re: Review Request 45325: Add the Config, Start and Stop logic for: (1). Hive Server Interactive, and (2). Associate the LLAP lifecycle to it.

2016-03-25 Thread Swapan Shridhar
s. - 2.5 : Negative testing : Only Hive Batch gets installed. (Hive Server Interactive not present). - - Python UT : Passes. - mvn clean test : ongoing. Will update. Thanks, Swapan Shridhar

Re: Review Request 45325: Add the Config, Start and Stop logic for: (1). Hive Server Interactive, and (2). Associate the LLAP lifecycle to it.

2016-03-25 Thread Swapan Shridhar
nt. Removed. > On March 25, 2016, 4:22 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py, > > line 76 > > <https://reviews.apache.org/r/45325/diff/1/?file=1314429#file1314429line76> > > > > Can you add a comment as to what does this do?

Re: Review Request 45325: Add the Config, Start and Stop logic for: (1). Hive Server Interactive, and (2). Associate the LLAP lifecycle to it.

2016-03-25 Thread Swapan Shridhar
ile=1314430#file1314430line116> > > > > Should not do sys.exit since may not grab error message, instead, > > return. Using return - Swapan --- This is an automatically generated e-mail. To reply, vi

Re: Review Request 45325: Add the Config, Start and Stop logic for: (1). Hive Server Interactive, and (2). Associate the LLAP lifecycle to it.

2016-03-27 Thread Swapan Shridhar
- Swapan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45325/#review12 --- On March 26, 2016, 4:27 a.m., Swapan Shridhar wrote: >

Re: Review Request 45598: Stack Upgrade did not ABORT in-progress upgrade, need to relax 'suspended' property and keep API backward compatible

2016-04-01 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45598/#review126633 --- Ship it! Ship It! - Swapan Shridhar On April 1, 2016, 7:06

Re: Review Request 46547: Create "/hadoop/llap/local" on each host and disk in Kerberized cluster for LLAP

2016-04-22 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46547/#review130209 --- Ship it! LGTM. - Swapan Shridhar On April 22, 2016, 10:24

Review Request 46600: Config calculations used by LLAP app.

2016-04-22 Thread Swapan Shridhar
vices/HIVE/configuration/hive-interactive-site.xml 21d1109 ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 4da21fa Diff: https://reviews.apache.org/r/46600/diff/ Testing --- Thanks, Swapan Shridhar

Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. Config calculations used by LLAP app. and fixes for AMBARI-16079, AMBARI-16086, AMBARI-16087

2016-04-25 Thread Swapan Shridhar
failures:0 OK Thanks, Swapan Shridhar

Re: Review Request 46427: AMBARI-15985. Service Checks for Hive Server Interactive and LLAP.

2016-04-20 Thread Swapan Shridhar
----- On April 20, 2016, 8:55 p.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46427/ >

Re: Review Request 46427: AMBARI-15985. Service Checks for Hive Server Interactive and LLAP.

2016-04-20 Thread Swapan Shridhar
> > Any reason we are running it twice? > > Swapan Shridhar wrote: > Nothing specific. A second chance. Typically, seen same way in HCAT and > Webhcat. Suggesting to do it only once ? > > Sumit Mohanty wrote: > Lets just call

Re: Review Request 46427: AMBARI-15985. Service Checks for Hive Server Interactive and LLAP.

2016-04-20 Thread Swapan Shridhar
', 'hdfs_site': ..., 'kinit_path_local': 'kinit', 'principal_name': 'missing_principal', 'user': 'hdfs', 'action': ['execute'], 'hadoop_conf_dir': '/usr/hdp/current/hadoop-client/conf', 'immutable_paths': [u'/apps/hive/warehouse', u'/mr-history/done', u'/app-logs', u'/tmp']} 2016-04-20 19:32:09,275 - Execute['/var/lib/ambari-agent/tmp/templetonSmoke.sh c6402.ambari.apache.org ambari-qa 50111 idtest.ambari-qa.1461180728.73.pig no_keytab false kinit no_principal'] {'logoutput': True, 'path': ['/usr/sbin:/sbin:/usr/local/bin:/bin:/usr/bin'], 'tries': 3, 'try_sleep': 5} Thanks, Swapan Shridhar

Re: Review Request 46427: AMBARI-15985. Service Checks for Hive Server Interactive and LLAP.

2016-04-20 Thread Swapan Shridhar
To reply, visit: https://reviews.apache.org/r/46427/#review129762 ------- On April 20, 2016, 6:15 p.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e

Re: Review Request 46511: Installer wizard: Starting Services hangs because of LLAP status check.

2016-04-21 Thread Swapan Shridhar
. Thanks, Swapan Shridhar

Re: Review Request 46511: Installer wizard: Starting Services hangs because of LLAP status check.

2016-04-21 Thread Swapan Shridhar
, Swapan Shridhar

Review Request 46760: AMBARI-16149. Support for LLAP alert in Ambari

2016-04-27 Thread Swapan Shridhar
-42a0-8262-31d357509048__Screen_Shot_2016-04-27_at_5.59.32_PM.png App in LAUNCHING state . Cluster Kerberized. https://reviews.apache.org/media/uploaded/files/2016/04/28/7a9c5482-f8e2-43e0-b9f9-08e5a62ed97b__Screen_Shot_2016-04-27_at_6.40.46_PM.png Thanks, Swapan Shridhar

Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. (1). Config calculations used by LLAP app. (2). AMBARI-16079. waiting for fixed number of times if the launched LLAP app is in LAUNCHING

2016-04-23 Thread Swapan Shridhar
759a9 ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 1cb2a02 Diff: https://reviews.apache.org/r/46600/diff/ Testing (updated) --- Python UT passes. Thanks, Swapan Shridhar

Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. Config calculations used by LLAP app. and fixes for AMBARI-16079, AMBARI-16086, AMBARI-16087

2016-04-25 Thread Swapan Shridhar
UT passes. -- Ran 261 tests in 7.091s OK -- Total run:995 Total errors:0 Total failures:0 OK Thanks, Swapan Shridhar

Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. (1). Config calculations used by LLAP app. and fixes for AMBARI-16079, AMBARI-16086, AMBARI-16087

2016-04-25 Thread Swapan Shridhar
eviews.apache.org/r/46600/#review130264 --- On April 25, 2016, 9:04 a.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46600/ >

Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. (1). Config calculations used by LLAP app. and fixes for AMBARI-16079, AMBARI-16086, AMBARI-16087

2016-04-25 Thread Swapan Shridhar
7.091s OK -- Total run:995 Total errors:0 Total failures:0 OK Thanks, Swapan Shridhar

Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. Config calculations used by LLAP app. and fixes for AMBARI-16079, AMBARI-16086, AMBARI-16087

2016-04-25 Thread Swapan Shridhar
7.091s OK -- Total run:995 Total errors:0 Total failures:0 OK Thanks, Swapan Shridhar

Re: Review Request 46600: AMBARI-16078. HiveServerInteractive. (1). Config calculations used by LLAP app. (2). AMBARI-16079. waiting for fixed number of times if the launched LLAP app is in LAUNCHING

2016-04-25 Thread Swapan Shridhar
UT passes. -- Ran 261 tests in 7.091s OK -- Total run:995 Total errors:0 Total failures:0 OK Thanks, Swapan Shridhar

Re: Review Request 46602: Delete Service: Deleting Hive fails with 500 error

2016-04-24 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46602/#review130297 --- Ship it! Ship It! - Swapan Shridhar On April 24, 2016, 4:40

Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in Ambari

2016-04-28 Thread Swapan Shridhar
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46760/#review130918 --- On April 28, 2016, 9:52 a.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &g

Re: Review Request 46772: AMBARI-16155. Fixing LLAP calculations and related trivial issues.

2016-04-28 Thread Swapan Shridhar
/2.5/common/test_stack_advisor.py 2817878 Diff: https://reviews.apache.org/r/46772/diff/ Testing --- tested manually. Thanks, Swapan Shridhar

Re: Review Request 46772: AMBARI-16155. Fixing LLAP calculations and related trivial issues.

2016-04-28 Thread Swapan Shridhar
/2.5/common/test_stack_advisor.py 2817878 Diff: https://reviews.apache.org/r/46772/diff/ Testing --- UT passes. Thanks, Swapan Shridhar

Re: Review Request 47621: AMBARI-16784. Remove 'org.apache.atlas.hive.hook.HiveHook' from Hive2/hive-site.xml config hive.exec.post.hooks as Atlas is not supported by Hive2.

2016-05-19 Thread Swapan Shridhar
need to remove it. Diffs - ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py 8e49cf0 Diff: https://reviews.apache.org/r/47621/diff/ Testing --- Python UT passes. Thanks, Swapan Shridhar

Review Request 47621: AMBARI-16784. Remove 'org.apache.atlas.hive.hook.HiveHook' from Hive2/hive-site.xml config hive.exec.post.hooks as Atlas is not supported by Hive2.

2016-05-19 Thread Swapan Shridhar
/0.12.0.2.0/package/scripts/hive_interactive.py 8e49cf0 Diff: https://reviews.apache.org/r/47621/diff/ Testing --- Python UT passes. Thanks, Swapan Shridhar

Re: Review Request 47621: AMBARI-16784. Remove 'org.apache.atlas.hive.hook.HiveHook' from Hive2/hive-site.xml config hive.exec.post.hooks as Atlas is not supported by Hive2.

2016-05-20 Thread Swapan Shridhar
/configs/hsi_default.json 65ff8b3 Diff: https://reviews.apache.org/r/47621/diff/ Testing (updated) --- - Tested removal of 'org.apache.atlas.hive.hook.HiveHook' value from 'hive.exec.post.hooks'. - - Added Unit Test. - Python UT passes. Thanks, Swapan Shridhar

Re: Review Request 47621: AMBARI-16784. Remove 'org.apache.atlas.hive.hook.HiveHook' from Hive2/hive-site.xml config hive.exec.post.hooks as Atlas is not supported by Hive2.

2016-05-20 Thread Swapan Shridhar
to JIRA 16784 Updated Review as per comments. - Swapan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47621/#review134085 ------- On May 20, 2016, 6:23 p.m., Swapan Shridhar wrote: > > ---

Re: Review Request 47596: HiveServer interactive - incorrect default memory value

2016-05-23 Thread Swapan Shridhar
/stack_advisor.py (line 221) <https://reviews.apache.org/r/47596/#comment199379> Can you explain how moving this line up helps ? Thx. - Swapan Shridhar On May 23, 2016, 8:20 a.m., Daniel Gergely wrote: > > --- > This is a

Re: Review Request 47596: HiveServer interactive - incorrect default memory value

2016-05-24 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47596/#review134606 --- Ship it! Ship It! - Swapan Shridhar On May 23, 2016, 8:20

Review Request 47680: AMBARI-16805. Fixing the failing Hive Service check for 'Hive Server Interactive' component

2016-05-20 Thread Swapan Shridhar
alid URL\|command not found\|Connection refused' - - - Python UT passes. Thanks, Swapan Shridhar

Review Request 47190: AMBARI-16438. Modifications to llap config names and descriptions

2016-05-10 Thread Swapan Shridhar
Screen Shot 2016-05-10 at 2.18.29 PM.png https://reviews.apache.org/media/uploaded/files/2016/05/10/3b6c19ce-0a55-42ce-86cb-a5e3cfa29686__Screen_Shot_2016-05-10_at_2.18.29_PM.png Thanks, Swapan Shridhar

Review Request 47506: AMBARI-16720. Update calculation logic for LLAP configs. AMBARI-16722. Change 'Number of LLAP Daemons', 'In-Memory Cache per Daemon', 'Maximum CPUs per Daemon' to be a 'Text Box'

2016-05-17 Thread Swapan Shridhar
tacks/2.5/common/test_stack_advisor.py cf82a9c Diff: https://reviews.apache.org/r/47506/diff/ Testing --- Yes. - Python UT's added. Thanks, Swapan Shridhar

Re: Review Request 47506: AMBARI-16720. Update calculation logic for LLAP configs. AMBARI-16722. Change 'Number of LLAP Daemons', 'In-Memory Cache per Daemon', 'Maximum CPUs per Daemon' to be a 'Text

2016-05-17 Thread Swapan Shridhar
views.apache.org/media/uploaded/files/2016/05/18/a0b77497-a9f5-47c8-8574-0e5cdc2b66be__Screen_Shot_2016-05-17_at_6.57.04_PM.png Thanks, Swapan Shridhar

Re: Review Request 47377: Fix for parsing multiple lines in output while looking for created 'llap package' name.

2016-05-13 Thread Swapan Shridhar
nd commit it. Updated JIRA. - Swapan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47377/#review133235 --- On May 14, 2016, 12:13

Re: Review Request 47377: Fix for parsing multiple lines in output while looking for created 'llap package' name.

2016-05-13 Thread Swapan Shridhar
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47377/#review133234 --- On May 14, 2016, 12:13 a.m., Swapan Shridhar wrote: > >

Re: Review Request 47377: AMBARI-16673. Fix for parsing multiple lines in output while looking for created 'llap package' name.

2016-05-13 Thread Swapan Shridhar
--- Yes. Pythn UT passes. Thanks, Swapan Shridhar

Re: Review Request 46925: Write out new log property files under /etc/hive2/conf

2016-05-03 Thread Swapan Shridhar
/hsi_default.json (line 52) <https://reviews.apache.org/r/46925/#comment195474> is \n intentional ? - Swapan Shridhar On May 3, 2016, 4:27 a.m., Sumit Mohanty wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 46877: LLAP related fix : Adding 'args' while package creation, commenting LLAP app status call, and code related to cache calculations.

2016-05-01 Thread Swapan Shridhar
/r/46877/diff/ Testing --- Yes. Python UT passes. Thanks, Swapan Shridhar

Re: Review Request 46248: YARN work preserving restart should be recommended and validated to be enabled if Hive interactive mode is turned ON

2016-04-15 Thread Swapan Shridhar
turned on and off respectively.) - Swapan Shridhar On April 15, 2016, 2:47 a.m., Sumit Mohanty wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 46248: YARN work preserving restart should be recommended and validated to be enabled if Hive interactive mode is turned ON

2016-04-15 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46248/#review129161 --- Ship it! Fix it and Ship it. - Swapan Shridhar On April 15

Re: Review Request 46183: AMBARI-15876. Stack advisor work for adding and disabling LLAP queue when Interactive query is turned on and off respectively.

2016-04-15 Thread Swapan Shridhar
oaded/files/2016/04/14/622db04f-ec39-4a63-920d-dffc3a269917__Screen_Shot_2016-04-13_at_4.51.03_PM.png YARn queue manager with llap and default queues https://reviews.apache.org/media/uploaded/files/2016/04/14/29ee3e5c-9c49-4e73-be39-46e6ec786d21__Screen_Shot_2016-04-13_at_4.48.46_PM.png Thanks, Swapan Shridhar

Re: Review Request 46183: AMBARI-15876. Stack advisor work for adding and disabling LLAP queue when Interactive query is turned on and off respectively.

2016-04-15 Thread Swapan Shridhar
s in the constructor? Done. - Swapan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46183/#review129170 --- On April 15,

Re: Review Request 46310: Use exclude list in order to merge hive-interactve-site from hive-site. Both will show common props in their config bag.

2016-04-18 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46310/#review129383 --- Ship it! Ship It! - Swapan Shridhar On April 18, 2016, 2:11

Review Request 46358: Incorporate 'llap status check' to be used for (1). Before Hive Server Interactive start, and (2). status call.

2016-04-18 Thread Swapan Shridhar
iff: https://reviews.apache.org/r/46358/diff/ Testing --- - UT added for this functionality tested. Thanks, Swapan Shridhar

Re: Review Request 46358: Incorporate 'llap status check' to be used for (1). Before Hive Server Interactive start, and (2). status call.

2016-04-18 Thread Swapan Shridhar
st/python/stacks/2.5/HIVE/starting.json PRE-CREATION ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py ac4f6fc Diff: https://reviews.apache.org/r/46358/diff/ Testing --- - UT added for this functionality tested. Thanks, Swapan Shridhar

Re: Review Request 46351: Hive Server Interactive to also write configs to conf.server and specify folder to unpack LLAP Slider app

2016-04-18 Thread Swapan Shridhar
g/r/46351/#comment192893> White spaces - Swapan Shridhar On April 18, 2016, 11:24 p.m., Alejandro Fernandez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 46358: Incorporate 'llap status check' to be used for (1). Before Hive Server Interactive start, and (2). status call.

2016-04-20 Thread Swapan Shridhar
it Mohanty wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py, > > line 352 > > <https://reviews.apache.org/r/46358/diff/7/?file=1352861#file1352861line352> > > > > Log the jso

Re: Review Request 46351: Hive Server Interactive to also write configs to conf.server and specify folder to unpack LLAP Slider app

2016-04-19 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46351/#review129656 --- Ship it! Ship It! - Swapan Shridhar On April 19, 2016, 11

  1   2   3   4   >