[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 3: (3 comments) > Based on my reading

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-20 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Philip Zeyliger, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8546 to look at the new patch set (#6). Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-20 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 6: (4 comments)

[Impala-ASF-CR] IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction

2017-11-20 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8436 ) Change subject: IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction .. Patch Set 8: > Uploaded patch

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2017-11-16 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8400 ) Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT .. Patch Set 3: (13 comments)

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-17 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Philip Zeyliger, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8546 to look at the new patch set (#5). Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 4: (7 comments)

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-17 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Philip Zeyliger, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8546 to look at the new patch set (#4). Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

[Impala-ASF-CR] IMPALA-5736: [DOCS] Document --query option for impala-shell

2017-12-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8771 ) Change subject: IMPALA-5736: [DOCS] Document --query_option for impala-shell .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE

2017-12-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8820 ) Change subject: IMPALA-5654: Disallow setting Kudu table name in CREATE TABLE .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-04 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10116 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. Patch Set 8: (4 comments)

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-04 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10116 to look at the new patch set (#8). Change subject: IMPALA-6131: Track time of last statistics update in metadata

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-05-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 4: Code-Review+1 (6 comments) Few nits otherwise looks

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-09 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10116 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. Patch Set 9: The change broke

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-09 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10116 to look at the new patch set (#9). Change subject: IMPALA-6131: Track time of last statistics update in metadata

[Impala-ASF-CR] IMPALA-6920: fix inconsistencies with scanner thread tokens

2018-04-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10186 ) Change subject: IMPALA-6920: fix inconsistencies with scanner thread tokens .. Patch Set 4: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6920: fix inconsistencies with scanner thread tokens

2018-04-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10186 ) Change subject: IMPALA-6920: fix inconsistencies with scanner thread tokens .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-10 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10116 to look at the new patch set (#10). Change subject: IMPALA-6131: Track time of last statistics update in metadata

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10116 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. Patch Set 10: Code-Review+1 Sorry, some of the

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-05-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-11 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10116 to look at the new patch set (#11). Change subject: IMPALA-6131: Track time of last statistics update in metadata

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10116 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. Patch Set 10: (8 comments)

[Impala-ASF-CR] IMPALA-5706: Parallelise read I/O in sorter

2018-05-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 ) Change subject: IMPALA-5706: Parallelise read I/O in sorter .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-05-04 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 3: (10 comments)

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-15 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10116 to look at the new patch set (#12). Change subject: IMPALA-6131: Track time of last statistics update in metadata

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10116 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. Patch Set 11: (4 comments)

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-20 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10116 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. Patch Set 14: >From the failing build: 21:55:34 ]

[Impala-ASF-CR](2.x) IMPALA-6131: Track time of last statistics update in metadata

2018-05-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10484 Change subject: IMPALA-6131: Track time of last statistics update in metadata .. IMPALA-6131: Track time of last statistics update in

[Impala-ASF-CR](2.x) IMPALA-6131: Track time of last statistics update in metadata

2018-05-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10484 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. Patch Set 1: The commit on master (

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-05-25 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 9: > > > Uploaded patch set 9. > > > > Patch -set 9

[Impala-ASF-CR] IMPALA-7060: Restrict Impala to only support timezones that work in Hive

2018-05-24 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10486 ) Change subject: IMPALA-7060: Restrict Impala to only support timezones that work in Hive .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-7060: Restrict Impala to only support timezones that work in Hive

2018-05-24 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10486 ) Change subject: IMPALA-7060: Restrict Impala to only support timezones that work in Hive .. Patch Set 1: > Is this a breaking

[Impala-ASF-CR] IMPALA-7060: Restrict Impala to only support timezones that work in Hive

2018-05-24 Thread Csaba Ringhofer (Code Review)
Hello Jim Apple, Attila Jeges, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10486 to look at the new patch set (#3). Change subject: IMPALA-7060: Restrict Impala to only support timezones that work in Hive

[Impala-ASF-CR] IMPALA-7060: Restrict Impala to only support timezones that work in Hive

2018-05-24 Thread Csaba Ringhofer (Code Review)
Hello Jim Apple, Attila Jeges, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10486 to look at the new patch set (#2). Change subject: IMPALA-7060: Restrict Impala to only support timezones that work in Hive

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-18 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10116 to look at the new patch set (#13). Change subject: IMPALA-6131: Track time of last statistics update in metadata

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10116 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10116 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-7060: Restrict Impala to only support timezones that work in Hive

2018-05-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10486 Change subject: IMPALA-7060: Restrict Impala to only support timezones that work in Hive .. IMPALA-7060: Restrict Impala to only

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-06-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 14: Code-Review+2 (5 comments) Thanks for thinking

[Impala-ASF-CR] IMPALA-7169: Prevent HDFS from checkpointing trash until 3000 AD

2018-06-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10742 ) Change subject: IMPALA-7169: Prevent HDFS from checkpointing trash until 3000 AD .. Patch Set 2: Code-Review+2 The flakiness

[Impala-ASF-CR] IMPALA-7181: Fix flaky test shell/test shell commandline.py::TestImpalaShell::test socket opening

2018-06-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10747 ) Change subject: IMPALA-7181: Fix flaky test shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening .. Patch Set 1:

[Impala-ASF-CR] IMPALA-7181: Fix flaky test shell/test shell commandline.py::TestImpalaShell::test socket opening

2018-06-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10747 ) Change subject: IMPALA-7181: Fix flaky test shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening .. Patch Set 2:

[Impala-ASF-CR] IMPALA-7181: Fix flaky test shell/test shell commandline.py::TestImpalaShell::test socket opening

2018-06-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10747 ) Change subject: IMPALA-7181: Fix flaky test shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening .. Patch Set 3:

[Impala-ASF-CR] IMPALA-7169: Prevent HDFS from checkpointing trash until 3000 AD

2018-06-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10742 ) Change subject: IMPALA-7169: Prevent HDFS from checkpointing trash until 3000 AD .. Patch Set 2: fyi, the build failure is related

[Impala-ASF-CR] IMPALA-7175: deflake check for failed impalad

2018-06-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10745 ) Change subject: IMPALA-7175: deflake check for failed impalad .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6835: Add table name and node id to Kudu scanner errors

2018-06-13 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10671 ) Change subject: IMPALA-6835: Add table name and node id to Kudu scanner errors .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-06-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 18: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6408: [DOCS] Add a missing info about SHUFFLE

2018-06-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10685 ) Change subject: IMPALA-6408: [DOCS] Add a missing info about SHUFFLE .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] Fail cleanly when in process server can't bind

2018-06-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10726 ) Change subject: Fail cleanly when in process server can't bind .. Patch Set 1: Code-Review+1 I thought a bit about not too

[Impala-ASF-CR] IMPALA-7115: set a default THREAD RESERVATION LIMIT value

2018-06-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10628 ) Change subject: IMPALA-7115: set a default THREAD_RESERVATION_LIMIT value .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6835: Improve Kudu scanner error messages to include the table name and the plan node id

2018-06-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10671 ) Change subject: IMPALA-6835: Improve Kudu scanner error messages to include the table name and the plan node id .. Patch Set 1: (5

[Impala-ASF-CR] IMPALA-7417: Remove DCHECKs with unnecessary constraint on dictionary encoding bit width

2018-06-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10683 Change subject: IMPALA-7417: Remove DCHECKs with unnecessary constraint on dictionary encoding bit width .. IMPALA-7417: Remove

[Impala-ASF-CR] [DOCS] Remove duplicate bullet point about null() in UDF data types

2018-06-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10614 ) Change subject: [DOCS] Remove duplicate bullet point about null() in UDF data types .. Patch Set 1: I have just bumped into this

[Impala-ASF-CR] [DOCS] Remove duplicate bullet point about null() in UDF data types

2018-06-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10614 Change subject: [DOCS] Remove duplicate bullet point about null() in UDF data types .. [DOCS] Remove duplicate bullet point about

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-06-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 11: (2 comments) Thanks for adding zip support! We

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-05-28 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 10: I do not see any more low hanging fruits for

[Impala-ASF-CR] IMPALA-7060: Restrict Impala to only support timezones that work in Hive

2018-06-01 Thread Csaba Ringhofer (Code Review)
Hello Jim Apple, Attila Jeges, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10486 to look at the new patch set (#4). Change subject: IMPALA-7060: Restrict Impala to only support timezones that work in Hive

[Impala-ASF-CR] IMPALA-7060: Restrict Impala to only support timezones that work in Hive

2018-06-04 Thread Csaba Ringhofer (Code Review)
Hello Jim Apple, Attila Jeges, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10486 to look at the new patch set (#5). Change subject: IMPALA-7060: Restrict Impala to only support timezones that work in Hive

[Impala-ASF-CR] IMPALA-3307: Add support for IANA time-zone db

2018-06-04 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9986 ) Change subject: IMPALA-3307: Add support for IANA time-zone db .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-7060: Restrict Impala to only support timezones that work in Hive

2018-06-04 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10486 ) Change subject: IMPALA-7060: Restrict Impala to only support timezones that work in Hive .. Patch Set 4: (2 comments)

[Impala-ASF-CR] WIP IMPALA-7178: Add the possibility to reduce logging for common data errors

2018-06-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10793 ) Change subject: WIP IMPALA-7178: Add the possibility to reduce logging for common data errors .. Patch Set 1: (2 comments)

[Impala-ASF-CR] WIP IMPALA-7178: Add the possibility to reduce logging for common data errors

2018-06-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10793 ) Change subject: WIP IMPALA-7178: Add the possibility to reduce logging for common data errors .. Patch Set 1: (2 comments) Thanks

[Impala-ASF-CR] IMPALA-7190: Remove unsupported format writer support

2018-06-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10823 ) Change subject: IMPALA-7190: Remove unsupported format writer support .. Patch Set 1: Code-Review+1 (2 comments) Some minor

[Impala-ASF-CR] [DOCS] Update to the workaround for IMPALA-3316

2018-06-25 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10800 ) Change subject: [DOCS] Update to the workaround for IMPALA-3316 .. Patch Set 1: (1 comment)

[Impala-ASF-CR] [DOCS] Update to the workaround for IMPALA-3316

2018-06-25 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10800 ) Change subject: [DOCS] Update to the workaround for IMPALA-3316 .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] WIP IMPALA-7178: Add the possibility to reduce logging for common data errors

2018-06-25 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10793 ) Change subject: WIP IMPALA-7178: Add the possibility to reduce logging for common data errors .. Patch Set 1: Thanks for the

[Impala-ASF-CR] IMPALA-7181: Fix flaky test shell/test shell commandline.py::TestImpalaShell::test socket opening

2018-06-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10747 ) Change subject: IMPALA-7181: Fix flaky test shell/test_shell_commandline.py::TestImpalaShell::test_socket_opening .. Patch Set 6:

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-02 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10116 to look at the new patch set (#6). Change subject: IMPALA-6131: Track time of last statistics update in metadata

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-02 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10116 to look at the new patch set (#5). Change subject: IMPALA-6131: Track time of last statistics update in metadata

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10116 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. Patch Set 7: (6 comments)

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-05-02 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10116 to look at the new patch set (#7). Change subject: IMPALA-6131: Track time of last statistics update in metadata

[Impala-ASF-CR] IMPALA-6946: handle negative counts in RLE decoder

2018-05-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10233 ) Change subject: IMPALA-6946: handle negative counts in RLE decoder .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-6946: handle negative counts in RLE decoder

2018-05-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10233 ) Change subject: IMPALA-6946: handle negative counts in RLE decoder .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-04-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10116 ) Change subject: IMPALA-6131: Track time of last statistics update in metadata .. Patch Set 4: (11 comments) I do not consider this

[Impala-ASF-CR] IMPALA-6131: Track time of last statistics update in metadata

2018-04-26 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10116 to look at the new patch set (#4). Change subject: IMPALA-6131: Track time of last statistics update in metadata

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-01-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5736: [DOCS] Document --query option for impala-shell

2018-01-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8771 ) Change subject: IMPALA-5736: [DOCS] Document --query_option for impala-shell .. Patch Set 3: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-01-15 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Gabor Kaszab, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8400 to look at the new patch set (#8). Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-01-15 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Gabor Kaszab, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8400 to look at the new patch set (#7). Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-01-17 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Gabor Kaszab, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8400 to look at the new patch set (#10). Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-01-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8400 ) Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT .. Patch Set 6: (6 comments)

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-01-17 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Gabor Kaszab, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8400 to look at the new patch set (#9). Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

[Impala-ASF-CR] IMPALA-4315: Allow USE and SHOW TABLES if the user has only column privileges

2018-01-16 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8973 ) Change subject: IMPALA-4315: Allow USE and SHOW TABLES if the user has only column privileges .. Patch Set 3: > Why do you say that

[Impala-ASF-CR] IMPALA-5801: [draft] Clean up codegen GetType() interface

2018-01-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9063 Change subject: IMPALA-5801: [draft] Clean up codegen GetType() interface .. IMPALA-5801: [draft] Clean up codegen GetType() interface

[Impala-ASF-CR] IMPALA-5801: [draft] Clean up codegen GetType() interface

2018-01-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: [draft] Clean up codegen GetType() interface .. Patch Set 1: (3 comments) The declarations of the

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-01-18 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Gabor Kaszab, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8400 to look at the new patch set (#11). Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-01-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8400 ) Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-01-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8400 ) Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT .. Patch Set 7: (7 comments) I have overwritten

[Impala-ASF-CR] IMPALA-5801: [draft] Clean up codegen GetType() interface

2018-01-23 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9063 to look at the new patch set (#2). Change subject: IMPALA-5801: [draft] Clean up codegen GetType() interface

[Impala-ASF-CR] IMPALA-5801: [draft] Clean up codegen GetType() interface

2018-01-23 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9063 to look at the new patch set (#3). Change subject: IMPALA-5801: [draft] Clean up codegen GetType() interface

[Impala-ASF-CR] IMPALA-5801: [draft] Clean up codegen GetType() interface

2018-01-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 ) Change subject: IMPALA-5801: [draft] Clean up codegen GetType() interface .. Patch Set 3: Patch 3 should have been the part of patch

[Impala-ASF-CR] IMPALA-4315: Allow USE and SHOW TABLES if the user has only column privileges

2018-01-17 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Laszlo Gaal, Gabor Kaszab, Attila Jeges, Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8973 to look at the new patch set (#5). Change subject: IMPALA-4315: Allow USE and SHOW TABLES if the user has

[Impala-ASF-CR] IMPALA-4315: Allow USE and SHOW TABLES if the user has only column privileges

2018-01-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8973 ) Change subject: IMPALA-4315: Allow USE and SHOW TABLES if the user has only column privileges .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-4315: Allow USE and SHOW TABLES if the user has only column privileges

2018-01-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8973 Change subject: IMPALA-4315: Allow USE and SHOW TABLES if the user has only column privileges .. IMPALA-4315: Allow USE and SHOW

[Impala-ASF-CR] IMPALA-5736: [DOCS] Document --query option for impala-shell

2018-01-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8771 ) Change subject: IMPALA-5736: [DOCS] Document --query_option for impala-shell .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-02-07 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Gabor Kaszab, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8400 to look at the new patch set (#12). Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-02-07 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Gabor Kaszab, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8400 to look at the new patch set (#13). Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2018-02-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8400 ) Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT .. Patch Set 11: (6 comments)

[Impala-ASF-CR] IMPALA-5801: Clean up codegen GetType() interface

2018-02-08 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9063 to look at the new patch set (#4). Change subject: IMPALA-5801: Clean up codegen GetType() interface

  1   2   3   4   5   >