[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-09-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-09-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-09-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8038/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-09-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-09-21 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-09-21 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7954 to look at the new patch set (#3). Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala

[Impala-ASF-CR] IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals

2017-09-13 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded a new change for review. http://gerrit.cloudera.org:8080/8051 Change subject: IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals .. IMPALA-5668: Fix cast(X as timestamp) for

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-09-22 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-09-21 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7954 to look at the new patch set (#4). Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-09-21 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals

2017-10-02 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8051 to look at the new patch set (#2). Change subject: IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-04 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 10: The fe/ files should not be in the

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-04 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 9: (4 comments)

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 11: (3 comments)

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-10 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7954 to look at the new patch set (#13). Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-10 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7954 to look at the new patch set (#14). Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-10 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Matthew Jacobs, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8038 to look at the new patch set (#4). Change subject: IMPALA-5736: Add impala-shell argument to set default query options

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-10 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 3: (10 comments)

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-13 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Matthew Jacobs, Philip Zeyliger, anujphadke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8038 to look at the new patch set (#7). Change subject: IMPALA-5736: Add impala-shell argument to set default query options

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-06 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7954 to look at the new patch set (#12). Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-13 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-09-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded a new patch set (#2). Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. IMPALA-5664: Unix time to timestamp conversions may crash Impala

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-09-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 2: (11 comments) http://gerrit.cloudera.org:8080/#/c/7954/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-09-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded a new change for review. http://gerrit.cloudera.org:8080/8038 Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. IMPALA-5736: Add impala-shell argument to set

[Impala-ASF-CR] IMPALA-5983: Fix crash in to/from utc timestamp("10:00:00", 'MSK')

2017-09-26 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8139 Change subject: IMPALA-5983: Fix crash in to/from_utc_timestamp("10:00:00", 'MSK') .. IMPALA-5983: Fix crash in

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-09-28 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Matthew Jacobs, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8038 to look at the new patch set (#2). Change subject: IMPALA-5736: Add impala-shell argument to set default query options

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-09-28 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 2: I will add unit tests if the

[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 bahavior to help string for 'minidump path' flag

2017-09-28 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8164 Change subject: IMPALA-4736: Add SIGUSR1 bahavior to help string for 'minidump_path' flag .. IMPALA-4736: Add SIGUSR1 bahavior to

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-09-28 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Matthew Jacobs, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8038 to look at the new patch set (#3). Change subject: IMPALA-5736: Add impala-shell argument to set default query options

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-02 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7954 to look at the new patch set (#9). Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump path' flag

2017-10-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8164 ) Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag .. Patch Set 6: (1 comment) Can you

[Impala-ASF-CR] IMPALA-5983: Fix crash in to/from utc timestamp("10:00:00", 'MSK')

2017-10-02 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8139 to look at the new patch set (#4). Change subject: IMPALA-5983: Fix crash in to/from_utc_timestamp("10:00:00", 'MSK')

[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump path' flag

2017-09-29 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8164 to look at the new patch set (#2). Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-09-29 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump path' flag

2017-09-29 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8164 to look at the new patch set (#3). Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag

[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump path' flag

2017-09-29 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8164 to look at the new patch set (#5). Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag

[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump path' flag

2017-09-29 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8164 to look at the new patch set (#4). Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag

[Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump path' flag

2017-09-29 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8164 ) Change subject: IMPALA-4736: Add SIGUSR1 behavior to help string for 'minidump_path' flag .. Patch Set 4: Would it be a good idea

[Impala-ASF-CR] IMPALA-5983: Fix crash in to/from utc timestamp("10:00:00", 'MSK')

2017-10-03 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8139 ) Change subject: IMPALA-5983: Fix crash in to/from_utc_timestamp("10:00:00", 'MSK') .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash impala (boost exception)

2017-09-04 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded a new change for review. http://gerrit.cloudera.org:8080/7954 Change subject: IMPALA-5664: Unix time to timestamp conversions may crash impala (boost exception) .. IMPALA-5664: Unix time to

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-04 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7954 to look at the new patch set (#10). Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-04 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7954 to look at the new patch set (#11). Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-06 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 11: (5 comments)

[Impala-ASF-CR] IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals

2017-10-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8051 ) Change subject: IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals .. Patch Set 2: (6 comments)

[Impala-ASF-CR] IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals

2017-10-11 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8051 to look at the new patch set (#4). Change subject: IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals

[Impala-ASF-CR] IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals

2017-10-11 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8051 ) Change subject: IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals

2017-10-11 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8051 to look at the new patch set (#3). Change subject: IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals

[Impala-ASF-CR] IMPALA-5983: Fix crash in to/from utc timestamp("10:00:00", 'MSK')

2017-09-27 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8139 to look at the new patch set (#2). Change subject: IMPALA-5983: Fix crash in to/from_utc_timestamp("10:00:00", 'MSK')

[Impala-ASF-CR] IMPALA-5983: Fix crash in to/from utc timestamp("10:00:00", 'MSK')

2017-09-27 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8139 ) Change subject: IMPALA-5983: Fix crash in to/from_utc_timestamp("10:00:00", 'MSK') .. Patch Set 2: > Thanks for fixing this. Can

[Impala-ASF-CR] IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals

2017-10-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8051 ) Change subject: IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 15: I have checked the output of

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-12 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Matthew Jacobs, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8038 to look at the new patch set (#5). Change subject: IMPALA-5736: Add impala-shell argument to set default query options

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-12 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Matthew Jacobs, Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8038 to look at the new patch set (#6). Change subject: IMPALA-5736: Add impala-shell argument to set default query options

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-12 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 4: (10 comments)

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 15: > Csaba, are those failing tests

[Impala-ASF-CR] IMPALA-4918: Support getting column comments via HS2

2017-10-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8315 Change subject: IMPALA-4918: Support getting column comments via HS2 .. IMPALA-4918: Support getting column comments via HS2 Fill the

[Impala-ASF-CR] IMPALA-4918: Support getting column comments via HS2

2017-10-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8315 ) Change subject: IMPALA-4918: Support getting column comments via HS2 .. IMPALA-4918: Support getting column comments via HS2 Fill the

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-20 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/7954 ) Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 17: (1 comment)

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8447 ) Change subject: IMPALA-2181: Add query option levels for display .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction

2017-11-13 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8436 to look at the new patch set (#5). Change subject: IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction

[Impala-ASF-CR] IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction

2017-11-13 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8436 ) Change subject: IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-5624: ProcessStateInfo::ReadProcFileDescriptorInfo() should not fork a process

2017-11-14 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8546 Change subject: IMPALA-5624: ProcessStateInfo::ReadProcFileDescriptorInfo() should not fork a process .. IMPALA-5624:

[Impala-ASF-CR] IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction

2017-11-03 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8436 to look at the new patch set (#4). Change subject: IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction

[Impala-ASF-CR] IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction

2017-11-03 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8436 ) Change subject: IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction .. Patch Set 1: (7 comments)

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8447 ) Change subject: IMPALA-2181: Add query option levels for display .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-11-02 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Michael Brown, Matthew Jacobs, Philip Zeyliger, anujphadke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8038 to look at the new patch set (#18). Change subject: IMPALA-5736: Add impala-shell argument to set

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-11-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 18: > Csaba, it's hard to see, but

[Impala-ASF-CR] IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction

2017-11-02 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8436 ) Change subject: IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-2181: Add query option levels for display

2017-11-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8447 ) Change subject: IMPALA-2181: Add query option levels for display .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-2248: Make idle session timeout a query option

2017-11-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 ) Change subject: IMPALA-2248: Make idle_session_timeout a query option .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2017-11-08 Thread Csaba Ringhofer (Code Review)
Hello Gabor Kaszab, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8400 to look at the new patch set (#3). Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2017-11-08 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8400 ) Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT .. IMPALA-4167: Support insert plan hints for CREATE

[Impala-ASF-CR] IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction

2017-11-03 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8436 to look at the new patch set (#2). Change subject: IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction

[Impala-ASF-CR] IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction

2017-11-03 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8436 to look at the new patch set (#3). Change subject: IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-25 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 14: (2 comments)

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-25 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Michael Brown, Matthew Jacobs, Philip Zeyliger, anujphadke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8038 to look at the new patch set (#15). Change subject: IMPALA-5736: Add impala-shell argument to set default query options

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-24 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 14: (3 comments) Sorry for the

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-24 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Michael Brown, Matthew Jacobs, Philip Zeyliger, anujphadke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8038 to look at the new patch set (#13). Change subject: IMPALA-5736: Add impala-shell argument to set default query options

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-24 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Michael Brown, Matthew Jacobs, Philip Zeyliger, anujphadke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8038 to look at the new patch set (#12). Change subject: IMPALA-5736: Add impala-shell argument to set default query options

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-24 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Michael Brown, Matthew Jacobs, Philip Zeyliger, anujphadke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8038 to look at the new patch set (#14). Change subject: IMPALA-5736: Add impala-shell argument to set default query options

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-30 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 16: (6 comments) > (6 comments)

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-30 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 17: > You've received several +1s

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-30 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Michael Brown, Matthew Jacobs, Philip Zeyliger, anujphadke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8038 to look at the new patch set (#16). Change subject: IMPALA-5736: Add impala-shell argument to set default query options

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-30 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Michael Brown, Matthew Jacobs, Philip Zeyliger, anujphadke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8038 to look at the new patch set (#17). Change subject: IMPALA-5736: Add impala-shell argument to set default query options

[Impala-ASF-CR] IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction

2017-10-31 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8436 Change subject: IMPALA-6054: Parquet dictionary pages should be freed on dictionary construction .. IMPALA-6054: Parquet dictionary

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-10-20 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Alex Behm, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7954 to look at the new patch set (#16). Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-19 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Michael Brown, Matthew Jacobs, Philip Zeyliger, anujphadke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8038 to look at the new patch set (#8). Change subject: IMPALA-5736: Add impala-shell argument to set default query options

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 8: (11 comments)

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-19 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Michael Brown, Matthew Jacobs, Philip Zeyliger, anujphadke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8038 to look at the new patch set (#9). Change subject: IMPALA-5736: Add impala-shell argument to set default query options

[Impala-ASF-CR] IMPALA-4918: Support getting column comments via HS2

2017-10-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8315 ) Change subject: IMPALA-4918: Support getting column comments via HS2 .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-19 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-19 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Michael Brown, Matthew Jacobs, Philip Zeyliger, anujphadke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8038 to look at the new patch set (#10). Change subject: IMPALA-5736: Add impala-shell argument to set default query options

[Impala-ASF-CR] IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals

2017-10-20 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8051 to look at the new patch set (#5). Change subject: IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals

[Impala-ASF-CR] IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals

2017-10-20 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8051 ) Change subject: IMPALA-5668: Fix cast(X as timestamp) for negative subsecond Decimals .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-20 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Michael Brown, Matthew Jacobs, Philip Zeyliger, anujphadke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8038 to look at the new patch set (#11). Change subject: IMPALA-5736: Add impala-shell argument to set default query options

[Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options

2017-10-20 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8038 ) Change subject: IMPALA-5736: Add impala-shell argument to set default query options .. Patch Set 7: (2 comments)