[kudu-CR] KUDU-1113 pushed predicates not displaying on scans web page

2016-09-06 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4206 to look at the new patch set (#2). Change subject: KUDU-1113 pushed predicates not displaying on scans web page ..

[kudu-CR] KUDU-1113 pushed predicates not displaying on scans web page

2016-09-06 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1113 pushed predicates not displaying on scans web page .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3232/ -- To view, visit

[kudu-CR] KUDU-1113 pushed predicates not displaying on scans web page

2016-09-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1113 pushed predicates not displaying on scans web page .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-1582. Optimize budgeted compaction policy with an approximation

2016-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1582. Optimize budgeted compaction policy with an approximation .. Patch Set 2: (9 comments)

[kudu-CR] KUDU-1582. Optimize budgeted compaction policy with an approximation

2016-09-06 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4153 to look at the new patch set (#3). Change subject: KUDU-1582. Optimize budgeted compaction policy with an approximation

[kudu-CR] compaction policy: fix bound calculation

2016-09-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: compaction_policy: fix bound calculation .. Patch Set 2: anyway to add a simple test? -- To view, visit http://gerrit.cloudera.org:8080/4152 To

[kudu-CR] KUDU-1590. Fix cache-test failure on some machines

2016-09-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1590. Fix cache-test failure on some machines .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] KUDU-1582. Optimize budgeted compaction policy with an approximation

2016-09-06 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1582. Optimize budgeted compaction policy with an approximation .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3240/ -- To view,

[kudu-CR] KUDU-1590. Fix cache-test failure on some machines

2016-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1590. Fix cache-test failure on some machines .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4321/1/src/kudu/util/cache-test.cc File

[kudu-CR] KUDU-1590. Fix cache-test failure on some machines

2016-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1590. Fix cache-test failure on some machines .. KUDU-1590. Fix cache-test failure on some machines CacheTest.TestEviction was failing on some

[kudu-CR] KUDU-668. log block manager should tolerate empty metadata

2016-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-668. log block manager should tolerate empty metadata .. KUDU-668. log block manager should tolerate empty metadata This solves a commonly seen

[kudu-CR] compaction policy: fix bound calculation

2016-09-06 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: compaction_policy: fix bound calculation .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3242/ -- To view, visit

[kudu-CR] KUDU-1582. Optimize budgeted compaction policy with an approximation

2016-09-06 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1582. Optimize budgeted compaction policy with an approximation .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/3243/ -- To view,

[kudu-CR] KUDU-1582. Optimize budgeted compaction policy with an approximation

2016-09-06 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4153 to look at the new patch set (#4). Change subject: KUDU-1582. Optimize budgeted compaction policy with an approximation

[kudu-CR] compaction policy: avoid O(n^2) calls to EstimateOnDiskSize

2016-09-06 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: compaction_policy: avoid O(n^2) calls to EstimateOnDiskSize .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3244/ -- To view, visit

[kudu-CR] docs: fix list of support encodings

2016-09-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: docs: fix list of support encodings .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4322 To unsubscribe, visit

[kudu-CR] consensus: improve log messages for lagging or tablet-copying peers

2016-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: improve log messages for lagging or tablet-copying peers .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

2016-09-06 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4315 to look at the new patch set (#2). Change subject: KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

[kudu-CR] KUDU-1582. Optimize budgeted compaction policy with an approximation

2016-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1582. Optimize budgeted compaction policy with an approximation .. Patch Set 3: (2 comments)

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-06 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: API and style improvements to the Kudu Flume Sink .. Patch Set 1: I also added Ara to the review in case he has input on this -- To view, visit

[kudu-CR] KUDU-1582. Optimize budgeted compaction policy with an approximation

2016-09-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1582. Optimize budgeted compaction policy with an approximation .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] log util: downgrade scary "missing footer" message to INFO

2016-09-06 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: log_util: downgrade scary "missing footer" message to INFO .. log_util: downgrade scary "missing footer" message to INFO In most cases if a Kudu server

[kudu-CR] docs: fix list of support encodings

2016-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/4322 Change subject: docs: fix list of support encodings .. docs: fix list of support encodings Change-Id:

[kudu-CR] docs: fix list of support encodings

2016-09-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: docs: fix list of support encodings .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4322/1/docs/schema_design.adoc File docs/schema_design.adoc:

[kudu-CR] Predicate evaluation pushdown

2016-09-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 10: (8 comments) http://gerrit.cloudera.org:8080/#/c/3990/10/src/kudu/cfile/cfile-test-base.h File

[kudu-CR] docs: fix list of support encodings

2016-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: docs: fix list of support encodings .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4322/1/docs/schema_design.adoc File docs/schema_design.adoc:

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-06 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Cleanup/refactor tracking of consensus watermarks .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/3252/ -- To view, visit

[kudu-CR] Cleanup/refactor tracking of consensus watermarks

2016-09-06 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4133 to look at the new patch set (#6). Change subject: Cleanup/refactor tracking of consensus watermarks

[kudu-CR] Patch resolves KUDU-1593. Modified Client.create table to expose the num replicas method of the KuduTableCreator class.

2016-09-06 Thread Anonymous Coward (Code Review)
jordantbirds...@gmail.com has uploaded a new change for review. http://gerrit.cloudera.org:8080/4315 Change subject: Patch resolves KUDU-1593. Modified Client.create_table to expose the num_replicas method of the KuduTableCreator class.

[kudu-CR] Patch resolves KUDU-1593. Modified Client.create table to expose the num replicas method of the KuduTableCreator class.

2016-09-06 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Patch resolves KUDU-1593. Modified Client.create_table to expose the num_replicas method of the KuduTableCreator class. .. Patch Set 1: Build Started

[kudu-CR] Patch resolves KUDU-1593. Modified Client.create table to expose the num replicas method of the KuduTableCreator class.

2016-09-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Patch resolves KUDU-1593. Modified Client.create_table to expose the num_replicas method of the KuduTableCreator class. .. Patch Set 1: (6 comments)

[kudu-CR] [WIP] KUDU-861 Support changing default, storage attributes

2016-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [WIP] KUDU-861 Support changing default, storage attributes .. Patch Set 3: No problem putting a patch up for it. It was assigned to me for more than a year with

[kudu-CR] [c++ client] AUTO FLUSH BACKGROUND optimizations

2016-09-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [c++ client] AUTO_FLUSH_BACKGROUND optimizations .. Patch Set 1: (2 comments) The Java client uses 50% too so even if the performance didn't change having that

[kudu-CR] KUDU-1113 pushed predicates not displaying on scans web page

2016-09-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1113 pushed predicates not displaying on scans web page .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4206 To unsubscribe,

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/4164/4/src/kudu/common/column_predicate.cc File

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-06 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/4164/4/src/kudu/common/column_predicate.cc File

[kudu-CR] KUDU-1113 pushed predicates not displaying on scans web page

2016-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1113 pushed predicates not displaying on scans web page .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4206 To unsubscribe,

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-06 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: API and style improvements to the Kudu Flume Sink .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3237/ -- To view, visit

[kudu-CR] API and style improvements to the Kudu Flume Sink

2016-09-06 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/4320 Change subject: API and style improvements to the Kudu Flume Sink .. API and style improvements to the Kudu Flume Sink This patch

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-06 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/3236/ -- To view, visit

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-06 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4164 to look at the new patch set (#5). Change subject: Inlined dispatch for predicate evaluation .. Inlined dispatch

[kudu-CR] Predicate evaluation pushdown

2016-09-06 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 10: Build Started http://104.196.14.100/job/kudu-gerrit/3235/ -- To view, visit http://gerrit.cloudera.org:8080/3990

[kudu-CR] docs: workflow for master migration

2016-09-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: docs: workflow for master migration .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4300/1/docs/administration.adoc File

[kudu-CR] compaction policy: fix bound calculation

2016-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: compaction_policy: fix bound calculation .. Patch Set 2: The tests in the next commit actually catch this bug. If I revert this patch and run the test from

[kudu-CR] KUDU-1590. Fix cache-test failure on some machines

2016-09-06 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1590. Fix cache-test failure on some machines .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3238/ -- To view, visit

[kudu-CR] KUDU-1590. Fix cache-test failure on some machines

2016-09-06 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4321 to review the following change. Change subject: KUDU-1590. Fix cache-test failure on some machines .. KUDU-1590. Fix

[kudu-CR] KUDU-668. log block manager should tolerate empty metadata

2016-09-06 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-668. log block manager should tolerate empty metadata .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4178 To unsubscribe,

[kudu-CR] KUDU-1582. Optimize budgeted compaction policy with an approximation

2016-09-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1582. Optimize budgeted compaction policy with an approximation .. Patch Set 3: (2 comments)

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list (WIP)

2016-09-06 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list (WIP) .. Patch Set 1: (7 comments) TFTR Adar, updated the patch, please re-review, also added some more tests. I

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list (WIP)

2016-09-06 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list (WIP) .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3249/ -- To view, visit

[kudu-CR] c++ client: expose private GetTablet API

2016-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: c++ client: expose private GetTablet API .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4179 To unsubscribe, visit

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-06 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4164 to look at the new patch set (#7). Change subject: Inlined dispatch for predicate evaluation .. Inlined dispatch

[kudu-CR] Predicate evaluation pushdown

2016-09-06 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#12). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list (WIP)

2016-09-06 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: port kudu-fs_dump, remove kudu-fs_list (WIP) .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3253/ -- To view, visit

[kudu-CR] tool: port kudu-fs dump, remove kudu-fs list (WIP)

2016-09-06 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4305 to look at the new patch set (#3). Change subject: tool: port kudu-fs_dump, remove kudu-fs_list (WIP)

[kudu-CR] KUDU-1513. consensus: improve log messages for lagging or tablet-copying peers

2016-09-06 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1513. consensus: improve log messages for lagging or tablet-copying peers .. Patch Set 2: Code-Review+2 Verified+1 -- To view, visit

[kudu-CR] KUDU-1513. consensus: improve log messages for lagging or tablet-copying peers

2016-09-06 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1513. consensus: improve log messages for lagging or tablet-copying peers .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3246/ -- To

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-06 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4164 to look at the new patch set (#6). Change subject: Inlined dispatch for predicate evaluation .. Inlined dispatch

[kudu-CR] Predicate evaluation pushdown

2016-09-06 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Predicate evaluation pushdown .. Patch Set 11: Build Started http://104.196.14.100/job/kudu-gerrit/3247/ -- To view, visit http://gerrit.cloudera.org:8080/3990

[kudu-CR] Predicate evaluation pushdown

2016-09-06 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3990 to look at the new patch set (#11). Change subject: Predicate evaluation pushdown .. Predicate evaluation pushdown

[kudu-CR] Inlined dispatch for predicate evaluation

2016-09-06 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Inlined dispatch for predicate evaluation .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/3248/ -- To view, visit

[kudu-CR] compaction policy: avoid O(n^2) calls to EstimateOnDiskSize

2016-09-06 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: compaction_policy: avoid O(n^2) calls to EstimateOnDiskSize .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4191 To