[kudu-CR] consensus: refactor tracking of received OpIds out of ReplicaState

Todd Lipcon has posted comments on this change. Change subject: consensus: refactor tracking of received OpIds out of ReplicaState .. Patch Set 1: (4 comments)

[kudu-CR] kernel stack watchdog: avoid blocking threads starting

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4626 to look at the new patch set (#2). Change subject: kernel_stack_watchdog: avoid blocking threads starting ..

[kudu-CR] raft consensus: clean up overrides, protected methods

David Ribeiro Alves has posted comments on this change. Change subject: raft_consensus: clean up overrides, protected methods .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4620 To

[kudu-CR] Add script to run clang-tidy against a patch

Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4381 to look at the new patch set (#3). Change subject: Add script to run clang-tidy against a patch .. Add

[kudu-CR] [python] - Expand gitignore for python

Todd Lipcon has posted comments on this change. Change subject: [python] - Expand gitignore for python .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4616 To unsubscribe, visit

[kudu-CR] [python] - Expand gitignore for python

Todd Lipcon has submitted this change and it was merged. Change subject: [python] - Expand gitignore for python .. [python] - Expand gitignore for python Adding additional exclusion rules for python to .gitignore. Change-Id:

[kudu-CR] Separate tablet MM ops into separate .cc file

Todd Lipcon has posted comments on this change. Change subject: Separate tablet MM ops into separate .cc file .. Patch Set 6: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4362 To unsubscribe,

[kudu-CR] Separate tablet MM ops into separate .cc file

Todd Lipcon has submitted this change and it was merged. Change subject: Separate tablet MM ops into separate .cc file .. Separate tablet MM ops into separate .cc file tablet.cc is a monster, no need for this in there. Plus,

[kudu-CR] mem tracker: fix race between FindTracker() and destructor

Todd Lipcon has posted comments on this change. Change subject: mem_tracker: fix race between FindTracker() and destructor .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

Todd Lipcon has posted comments on this change. Change subject: KUDU-1563. Add support for INSERT IGNORE .. Patch Set 8: Yep, check out the RANGE_PARTITION_BOUNDS feature for an example -- To view, visit

[kudu-CR] [java client] Rename NoLeaderMasterFoundException and reuse

Dan Burkert has posted comments on this change. Change subject: [java client] Rename NoLeaderMasterFoundException and reuse .. Patch Set 1: Code-Review+2 I'm assuming you want to keep around NoSuitableReplicaException for

[kudu-CR] [java client] Tight-ish loop in master lookups if a tablet doesn't have a leader

Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Tight-ish loop in master lookups if a tablet doesn't have a leader .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4594 to look at the new patch set (#3). Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

[kudu-CR] [c++ client] notes for timestamp-related methods

David Ribeiro Alves has posted comments on this change. Change subject: [c++ client] notes for timestamp-related methods .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/4569/5/src/kudu/client/client.h File

[kudu-CR](branch-1.0.x) KUDU-1652 (part 2): Filter IS NOT NULL predicates from scan on client

Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1652 (part 2): Filter IS NOT NULL predicates from scan on client .. KUDU-1652 (part 2): Filter IS NOT NULL predicates from scan on client Part 1

[kudu-CR] [client-test] added basic test for RWYW behavior

Alexey Serbin has posted comments on this change. Change subject: [client-test] added basic test for RWYW behavior .. Patch Set 2: (1 comment) > As I had suggested if you made so that the test always failed, we > could merge

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

Dinesh Bhat has posted comments on this change. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone .. Patch Set 2: (1 comment)

[kudu-CR](branch-1.0.x) KUDU-1652 (part 2): Filter IS NOT NULL predicates from scan on client

Dan Burkert has posted comments on this change. Change subject: KUDU-1652 (part 2): Filter IS NOT NULL predicates from scan on client .. Patch Set 1: Code-Review+2 Verified+1 Going to manually verify so that it doesn't mess

[kudu-CR] KUDU-1652 (part 2): Filter IS NOT NULL predicates from scan on client

Adar Dembo has posted comments on this change. Change subject: KUDU-1652 (part 2): Filter IS NOT NULL predicates from scan on client .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4612 To

[kudu-CR] KUDU-1652 (part 2): Filter IS NOT NULL predicates from scan on client

Dan Burkert has posted comments on this change. Change subject: KUDU-1652 (part 2): Filter IS NOT NULL predicates from scan on client .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4612 To

[kudu-CR] Reintroduce TSAN suppression for epoll ctl

Dan Burkert has posted comments on this change. Change subject: Reintroduce TSAN suppression for epoll_ctl .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4618 To unsubscribe, visit

[kudu-CR] KUDU-1652 (part 2): Filter IS NOT NULL predicates from scan on client

Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1652 (part 2): Filter IS NOT NULL predicates from scan on client .. KUDU-1652 (part 2): Filter IS NOT NULL predicates from scan on client Part 1

[kudu-CR] [java client] Tight-ish loop in master lookups if a tablet doesn't have a leader

Dan Burkert has posted comments on this change. Change subject: [java client] Tight-ish loop in master lookups if a tablet doesn't have a leader .. Patch Set 2: (2 comments) I agree with JD: we routinely find tight loops

[kudu-CR] Reintroduce TSAN suppression for epoll ctl

Dan Burkert has submitted this change and it was merged. Change subject: Reintroduce TSAN suppression for epoll_ctl .. Reintroduce TSAN suppression for epoll_ctl Since 407f95da1254 a few spurious TSAN errors have surfaced from

[kudu-CR] [c++ client] notes for timestamp-related methods

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4569 to look at the new patch set (#5). Change subject: [c++ client] notes for timestamp-related methods .. [c++

[kudu-CR] Reintroduce TSAN suppression for epoll ctl

Todd Lipcon has posted comments on this change. Change subject: Reintroduce TSAN suppression for epoll_ctl .. Patch Set 1: This is starting to come back to me now. There is some craziness with epoll FDs when a child closes

[kudu-CR] [c++ client] notes for timestamp-related methods

Alexey Serbin has posted comments on this change. Change subject: [c++ client] notes for timestamp-related methods .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4569/4/src/kudu/client/client.h File

[kudu-CR] KUDU-1652 (part 2): Filter IS NOT NULL predicates from scan on client

Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1652 (part 2): Filter IS NOT NULL predicates from scan on client .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

Alexey Serbin has posted comments on this change. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone .. Patch Set 2: (1 comment)

[kudu-CR] Reintroduce TSAN suppression for epoll ctl

Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4618 to review the following change. Change subject: Reintroduce TSAN suppression for epoll_ctl .. Reintroduce TSAN

[kudu-CR] Reintroduce TSAN suppression for epoll ctl

Todd Lipcon has posted comments on this change. Change subject: Reintroduce TSAN suppression for epoll_ctl .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4618 To unsubscribe, visit

[kudu-CR] Separate tablet MM ops into separate .cc file

Jean-Daniel Cryans has posted comments on this change. Change subject: Separate tablet MM ops into separate .cc file .. Patch Set 6: Code-Review+2 I didn't run a line-by-line comparison of your copy paste so I assume it's fine

[kudu-CR] KUDU-1640 - [python] Add IN-list predicate support

Dan Burkert has posted comments on this change. Change subject: KUDU-1640 - [python] Add IN-list predicate support .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/4548/6/python/kudu/client.pyx File

[kudu-CR] consensus: refactor tracking of received OpIds out of ReplicaState

Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4476 to look at the new patch set (#2). Change subject: consensus: refactor tracking of received OpIds out of ReplicaState

[kudu-CR] raft consensus: clean up overrides, protected methods

Hello David Ribeiro Alves, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4620 to review the following change. Change subject: raft_consensus: clean up overrides, protected methods

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

Jordan Birdsell has posted comments on this change. Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning .. Patch Set 5: (1 comment)

[kudu-CR] raft consensus: clean up overrides, protected methods

Hello David Ribeiro Alves, Mike Percy, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4620 to look at the new patch set (#2). Change subject: raft_consensus: clean up overrides, protected methods

[kudu-CR] [java client] Tight-ish loop in master lookups if a tablet doesn't have a leader

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4570 to look at the new patch set (#3). Change subject: [java client] Tight-ish loop in master lookups if a tablet doesn't have a leader

[kudu-CR] [java client] Tight-ish loop in master lookups if a tablet doesn't have a leader

Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Tight-ish loop in master lookups if a tablet doesn't have a leader .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

Todd Lipcon has posted comments on this change. Change subject: KUDU-1563. Add support for INSERT IGNORE .. Patch Set 8: (12 comments) What happens if you try to INSERT IGNORE against an older tserver which doesn't support

[kudu-CR](branch-1.0.x) Apache Kudu 1.0.1 Release Notes

Todd Lipcon has posted comments on this change. Change subject: Apache Kudu 1.0.1 Release Notes .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4621 To unsubscribe, visit

[kudu-CR] [c++ client] notes for timestamp-related methods

Alexey Serbin has posted comments on this change. Change subject: [c++ client] notes for timestamp-related methods .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/4569/5/src/kudu/client/client.h File

[kudu-CR] WIP: KUDU-1567. Decouple hard-minimum WAL segment retention from target

Mike Percy has posted comments on this change. Change subject: WIP: KUDU-1567. Decouple hard-minimum WAL segment retention from target .. Patch Set 4: Code-Review+1 reasonable approach -- To view, visit

[kudu-CR] [docs] - Impala Hash Partition Example Correction

Mike Percy has submitted this change and it was merged. Change subject: [docs] - Impala Hash Partition Example Correction .. [docs] - Impala Hash Partition Example Correction The Impala doc has a basic hash partitioning

[kudu-CR] [docs] - Impala Hash Partition Example Correction

Mike Percy has posted comments on this change. Change subject: [docs] - Impala Hash Partition Example Correction .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4615 To unsubscribe,

[kudu-CR] Separate tablet MM ops into separate .cc file

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4362 to look at the new patch set (#6). Change subject: Separate tablet MM ops into separate .cc file .. Separate

[kudu-CR] [python] - Expand gitignore for python

Jordan Birdsell has uploaded a new change for review. http://gerrit.cloudera.org:8080/4616 Change subject: [python] - Expand gitignore for python .. [python] - Expand gitignore for python Adding additional exclusion rules

[kudu-CR] WIP: consensus: refactor tracking of received OpIds out of ReplicaState

Mike Percy has posted comments on this change. Change subject: WIP: consensus: refactor tracking of received OpIds out of ReplicaState .. Patch Set 1: Code-Review+1 (3 comments) looks like a good change

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

Jordan Birdsell has posted comments on this change. Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/4520/4/python/kudu/client.pyx

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4520 to look at the new patch set (#5). Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning ..

[kudu-CR] [docs] - Impala Hash Partition Example Correction

Jordan Birdsell has uploaded a new change for review. http://gerrit.cloudera.org:8080/4615 Change subject: [docs] - Impala Hash Partition Example Correction .. [docs] - Impala Hash Partition Example Correction The Impala doc

[kudu-CR] [java client] Rename NoLeaderMasterFoundException and reuse

Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/4624 Change subject: [java client] Rename NoLeaderMasterFoundException and reuse .. [java client] Rename NoLeaderMasterFoundException

[kudu-CR] WIP: KUDU-1567. Decouple hard-minimum WAL segment retention from target

Todd Lipcon has posted comments on this change. Change subject: WIP: KUDU-1567. Decouple hard-minimum WAL segment retention from target .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4470/4//COMMIT_MSG

[kudu-CR] [java client] Tight-ish loop in master lookups if a tablet doesn't have a leader

Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] Tight-ish loop in master lookups if a tablet doesn't have a leader .. [java client] Tight-ish loop in master lookups if a tablet

[kudu-CR] [java client] Tight-ish loop in master lookups if a tablet doesn't have a leader

Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Tight-ish loop in master lookups if a tablet doesn't have a leader .. Patch Set 3: Verified+1 Dan messed up my build, but I did run all the

[kudu-CR](branch-1.0.x) Apache Kudu 1.0.1 Release Notes

Dan Burkert has submitted this change and it was merged. Change subject: Apache Kudu 1.0.1 Release Notes .. Apache Kudu 1.0.1 Release Notes Change-Id: I16986205e8c29dd42393b4e1b43d44a3fdb4daca Reviewed-on:

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1563. Add support for INSERT IGNORE .. Patch Set 7: looking good, only a few nits and one thing about metrics. thank you for your perseverance .

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

Alexey Serbin has posted comments on this change. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone .. Patch Set 2: (1 comment)

[kudu-CR] WIP: KUDU-1567. Decouple hard-minimum WAL segment retention from target

David Ribeiro Alves has posted comments on this change. Change subject: WIP: KUDU-1567. Decouple hard-minimum WAL segment retention from target .. Patch Set 4: (1 comment)

[kudu-CR] WIP: KUDU-1567. Decouple hard-minimum WAL segment retention from target

David Ribeiro Alves has posted comments on this change. Change subject: WIP: KUDU-1567. Decouple hard-minimum WAL segment retention from target .. Patch Set 4: Code-Review+1 My comment is more of a follow on. +1 "Keep Going"

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1563. Add support for INSERT IGNORE .. Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/4491/8/src/kudu/client/client.cc File

[kudu-CR] KUDU-1640 - [python] Add IN-list predicate support

Jordan Birdsell has posted comments on this change. Change subject: KUDU-1640 - [python] Add IN-list predicate support .. Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/4548/6/python/kudu/client.pyx File

[kudu-CR] kernel stack watchdog: avoid blocking threads starting

Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4626 to review the following change. Change subject: kernel_stack_watchdog: avoid blocking threads starting ..

[kudu-CR] KUDU-1563. Add support for INSERT IGNORE

Brock Noland has posted comments on this change. Change subject: KUDU-1563. Add support for INSERT IGNORE .. Patch Set 8: Thanks for the tip on the RPC thing. Spent some time looking into the RPC system and looks like it's

[kudu-CR] [python] - Expand gitignore for python

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4616 to look at the new patch set (#2). Change subject: [python] - Expand gitignore for python .. [python] - Expand

[kudu-CR] Add support for reinsert encoding on delta files

David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4627 Change subject: Add support for reinsert encoding on delta files .. Add support for reinsert encoding on delta files This adds

[kudu-CR] KUDU-1567. Decouple hard-minimum WAL segment retention from target

Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4470 to look at the new patch set (#5). Change subject: KUDU-1567. Decouple hard-minimum WAL segment retention from target

[kudu-CR] loadgen: allow configuring the number of buckets

Hello David Ribeiro Alves, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4625 to review the following change. Change subject: loadgen: allow configuring the number of buckets

[kudu-CR] KUDU-1567. Decouple hard-minimum WAL segment retention from target

Todd Lipcon has posted comments on this change. Change subject: KUDU-1567. Decouple hard-minimum WAL segment retention from target .. Patch Set 5: Verified+1 test failures are unrelated -- To view, visit

[kudu-CR] KUDU-1640 - [python] Add IN-list predicate support

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4548 to look at the new patch set (#7). Change subject: KUDU-1640 - [python] Add IN-list predicate support .. KUDU-1640

[kudu-CR] KUDU-1671 - [python] Enable predicate pushdown for additional types

Jordan Birdsell has posted comments on this change. Change subject: KUDU-1671 - [python] Enable predicate pushdown for additional types .. Patch Set 3: (5 comments)

[kudu-CR] KUDU-1671 - [python] Enable predicate pushdown for additional types

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4589 to look at the new patch set (#3). Change subject: KUDU-1671 - [python] Enable predicate pushdown for additional types

[kudu-CR] [python] - Expand gitignore for python

Jordan Birdsell has posted comments on this change. Change subject: [python] - Expand gitignore for python .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4616/1/.gitignore File .gitignore: > Since all of

[kudu-CR] [java client] Temporarily ignore row count regressions in ITClient

David Ribeiro Alves has posted comments on this change. Change subject: [java client] Temporarily ignore row count regressions in ITClient .. Patch Set 1: oh and don't forget to point to the umbrella jira (KUDU-430) there are

[kudu-CR] [docs] Python updates for development page

David Ribeiro Alves has posted comments on this change. Change subject: [docs] Python updates for development page .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/4586/1/docs/developing.adoc File

[kudu-CR] [c++ client] notes for timestamp-related methods

David Ribeiro Alves has posted comments on this change. Change subject: [c++ client] notes for timestamp-related methods .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4569/4/src/kudu/client/client.h File

[kudu-CR] [java client] Temporarily ignore row count regressions in ITClient

David Ribeiro Alves has posted comments on this change. Change subject: [java client] Temporarily ignore row count regressions in ITClient .. Patch Set 1: After talking to JD and unserstanding how the test works, I actually

[kudu-CR] [java client] Temporarily ignore row count regressions in ITClient

David Ribeiro Alves has posted comments on this change. Change subject: [java client] Temporarily ignore row count regressions in ITClient .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4597

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

Dinesh Bhat has posted comments on this change. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone

Dinesh Bhat has posted comments on this change. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone .. Patch Set 2: (1 comment)

[kudu-CR] [client-test] added basic test for RWYW behavior

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4583 to look at the new patch set (#2). Change subject: [client-test] added basic test for RWYW behavior ..