[kudu-CR] [client.h] updated comment for CountBufferedOperations

2016-10-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [client.h] updated comment for CountBufferedOperations .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4723/1/src/kudu/client/client.h File

[kudu-CR] [client.h] updated comment for CountBufferedOperations

2016-10-14 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: [client.h] updated comment for CountBufferedOperations .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4723/1/src/kudu/client/client.h File src

[kudu-CR] Commit CSD metrics for 1.0.0 and 1.0.1

2016-10-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Commit CSD metrics for 1.0.0 and 1.0.1 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4695 To unsubscribe, visit http://gerrit.cl

[kudu-CR] [client.h] updated comment for CountBufferedOperations

2016-10-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [client.h] updated comment for CountBufferedOperations .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4723/1/src/kudu/client/client.h File src

[kudu-CR] [client.h] CountBufferedOperations marked as deprecated

2016-10-14 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4723 to look at the new patch set (#3). Change subject: [client.h] CountBufferedOperations marked as deprecated .. [clie

[kudu-CR] [java client] Extract ip2client out of AsyncKuduClient

2016-10-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Extract ip2client out of AsyncKuduClient .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4717 To unsubscribe, visit h

[kudu-CR] Add krb5 to thirdparty

2016-10-14 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4727 to review the following change. Change subject: Add krb5 to thirdparty .. Add krb5 to thirdparty Change-I

[kudu-CR] add 1.0.1 release notes to prior release notes.adoc

2016-10-14 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: add 1.0.1 release notes to prior_release_notes.adoc .. add 1.0.1 release notes to prior_release_notes.adoc Change-Id: Ieff57fd7120e98e2e1a7c0812e6c04eca70

[kudu-CR] Commit CSD metrics for 1.0.0 and 1.0.1

2016-10-14 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Commit CSD metrics for 1.0.0 and 1.0.1 .. Commit CSD metrics for 1.0.0 and 1.0.1 Change-Id: If7e9867289522e0c0c04bcbffaf04fb249589287 Reviewed-on: http://

[kudu-CR] Add krb5 to thirdparty

2016-10-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add krb5 to thirdparty .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4727/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh

[kudu-CR] Add krb5 to thirdparty

2016-10-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add krb5 to thirdparty .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4727/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh

[kudu-CR] Add krb5 to thirdparty

2016-10-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add krb5 to thirdparty .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4727/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh

[kudu-CR] Add krb5 to thirdparty

2016-10-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add krb5 to thirdparty .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4727/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh:

[kudu-CR] Add krb5 to thirdparty

2016-10-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Add krb5 to thirdparty .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4727/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.

[kudu-CR] [java client] Extract ip2client out of AsyncKuduClient

2016-10-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] Extract ip2client out of AsyncKuduClient .. [java client] Extract ip2client out of AsyncKuduClient As part of making the Java client

[kudu-CR] Add krb5 to thirdparty

2016-10-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Add krb5 to thirdparty .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4727/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.

[kudu-CR] Add krb5 to thirdparty

2016-10-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Add krb5 to thirdparty .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4727/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.

[kudu-CR] [java client] Extract RemoteTablet from AsyncKuduClient

2016-10-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Extract RemoteTablet from AsyncKuduClient .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4719 To unsubscribe, visit

[kudu-CR] Add krb5 to thirdparty

2016-10-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add krb5 to thirdparty .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4727/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh

[kudu-CR] [java client] Extract RemoteTablet from AsyncKuduClient

2016-10-14 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] Extract RemoteTablet from AsyncKuduClient .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4719/3/java/kudu-client/src/main/java/org/

[kudu-CR] [java client] Extract RemoteTablet from AsyncKuduClient

2016-10-14 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4719 to look at the new patch set (#4). Change subject: [java client] Extract RemoteTablet from AsyncKuduClient .

[kudu-CR] [java client] Extract RemoteTablet from AsyncKuduClient

2016-10-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Extract RemoteTablet from AsyncKuduClient .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/4719/3/java/kudu-client/src/main/j

[kudu-CR] [java client] Extract RemoteTablet from AsyncKuduClient

2016-10-14 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] Extract RemoteTablet from AsyncKuduClient .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4719 To unsubscribe, visit

[kudu-CR] Improve pmem cmake discovery failure message

2016-10-14 Thread Dan Burkert (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4729 to review the following change. Change subject: Improve pmem cmake discovery failure message .. Improve pmem cmake disc

[kudu-CR] Add krb5 to thirdparty

2016-10-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add krb5 to thirdparty .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4727/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh:

[kudu-CR] Improve pmem cmake discovery failure message

2016-10-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Improve pmem cmake discovery failure message .. Patch Set 1: Patch is fine, but would you mind explaining the significance of the difference in your commit message

[kudu-CR] Add krb5 to thirdparty

2016-10-14 Thread Dan Burkert (Code Review)
Dan Burkert has abandoned this change. Change subject: Add krb5 to thirdparty .. Abandoned We're going to require krb5kdc to be installed on test machines. -- To view, visit http://gerrit.cloudera.org:8080/4727 To unsubscribe

[kudu-CR] Add krb5 to thirdparty

2016-10-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Add krb5 to thirdparty .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4727/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.

[kudu-CR] KUDU-1508: script for testing presence of bug and finding upper bounds

2016-10-14 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4730 to review the following change. Change subject: KUDU-1508: script for testing presence of bug and finding upper bounds ...

[kudu-CR] KUDU-1508: script for testing presence of bug and finding upper bounds

2016-10-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1508: script for testing presence of bug and finding upper bounds .. Patch Set 1: (5 comments) can you write in the commit message or in the test header som

[kudu-CR] consensus peers: a little cleanup of cruft

2016-10-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus_peers: a little cleanup of cruft .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4704/2/src/kudu/consensus/peer_manager.h File src/kudu/

[kudu-CR] consensus: move more logic from ReplicaState to RaftConsensus

2016-10-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: move more logic from ReplicaState to RaftConsensus .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4709/1/src/kudu/consensus/consensus

[kudu-CR] consensus: remove bits of dead code

2016-10-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus: remove bits of dead code .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4712/1/src/kudu/consensus/raft_consensus.cc File src/kudu/cons

[kudu-CR] consensus: remove bits of dead code

2016-10-14 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4712 to look at the new patch set (#2). Change subject: consensus: remove bits of dead code .. consensus: remove bits of

[kudu-CR] ITBLL: use a faster PRNG

2016-10-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/4731 Change subject: ITBLL: use a faster PRNG .. ITBLL: use a faster PRNG The SecureRandom PRNG is very very slow. Since we don't need cryptogr

[kudu-CR] KUDU-1365. Add leader pre-elections

2016-10-14 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4694 to look at the new patch set (#5). Change subject: KUDU-1365. Add leader pre-elections .. KUDU-1365. Ad

[kudu-CR] consensus peers: a little cleanup of cruft

2016-10-14 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4704 to look at the new patch set (#3). Change subject: consensus_peers: a little cleanup of cruft .. consensus_peers: a

[kudu-CR] consensus: split ReplicaState in twain[1]

2016-10-14 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4713 to look at the new patch set (#2). Change subject: consensus: split ReplicaState in twain[1] .. consensus: split Re

[kudu-CR] consensus: move more logic from ReplicaState to RaftConsensus

2016-10-14 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4709 to look at the new patch set (#2). Change subject: consensus: move more logic from ReplicaState to RaftConsensus ..