[kudu-CR] tablet copy: Rename tablet copy session source files

2016-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tablet copy: Rename tablet copy session source files .. Patch Set 1: this seems to need a manual rebase -- To view, visit http://gerrit.cloudera.org:8080/5042

[kudu-CR] tablet copy: Make the StartTabletCopy() RPC async

2016-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 2: (7 comments) > I think we need to run the whole process on the thread pool because if there >

[kudu-CR] KUDU-1189 scans: reuse snapshot timestamp when not set

2016-11-21 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5143 to look at the new patch set (#4). Change subject: KUDU-1189 scans: reuse snapshot timestamp when not set ..

[kudu-CR] Check that the set raw snapshot timestamp is > 0

2016-11-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Check that the set raw snapshot timestamp is > 0 .. Patch Set 1: not sure, nothing changed in the java client, but having the c++ not allow scans at 0

[kudu-CR] Check that the set raw snapshot timestamp is > 0

2016-11-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Check that the set raw snapshot timestamp is > 0 .. Check that the set raw snapshot timestamp is > 0 Commit 06bb52d changed the default (invalid)

[kudu-CR] KUDU-1189 if not set, use timestamp from first server

2016-11-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1189 if not set, use timestamp from first server .. Patch Set 3: (33 comments) http://gerrit.cloudera.org:8080/#/c/5143/3//COMMIT_MSG Commit Message:

[kudu-CR] KUDU-1189 if not set, use timestamp from first server

2016-11-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1189 if not set, use timestamp from first server .. Patch Set 3: (1 comment)

[kudu-CR] tablet copy: Rename TabletCopySession -> TabletCopySourceSession

2016-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tablet copy: Rename TabletCopySession -> TabletCopySourceSession .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5041 To

[kudu-CR] [scan] test for reusing snapshot timestamp when not set

2016-11-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5163 Change subject: [scan] test for reusing snapshot timestamp when not set .. [scan] test for reusing snapshot timestamp when not set

[kudu-CR] tablet copy: Make the StartTabletCopy() RPC async

2016-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: tablet copy: Make the StartTabletCopy() RPC async .. Patch Set 2: This needs a couple of changes, I think: 1. Increase the minimum number of threads on the

[kudu-CR] Check that the set raw snapshot timestamp is > 0

2016-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Check that the set raw snapshot timestamp is > 0 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5155 To unsubscribe, visit

[kudu-CR] Check that the set raw snapshot timestamp is > 0

2016-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Check that the set raw snapshot timestamp is > 0 .. Patch Set 1: Do we need an equivalent change on the Java side? -- To view, visit

[kudu-CR] tablet copy: Rename TabletCopySession -> TabletCopySourceSession

2016-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tablet copy: Rename TabletCopySession -> TabletCopySourceSession .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5041 To

[kudu-CR] KUDU-1189 scans: reuse snapshot timestamp when not set

2016-11-21 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5143 to look at the new patch set (#5). Change subject: KUDU-1189 scans: reuse snapshot timestamp when not set ..

[kudu-CR] KUDU-798 (part 2) - Always use pre-assigned timestamps in tablet tests

2016-11-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-798 (part 2) - Always use pre-assigned timestamps in tablet tests .. Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/5056/3//COMMIT_MSG

[kudu-CR] [scan] test for reusing snapshot timestamp when not set

2016-11-21 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5163 to look at the new patch set (#2). Change subject: [scan] test for reusing snapshot timestamp when not set ..

[kudu-CR] Check that the set raw snapshot timestamp is > 0

2016-11-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Check that the set raw snapshot timestamp is > 0 .. Patch Set 2: (1 comment) > fuzz-itest used to create snapshots at timestamp 0, which > previously were

[kudu-CR] KUDU-1448. Enable AVX2 bitshuffle at runtime

2016-11-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1448. Enable AVX2 bitshuffle at runtime .. Patch Set 1: (3 comments) Just passing through...

[kudu-CR] [TestSignalStackTrace] scope cleanup for test thread

2016-11-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [TestSignalStackTrace] scope cleanup for test thread .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5171/1/src/kudu/util/debug-util-test.cc File

[kudu-CR] [TestSignalStackTrace] scope cleanup for test thread

2016-11-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [TestSignalStackTrace] scope cleanup for test thread .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5171/1/src/kudu/util/debug-util-test.cc

[kudu-CR] [TestSignalStackTrace] scope cleanup for test thread

2016-11-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#2). Change subject: [TestSignalStackTrace] scope cleanup for test thread .. [TestSignalStackTrace] scope cleanup for test thread Use scope clean-up object to allow the test thread to

[kudu-CR] [TestSignalStackTrace] scope cleanup for test thread

2016-11-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [TestSignalStackTrace] scope cleanup for test thread .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5171 To unsubscribe, visit

[kudu-CR] [WIP][DONT BUILD][spark] - Java Spark API

2016-11-21 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5172 Change subject: [WIP][DONT_BUILD][spark] - Java Spark API .. [WIP][DONT_BUILD][spark] - Java Spark API Currently, the Kudu Spark API

[kudu-CR] KUDU-1448. Enable AVX2 bitshuffle at runtime

2016-11-21 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5166 to look at the new patch set (#2). Change subject: KUDU-1448. Enable AVX2 bitshuffle at runtime ..

[kudu-CR] KUDU-1448. Enable AVX2 bitshuffle at runtime

2016-11-21 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5166 to look at the new patch set (#3). Change subject: KUDU-1448. Enable AVX2 bitshuffle at runtime ..

[kudu-CR] KUDU-1448. Enable AVX2 bitshuffle at runtime

2016-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1448. Enable AVX2 bitshuffle at runtime .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5166/1/src/kudu/cfile/bshuf_block.h File

[kudu-CR] KUDU-1751 (part 1): Change default int encoding to BIT SHUFFLE

2016-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1751 (part 1): Change default int encoding to BIT_SHUFFLE .. Patch Set 1: Code-Review-1 should fix KUDU-1600 before this is committed -- To view, visit

[kudu-CR] Implement fix for KUDU-1493

2016-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Implement fix for KUDU-1493 .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5167/1//COMMIT_MSG Commit Message: Line 7: Implement fix for

[kudu-CR] Change 100M-int cfile tests to use BIT SHUFFLE instead of GROUP VARINT

2016-11-21 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5168 to review the following change. Change subject: Change 100M-int cfile tests to use BIT_SHUFFLE instead of GROUP_VARINT

[kudu-CR] KUDU-1751 (part 1): Change default int encoding to BIT SHUFFLE

2016-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/5169 Change subject: KUDU-1751 (part 1): Change default int encoding to BIT_SHUFFLE .. KUDU-1751 (part 1): Change default int encoding to

[kudu-CR] WIP: KUDU-1751: change default BINARY encoding to DICTIONARY

2016-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/5170 Change subject: WIP: KUDU-1751: change default BINARY encoding to DICTIONARY .. WIP: KUDU-1751: change default BINARY encoding to

[kudu-CR] util: add file cache

2016-11-21 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5146 to look at the new patch set (#3). Change subject: util: add file cache .. util: add file cache This commit

[kudu-CR] [java client] fixed typo in AsyncKuduScanner

2016-11-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5174 Change subject: [java client] fixed typo in AsyncKuduScanner .. [java client] fixed typo in AsyncKuduScanner Removed an extra call to

[kudu-CR] util: add file cache

2016-11-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: util: add file cache .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/5146/2//COMMIT_MSG Commit Message: PS2, Line 41: hareds > shards? Done

[kudu-CR] [TestSignalStackTrace] scope cleanup for test thread

2016-11-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5171 Change subject: [TestSignalStackTrace] scope cleanup for test thread .. [TestSignalStackTrace] scope cleanup for test thread Use scope

[kudu-CR] [TestSignalStackTrace] scope cleanup for test thread

2016-11-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [TestSignalStackTrace] scope cleanup for test thread .. [TestSignalStackTrace] scope cleanup for test thread Use scope clean-up object to allow the

[kudu-CR] util: add file cache

2016-11-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: util: add file cache .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/5146/4/src/kudu/util/file_cache.cc File src/kudu/util/file_cache.cc:

[kudu-CR] KUDU-1751 (part 1): Change default int encoding to BIT SHUFFLE

2016-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1751 (part 1): Change default int encoding to BIT_SHUFFLE .. Patch Set 1: well, these test failures are concerning... various end-to-end test failed with

[kudu-CR] util: add file cache

2016-11-21 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5146 to look at the new patch set (#4). Change subject: util: add file cache .. util: add file cache This commit

[kudu-CR] block manager: start using the file cache

2016-11-21 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new patch set (#3). Change subject: block manager: start using the file cache .. block manager: start using the file cache This commit integrates the file cache into both the file and log block

[kudu-CR] [java-client]: support for Kerberized RPC

2016-11-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java-client]: support for Kerberized RPC .. Patch Set 1: (14 comments) I only really looked at the test changes, so don't consider this a full review (I'm

[kudu-CR] [WIP][spark] - Java Spark API DONT BUILD

2016-11-21 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5172 to look at the new patch set (#2). Change subject: [WIP][spark] - Java Spark API DONT_BUILD .. [WIP][spark] - Java

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Don't output unobservable rows from the MemRowset .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/4994/9//COMMIT_MSG Commit Message: Line 28:

[kudu-CR] env: convert all gscoped ptr usages to unique ptr

2016-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: env: convert all gscoped_ptr usages to unique_ptr .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5145 To unsubscribe, visit

[kudu-CR] env: convert all gscoped ptr usages to unique ptr

2016-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: env: convert all gscoped_ptr usages to unique_ptr .. env: convert all gscoped_ptr usages to unique_ptr This also updates the direct dependents of env, as

[kudu-CR](gh-pages) Add 1.1.0 release docs

2016-11-21 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add 1.1.0 release docs .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5160 To unsubscribe, visit

[kudu-CR](gh-pages) Add 1.1.0 release docs

2016-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add 1.1.0 release docs .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5160 To unsubscribe, visit

[kudu-CR](gh-pages) Add 1.1.0 release docs

2016-11-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Add 1.1.0 release docs .. Add 1.1.0 release docs Change-Id: Ic60915f21f5058d946d420ea104ebee41055bb25 Reviewed-on: http://gerrit.cloudera.org:8080/5160

[kudu-CR](gh-pages) Add 1.1.0 release docs

2016-11-21 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5160 to review the following change. Change subject: Add 1.1.0 release docs .. Add 1.1.0 release docs Change-Id:

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files .. Patch Set 12: (12 comments)

[kudu-CR] Don't output unobservable rows from the MemRowset

2016-11-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Don't output unobservable rows from the MemRowset .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/4994/9//COMMIT_MSG Commit Message: