[kudu-CR] data dirs: be permissive if RefreshIsFull fails

2017-10-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8389 ) Change subject: data_dirs: be permissive if RefreshIsFull fails .. Patch Set 5: TSAN failure seems unrelated. -- To view, visit

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-10-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7439 ) Change subject: mvcc: allow tablet shutdown without completing txs .. Patch Set 20: Have been updating to fix lint / tidybot / iwyu.

[kudu-CR] mvcc: allow tablet shutdown without completing txs

2017-10-26 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Mike Percy, David Ribeiro Alves, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7439 to look at the new patch set (#20). Change subject: mvcc: allow tablet shutdown without completing txs

[kudu-CR] tool: new actions for adding and removing data directories

2017-10-26 Thread Adar Dembo (Code Review)
Adar Dembo has abandoned this change. ( http://gerrit.cloudera.org:8080/8352 ) Change subject: tool: new actions for adding and removing data directories .. Abandoned It's too difficult to do this safely without some more

[kudu-CR] fs: defer failure from metadata load to bootstrap when data dir is missing

2017-10-26 Thread Adar Dembo (Code Review)
Adar Dembo has abandoned this change. ( http://gerrit.cloudera.org:8080/8376 ) Change subject: fs: defer failure from metadata load to bootstrap when data dir is missing .. Abandoned It's too difficult to do this safely, due

[kudu-CR] fs: ensure the existence of important directories on open

2017-10-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8399 ) Change subject: fs: ensure the existence of important directories on open .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] fs: ensure the existence of important directories on open

2017-10-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8399 ) Change subject: fs: ensure the existence of important directories on open .. fs: ensure the existence of important directories on

[kudu-CR] error manager: synchronize/serialize handling

2017-10-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8395 ) Change subject: error_manager: synchronize/serialize handling .. Patch Set 3: (3 comments)

[kudu-CR] fs: defer failure from metadata load to bootstrap when data dir is missing

2017-10-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8376 ) Change subject: fs: defer failure from metadata load to bootstrap when data dir is missing .. Patch Set 2: (1 comment)

[kudu-CR] data dirs: be permissive if RefreshIsFull fails

2017-10-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8389 ) Change subject: data_dirs: be permissive if RefreshIsFull fails .. Patch Set 5: Verified+1 Code-Review+2 Agreed. -- To view, visit

[kudu-CR] data dirs: be permissive if RefreshIsFull fails

2017-10-26 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8389 ) Change subject: data_dirs: be permissive if RefreshIsFull fails .. data_dirs: be permissive if RefreshIsFull fails In testing

[kudu-CR] data dirs: be permissive if RefreshIsFull fails

2017-10-26 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8389 ) Change subject: data_dirs: be permissive if RefreshIsFull fails .. Removed reviewer Kudu Jenkins with the following votes: *

[kudu-CR] tool: new actions for adding and removing data directories

2017-10-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8352 ) Change subject: tool: new actions for adding and removing data directories .. Patch Set 4: (2 comments)

[kudu-CR] tool: new actions for adding and removing data directories

2017-10-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8352 ) Change subject: tool: new actions for adding and removing data directories .. Patch Set 4: (2 comments)

[kudu-CR] thirdparty: bump crcutil hash

2017-10-26 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8390 ) Change subject: thirdparty: bump crcutil hash .. thirdparty: bump crcutil hash The new revision includes a patch that detects gcc

[kudu-CR] error manager: synchronize/serialize handling

2017-10-26 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8395 to look at the new patch set (#3). Change subject: error_manager: synchronize/serialize handling

[kudu-CR] docs: update security doc on --redact flag usage

2017-10-26 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8394 ) Change subject: docs: update security doc on --redact flag usage .. docs: update security doc on --redact flag usage Change-Id:

[kudu-CR] tool: new actions for adding and removing data directories

2017-10-26 Thread Adar Dembo (Code Review)
Hello Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8352 to look at the new patch set (#5). Change subject: tool: new actions for adding and removing data directories

[kudu-CR] fs: ensure the existence of important directories on open

2017-10-26 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8399 Change subject: fs: ensure the existence of important directories on open .. fs: ensure the existence of important directories on open

[kudu-CR] [java client] improve AsyncKuduScanner logging

2017-10-26 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/8382 ) Change subject: [java client] improve AsyncKuduScanner logging .. Patch Set 2: (3 comments)

[kudu-CR] [tools] limit per-session error buffer space

2017-10-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8396 ) Change subject: [tools] limit per-session error buffer space .. Patch Set 3: (4 comments)

[kudu-CR] [java client] improve AsyncKuduScanner logging

2017-10-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8382 ) Change subject: [java client] improve AsyncKuduScanner logging .. Patch Set 2: (1 comment)

[kudu-CR] fs: ensure the existence of important directories on open

2017-10-26 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8399 to look at the new patch set (#2). Change subject: fs: ensure the existence of important directories on open

[kudu-CR] tool: new actions for adding and removing data directories

2017-10-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8352 ) Change subject: tool: new actions for adding and removing data directories .. Patch Set 5: (1 comment)

[kudu-CR] [tools] limit per-session error buffer space

2017-10-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8396 ) Change subject: [tools] limit per-session error buffer space .. Patch Set 3: (4 comments)

[kudu-CR] [tools] limit per-session error buffer space

2017-10-26 Thread Alexey Serbin (Code Review)
Hello Dan Burkert, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8396 to look at the new patch set (#4). Change subject: [tools] limit per-session error buffer space

[kudu-CR] [tools] limit per-session error buffer space

2017-10-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8396 ) Change subject: [tools] limit per-session error buffer space .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] tool: new actions for adding and removing data directories

2017-10-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8352 ) Change subject: tool: new actions for adding and removing data directories .. Patch Set 7: Verified+1 Overriding Jenkins, failures are

[kudu-CR] tool: new actions for adding and removing data directories

2017-10-26 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8352 ) Change subject: tool: new actions for adding and removing data directories .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] [java client] improve AsyncKuduScanner logging

2017-10-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8382 ) Change subject: [java client] improve AsyncKuduScanner logging .. Patch Set 2: (3 comments)

[kudu-CR] consensus: disarm failure detector around elections

2017-10-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8134 ) Change subject: consensus: disarm failure detector around elections .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-1961: enable ccache when using devtoolset-3

2017-10-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8392 ) Change subject: KUDU-1961: enable ccache when using devtoolset-3 .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] fs: ensure the existence of important directories on open

2017-10-26 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8399 ) Change subject: fs: ensure the existence of important directories on open .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] fs: ensure the existence of important directories on open

2017-10-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8399 ) Change subject: fs: ensure the existence of important directories on open .. Patch Set 3: Verified+1 Overriding Jenkins, TSAN failure was

[kudu-CR] KUDU-1961: enable ccache when using devtoolset-3

2017-10-26 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8392 ) Change subject: KUDU-1961: enable ccache when using devtoolset-3 .. KUDU-1961: enable ccache when using devtoolset-3 The original

[kudu-CR] fs: ensure the existence of important directories on open

2017-10-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8399 ) Change subject: fs: ensure the existence of important directories on open .. Patch Set 3: Code-Review+1 -- To view, visit

[kudu-CR] thirdparty: treat cc the same as gcc when building boost

2017-10-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8391 ) Change subject: thirdparty: treat cc the same as gcc when building boost .. thirdparty: treat cc the same as gcc when building

[kudu-CR] thirdparty: treat cc the same as gcc when building boost

2017-10-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8391 ) Change subject: thirdparty: treat cc the same as gcc when building boost .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1961: enable ccache when using devtoolset-3

2017-10-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8392 ) Change subject: KUDU-1961: enable ccache when using devtoolset-3 .. Patch Set 1: (1 comment)

[kudu-CR] [tools] limit per-session error buffer space

2017-10-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8396 ) Change subject: [tools] limit per-session error buffer space .. [tools] limit per-session error buffer space Introduced

[kudu-CR] KUDU-1961: enable ccache when using devtoolset-3

2017-10-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8392 ) Change subject: KUDU-1961: enable ccache when using devtoolset-3 .. Patch Set 1: (1 comment)

[kudu-CR] fs: defer failure from metadata load to bootstrap when data dir is missing

2017-10-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8376 ) Change subject: fs: defer failure from metadata load to bootstrap when data dir is missing .. Patch Set 2: (6 comments)

[kudu-CR] fs: ensure the existence of important directories on open

2017-10-26 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8399 ) Change subject: fs: ensure the existence of important directories on open .. Patch Set 2: (1 comment)

[kudu-CR] fs: ensure the existence of important directories on open

2017-10-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8399 ) Change subject: fs: ensure the existence of important directories on open .. Patch Set 3: (1 comment)

[kudu-CR] [java client] improve AsyncKuduScanner logging

2017-10-26 Thread Hao Hao (Code Review)
Hello Alexey Serbin, Dan Burkert, Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8382 to look at the new patch set (#3). Change subject: [java client] improve AsyncKuduScanner logging

[kudu-CR] fs: ensure the existence of important directories on open

2017-10-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8399 ) Change subject: fs: ensure the existence of important directories on open .. Patch Set 2: Code-Review+1 -- To view, visit

[kudu-CR] fs: ensure the existence of important directories on open

2017-10-26 Thread Adar Dembo (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8399 to look at the new patch set (#3). Change subject: fs: ensure the existence of important directories on open

[kudu-CR] [docs] Document how to recovery from a majority failed tablet

2017-10-26 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8402 Change subject: [docs] Document how to recovery from a majority failed tablet .. [docs] Document how to recovery from a majority failed

[kudu-CR] [docs] Document how to recovery from a majority failed tablet

2017-10-26 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8402 to look at the new patch set (#2). Change subject: [docs] Document how to recovery from a majority failed tablet ..

[kudu-CR] [docs] Document how to recover from a majority failed tablet

2017-10-26 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8402 to look at the new patch set (#3). Change subject: [docs] Document how to recover from a majority failed tablet ..