[kudu-CR] [catalog manager] more info if unable to replace a replica

2018-01-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9040 Change subject: [catalog_manager] more info if unable to replace a replica .. [catalog_manager] more info if unable to replace a replica

[kudu-CR] mini-cluster: rename data root to cluster root

2018-01-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9033 ) Change subject: mini-cluster: rename data_root to cluster_root .. Patch Set 4: Verified+1 The failure was due to a clock sync issue.

[kudu-CR] mini-cluster: rename data root to cluster root

2018-01-16 Thread Andrew Wong (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9033 to look at the new patch set (#4). Change subject: mini-cluster: rename data_root to cluster_root

[kudu-CR] mini-cluster: rename data root to cluster root

2018-01-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9033 ) Change subject: mini-cluster: rename data_root to cluster_root .. Patch Set 3: (1 comment) > Patch Set 3: > > (1 comment)

[kudu-CR] mini-cluster: rename data root to cluster root

2018-01-16 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change. Change subject: mini-cluster: rename data_root to cluster_root .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/9033 To unsubscribe,

[kudu-CR] KUDU-1489: allow configuration of metadata dir

2018-01-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9027 ) Change subject: KUDU-1489: allow configuration of metadata dir .. Patch Set 7: (2 comments)

[kudu-CR] KUDU-1489: allow configuration of metadata dir

2018-01-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9027 ) Change subject: KUDU-1489: allow configuration of metadata dir .. Patch Set 6: (18 comments)

[kudu-CR] KUDU-1489: allow configuration of metadata dir

2018-01-16 Thread Andrew Wong (Code Review)
Hello Tidy Bot, David Ribeiro Alves, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9027 to look at the new patch set (#7). Change subject: KUDU-1489: allow configuration of metadata dir

[kudu-CR] mini-cluster: rename data root to cluster root

2018-01-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9033 ) Change subject: mini-cluster: rename data_root to cluster_root .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2261: The order of the responses after flush should match the order we call apply

2018-01-16 Thread zhen.zhang (Code Review)
zhen.zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9029 Change subject: KUDU-2261: The order of the responses after flush should match the order we call apply .. KUDU-2261: The order of the

[kudu-CR] mini-cluster: rename data root to cluster root

2018-01-16 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9033 Change subject: mini-cluster: rename data_root to cluster_root .. mini-cluster: rename data_root to cluster_root I found that the name

[kudu-CR] KUDU-1489: allow configuration of metadata dir

2018-01-16 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9027 to look at the new patch set (#4). Change subject: KUDU-1489: allow configuration of metadata dir ..

[kudu-CR] rpc: allow setting --rpc tls min protocol on older RHEL versions

2018-01-16 Thread Dan Burkert (Code Review)
Hello Alexey Serbin, Henry Robinson, Adar Dembo, Sailesh Mukil, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7821 to look at the new patch set (#3). Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions

[kudu-CR] KUDU-1913: LIFO wake up ordering for threadpool worker threads

2018-01-16 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9021 ) Change subject: KUDU-1913: LIFO wake up ordering for threadpool worker threads .. Patch Set 1: Code-Review+1 (1 comment)

[kudu-CR] [catalog manager] more info if unable to replace a replica

2018-01-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9040 ) Change subject: [catalog_manager] more info if unable to replace a replica .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-1489: allow configuration of metadata dir

2018-01-16 Thread Andrew Wong (Code Review)
Hello Tidy Bot, David Ribeiro Alves, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9027 to look at the new patch set (#10). Change subject: KUDU-1489: allow configuration of metadata dir

[kudu-CR] KUDU-2261: The order of the responses after flush should match the order we call apply

2018-01-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9029 ) Change subject: KUDU-2261: The order of the responses after flush should match the order we call apply .. Patch Set 1: (5 comments)

[kudu-CR] heavy-update-compaction-itest

2018-01-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9037 ) Change subject: heavy-update-compaction-itest .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] heavy-update-compaction-itest

2018-01-16 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9037 ) Change subject: heavy-update-compaction-itest .. heavy-update-compaction-itest This is an integration test which simulates an

[kudu-CR] [catalog manager] more info if unable to replace a replica

2018-01-16 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9040 to look at the new patch set (#2). Change subject: [catalog_manager] more info if unable to replace a replica

[kudu-CR] [catalog manager] more info if unable to replace a replica

2018-01-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9040 ) Change subject: [catalog_manager] more info if unable to replace a replica .. Patch Set 3: Shouldn't we also periodically print this

[kudu-CR] [catalog manager] more info if unable to replace a replica

2018-01-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9040 ) Change subject: [catalog_manager] more info if unable to replace a replica .. Patch Set 4: > Shouldn't we also periodically print this

[kudu-CR] rpc: allow setting --rpc tls min protocol on older RHEL versions

2018-01-16 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/7821 ) Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. Patch Set 3: I've updated according to Alexey's

[kudu-CR] KUDU-2148: do not crash on GetStatus during server startup

2018-01-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9041 ) Change subject: KUDU-2148: do not crash on GetStatus during server startup .. Patch Set 2: (5 comments) lgtm, just a few nits

[kudu-CR] [catalog manager] more info if unable to replace a replica

2018-01-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9040 ) Change subject: [catalog_manager] more info if unable to replace a replica .. [catalog_manager] more info if unable to replace

[kudu-CR] KUDU-2238. DMS not flush under memory pressure.

2018-01-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8904 ) Change subject: KUDU-2238. DMS not flush under memory pressure. .. Patch Set 2: (1 comment)

[kudu-CR] mini-cluster: rename data root to cluster root

2018-01-16 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9033 ) Change subject: mini-cluster: rename data_root to cluster_root .. mini-cluster: rename data_root to cluster_root I found that

[kudu-CR] KUDU-2148: do not crash on GetStatus during server startup

2018-01-16 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9041 to look at the new patch set (#2). Change subject: KUDU-2148: do not crash on GetStatus during server startup

[kudu-CR] [catalog manager] more info if unable to replace a replica

2018-01-16 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9040 ) Change subject: [catalog_manager] more info if unable to replace a replica .. Patch Set 2: (2 comments)

[kudu-CR] [catalog manager] more info if unable to replace a replica

2018-01-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9040 ) Change subject: [catalog_manager] more info if unable to replace a replica .. Patch Set 2: (2 comments)

[kudu-CR] [catalog manager] more info if unable to replace a replica

2018-01-16 Thread Alexey Serbin (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9040 to look at the new patch set (#3). Change subject: [catalog_manager] more info if unable to replace a replica

[kudu-CR] KUDU-1489: allow configuration of metadata dir

2018-01-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9027 ) Change subject: KUDU-1489: allow configuration of metadata dir .. Patch Set 7: (9 comments) Done, and added a more integration-y test

[kudu-CR] KUDU-1489: allow configuration of metadata dir

2018-01-16 Thread Andrew Wong (Code Review)
Hello Tidy Bot, David Ribeiro Alves, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9027 to look at the new patch set (#8). Change subject: KUDU-1489: allow configuration of metadata dir

[kudu-CR] KUDU-1913: LIFO wake up ordering for threadpool worker threads

2018-01-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9021 ) Change subject: KUDU-1913: LIFO wake up ordering for threadpool worker threads .. Patch Set 1: Code-Review+1 (3 comments)

[kudu-CR] [catalog manager] more info if unable to replace a replica

2018-01-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9040 ) Change subject: [catalog_manager] more info if unable to replace a replica .. Patch Set 3: > Shouldn't we also periodically print this

[kudu-CR] KUDU-2148: do not crash on GetStatus during server startup

2018-01-16 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9041 to review the following change. Change subject: KUDU-2148: do not crash on GetStatus during server startup

[kudu-CR] KUDU-1489: allow configuration of metadata dir

2018-01-16 Thread Andrew Wong (Code Review)
Hello Tidy Bot, David Ribeiro Alves, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9027 to look at the new patch set (#9). Change subject: KUDU-1489: allow configuration of metadata dir

[kudu-CR] KUDU-2261: The order of the responses after flush should match the order we call apply

2018-01-16 Thread zhen.zhang (Code Review)
zhen.zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9029 ) Change subject: KUDU-2261: The order of the responses after flush should match the order we call apply .. Patch Set 1: The test failed

[kudu-CR] consensus: Fix KUDU-1735 regression test in 3-4-3 mode

2018-01-16 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. ( http://gerrit.cloudera.org:8080/9013 ) Change subject: consensus: Fix KUDU-1735 regression test in 3-4-3 mode .. Abandoned Superseded by https://gerrit.cloudera.org/c/8989/ -- To view,

[kudu-CR] rpc: allow setting --rpc tls min protocol on older RHEL versions

2018-01-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/7821 ) Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. Patch Set 3: Code-Review+1 LGTM (deferring to

[kudu-CR](branch-1.4.x) KUDU-2193 (part 2): avoid holding TSTabletManager::lock for a long time

2018-01-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8528 ) Change subject: KUDU-2193 (part 2): avoid holding TSTabletManager::lock_ for a long time .. KUDU-2193 (part 2): avoid holding

[kudu-CR] KUDU-1489: allow configuration of metadata dir

2018-01-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9027 ) Change subject: KUDU-1489: allow configuration of metadata dir .. Patch Set 10: (4 comments)

[kudu-CR](branch-1.5.x) KUDU-2193 (part 2): avoid holding TSTabletManager::lock for a long time

2018-01-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8526 ) Change subject: KUDU-2193 (part 2): avoid holding TSTabletManager::lock_ for a long time .. KUDU-2193 (part 2): avoid holding

[kudu-CR] KUDU-2208 Add RETRY ON EINTR() to Subprocess

2018-01-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9015 ) Change subject: KUDU-2208 Add RETRY_ON_EINTR() to Subprocess .. Patch Set 10: (4 comments)

[kudu-CR] KUDU-1489: allow configuration of metadata dir

2018-01-16 Thread Andrew Wong (Code Review)
Hello Tidy Bot, David Ribeiro Alves, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9027 to look at the new patch set (#11). Change subject: KUDU-1489: allow configuration of metadata dir

[kudu-CR] KUDU-2208 Add RETRY ON EINTR() to Subprocess

2018-01-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9015 ) Change subject: KUDU-2208 Add RETRY_ON_EINTR() to Subprocess .. KUDU-2208 Add RETRY_ON_EINTR() to Subprocess This patch submits

[kudu-CR] KUDU-2208 Add RETRY ON EINTR() to Subprocess

2018-01-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9015 ) Change subject: KUDU-2208 Add RETRY_ON_EINTR() to Subprocess .. Patch Set 12: Code-Review+2 -- To view, visit

[kudu-CR] tools: Add debug mode to pb dump tool

2018-01-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9024 ) Change subject: tools: Add debug mode to pb dump tool .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2208 Add RETRY ON EINTR() to Subprocess

2018-01-16 Thread Jeffrey F. Lukman (Code Review)
Jeffrey F. Lukman has abandoned this change. ( http://gerrit.cloudera.org:8080/9042 ) Change subject: KUDU-2208 Add RETRY_ON_EINTR() to Subprocess .. Abandoned Wrong commit -- To view, visit

[kudu-CR] KUDU-2208 Add RETRY ON EINTR() to Subprocess

2018-01-16 Thread Jeffrey F. Lukman (Code Review)
Jeffrey F. Lukman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9042 Change subject: KUDU-2208 Add RETRY_ON_EINTR() to Subprocess .. KUDU-2208 Add RETRY_ON_EINTR() to Subprocess This patch submits a

[kudu-CR] KUDU-2208 Add RETRY ON EINTR() to Subprocess

2018-01-16 Thread Jeffrey F. Lukman (Code Review)
Jeffrey F. Lukman has posted comments on this change. ( http://gerrit.cloudera.org:8080/9015 ) Change subject: KUDU-2208 Add RETRY_ON_EINTR() to Subprocess .. Patch Set 12: (4 comments)

[kudu-CR] KUDU-2208 Add RETRY ON EINTR() to Subprocess

2018-01-16 Thread Jeffrey F. Lukman (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9015 to look at the new patch set (#12). Change subject: KUDU-2208 Add RETRY_ON_EINTR() to Subprocess ..

[kudu-CR] KUDU-2238. DMS not flush under memory pressure.

2018-01-16 Thread zhen.zhang (Code Review)
zhen.zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8904 ) Change subject: KUDU-2238. DMS not flush under memory pressure. .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2261: The order of the responses after flush should match the order we call apply

2018-01-16 Thread zhen.zhang (Code Review)
Hello Mike Percy, Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9029 to look at the new patch set (#2). Change subject: KUDU-2261: The order of the responses after flush should match the order we call apply

[kudu-CR] KUDU-2195 (part 1): always sync PBC-format metadata files

2018-01-16 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9043 to review the following change. Change subject: KUDU-2195 (part 1): always sync PBC-format metadata files .. KUDU-2195

[kudu-CR] KUDU-2238. DMS not flush under memory pressure.

2018-01-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8904 ) Change subject: KUDU-2238. DMS not flush under memory pressure. .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2238. DMS not flush under memory pressure.

2018-01-16 Thread zhen.zhang (Code Review)
zhen.zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8904 ) Change subject: KUDU-2238. DMS not flush under memory pressure. .. Patch Set 3: (1 comment)

[kudu-CR] rpc: allow setting --rpc tls min protocol on older RHEL versions

2018-01-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/7821 ) Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. Patch Set 3: Code-Review+1 lgtm, please test using

[kudu-CR] KUDU-1489: allow configuration of metadata dir

2018-01-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9027 ) Change subject: KUDU-1489: allow configuration of metadata dir .. Patch Set 11: (4 comments)

[kudu-CR] KUDU-2238. DMS not flush under memory pressure.

2018-01-16 Thread zhen.zhang (Code Review)
Hello Mike Percy, Jean-Daniel Cryans, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8904 to look at the new patch set (#4). Change subject: KUDU-2238. DMS not flush under memory pressure.

[kudu-CR] KUDU-2238. DMS not flush under memory pressure.

2018-01-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8904 ) Change subject: KUDU-2238. DMS not flush under memory pressure. .. Patch Set 4: Code-Review+2 Looks good. Please report back if this

[kudu-CR] tools: Add debug mode to pb dump tool

2018-01-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9024 ) Change subject: tools: Add debug mode to pb dump tool .. Patch Set 1: (5 comments)

[kudu-CR] mini-cluster: rename data root to cluster root

2018-01-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9033 ) Change subject: mini-cluster: rename data_root to cluster_root .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-1489: allow configuration of metadata dir

2018-01-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9027 ) Change subject: KUDU-1489: allow configuration of metadata dir .. Patch Set 5: Sorry, pushed accidentally in conjunction with another

[kudu-CR] KUDU-1489: allow configuration of metadata dir

2018-01-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9027 ) Change subject: KUDU-1489: allow configuration of metadata dir .. Patch Set 6: (18 comments)

[kudu-CR](branch-1.5.x) KUDU-2193 (part 2): avoid holding TSTabletManager::lock for a long time

2018-01-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8526 ) Change subject: KUDU-2193 (part 2): avoid holding TSTabletManager::lock_ for a long time .. Patch Set 1: Code-Review+2 -- To view,

[kudu-CR](branch-1.4.x) KUDU-2193 (part 2): avoid holding TSTabletManager::lock for a long time

2018-01-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8528 ) Change subject: KUDU-2193 (part 2): avoid holding TSTabletManager::lock_ for a long time .. Patch Set 1: Code-Review+2 -- To view,

[kudu-CR] mini-cluster: rename data root to cluster root

2018-01-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9033 ) Change subject: mini-cluster: rename data_root to cluster_root .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-721: Support for Decimal type, Part 1 (Server, C++ Client)

2018-01-16 Thread Grant Henke (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8830 to look at the new patch set (#9). Change subject: KUDU-721: Support for Decimal type, Part 1 (Server, C++ Client)

[kudu-CR] KUDU-721: Support for Decimal type, Part 1 (Server, C++ Client)

2018-01-16 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/8830 ) Change subject: KUDU-721: Support for Decimal type, Part 1 (Server, C++ Client) .. Patch Set 8: (21 comments) Still tweaking the

[kudu-CR] KUDU-721: Support for Decimal type, Part 1 (Server, C++ Client)

2018-01-16 Thread Grant Henke (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8830 to look at the new patch set (#10). Change subject: KUDU-721: Support for Decimal type, Part 1 (Server, C++ Client)

[kudu-CR] KUDU-2202: support for removing data directories (take two)

2018-01-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8978 ) Change subject: KUDU-2202: support for removing data directories (take two) .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2202: support for removing data directories (take two)

2018-01-16 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8978 to look at the new patch set (#5). Change subject: KUDU-2202: support for removing data directories (take two)

[kudu-CR] heavy-update-compaction-itest

2018-01-16 Thread Dan Burkert (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9037 to review the following change. Change subject: heavy-update-compaction-itest ..

[kudu-CR] KUDU-2208 Add RETRY ON EINTR() to Subprocess

2018-01-16 Thread Jeffrey F. Lukman (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9015 to look at the new patch set (#10). Change subject: KUDU-2208 Add RETRY_ON_EINTR() to Subprocess ..

[kudu-CR] KUDU-721: [Java] Add DECIMAL column type support

2018-01-16 Thread Grant Henke (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8882 to look at the new patch set (#4). Change subject: KUDU-721: [Java] Add DECIMAL column type support ..

[kudu-CR] heavy-update-compaction-itest

2018-01-16 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9037 ) Change subject: heavy-update-compaction-itest .. Patch Set 1: Note for reviewers: this test was included in revision 6 of

[kudu-CR] mini-cluster: rename data root to cluster root

2018-01-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9033 ) Change subject: mini-cluster: rename data_root to cluster_root .. Patch Set 1: (1 comment)

[kudu-CR] mini-cluster: rename data root to cluster root

2018-01-16 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9033 to look at the new patch set (#2). Change subject: mini-cluster: rename data_root to cluster_root ..

[kudu-CR] fs: move metadata to the WAL directory

2018-01-16 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9027 to look at the new patch set (#5). Change subject: fs: move metadata to the WAL directory ..

[kudu-CR] KUDU-1489: allow configuration of metadata dir

2018-01-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9027 ) Change subject: KUDU-1489: allow configuration of metadata dir .. Patch Set 4: I think we should merge KUDU-2202 before merging this

[kudu-CR] KUDU-1489: allow configuration of metadata dir

2018-01-16 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9027 to look at the new patch set (#6). Change subject: KUDU-1489: allow configuration of metadata dir

[kudu-CR] rpc: allow setting --rpc tls min protocol on older RHEL versions

2018-01-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/7821 ) Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions .. Patch Set 2: (1 comment)

[kudu-CR] build: Move fake XML file generation to run-test.sh

2018-01-16 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. ( http://gerrit.cloudera.org:8080/8984 ) Change subject: build: Move fake XML file generation to run-test.sh .. Patch Set 3: Code-Review+1 -- To view, visit

[kudu-CR] heavy-update-compaction-itest

2018-01-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9037 ) Change subject: heavy-update-compaction-itest .. Patch Set 1: (3 comments)

[kudu-CR] KUDU-721: Support for Decimal type, Part 1 (Server, C++ Client)

2018-01-16 Thread Grant Henke (Code Review)
Hello Tidy Bot, Alexey Serbin, Dan Burkert, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8830 to look at the new patch set (#11). Change subject: KUDU-721: Support for Decimal type, Part 1 (Server, C++ Client)

[kudu-CR] build: Move fake XML file generation to run-test.sh

2018-01-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8984 ) Change subject: build: Move fake XML file generation to run-test.sh .. Patch Set 3: (1 comment) I can think of another reason why it may

[kudu-CR] WIP [rpc] don't issue authn tokens over non-confidential connections

2018-01-16 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9025 ) Change subject: WIP [rpc] don't issue authn tokens over non-confidential connections .. Patch Set 1: (1 comment) LGTM, I agree about

[kudu-CR] heavy-update-compaction-itest

2018-01-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9037 ) Change subject: heavy-update-compaction-itest .. Patch Set 1: (2 comments)

[kudu-CR] mini-cluster: rename data root to cluster root

2018-01-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9033 ) Change subject: mini-cluster: rename data_root to cluster_root .. Patch Set 3: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-1489: allow configuration of metadata dir

2018-01-16 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9027 ) Change subject: KUDU-1489: allow configuration of metadata dir .. Patch Set 6: (7 comments) first pass. mostly looked at the

[kudu-CR] heavy-update-compaction-itest

2018-01-16 Thread Dan Burkert (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9037 to look at the new patch set (#2). Change subject: heavy-update-compaction-itest

[kudu-CR] heavy-update-compaction-itest

2018-01-16 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9037 ) Change subject: heavy-update-compaction-itest .. Patch Set 1: (5 comments)