[kudu-CR] [metrics] Fix bugs when metrics do merge

2020-01-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/15014 ) Change subject: [metrics] Fix bugs when metrics do merge .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/15014/1//COM

[kudu-CR] KUDU-2973 Normalize table names for Ranger

2020-01-14 Thread Attila Bukor (Code Review)
Hello Kudu Jenkins, Anonymous Coward (314), Adar Dembo, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15018 to look at the new patch set (#3). Change subject: KUDU-2973 Normalize table names for Ranger .

[kudu-CR] KUDU-2973 Normalize table names for Ranger

2020-01-14 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15018 ) Change subject: KUDU-2973 Normalize table names for Ranger .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/15018/2//C

[kudu-CR] [java] KUDU-2971: process communicates via protobuf-based protocol

2020-01-14 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/14329 ) Change subject: [java] KUDU-2971: process communicates via protobuf-based protocol .. Patch Set 8: (4 comments) http://gerrit.clouder

[kudu-CR] [metrics] Fix bugs when metrics do merge

2020-01-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15014 ) Change subject: [metrics] Fix bugs when metrics do merge .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15014/2/src/ku

[kudu-CR] [tools] Support running the master and tablet server via the kudu binary

2020-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12517 ) Change subject: [tools] Support running the master and tablet server via the kudu binary .. Patch Set 23: (1 comment) http://gerrit.

[kudu-CR] [master] KUDU-3016 flag for chunking tablet report updates

2020-01-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14897 ) Change subject: [master] KUDU-3016 flag for chunking tablet report updates .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/

[kudu-CR] KUDU-3005: Reduce size of kudu-python docker image

2020-01-14 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14984 to look at the new patch set (#3). Change subject: KUDU-3005: Reduce size of kudu-python docker image .

[kudu-CR] [tools] Support running the master and tablet server via the kudu binary

2020-01-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12517 ) Change subject: [tools] Support running the master and tablet server via the kudu binary .. Patch Set 25: Code-Review+2 -- To view, vis

[kudu-CR] KUDU-3005: Reduce size of kudu-python docker image

2020-01-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14984 ) Change subject: KUDU-3005: Reduce size of kudu-python docker image .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.clouder

[kudu-CR] [tools] Support running the master and tablet server via the kudu binary

2020-01-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12517 ) Change subject: [tools] Support running the master and tablet server via the kudu binary .. Patch Set 25: Code-Review+2 -- To view, vi

[kudu-CR] KUDU-3005: Reduce size of kudu-python docker image

2020-01-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14984 ) Change subject: KUDU-3005: Reduce size of kudu-python docker image .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloude

[kudu-CR] [docker] Use only the kudu binary in the kudu image

2020-01-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12518 ) Change subject: [docker] Use only the kudu binary in the kudu image .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.clou

[kudu-CR] [docker] Adjust entrypoint variable to be more composable

2020-01-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14993 ) Change subject: [docker] Adjust entrypoint variable to be more composable .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloud

[kudu-CR] [java] KUDU-2971: process communicates via protobuf-based protocol

2020-01-14 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14329 ) Change subject: [java] KUDU-2971: process communicates via protobuf-based protocol .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:

[kudu-CR] [docker] Use only the kudu binary in the kudu image

2020-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12518 ) Change subject: [docker] Use only the kudu binary in the kudu image .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cl

[kudu-CR] [tools] Support running the master and tablet server via the kudu binary

2020-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12517 ) Change subject: [tools] Support running the master and tablet server via the kudu binary .. Patch Set 25: Code-Review+1 -- To view,

[kudu-CR] [docker] Adjust entrypoint variable to be more composable

2020-01-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14993 ) Change subject: [docker] Adjust entrypoint variable to be more composable .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#

[kudu-CR] [docker] Adjust entrypoint variable to be more composable

2020-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14993 ) Change subject: [docker] Adjust entrypoint variable to be more composable .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080

[kudu-CR] [docker] Adjust entrypoint variable to be more composable

2020-01-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14993 ) Change subject: [docker] Adjust entrypoint variable to be more composable .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#

[kudu-CR] [docker] Adjust entrypoint variable to be more composable

2020-01-14 Thread Grant Henke (Code Review)
Grant Henke has removed a vote on this change. Change subject: [docker] Adjust entrypoint variable to be more composable .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/14993 To unsu

[kudu-CR] [docker] Adjust entrypoint variable to be more composable

2020-01-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14993 ) Change subject: [docker] Adjust entrypoint variable to be more composable .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cl

[kudu-CR] [docker] Use only the kudu binary in the kudu image

2020-01-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12518 ) Change subject: [docker] Use only the kudu binary in the kudu image .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.clouder

[kudu-CR] KUDU-3005: Reduce size of kudu-python docker image

2020-01-14 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14984 ) Change subject: KUDU-3005: Reduce size of kudu-python docker image .. KUDU-3005: Reduce size of kudu-python docker image This pa

[kudu-CR] [docker] Use only the kudu binary in the kudu image

2020-01-14 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12518 ) Change subject: [docker] Use only the kudu binary in the kudu image .. [docker] Use only the kudu binary in the kudu image This

[kudu-CR] [tools] Support running the master and tablet server via the kudu binary

2020-01-14 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12517 ) Change subject: [tools] Support running the master and tablet server via the kudu binary .. [tools] Support running the master a

[kudu-CR] [docker] Adjust entrypoint variable to be more composable

2020-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14993 ) Change subject: [docker] Adjust entrypoint variable to be more composable .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080

[kudu-CR] [docker] Adjust entrypoint variable to be more composable

2020-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14993 ) Change subject: [docker] Adjust entrypoint variable to be more composable .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080

[kudu-CR] [tablet] KUDU-3023 validate RPC vs transaction size limit

2020-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15030 Change subject: [tablet] KUDU-3023 validate RPC vs transaction size limit .. [tablet] KUDU-3023 validate RPC vs transaction size limit

[kudu-CR] KUDU-2973 Normalize table names for Ranger

2020-01-14 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15018 ) Change subject: KUDU-2973 Normalize table names for Ranger .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15018/2/src/kudu

[kudu-CR] [master] KUDU-3016 flag for chunking tablet report updates

2020-01-14 Thread Alexey Serbin (Code Review)
Hello Tidy Bot, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14897 to look at the new patch set (#11). Change subject: [master] KUDU-3016 flag for chunking tablet report updates ..

[kudu-CR] [master] KUDU-3016 flag for chunking tablet report updates

2020-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14897 ) Change subject: [master] KUDU-3016 flag for chunking tablet report updates .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:808

[kudu-CR] [docker] Adjust entrypoint variable to be more composable

2020-01-14 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14993 ) Change subject: [docker] Adjust entrypoint variable to be more composable .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#

[kudu-CR] [docker] Adjust entrypoint variable to be more composable

2020-01-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14993 ) Change subject: [docker] Adjust entrypoint variable to be more composable .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit

[kudu-CR] [build] Make IWYU scipts compatible with Python 3

2020-01-14 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15031 Change subject: [build] Make IWYU scipts compatible with Python 3 .. [build] Make IWYU scipts compatible with Python 3 This patch makes m

[kudu-CR] [docker] Adjust entrypoint variable to be more composable

2020-01-14 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14993 ) Change subject: [docker] Adjust entrypoint variable to be more composable .. [docker] Adjust entrypoint variable to be more compo

[kudu-CR] KUDU-3042: Fix invalid DCHECK when rpc is cancelled then times out

2020-01-14 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15032 Change subject: KUDU-3042: Fix invalid DCHECK when rpc is cancelled then times out .. KUDU-3042: Fix invalid DCHECK when rpc i

[kudu-CR] KUDU-3042: Fix invalid DCHECK when rpc is cancelled then times out

2020-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15032 ) Change subject: KUDU-3042: Fix invalid DCHECK when rpc is cancelled then times out .. Patch Set 1: (1 comment) http://gerrit.clouder

[kudu-CR] Integrate BlockBloomFilter with ColumnPredicate on server side

2020-01-14 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15034 Change subject: Integrate BlockBloomFilter with ColumnPredicate on server side .. Integrate BlockBloomFilter with ColumnPredicate on se

[kudu-CR] Use unique ptr instead of shared ptr in BlockBloomFilterTest

2020-01-14 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15033 Change subject: Use unique_ptr instead of shared_ptr in BlockBloomFilterTest .. Use unique_ptr instead of shared_ptr in BlockBloomFilte

[kudu-CR] [build] Make IWYU scipts compatible with Python 3

2020-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15031 ) Change subject: [build] Make IWYU scipts compatible with Python 3 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloud

[kudu-CR] [docker] Adjust entrypoint variable to be more composable

2020-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14993 ) Change subject: [docker] Adjust entrypoint variable to be more composable .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080

[kudu-CR] Use unique ptr instead of shared ptr in BlockBloomFilterTest

2020-01-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15033 ) Change subject: Use unique_ptr instead of shared_ptr in BlockBloomFilterTest .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cl

[kudu-CR] Use unique ptr instead of shared ptr in BlockBloomFilterTest

2020-01-14 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15033 to look at the new patch set (#2). Change subject: Use unique_ptr instead of shared_ptr in BlockBloomFilterTest ...

[kudu-CR] Integrate BlockBloomFilter with ColumnPredicate on server side

2020-01-14 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15034 to look at the new patch set (#2). Change subject: Integrate BlockBloomFilter with ColumnPredicate on server side ..

[kudu-CR] Use unique ptr instead of shared ptr in BlockBloomFilterTest

2020-01-14 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15033 ) Change subject: Use unique_ptr instead of shared_ptr in BlockBloomFilterTest .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:

[kudu-CR] Integrate BlockBloomFilter with ColumnPredicate on server side

2020-01-14 Thread Bankim Bhavsar (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15034 to look at the new patch set (#3). Change subject: Integrate BlockBloomFilter with ColumnPredicate on server side ..

[kudu-CR] [tablet] KUDU-3023 validate RPC vs transaction size limit

2020-01-14 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15030 to look at the new patch set (#2). Change subject: [tablet] KUDU-3023 validate RPC vs transaction size limit .. [ta

[kudu-CR] Use unique ptr instead of shared ptr in BlockBloomFilterTest

2020-01-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15033 ) Change subject: Use unique_ptr instead of shared_ptr in BlockBloomFilterTest .. Patch Set 2: Code-Review+2 -- To view, visit http://ger

[kudu-CR] Use unique ptr instead of shared ptr in BlockBloomFilterTest

2020-01-14 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15033 ) Change subject: Use unique_ptr instead of shared_ptr in BlockBloomFilterTest .. Use unique_ptr instead of shared_ptr in BlockBloo

[kudu-CR] [master] KUDU-3016 flag for chunking tablet report updates

2020-01-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14897 ) Change subject: [master] KUDU-3016 flag for chunking tablet report updates .. Patch Set 11: Code-Review+2 -- To view, visit http://gerri

[kudu-CR] [tablet] KUDU-3023 validate RPC vs transaction size limit

2020-01-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15030 ) Change subject: [tablet] KUDU-3023 validate RPC vs transaction size limit .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.

[kudu-CR] [master] KUDU-3016 flag for chunking tablet report updates

2020-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14897 ) Change subject: [master] KUDU-3016 flag for chunking tablet report updates .. [master] KUDU-3016 flag for chunking tablet repor

[kudu-CR] [java] KUDU-2971: process communicates via protobuf-based protocol

2020-01-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14329 ) Change subject: [java] KUDU-2971: process communicates via protobuf-based protocol .. Patch Set 8: (1 comment) http://gerrit.cloudera.o

[kudu-CR] KUDU-2971 p2: add basic protobuf msg

2020-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14426 ) Change subject: KUDU-2971 p2: add basic protobuf msg .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] [tablet] KUDU-3023 validate RPC vs transaction size limit

2020-01-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15030 ) Change subject: [tablet] KUDU-3023 validate RPC vs transaction size limit .. [tablet] KUDU-3023 validate RPC vs transaction siz

[kudu-CR] Integrate BlockBloomFilter with ColumnPredicate on server side

2020-01-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15034 ) Change subject: Integrate BlockBloomFilter with ColumnPredicate on server side .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8

[kudu-CR] [metrics] Fix bugs when metrics do merge

2020-01-14 Thread Yingchun Lai (Code Review)
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/15014 ) Change subject: [metrics] Fix bugs when metrics do merge .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15014/2/src/

[kudu-CR] [build] Make IWYU scipts compatible with Python 3

2020-01-14 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15031 ) Change subject: [build] Make IWYU scipts compatible with Python 3 .. [build] Make IWYU scipts compatible with Python 3 This patc

[kudu-CR] KUDU-3011 p5: transfer leadership when quiescing

2020-01-14 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15012 to look at the new patch set (#4). Change subject: KUDU-3011 p5: transfer leadership when quiescing ...

[kudu-CR] KUDU-3011 p6: don't transfer leadership to quiescing followers

2020-01-14 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15035 Change subject: KUDU-3011 p6: don't transfer leadership to quiescing followers .. KUDU-3011 p6: don't transfer leadership to quiescing fol

[kudu-CR] KUDU-3011 p5: transfer leadership when quiescing

2020-01-14 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15012 to look at the new patch set (#5). Change subject: KUDU-3011 p5: transfer leadership when quiescing ...

[kudu-CR] KUDU-3011 p5: transfer leadership when quiescing

2020-01-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15012 ) Change subject: KUDU-3011 p5: transfer leadership when quiescing .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/15012